On Tue, 19 Jan 2021 22:23:38 GMT, Chris Plummer wrote:
>> Hi,
>> may I please ask the community to review this small fix? It closes another
>> hole in AsyncGetCallTrace().
>> Thanks a lot!
>> Lutz
>
> The changes look ok to me. I think it would be good to get someone from the
> compiler team t
On Tue, 19 Jan 2021 23:16:30 GMT, David Holmes wrote:
> What do you mean by this? The -J args are not "translated" here but later in
> TranslateApplicationArgs.
I meant that they are translated in TranslateApplicationArgs. Looks like it's
not clear. Updated the comment as you suggested.
-
> The fix adds NMT handling for non-java launchers
Alex Menkov has updated the pull request incrementally with one additional
commit since the last revision:
Updated comment
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/2106/files
- new: https://git.openjdk.java.net
On Tue, 19 Jan 2021 23:02:54 GMT, Alex Menkov wrote:
>> The fix adds NMT handling for non-java launchers
>
> Alex Menkov has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Non-lava launchers should process all "-J" arguments
Hi Alex,
I think
On Sun, 17 Jan 2021 12:55:35 GMT, David Holmes wrote:
>> Alex Menkov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Non-lava launchers should process all "-J" arguments
>
> Alex,
>
> This approach results in two scans of the argument l
On Sun, 17 Jan 2021 12:55:35 GMT, David Holmes wrote:
>> Alex Menkov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Non-lava launchers should process all "-J" arguments
>
> Alex,
>
> This approach results in two scans of the argument l
> The fix adds NMT handling for non-java launchers
Alex Menkov has updated the pull request incrementally with one additional
commit since the last revision:
Non-lava launchers should process all "-J" arguments
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/2106/files
Hi Chris,
thank you for your review.
Per your request/recommendation, I'll cross-post to hotspot-compiler-dev.
On the other hand, I've been working recently in just that corner of
CodeHeap/CodeCache. As the access to VM data structures via AsyncGetCallTrace()
is asynchronous (the name suggest
See the bug for most details. A few notes here about some implementation
details:
In the `PointerLocation` class, I added more consistency w.r.t. whether or not
a newline is printed. It used to for some address types, but not others. Now it
always does. And if you see a comment something like t
On Mon, 11 Jan 2021 18:39:41 GMT, Lutz Schmidt wrote:
> Hi,
> may I please ask the community to review this small fix? It closes another
> hole in AsyncGetCallTrace().
> Thanks a lot!
> Lutz
The changes look ok to me. I think it would be good to get someone from the
compiler team to verify yo
On Tue, 19 Jan 2021 05:43:12 GMT, Lin Zang wrote:
>> 8257234 : Add gz option to SA jmap to write a gzipped heap dump
>
> Lin Zang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> code refine
src/jdk.hotspot.agent/share/classes/sun/jvm/hotsp
On Tue, 19 Jan 2021 12:39:12 GMT, Lin Zang wrote:
>> 8257234 : Add gz option to SA jmap to write a gzipped heap dump
>
> Lin Zang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fix issue of setting gz option with no value
I think you need
On Tue, 19 Jan 2021 10:14:14 GMT, Severin Gehwolf wrote:
>> This patch adds some explicit capacity for local refs. New regression test
>> fails prior and passes after the patch.
>>
>> Thoughts?
>
> Severin Gehwolf has updated the pull request with a new target base due to a
> merge or a rebase.
> 8257234 : Add gz option to SA jmap to write a gzipped heap dump
Lin Zang has updated the pull request incrementally with one additional commit
since the last revision:
fix issue of setting gz option with no value
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/1712/fi
On Mon, 18 Jan 2021 14:10:56 GMT, Severin Gehwolf wrote:
> This patch adds some explicit capacity for local refs. New regression test
> fails prior and passes after the patch.
>
> Thoughts?
Thanks for the review! More thoughts?
-
PR: https://git.openjdk.java.net/jdk/pull/2130
On Tue, 19 Jan 2021 09:41:27 GMT, Aleksey Shipilev wrote:
>> Severin Gehwolf has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>>
On Mon, 18 Jan 2021 23:06:07 GMT, David Holmes wrote:
>> Severin Gehwolf has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>> comm
> This patch adds some explicit capacity for local refs. New regression test
> fails prior and passes after the patch.
>
> Thoughts?
Severin Gehwolf has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in b
On Mon, 18 Jan 2021 14:10:56 GMT, Severin Gehwolf wrote:
> This patch adds some explicit capacity for local refs. New regression test
> fails prior and passes after the patch.
>
> Thoughts?
test/jdk/com/sun/management/DiagnosticCommandMBean/DcmdMBeanTestCheckJni.java
line 38:
> 36: public cla
> I saw the exception as following when I chose "Monitor Cache Dump" menu on
> HSDB:
>
> Exception in thread "AWT-EventQueue-0" java.lang.ExceptionInInitializerError
> at
> jdk.hotspot.agent/sun.jvm.hotspot.ui.MonitorCacheDumpPanel.dumpOn(MonitorCacheDumpPanel.java:92)
> at
> jd
On Tue, 19 Jan 2021 06:27:27 GMT, David Holmes wrote:
>> Yasumasa Suenaga has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains three commits:
>>
>> - Fix comments
>> - Merge
>> - 8259008: ArithmeticException was thrown at "Monitor C
On Tue, 19 Jan 2021 05:43:12 GMT, Lin Zang wrote:
>> 8257234 : Add gz option to SA jmap to write a gzipped heap dump
>
> Lin Zang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> code refine
src/jdk.hotspot.agent/share/classes/sun/jvm/hotsp
22 matches
Mail list logo
