On Thu, 4 Feb 2021 07:37:03 GMT, Hamlin Li wrote:
>>> I am not reviewer, but maybe you could add test for "parallel" in
>>> BasicJMapTest.java.
>>
>> That test is for the `jmap` command, not the `GC.class_histogram` jcmd. As I
>> pointed out, there are tests in
On Thu, 4 Feb 2021 03:40:26 GMT, Chris Plummer wrote:
>> Hi @Hamlin-Li
>> I am not reviewer, but maybe you could add test for "parallel" in
>> BasicJMapTest.java.
>
>> I am not reviewer, but maybe you could add test for "parallel" in
>> BasicJMapTest.java.
>
> That test is for the `jmap`
On Wed, 3 Feb 2021 12:44:53 GMT, Hamlin Li wrote:
> parallel -histo of jmap was added by JDK-8214535, it's better to support
> parallel for jcmd GC.class_histogram too.
> Hi @Hamlin-Li
> I am not reviewer, but maybe you could add test for "parallel" in
> BasicJMapTest.java.
Hi @linzang ,
On Wed, 3 Feb 2021 21:28:40 GMT, Chris Plummer wrote:
>> Hamlin Li has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> JDK-8261034: improve jcmd GC.class_histogram to support parallel
>
> src/hotspot/share/services/diagnosticCommand.cpp
> parallel -histo of jmap was added by JDK-8214535, it's better to support
> parallel for jcmd GC.class_histogram too.
Hamlin Li has updated the pull request incrementally with one additional commit
since the last revision:
JDK-8261034: improve jcmd GC.class_histogram to support parallel
8261131: jcmd jmap dump should not accept gz option with no value
-
Commit messages:
- 8261131: jcmd jmap dump should not accept gz option with no value
Changes: https://git.openjdk.java.net/jdk/pull/2399/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=2399=00
Issue:
> parallel -histo of jmap was added by JDK-8214535, it's better to support
> parallel for jcmd GC.class_histogram too.
Hamlin Li has updated the pull request incrementally with one additional commit
since the last revision:
JDK-8261034: improve jcmd GC.class_histogram to support parallel
On Fri, 29 Jan 2021 05:39:59 GMT, Lin Zang wrote:
>> 8257234 : Add gz option to SA jmap to write a gzipped heap dump
>
> Lin Zang has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - fix an issue of double printing error message.
> - fix
On Thu, 4 Feb 2021 03:17:28 GMT, Lin Zang wrote:
> IMO, there can be two ways which may help solve the compatibility issue of
> introducing "parallel" option:
>
> * unblock socket with timeout. In this way, old Jmap could work with new
> JDK, but it maybe complicated because of different
On Thu, 4 Feb 2021 03:40:26 GMT, Chris Plummer wrote:
> > I am not reviewer, but maybe you could add test for "parallel" in
> > BasicJMapTest.java.
>
> That test is for the `jmap` command, not the `GC.class_histogram` jcmd. As I
> pointed out, there are tests in
On Thu, 4 Feb 2021 02:58:52 GMT, Lin Zang wrote:
> I am not reviewer, but maybe you could add test for "parallel" in
> BasicJMapTest.java.
That test is for the `jmap` command, not the `GC.class_histogram` jcmd. As I
pointed out, there are tests in `test/hotpot/jtreg/serviceability/dcmd/gc`
On Thu, 28 Jan 2021 22:33:53 GMT, Chris Plummer wrote:
>> Lin Zang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix the logic of using gz= as file name
>
> You added clhsdb testing to ClhsdbDumpheap.java, but I had also suggested
>
On Wed, 3 Feb 2021 22:02:04 GMT, Chris Plummer wrote:
>> Hi Lin, When I suggested that it would ok just to just always use the
>> default number of parallel threads, I wasn't considering that we also have
>> `jmap -histo`, which also supports parallel threads, but includes an
>> argument to
On Wed, 3 Feb 2021 12:44:53 GMT, Hamlin Li wrote:
> parallel -histo of jmap was added by JDK-8214535, it's better to support
> parallel for jcmd GC.class_histogram too.
Hi @Hamlin-Li
I am not reviewer, but maybe you could add test for "parallel" in
BasicJMapTest.java.
-
PR:
On Thu, 4 Feb 2021 01:17:48 GMT, Jesper Wilhelmsson
wrote:
> Forwardport JDK 16 -> JDK 17
This pull request has now been integrated.
Changeset: 9b7a8f19
Author:Jesper Wilhelmsson
URL: https://git.openjdk.java.net/jdk/commit/9b7a8f19
Stats: 2645 lines in 56 files changed: 2497
Forwardport JDK 16 -> JDK 17
-
Commit messages:
- Merge
- 8259794: Remove EA from JDK 16 version string starting with Initial RC
promotion on Feb 04, 2021(B35)
- 8260704: ParallelGC: oldgen expansion needs release-store for _end
- 8260927: StringBuilder::insert is incorrect
> The test expects debuggee output in jdb output stream.
> But jdb redirects debuggee output asynchronously so sometimes it's incomplete
> or mixed with jdb output.
> The fix updates debuggee to print output to file and read/analyze it after
> jdb (and debuggee) exits.
Alex Menkov has updated
On Wed, 3 Feb 2021 23:13:12 GMT, Bernhard Urban-Forster
wrote:
>> No idea how to insert spaces and make text align :-(
>
> using ` ```c `
> https://docs.github.com/en/github/writing-on-github/creating-and-highlighting-code-blocks
>
> I was wrong about `SIGFPE` / `EXC_MASK_ARITHMETIC`, it's
On Wed, 3 Feb 2021 22:48:33 GMT, Gerard Ziemski wrote:
>> I don't like the idea of using masks on architectures that do not require
>> them. How about something like this?
>>
>> `#if defined(__APPLE__)`
>> ` // lldb (gdb) installs both standard BSD signal handlers, and mach
>> exception`
>>
On Wed, 3 Feb 2021 22:17:02 GMT, Bernhard Urban-Forster
wrote:
>> To answer my own question, it seems that code is still needed on `x86_64`
>> for `lldb` with `EXC_MASK_BAD_ACCESS` or we keep tripping over
>> `EXC_BAD_ACCESS`
>>
>> Remaining questions:
>>
>> a) why we need
On Wed, 3 Feb 2021 22:44:18 GMT, Gerard Ziemski wrote:
>> Thanks for your questions Gerard.
>>
>>> Part of the comment said This work-around is not necessary for 10.5+, as
>>> CrashReporter no longer intercedes on caught fatal signals.
>>
>> That comment can probably be deleted since
On Wed, 3 Feb 2021 22:17:03 GMT, Alex Menkov wrote:
>> The test expects debuggee output in jdb output stream.
>> But jdb redirects debuggee output asynchronously so sometimes it's
>> incomplete or mixed with jdb output.
>> The fix updates debuggee to print output to file and read/analyze it
On Wed, 3 Feb 2021 22:17:03 GMT, Alex Menkov wrote:
>> The test expects debuggee output in jdb output stream.
>> But jdb redirects debuggee output asynchronously so sometimes it's
>> incomplete or mixed with jdb output.
>> The fix updates debuggee to print output to file and read/analyze it
On Tue, 2 Feb 2021 23:37:21 GMT, Yasumasa Suenaga wrote:
> We could see NPE on `LinuxCDebugger::loadObjectContainingPC` which is used
> mainly by the clhsdb `findpc` command. (See
> [JDK-8248876](https://bugs.openjdk.java.net/browse/JDK-8248876) for more
> details)
>
> It is caused by PIE
On Wed, 3 Feb 2021 20:29:48 GMT, Gerard Ziemski wrote:
>> Part of the comment said `This work-around is not necessary for 10.5+, as
>> CrashReporter no longer intercedes on caught fatal signals.` so I thought it
>> was no longer needed, but it sounds like the part about `gdb` still applies
>>
> The test expects debuggee output in jdb output stream.
> But jdb redirects debuggee output asynchronously so sometimes it's incomplete
> or mixed with jdb output.
> The fix updates debuggee to print output to file and read/analyze it after
> jdb (and debuggee) exits.
Alex Menkov has updated
On Wed, 3 Feb 2021 21:52:00 GMT, Chris Plummer wrote:
>> Dear All,
>> I have updated the patch and remove the introduction of new "parallel"
>> option. So there can be no backward-compatibility issue for jmap -dump
>> command. May I ask your help to remove the CSR label if agreed?
>>
>>
On Thu, 28 Jan 2021 22:40:57 GMT, Phil Race wrote:
> This removes the JNF dependency from the jdk.hotspot.agent module.
> The macro expansions are the same as already used in the Java desktop module
> - which actually uses a macro
> still but there there are hundreds of uses.
> The function of
On Wed, 3 Feb 2021 02:19:43 GMT, Lin Zang wrote:
>> Hi All,
>> As discussed in this PR, it is reasonable to enable parallel heap dump by
>> default rather than introducing a new "parallel" option. I would like to
>> close the CSR at https://bugs.openjdk.java.net/browse/JDK-8260424.
>
> Dear
On Wed, 3 Feb 2021 12:44:53 GMT, Hamlin Li wrote:
> parallel -histo of jmap was added by JDK-8214535, it's better to support
> parallel for jcmd GC.class_histogram too.
I think you'll need a CSR just as
[JDK-8215624](https://bugs.openjdk.java.net/browse/JDK-8215624). Also, a test
is needed.
On Wed, 3 Feb 2021 20:17:03 GMT, Phil Race wrote:
>> This removes the JNF dependency from the jdk.hotspot.agent module.
>> The macro expansions are the same as already used in the Java desktop module
>> - which actually uses a macro
>> still but there there are hundreds of uses.
>> The function
On Wed, 3 Feb 2021 20:04:18 GMT, Gerard Ziemski wrote:
>> See comment above about `gdb`, the same applies to `lldb` today. The AArch64
>> backend uses `SIGILL` (~= `EXC_MASK_BAD_INSTRUCTION`) to initiate a
>> deoptimization. Without this change you cannot continue debugging once you
>> the
> This removes the JNF dependency from the jdk.hotspot.agent module.
> The macro expansions are the same as already used in the Java desktop module
> - which actually uses a macro
> still but there there are hundreds of uses.
> The function of this macro code is to prevent NSExceptions escaping
On Tue, 2 Feb 2021 20:27:17 GMT, Chris Plummer wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8257988: Remove JNF dependency from libsaproc/MacosxDebuggerLocal.m
>
>
On Wed, 3 Feb 2021 09:14:24 GMT, Andrew Haley wrote:
>> src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp line 5271:
>>
>>> 5269: //
>>> 5270: void MacroAssembler::get_thread(Register dst) {
>>> 5271: RegSet saved_regs = RegSet::range(r0, r1) +
>>> BSD_ONLY(RegSet::range(r2, r17)) + lr -
On Wed, 3 Feb 2021 19:57:24 GMT, Anton Kozlov wrote:
>> For platform files that were copied from other ports to this port, if the
>> file wasn't
>> changed I presume the copyright years are left alone. If the file required
>> changes
>> for this port, I expect the year to be updated to 2021.
On Tue, 2 Feb 2021 19:23:16 GMT, Bernhard Urban-Forster
wrote:
>> src/hotspot/os/posix/signals_posix.cpp line 1297:
>>
>>> 1295: kern_return_t kr;
>>> 1296: kr = task_set_exception_ports(mach_task_self(),
>>> 1297: EXC_MASK_BAD_ACCESS |
>>>
On Tue, 2 Feb 2021 23:03:45 GMT, Daniel D. Daugherty wrote:
>> Anton Kozlov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> support macos_aarch64 in hsdis
>
> src/hotspot/share/runtime/thread.cpp line 3991:
>
>> 3989: JavaThread*
On Tue, 2 Feb 2021 18:00:06 GMT, Gerard Ziemski wrote:
>> Anton Kozlov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> support macos_aarch64 in hsdis
>
> src/hotspot/cpu/aarch64/interpreterRT_aarch64.cpp line 390:
>
>> 388:
On Tue, 26 Jan 2021 12:01:30 GMT, Coleen Phillimore wrote:
>> I assume a WXVerifier class that tracks W^X mode in debug mode and does
>> nothing in release mode. I've considered to do this, it's relates to small
>> inefficiencies, while this patch brings zero overhead (in release) for a
>>
On Tue, 26 Jan 2021 12:50:22 GMT, Anton Kozlov wrote:
>> Yes, that's why I thought it should be added to the classes
>> ThreadInVMfromNative, etc like:
>> class ThreadInVMfromNative : public ThreadStateTransition {
>> ResetNoHandleMark __rnhm;
>>
>> We can look at it with cleaning up the
On Wed, 3 Feb 2021 20:05:29 GMT, Anton Kozlov wrote:
>> Thank you all for your comments regarding W^X implementation. I've made a
>> change that reduces the footprint of the implementation, also addressing
>> most of the comments. I'll revisit them individually to make sure nothing is
>>
> Please review the implementation of JEP 391: macOS/AArch64 Port.
>
> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
> windows/aarch64.
>
> Major changes are in:
> * src/hotspot/cpu/aarch64: support of the new calling convention (subtasks
> JDK-8253817, JDK-8253818)
On Tue, 2 Feb 2021 23:10:17 GMT, Daniel D. Daugherty wrote:
>> Anton Kozlov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> support macos_aarch64 in hsdis
>
> For platform files that were copied from other ports to this port, if the
>
On Wed, 3 Feb 2021 12:04:00 GMT, Roland Westrelin wrote:
>> test/lib/jdk/test/lib/process/ProcessTools.java line 461:
>>
>>> 459: }
>>> 460:
>>> 461: static public class OutputAnalyzerAndPID {
>>
>> can we either change `OutputAnalyzer` to store pid (and use -1 for cases
>> when
On Wed, 3 Feb 2021 05:45:02 GMT, Igor Ignatyev wrote:
>> Roland Westrelin has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains seven additional
>>
> 8252842: Extend jmap to support parallel heap dump
Lin Zang has updated the pull request incrementally with one additional commit
since the last revision:
Fix logic in thread number calculation and code refine
-
Changes:
- all:
On 2021-02-02 21:47, Chris Plummer wrote:
Is there a reason why `java.desktop` continues to use `JNFJavaToNSString`? I
was looking to see how this was handled in other places, but I couldn't find an
example where `JNFJavaToNSString` was converted to call a newly implemented
On Tue, 2 Feb 2021 21:49:36 GMT, Daniel D. Daugherty wrote:
>> Anton Kozlov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> support macos_aarch64 in hsdis
>
> src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp line 323:
>
>> 321:
On Tue, 2 Feb 2021 18:03:50 GMT, Gerard Ziemski wrote:
>> Anton Kozlov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> support macos_aarch64 in hsdis
>
> src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp line 5271:
>
>> 5269: //
>>
50 matches
Mail list logo
