v
>
> Hi Shafi,
>
> I agree with David.
> Consider it reviewed if you add the initialization of ebuf.
>
> Thanks,
> Serguei
>
>
> On 3/31/18 00:24, David Holmes wrote:
> > Hi Shafi,
> >
> > On 29/03/2018 7:11 PM, Shafi Ahmad wrote:
> >>
Hi,
Please review the backport of ' JDK-8165736: Error message should be shown when
JVMTI agent cannot be attached' to jdk8u-dev.
Please note that this is not a clean backport because we can't not backport
native jtreg tests as infrastructure of naive jtreg test has been available
since JDK
Hi,
Could someone please review it.
Regards,
Shafi
> -Original Message-
> From: Shafi Ahmad
> Sent: Monday, January 29, 2018 6:02 PM
> To: serviceability-dev@openjdk.java.net
> Subject: [8u] RFR for 'JDK-8195088: [TEST_BUG] StartManagementAgent got
> unexpected
Hi,
Please review the trivial code change for the fix of 'JDK-8195088: [TEST_BUG]
StartManagementAgent got unexpected exception' to jdk8u-dev.
Summary:
This test case is expected to fail but the expected exception message is
different.
This fix
-if
To: David Holmes <david.hol...@oracle.com>; Shafi Ahmad
<shafi.s.ah...@oracle.com>
Cc: serviceability-dev@openjdk.java.net
Subject: Re: [10] RFR for JDK-8170299: Debugger does not stop inside the low
memory notifications code [internal]
On 12/11/17 9:32 PM, David Holmes wrote:
H
I will send the updated webrev after incorporating the review comment.
Regards,
Shafi
From: mandy chung
Sent: Tuesday, December 12, 2017 2:35 AM
To: Shafi Ahmad <shafi.s.ah...@oracle.com>
Cc: serviceability-dev@openjdk.java.net
Subject: Re: [10] RFR for JDK-8170299: Debugger d
with the service
thread, which is a hidden thread.
shafi@shafi-ahmad:~/Java/jdk8/jdk8u-dev$ jdb -Xmx32m MemoryWarningSystem
Initializing jdb ...
> stop at MemoryWarningSystem$1:25
Deferring breakpoint MemoryWarningSystem$1:25.
It will be set after the class is loaded.
> ru
Thank you David.
Regards,
Shafi
> -Original Message-
> From: David Holmes
> Sent: Thursday, November 02, 2017 11:55 AM
> To: Shafi Ahmad <shafi.s.ah...@oracle.com>; Daniel Fuchs
> <daniel.fu...@oracle.com>; serviceability-dev@openjdk.java.net
> Subject: Re
Hi All,
May get the second review for this backport.
Regards,
Shafi
> -Original Message-
> From: Daniel Fuchs
> Sent: Wednesday, October 25, 2017 2:34 PM
> To: Shafi Ahmad <shafi.s.ah...@oracle.com>; serviceability-
> d...@openjdk.java.net
> Cc: David Holmes
Hi Daniel,
Thank you for the review.
Regards,
Shafi
> -Original Message-
> From: Daniel Fuchs
> Sent: Wednesday, October 25, 2017 2:34 PM
> To: Shafi Ahmad <shafi.s.ah...@oracle.com>; serviceability-
> d...@openjdk.java.net
> Cc: David Holmes <david.hol...@ora
Hi,
Please review the backport of "JDK-8177721: Improve diagnostics in
sun.management.Agent#startAgent()" to jdk8u-dev.
The backport is not clean as I got the below conflict.
shshahma@slc12kkg:/scratch/shshahma/Java/jdk8u-dev/jdk$ cat
src/share/classes/sun/management/Agent.java.rej
---
chung
Sent: Tuesday, September 12, 2017 2:19 AM
To: Shafi Ahmad <shafi.s.ah...@oracle.com>; serviceability-dev@openjdk.java.net
Cc: Poonam Parhar <poonam.ba...@oracle.com>
Subject: Re: [10] RFR for JDK-8170299: Debugger does not stop inside the low
memory notifications code
Gentle reminder.
Regards,
Shafi
From: Shafi Ahmad
Sent: Thursday, September 07, 2017 11:43 AM
To: Daniel Daugherty <daniel.daughe...@oracle.com>;
serviceability-dev@openjdk.java.net
Subject: RE: [10] RFR for JDK-8170299: Debugger does not stop inside the low
memory notific
:
-Djmx-registry.port=
test result: Failed. Execution failed: `main' threw exception:
java.lang.RuntimeException: Specify port with system property:
-Djmx-registry.port=
Regards,
Shafi
From: Daniel D. Daugherty
Sent: Tuesday, September 05, 2017 10:36 PM
To: Shafi Ahmad <shafi.s
Dan
On 9/4/17 4:11 AM, Shafi Ahmad wrote:
Hi,
Please review the fix for ‘JDK-8170299:
Debugger does not stop inside the low memory notifications
code’ to jdk10.
Hi,
Please review the fix for 'JDK-8170299: Debugger does not stop inside the low
memory notifications code' to jdk10.
With the current implementation 'debugger does not stop inside the low memory
*notifications* code'
This is expected as the notification code is getting executed with
Thank you Serguei.
Regards,
Shafi
> -Original Message-
> From: Serguei Spitsyn
> Sent: Thursday, August 24, 2017 12:49 AM
> To: Shafi Ahmad <shafi.s.ah...@oracle.com>; serviceability-
> d...@openjdk.java.net
> Cc: Langer, Christoph <christoph.lan...
Hi,
Please review the backport of bug: "JDK-8169961: Memory leak after debugging
session" to jdk8u-dev
Please note that this is not a clean backport due to small conflict -
shshahma@slc12kkg:/scratch/shshahma/Java/jdk8u-dev-base/jdk$ cat
src/share/classes/com/sun/tools/jdi/TargetVM.java.rej
, 2017 12:27 AM
> To: Daniel Daugherty <daniel.daughe...@oracle.com>; Shafi Ahmad
> <shafi.s.ah...@oracle.com>; serviceability-dev@openjdk.java.net
> Cc: Roger Calnan <roger.cal...@oracle.com>
> Subject: Re: [10] RFR for JDK-8169961: Memory leak after debugging session
&g
May I get it reviewed by serviceability team.
Regards,
Shafi
> -Original Message-
> From: Shafi Ahmad
> Sent: Wednesday, July 26, 2017 8:26 AM
> To: serviceability-dev@openjdk.java.net
> Cc: Roger Calnan <roger.cal...@oracle.com>
> Subject: RE: [10] RFR for
Hi,
> -Original Message-
> From: Langer, Christoph [mailto:christoph.lan...@sap.com]
> Sent: Monday, July 17, 2017 9:01 PM
> To: Poonam Parhar <poonam.ba...@oracle.com>
> Cc: Shafi Ahmad <shafi.s.ah...@oracle.com>; serviceability-
> d...@openjdk.java.net
&
Hi Daniel,
> -Original Message-
> From: Langer, Christoph [mailto:christoph.lan...@sap.com]
> Sent: Monday, July 17, 2017 6:44 PM
> To: Shafi Ahmad <shafi.s.ah...@oracle.com>; Daniel Daugherty
> <daniel.daughe...@oracle.com>
> Cc: serviceability-dev@openj
Hi Daniel,
Thank you for the review.
> -Original Message-
> From: Daniel D. Daugherty
> Sent: Friday, July 14, 2017 6:46 AM
> To: Shafi Ahmad <shafi.s.ah...@oracle.com>; serviceability-
> d...@openjdk.java.net
> Subject: Re: [10] RFR for JDK-8169961: Memory leak
Hi Daniel,
Thank you for the review.
> -Original Message-
> From: Daniel D. Daugherty
> Sent: Thursday, July 13, 2017 7:40 PM
> To: Shafi Ahmad <shafi.s.ah...@oracle.com>; serviceability-
> d...@openjdk.java.net
> Subject: Re: [10] RFR for JDK-8169961: Memory leak
Hi Christoph,
Thank you for reviewing.
Regards,
Shafi
> -Original Message-
> From: Langer, Christoph [mailto:christoph.lan...@sap.com]
> Sent: Thursday, July 13, 2017 4:16 PM
> To: Shafi Ahmad <shafi.s.ah...@oracle.com>
> Cc: serviceability-dev@openjdk.java.net
&g
Hi,
Please review the code change for the fix of bug 'JDK-8169961: Memory leak
after debugging session'
Summary:
1. It seems that the thread created for
com.sun.tools.jdi.TargetVM.EventController is never stopped and keeps a hard
reference to the VirtualMachineImpl. This leads to
> Sent: Thursday, April 27, 2017 2:35 AM
> To: Shafi Ahmad <shafi.s.ah...@oracle.com>; Poonam Parhar
> <poonam.ba...@oracle.com>; Daniel Fuchs <daniel.fu...@oracle.com>;
> serviceability-dev@openjdk.java.net; hotspot-runtime-
> d...@openjdk.java.net
> Subject: Re: [jdk10]
s <daniel.fu...@oracle.com>; David Holmes
> <david.hol...@oracle.com>; Shafi Ahmad <shafi.s.ah...@oracle.com>;
> serviceability-dev@openjdk.java.net; hotspot-runtime-
> d...@openjdk.java.net
> Subject: RE: [jdk10] RFR for 'JDK-8177721: Improve diagnostics in
> sun.m
Hi,
Please review the trivial code change for the fix of 'JDK-8177721: Improve
diagnostics in sun.management.Agent#startAgent()' to jdk10.
Summary:
In method exportMBeanServer of
sun/management/jmxremote/ConnectorBootstrap.java, we wrap IOException in
AgentConfigurationError.
But in
Sending it to runtime alias too.
Please note that the changes in the test case are done only for testing
purpose. It will not be a part of final checkin.
Any way attached webrev don't have this change.
Regards,
Shafi
-Original Message-
From: Shafi Ahmad
Sent: Wednesday, April 12
30 matches
Mail list logo
