Re: CFV: New Serviceability Group Lead: Serguei Spitsyn

2017-04-14 Thread Tomas Hurka
ions, see [3]. > > Thanks, > Daniel Daugherty > > [1]: http://openjdk.java.net/bylaws#group-lead > [2]: http://openjdk.java.net/census#serviceability > [3]: http://openjdk.java.net/groups#lead-vote -- Tomas Hurka <mailto:tomas.hu...@oracle.com> NetBeans Profiler http://profiler.netbeans.org VisualVM http://visualvm.github.io Software Developer Oracle, Praha Czech Republic

Re: Nashorn and JVMTI

2014-10-02 Thread Tomas Hurka
Hi Attila, JVMTI error 62 is caused by bug in JDK. See <https://netbeans.org/bugzilla/show_bug.cgi?id=245522> -- Tomas Hurka <mailto:tomas.hu...@oracle.com> NetBeans Profiler http://profiler.netbeans.org VisualVM http://visualvm.java.net Software Developer Oracle, Praha Czech Rep

RFR: 8009204 : [dtrace] signatures returned by Java 7 jstack() are corrupted on Solaris

2013-06-28 Thread Tomas Hurka
ally backport of JDK-7019165 to jhelper.d. Webrev: <http://cr.openjdk.java.net/~thurka/8009204/webrev.00/> I tested the fix using above D-script on latest JDK 8 and JDK 7u sources. Thanks, -- Tomas Hurka <mailto:tomas.hu...@oracle.com> NetBeans Profiler http://profiler.netbeans.org

Re: SA frontends

2012-02-24 Thread Tomas Hurka
t on java.net and I think members of the project having > contributor role should be able to contribute to the project. In addition to SA-Plugin, VisualVM uses SA when working with the core dumps. It is also uses SA as a last resort for getting data (system properties, thread dump, etc.) from

hg: jdk7/hotspot-rt/hotspot: 7007254: NullPointerException occurs with jvisualvm placed under a dir. including Japanese chars

2011-04-16 Thread tomas . hurka
Changeset: fcc932c8238c Author:thurka Date: 2011-04-16 11:59 +0200 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/fcc932c8238c 7007254: NullPointerException occurs with jvisualvm placed under a dir. including Japanese chars Summary: use java_lang_String::create_from_pl

Re: code review for CR7007254

2011-03-31 Thread Tomas Hurka
idea to change it for JDK 7 at this time So Alan and Kelly, what do you think? Are you OK with this 'incremental improvement to the platform encoding support'? Thanks. On 4 Jan 2011, at 14:05, Tomas Hurka wrote: > Hello, > I would like to as for review of the fix f

Re: code review for CR7007254

2011-01-04 Thread Tomas Hurka
Hi Alan, On 4 Jan 2011, at 15:29, Tomas Hurka wrote: > On 4 Jan 2011, at 15:05, Alan Bateman wrote: > >> Tomas Hurka wrote: >>> Hello, >>> I would like to as for review of the fix for CR7007254 - A >>> NullPointerException occurs with jvisualvm placed und

Re: code review for CR7007254

2011-01-04 Thread Tomas Hurka
Hi Alan, On 4 Jan 2011, at 15:05, Alan Bateman wrote: > Tomas Hurka wrote: >> Hello, >> I would like to as for review of the fix for CR7007254 - A >> NullPointerException occurs with jvisualvm placed under a dir. including >> Japanese chars. >> >> Web

code review for CR7007254

2011-01-04 Thread Tomas Hurka
. The Linux part is done differently at sun.tools.attach.LinuxVirtualMachine.execute() and encodes Attach API command and arguments in UTF-8. Thanks, -- Tomas Hurka <mailto:tomas.hu...@oracle.com> NetBeans Profiler http://profiler.netbeans.org VisualVM http://visualvm.dev.java.net Software Developer Oracle, Praha Czech Republic

hg: jdk7/hotspot-rt/hotspot: 6765718: Indicate which thread throwing OOME when generating the heap dump at OOME

2010-09-12 Thread tomas . hurka
Changeset: 30f67acf635d Author:thurka Date: 2010-09-11 08:18 +0200 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/30f67acf635d 6765718: Indicate which thread throwing OOME when generating the heap dump at OOME Summary: Emit a fake frame that makes it look like the thre

Re: Review request: 6765718: Indicate which thread throwing OOME when generating the heap dump at OOME

2010-09-10 Thread Tomas Hurka
Hi Dan, On 10 Sep 2010, at 15:22, Daniel D. Daugherty wrote: >> The new webrev with above changes is here: >> <http://cr.openjdk.java.net/~thurka/6765718/webrev.02> > > Thumbs up on the latest webrev. Thanks for the review. Bye, -- Tomas Hurka <mailto:tomas.hu...

Re: Review request: 6765718: Indicate which thread throwing OOME when generating the heap dump at OOME

2010-09-10 Thread Tomas Hurka
> Please send this changeset to RT_Baseline through JPRT when you're > ready. OK, I will do it. The new webrev with above changes is here: <http://cr.openjdk.java.net/~thurka/6765718/webrev.02> Bye, -- Tomas Hurka <mailto:tomas.hu...@sun.com> NetBeans Profiler http://profi

Review request: 6765718: Indicate which thread throwing OOME when generating the heap dump at OOME

2010-09-06 Thread Tomas Hurka
the thread throwing OOME. Webrev is here: http://cr.openjdk.java.net/~thurka/6765718/webrev.01/ Thanks in advance for the review, -- Tomas Hurka <mailto:tomas.hu...@sun.com> NetBeans Profiler http://profiler.netbeans.org VisualVM http://visualvm.dev.java.net Software Engineer, Dev

Re: 6950927: Testcase failure sun/management/jmxremote/bootstrap/JvmstatCountersTest.java

2010-06-01 Thread Tomas Hurka
s/linux/vm/attachListener_linux.cpp:459:// or /tmp then this is the trigger to start the attach mechanism but this is in different repository, so I am not sure if you can change these comments in one commit together with above changes. Bye, -- Tomas Hurka <mailto:tomas.hu...@sun.com> N

Re: Hotspot Debugger on Mac OS X Java 1.6 32-bit

2010-02-03 Thread Tomas Hurka
e to Mac OS X 10.6. It supports Java 6 on 32-bit Core Duo processor. Bye, -- Tomas Hurka <mailto:tomas.hu...@sun.com> NetBeans Profiler http://profiler.netbeans.org VisualVM http://visualvm.dev.java.net Software Engineer, Developer Platforms Group Sun Microsystems, Praha Czech Republic

hg: jdk7/tl/jdk: 6858708: HotspotDiagnosticMXBean.setVMOption() throws NullPointerException

2009-11-16 Thread tomas . hurka
Changeset: 16bce7ce4fc9 Author:thurka Date: 2009-11-16 15:33 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/16bce7ce4fc9 6858708: HotspotDiagnosticMXBean.setVMOption() throws NullPointerException Summary: Add a null check for the VM option string Reviewed-by: mchung, ohair !

Re: Review request for 6858708: HotspotDiagnosticMXBean.setVMOption() throws NullPointerException

2009-11-13 Thread Tomas Hurka
Hi Mandy and Kelly, On 13 Nov 2009, at 18:26, Mandy Chung wrote: The fix looks good. Thanks for fixing it. Thanks for the review! I'll file a RFE to rewrite sun.management.Flag to support different types. OK. -- Tomas Hurka <mailto:tomas.hu...@sun.com> NetBeans Pr

Review request for 6858708: HotspotDiagnosticMXBean.setVMOption() throws NullPointerException

2009-11-13 Thread Tomas Hurka
recognized as String. I also added test. In general it is not very nice that sun.management.Flag uses value of the flag to detect its type so maybe whole code should be rewritten to explicitly specify type of the flag. Thanks, -- Tomas Hurka <mailto:tomas.hu...@sun.com> NetBeans Profile

VisualVM 1.2 Released!

2009-10-21 Thread Tomas Hurka
the latest NetBeans Platform and profiler 6.7.1 This release also extends the API for plugins and fixes several bugs. See the Release Notes for list of all changes: https://visualvm.dev.java.net/relnotes.html. The bits can be downloaded at https://visualvm.dev.java.net. VisualVM Team -- Tomas

Re: Improve root set used by hat

2009-10-07 Thread Tomas Hurka
t remember how "roots" is filled. May be, these static fields should not be flagged as roots? I think this is in hat only, since HeapWalker in Java VIsualVM does it correctly. Bye, -- Tomas Hurka <mailto:tomas.hu...@sun.com> NetBeans Profiler http://profiler.

Re: JVMTI OOM handling when arrays / objects are too large

2009-06-15 Thread Tomas Hurka
Hi Jeremy, On 15 Jun 2009, at 09:53, Jeremy Manson wrote: FWIW, I also think that having a call to new throw anything that isn't an OOME is opening up a much larger compatibility can of worms than anything else I intended with this patch. I understand. Bye, -- Tomas Hurka <mailto:

Re: JVMTI OOM handling when arrays / objects are too large

2009-06-15 Thread Tomas Hurka
arrays of any nonnegative integral size, no? Sure, it does. Bye, -- Tomas Hurka <mailto:tomas.hu...@sun.com> NetBeans Profiler http://profiler.netbeans.org VisualVM http://visualvm.dev.java.net Software Engineer, Developer Platforms Group Sun Microsystems, Praha Czech Republic

Re: JVMTI OOM handling when arrays / objects are too large

2009-06-15 Thread Tomas Hurka
I think it will be better to separate them to the different changeset. Bye, -- Tomas Hurka <mailto:tomas.hu...@sun.com> NetBeans Profiler http://profiler.netbeans.org VisualVM http://visualvm.dev.java.net Software Engineer, Developer Platforms Group Sun Microsystems, Praha Czech Republic

hg: jdk7/hotspot-rt/hotspot: 6839599: JVM crash while profiling Tomcat and Liferay

2009-05-20 Thread tomas . hurka
Changeset: 47ffceb239d0 Author:thurka Date: 2009-05-20 09:36 +0200 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/47ffceb239d0 6839599: JVM crash while profiling Tomcat and Liferay Summary: constantPoolOopDesc::copy_cpool_bytes() - do the brute-force search search thro

hg: jdk7/tl/jdk: 6790467: Add test for setInterval() for local MonitoredHost and local MonitoredVm

2009-01-07 Thread tomas . hurka
Changeset: 0bd360988b3a Author:thurka Date: 2009-01-07 14:06 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0bd360988b3a 6790467: Add test for setInterval() for local MonitoredHost and local MonitoredVm Summary: test for MonitoredHost.setInterval() and MonitoredVm.setInterva

hg: jdk7/hotspot-svc/hotspot: 2 new changesets

2008-08-15 Thread tomas . hurka
Changeset: f3a650d8df24 Author:thurka Date: 2008-08-14 21:05 +0200 URL: http://hg.openjdk.java.net/jdk7/hotspot-svc/hotspot/rev/f3a650d8df24 6625846: Export system property java.version via jvmstat Summary: java.version added to property_counters_ss array Reviewed-by: swamyv ! src/

hg: jdk7/tl/jdk: 6672135: setInterval() for local MonitoredHost and local MonitoredVm does not work

2008-07-25 Thread tomas . hurka
Changeset: 7b7d051e3b96 Author:thurka Date: 2008-07-25 12:40 +0200 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7b7d051e3b96 6672135: setInterval() for local MonitoredHost and local MonitoredVm does not work Summary: super.setInterval() invoked with correct value Reviewed-by: sw