On Mon, 9 May 2022 15:56:35 GMT, Adam Sotona wrote:
> Please review this patch adding new lint option, **lossy-conversions**, to
> javac to warn about type casts in compound assignments with possible lossy
> conversions.
>
> The new lint warning is shown if the type of the right-hand operand o
On Thu, 5 May 2022 09:35:42 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview).
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in the HotSpot VM are disabled by default an
On Tue, 26 Apr 2022 22:24:26 GMT, Joe Darcy wrote:
> To enable more complete doclint checking (courtesy @jonathan-gibbons), please
> review this PR to add type-level @param tags where they are missing.
>
> To the maintainers of java.util.concurrent, those changes could be separat
tenance of that code.
>
> Making these library fixes is a blocker for correcting and expanding the
> doclint checks (JDK-8285496).
>
> I'll update copyright years before pushing.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The increm
tenance of that code.
>
> Making these library fixes is a blocker for correcting and expanding the
> doclint checks (JDK-8285496).
>
> I'll update copyright years before pushing.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last
On Thu, 28 Apr 2022 08:10:38 GMT, Alan Bateman wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Respond to more review feedback.
>
> src/java.base/share/classes/java/nio/file/Wat
On Thu, 28 Apr 2022 08:08:37 GMT, Alan Bateman wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Respond to more review feedback.
>
> src/java.base/share/classes/java/nio/file/Secu
On Wed, 27 Apr 2022 23:24:57 GMT, Stuart Marks wrote:
>> I said "keys maintained", omitting "by this map" to finesse the question of
>> if the SimpleEntry class *is* a map, or is used to implement a map, etc. I
>> can change it to include "by this map" if the map/entry distinction is okay
>> t
tenance of that code.
>
> Making these library fixes is a blocker for correcting and expanding the
> doclint checks (JDK-8285496).
>
> I'll update copyright years before pushing.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last
tenance of that code.
>
> Making these library fixes is a blocker for correcting and expanding the
> doclint checks (JDK-8285496).
>
> I'll update copyright years before pushing.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The increm
On Wed, 27 Apr 2022 10:55:22 GMT, Daniel Fuchs wrote:
>> Joe Darcy has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains three
On Wed, 27 Apr 2022 10:54:00 GMT, Daniel Fuchs wrote:
>> To enable more complete doclint checking (courtesy @jonathan-gibbons),
>> please review this PR to add type-level @param tags where they are missing.
>>
>> To the maintainers of java.util.concurrent, those changes could be separated
>> o
On Wed, 27 Apr 2022 01:39:27 GMT, Stuart Marks wrote:
>> To enable more complete doclint checking (courtesy @jonathan-gibbons),
>> please review this PR to add type-level @param tags where they are missing.
>>
>> To the maintainers of java.util.concurrent, those changes could be separated
>> o
To enable more complete doclint checking (courtesy @jonathan-gibbons), please
review this PR to add type-level @param tags where they are missing.
To the maintainers of java.util.concurrent, those changes could be separated
out in another bug if that would ease maintenance of that code.
Making
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
Marked as reviewed by darcy (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/7268
On Tue, 1 Feb 2022 16:19:01 GMT, Pavel Rappo wrote:
> While looking into guts of javadoc comment inheritance, I noticed that a
> number of places in JDK seem to confuse JLS 8.4.6.** with JLS 8.4.8.**.
>
> Granted, "8.4.6 Method Throws" tangentially addresses overriding. However, I
> believe th
On Sat, 22 Jan 2022 21:09:03 GMT, Joe Darcy wrote:
> Use presumed syntax that will be introduced by JDK-8280488.
This pull request has now been integrated.
Changeset: 8e82d002
Author: Joe Darcy
URL:
https://git.openjdk.java.net/jdk/commit/8e82d0021c119b7793870811fad37d7659c11
> Use presumed syntax that will be introduced by JDK-8280488.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase. The pull request contains three additional commits si
On Mon, 24 Jan 2022 11:33:18 GMT, Pavel Rappo wrote:
> > Use presumed syntax that will be introduced by JDK-8280488.
>
> Is that a wrong bug? If you are talking about module-prefix syntax for links,
> then it was introduced in JDK 15; JDK-8164408: Add module support for @see,
> @link and @link
On Sat, 22 Jan 2022 21:09:03 GMT, Joe Darcy wrote:
> Use presumed syntax that will be introduced by JDK-8280488.
This should be the (near) final step to fully enable all doclint checks during
the javac portion of the build. The "reference" doclint check is currently
disabled
Use presumed syntax that will be introduced by JDK-8280488.
-
Commit messages:
- JDK-8280492: Address remaining doclint issues in JDK build
Changes: https://git.openjdk.java.net/jdk/pull/7189/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=7189&range=00
Issue: https:/
On Sun, 5 Dec 2021 23:45:32 GMT, Joe Darcy wrote:
> Exploratory builds indicate it is not currently necessary to exclude the
> doclint accessibility checks; this patch enables them.
>
> (Enabling the reference checks is left for future work.)
This pull request has now bee
Exploratory builds indicate it is not currently necessary to exclude the
doclint accessibility checks; this patch enables them.
(Enabling the reference checks is left for future work.)
-
Commit messages:
- JDK-8278273: Remove unnecessary exclusion of doclint accessibility checks
C
On Thu, 18 Nov 2021 21:51:30 GMT, Brent Christian wrote:
> Here are the code changes for the "Deprecate finalizers in the standard Java
> API" portion of JEP 421 ("Deprecate Finalization for Removal") for code
> review.
>
> This change makes the indicated deprecations, and updates the API spec
On Wed, 13 Oct 2021 19:58:43 GMT, Joe Darcy wrote:
> After a refinement to the checks under development in #5709, the new checks
> examine array types of serial fields and warn if the underlying component
> type is not serializable. Per the JLS, all array types are serializable, but
After a refinement to the checks under development in #5709, the new checks
examine array types of serial fields and warn if the underlying component type
is not serializable. Per the JLS, all array types are serializable, but if the
base component is not serializable, the serialization process
On Tue, 5 Oct 2021 21:39:52 GMT, Daniel D. Daugherty wrote:
> A trivial fix to ProblemList
> resourcehogs/serviceability/sa/TestHeapDumpForLargeArray.java
> on macosx-x64.
Marked as reviewed by darcy (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/5829
On Mon, 27 Sep 2021 21:49:06 GMT, Joe Darcy wrote:
> Follow-up change to JDK-8232442, augmentations to javac's Xlint:serial
> checking are out for review (#5709) and various management libraries would
> need some changes to pass under the expanded checks.
>
> The cha
s in
> serializable types are not declared with a type statically known to be
> serializable. That isn't necessarily a correctness issues, but it does merit
> further scrutiny.
>
> I'll run a script to update copyright years before a push.
Joe Darcy has updated the pull req
On Thu, 30 Sep 2021 09:56:45 GMT, Serguei Spitsyn wrote:
>
>
> Looks good. Thanks, Serguei
Thanks Serguei, I'll add some explanatory comments and check for any needed
copyright updates before pushing.
-
PR: https://git.openjdk.java.net/jdk/pull/5726
Follow-up change to JDK-8232442, augmentations to javac's Xlint:serial checking
are out for review (#5709) and various management libraries would need some
changes to pass under the expanded checks.
The changes are to suppress warnings where non-transient fields in serializable
types are not de
This is an initial PR for expanded lint warnings done under two bugs:
8202056: Expand serial warning to check for bad overloads of serial-related
methods and ineffectual fields
8160675: Issue lint warning for non-serializable non-transient instance fields
in serializable type
to get feedback on
On Thu, 23 Sep 2021 16:45:30 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList 2 serviceability/dcmd/gc tests with ZGC on
> linux-all and windows-all.
Marked as reviewed by darcy (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/5657
On Thu, 5 Aug 2021 19:20:50 GMT, Jonathan Gibbons wrote:
> Please review a semi-automatic update of the nroff man pages from the
> upstream files.
Marked as reviewed by darcy (Reviewer).
-
PR: https://git.openjdk.java.net/jdk17/pull/303
On Thu, 22 Jul 2021 21:51:30 GMT, Daniel D. Daugherty
wrote:
> Trivial fixes:
> JDK-8271165 ProblemList serviceability/dcmd/gc/HeapDumpAllTest.java on X64
> JDK-8271166 ProblemList applications/jcstress/copy.java on Linux-X64
Marked as reviewed by darcy (Reviewer).
-
PR: https://g
On Wed, 30 Jun 2021 17:27:00 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList sun/management/jdp/JdpDefaultsTest.java on
> Linux-aarch64.
Marked as reviewed by darcy (Reviewer).
-
PR: https://git.openjdk.java.net/jdk17/pull/182
On 6/21/2021 2:02 PM, Paul Sandoz wrote:
On Mon, 21 Jun 2021 05:17:09 GMT, Yi Yang wrote:
After JDK-8265518(#3615), it's possible to replace all variants of checkIndex
by Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in
the whole JDK codebase.
Yi Yang has updated th
On Mon, 17 May 2021 18:23:41 GMT, Weijun Wang wrote:
> Please review this implementation of [JEP
> 411](https://openjdk.java.net/jeps/411).
>
> The code change is divided into 3 commits. Please review them one by one.
>
> 1.
> https://github.com/openjdk/jdk/commit/576161d15423f58281e384174d28
On Thu, 22 Apr 2021 20:32:33 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList
> serviceability/sa/sadebugd/DisableRegistryTest.java on ZGC.
Marked as reviewed by darcy (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/3641
On Wed, 24 Mar 2021 23:17:46 GMT, Joe Darcy wrote:
> 8264148: Update spec for exceptions retrofitted for exception chaining
This pull request has now been integrated.
Changeset: 815248ab
Author: Joe Darcy
URL: https://git.openjdk.java.net/jdk/commit/815248ab
Stats: 84 lines in
On 3/30/2021 6:29 AM, Roger Riggs wrote:
On Wed, 24 Mar 2021 23:17:46 GMT, Joe Darcy wrote:
8264148: Update spec for exceptions retrofitted for exception chaining
I agree that the public field in WriteAbortedException could be remediated.
But it is also mostly harmless.
src
On 3/30/2021 6:43 AM, jmehrens wrote:
On Wed, 24 Mar 2021 23:17:46 GMT, Joe Darcy wrote:
8264148: Update spec for exceptions retrofitted for exception chaining
src/java.base/share/classes/java/io/WriteAbortedException.java line 86:
84: @Override
85: public Throwable getCause
On Thu, 25 Mar 2021 18:52:54 GMT, Stuart Marks wrote:
>> 8264148: Update spec for exceptions retrofitted for exception chaining
>
> The removal of the obsolescent "As of release 1.4, this exception has been
> retrofitted..." is good. Changing the calls from the other exception-getting
> methods
8264148: Update spec for exceptions retrofitted for exception chaining
-
Commit messages:
- Respond to review feedback.
- Respond to review feedback.
- Merge branch 'master' into 8264148
- Merge branch 'master' into 8264148
- 8264148: Update spec for exceptions retrofitted for ex
On Thu, 22 Oct 2020 17:16:23 GMT, Jonathan Gibbons wrote:
> The change is (just) to remove legacy usages of a JDK-private custom tag.
Marked as reviewed by darcy (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/814
On Mon, 21 Sep 2020 21:36:39 GMT, Vicente Romero wrote:
>> Co-authored-by: Vicente Romero
>> Co-authored-by: Harold Seigel
>> Co-authored-by: Jonathan Gibbons
>> Co-authored-by: Brian Goetz
>> Co-authored-by: Maurizio Cimadamore
>> Co-authored-by: Joe Dar
Hello,
Another module, another set of default constructors to replace with
explicit ones. Please review the code changes and CSR to address:
JDK-8250640: Address reliance on default constructors in jdk.jdi
webrev: http://cr.openjdk.java.net/~darcy/8250640.0/
CSR: https://bugs.openj
Hello,
I'm not positive serviceability-dev is the best alias for this review;
if not, please direct me elsewhere.
In any case, please review the changes and CSR for:
JDK-8250583: Address reliance on default constructors in
java.management
webrev: http://cr.openjdk.java.net/~darcy/82
+1
-Joe
On 6/18/2020 4:00 PM, Jonathan Gibbons wrote:
Please review a trivial fix for an invalid @see tag in
java/lang/management/package.html.
The presumed intent of the original is not a supported variant. The
fix is to remove the
`{@linkplain ...}` wrapper.
-- Jon
JBS: https://bugs.openj
Hello,
On 4/16/2020 5:47 AM, Magnus Ihse Bursie wrote:
[snip]
The tricky one here is the helper TableModelComparator. This one took
me a while to wrap my head around. It implements Comparator, but the
compare() method takes "rows" from the model, which are just expressed
as Objects, and left t
Looks fine Magnus; thanks,
-Joe
On 4/15/2020 1:18 AM, Magnus Ihse Bursie wrote:
In the quest for getting rid of warning messages in jdk.hotspot.agent,
the time has now come for another major source of deprecation
messages, that are trivial to fix and might hide more tricky issues.
This patch
Serguei or others working directly in java.management, any other
comments on these changes?
Thanks,
-Joe
On 10/17/2019 3:58 PM, Joe Darcy wrote:
Hi Roger,
I would certainly be in favor of a more thorough review of the use of
serialization in the management modules by the serviceability
them transient, but
SuppressWarnings
calls more attention to them as fields that are being serialized, even
indirectly.
The presence of a writeReplace method weakens the coupling of the
fields to the serialized values.
Roger
On 10/16/19 10:31 PM, Joe Darcy wrote:
Hello,
Quick background
Hello,
Please review a serial warning update of three exceptions types in the
jdk.jdi module.
JDK-8232448: Suppress warnings on non-serializable non-transient
instance fields in jdk.jdi
http://cr.openjdk.java.net/~darcy/8232448.0/
These exception classes are generally not written to
Hello,
Quick background, ahead of strengthening javac's -Xlint:serial checks to
include more aspects of a Serializable or Externalizable type (
JDK-8160675 ), I've been working through the JDK libraries to review
issue found by the upcoming analysis (JDK-8231641).
The latest segment of the l
Hello,
For more information about CSR, see the wiki page:
https://wiki.openjdk.java.net/display/csr
and the slides from the February 2019 OCW in Brussels:
http://cr.openjdk.java.net/~darcy/Presentations/OCW/ocw-CSR-2019-02.pdf
The backup slides from the presentation include some informati
Yes, if you make yourself the assignee, you can change the state of the
request (and then change the assignee back to the original person).
HTH,
-Joe
On 2/12/2019 7:38 AM, Daniel Fuchs wrote:
Hi Paul,
On 12/02/2019 16:27, Hohensee, Paul wrote:
I don't see a way to change the Status from Clos
Looks fine; thanks,
-Joe
On 8/10/2016 11:30 PM, John Jiang wrote:
Hi,
Please review another updated webrev:
http://cr.openjdk.java.net/~jjiang/8160611/webrev.02/
com/sun/jdi/JdbMethodExitTest.sh 8031555 generic-all
The above line shouldn't be removed, and 8031555 should be replaced by
690212
On 4/22/2016 1:09 AM, Alan Bateman wrote:
On 22/04/2016 09:06, Amy Lu wrote:
Please review this tiny fix for typos in the the documentation of:
jdk/src/jdk.jlink/share/classes/jdk/tools/jlink/plugin/Pool.java
jdk/src/jdk.jdi/share/classes/com/sun/jdi/VirtualMachineManager.java
bug: https://b
Hi Igor,
The change to the test list in and of itself looks fine. Once some
stable subset of the svc tests can be committed to, it would be good to
have them back in tier 2.
Thanks,
-Joe
On 2/11/2016 1:03 PM, Igor Ignatyev wrote:
http://cr.openjdk.java.net/~iignatyev/8149700/webrev.00/
2
Hello,
The test
sun/management/jmxremote/bootstrap/RmiSslBootstrapTest.sh
has recently been seen to fail frequently on various platforms. Until
the root cause is addressed (JDK-8145919), the test should be placed on
the problem list.
Please review the patch below which does this,
Thank
Looks fine Amy; thanks,
-Joe
On 12/20/2015 8:53 PM, Amy Lu wrote:
sun/management/jmxremote/startstop/JMXStartStopTest.java
sun/tools/jstatd/TestJstatdServer.java
Above tests are known to fail intermittently, this patch is to mark
the test accordingly with keyword 'intermittent'.
bug: https:
Hello,
With the most recent integration of HotSpot into dev, we started seeing
test failures of
sun/tools/jhsdb/BasicLauncherTest.java
The underlying problem has been fixed by JDK-8132648 in hs-rt, but until
that fix propagates, the test should be problem listed in dev:
diff -r 9bce83
Hello,
Yes, my general guidance is to make sure flaky tests are marked as
"intermittent" in the test itself. This lets someone running the test
easily check if the test is known to be unreliable *in that state of the
sources*.
There is a upfront overhead to collecting information about the c
On 4/23/2015 10:58 PM, Alan Bateman wrote:
On 24/04/2015 02:54, Joseph D. Darcy wrote:
Hello,
Any additional comments on marking with tests in question with a
"randomness" keyword?
Thanks,
-Joe
I don't object to this keyword although I should say that most of the
(apparent) randomness tha
Hi Daniel,
On 4/22/2015 1:31 AM, Daniel Fuchs wrote:
On 22/04/15 04:13, Joseph D. Darcy wrote:
One goal of marking the tests using randomness is to help root out some
remaining intermittent test failures. If one of the randomness tests is
observed to fail intermittently, if it has not already b
Hello,
As the test sun/management/jmxremote/bootstrap/RmiSslBootstrapTest.sh
has been failing for several days across platforms, I think the time has
come to mark the test as ignored until the full fix for related bug
JDK-8077924:
sun/management/jmxremote/bootstrap/RmiSslBootstrapTest.sh
Hello,
While trying to turn on doclint checking in the build on more modules,
it came to my attention that various parts of the javax.management
package are missing javadoc. Please review the straightforward changes
to add the missing javadoc:
JDK-8077923: Add missing doclint in javax.ma
Hello,
We've observed two serviceability tests failing on mac platforms; I'd
like to put those tests on the problem list while the underlying causes
are under investigation:
http://cr.openjdk.java.net/~darcy/8072371.0/
Patch below.
Thanks,
-Joe
--- old/test/ProblemList.txt2015-02-
Hello,
Please review the patch below which addresses
JDK-8066634: Suppress deprecation warnings in java.management module
Thanks,
-Joe
diff -r 913808eaf19a
src/java.management/share/classes/com/sun/jmx/interceptor/DefaultMBeanServerInterceptor.java
---
a/src/java.management/share/classe
Hello,
Please review the small patch below to fix
JDK-8066636: Suppress deprecation warnings in the jdk.jvmstat and
jdk.jdi modules
Thanks,
-Joe
diff -r 913808eaf19a
src/jdk.jdi/share/classes/com/sun/tools/example/debug/expr/ExpressionParser.java
---
a/src/jdk.jdi/share/classes/com/su
Hello,
There are a few stray raw and unchecked warnings remaining in core libs;
please review my fix:
JDK-8054050: Fix stay raw and unchecked lint warnings in core libs
http://cr.openjdk.java.net/~darcy/8054050.0/
Patch below.
Thanks,
-Joe
--- old/src/share/classes/com/sun/manageme
/2014 6:35 PM, Joe Darcy wrote:
Hi Mandy,
On 07/09/2014 06:26 PM, Mandy Chung wrote:
On 7/9/2014 6:10 PM, Joe Darcy wrote:
Hello,
Another batch of lint warnings removal; this time for
8049820: Fix raw and unchecked lint warnings in sun.management
http://cr.openjdk.java.net/~darcy/8049
Hi Mandy,
On 07/09/2014 06:26 PM, Mandy Chung wrote:
On 7/9/2014 6:10 PM, Joe Darcy wrote:
Hello,
Another batch of lint warnings removal; this time for
8049820: Fix raw and unchecked lint warnings in sun.management
http://cr.openjdk.java.net/~darcy/8049820.0/
230
Hello,
Another batch of lint warnings removal; this time for
8049820: Fix raw and unchecked lint warnings in sun.management
http://cr.openjdk.java.net/~darcy/8049820.0/
Patch below.
Thanks,
-Joe
--- old/src/share/classes/sun/management/DiagnosticCommandImpl.java
2014-07-09 18:07:40.
On 07/09/2014 02:48 PM, Mandy Chung wrote:
On 7/9/2014 2:36 PM, Joe Darcy wrote:
Hello,
Please review these changes to address
JDK-8049794: Fix raw and unchecked warnings in jvmstat
http://cr.openjdk.java.net/~darcy/8049794.0/
I looked through the patch and the generified types
Hello,
Please review these changes to address
JDK-8049794: Fix raw and unchecked warnings in jvmstat
http://cr.openjdk.java.net/~darcy/8049794.0/
Patch below.
Thanks,
-Joe
---
old/src/share/classes/sun/jvmstat/monitor/event/MonitorStatusChangeEvent.java
2014-07-09 14:30:52.
Hello,
Please review the patch below which addresses
JDK-8049736: Fix raw and unchecked lint warnings in sun.tracing
Thanks,
-Joe
diff -r 2b7bf1d63a9c src/share/classes/sun/tracing/ProviderSkeleton.java
--- a/src/share/classes/sun/tracing/ProviderSkeleton.javaWed Jul 09
10:02:30 2014
Approved!
-Joe
On 04/25/2014 09:36 AM, Staffan Larsen wrote:
Here is an anti-delta for the broken push. I prepared it using “hg backout”.
webrev: http://cr.openjdk.java.net/~sla/8041948/webrev.00/
bug: https://bugs.openjdk.java.net/browse/JDK-8041948
If I can get this reviewed quickly I can p
Hello,
*fingers crossed* The patch below should be the last change needed to
fully clear the JDK 9 jdk repo of serialization warnings.
Thanks,
-Joe
diff -r b6997dd0667e src/share/classes/com/sun/jmx/snmp/Enumerated.java
--- a/src/share/classes/com/sun/jmx/snmp/Enumerated.javaTue Apr 01
Hello,
With the serial warnings cleanup of the JDK drawing to completion,
please review the patch below which addresses some lingering issues in
jconsole and jstat.
Thanks,
-Joe
diff -r b6997dd0667e src/share/classes/sun/tools/jconsole/Tab.java
--- a/src/share/classes/sun/tools/jconsole/Tab
Changeset: 68de5492a06d
Author:darcy
Date: 2014-01-03 11:38 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/68de5492a06d
8030212: Several api.java.util.stream tests got "NaN" value instead of
"Infinity" or "-Infinity"
Reviewed-by: mduigou, psandoz
! src/share/classes/java/ut
Changeset: 6d1f9d1fd585
Author:darcy
Date: 2013-12-17 10:26 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/6d1f9d1fd585
8030080: Correct misstatement in JSR 269 MR (in javax.lang.model)
Reviewed-by: jfranck
! src/share/classes/javax/lang/model/type/IntersectionType.jav
Changeset: f8da1f34c65c
Author:darcy
Date: 2013-12-06 11:28 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f8da1f34c65c
8023471: Add compatibility note to AnnotatedElement
Reviewed-by: smarks, jfranck, abuckley
! src/share/classes/java/lang/annotation/Annotation.java
! src/s
Changeset: cd4aabc40f72
Author:darcy
Date: 2013-12-03 11:52 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cd4aabc40f72
8029475: Fix more doclint issues in javax.security
Reviewed-by: juh
! src/share/classes/javax/crypto/Cipher.java
! src/share/classes/javax/crypto/CipherSpi
Changeset: 1c3d58caa7da
Author:darcy
Date: 2013-12-03 10:07 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1c3d58caa7da
8029478: Fix more doclint issues in javax.script
Reviewed-by: chegar, mduigou
! src/share/classes/javax/script/ScriptEngineFactory.java
Changeset: ca911e383e26
Author:darcy
Date: 2013-12-01 23:35 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ca911e383e26
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce
numerical errors
Reviewed-by: psandoz, mduigou
! src/share/classes/java/util/
Changeset: e6333788b117
Author:darcy
Date: 2013-11-13 11:06 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e6333788b117
8028300: Fix raw type lint warnings in java.util.concurrent
Reviewed-by: chegar, martin
! src/share/classes/java/util/concurrent/ForkJoinPool.java
! src/sh
Changeset: 69432cb5bca2
Author:darcy
Date: 2013-11-12 09:44 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/69432cb5bca2
8028229: Fix more raw types lint warning in core libraries
Reviewed-by: chegar, forax, lancea, alanb, jfranck
! src/share/classes/java/io/ObjectOutputStrea
Changeset: 11376ad23e21
Author:darcy
Date: 2013-11-08 12:19 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/11376ad23e21
8028076: Correct raw type lint warnings in core reflection implementation
classes
Reviewed-by: lancea, alanb
!
src/share/classes/sun/reflect/generics/ref
Changeset: e39bd9401ea5
Author:darcy
Date: 2013-11-07 20:11 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e39bd9401ea5
8027730: Fix release-8 type visitors to support intersection types
Reviewed-by: jjg, jlahoda, sogoel
! src/share/classes/javax/lang/model/util/Simple
Changeset: e8894e3224d9
Author:darcy
Date: 2013-10-30 17:27 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e8894e3224d9
8005294: Consider default methods for additions to AnnotatedElement
Reviewed-by: jfranck, plevart, mchung, abuckley, sogoel
! src/share/classes/java/lang/r
Changeset: 9a32af82bd1e
Author:darcy
Date: 2013-10-22 12:04 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9a32af82bd1e
8027062: Fix lint and doclint issues in java.lang.{ClassLoader, ClassValue,
SecurityManager}
Reviewed-by: chegar, forax, alanb, mduigou
! src/share/classe
Changeset: b82982ac3ca2
Author:darcy
Date: 2013-10-21 15:37 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b82982ac3ca2
8026984: Clarity intended use of jdk.Exported
Reviewed-by: psandoz, mr, alanb
! src/share/classes/jdk/Exported.java
Changeset: c1700125d041
Author:darcy
Date: 2013-10-21 12:52 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c1700125d041
8022658: Revisit FunctionalInterface on some core libs types
Reviewed-by: briangoetz, mduigou, mr
! src/share/classes/java/io/Closeable.java
! src/share/cl
Changeset: 8a7b1b615100
Author:darcy
Date: 2013-10-17 22:22 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8a7b1b615100
8026840: Fix new doclint issues in javax.naming
Reviewed-by: mchung
! src/share/classes/javax/naming/CompositeName.java
! src/share/classes/javax/naming/Co
Changeset: 7af634b1fc5b
Author:darcy
Date: 2013-10-17 19:10 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7af634b1fc5b
8026838: Fix new doclint issues in javax.annotation.processing
Reviewed-by: jjg
! src/share/classes/javax/annotation/processing/Processor.java
Changeset: c13309f658e1
Author:darcy
Date: 2013-10-09 18:31 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c13309f658e1
8024354: Explicitly permit DoubleStream.sum()/average() implementations to use
higher precision summation
Reviewed-by: mduigou, briangoetz
! src/share/cla
Changeset: 4dd7ffbf01fb
Author:darcy
Date: 2013-10-07 16:51 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4dd7ffbf01fb
8026017: Make history of AnnotatedConstruct methods in jx.l.m.e.Element clearer
Reviewed-by: jjg
! src/share/classes/javax/lang/model/element/Element
Changeset: 379c04c090cf
Author:darcy
Date: 2013-10-04 10:00 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/379c04c090cf
8025913: Rename jdk.Supported to jdk.Exported
Reviewed-by: psandoz, forax, lancea, alanb, mchung, jjg
! src/share/classes/com/sun/source/doctree/Attr
1 - 100 of 369 matches
Mail list logo
