Re: RFR: 8143121: javax/management/remote/mandatory/loading/MethodResultTest.java fails intermittently

2015-11-23 Thread Shanliang JIANG
We could repeat retrying until the test harness timeout, but add a sleep is definitively useful between retrying. Shanliang > On 23 Nov 2015, at 12:32, Daniel Fuchs wrote: > > Hi Alexander, > > This looks a bit dangerous to me - it could create a busy loop > if for some reason the connection c

Re: jmx-dev RFR 8141591: javax/management/remote/mandatory/threads/ExecutorTest.java fails intermittently

2015-11-13 Thread Shanliang JIANG
> On 13 Nov 2015, at 09:04, Jaroslav Bachorik > wrote: > > On 13.11.2015 08:05, Shanliang JIANG wrote: >> Hi Jaroslav, >> >> The issue is that after a JMX client is terminated, its >> ClientNotifForwarder continues deliver a job to a user specific >

Re: RFR: 8141591 : javax/management/remote/mandatory/threads/ExecutorTest.java fails intermittently

2015-11-10 Thread Shanliang JIANG
) { executor.execute(new NotifFetcher()); } } Thanks to work on this issue. Shanliang > On 10 Nov 2015, at 12:36, Alexander Kulyakhtin > wrote: > > Hi Jaroslav, Shanliang Jiang > > Thank you very much for the review. > > Following the comments from Sha

Re: RFR (xs) 8132003: Update javax/management regression test for Verona (versioning)

2015-07-21 Thread Shanliang Jiang
++ b/test/javax/management/remote/mandatory/notif/NotSerializableNotifTest.java Mon Jul 20 19:31:54 2015 -0700 @@ -24,7 +24,7 @@ /* * @test * @summary Tests to send a not serializable notification. - * @bug 5022196 + * @bug 5022196 8132003 * @author Shanliang JIANG * @modules java.management

Re: RFR 8029098: Exclude javax/management/remote/mandatory/notif/ListenerScaleTest.java from running on fastdebug builds

2015-05-12 Thread Shanliang Jiang
Looks good to me! Shanliang Jaroslav Bachorik wrote: Please, review the following simple change Issue : https://bugs.openjdk.java.net/browse/JDK-8029098 Webrev: http://cr.openjdk.java.net/~jbachorik/8029098/webrev.00 The 'ListenerScaleTest' is meant to check the proper scaling of the MBean

Re: Potential infinite waiting at JMXConnection#createConnection

2015-05-06 Thread Shanliang Jiang
liang Thanks, Yuji 2015-05-06 18:51 GMT+09:00 Shanliang Jiang <mailto:shanliang.ji...@oracle.com>>: Hi Yuji, I think better at first to create a bug at: https://bugs.openjdk.java.net/secure/Dashboard.jspa It looks like an issue for me, it must be possible to have

Re: Potential infinite waiting at JMXConnection#createConnection

2015-05-06 Thread Shanliang Jiang
2:03 GMT+09:00 Shanliang Jiang <mailto:shanliang.ji...@oracle.com>>: > Hi Yuji, > > (I reply to serviceability alias) > > When you create a RMI server connector, you can specify a > RMIClientSocketFactory by RMI_CLIENT_SOCKET_FACTORY_ATTRIBUTE, this allows >

Re: Potential infinite waiting at JMXConnection#createConnection

2015-05-04 Thread Shanliang Jiang
Hi Yuji, (I reply to serviceability alias) When you create a RMI server connector, you can specify a RMIClientSocketFactory by RMI_CLIENT_SOCKET_FACTORY_ATTRIBUTE ,

Re: RFR: 8078144 many nightly tests failed due to NoSuchMethodError: sun.management.ManagementFactoryHelper.getDiagnosticMXBean

2015-04-21 Thread Shanliang Jiang
Alan Bateman wrote: On 21/04/2015 08:01, Shanliang Jiang wrote: Hi, Please review this test fix: webrev: http://cr.openjdk.java.net/~sjiang/JDK-8078144/00/ bug: https://bugs.openjdk.java.net/browse/JDK-8078144 The method sun.management.ManagementFactoryHelper.getDiagnosticMXBean was removed

RFR: 8078144 many nightly tests failed due to NoSuchMethodError: sun.management.ManagementFactoryHelper.getDiagnosticMXBean

2015-04-21 Thread Shanliang Jiang
Hi, Please review this test fix: webrev: http://cr.openjdk.java.net/~sjiang/JDK-8078144/00/ bug: https://bugs.openjdk.java.net/browse/JDK-8078144 The method sun.management.ManagementFactoryHelper.getDiagnosticMXBean was removed because HotSpotDiagnosticMXBean is not in java.management module

RFR: 8077408 javax/management/remote/mandatory/notif/NotSerializableNotifTest.java fails due to Port already in use: 2468

2015-04-13 Thread Shanliang Jiang
Hi, Please review this test fix. Instead to specify a port, we use "0" to get a free port. I also remove the test waiting time variable, better to reply on directly the test harness timeout. bug: https://bugs.openjdk.java.net/browse/JDK-8077408 webrev: http://cr.openjdk.java.net/~sjiang/JDK-

Re: RFR 8042901: Allow com.sun.management to be in a different module to java.lang.management

2015-04-03 Thread Shanliang Jiang
Mandy Chung wrote: CheckSomeMXBeanImplPackage.java line 45-50 & 58-60: should be called unconditionally since they should pass if java.management is present. The method "check" checks that an MBean implementation must be from "com.sun.management.internal", so even we look for an MXBean with

Re: RFR 8042901: Allow com.sun.management to be in a different module to java.lang.management

2015-04-02 Thread Shanliang Jiang
Hi, I have to ask the review again because I need to modify: langtools/src/jdk.dev/share/classes/com/sun/tools/jdeps/Profile.java The issue was found when langtools tests were added into my test list. The new version is: http://cr.openjdk.java.net/~sjiang/JDK-8042901/02/ which integrated

hg: jdk8/tl/jdk: 8029063: test/com/sun/jmx/snmp/NoInfoLeakTest.java does not compile with OpenJDK builds

2013-12-02 Thread shanliang . jiang
Changeset: c11553506228 Author:sjiang Date: 2013-12-03 08:53 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c11553506228 8029063: test/com/sun/jmx/snmp/NoInfoLeakTest.java does not compile with OpenJDK builds Reviewed-by: alanb, dfuchs - test/com/sun/jmx/snmp/NoInfoLeakTest

hg: jdk8/tl/jdk: 8026028: [findbugs] findbugs report some issue in com.sun.jmx.snmp package

2013-10-18 Thread shanliang . jiang
Changeset: 4161f17dfe2b Author:sjiang Date: 2013-10-18 16:15 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4161f17dfe2b 8026028: [findbugs] findbugs report some issue in com.sun.jmx.snmp package Reviewed-by: psandoz, dfuchs ! src/share/classes/com/sun/jmx/snmp/SnmpString.ja

hg: jdk8/tl/jdk: 8025204: Intermittent test failure: javax/management/remote/mandatory/connection/IdleTimeoutTest.java

2013-10-10 Thread shanliang . jiang
Changeset: cab80088c671 Author:sjiang Date: 2013-10-10 17:47 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cab80088c671 8025204: Intermittent test failure: javax/management/remote/mandatory/connection/IdleTimeoutTest.java Reviewed-by: dholmes, jbachorik ! test/javax/manage

hg: jdk8/tl/jdk: 8025205: Intermittent test failure: javax/management/remote/mandatory/connection/BrokenConnectionTest.java

2013-10-10 Thread shanliang . jiang
Changeset: a30f6fd581b3 Author:sjiang Date: 2013-10-10 09:01 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a30f6fd581b3 8025205: Intermittent test failure: javax/management/remote/mandatory/connection/BrokenConnectionTest.java Reviewed-by: dholmes, dfuchs, jbachorik ! test

hg: jdk8/tl/jdk: 8025207: Intermittent test failure: javax/management/monitor/CounterMonitorThresholdTest.java

2013-10-10 Thread shanliang . jiang
Changeset: e901a618dcff Author:sjiang Date: 2013-10-10 08:37 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e901a618dcff 8025207: Intermittent test failure: javax/management/monitor/CounterMonitorThresholdTest.java Reviewed-by: dfuchs, dholmes ! test/javax/management/monito

hg: jdk8/tl/jdk: 8025206: Intermittent test failure: javax/management/monitor/NullAttributeValueTest.java

2013-10-09 Thread shanliang . jiang
Changeset: e8097e1e18a7 Author:sjiang Date: 2013-10-10 08:49 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e8097e1e18a7 8025206: Intermittent test failure: javax/management/monitor/NullAttributeValueTest.java Reviewed-by: dholmes, dfuchs, jbachorik ! test/javax/managem

hg: jdk8/tl/jdk: 8023954: MBean*Info.equals: throw NPE

2013-09-17 Thread shanliang . jiang
Changeset: 8708569b5524 Author:sjiang Date: 2013-09-18 08:51 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8708569b5524 8023954: MBean*Info.equals: throw NPE Reviewed-by: dfuchs, dholmes ! src/share/classes/javax/management/MBeanAttributeInfo.java ! src/share/classes/javax/

hg: jdk8/tl/jdk: 8023669: MBean*Info.hashCode : NPE

2013-09-13 Thread shanliang . jiang
Changeset: ba0b95f310c8 Author:sjiang Date: 2013-09-13 10:48 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ba0b95f310c8 8023669: MBean*Info.hashCode : NPE Reviewed-by: dholmes, dfuchs, jbachorik ! src/share/classes/javax/management/MBeanAttributeInfo.java ! src/share/classe

hg: jdk8/tl/jdk: 8023529: OpenMBeanInfoSupport.equals/hashCode throw NPE

2013-09-12 Thread shanliang . jiang
Changeset: e407df8093dc Author:sjiang Date: 2013-09-12 09:41 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e407df8093dc 8023529: OpenMBeanInfoSupport.equals/hashCode throw NPE Reviewed-by: dholmes, dfuchs ! src/share/classes/javax/management/openmbean/OpenMBeanInfoSupport.j

hg: jdk8/tl/jdk: 6566891: RMIConnector: map value referencing map key in WeakHashMap prevents map entry to be removed

2013-08-30 Thread shanliang . jiang
Changeset: 2d51653d9b4b Author:sjiang Date: 2013-08-30 12:49 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2d51653d9b4b 6566891: RMIConnector: map value referencing map key in WeakHashMap prevents map entry to be removed Reviewed-by: egahlin, jbachorik, dfuchs, dholmes ! s

hg: jdk8/tl/jdk: 8016221: A unit test should not use a fix port to run a jmx connector

2013-07-24 Thread shanliang . jiang
Changeset: 187a1f2613c0 Author:sjiang Date: 2013-07-24 15:47 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/187a1f2613c0 8016221: A unit test should not use a fix port to run a jmx connector Reviewed-by: jbachorik, dfuchs ! test/com/sun/management/DiagnosticCommandMBean/Dcm

hg: jdk8/tl/jdk: 7120365: DiffHBTest.java fails due to ConcurrentModificationException

2012-12-28 Thread shanliang . jiang
Changeset: 46675076f753 Author:sjiang Date: 2012-12-28 16:44 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/46675076f753 7120365: DiffHBTest.java fails due to ConcurrentModificationException Summary: The problem is from the server notification forwarder, it should use a copy

hg: jdk8/tl/jdk: 8005325: The script should use TESTVMOPTS

2012-12-21 Thread shanliang . jiang
Changeset: 86c10d1484e9 Author:sjiang Date: 2012-12-21 10:58 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/86c10d1484e9 8005325: The script should use TESTVMOPTS Summary: Put back TESTVMOPTS which was removed by mistake. Reviewed-by: smarks ! test/sun/management/jmxremote/s

hg: jdk8/tl/jdk: 7146162: javax/management/remote/mandatory/connection/BrokenConnectionTest.java failing intermittently

2012-12-21 Thread shanliang . jiang
Changeset: 42ee6b6ad373 Author:jbachorik Date: 2012-12-21 09:27 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/42ee6b6ad373 7146162: javax/management/remote/mandatory/connection/BrokenConnectionTest.java failing intermittently Summary: ClientCommunicatorAdmin should call got

hg: jdk8/tl/jdk: 7158614: JMXStartStopTest.sh failing intermittently

2012-12-19 Thread shanliang . jiang
Changeset: c79b26b8efe0 Author:sjiang Date: 2012-12-19 11:06 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c79b26b8efe0 7158614: JMXStartStopTest.sh failing intermittently Summary: fixed 3 problems here: 1) checked the lock file too eary 2) never got the process id of a jav

hg: jdk7/tl/jdk: 2 new changesets

2008-12-09 Thread shanliang . jiang
Changeset: 7aa035fdd97d Author:sjiang Date: 2008-12-09 20:50 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7aa035fdd97d 6336980: NotificationBroadcasterSupport: to tell whether there are listeners and to do clear Reviewed-by: emcmanus ! src/share/classes/javax/management/N

hg: jdk7/tl/jdk: 6332907: Add ability for connector server to close individual connections

2008-12-09 Thread shanliang . jiang
Changeset: 4951fee90769 Author:sjiang Date: 2008-12-09 19:44 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4951fee90769 6332907: Add ability for connector server to close individual connections Reviewed-by: emcmanus ! src/share/classes/com/sun/jmx/remote/util/EnvHelp.java !

hg: jdk7/tl/jdk: 2 new changesets

2008-12-09 Thread shanliang . jiang
Changeset: 23738109351f Author:sjiang Date: 2008-12-09 18:42 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/23738109351f 6760712: Provide a connector server option that causes it not to prevent the VM from exiting Reviewed-by: emcmanus ! src/share/classes/com/sun/jmx/remote

hg: jdk7/tl/jdk: 2 new changesets

2008-12-09 Thread shanliang . jiang
Changeset: 6eec8be80bfe Author:sjiang Date: 2008-12-09 17:41 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6eec8be80bfe 6405891: MLet: could be improved to load a native lib Reviewed-by: emcmanus ! src/share/classes/javax/management/loading/MLet.java Changeset: 30239cf868b

hg: jdk7/tl/jdk: 6697180: JMX query results in java.io.IOException: Illegal state - also a deadlock can also be seen

2008-09-22 Thread shanliang . jiang
Changeset: a1ab54c36c8a Author:sjiang Date: 2008-09-22 15:43 +0200 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a1ab54c36c8a 6697180: JMX query results in java.io.IOException: Illegal state - also a deadlock can also be seen Reviewed-by: emcmanus ! src/share/classes/com/sun/jmx

hg: jdk7/tl/jdk: 6736611: [Evt Srv] EventSubscriber.unsubscribe removes other listeners

2008-09-09 Thread shanliang . jiang
Changeset: 094873a59791 Author:sjiang Date: 2008-09-09 14:17 +0200 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/094873a59791 6736611: [Evt Srv] EventSubscriber.unsubscribe removes other listeners Reviewed-by: emcmanus ! src/share/classes/javax/management/event/EventSubscriber.ja