Looks good. Thank you.
And I will deal with the early event work when we add more events in terms of
exactly how early we need to initialize the tracing subsystem.
thanks,
Karen
On Feb 15, 2012, at 6:38 AM, Nils Loodin wrote:
> Thank you all for suggesting even more improvements!
>
> Updated t
Thank you all for suggesting even more improvements!
Updated the webrev and put it here:
http://cr.openjdk.java.net/~nloodin/7145243/webrev.02/
Regards,
Nils Loodin
On Feb 14, 2012, at 18:29 , Nils Loodin wrote:
> Thanks all for suggestions on improvements.
> I have an updated webrev here:
> h
Forgot to reply all..
/Nisse
Begin forwarded message:
> From: Nils Loodin
> Subject: Re: Diagnostic command fixes
> Date: February 15, 2012 12:27:19 GMT+01:00
> To: David Holmes
>
>
> On Feb 15, 2012, at 4:03 , David Holmes wrote:
>
>> Hi Nils,
>>
>
Hi Nils,
I only glanced at this and though the change in thread.cpp a little strange:
3401 // Set flag that basic initialization has completed. Used by
exceptions and various
3402 // debug stuff, that does not work until all basic classes have
been initialized.
3403 set_init_completed()
Frederic, Nils,
Just fix the copyright then.
responses inline ...
On Feb 14, 2012, at 1:27 PM, Frederic Parain wrote:
>
>
> On 14/02/2012 18:55, Karen Kinnear wrote:
>> Thank you Nils :-)
>>
>> I had a question on the DCmdArgument - I think I am
>> not reading
>> this correctly:
>>
>> Coupl
On 14/02/2012 18:55, Karen Kinnear wrote:
Thank you Nils :-)
I had a question on the DCmdArgument - I think I am
not reading
this correctly:
Couple of questions please:
I haven't seen the specification at this level of detail, but I thought
that if
you entered a digit value with no units tha
Thank you Nils :-)
I had a question on the DCmdArgument - I think I am not
reading
this correctly:
Couple of questions please:
1) What is this doing?
if (idx == len) {
143
// only accept missing unit if the value is 0
144
if (_value._time != 0) {
145
THROW_MSG(vmS
Forgot an important point - the testing
First I ran all the testing we have for the tracing framework that makes use of
these commands.
I have also debugged through with frivolous command lines to make sure we don't
do anything bad, like crash.
Also I've manually tried to use all the combination
Thanks all for suggestions on improvements.
I have an updated webrev here:
http://cr.openjdk.java.net/~nloodin/7145243/webrev.01/
Regards
Nils Loodin
PS: Note - Frederic Parain has graciously taken upon himself to sponsor this.
Many thanks!
DS
On Feb 13, 2012, at 22:58 , Nils Loodin wrote:
>
Hi Nils,
I can be the sponsor for this one.
Here's my comments:
diagnosticFramework.cpp:77-79
why do you need:
77 if (_buffer[_cursor] == _delim) {
78 _cursor++;
79 }
When there's this loop just a few lines above:
64 while (_cursor < _len - 1 && _buffer[_cursor] == _delim)
Hey all!
The new diagnostic command parser needs some additional specializations for
time and bytes, here included.
Also a few fixes for crashes for some combinations of commandlines.
Tested by throwing a lot of different arguments on the parser, also by running
the tests in sun/tools/jcmd.
ht
11 matches
Mail list logo
