RE: RFR: JDK-8163346: Update jmap-hashcode/Test8028623.java for better diagnostic of timeout.

2016-08-25 Thread Sharath Ballal
Thanks David. -Sharath Ballal -Original Message- From: David Holmes Sent: Thursday, August 25, 2016 5:56 PM To: Sharath Ballal; Dmitry Samersoff; serviceability-dev@openjdk.java.net Subject: Re: RFR: JDK-8163346: Update jmap-hashcode/Test8028623.java for better diagnostic of timeout

Re: RFR: JDK-8163346: Update jmap-hashcode/Test8028623.java for better diagnostic of timeout.

2016-08-25 Thread David Holmes
- From: Sharath Ballal Sent: Monday, August 22, 2016 9:57 PM To: Dmitry Samersoff Cc: Arvind Aprameya Subject: RE: RFR: JDK-8163346: Update jmap-hashcode/Test8028623.java for better diagnostic of timeout. Hi Dmitry, I have made the suggested changes. As discussed, I have also excluded

RE: RFR: JDK-8163346: Update jmap-hashcode/Test8028623.java for better diagnostic of timeout.

2016-08-25 Thread Sharath Ballal
@openjdk.java.net Subject: Re: RFR: JDK-8163346: Update jmap-hashcode/Test8028623.java for better diagnostic of timeout. Sharath, Looks good for me. Please, move LingeredAppWithExtendedChars.java to the test directory, it's test-specific code and it shouldn't be in the library (no need for re-review

Re: RFR: JDK-8163346: Update jmap-hashcode/Test8028623.java for better diagnostic of timeout.

2016-08-19 Thread Dmitry Samersoff
.net > Subject: Re: RFR: JDK-8163346: Update jmap-hashcode/Test8028623.java for > better diagnostic of timeout. > > Sharath, > > As soon as you request a heap dump of LingeredApp, LingeredApp should > contains the object with extended characters in it's name. > > So p

RE: RFR: JDK-8163346: Update jmap-hashcode/Test8028623.java for better diagnostic of timeout.

2016-08-17 Thread Sharath Ballal
@openjdk.java.net Subject: Re: RFR: JDK-8163346: Update jmap-hashcode/Test8028623.java for better diagnostic of timeout. Sharath, As soon as you request a heap dump of LingeredApp, LingeredApp should contains the object with extended characters in it's name. So please: 1. Inherit LingeredApp (See

Re: RFR: JDK-8163346: Update jmap-hashcode/Test8028623.java for better diagnostic of timeout.

2016-08-10 Thread Dmitry Samersoff
Sharath, As soon as you request a heap dump of LingeredApp, LingeredApp should contains the object with extended characters in it's name. So please: 1. Inherit LingeredApp (See LingeredAppWithDeadlock as an example) and add public static int \u00CB = 1; 2. Copy BasicLauncherTest to

RFR: JDK-8163346: Update jmap-hashcode/Test8028623.java for better diagnostic of timeout.

2016-08-08 Thread Sharath Ballal
Hello, Pls review the following fix for modifying the testcase jmap-hashcode/Test8028623.java to use LingeredApp. http://cr.openjdk.java.net/~sballal/8163346/webrev.00/ Link to bug: https://bugs.openjdk.java.net/browse/JDK-8163346 -Sharath Ballal