On Fri, 2 Oct 2020 05:10:20 GMT, Serguei Spitsyn wrote:
>> Please review this change for hotspot and one test.
>> There is few JVMTI callback/event functions in jdk which signature doesn't
>> match specification.
>> for example:
>> static jvmtiError JNICALL IsClassUnloadingEnabled(const jvmtiEnv
On Fri, 2 Oct 2020 06:59:13 GMT, Vladimir Kempik wrote:
>> Vladimir, it looks good to me.
>
>> David,
>> I think, Vladimir is referring to the JVMTI extension mechanism spec:
>> https://docs.oracle.com/en/java/javase/15/docs/specs/jvmti.html#jvmtiExtensionFunction
>> https://docs.oracle.com/en/ja
On Fri, 2 Oct 2020 06:30:34 GMT, Serguei Spitsyn wrote:
> * Q1: Is it necessary to call the Agent_OnUnload()?
[JVMTI spec of
Agent_OnUnload()](https://docs.oracle.com/en/java/javase/15/docs/specs/jvmti.html#onunload)
says this
function will be called when the agent library will be unloaded by
On Fri, 2 Oct 2020 07:27:17 GMT, David Holmes wrote:
> Okay but look at the example that documentation gives:
>
> > For example, if the jvmtiParamInfo returned by GetExtensionEvents indicates
> > that there is a jint parameter, the event
> > handler should be declared: ```
> > void JNICALL
On Fri, 11 Sep 2020 07:24:20 GMT, Lin Zang wrote:
>> Hi @pliden,
>> Thanks for your comments, I will try to merge ZHeapIterator and
>> ZHeapParIterator and update the pr then.
>> -Lin
>
> Hi @pliden,
>I updated the PR which merge the changed code into ZHeapIterator.
>May I ask your hel
> In the platform-specific implementations of linker_md.c, we see the
> dll_build_name methods begin with a call to
> jvmtiAllocate.
> We then appear to rush ahead and try to use that variable without checking
> for a null.
>
> I propose moving the null check to the point *before* we try to use
On Fri, 18 Sep 2020 22:25:13 GMT, Chris Plummer wrote:
>> Adam Farley has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental
>> views will show differences compared to the previous content of the PR. The
>> pull request contains one new commi
On Fri, 2 Oct 2020 04:46:53 GMT, Serguei Spitsyn wrote:
>> Ziviani has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views
>> will show differences compared to the previous content of the PR.
>
> LGTM
Added comment to JDK-8230664. Test r
> continuing the review thread from here
> https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-September/068546.html
>
>> The download side of using JNI in these tests is that it complicates the
>> setup a bit for those that run jtreg directly and/or just build the JDK
>> and not the test
On Wed, 9 Sep 2020 19:29:30 GMT, Vipin Sharma wrote:
> Updated @exception with @throws for core-libs, it fixes all open sub-tasks of
> JDK-8252536.
>
> Open Subtasks part of this fix are:
> 1. JDK-8252537
> 2. JDK-8252539
> 3. JDK-8252540
> 4. JDK-8252541
>
> Previous conversation on this:
> h
Hi Vladimir,
On 2/10/2020 5:37 pm, Vladimir Kempik wrote:
On Fri, 2 Oct 2020 07:27:17 GMT, David Holmes wrote:
Okay but look at the example that documentation gives:
For example, if the jvmtiParamInfo returned by GetExtensionEvents indicates
that there is a jint parameter, the event
handle
On Fri, 2 Oct 2020 07:34:45 GMT, Vladimir Kempik wrote:
>> Okay but look at the example that documentation gives:
>>
>>> For example, if the jvmtiParamInfo returned by GetExtensionEvents indicates
>>> that there is a jint parameter, the event
>>> handler should be declared:
>>> void JNI
> continuing the review thread from here
> https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-September/068546.html
>
>> The download side of using JNI in these tests is that it complicates the
>> setup a bit for those that run jtreg directly and/or just build the JDK
>> and not the test
> continuing the review thread from here
> https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-September/068546.html
>
>> The download side of using JNI in these tests is that it complicates the
>> setup a bit for those that run jtreg directly and/or just build the JDK
>> and not the test
An issue similar to
[JDK-8239559](https://bugs.openjdk.java.net/browse/JDK-8239559) has been
discovered. On the
affected system, `/proc/self/mountinfo` contains a line such as this one:
35 26 0:26 / /sys/fs/cgroup/systemd rw,nosuid,nodev,noexec,relatime - cgroup
systemd rw,name=systemd
Note
On Fri, 2 Oct 2020 16:34:49 GMT, Severin Gehwolf wrote:
> An issue similar to
> [JDK-8239559](https://bugs.openjdk.java.net/browse/JDK-8239559) has been
> discovered. On the
> affected system, `/proc/self/mountinfo` contains a line such as this one:
>
> 35 26 0:26 / /sys/fs/cgroup/systemd rw,n
On Fri, 2 Oct 2020 09:48:48 GMT, Adam Farley wrote:
>> In the platform-specific implementations of linker_md.c, we see the
>> dll_build_name methods begin with a call to
>> jvmtiAllocate.
>> We then appear to rush ahead and try to use that variable without checking
>> for a null.
>>
>> I propo
On Wed, 30 Sep 2020 00:40:29 GMT, David Holmes wrote:
>> Monica Beckwith has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> change string representation for r18 to "r18_tls" on every platform
>
> Marked as reviewed by dholmes (Reviewer).
>
18 matches
Mail list logo
