On Fri, 2 Oct 2020 06:59:13 GMT, Vladimir Kempik <vkem...@openjdk.org> wrote:
>> Vladimir, it looks good to me. > >> David, >> I think, Vladimir is referring to the JVMTI extension mechanism spec: >> https://docs.oracle.com/en/java/javase/15/docs/specs/jvmti.html#jvmtiExtensionFunction >> https://docs.oracle.com/en/java/javase/15/docs/specs/jvmti.html#jvmtiExtensionEvent > > Hello Serguei, you are right, I was talking about this documents. > Thank you. Okay but look at the example that documentation gives: > For example, if the jvmtiParamInfo returned by GetExtensionEvents indicates > that there is a jint parameter, the event > handler should be declared: > void JNICALL myHandler(jvmtiEnv* jvmti_env, jint myInt, ...) The myInt is explicit, just as our "jboolean* enabled" is explicit. I think they key point is that the signature must end with "..." which it does. I don't see anything here that needs to be fixed. ------------- PR: https://git.openjdk.java.net/jdk/pull/466
