On Fri, 2 Oct 2020 05:10:20 GMT, Serguei Spitsyn <sspit...@openjdk.org> wrote:
>> Please review this change for hotspot and one test. >> There is few JVMTI callback/event functions in jdk which signature doesn't >> match specification. >> for example: >> static jvmtiError JNICALL IsClassUnloadingEnabled(const jvmtiEnv* env, >> jboolean* enabled, ...) >> but according to jvmti specs it should be: >> static jvmtiError JNICALL IsClassUnloadingEnabled(const jvmtiEnv* env, ...) >> same with ClassUnload(jvmtiEnv* jvmti_env, JNIEnv* jni_env, const char* >> name, ...) in tests >> for many years that didn't matter but with coming JEP-391 it becomes >> important to make it match the spec >> https://developer.apple.com/documentation/apple_silicon/addressing_architectural_differences_in_your_macos_code >> This commit makes the above mentioned functions to have signature matching >> jvmti specification > > Vladimir, it looks good to me. > David, > I think, Vladimir is referring to the JVMTI extension mechanism spec: > https://docs.oracle.com/en/java/javase/15/docs/specs/jvmti.html#jvmtiExtensionFunction > https://docs.oracle.com/en/java/javase/15/docs/specs/jvmti.html#jvmtiExtensionEvent Hello Serguei, you are right, I was talking about this documents. Thank you. ------------- PR: https://git.openjdk.java.net/jdk/pull/466
