RE: RFR: JDK-8163143: illegal bci error with interpreted frames in SA due to mirror being stored in interpreted frames

2016-08-10 Thread Jini Susan George
Thank you very much, Dmitry for the review. I have created a new webrev with a launchJStack() method in BasicLauncherTest.java. The exit value is 0, despite the error -- so that does not help. Please do take a look at the modified webrev:

Re: RFR: JDK-8163581: Heap Parameters in HSDB cannot handle G1CollectedHeap

2016-08-10 Thread David Holmes
Hi Yasumasa, Adding in GC folk. I agree with the need to override the printOn method, but can't comment on the details of what you are actually printing. Thanks, David On 10/08/2016 10:20 PM, Yasumasa Suenaga wrote: Hi all, When I chose "Heap Parameters" menu in HSDB, I got following

Re: RFR: JDK-8163580: Cannot get Monitor Cache Dump in HSDB

2016-08-10 Thread David Holmes
Hi Yasumasa, On 10/08/2016 10:18 PM, Yasumasa Suenaga wrote: Hi all, When I chose "Monitor Cache Dump" menu in HSDB, I saw an Exception as below: Exception in thread "AWT-EventQueue-0" java.lang.ExceptionInInitializerError at

Re: RFR : JDK-8162530 : src/jdk.management/share/native/libmanagement_ext/GcInfoBuilder.c doesn't handle JNI exceptions properly

2016-08-10 Thread David Holmes
On 10/08/2016 8:46 PM, Amit Sapre wrote: Hello, Well for some reason, unknown to me, JNI code checker is not complaining for exception thrown by SetObjectArrayElement. It complains for any pending exceptions before calling SetObjectArrayElement. I have added exceptions checks after calling

RFR: JDK-8163581: Heap Parameters in HSDB cannot handle G1CollectedHeap

2016-08-10 Thread Yasumasa Suenaga
Hi all, When I chose "Heap Parameters" menu in HSDB, I got following value: Heap Parameters: unknown subtype of CollectedHeap @ 0x7f4d4c030510 (0x0006c6e0,0x0007c000) I think it should not be "unknown subtype". This value is shown

RFR: JDK-8163580: Cannot get Monitor Cache Dump in HSDB

2016-08-10 Thread Yasumasa Suenaga
Hi all, When I chose "Monitor Cache Dump" menu in HSDB, I saw an Exception as below: Exception in thread "AWT-EventQueue-0" java.lang.ExceptionInInitializerError at sun.jvm.hotspot.ui.MonitorCacheDumpPanel.dumpOn(jdk.hotspot.agent@9-internal/MonitorCacheDumpPanel.java:92)

RE: RFR : JDK-8162530 : src/jdk.management/share/native/libmanagement_ext/GcInfoBuilder.c doesn't handle JNI exceptions properly

2016-08-10 Thread Amit Sapre
Hello, Well for some reason, unknown to me, JNI code checker is not complaining for exception thrown by SetObjectArrayElement. It complains for any pending exceptions before calling SetObjectArrayElement. I have added exceptions checks after calling SetObjectArrayElement. The updated changes

Re: RFR: JDK-8163143: illegal bci error with interpreted frames in SA due to mirror being stored in interpreted frames

2016-08-10 Thread Dmitry Samersoff
Jini, Code changes looks good for me. CC'in Goetz for PPC changes. BasicLauncherTest.java: I'm not sure we need two extra parameters to launch() just to check for jstack Assertion Failure. Please either create a separate launchJStack method or just check exit code of jhsdb jstack. -Dmitry

Re: RFR: JDK-8163346: Update jmap-hashcode/Test8028623.java for better diagnostic of timeout.

2016-08-10 Thread Dmitry Samersoff
Sharath, As soon as you request a heap dump of LingeredApp, LingeredApp should contains the object with extended characters in it's name. So please: 1. Inherit LingeredApp (See LingeredAppWithDeadlock as an example) and add public static int \u00CB = 1; 2. Copy BasicLauncherTest to

RFR: JDK-8163143: illegal bci error with interpreted frames in SA due to mirror being stored in interpreted frames

2016-08-10 Thread Jini Susan George
Hi all, Please do review the changes for the SA defect: https://bugs.openjdk.java.net/browse/JDK-8163143 The webrev is at: http://cr.openjdk.java.net/~sballal/sponsorship/8163143/webrev.00/ Need testing with PPC64 for this. I have implemented the changes but have not tested