Jini,

Code changes looks good for me.

CC'in Goetz for PPC changes.


BasicLauncherTest.java:

I'm not sure we need two extra parameters to launch() just to check for
jstack Assertion Failure.

Please either create a separate launchJStack method or just check exit
code of jhsdb jstack.

-Dmitry

On 2016-08-10 10:10, Jini Susan George wrote:
> Hi all,
> 
>  
> 
> Please do review the changes for the SA defect:
> 
>  
> 
> https://bugs.openjdk.java.net/browse/JDK-8163143
> 
>  
> 
> The webrev is at:
> 
>  
> 
> http://cr.openjdk.java.net/~sballal/sponsorship/8163143/webrev.00/
> 
>  
> 
> Need testing with PPC64 for this. I have implemented the changes but
> have not tested on PPC64.
> 
>  
> 
> Thank you,
> 
> - Jini Susan George
> 
>  
> 


-- 
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.

Reply via email to