t we have.
Thanks for all the discussion on this.
Cheers
Andrew
Andrew Leonard
Java Runtimes Development
IBM Hursley
IBM United Kingdom Ltd
internet email: andrew_m_leon...@uk.ibm.com
Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number
741598.
Hi Alan,
Was wondering if you had had a chance to look at this please?
Thanks
Andrew
Andrew Leonard
Java Runtimes Development
IBM Hursley
IBM United Kingdom Ltd
internet email: andrew_m_leon...@uk.ibm.com
From: Andrew Leonard/UK/IBM
To: Alan Bateman
Cc: serviceability-dev
Thanks Alan, much appreciated.
Andrew Leonard
Java Runtimes Development
IBM Hursley
IBM United Kingdom Ltd
internet email: andrew_m_leon...@uk.ibm.com
From: Alan Bateman
To: Andrew Leonard
Cc: serviceability-dev@openjdk.java.net
Date: 02/07/2019 07:45
Subject:Re: RFR
Any one able to review please?
Thanks
Andrew
Andrew Leonard
Java Runtimes Development
IBM Hursley
IBM United Kingdom Ltd
internet email: andrew_m_leon...@uk.ibm.com
From: Andrew Leonard/UK/IBM
To: Alan Bateman
Cc: serviceability-dev@openjdk.java.net
Date: 19/06/2019 18:29
blication", and avoids wasteful double
construction that was happening before.
SocketTransportService:
static class SocketListenKey extends ListenKey {
final ServerSocket ss;
==> Made "final" so that ListenKey returned by startListening() is
safe for publica
I'm going to persevere with this a bit more..
but first I need to better understand "safe publication"
Thanks
Andrew
Andrew Leonard
Java Runtimes Development
IBM Hursley
IBM United Kingdom Ltd
internet email: andrew_m_leon...@uk.ibm.com
From: Alan Bateman
To: And
will go and brush up!!
Should we create a separate bug to update the spec/doc to clarify the
position on JDI Connectors being non-thread-safe, or is the current
non-statement the normal stance on this one?
Thanks
Andrew
Andrew Leonard
Java Runtimes Development
IBM Hursley
IBM United Kingdo
stening on the SocketListen Connector is
a reasonable usecase? How would a debugger font-end UI handle it? I'm not
experienced enough with JDI, but my natural thought is it could be
reasonable to have a "front-end" listening on multiple TargetVM's and
handling them in a multi-
Andrew Leonard
Java Runtimes Development
IBM Hursley
IBM United Kingdom Ltd
internet email: andrew_m_leon...@uk.ibm.com
From: Alex Menkov
To: "serguei.spit...@oracle.com" , Andrew
Leonard
Cc: serviceability-dev@openjdk.java.net
Date: 13/06/2019 18:15
Subject:R
Thanks Serguei, i'll add those changes to my new webrev I am working on
based on Alan's suggestions. It should be ready once i've finished my
stress tests later today.
Cheers
Andrew
Andrew Leonard
Java Runtimes Development
IBM Hursley
IBM United Kingdom Ltd
internet email
Thanks again
Andrew
Andrew Leonard
Java Runtimes Development
IBM Hursley
IBM United Kingdom Ltd
internet email: andrew_m_leon...@uk.ibm.com
From: Alan Bateman
To: Andrew Leonard
Cc: serviceability-dev@openjdk.java.net
Date: 12/06/2019 10:54
Subject:Re: RFR JDK-8225474:
appy with it as it stands, i've thrashed the startListening
concurrency quite hard on xLinux and it now seems robust.
I am going to run some stress tests on some other platforms tomorrow,
Win64 and Mac if I can.
Is one of the JDI SME's able to review this please?
Thanks
Andrew
Andrew
Thanks Alex,
I have changed the testcase to allocate ports which makes better sense:
http://cr.openjdk.java.net/~aleonard/8225474/webrev.02/
Cheers
Andrew
Andrew Leonard
Java Runtimes Development
IBM Hursley
IBM United Kingdom Ltd
internet email: andrew_m_leon...@uk.ibm.com
From: Alex
issue with the "bug" was
corruption of the HashMap so that the accept() method incorrectly thought
the port was not being listened upon and then tried to do another
startListening().
Thoughts?
Thanks
Andrew
Andrew Leonard
Java Runtimes Development
IBM Hursley
IBM United Kingdom Ltd
inter
ports for each
run, equally it could also be an issue as pointed out by Alan.
Thanks
Andrew
Andrew Leonard
Java Runtimes Development
IBM Hursley
IBM United Kingdom Ltd
internet email: andrew_m_leon...@uk.ibm.com
From: Alex Menkov
To: Andrew Leonard ,
serviceability-dev@openjdk.java.net
thread-safe" that it should be assumed as "not-thread
safe"?
Thanks
Andrew
Andrew Leonard
Java Runtimes Development
IBM Hursley
IBM United Kingdom Ltd
internet email: andrew_m_leon...@uk.ibm.com
From: Alan Bateman
To: "serguei.spit...@oracle.com" , Andrew
Leonard ,
es it
reliably.
http://cr.openjdk.java.net/~aleonard/8225474/webrev.00
Thanks
Andrew
Andrew Leonard
Java Runtimes Development
IBM Hursley
IBM United Kingdom Ltd
internet email: andrew_m_leon...@uk.ibm.com
Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and
information.
Thanks
Andrew
Andrew Leonard
Java Runtimes Development
IBM Hursley
IBM United Kingdom Ltd
Phone internal: 245913, external: 01962 815913
internet email: andrew_m_leon...@uk.ibm.com
From: "serguei.spit...@oracle.com"
To: Andrew Leonard
Cc: serviceability-dev@
Hi Serguei,
Good find, i'll try it out and do some debugging.
Many thanks
Andrew
Andrew Leonard
Java Runtimes Development
IBM Hursley
IBM United Kingdom Ltd
Phone internal: 245913, external: 01962 815913
internet email: andrew_m_leon...@uk.ibm.com
From: "serguei.spit...@oracl
No Problem, thanks Serguei, let me know if I can help in any way.
Thanks
Andrew
Andrew Leonard
Java Runtimes Development
IBM Hursley
IBM United Kingdom Ltd
Phone internal: 245913, external: 01962 815913
internet email: andrew_m_leon...@uk.ibm.com
From: "serguei.spit...@oracle.com
Hi Serguei,
Do you need me to try anything else for this review?
hotspot/jtreg/serviceability suite run successfully.
Many Thanks
Andrew
Andrew Leonard
Java Runtimes Development
IBM Hursley
IBM United Kingdom Ltd
Phone internal: 245913, external: 01962 815913
internet email: andrew_m_leon
Hi Daniel,
Thanks for reviewing this. Just to let you know, I have successfully run
all the jdk_core and hotspot/jtreg/serviceability tests with this patch in
place.
Cheers
Andrew
Andrew Leonard
Java Runtimes Development
IBM Hursley
IBM United Kingdom Ltd
Phone internal: 245913, external: 01962
y not help..but hopefully helps explain things a bit? It's the
timing of the resume command during the test that is crucial, resuming
before the VM initialization is complete will trigger it.
Thanks
Andrew
Andrew Leonard
Java Runtimes Development
IBM Hursley
IBM United Kingdom Ltd
Phone intern
that will always "fail" if the fix
is not present.
Your thoughts?
Cheers
Andrew
Andrew Leonard
Java Runtimes Development
IBM Hursley
IBM United Kingdom Ltd
Phone internal: 245913, external: 01962 815913
internet email: andrew_m_leon...@uk.ibm.com
From: "sergu
ecreated: JDK11
Thanks
Andrew
Andrew Leonard
Java Runtimes Development
IBM Hursley
IBM United Kingdom Ltd
Phone internal: 245913, external: 01962 815913
internet email: andrew_m_leon...@uk.ibm.com
From: "serguei.spit...@oracle.com"
To: Andrew Leonard ,
serviceability-dev@openj
ds.
Thanks
Andrew
Andrew Leonard
Java Runtimes Development
IBM Hursley
IBM United Kingdom Ltd
Phone internal: 245913, external: 01962 815913
internet email: andrew_m_leon...@uk.ibm.com
From: David Holmes
To: Andrew Leonard ,
serviceability-dev@openjdk.java.net
Date: 10/04/2018 02:
JDWP_COMMAND_SET(Event),
JDWP_COMMAND(Event, Composite));
Andrew Leonard
Java Runtimes Development
IBM Hursley
IBM United Kingdom Ltd
Phone internal: 245913, external: 01962 815913
internet email: andrew_m_leon...@uk.ibm.com
Unless stated otherwise ab
looks good
Cheers
Andrew Leonard
Java Runtimes Development
IBM Hursley
IBM United Kingdom Ltd
Phone internal: 245913, external: 01962 815913
internet email: andrew_m_leon...@uk.ibm.com
From: "Langer, Christoph"
To: OpenJDK Dev list ,
"serviceability-dev@openjdk
Thank you Christoph
Andrew Leonard
Java Runtimes Development
IBM Hursley
IBM United Kingdom Ltd
Phone internal: 245913, external: 01962 815913
internet email: andrew_m_leon...@uk.ibm.com
From: "Langer, Christoph"
To: David Holmes , Andrew Leonard
, "ser
gement/jdp/JdpController.java
@@ -34,7 +34,6 @@
import java.lang.reflect.Field;
import java.lang.reflect.Method;
import java.lang.UnsupportedOperationException;
-import sun.management.VMManagement;
/**
* JdpController is responsible to create and manage a broadcast loop.
Andrew Leonard
Java Runtimes D
. I also see if I
look at the javadoc for ProcessHandle.pid() that it can in "theory" return
UnsupportOperationException, so I have also handled that. I have a new
webrev, which I will ask Christoph to upload...
Thanks
Andrew
Andrew Leonard
Java Runtimes Development
IBM Hursley
IBM U
Thanks Christoph,
Any offers for another reviewer of this fix please, it's only a few lines
of code change.
Thanks
Andrew
Andrew Leonard
Java Runtimes Development
IBM Hursley
IBM United Kingdom Ltd
Phone internal: 245913, external: 01962 815913
internet email: andrew_m_leon...@uk.ib
==
TEST SUCCESS
Cheers
Andrew
Andrew Leonard
Java Runtimes Development
IBM Hursley
IBM United Kingdom Ltd
Phone internal: 245913, external: 01962 815913
internet email: andrew_m_leon...@uk.ibm.com
From: "Langer, Christoph"
To: Andrew L
with call to
ProcessHandle.current().getPid().
- Update testcase to cover the failing scenario. Thus it fails without my
patch, and succeeds with it.
Thanks
Andrew
Andrew Leonard
Java Runtimes Development
IBM Hursley
IBM United Kingdom Ltd
Phone internal: 245913, external: 01962 815913
internet
Thanks Roger for taking a look, i'll see what the serviceability community
think,
cheers
Andrew
Andrew Leonard
Java Runtimes Development
IBM Hursley
IBM United Kingdom Ltd
Phone internal: 245913, external: 01962 815913
internet email: andrew_m_leon...@uk.ibm.com
From: Roger Rigg
rent process id
> return (int)ProcessHandle.current().getPid();
I'd appreciate any feedback please, and help obtaining a suitable sponsor
and contributor?
Thanks
Andrew
Andrew Leonard
Java Runtimes Development
IBM Hursley
IBM United Kingdom Ltd
Phone internal: 245913, extern
36 matches
Mail list logo
