Re: hg: hsx/hotspot-rt/hotspot: 8012927: 'assert(nbits == 32 || (-(1 nbits-1) = x x ( 1 nbits-1))) failed: value out of range' in interpreter initialization.

Hi Jiangli, that's really sad! First because it is not the way it is supposed to work and second because we detected and fixed this same problem a few days ago as well.. I don't understand what's the problem to post a review request on the list and get the reviews by mail. That shouldn't take

Re: Project to improve hs_err files

Hi Mattis, just some quick comments: On Fri, Sep 6, 2013 at 1:32 PM, Mattis Castegren mattis.casteg...@oracle.com wrote: Hi (re-sending mail after joining the mailing lists, sorry if you get this mail twice) My name is Mattis and I work with the JVM sustaining engineering team at

Re: [OpenJDK 2D-Dev] RFR(L): 8024854: Basic changes and files to build the class library on AIX

for sure that hotspot and core-libs teams both agree to this approach and whether there is an alternative. -phil. On 9/19/13 4:29 AM, Volker Simonis wrote: Hi Phil, thank you for looking at the changes. Please find my answers inline: /* AIX does not provide the 'dladdr' function

Re: [OpenJDK 2D-Dev] RFR(L): 8024854: Basic changes and files to build the class library on AIX

or hotspot teams ? No, I didn't got any opinions on that topic. I'm currently preparing a new webrev for the second review round where we can then hopefully clarify that point. Thank you and best regards, Volker -phil. On 9/19/2013 7:28 AM, Volker Simonis wrote: Hi Phil, I'm open to any good

RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX

Hi, this is the second review round for 8024854: Basic changes and files to build the class library on AIXhttps://bugs.openjdk.java.net/browse/JDK-8024854. The previous reviews can be found at the end of this mail in the references section. I've tried to address all the comments and suggestions

Re: RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX

Hi Alan, thanks a lot for the fast review and your valuable comments. Please find my answers inline: On Thu, Nov 21, 2013 at 1:01 PM, Alan Bateman alan.bate...@oracle.comwrote: On 20/11/2013 18:26, Volker Simonis wrote: Hi, this is the second review round for 8024854: Basic changes

Re: RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX

/OperatingSystemImpl.c. Fortunately, my changes to UnixOperatingSystem_md.c described in the webrev apply cleanly to the new file (I've tested this locally). I'll update the webrev accordingly once I've collected some more feedback. Thank you and best regards, Volker On Wed, Nov 20, 2013 at 7:26 PM, Volker Simonis

Re: RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX

reviewed the 'core-lib'/'net' parts right? That would mean that I'll still need a review from the AWT/2D and the Security group - any volunteers:). Once again thanks a lot for your help, Volker On Fri, Nov 22, 2013 at 2:24 PM, Alan Bateman alan.bate...@oracle.com wrote: On 21/11/2013 15:54, Volker

Re: RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX

PM, Volker Simonis wrote: Hi, this is the second review round for 8024854: Basic changes and files to build the class library on AIX https://bugs.openjdk.java.net/browse/JDK-8024854. The previous reviews can be found at the end of this mail in the references section. I've tried to address

Re: RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX

/20/2013 01:26 PM, Volker Simonis wrote: Hi, this is the second review round for 8024854: Basic changes and files to build the class library on AIXhttps://bugs.openjdk.java.net/browse/JDK-8024854. The previous reviews can be found at the end of this mail in the references section. I've

Re: [OpenJDK 2D-Dev] RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX

is already in place. I'll prepare and test a finaly webrev with all the changes from this review round today. Thanks a lot, Volker -phil. On 11/20/2013 10:26 AM, Volker Simonis wrote: Hi, this is the second review round for 8024854: Basic changes and files to build the class library

Re: RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX

()' as suggested by Alan. The changes to src/solaris/native/com/sun/ management/UnixOperatingSystem_md.c are now in src/solaris/native/sun/management/OperatingSystemImpl.c because that file was moved by an upstream change. On Wed, Nov 20, 2013 at 7:26 PM, Volker Simonis volker.simo...@gmail.comwrote

TEST: java/util/logging/LoggerWeakRefLeak.sh

Hi, the test 'java/util/logging/LoggerWeakRefLeak.sh' checks for the availability of the '-histo:live' option in jmap which is only available if the SA is available. However I don't think that it should be an error if the option isn't supported because of a missing SA implementation on a

Re: TEST: java/util/logging/LoggerWeakRefLeak.sh

Sorry, I forgot to mention that the same problem holds true for the test java/util/logging/AnonLoggerWeakRefLeak.sh as well. And it can be fixed in the same way as proposed for LoggerWeakRefLeak.sh. Volker On Wed, Dec 18, 2013 at 5:44 PM, Volker Simonis volker.simo...@gmail.com wrote: Hi

Re: TEST: java/util/logging/LoggerWeakRefLeak.sh

On Wed, Dec 18, 2013 at 5:58 PM, Alan Bateman alan.bate...@oracle.com wrote: On 18/12/2013 16:44, Volker Simonis wrote: Hi, the test 'java/util/logging/LoggerWeakRefLeak.sh' checks for the availability of the '-histo:live' option in jmap which is only available if the SA is available

RFR(L): 8031581: PPC64: Addons and fixes for AIX to pass the jdk regression tests

Hi, could you please review the following changes for the ppc-aix-port stage/stage-9 repositories (the changes are planned for integration into ppc-aix-port/stage-9 and subsequent backporting to ppc-aix-port/stage): http://cr.openjdk.java.net/~simonis/webrevs/8031581/ I've build and smoke

Re: RFR(L): 8031581: PPC64: Addons and fixes for AIX to pass the jdk regression tests

Hi Alan, On Tue, Jan 14, 2014 at 10:19 AM, Alan Bateman alan.bate...@oracle.comwrote: On 14/01/2014 08:40, Volker Simonis wrote: Hi, could you please review the following changes for the ppc-aix-port stage/stage-9 repositories (the changes are planned for integration into ppc-aix-port

Re: RFR(L): 8031581: PPC64: Addons and fixes for AIX to pass the jdk regression tests

' in the static initializers of the corresponding classes? I think that shouldn't introduce too much overhead and I could get rid of all the ugly conversion code. Regards, Volker David On 14/01/2014 6:40 PM, Volker Simonis wrote: Hi, could you please review the following changes for the ppc-aix

Re: RFR(L): 8031581: PPC64: Addons and fixes for AIX to pass the jdk regression tests

On Wed, Jan 15, 2014 at 10:03 AM, Alan Bateman alan.bate...@oracle.comwrote: On 15/01/2014 06:24, David Holmes wrote: I'm not a fan of runtime checks of this kind though if it is only a very samll number of values it might be okay. Another option would be to make those classes into

Re: RFR(L): 8031581: PPC64: Addons and fixes for AIX to pass the jdk regression tests

/META-INF/services/com.sun.tools.attach.spi.AttachProvider No comments. Thanks, /Staffan On 14 jan 2014, at 09:40, Volker Simonis volker.simo...@gmail.com wrote: Hi, could you please review the following changes for the ppc-aix-port stage/stage-9 repositories (the changes are planned

Re: RFR(L): 8031581: PPC64: Addons and fixes for AIX to pass the jdk regression tests

On Wed, Jan 15, 2014 at 6:27 PM, Volker Simonis volker.simo...@gmail.com wrote: On Wed, Jan 15, 2014 at 5:34 PM, Volker Simonis volker.simo...@gmail.com wrote: Hi Staffan, thanks for the review. Please find my comments inline: On Wed, Jan 15, 2014 at 9:57 AM, Staffan Larsen staffan.lar

Re: RFR(L): 8031581: PPC64: Addons and fixes for AIX to pass the jdk regression tests

On Wed, Jan 15, 2014 at 12:05 PM, Volker Simonis volker.simo...@gmail.comwrote: On Wed, Jan 15, 2014 at 10:03 AM, Alan Bateman alan.bate...@oracle.comwrote: On 15/01/2014 06:24, David Holmes wrote: I'm not a fan of runtime checks of this kind though if it is only a very samll number

Re: RFR(L): 8031581: PPC64: Addons and fixes for AIX to pass the jdk regression tests

On Thu, Jan 16, 2014 at 11:05 AM, Alan Bateman alan.bate...@oracle.com wrote: On 16/01/2014 09:38, Volker Simonis wrote: Hi Alan, I think sun.nio.ch.IOUtil seems even more appropriate to me for these constants. What do you think? Would it be OK for you if I initialize them right

Re: RFR(L): 8031581: PPC64: Addons and fixes for AIX to pass the jdk regression tests

On Tue, Jan 14, 2014 at 10:19 AM, Alan Bateman alan.bate...@oracle.com wrote: On 14/01/2014 08:40, Volker Simonis wrote: Hi, could you please review the following changes for the ppc-aix-port stage/stage-9 repositories (the changes are planned for integration into ppc-aix-port/stage-9

Re: RFR(L): 8031581: PPC64: Addons and fixes for AIX to pass the jdk regression tests

On Fri, Jan 17, 2014 at 10:15 PM, Volker Simonis volker.simo...@gmail.com wrote: On Tue, Jan 14, 2014 at 10:19 AM, Alan Bateman alan.bate...@oracle.com wrote: On 14/01/2014 08:40, Volker Simonis wrote: Hi, could you please review the following changes for the ppc-aix-port stage/stage-9

Re: RFR(L): 8031581: PPC64: Addons and fixes for AIX to pass the jdk regression tests

On Mon, Jan 20, 2014 at 12:41 PM, Alan Bateman alan.bate...@oracle.com wrote: On 20/01/2014 09:59, Volker Simonis wrote: : Hi Alan, yes, that's interesting. Sounds like a very similar problem on Mac. I would suggest the following: I cut out the Async Close AIX FIX stuff from this change

Re: RFR(L): 8031581: PPC64: Addons and fixes for AIX to pass the jdk regression tests

On Mon, Jan 20, 2014 at 4:24 PM, Alan Bateman alan.bate...@oracle.com wrote: On 20/01/2014 13:45, Volker Simonis wrote: : Hi everybody, so here's the second version of this webrev: http://cr.openjdk.java.net/~simonis/webrevs/8031581_2/ This looks okay to me. Thanks. The typo (legel

Re: Why do we need both - export maps AND -fvisibility=hidden/__attribute__((visibility(default)))

interested. Regards, Volker David Jeremy On Tue, Feb 4, 2014 at 4:51 PM, David Holmes david.hol...@oracle.com mailto:david.hol...@oracle.com wrote: Hi Volker, On 5/02/2014 2:18 AM, Volker Simonis wrote: I know this is an old topic and actually I was involved myself

Re: Project to improve hs_err files

On Wed, Feb 12, 2014 at 2:14 PM, Nils Eliasson nils.elias...@oracle.com wrote: On 2013-09-06 13:32, Mattis Castegren wrote: ... * Bigger changes - Re-structure hs_err file ... Yes, please move the compiler related info together. Having the current compiler task separated from the

Re: Project to improve hs_err files

On Wed, Feb 12, 2014 at 6:30 PM, Nils Eliasson nils.elias...@oracle.com wrote: On 2014-02-12 15:28, Volker Simonis wrote: On Wed, Feb 12, 2014 at 2:14 PM, Nils Eliasson nils.elias...@oracle.com wrote: On 2013-09-06 13:32, Mattis Castegren wrote: ... * Additional Data ... Make

Re: RFR(XS): JDK-8034867 - Object references from expression stack are not visible as roots via jvmti FollowReferences and HeapDump

Axel is covered by the SAP OCA. Thanks, Volker On Thu, Feb 20, 2014 at 6:30 AM, serguei.spit...@oracle.com serguei.spit...@oracle.com wrote: It looks good to me too. But does Axel need to sign an OCA ? This is a link to follow: http://openjdk.java.net/contribute/ Thanks, Serguei

Re: RFR(XS): JDK-8034867 - Object references from expression stack are not visible as roots via jvmti FollowReferences and HeapDump

Message- From: Volker Simonis [mailto:volker.simo...@gmail.com] Sent: Donnerstag, 20. Februar 2014 09:21 To: serguei.spit...@oracle.com Cc: Coleen Phillimore; hotspot-runtime-...@openjdk.java.net; serviceability-dev@openjdk.java.net; Siebenborn, Axel Subject: Re: RFR(XS): JDK-8034867

Re: RFR(XS): JDK-8034867 - Object references from expression stack are not visible as roots via jvmti FollowReferences and HeapDump

On Mon, Feb 24, 2014 at 10:16 AM, Staffan Larsen staffan.lar...@oracle.com wrote: On 24 feb 2014, at 09:39, Volker Simonis volker.simo...@gmail.com wrote: Hi Serguei, thanks a lot for sponsoring this change. It seems that https://bugs.openjdk.java.net/browse/INTJDK-7609362 is not visible

RFR(S): 8038233 : Fix unsafe strcpy in Java_sun_tools_attach_{Aix, Bsd, Linux}VirtualMachine_connect()

Hi, a security audit for the PPC64/AIX port revealed an unsecure useage of 'strcpy' in Java_sun_tools_attach_AixVirtualMachine_connect(). Because the same coding is also used in the Linux and BSD implementations, the following change fixes them all together:

Re: RFR(S): 8038233 : Fix unsafe strcpy in Java_sun_tools_attach_{Aix, Bsd, Linux}VirtualMachine_connect()

with possibly not expected permissions. -Dmitry On 2014-03-27 22:08, Volker Simonis wrote: Hi, a security audit for the PPC64/AIX port revealed an unsecure useage of 'strcpy' in Java_sun_tools_attach_AixVirtualMachine_connect(). Because the same coding is also used in the Linux and BSD

Re: RFR(S): 8038233 : Fix unsafe strcpy in Java_sun_tools_attach_{Aix, Bsd, Linux}VirtualMachine_connect()

Hi Alan, thanks for the review. On Thu, Mar 27, 2014 at 7:31 PM, Alan Bateman alan.bate...@oracle.com wrote: On 27/03/2014 18:08, Volker Simonis wrote: Hi, a security audit for the PPC64/AIX port revealed an unsecure useage of 'strcpy' in Java_sun_tools_attach_AixVirtualMachine_connect

Re: Fwd: PowerPC issue: Some JVMTI dynamic code generated events have code size of zero

PM, Maynard Johnson mayna...@us.ibm.com wrote: On 07/02/2014 01:21 PM, Volker Simonis wrote: After a quick look I can say that at least for the flush_icache_stub and verify_oop cases we indeed generate no code. Other platforms like x86 for example generate code for instruction cache flushing

RFR(S): 8049715: PPC64: First steps to enable SA on Linux/PPC64

Hi, could someone please review and sponsor the following change which does some preliminary work for enabling the SA agent on Linux/PPC64: http://cr.openjdk.java.net/~simonis/webrevs/8049715/ https://bugs.openjdk.java.net/browse/JDK-8049715 Details: Currently, we don't support the SA agent on

Re: PowerPC: core file option not available with serviceability tools

On Wed, Jul 9, 2014 at 3:45 PM, Maynard Johnson mayna...@us.ibm.com wrote: On 07/04/2014 10:59 AM, Volker Simonis wrote: Hi Maynard, we (i.e. SAP) do not currently support the SA agent on Linux/PPC64 and AIX (we have other proprietary servicibility tools). Because of that (and because SA

Re: RFR(S): 8049715: PPC64: First steps to enable SA on Linux/PPC64

, Comments below where you might expect them :) On 10/07/2014 3:36 AM, Volker Simonis wrote: Hi, could someone please review and sponsor the following change which does some preliminary work for enabling the SA agent on Linux/PPC64: http://cr.openjdk.java.net/~simonis/webrevs/8049715

8046282: SA update seems to break the SA/jstack in OpenJDK

Hi, the change 8046282: SA update introduced the following new code in agent/src/share/classes/sun/jvm/hotspot/oops/Klass.java +traceIDField = type.getField(_trace_id); But I can not find the corresponding field in src/share/vm/oops/klass.hpp. The Klass class only contains the macro

Re: 8046282: SA update seems to break the SA/jstack in OpenJDK

to have it fixed. See. https://bugs.openjdk.java.net/browse/JDK-8049881 Thanks for reporting Erik Volker Simonis skrev 2014-07-10 12:30: Hi, the change 8046282: SA update introduced the following new code in agent/src/share/classes/sun/jvm/hotspot/oops/Klass.java +traceIDField

Re: RFR(S): 8049715: PPC64: First steps to enable SA on Linux/PPC64

On Fri, Jul 11, 2014 at 6:36 AM, David Holmes david.hol...@oracle.com wrote: Hi Volker, On 10/07/2014 8:12 PM, Volker Simonis wrote: Hi David, thanks for looking at this. Here's my new version of the change with some of your suggestions applied: http://cr.openjdk.java.net/~simonis

Re: RFR(S): 8049715: PPC64: First steps to enable SA on Linux/PPC64

= ADD_SA_BINARIES/zero = OK, but then I also remove IA64 as it isn't an open platform either: http://cr.openjdk.java.net/~simonis/webrevs/8049715.v4/ I've also added Vladimir as reviewer. Thank you and best regards, Volker Thanks, David On 11/07/2014 9:54 PM, Volker Simonis wrote: On Fri, Jul

Re: RFR(XS): 8049441: PPC64: Don't use StubCodeMarks for zero-length stubs

Hi everybody, can somebody PLEASE review and sponsor this tiny, ppc64-only change. Thanks, Volker On Tue, Jul 8, 2014 at 5:45 PM, Daniel D. Daugherty daniel.daughe...@oracle.com wrote: Adding the Serviceability Team since JVM/TI belongs to them. Dan On 7/8/14 9:41 AM, Volker Simonis

Re: RFR(S): 8049715: PPC64: First steps to enable SA on Linux/PPC64

Great! Thanks a lot, Volker On Tue, Jul 15, 2014 at 12:56 AM, David Holmes david.hol...@oracle.com wrote: All changes (hotspot and top-level) are now in the jdk9/hs-rt forest. David On 14/07/2014 9:09 PM, David Holmes wrote: On 14/07/2014 7:44 PM, Volker Simonis wrote: On Sun, Jul 13

Re: RFR(XS): 8049441: PPC64: Don't use StubCodeMarks for zero-length stubs

Hi Serguei, thanks for sponsoring! So just waiting for another reviewer. Anybody volunteers:) Regards, Volker On Tue, Jul 15, 2014 at 11:09 AM, serguei.spit...@oracle.com serguei.spit...@oracle.com wrote: On 7/15/14 1:48 AM, Volker Simonis wrote: On Mon, Jul 14, 2014 at 10:35 PM

Re: Fwd: PowerPC issue: Some JVMTI dynamic code generated events have code size of zero

on the status of this bug. Thanks. -Maynard Regards, Volker On Mon, Jul 7, 2014 at 4:18 PM, Maynard Johnson mayna...@us.ibm.com wrote: On 07/02/2014 01:21 PM, Volker Simonis wrote: After a quick look I can say that at least for the flush_icache_stub and verify_oop cases we indeed generate

Re: Problem generating C header file for Hotspot debugger PPC64ThreadContext class

Hy Maynard, sorry, but I think you edited the wrong Make file (that's why you saw no effect - neither positive nor negative:) The right Makefile is hotspot/make/linux/makefiles/sa.make. If you add your new Thread context class to the 'javah' rules at the end of the file it should work. I

Re: RFR: 8057776 Misc cleanups of the attach code

/classes/sun/tools/attach/VirtualMachineImpl.java. On 8 sep 2014, at 14:48, Volker Simonis volker.simo...@gmail.com wrote: hi Staffen, the change looks good, but could you please also change src/jdk.attach/aix/classes/sun/tools/attach/AttachProviderImpl.java Thanks, Volker On Mon, Sep

Re: PowerPC: core file option not available with serviceability tools

pointer (i.e. the ebp register points to the last frame pointer while (frame pointer - 1) points to the return pc. Regards, Volker On Tue, Sep 30, 2014 at 12:42 AM, Maynard Johnson mayna...@us.ibm.com wrote: On 07/09/2014 12:38 PM, Volker Simonis wrote: On Wed, Jul 9, 2014 at 3:45 PM, Maynard

Re: RFR(XS): 8059868: JVM crashes on attach on Windows when compiled with /RTC1

Hi, the change looks good to me. I can also sponsor this change. Nevertheless I'd like to get one more opinion from the serviceability group. Thanks, Volker On Tue, Oct 7, 2014 at 4:27 PM, Thomas Stüfe thomas.stu...@gmail.com wrote: (the corresponding bug report is

Re: RFR(XS): 8059868: JVM crashes on attach on Windows when compiled with /RTC1

Thanks Alan, Staffan, I'll push the change with the spacing adjusted as suggested by Alan. Regards, Volker On Wed, Oct 8, 2014 at 9:33 AM, Staffan Larsen staffan.lar...@oracle.com wrote: Looks good! Thanks, /Staffan On 7 okt 2014, at 16:26, Thomas Stüfe thomas.stu...@gmail.com wrote:

Re: system profilers and incomplete stacks

Hi, I think the main problem here is not only that compiled code uses the frame pointer as a general purpose register, but the fact that even the VM itself currently can not reliably take a stack trace of a thread at any arbitrary PC. An external sampling profiler like perf can interrupt the VM

Re: PowerPC: core file option not available with serviceability tools

On Fri, Nov 14, 2014 at 6:00 PM, Maynard Johnson mayna...@us.ibm.com wrote: On 10/07/2014 08:35 AM, Maynard Johnson wrote: On 10/07/2014 03:58 AM, Volker Simonis wrote: Hi Maynard, I'm now back from JavaOne and can look at this issue. Could you please share your current implementation so I

Re: [PATCH RFC 0/2] Add linux/ppc64 support for Hotspot serviceability agent to read core files

On Friday, November 14, 2014, Vladimir Kozlov vladimir.koz...@oracle.com wrote: Volker or Goetz, can you help Maynard to create bugs and prepare webrevs on cr.openjdk for these 3 changes? I will create the bugs and have look at the changes on monday. Regards, Volker Thanks, Vladimir On

Re: [PATCH RFC 0/2] Add linux/ppc64 support for Hotspot serviceability agent to read core files

Hi Maynard, I'm currently looking at your changes. At first glance they look good. I could open a simple core file which contained both, interpreted and compiled frames: $ jstack ./images/j2sdk-image/bin/java core.7034 ... Thread 7035: (state = IN_VM) - sun.misc.Unsafe.putAddress(long, long)

Re: [PATCH RFC 0/2] Add linux/ppc64 support for Hotspot serviceability agent to read core files

On Mon, Nov 17, 2014 at 6:59 PM, Maynard Johnson mayna...@us.ibm.com wrote: On 11/17/2014 10:20 AM, Volker Simonis wrote: Hi Maynard, I'm currently looking at your changes. At first glance they look good. I could open a simple core file which contained both, interpreted and compiled frames

Re: [PATCH RFC 0/2] Add linux/ppc64 support for Hotspot serviceability agent to read core files

=0x3fffa000f518) test.main(test.java:56) I'll keep you informed once I fixed the problem (I'll also look into the .opd issue afterwards). Regards, Volker On Tue, Nov 18, 2014 at 12:20 AM, Maynard Johnson mayna...@us.ibm.com wrote: On 11/17/2014 01:21 PM, Volker Simonis wrote: On Mon, Nov 17

Re: [PATCH RFC 0/2] Add linux/ppc64 support for Hotspot serviceability agent to read core files

/hotspot/tools/jcore/*.java \ $(AGENT_SRC_DIR)/sun/jvm/hotspot/tools/soql/*.java \ On Wed, Nov 19, 2014 at 7:33 PM, Volker Simonis volker.simo...@gmail.com wrote: Hi Maynard, I just wanted to let you know that I'm still working on fixing the bogus entries in the stack trace. I'm pretty sure

Re: [PATCH RFC 0/2] Add linux/ppc64 support for Hotspot serviceability agent to read core files

PM, Maynard Johnson mayna...@us.ibm.com wrote: On 11/20/2014 05:03 AM, Volker Simonis wrote: Hy Maynard, I've just realized that in your patch the two directory patterns $(AGENT_SRC_DIR)/sun/jvm/hotspot/runtime/linux_ppc64/*.java and $(AGENT_SRC_DIR)/sun/jvm/hotspot/runtime/ppc64/*.java

Re: [PATCH RFC 0/2] Add linux/ppc64 support for Hotspot serviceability agent to read core files

On Wed, Dec 3, 2014 at 7:33 PM, Maynard Johnson mayna...@us.ibm.com wrote: On 12/03/2014 02:40 AM, Volker Simonis wrote: On Tue, Dec 2, 2014 at 9:50 PM, Maynard Johnson mayna...@us.ibm.com wrote: On 12/02/2014 11:45 AM, Volker Simonis wrote: Hi Maynard, did you intentionally answered only

Re: [PATCH RFC 0/2] Add linux/ppc64 support for Hotspot serviceability agent to read core files

On Wed, Dec 3, 2014 at 7:50 PM, Andrew Haley a...@redhat.com wrote: On 12/03/2014 06:20 PM, Maynard Johnson wrote: If you're running on Debian/Ubuntu it is probably this issue: https://wiki.ubuntu.com/SecurityTeam/Roadmap/KernelHardening#ptrace_Protection which can be solved by doing:

Re: [PATCH RFC 0/2] Add linux/ppc64 support for Hotspot serviceability agent to read core files

On Wed, Dec 3, 2014 at 7:55 PM, Maynard Johnson mayna...@us.ibm.com wrote: On 12/03/2014 12:33 PM, Maynard Johnson wrote: On 12/03/2014 02:40 AM, Volker Simonis wrote: On Tue, Dec 2, 2014 at 9:50 PM, Maynard Johnson mayna...@us.ibm.com wrote: In the approximate 10 times that I re-ran my test

RFR(L): 8049716: PPC64: Implement SA on Linux/PPC64

Hi, I'd like to submit this webrev which adds support for the SA agent on Linux/PPC64 on behalf of Maynard Johnson who is the main author of the change: http://cr.openjdk.java.net/~simonis/webrevs/8049716 https://bugs.openjdk.java.net/browse/JDK-8049716 I have already reviewed and tested the

Re: RFR(L): 8049716: PPC64: Implement SA on Linux/PPC64

file. if (try_debuginfo) { #endif -- Here I think we should do as you suggest: #if defined(ppc64) !defined(ABI_ELFv2) -Maynard Sorry for the late notice. Sasha On Thu, Dec 4, 2014 at 9:50 AM, Volker Simonis volker.simo...@gmail.com wrote: Hi, I'd like

Re: A hotspot patch for stack profiling (frame pointer)

(unless you disable inlining, but that can cost 40% performance). There is the other issue Volker Simonis mentioned as well, where some stacks may not be profiled correctly. And, if you are unlucky, symbols can move during the profile, so any static perf-map-agent map will translate some incorrectly

Re: A hotspot patch for stack profiling (frame pointer)

suitable for profiling since has a very high overhead (it attaches a debugger to the process). /Staffan On 5 dec 2014, at 20:22, Volker Simonis volker.simo...@gmail.com wrote: Hi Brendan, I'm still not understanding who is taking the actual stack traces (let alone the symbols) in your

Re: A hotspot patch for stack profiling (frame pointer)

On Mon, Dec 8, 2014 at 4:05 PM, Maynard Johnson mayna...@us.ibm.com wrote: On 12/05/2014 05:09 PM, Brendan Gregg wrote: G'Day Volker, On Fri, Dec 5, 2014 at 11:22 AM, Volker Simonis volker.simo...@gmail.com wrote: Hi Brendan, I'm still not understanding who is taking the actual stack

Re: RFR(L): 8049716: PPC64: Implement SA on Linux/PPC64

Hi, can somebody from the serviceability team please review this webrev? http://cr.openjdk.java.net/~simonis/webrevs/8049716 https://bugs.openjdk.java.net/browse/JDK-8049716 The shared changes are really all trivial. Thanks, Volker On Fri, Dec 5, 2014 at 4:01 PM, Volker Simonis volker.simo

Re: RFR(L): 8049716: PPC64: Implement SA on Linux/PPC64

/classes/sun/jvm/hotspot/runtime/ppc64/PPC64JavaCallWrapper.java - no comments * agent/src/share/classes/sun/jvm/hotspot/runtime/ppc64/PPC64RegisterMap.java - no comments -Dmitry On 2014-12-09 21:10, Volker Simonis wrote: Hi, can somebody from the serviceability team please review

Re: RFR(L): 8049716: PPC64: Implement SA on Linux/PPC64

, /Staffan On 17 dec 2014, at 19:06, Dmitry Samersoff dmitry.samers...@oracle.com wrote: Volker, The changes looks good for me and I'll sponsor the push. But please check, whether you need one more reviewer or not. -Dmitry On 2014-12-17 20:37, Volker Simonis wrote: Hi Dmitry, once again

Re: gdb and OpenJDK

Hi Jeremy, nice to see that somebody is working on this topic. Can you please detail a little bit on how this would work? As far as I understand you extend gdb to support frame undwinder plugins written in Python. One of these plugins, which you want to contribute to the OpenJDK, can be used to

Re: gdb and OpenJDK

Hi everybody, I really don't want to prevent the Good Enough solution and as far as I understand, this solution doesn't require any code changes to HotSpot, right? It will just add an additional Python artifact to the OpenJDK delivery which will be used by gdb. But in general I have to agree

Re: RFR(XS): 8071687: AIX port of 8039173: Propagate errors from Diagnostic Commands as exceptions in the attach framework

No problem:) Thanks for the review, Volker On Tue, Mar 17, 2015 at 7:55 PM, Staffan Larsen staffan.lar...@oracle.com wrote: Looks good to me. Sorry I didn’t do those changes as well. /Staffan On 17 mar 2015, at 18:40, Volker Simonis volker.simo...@gmail.com wrote: Hi, can I please have

RFR(XS): 8071687: AIX port of 8039173: Propagate errors from Diagnostic Commands as exceptions in the attach framework

Hi, can I please have a review for this AIX-only change. It is an exact copy of the changes done in 8039173: Propagate errors from Diagnostic Commands as exceptions in the attach framework into the corresponding AIX files. http://cr.openjdk.java.net/~simonis/webrevs/2015/8071687

RFR(XS): 8079510: AIX: fix build after '8042901: Allow com.sun.management to be in a different module...'

Hi, can somebody please review this trivial AIX-only change which fixes an AIX build error: http://cr.openjdk.java.net/~simonis/webrevs/2015/8079510/ https://bugs.openjdk.java.net/browse/JDK-8079510 Here are the details: Change '8042901: Allow com.sun.management to be in a different module to

Re: (S) RFR: 8159461: bigapps/Kitchensink/stressExitCode hits assert: Must be VMThread or JavaThread

Hi David, looks good now. Thanks, Volker On Fri, Aug 5, 2016 at 4:28 AM, David Holmes <david.hol...@oracle.com> wrote: > Hi Volker, > > Thanks for looking at this. > > On 5/08/2016 1:48 AM, Volker Simonis wrote: >> >> Hi David, >> >> thanks for d

Re: 8173941 Re: SA does not work if executable is DSO

On Fri, Feb 10, 2017 at 10:40 AM, Andrew Haley wrote: > On 10/02/17 03:13, Yasumasa Suenaga wrote: >> We can calculate start address of executable (java command) through entry >> point. >> I updated webrev: >> >> http://cr.openjdk.java.net/~ysuenaga/JDK-8173941/webrev.01/ >> >>

Re: 8173941 Re: SA does not work if executable is DSO

On Fri, Feb 10, 2017 at 2:44 PM, Andrew Haley <a...@redhat.com> wrote: > On 10/02/17 13:21, Volker Simonis wrote: >> @Andrew: as this bug is assigned to you, I'd suggest to change it's >> status to open, the priority to P3 and target it for 9 (i.e. Fix >> Version = 9

Re: (S) RFR: 8159461: bigapps/Kitchensink/stressExitCode hits assert: Must be VMThread or JavaThread

Hi David, thanks for doing this change on all platforms. The fix looks good. Maybe you can just extend the following comment with something like: // Note that the SR_lock plays no role in this suspend/resume protocol. // It is only used in SR_handler as a thread termination indicator if

Why doesn't jdk.hotspot.agent export anything?

Hi, I understand that the SA API is an unofficial, unsupported API which is constantly evolving and changing. But at least its JavaDoc has been made available recently [1] (and I really welcome and appreciate that). Unfortunately, with Java 9 and the new module system it becomes very

Re: Why doesn't jdk.hotspot.agent export anything?

On Thu, Mar 2, 2017 at 10:00 AM, Alan Bateman <alan.bate...@oracle.com> wrote: > On 01/03/2017 13:23, Volker Simonis wrote: > >> Hi, >> >> I understand that the SA API is an unofficial, unsupported API which >> is constantly evolving and changing. But a

Re: @HotSpotIntrinsicCandidate and native prefixes

On Thu, Mar 23, 2017 at 10:30 AM, Michael Rasmussen wrote: > On Mar 14, 2017 23:03, "Vladimir Ivanov" > wrote: > > Yes, you are right. Then the only option is: > -XX:+UnlockDiagnosticVMOptions -XX:-CheckIntrinsics > > Best

Re: RFR(XS): 8185112: [TESTBUG] Servicability tests cannot parse float if non US locale.

Looks good, but don't we also need this for getIntValue() as well? I.e. can't an integer be "1.234.678" (German style) as well as "1,234,678" (American style) for example ? Thanks, Volker On Mon, Jul 24, 2017 at 9:07 AM, Lindenmaier, Goetz wrote: > Hi, > > > > Some

Re: RFR(XS): 8185112: [TESTBUG] Servicability tests cannot parse float if non US locale.

ays (took a while because the tests didn't run > nightly): > http://cr.openjdk.java.net/~goetz/wr17/8185112-macLocale/webrev.02/ > > Best regards, > Goetz. > >> -Original Message- >> From: Volker Simonis [mailto:volker.simo...@gmail.com] >> Sent: Fre

Re: RFR(xxxs): 8203014: jcmd should output command list if no command is given

Hi Thomas, I think the request sounds reasonable and the change looks good. @David: why should this require a CSR request? I don’t see that the behavior for bad command line flags is specified somewhere. So we’re changing an undocumented behavior into o more meaningful undocumented behavior.

Re: [URGENT] RFR: 8205096: Add missing files for 8203394

Can't comment on the content, but at least it fixes the build so thumbs up from me! Regards, Volker On Fri, Jun 15, 2018 at 11:16 AM, serguei.spit...@oracle.com wrote: > Please, review a fix for: > https://bugs.openjdk.java.net/browse/JDK-8205096 > > Webrev: > >

Re: RFR (S) 8205608: Fix 'frames()' in ThreadReferenceImpl.c to prevent quadratic runtime behavior

Hi Sergey, thanks for your help, but I've just pushed the fix now. @Thomas: sorry, I really apologize, but I've just realized that I've forgot to add you as a Reviewer :( I'll promise to look more carefully next time. Regards, Volker On Tue, Jul 24, 2018 at 6:01 PM, serguei.spit...@oracle.com

Re: RFR: JDK-8200178 Remove mapfiles for JDK native libraries

Hi Magnus, thanks for addressing this long standing issue! I haven't looked at the changes, but just want to share some general and historical notes: - Compiling with "-fvisibility=hidden" which hides all symbols expect the ones explicitly exported with "__attribute__((visibility("default")))"

Re: 8u: RFR(S): 8197943: Unable to use JDWP API in JDK 8 to debug JDK 9 VM

Hi Christoph, I think the new code is wrong for "jdwpMajor == 0", which was correctly handled before. But I'm not sure if that is relevant at all nowadays and taking into account that this is a verbatim downport from 9 I don't think we have to do better in 8u. Otherwise looks good from my side.

Re: RFR(S): 8215975: [testbug] Adapt nsk tests to the PPC, S390 and AIX platforms.

gt; ... and I'll update the copyrights before pushing ... > > Sorry for the inconvenience! > Goetz > > > -Original Message- > > From: Volker Simonis > > Sent: Donnerstag, 3. Januar 2019 09:50 > > To: Lindenmaier, Goetz > > Cc: gary.ad...@oracle.com;

Re: RFR(S): 8215975: [testbug] Adapt nsk tests to the PPC, S390 and AIX platforms.

Looks good to me. Thanks, Volker On Wed, Jan 2, 2019 at 4:48 PM Lindenmaier, Goetz wrote: > Hi Gary, > > as promised, I'll do a follow up fixing all these. > But all the tests you mention are either not configured for aix (@requires > linux etc) > or are passing currently. So no need for

Re: RFC (csr): 8221528: Introduce compatibility mode with VM option -XX:AllowRedefinitionToAddOrDeleteMethods

Hi Serguei, can you please detail a little bit on the reasons why you finally decided to change the implementation to conform to the spec instead of just updating the spec to endorse a behavior which is there since quite some time? I read trough the comment thread of "JDK-8192936" and it seems

Re: RFR (M) 8223456: CSR Delayed starting of debugging via jcmd

Hi Alan, you may be right that the initial submitter and reviewers have missed the need of a CSR, but after all, the change itself has been correctly reviewed on serviceability-dev by your colleague Chris Plummer and my colleague Christoph Langer. I think it is a little exaggerated to claim the

Re: Slow class loading when running JVM in debug mode

Hi Egor, yes, I‘d say this is something well known. The reason for this is that a debugging agent will request some JVMTI capabilities like "can_access_local_variables" which can only be requested at JVM startup. However, once these capabilities have been taken, certain kinds of optimizations

Re: 8234624: jstack mixed mode should refer DWARF

Just a wild guess, but maybe after your changes, the debug symbols are required and not found any more? This could be caused by the fact that Mach5 builds with different settings compared to you? See

Re: serviceability agent : problems when using gcc LTO (link time optimization)

SA pretends to know the exact types of objects in the JVM and for polymorphic objects it wants to read their vtable from the shared library. If LTO de-virtulizes methods and thus changes polymorphic to non-polymorphic types, this won't work. But if LTO can de-virtulizes a type, maybe you can do

Re: serviceability agent : problems when using gcc LTO (link time optimization)

While we are speaking about all the drawbacks of LTO, it's still not clear what the benefits are? In the very first mail Matthias mentioned that there might be performance improvements but that performance is not the main driving factor behind this initiative. So is it the reduced code size

Re: serviceability agent : problems when using gcc LTO (link time optimization)

cause it is C++ ? > > > > > > So for some libs you see 10% and more , but not for all . But most > large libs like libjvm.so, libfontmanager.so or liblcms.so > we see good results regarding reduced code size. > > > > I Cannot say much about p

  1   2   >