Re: RFR(S): 8198655: test/lib/jdk/test/lib/apps/LingeredApp shouldn't inherit cout/cerr

Hi Chris, the changeset looks reasonable, reviewed. Thanks, -- Igor > On Mar 21, 2018, at 3:26 PM, David Holmes wrote: > > Sorry Chris I just don't have time to try and figure this one out. If it > works uses it. > > David > > On 22/03/2018 4:24 AM, Chris Plummer

Re: RFR(S): 8198655: test/lib/jdk/test/lib/apps/LingeredApp shouldn't inherit cout/cerr

Sorry Chris I just don't have time to try and figure this one out. If it works uses it. David On 22/03/2018 4:24 AM, Chris Plummer wrote: Yeah, this was all new to me. Before this I didn't know anything about jtreg IO other than the use of OutputAnalyzer for capture and verification. Thanks

Re: RFR(S): 8198655: test/lib/jdk/test/lib/apps/LingeredApp shouldn't inherit cout/cerr

Yeah, this was all new to me. Before this I didn't know anything about jtreg IO other than the use of OutputAnalyzer for capture and verification. Thanks for reviewing. Chris On 3/21/18 11:08 AM, serguei.spit...@oracle.com wrote: Hi Chris, It looks good to me. It is a little bit more

Re: RFR(S): 8198655: test/lib/jdk/test/lib/apps/LingeredApp shouldn't inherit cout/cerr

Hi Chris, It looks good to me. It is a little bit more complicated than one would expect but reasonable. Thanks, Serguei On 3/21/18 09:31, Chris Plummer wrote: Ping. I still need a couple of reviews for this. thanks, Chris On 3/19/18 3:50 PM, Chris Plummer wrote: I looked into modifying

Re: RFR(S): 8198655: test/lib/jdk/test/lib/apps/LingeredApp shouldn't inherit cout/cerr

Ping. I still need a couple of reviews for this. thanks, Chris On 3/19/18 3:50 PM, Chris Plummer wrote: I looked into modifying OutputAnalyzer (actually ended up being ProcessTools that needed all the changes) to be more flexible so it could support LingeredApp. The problem I ran into is

Re: RFR(S): 8198655: test/lib/jdk/test/lib/apps/LingeredApp shouldn't inherit cout/cerr

I looked into modifying OutputAnalyzer (actually ended up being ProcessTools that needed all the changes) to be more flexible so it could support LingeredApp. The problem I ran into is that ProcessTools is all static, but I needed to create and return a context. It ended up being too much

Re: RFR(S): 8198655: test/lib/jdk/test/lib/apps/LingeredApp shouldn't inherit cout/cerr

Hi David, Just to clarify one point, most of the tests that use OutputAnalyzer do not display process output unless there is an error. So part of the decision here with LingeredApp is when to display the output. Currently the stdout is captured, but not displayed, unless the tests does the

Re: RFR(S): 8198655: test/lib/jdk/test/lib/apps/LingeredApp shouldn't inherit cout/cerr

I'm afraid I'm losing track of this change. The key thing is that we should not have a test that launches any other process for which we can not see the output of that process. David On 17/03/2018 7:48 AM, Chris Plummer wrote: On 3/16/18 1:25 PM, serguei.spit...@oracle.com wrote: Hi Chris,

Re: RFR(S): 8198655: test/lib/jdk/test/lib/apps/LingeredApp shouldn't inherit cout/cerr

On 3/16/18 1:25 PM, serguei.spit...@oracle.com wrote: Hi Chris, Thank you for taking care about this issue! On 3/16/18 11:20, Chris Plummer wrote: Hi, I've resolved the issues I had before with not seeing all the stderr output when I tried to capture it. What I'd like to do now is have us

Re: RFR(S): 8198655: test/lib/jdk/test/lib/apps/LingeredApp shouldn't inherit cout/cerr

Hi Chris, Thank you for taking care about this issue! On 3/16/18 11:20, Chris Plummer wrote: Hi, I've resolved the issues I had before with not seeing all the stderr output when I tried to capture it. What I'd like to do now is have us decide how the output should be handled from the

Re: RFR(S): 8198655: test/lib/jdk/test/lib/apps/LingeredApp shouldn't inherit cout/cerr

Hi, I've resolved the issues I had before with not seeing all the stderr output when I tried to capture it. What I'd like to do now is have us decide how the output should be handled from the perspective a LingeredApp user (driver app). Currently all LingeredApp stdout is captured and gets

Re: RFR(S): 8198655: test/lib/jdk/test/lib/apps/LingeredApp shouldn't inherit cout/cerr

On 3/12/18 1:51 PM, Chris Plummer wrote: Hi Igor, On 3/12/18 1:26 PM, Igor Ignatyev wrote: On Mar 12, 2018, at 8:53 AM, Chris Plummer > wrote: On 3/11/18 7:52 PM, David Holmes wrote: Hi Chris, On 10/03/2018 6:46 AM, Chris

Re: RFR(S): 8198655: test/lib/jdk/test/lib/apps/LingeredApp shouldn't inherit cout/cerr

Hi Igor, On 3/12/18 1:26 PM, Igor Ignatyev wrote: On Mar 12, 2018, at 8:53 AM, Chris Plummer > wrote: On 3/11/18 7:52 PM, David Holmes wrote: Hi Chris, On 10/03/2018 6:46 AM, Chris Plummer wrote: Hello, Please help review the

Re: RFR(S): 8198655: test/lib/jdk/test/lib/apps/LingeredApp shouldn't inherit cout/cerr

> On Mar 12, 2018, at 8:53 AM, Chris Plummer wrote: > > On 3/11/18 7:52 PM, David Holmes wrote: >> Hi Chris, >> >> On 10/03/2018 6:46 AM, Chris Plummer wrote: >>> Hello, >>> >>> Please help review the following: >>> >>>

Re: RFR(S): 8198655: test/lib/jdk/test/lib/apps/LingeredApp shouldn't inherit cout/cerr

On 3/11/18 7:52 PM, David Holmes wrote: Hi Chris, On 10/03/2018 6:46 AM, Chris Plummer wrote: Hello, Please help review the following: https://bugs.openjdk.java.net/browse/JDK-8198655 http://cr.openjdk.java.net/~cjplummer/8198655/webrev.00/webrev/ In the end there were two issues. The first

Re: RFR(S): 8198655: test/lib/jdk/test/lib/apps/LingeredApp shouldn't inherit cout/cerr

On 3/12/18 3:27 AM, Langer, Christoph wrote: Hi Chris, Hi Chris, On 10/03/2018 6:46 AM, Chris Plummer wrote: Hello, Please help review the following: https://bugs.openjdk.java.net/browse/JDK-8198655 http://cr.openjdk.java.net/~cjplummer/8198655/webrev.00/webrev/ In the end there were two

RE: RFR(S): 8198655: test/lib/jdk/test/lib/apps/LingeredApp shouldn't inherit cout/cerr

Hi Chris, > Hi Chris, > > On 10/03/2018 6:46 AM, Chris Plummer wrote: > > Hello, > > > > Please help review the following: > > > > https://bugs.openjdk.java.net/browse/JDK-8198655 > > http://cr.openjdk.java.net/~cjplummer/8198655/webrev.00/webrev/ > > > > In the end there were two issues. The

Re: RFR(S): 8198655: test/lib/jdk/test/lib/apps/LingeredApp shouldn't inherit cout/cerr

Hi Chris, On 10/03/2018 6:46 AM, Chris Plummer wrote: Hello, Please help review the following: https://bugs.openjdk.java.net/browse/JDK-8198655 http://cr.openjdk.java.net/~cjplummer/8198655/webrev.00/webrev/ In the end there were two issues. The first was that the pb.redirectError() call

RFR(S): 8198655: test/lib/jdk/test/lib/apps/LingeredApp shouldn't inherit cout/cerr

Hello, Please help review the following: https://bugs.openjdk.java.net/browse/JDK-8198655 http://cr.openjdk.java.net/~cjplummer/8198655/webrev.00/webrev/ In the end there were two issues. The first was that the pb.redirectError() call was redirecting the LingeredApp's stderr to the console,