Re: [10] RFR for JDK-8169961: Memory leak after debugging session

2017-08-10 Thread serguei.spit...@oracle.com
rds, Shafi -Original Message- From: Serguei Spitsyn Sent: Thursday, August 10, 2017 12:27 AM To: Daniel Daugherty ; Shafi Ahmad ; serviceability-dev@openjdk.java.net Cc: Roger Calnan Subject: Re: [10] RFR for JDK-8169961: Memory leak after debugging session On 8/9/17 08:27, Daniel D. Daugherty wrot

RE: [10] RFR for JDK-8169961: Memory leak after debugging session

2017-08-10 Thread Shafi Ahmad
August 10, 2017 12:27 AM > To: Daniel Daugherty ; Shafi Ahmad > ; serviceability-dev@openjdk.java.net > Cc: Roger Calnan > Subject: Re: [10] RFR for JDK-8169961: Memory leak after debugging session > > On 8/9/17 08:27, Daniel D. Daugherty wrote: > > On 8/9/17 3:05 AM, Shafi

Re: [10] RFR for JDK-8169961: Memory leak after debugging session

2017-08-09 Thread serguei.spit...@oracle.com
s vacation... More below... More below. Regards, Shafi -Original Message- From: Shafi Ahmad Sent: Wednesday, July 26, 2017 8:26 AM To: serviceability-dev@openjdk.java.net Cc: Roger Calnan Subject: RE: [10] RFR for JDK-8169961: Memory leak after debugging session May I get i

Re: [10] RFR for JDK-8169961: Memory leak after debugging session

2017-08-09 Thread serguei.spit...@oracle.com
alnan Subject: RE: [10] RFR for JDK-8169961: Memory leak after debugging session May I get it reviewed by someone from serviceability group. Webrev link: http://cr.openjdk.java.net/~shshahma/8169961/webrev.01/ This review thread: http://mail.openjdk.java.net/pipermail/serviceability- dev/2017-July/0

Re: [10] RFR for JDK-8169961: Memory leak after debugging session

2017-08-09 Thread Daniel D. Daugherty
hafi Ahmad Sent: Wednesday, July 26, 2017 8:26 AM To: serviceability-dev@openjdk.java.net Cc: Roger Calnan Subject: RE: [10] RFR for JDK-8169961: Memory leak after debugging session May I get it reviewed by someone from serviceability group. Webrev link: http://cr.openjdk.java.net/~shshahma/8169961

RE: [10] RFR for JDK-8169961: Memory leak after debugging session

2017-08-09 Thread Shafi Ahmad
May I get it reviewed by serviceability team. Regards, Shafi > -Original Message- > From: Shafi Ahmad > Sent: Wednesday, July 26, 2017 8:26 AM > To: serviceability-dev@openjdk.java.net > Cc: Roger Calnan > Subject: RE: [10] RFR for JDK-8169961: Memory leak after

RE: [10] RFR for JDK-8169961: Memory leak after debugging session

2017-07-25 Thread Shafi Ahmad
Ahmad > Sent: Monday, July 24, 2017 12:52 PM > To: serviceability-dev@openjdk.java.net > Subject: RE: [10] RFR for JDK-8169961: Memory leak after debugging session > > Hi, > > > -Original Message- > > From: Langer, Christoph [mailto:christoph.lan...@sap.com]

RE: [10] RFR for JDK-8169961: Memory leak after debugging session

2017-07-24 Thread Shafi Ahmad
Hi, > -Original Message- > From: Langer, Christoph [mailto:christoph.lan...@sap.com] > Sent: Monday, July 17, 2017 9:01 PM > To: Poonam Parhar > Cc: Shafi Ahmad ; serviceability- > d...@openjdk.java.net > Subject: RE: [10] RFR for JDK-8169961: Memory leak after debu

Re: [10] RFR for JDK-8169961: Memory leak after debugging session

2017-07-20 Thread Daniel D. Daugherty
[mailto:serviceability-dev- boun...@openjdk.java.net] On Behalf Of Shafi Ahmad Sent: Montag, 17. Juli 2017 14:25 To: Daniel Daugherty ; serviceability- d...@openjdk.java.net Subject: RE: [10] RFR for JDK-8169961: Memory leak after debugging session Hi Daniel, Thank you for the review. -Original

RE: [10] RFR for JDK-8169961: Memory leak after debugging session

2017-07-20 Thread Shafi Ahmad
Hi Daniel, > -Original Message- > From: Langer, Christoph [mailto:christoph.lan...@sap.com] > Sent: Monday, July 17, 2017 6:44 PM > To: Shafi Ahmad ; Daniel Daugherty > > Cc: serviceability-dev@openjdk.java.net > Subject: RE: [10] RFR for JDK-8169961: Memory leak af

RE: [10] RFR for JDK-8169961: Memory leak after debugging session

2017-07-17 Thread Langer, Christoph
Hi Poonam, > Line 182: Here, eventController.release() is called after the 'vm' is > disposed. > And eventController.release() causes the following statement to be > executed on the eventcontroller thread after the 'vm' is disposed: > > JDWP.VirtualMachine.ReleaseEvents.process(vm); > > Which

RE: [10] RFR for JDK-8169961: Memory leak after debugging session

2017-07-17 Thread Poonam Parhar
Hello Shafi, A couple of comments: Line 182: Here, eventController.release() is called after the 'vm' is disposed. And eventController.release() causes the following statement to be executed on the eventcontroller thread after the 'vm' is disposed: JDWP.VirtualMachine.ReleaseEvents.process(vm)

RE: [10] RFR for JDK-8169961: Memory leak after debugging session

2017-07-17 Thread Langer, Christoph
ty-dev- > boun...@openjdk.java.net] On Behalf Of Shafi Ahmad > Sent: Montag, 17. Juli 2017 14:25 > To: Daniel Daugherty ; serviceability- > d...@openjdk.java.net > Subject: RE: [10] RFR for JDK-8169961: Memory leak after debugging session > > Hi Daniel, > > Thank you for

RE: [10] RFR for JDK-8169961: Memory leak after debugging session

2017-07-17 Thread Shafi Ahmad
Hi Daniel, Thank you for the review. > -Original Message- > From: Daniel D. Daugherty > Sent: Friday, July 14, 2017 6:46 AM > To: Shafi Ahmad ; serviceability- > d...@openjdk.java.net > Subject: Re: [10] RFR for JDK-8169961: Memory leak after debugging session >

Re: [10] RFR for JDK-8169961: Memory leak after debugging session

2017-07-13 Thread Daniel D. Daugherty
On 7/13/17 10:19 AM, Shafi Ahmad wrote: Hi Daniel, Thank you for the review. -Original Message- From: Daniel D. Daugherty Sent: Thursday, July 13, 2017 7:40 PM To: Shafi Ahmad ; serviceability- d...@openjdk.java.net Subject: Re: [10] RFR for JDK-8169961: Memory leak after debugging

RE: [10] RFR for JDK-8169961: Memory leak after debugging session

2017-07-13 Thread Shafi Ahmad
Hi Daniel, Thank you for the review. > -Original Message- > From: Daniel D. Daugherty > Sent: Thursday, July 13, 2017 7:40 PM > To: Shafi Ahmad ; serviceability- > d...@openjdk.java.net > Subject: Re: [10] RFR for JDK-8169961: Memory leak after debugging session >

Re: [10] RFR for JDK-8169961: Memory leak after debugging session

2017-07-13 Thread Daniel D. Daugherty
On 7/13/17 2:45 AM, Shafi Ahmad wrote: Hi, Please review the code change for the fix of bug 'JDK-8169961: Memory leak after debugging session' Summary: 1. It seems that the thread created for com.sun.tools.jdi.TargetVM.EventController is never stopped and keeps a hard reference to the Virt

RE: [10] RFR for JDK-8169961: Memory leak after debugging session

2017-07-13 Thread Shafi Ahmad
Hi Christoph, Thank you for reviewing. Regards, Shafi > -Original Message- > From: Langer, Christoph [mailto:christoph.lan...@sap.com] > Sent: Thursday, July 13, 2017 4:16 PM > To: Shafi Ahmad > Cc: serviceability-dev@openjdk.java.net > Subject: RE: [10] RFR for J

RE: [10] RFR for JDK-8169961: Memory leak after debugging session

2017-07-13 Thread Langer, Christoph
Hi Shafi, this fix looks good to me. Reviewed. Best regards Christoph > -Original Message- > From: serviceability-dev [mailto:serviceability-dev- > boun...@openjdk.java.net] On Behalf Of Shafi Ahmad > Sent: Donnerstag, 13. Juli 2017 10:45 > To: serviceability-dev@openjdk.java.net > Subje