rds,
Shafi
-Original Message-
From: Serguei Spitsyn
Sent: Thursday, August 10, 2017 12:27 AM
To: Daniel Daugherty ; Shafi Ahmad
; serviceability-dev@openjdk.java.net
Cc: Roger Calnan
Subject: Re: [10] RFR for JDK-8169961: Memory leak after debugging session
On 8/9/17 08:27, Daniel D. Daugherty wrot
August 10, 2017 12:27 AM
> To: Daniel Daugherty ; Shafi Ahmad
> ; serviceability-dev@openjdk.java.net
> Cc: Roger Calnan
> Subject: Re: [10] RFR for JDK-8169961: Memory leak after debugging session
>
> On 8/9/17 08:27, Daniel D. Daugherty wrote:
> > On 8/9/17 3:05 AM, Shafi
s vacation...
More below...
More below.
Regards,
Shafi
-Original Message-
From: Shafi Ahmad
Sent: Wednesday, July 26, 2017 8:26 AM
To: serviceability-dev@openjdk.java.net
Cc: Roger Calnan
Subject: RE: [10] RFR for JDK-8169961: Memory leak after debugging
session
May I get i
alnan
Subject: RE: [10] RFR for JDK-8169961: Memory leak after debugging session
May I get it reviewed by someone from serviceability group.
Webrev link: http://cr.openjdk.java.net/~shshahma/8169961/webrev.01/
This review thread: http://mail.openjdk.java.net/pipermail/serviceability-
dev/2017-July/0
hafi Ahmad
Sent: Wednesday, July 26, 2017 8:26 AM
To: serviceability-dev@openjdk.java.net
Cc: Roger Calnan
Subject: RE: [10] RFR for JDK-8169961: Memory leak after debugging session
May I get it reviewed by someone from serviceability group.
Webrev link: http://cr.openjdk.java.net/~shshahma/8169961
May I get it reviewed by serviceability team.
Regards,
Shafi
> -Original Message-
> From: Shafi Ahmad
> Sent: Wednesday, July 26, 2017 8:26 AM
> To: serviceability-dev@openjdk.java.net
> Cc: Roger Calnan
> Subject: RE: [10] RFR for JDK-8169961: Memory leak after
Ahmad
> Sent: Monday, July 24, 2017 12:52 PM
> To: serviceability-dev@openjdk.java.net
> Subject: RE: [10] RFR for JDK-8169961: Memory leak after debugging session
>
> Hi,
>
> > -Original Message-
> > From: Langer, Christoph [mailto:christoph.lan...@sap.com]
Hi,
> -Original Message-
> From: Langer, Christoph [mailto:christoph.lan...@sap.com]
> Sent: Monday, July 17, 2017 9:01 PM
> To: Poonam Parhar
> Cc: Shafi Ahmad ; serviceability-
> d...@openjdk.java.net
> Subject: RE: [10] RFR for JDK-8169961: Memory leak after debu
[mailto:serviceability-dev-
boun...@openjdk.java.net] On Behalf Of Shafi Ahmad
Sent: Montag, 17. Juli 2017 14:25
To: Daniel Daugherty ; serviceability-
d...@openjdk.java.net
Subject: RE: [10] RFR for JDK-8169961: Memory leak after debugging
session
Hi Daniel,
Thank you for the review.
-Original
Hi Daniel,
> -Original Message-
> From: Langer, Christoph [mailto:christoph.lan...@sap.com]
> Sent: Monday, July 17, 2017 6:44 PM
> To: Shafi Ahmad ; Daniel Daugherty
>
> Cc: serviceability-dev@openjdk.java.net
> Subject: RE: [10] RFR for JDK-8169961: Memory leak af
Hi Poonam,
> Line 182: Here, eventController.release() is called after the 'vm' is
> disposed.
> And eventController.release() causes the following statement to be
> executed on the eventcontroller thread after the 'vm' is disposed:
>
> JDWP.VirtualMachine.ReleaseEvents.process(vm);
>
> Which
Hello Shafi,
A couple of comments:
Line 182: Here, eventController.release() is called after the 'vm' is disposed.
And eventController.release() causes the following statement to be executed on
the eventcontroller thread after the 'vm' is disposed:
JDWP.VirtualMachine.ReleaseEvents.process(vm)
ty-dev-
> boun...@openjdk.java.net] On Behalf Of Shafi Ahmad
> Sent: Montag, 17. Juli 2017 14:25
> To: Daniel Daugherty ; serviceability-
> d...@openjdk.java.net
> Subject: RE: [10] RFR for JDK-8169961: Memory leak after debugging session
>
> Hi Daniel,
>
> Thank you for
Hi Daniel,
Thank you for the review.
> -Original Message-
> From: Daniel D. Daugherty
> Sent: Friday, July 14, 2017 6:46 AM
> To: Shafi Ahmad ; serviceability-
> d...@openjdk.java.net
> Subject: Re: [10] RFR for JDK-8169961: Memory leak after debugging session
>
On 7/13/17 10:19 AM, Shafi Ahmad wrote:
Hi Daniel,
Thank you for the review.
-Original Message-
From: Daniel D. Daugherty
Sent: Thursday, July 13, 2017 7:40 PM
To: Shafi Ahmad ; serviceability-
d...@openjdk.java.net
Subject: Re: [10] RFR for JDK-8169961: Memory leak after debugging
Hi Daniel,
Thank you for the review.
> -Original Message-
> From: Daniel D. Daugherty
> Sent: Thursday, July 13, 2017 7:40 PM
> To: Shafi Ahmad ; serviceability-
> d...@openjdk.java.net
> Subject: Re: [10] RFR for JDK-8169961: Memory leak after debugging session
>
On 7/13/17 2:45 AM, Shafi Ahmad wrote:
Hi,
Please review the code change for the fix of bug 'JDK-8169961: Memory leak
after debugging session'
Summary:
1. It seems that the thread created for
com.sun.tools.jdi.TargetVM.EventController is never stopped and keeps a hard
reference to the Virt
Hi Christoph,
Thank you for reviewing.
Regards,
Shafi
> -Original Message-
> From: Langer, Christoph [mailto:christoph.lan...@sap.com]
> Sent: Thursday, July 13, 2017 4:16 PM
> To: Shafi Ahmad
> Cc: serviceability-dev@openjdk.java.net
> Subject: RE: [10] RFR for J
Hi Shafi,
this fix looks good to me. Reviewed.
Best regards
Christoph
> -Original Message-
> From: serviceability-dev [mailto:serviceability-dev-
> boun...@openjdk.java.net] On Behalf Of Shafi Ahmad
> Sent: Donnerstag, 13. Juli 2017 10:45
> To: serviceability-dev@openjdk.java.net
> Subje
19 matches
Mail list logo