Re: RFR 8170541: serviceability/jdwp/AllModulesCommandTest.java fails intermittently on Windows and Solaris

2018-03-02 Thread David Holmes
om: *"serguei.spit...@oracle.com" *Date: *Tuesday, February 20, 2018 at 3:00 PM *To: *Daniil Titov , "serviceability-dev@openjdk.java.net" *Subject: *Re: RFR 8170541: serviceability/jdwp/AllModulesCommandTest.java fails intermittently on Windows and Solaris Hi Daniil, Interesti

Re: RFR 8170541: serviceability/jdwp/AllModulesCommandTest.java fails intermittently on Windows and Solaris

2018-03-02 Thread Chris Plummer
ed is at http://cr.openjdk.java.net/~dtitov/8170541/webrev.02/ Thank you! Best regards, Daniil *From: *"serguei.spit...@oracle.com" *Date: *Tuesday, February 20, 2018 at 3:00 PM *To: *Daniil Titov , "serviceability-dev@openjdk.java.net" *Subject: *Re: RFR 8170541: s

Re: RFR 8170541: serviceability/jdwp/AllModulesCommandTest.java fails intermittently on Windows and Solaris

2018-03-01 Thread David Holmes
regards, Daniil *From: *"serguei.spit...@oracle.com" *Date: *Tuesday, February 20, 2018 at 3:00 PM *To: *Daniil Titov , "serviceability-dev@openjdk.java.net" *Subject: *Re: RFR 8170541: serviceability/jdwp/AllModulesCommandTest.java fails intermittently on Windows and Sol

Re: RFR 8170541: serviceability/jdwp/AllModulesCommandTest.java fails intermittently on Windows and Solaris

2018-03-01 Thread daniil . x . titov
niil Titov , "serviceability-dev@openjdk.java.net" *Subject: *Re: RFR 8170541: serviceability/jdwp/AllModulesCommandTest.java fails intermittently on Windows and Solaris Hi Daniil, Interesting issue... Thank you for finding to the root cause so quickly! The fix loo

Re: RFR 8170541: serviceability/jdwp/AllModulesCommandTest.java fails intermittently on Windows and Solaris

2018-02-27 Thread Daniil Titov
>>>>>> it can fail in the future when more modules are added to the >>>>>> platform. >>>>>> >>>>>> >>>>>>> I'm wondering if all these reads should be loops, ensuring we >>>

Re: RFR 8170541: serviceability/jdwp/AllModulesCommandTest.java fails intermittently on Windows and Solaris

2018-02-26 Thread David Holmes
2018 at 3:00 PM *To: *Daniil Titov , "serviceability-dev@openjdk.java.net" *Subject: *Re: RFR 8170541: serviceability/jdwp/AllModulesCommandTest.java fails intermittently on Windows and Solaris Hi Daniil, Interesting issue... Thank you for finding to the root cause so quickl

Re: RFR 8170541: serviceability/jdwp/AllModulesCommandTest.java fails intermittently on Windows and Solaris

2018-02-26 Thread serguei.spit...@oracle.com
e.com" *Date: *Tuesday, February 20, 2018 at 3:00 PM *To: *Daniil Titov , "serviceability-dev@openjdk.java.net" *Subject: *Re: RFR 8170541: serviceability/jdwp/AllModulesCommandTest.java fails intermittently on Windows and Solaris Hi Daniil, Interesting issue... Thank you for finding to

Re: RFR 8170541: serviceability/jdwp/AllModulesCommandTest.java fails intermittently on Windows and Solaris

2018-02-26 Thread Chris Plummer
" *Date: *Tuesday, February 20, 2018 at 3:00 PM *To: *Daniil Titov , "serviceability-dev@openjdk.java.net" *Subject: *Re: RFR 8170541: serviceability/jdwp/AllModulesCommandTest.java fails intermittently on Windows and Solaris Hi Daniil, Interesting issue... Thank you for find

Re: RFR 8170541: serviceability/jdwp/AllModulesCommandTest.java fails intermittently on Windows and Solaris

2018-02-26 Thread daniil . x . titov
.spit...@oracle.com" *Date: *Tuesday, February 20, 2018 at 3:00 PM *To: *Daniil Titov , "serviceability-dev@openjdk.java.net" *Subject: *Re: RFR 8170541: serviceability/jdwp/AllModulesCommandTest.java fails intermittently on Windows and Solaris Hi Daniil, Interesting issue..

Re: RFR 8170541: serviceability/jdwp/AllModulesCommandTest.java fails intermittently on Windows and Solaris

2018-02-26 Thread Chris Plummer
Daniil *From: *"serguei.spit...@oracle.com" *Date: *Tuesday, February 20, 2018 at 3:00 PM *To: *Daniil Titov , "serviceability-dev@openjdk.java.net" *Subject: *Re: RFR 8170541: serviceability/jdwp/AllModulesCommandTest.java fails intermittently on Windows and Solaris Hi Daniil,

Re: RFR 8170541: serviceability/jdwp/AllModulesCommandTest.java fails intermittently on Windows and Solaris

2018-02-26 Thread daniil . x . titov
Thank you! Best regards, Daniil *From: *"serguei.spit...@oracle.com" *Date: *Tuesday, February 20, 2018 at 3:00 PM *To: *Daniil Titov , "serviceability-dev@openjdk.java.net" *Subject: *Re: RFR 8170541: serviceability/jdwp/AllModulesCommandTest.java fails intermittently on

Re: RFR 8170541: serviceability/jdwp/AllModulesCommandTest.java fails intermittently on Windows and Solaris

2018-02-20 Thread serguei.spit...@oracle.com
; *Date: *Tuesday, February 20, 2018 at 3:00 PM *To: *Daniil Titov , "serviceability-dev@openjdk.java.net" *Subject: *Re: RFR 8170541: serviceability/jdwp/AllModulesCommandTest.java fails intermittently on Windows and Solaris Hi Daniil, Interesting issue... Thank you for finding to the

Re: RFR 8170541: serviceability/jdwp/AllModulesCommandTest.java fails intermittently on Windows and Solaris

2018-02-20 Thread Daniil Titov
e: Tuesday, February 20, 2018 at 7:31 PM To: Daniil Titov , "serviceability-dev@openjdk.java.net" Subject: Re: RFR 8170541: serviceability/jdwp/AllModulesCommandTest.java fails intermittently on Windows and Solaris Hi Daniil, It looks good to me. It seems, you have been able to re

Re: RFR 8170541: serviceability/jdwp/AllModulesCommandTest.java fails intermittently on Windows and Solaris

2018-02-20 Thread David Holmes
quot;serviceability-dev@openjdk.java.net" *Subject: *Re: RFR 8170541: serviceability/jdwp/AllModulesCommandTest.java fails intermittently on Windows and Solaris Hi Daniil, Interesting issue... Thank you for finding to the root cause so quickly! The fix looks good. Could I ask you to reformat

Re: RFR 8170541: serviceability/jdwp/AllModulesCommandTest.java fails intermittently on Windows and Solaris

2018-02-20 Thread serguei.spit...@oracle.com
Subject: Re: RFR 8170541: serviceability/jdwp/AllModulesCommandTest.java fails intermittently on Windows and Solaris   Hi Daniil, Interesting issue... Thank yo

Re: RFR 8170541: serviceability/jdwp/AllModulesCommandTest.java fails intermittently on Windows and Solaris

2018-02-20 Thread Daniil Titov
niil Titov , "serviceability-dev@openjdk.java.net" Subject: Re: RFR 8170541: serviceability/jdwp/AllModulesCommandTest.java fails intermittently on Windows and Solaris Hi Daniil, Interesting issue... Thank you for finding to the root cause so quickly! The fix looks good. Could I ask you to

Re: RFR 8170541: serviceability/jdwp/AllModulesCommandTest.java fails intermittently on Windows and Solaris

2018-02-20 Thread serguei.spit...@oracle.com
Hi Daniil, Interesting issue... Thank you for finding to the root cause so quickly! The fix looks good. Could I ask you to reformat these lines to make the L54 shorter ?: 54 System.out.println("[" + getClass().getName() + "] O