Re: [sheepdog] [PATCH 0/3] work: implement a dynamically changing thread pool

2012-10-25 Thread Bastian Scholz
Am 2012-10-22 08:43, schrieb MORITA Kazutaka: Yes, we need more numbers with various conditions to change the design. (I like this patch implementation, which uses the same code with ordered work queue, though.) I think of trying it, but I wish more users would test it too. Hi Kazutaka, If

Re: [sheepdog] [PATCH 0/3] work: implement a dynamically changing thread pool

2012-10-25 Thread MORITA Kazutaka
At Thu, 25 Oct 2012 09:14:32 +0200, Bastian Scholz wrote: Am 2012-10-22 08:43, schrieb MORITA Kazutaka: Yes, we need more numbers with various conditions to change the design. (I like this patch implementation, which uses the same code with ordered work queue, though.) I think of

Re: [sheepdog] [PATCH 0/3] work: implement a dynamically changing thread pool

2012-10-25 Thread Bastian Scholz
OKAY... call me sheep-ripper... Am 2012-10-25 10:08, schrieb MORITA Kazutaka: So far, I've not encountered situations where my patch shows worse performance. In most cases, queue_work is called only from one thread, so serializing at queue_work is unlikely to be a problem. Another contention

Re: [sheepdog] [PATCH 0/3] work: implement a dynamically changing thread pool

2012-10-25 Thread MORITA Kazutaka
At Thu, 25 Oct 2012 13:55:20 +0200, Bastian Scholz wrote: Master Branch from today... # collie vdi create test 1G # ./vditest test -w -B 4096 -a First try, some sheeps die and the vdis had failed objects. After shutting down the remaining sheeps, restart all and wait for recovery

[sheepdog] [PATCH] collie: send no data when preallocating data objects

2012-10-25 Thread MORITA Kazutaka
Sheep calls fallocate before creating objects, so we don't need to send actual data to be written when preallocating objects. Signed-off-by: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp --- collie/vdi.c |9 +++-- 1 files changed, 3 insertions(+), 6 deletions(-) diff --git

[sheepdog] [PATCH] avoid strcpy and strncpy

2012-10-25 Thread MORITA Kazutaka
strcpy has a risk of buffer overflow, and strncpy may not set '\0' to the destination buffer. This patch introduces pstrcpy to copy strings safely. Signed-off-by: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp --- collie/cluster.c |7 --- collie/treeview.c |6 +++--- collie/vdi.c