Re: [Slackbuilds-users] Commit messages by maintainers are truncated when committed.

[Willy Sudiarto Raharjo]

>> There is a limit of 68 characters on the commit messages.  Also, there
>> is not any automatic way of adding your extra text to the commit
>> messages, I have to do it manually, and if it's late at night and if
>> it's taken an hour to clean up a submission, sometimes I forget.
> 
> To clarify... does that 68 characters include the category and program name?

yes

> E.g. there's a build called 
> "haskell/haskell-data-default-instances-containers"
> whose name is 49 characters long. The commit format also calls for a colon
> and a space after the name, so that'd be 51, leaving only 17 characters
> for the actual message... is this correct?

yes

> Also... 68 is a very specific number. Curious to know where it comes from...

I don't have the exact answer for this one, but i'm guessing that it
would be for readability in the public update announcement as well as in
the git log.

"git log doesn’t do any special special wrapping of the commit messages.
With the default pager of less -S, this means your paragraphs flow far
off the edge of the screen, making them difficult to read. On an 80
column terminal, if we subtract 4 columns for the indent on the left and
4 more for symmetry on the right, we’re left with 72 columns."
see
https://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html
for more info

Other projects (eg Linux kernel) also have their own numbers
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/plain/Documentation/process/submitting-patches.rst


-- 
Willy Sudiarto Raharjo



signature.asc
Description: OpenPGP digital signature
___
SlackBuilds-users mailing list
SlackBuilds-users@slackbuilds.org
https://lists.slackbuilds.org/mailman/listinfo/slackbuilds-users
Archives - https://lists.slackbuilds.org/pipermail/slackbuilds-users/
FAQ - https://slackbuilds.org/faq/

Re: [Slackbuilds-users] Commit messages by maintainers are truncated when committed.

[B Watson]

On 4/6/18, David Spencer  wrote:
>
> There is a limit of 68 characters on the commit messages.  Also, there
> is not any automatic way of adding your extra text to the commit
> messages, I have to do it manually, and if it's late at night and if
> it's taken an hour to clean up a submission, sometimes I forget.

To clarify... does that 68 characters include the category and program name?

E.g. there's a build called "haskell/haskell-data-default-instances-containers"
whose name is 49 characters long. The commit format also calls for a colon
and a space after the name, so that'd be 51, leaving only 17 characters
for the actual message... is this correct?

Also... 68 is a very specific number. Curious to know where it comes from...
___
SlackBuilds-users mailing list
SlackBuilds-users@slackbuilds.org
https://lists.slackbuilds.org/mailman/listinfo/slackbuilds-users
Archives - https://lists.slackbuilds.org/pipermail/slackbuilds-users/
FAQ - https://slackbuilds.org/faq/

Re: [Slackbuilds-users] Commit messages by maintainers are truncated when committed.

[David Spencer]

> Hi,
> 
> I don't know if it is on purpose but two times in a row my messages for
> submissions are truncated in the "approved" page's commit messages
> column. First, a few weeks ago, there was rstudio-desktop when I took
> over the maintenance and updated the version and message's "+ new
> maintainer." part was omitted in the commit message. This week it is
> again rstudio-desktop, another version update plus a fix in the symlink
> creation of the doinst.sh script and the message's "+ fix symlink
> creation (thanks to Michael a.k.a mykyoyo)" was omitted in the commit
> message. Why?

Hi Ekin,

There is a limit of 68 characters on the commit messages.  Also, there
is not any automatic way of adding your extra text to the commit
messages, I have to do it manually, and if it's late at night and if
it's taken an hour to clean up a submission, sometimes I forget.

Sorry.
-D.
___
SlackBuilds-users mailing list
SlackBuilds-users@slackbuilds.org
https://lists.slackbuilds.org/mailman/listinfo/slackbuilds-users
Archives - https://lists.slackbuilds.org/pipermail/slackbuilds-users/
FAQ - https://slackbuilds.org/faq/