CVS commit: src/sys/netinet

2019-06-01 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Sat Jun 1 15:18:42 UTC 2019 Modified Files: src/sys/netinet: tcp_input.c Log Message: Replace potentially misaligned pointer dereference + htonl() with be32dec() Reported by kUBSan. To generate a diff of this commit: cvs rdiff

CVS commit: src/sys/kern

2019-05-31 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Sat Jun 1 00:19:43 UTC 2019 Modified Files: src/sys/kern: kern_proc.c Log Message: fill_cwd() Drop GETCWD_CHECK_ACCESS This additional check is not needed and actually prevents from checking the path. This follows the protection

CVS commit: src/sys/kern

2019-05-31 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Fri May 31 23:19:38 UTC 2019 Modified Files: src/sys/kern: kern_proc.c Log Message: Use proper copylen for copyout in fill_cwd() To generate a diff of this commit: cvs rdiff -u -r1.229 -r1.230 src/sys/kern/kern_proc.c Please

CVS commit: src/sys/kern

2019-05-31 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Fri May 31 23:19:38 UTC 2019 Modified Files: src/sys/kern: kern_proc.c Log Message: Use proper copylen for copyout in fill_cwd() To generate a diff of this commit: cvs rdiff -u -r1.229 -r1.230 src/sys/kern/kern_proc.c Please

CVS commit: src/sys

2019-05-31 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Fri May 31 23:01:39 UTC 2019 Modified Files: src/sys/kern: kern_proc.c src/sys/sys: sysctl.h Log Message: Implement KERN_PROC_CWD in sysctl(3) Retrieve specified process current working directory. Fixes PR kern/50620 by

CVS commit: src/sys

2019-05-31 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Fri May 31 23:01:39 UTC 2019 Modified Files: src/sys/kern: kern_proc.c src/sys/sys: sysctl.h Log Message: Implement KERN_PROC_CWD in sysctl(3) Retrieve specified process current working directory. Fixes PR kern/50620 by

CVS commit: src/share/man/man4

2019-05-28 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Tue May 28 21:31:53 UTC 2019 Modified Files: src/share/man/man4: kcov.4 Log Message: Correct the example in kcov(4) mmap(2) has to be called with MAP_SHARED, not MAP_PRIVATE. Reported by Maciej Grochowski. To generate a diff

CVS commit: src/share/man/man4

2019-05-28 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Tue May 28 21:31:53 UTC 2019 Modified Files: src/share/man/man4: kcov.4 Log Message: Correct the example in kcov(4) mmap(2) has to be called with MAP_SHARED, not MAP_PRIVATE. Reported by Maciej Grochowski. To generate a diff

CVS commit: src/sys/arch/x86/x86

2019-05-28 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Tue May 28 16:43:24 UTC 2019 Modified Files: src/sys/arch/x86/x86: procfs_machdep.c Log Message: Avoid the 1<<31 construct Shift unsigned int rather than signed one. Detected with kUBSan when reading /proc/cpuinfo. To generate

CVS commit: src/sys/arch/x86/x86

2019-05-28 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Tue May 28 16:43:24 UTC 2019 Modified Files: src/sys/arch/x86/x86: procfs_machdep.c Log Message: Avoid the 1<<31 construct Shift unsigned int rather than signed one. Detected with kUBSan when reading /proc/cpuinfo. To generate

CVS commit: src/sys/external/bsd/acpica/dist/tables

2019-05-28 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Tue May 28 13:34:40 UTC 2019 Modified Files: src/sys/external/bsd/acpica/dist/tables: tbutils.c Log Message: Correct misaligned pointer dereference of type UINT32 in ACPICA Detected with kUBSan. To generate a diff of this

CVS commit: src/sys/external/bsd/acpica/dist/tables

2019-05-28 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Tue May 28 13:34:40 UTC 2019 Modified Files: src/sys/external/bsd/acpica/dist/tables: tbutils.c Log Message: Correct misaligned pointer dereference of type UINT32 in ACPICA Detected with kUBSan. To generate a diff of this

CVS commit: src/sys/arch/x86/x86

2019-05-28 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Tue May 28 13:20:23 UTC 2019 Modified Files: src/sys/arch/x86/x86: patch.c Log Message: Disable sanitizer instrumentation in x86_hotpatch() Local variables have empty (0-sized), unknown alignment to UBSan. This is hard to

CVS commit: src/sys/arch/x86/x86

2019-05-28 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Tue May 28 13:20:23 UTC 2019 Modified Files: src/sys/arch/x86/x86: patch.c Log Message: Disable sanitizer instrumentation in x86_hotpatch() Local variables have empty (0-sized), unknown alignment to UBSan. This is hard to

CVS commit: src/sys/external/bsd/acpica/dist/include

2019-05-27 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Tue May 28 04:04:11 UTC 2019 Modified Files: src/sys/external/bsd/acpica/dist/include: amlresrc.h Log Message: Use pack attribute for AML_RESOURCE in acpica This fixes kUBSan warnings. Patch by Akul Pillai. To generate a diff

CVS commit: src/sys/external/bsd/acpica/dist/include

2019-05-27 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Tue May 28 04:04:11 UTC 2019 Modified Files: src/sys/external/bsd/acpica/dist/include: amlresrc.h Log Message: Use pack attribute for AML_RESOURCE in acpica This fixes kUBSan warnings. Patch by Akul Pillai. To generate a diff

CVS commit: src/sys/netinet6

2019-05-27 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Tue May 28 03:56:46 UTC 2019 Modified Files: src/sys/netinet6: in6.h Log Message: Decorate struct in6_addr with the __packed attribute This avoids undefined behavior when accessing misaligned pointers. Detected by kUBSan. Patch

CVS commit: src/sys/netinet6

2019-05-27 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Tue May 28 03:56:46 UTC 2019 Modified Files: src/sys/netinet6: in6.h Log Message: Decorate struct in6_addr with the __packed attribute This avoids undefined behavior when accessing misaligned pointers. Detected by kUBSan. Patch

CVS commit: src/sys/ufs/ffs

2019-05-27 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Tue May 28 03:53:29 UTC 2019 Modified Files: src/sys/ufs/ffs: ffs_subr.c Log Message: Avoid unportable shift base -1 in ffs_subr.c Cast the start variable before the modulo opration to unsigned int. Detected with kUBSan. To

CVS commit: src/sys/ufs/ffs

2019-05-27 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Tue May 28 03:53:29 UTC 2019 Modified Files: src/sys/ufs/ffs: ffs_subr.c Log Message: Avoid unportable shift base -1 in ffs_subr.c Cast the start variable before the modulo opration to unsigned int. Detected with kUBSan. To

CVS commit: src/sys/arch/amd64/amd64

2019-05-27 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Tue May 28 03:52:09 UTC 2019 Modified Files: src/sys/arch/amd64/amd64: kobj_machdep.c Log Message: Replace misaligned operations with memcpy() calls in kobj_machdep.c Detected with kUBSan. To generate a diff of this commit: cvs

CVS commit: src/sys/arch/amd64/amd64

2019-05-27 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Tue May 28 03:52:09 UTC 2019 Modified Files: src/sys/arch/amd64/amd64: kobj_machdep.c Log Message: Replace misaligned operations with memcpy() calls in kobj_machdep.c Detected with kUBSan. To generate a diff of this commit: cvs

CVS commit: src/include

2019-05-27 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Mon May 27 07:31:11 UTC 2019 Modified Files: src/include: assert.h Log Message: As a _NETBSD_SOURCE extension define static_assert for pre-c11/c++99 Proposed on source-changes-d. To generate a diff of this commit: cvs rdiff -u

CVS commit: src/include

2019-05-27 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Mon May 27 07:31:11 UTC 2019 Modified Files: src/include: assert.h Log Message: As a _NETBSD_SOURCE extension define static_assert for pre-c11/c++99 Proposed on source-changes-d. To generate a diff of this commit: cvs rdiff -u

CVS commit: src/sys/kern

2019-05-25 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Sun May 26 05:41:45 UTC 2019 Modified Files: src/sys/kern: subr_kcov.c Log Message: Drop no longer available macros KCOV_STORE() KCOV_LOAD() in kcov(4) Recently KCOV_STORE() and KCOV_LOAD() were equivalent to x=y. Obtained from

CVS commit: src/sys/kern

2019-05-25 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Sun May 26 05:41:45 UTC 2019 Modified Files: src/sys/kern: subr_kcov.c Log Message: Drop no longer available macros KCOV_STORE() KCOV_LOAD() in kcov(4) Recently KCOV_STORE() and KCOV_LOAD() were equivalent to x=y. Obtained from

CVS commit: src

2019-05-25 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Sun May 26 01:44:34 UTC 2019 Modified Files: src/share/man/man4: kcov.4 src/sys/sys: kcov.h src/tests/modules: t_kcov.c Log Message: Drop no longer needed macros KCOV_STORE() KCOV_LOAD() in kcov(4) Corrently

CVS commit: src

2019-05-25 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Sun May 26 01:44:34 UTC 2019 Modified Files: src/share/man/man4: kcov.4 src/sys/sys: kcov.h src/tests/modules: t_kcov.c Log Message: Drop no longer needed macros KCOV_STORE() KCOV_LOAD() in kcov(4) Corrently

CVS commit: src/share/man/man2

2019-05-24 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Sat May 25 05:11:14 UTC 2019 Modified Files: src/share/man/man2: siginfo.2 Log Message: Document TRAP_SCE and TRAP_SCX in siginfo(2) To generate a diff of this commit: cvs rdiff -u -r1.22 -r1.23 src/share/man/man2/siginfo.2

CVS commit: src/lib/libc/sys

2019-05-24 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Sat May 25 04:25:14 UTC 2019 Modified Files: src/lib/libc/sys: ptrace.2 Log Message: Update the ptrace(2) documentation Document that TRAP_EXEC can be returned for PT_SYSCALL. Document truncated byte transfers. To generate a

CVS commit: src/lib/libc/sys

2019-05-24 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Sat May 25 04:25:14 UTC 2019 Modified Files: src/lib/libc/sys: ptrace.2 Log Message: Update the ptrace(2) documentation Document that TRAP_EXEC can be returned for PT_SYSCALL. Document truncated byte transfers. To generate a

CVS commit: src/tests/lib/libc/sys

2019-05-24 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Sat May 25 03:25:08 UTC 2019 Modified Files: src/tests/lib/libc/sys: t_ptrace_wait.c Log Message: Add new user_va0_disable* tests in t_ptrace_wait* Add tests: - user_va0_disable_pt_continue - user_va0_disable_pt_syscall -

CVS commit: src/tests/lib/libc/sys

2019-05-24 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Sat May 25 03:25:08 UTC 2019 Modified Files: src/tests/lib/libc/sys: t_ptrace_wait.c Log Message: Add new user_va0_disable* tests in t_ptrace_wait* Add tests: - user_va0_disable_pt_continue - user_va0_disable_pt_syscall -

CVS commit: src/tests/lib/libc/sys

2019-05-24 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Sat May 25 03:22:53 UTC 2019 Modified Files: src/tests/lib/libc/sys: t_ptrace_wait.h Log Message: Add get_user_va0_disable() in t_ptrace_wait.h Add a utility function to check vm.user_va0_disable. To generate a diff of this

CVS commit: src/tests/lib/libc/sys

2019-05-24 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Sat May 25 03:22:53 UTC 2019 Modified Files: src/tests/lib/libc/sys: t_ptrace_wait.h Log Message: Add get_user_va0_disable() in t_ptrace_wait.h Add a utility function to check vm.user_va0_disable. To generate a diff of this

CVS commit: src/sys/kern

2019-05-24 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Sat May 25 03:20:43 UTC 2019 Modified Files: src/sys/kern: sys_ptrace_common.c Log Message: Relax prohibition of Program Counter set to 0x0 in ptrace(2) In PT_CONTINUE, PT_SYSCALL and PT_DETACH the 3rd argument of ptrace(2)

CVS commit: src/sys/kern

2019-05-24 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Sat May 25 03:20:43 UTC 2019 Modified Files: src/sys/kern: sys_ptrace_common.c Log Message: Relax prohibition of Program Counter set to 0x0 in ptrace(2) In PT_CONTINUE, PT_SYSCALL and PT_DETACH the 3rd argument of ptrace(2)

Re: CVS commit: src/include

2019-05-23 Thread Kamil Rytarowski
On 23.05.2019 16:09, m...@netbsd.org wrote: > On Thu, May 23, 2019 at 09:05:00AM +0200, Martin Husemann wrote: >> On Thu, May 23, 2019 at 12:03:33AM +0200, Kamil Rytarowski wrote: >>>>> -#if ((__cplusplus - 0) < 201103L) >>>>> +#if defined(_ISOC11_SO

Re: CVS commit: src/include

2019-05-22 Thread Kamil Rytarowski
On 22.05.2019 23:35, Kamil Rytarowski wrote: > On 22.05.2019 23:25, Maya Rashish wrote: >> Module Name: src >> Committed By:maya >> Date:Wed May 22 21:25:01 UTC 2019 >> >> Modified Files: >> src/include: assert.h >> >

Re: CVS commit: src/include

2019-05-22 Thread Kamil Rytarowski
On 22.05.2019 23:25, Maya Rashish wrote: > Module Name: src > Committed By: maya > Date: Wed May 22 21:25:01 UTC 2019 > > Modified Files: > src/include: assert.h > > Log Message: > Limit static_assert visibility to C11. > > The existing definition caused issues as GCC only

CVS commit: src

2019-05-22 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Wed May 22 08:31:26 UTC 2019 Modified Files: src/share/mk: bsd.sys.mk src/sys/arch/amd64/conf: Makefile.amd64 Log Message: Allow to use KCOV + kASan together Stop instrumenting KCOV files with kASan and the other way

Re: CVS commit: src/sys

2019-05-10 Thread Kamil Rytarowski
On 08.05.2019 11:34, Ryota Ozaki wrote: > On Sat, Apr 20, 2019 at 6:45 PM Ryota Ozaki wrote: >> >> On Fri, Apr 19, 2019 at 6:49 PM Kamil Rytarowski wrote: >>> >>> On 19.04.2019 11:41, J. Hannken-Illjes wrote: >>>>> On 19. Apr 2019, at 03:52,

Re: CVS commit: src

2019-05-08 Thread Kamil Rytarowski
On 09.05.2019 06:25, Kamil Rytarowski wrote: > On 24.04.2019 12:26, Roy Marples wrote: >> Module Name: src >> Committed By:roy >> Date:Wed Apr 24 10:26:09 UTC 2019 >> >> Modified Files: >> src/distrib/sets: comments deps descrs

Re: CVS commit: src

2019-05-08 Thread Kamil Rytarowski
On 24.04.2019 12:26, Roy Marples wrote: > Module Name: src > Committed By: roy > Date: Wed Apr 24 10:26:09 UTC 2019 > > Modified Files: > src/distrib/sets: comments deps descrs > src/distrib/sets/lists/comp: mi > src/include: Makefile > > Log Message: > Don't install

Re: CVS commit: src/sys/kern

2019-05-06 Thread Kamil Rytarowski
On 07.05.2019 03:22, Paul Goyette wrote: > Just a thought > > Currently we have the global sysctl variable, but I wonder if it should > be made local to a particular emulation and/or to an individual process? > I think it would be too much. We already warn a user with ttyprintf(9) once

Re: CVS commit: src/sys/kern

2019-05-06 Thread Kamil Rytarowski
On 07.05.2019 02:49, matthew green wrote: >> I see. I will document in the man page that (void *)0 and (void *)1 are >> special cases and they have to be set with PTRACE_REG_SET_PC() >> explicitly if really intended. >> >> Keeping allowed 0x0 in PT_CONTINUE/PT_DETACH/.. makes it harder to >>

Re: CVS commit: src/sys/kern

2019-05-06 Thread Kamil Rytarowski
On 06.05.2019 22:59, Joerg Sonnenberger wrote: > On Thu, May 02, 2019 at 03:01:31AM +0200, Kamil Rytarowski wrote: >> We forbid NULL pointer dereference on modern ports. It was certainly >> used by PDP-11 as there was a special zeroed mask in 0x0 and >> dereferencing NULL

Re: CVS commit: src/sys

2019-05-05 Thread Kamil Rytarowski
On 05.05.2019 22:22, matthew green wrote: > "Kamil Rytarowski" writes: >> Module Name: src >> Committed By:kamil >> Date:Fri May 3 22:34:21 UTC 2019 >> >> Modified Files: >> src/sys/kern: kern_exec.c kern_fork.c ke

Re: CVS commit: [netbsd-7] src/sys/kern

2019-05-02 Thread Kamil Rytarowski
On 02.05.2019 20:59, Maxime Villard wrote: > Le 01/05/2019 à 11:48, Martin Husemann a écrit : >> Module Name:    src >> Committed By:    martin >> Date:    Wed May  1 09:48:56 UTC 2019 >> >> Modified Files: >> src/sys/kern [netbsd-7]: sys_pipe.c >> >> Log Message: >> Pull up following

Re: CVS commit: src/sys/kern

2019-05-01 Thread Kamil Rytarowski
On 02.05.2019 02:48, matthew green wrote: > "Kamil Rytarowski" writes: >> Module Name: src >> Committed By:kamil >> Date:Wed May 1 17:02:40 UTC 2019 >> >> Modified Files: >> src/sys/kern: sys_ptrace_common.c >> &

Re: CVS commit: src/sys

2019-04-19 Thread Kamil Rytarowski
On 19.04.2019 11:41, J. Hannken-Illjes wrote: >> On 19. Apr 2019, at 03:52, Ryota Ozaki wrote: >> >> Module Name: src >> Committed By:ozaki-r >> Date:Fri Apr 19 01:52:56 UTC 2019 >> >> Modified Files: >> src/sys/kern: kern_lwp.c kern_softint.c subr_psref.c >>

Re: CVS commit: src/sys

2019-04-06 Thread Kamil Rytarowski
On 04.04.2019 21:32, Christos Zoulas wrote: > In article <86734bad-b0e6-57dc-3e0f-5d7c124fa...@gmx.com>, > Kamil Rytarowski wrote: >> -=-=-=-=-=- >> -=-=-=-=-=- >> >> On 04.04.2019 02:42, Christos Zoulas wrote: >>> Intermediate or not quality co

Re: CVS commit: src

2019-04-06 Thread Kamil Rytarowski
On 06.04.2019 05:06, Jason R Thorpe wrote: > Module Name: src > Committed By: thorpej > Date: Sat Apr 6 03:06:29 UTC 2019 > > Modified Files: > src/distrib/sets/lists/comp: mi > src/distrib/sets/lists/tests: module.mi > src/share/man/man9: Makefile ipi.9 ucas.9 >

Re: CVS commit: src

2019-04-04 Thread Kamil Rytarowski
On 04.04.2019 21:35, matthew green wrote: > thanks for updating indent. > >> Log Message: >> Upgrade indent(1) >> >> Merge all the changes from the recent FreeBSD HEAD snapshot >> into our local copy. > > can you use "cvs import" on the original sources so we know what > we changed, etc, making

Re: CVS commit: src/sys

2019-04-03 Thread Kamil Rytarowski
On 04.04.2019 02:42, Christos Zoulas wrote: > Intermediate or not quality counts It would have been simple enough to > write the function once and call it from 13 places, perhaps even less work! > It does. I'm waiting now on releng test results (the service seems to be returning 503) and I

Re: CVS commit: src/sys

2019-04-03 Thread Kamil Rytarowski
On 03.04.2019 14:04, Christos Zoulas wrote: > Yes, but this md copy-pasted code should be handled with an MI function. > If it is all the same don't copy it 13 times! > Nothing to add. This is an intermediate step. Next planned steps in this domain: - assert expected behavior in posix_spawn

Re: CVS commit: src/external/bsd/jemalloc

2019-03-10 Thread Kamil Rytarowski
On 10.03.2019 10:21, Kamil Rytarowski wrote: > On 10.03.2019 10:00, Tom Ivar Helbekkmo wrote: >> Christos Zoulas writes: >> >>> Module Name:src >>> Committed By: christos >>> Date: Sun Mar 10 02:49:52 UTC 2019 >>> &g

Re: CVS commit: src/external/bsd/jemalloc

2019-03-10 Thread Kamil Rytarowski
On 10.03.2019 10:00, Tom Ivar Helbekkmo wrote: > Christos Zoulas writes: > >> Module Name: src >> Committed By:christos >> Date:Sun Mar 10 02:49:52 UTC 2019 >> >> Modified Files: >> src/external/bsd/jemalloc/dist/src: jemalloc.c >>

Re: CVS commit: src/sys/netinet

2019-02-25 Thread Kamil Rytarowski
On 25.02.2019 11:23, Martin Husemann wrote: > On Mon, Feb 25, 2019 at 01:19:02PM +0300, Valery Ushakov wrote: >> On Mon, Feb 25, 2019 at 06:23:33 +0100, Martin Husemann wrote: >> >>> On Sun, Feb 24, 2019 at 09:43:52PM +0100, Kamil Rytarowski wrote: >>>> I con

Re: CVS commit: src/sys/netinet

2019-02-24 Thread Kamil Rytarowski
On 24.02.2019 23:55, Robert Swindells wrote: > > Kamil Rytarowski wrote: >> Module Name:src >> Committed By: kamil >> Date: Sun Feb 24 17:01:52 UTC 2019 >> >> Modified Files: >>src/sys/netinet: sctp_asconf.h >> >>

Re: CVS commit: src/sys/netinet

2019-02-24 Thread Kamil Rytarowski
On 24.02.2019 21:38, Martin Husemann wrote: > On Sun, Feb 24, 2019 at 09:36:55PM +0100, Kamil Rytarowski wrote: >> My only specific change was NetBSD/i386 kernel=GENERIC with kUBSan and >> KCOV enabled. > > This does not answer the question. What does enabling kUBSan

Re: CVS commit: src/sys/netinet

2019-02-24 Thread Kamil Rytarowski
On 24.02.2019 21:43, Kamil Rytarowski wrote: > On 24.02.2019 21:38, Martin Husemann wrote: >> On Sun, Feb 24, 2019 at 09:36:55PM +0100, Kamil Rytarowski wrote: >>> My only specific change was NetBSD/i386 kernel=GENERIC with kUBSan and >>> KCOV enabled. >> >>

Re: CVS commit: src/sys/netinet

2019-02-24 Thread Kamil Rytarowski
On 24.02.2019 20:39, Martin Husemann wrote: > On Sun, Feb 24, 2019 at 07:20:10PM +0100, Kamil Rytarowski wrote: >> On 24.02.2019 19:15, David Holland wrote: >>> On Sun, Feb 24, 2019 at 05:01:52PM +, Kamil Rytarowski wrote: >>> > Modified Files: >>

Re: CVS commit: src/sys/netinet

2019-02-24 Thread Kamil Rytarowski
On 24.02.2019 19:15, David Holland wrote: > On Sun, Feb 24, 2019 at 05:01:52PM +0000, Kamil Rytarowski wrote: > > Modified Files: > >src/sys/netinet: sctp_asconf.h > > > > Log Message: > > Appease GCC7 in sctp_asconf.h > > > > Do not

Re: CVS commit: src

2019-02-23 Thread Kamil Rytarowski
On 23.02.2019 08:35, Martin Husemann wrote: > On Sat, Feb 23, 2019 at 03:10:07AM +0000, Kamil Rytarowski wrote: >> Module Name: src >> Committed By:kamil >> Date:Sat Feb 23 03:10:06 UTC 2019 >> >> Modified Files: >> src/distrib/

Re: CVS commit: src/external/gpl3/gcc/lib

2019-02-08 Thread Kamil Rytarowski
On 08.02.2019 23:06, matthew green wrote: > Module Name: src > Committed By: mrg > Date: Fri Feb 8 22:06:12 UTC 2019 > > Modified Files: > src/external/gpl3/gcc/lib/libasan: Makefile > src/external/gpl3/gcc/lib/libtsan: Makefile > src/external/gpl3/gcc/lib/libubsan:

Re: CVS commit: src/tests/lib/libc/misc

2019-02-04 Thread Kamil Rytarowski
On 04.02.2019 09:50, Robert Elz wrote: > Date:Mon, 4 Feb 2019 05:02:46 +0100 > From: Kamil Rytarowski > Message-ID: <2eadaf71-d7d7-c285-bdec-78ddcd3a5...@gmx.com> > > > | If GCC is fine with it, we could try raise(!!(a * b) ? SIGSEGV : SIGB

Re: CVS commit: src/tests/lib/libc/misc

2019-02-03 Thread Kamil Rytarowski
On 04.02.2019 04:10, matthew green wrote: > Module Name: src > Committed By: mrg > Date: Mon Feb 4 03:10:33 UTC 2019 > > Modified Files: > src/tests/lib/libc/misc: Makefile t_ubsan.c > > Log Message: > - revert previous to t_ubsan.c, it is desired behaviour. from kamil. > - use

Re: CVS commit: src

2019-02-03 Thread Kamil Rytarowski
On 03.02.2019 11:45, matthew green wrote: > Module Name: src > Committed By: mrg > Date: Sun Feb 3 10:45:58 UTC 2019 > > Modified Files: > src/games/backgammon/backgammon: main.c > src/tests/lib/libc/misc: t_ubsan.c > > Log Message: > - avoid multipling a boolean value, use

Re: CVS commit: src/bin/sleep

2019-01-28 Thread Kamil Rytarowski
On 28.01.2019 13:45, Robert Elz wrote: > Date:Mon, 28 Jan 2019 11:12:07 +0100 > From: Kamil Rytarowski > Message-ID: > > | In my perception yes. Such calls won't be portable and can stop to be > | functional with tool upgrade/change. > >

Re: CVS commit: src/bin/sleep

2019-01-28 Thread Kamil Rytarowski
On 28.01.2019 01:52, Robert Elz wrote: > The only question is whether there > is any harm in also accepting the 0,2 form when ',' is the > "decimal point". In my perception yes. Such calls won't be portable and can stop to be functional with tool upgrade/change. I have checked that some countries

Re: CVS commit: src/bin/sleep

2019-01-27 Thread Kamil Rytarowski
On 27.01.2019 06:54, Kamil Rytarowski wrote: > On 27.01.2019 05:42, Robert Elz wrote: >> Yes, like English... I wasn't previously aware that '.' was ever used >> as the grouping char, though I did believe that some locales use a >> space for that purpose. >

Re: CVS commit: src/bin/sleep

2019-01-26 Thread Kamil Rytarowski
On 27.01.2019 05:42, Robert Elz wrote: > Yes, like English... I wasn't previously aware that '.' was ever used > as the grouping char, though I did believe that some locales use a > space for that purpose. I don't know whether there is formality that is followed, but in practice people use no

Re: CVS commit: src/bin/sleep

2019-01-26 Thread Kamil Rytarowski
On 26.01.2019 16:05, Martin Husemann wrote: > On Sat, Jan 26, 2019 at 12:28:08PM +0100, Kamil Rytarowski wrote: >>> Those take no floating point input that I can see. For sort, >>> its only use of floats would be sorting files containing them, >>> for which (I ass

Re: CVS commit: src/bin/sleep

2019-01-26 Thread Kamil Rytarowski
On 26.01.2019 02:30, Robert Elz wrote: > Date:Fri, 25 Jan 2019 15:51:05 +0100 > From: Kamil Rytarowski > Message-ID: > > | sort(1) > | stat(1) > > Those take no floating point input that I can see. For sort, > its only use of fl

Re: CVS commit: src/bin/sleep

2019-01-25 Thread Kamil Rytarowski
On 25.01.2019 15:35, Christos Zoulas wrote: > On Jan 25, 8:59pm, k...@munnari.oz.au (Robert Elz) wrote: > -- Subject: Re: CVS commit: src/bin/sleep > > | Sounds entirely reasonable, except the standards won't say anything > | relevant about sleep in particular, as only integers are supported

Re: CVS commit: src/bin/sleep

2019-01-25 Thread Kamil Rytarowski
On 25.01.2019 14:08, Robert Elz wrote: > Date:Fri, 25 Jan 2019 12:38:00 +0100 > From: Kamil Rytarowski > Message-ID: <9790a289-8b3e-e57a-e4d8-c021aa7b1...@gmx.com> > > | I think it's better to keep an uniform way of handling separator in >

Re: CVS commit: src/bin/sleep

2019-01-25 Thread Kamil Rytarowski
On 25.01.2019 11:38, Robert Elz wrote: > Date:Fri, 25 Jan 2019 12:30:23 +0300 > From:Valery Ushakov > Message-ID: <20190125093023.gc18...@pony.stderr.spb.ru> > > | As someone who actually have to ecnoutner locales in daily life and > | not just think about them

Re: Pre-branch commits

2019-01-12 Thread Kamil Rytarowski
On 12.01.2019 13:54, Martin Husemann wrote: > On Sat, Jan 12, 2019 at 05:11:31AM +0700, Robert Elz wrote: >> I'd like to suggest a possible solution: Go back to the old way, >> and announce the branch date in advance (with a reasonable >> lead time, not just a day or so, which would change

Re: Unaligned access in kernel on ARMv6+ (Re: CVS commit: src/sys/dev/usb)

2019-01-06 Thread Kamil Rytarowski
kUBSan detected a number of unaligned accesses in USB code: http://netbsd.org/~kamil/kubsan/0007-boot-real-hardware.txt On 06.01.2019 09:46, Rin Okuyama wrote: > (CC added to port-...@netbsd.org) > > Let me summarize the problem briefly. In axe(4), there is a code where > memcpy() is carried

Re: CVS commit: src

2019-01-02 Thread Kamil Rytarowski
On 02.01.2019 08:42, Joerg Sonnenberger wrote: > On Tue, Jan 01, 2019 at 10:30:38PM +0100, Kamil Rytarowski wrote: >> Joerg seems to just want to play with Clang out of the LLVM projects, >> deteriorating experience with the rest blocking this patch. Other people >> need mor

Re: CVS commit: src

2019-01-01 Thread Kamil Rytarowski
On 02.01.2019 02:52, Roy Marples wrote: > On 01/01/2019 21:30, Kamil Rytarowski wrote: >> Joerg seems to just want to play with Clang out of the LLVM projects, >> deteriorating experience with the rest blocking this patch. Other people >> need more than that. > >

Re: CVS commit: src

2019-01-01 Thread Kamil Rytarowski
On 01.01.2019 15:07, Joerg Sonnenberger wrote: > On Tue, Jan 01, 2019 at 05:45:31AM +0100, Kamil Rytarowski wrote: >> Regarding usefulness, it's a step forward to reusing builtin toolchain >> for dependencies (xsrc, pkgsrc). > > Installing headers alone is absolutely

Re: CVS commit: src

2019-01-01 Thread Kamil Rytarowski
On 01.01.2019 14:33, Martin Husemann wrote: > On Tue, Jan 01, 2019 at 05:45:31AM +0100, Kamil Rytarowski wrote: >> LLVM has no API/ABI stability contract and we are down to just keep >> syncing the headers and libraries with LLVM releases. > > Can you explain this in mor

Re: CVS commit: src

2018-12-31 Thread Kamil Rytarowski
On 01.01.2019 04:13, Joerg Sonnenberger wrote: >> Log Message: >> Install most of the llvm headers. >> >> This is missing some generated files, llvm/include/IR/*.inc > Can you please not do such changes without proper discussion? I'm *very* > strongly against this. At the very least it is not

Re: CVS commit: src/sys/sys

2018-11-06 Thread Kamil Rytarowski
On 07.11.2018 00:55, m...@netbsd.org wrote: > On Tue, Nov 06, 2018 at 11:15:11PM +0300, Valery Ushakov wrote: >> On Tue, Nov 06, 2018 at 16:26:44 +, Maya Rashish wrote: >> >>> Module Name:src >>> Committed By: maya >>> Date: Tue Nov 6 16:26:44 UTC 2018 >>> >>>

Re: CVS commit: src/lib/libc

2018-11-06 Thread Kamil Rytarowski
On 07.11.2018 03:34, matthew green wrote: > "Maya Rashish" writes: >> Module Name: src >> Committed By:maya >> Date:Mon Nov 5 04:08:40 UTC 2018 >> >> Modified Files: >> src/lib/libc: shlib_version >> >> Log Message: >> Suggest to remove lfs_ stubs on a major bump. >>

Re: CVS commit: src/sys/external/bsd/drm2/dist/drm/i915

2018-09-23 Thread Kamil Rytarowski
On 23.09.2018 04:28, Robert Elz wrote: > Date:Sat, 22 Sep 2018 22:03:56 +0200 > From: Kamil Rytarowski > Message-ID: <164fe80f-089f-ea38-1751-e442e6125...@gmx.com> > > > | I know, but in this case the symbol name (preprocessor symbol) was

Re: CVS commit: src/sys/external/bsd/drm2/dist/drm/i915

2018-09-22 Thread Kamil Rytarowski
On 21.09.2018 14:22, Christos Zoulas wrote: > In article <20180921114916.d5b8cf...@cvs.netbsd.org>, > Kamil Rytarowski wrote: >> -=-=-=-=-=- >> >> Module Name: src >> Committed By:kamil >> Date:Fri Sep 21 11:49:16 UTC 2018 >>

Re: CVS commit: src/sys/kern

2018-08-20 Thread Kamil Rytarowski
On 20.08.2018 20:33, matthew green wrote: > "Maxime Villard" writes: >> Module Name: src >> Committed By:maxv >> Date:Mon Aug 20 11:35:28 UTC 2018 >> >> Modified Files: >> src/sys/kern: files.kern subr_kmem.c >> >> Log Message: >> Retire KMEM_REDZONE and KMEM_POISON.

Re: CVS commit: src/external/cddl/osnet/dev/dtrace/amd64

2018-08-16 Thread Kamil Rytarowski
On 12.08.2018 18:07, Christos Zoulas wrote: > Module Name: src > Committed By: christos > Date: Sun Aug 12 16:07:27 UTC 2018 > > Modified Files: > src/external/cddl/osnet/dev/dtrace/amd64: dtrace_isa.c > > Log Message: > handle variable kernel vm min address > > > To generate a

Re: CVS commit: src/external/bsd/dhcpcd/dist/src

2018-08-04 Thread Kamil Rytarowski
On 04.08.2018 05:44, Robert Elz wrote: > Date:Sat, 4 Aug 2018 04:24:01 +0200 > From: Kamil Rytarowski > Message-ID: <568544f4-36d5-853e-cdf8-248f84fad...@gmx.com> > > | I haven't changed any optimization or similar flags for the builds. >

Re: CVS commit: src/external/bsd/dhcpcd/dist/src

2018-08-03 Thread Kamil Rytarowski
On 04.08.2018 03:23, Robert Elz wrote: > Date:Sat, 4 Aug 2018 02:15:15 +0200 > From: Kamil Rytarowski > Message-ID: > > > | In general there shall not be a relation between -O level and > | sanitizers. Sanitizers do not need -O0 or -g for o

Re: CVS commit: src/external/bsd/dhcpcd/dist/src

2018-08-03 Thread Kamil Rytarowski
On 04.08.2018 01:31, Robert Elz wrote: > Kamil: assuming you agree that this is a reasonable analysis, I'd suggest > no more code changes based upon gcc warnings issued this way. In general there shall not be a relation between -O level and sanitizers. Sanitizers do not need -O0 or -g for

Re: CVS commit: src/external/bsd/dhcpcd/dist/src

2018-08-03 Thread Kamil Rytarowski
On 03.08.2018 20:49, Roy Marples wrote: > On 03/08/2018 15:22, Robert Elz wrote: >> Whether there need to be any attention to the possibility >> of a malformed packet I will leave for Roy to decide (I am >> assuming probably not) but that added cast just looks to be >> a bandaid for a broken

Re: CVS commit: src/external/bsd/dhcpcd/dist/src

2018-08-03 Thread Kamil Rytarowski
On 03.08.2018 15:20, Martin Husemann wrote: > On Fri, Aug 03, 2018 at 03:18:18PM +0200, Kamil Rytarowski wrote: >> The change was indicating to the compiler that code is safe, without >> changing the algorithm. > > I don't get why. > > Martin > Overflow (u

Re: CVS commit: src/external/bsd/dhcpcd/dist/src

2018-08-03 Thread Kamil Rytarowski
On 03.08.2018 15:02, Martin Husemann wrote: > On Fri, Aug 03, 2018 at 02:47:53PM +0200, Kamil Rytarowski wrote: >>> Further if there ever was a potential problem from this line ... >>> >>> *len = ntohs(p->ip.ip_len) - sizeof(p->ip) - sizeof(p->udp);

Re: CVS commit: src/external/bsd/dhcpcd/dist/src

2018-08-03 Thread Kamil Rytarowski
On 03.08.2018 12:26, Robert Elz wrote: > Date:Fri, 3 Aug 2018 02:17:33 + > From: "Kamil Rytarowski" > Message-ID: <20180803021733.b2002f...@cvs.netbsd.org> > > | GCC with -fsanitize=undefiend detects a potential overflow in the co

Re: CVS commit: src/sys/kern

2018-08-02 Thread Kamil Rytarowski
On 02.08.2018 12:23, Kamil Rytarowski wrote: > I will defer the research on a proper solution in the networking code as > I'm swamped by the development and improving of tool catching > misalignment access. I will be done with it soon. > For the record, I've landed the kUBSan im

Re: ubsan.c (was: CVS commit: src/common/lib/libc/misc)

2018-08-02 Thread Kamil Rytarowski
On 03.08.2018 04:48, Paul Goyette wrote: > If there are no licensing issues or concerns, then please describe the > real reason(s) for avoiding KNF. > > As discussed, we have removed the comment and drop the unnecessary part from CVS log. signature.asc Description: OpenPGP digital signature

<    2   3   4   5   6   7   8   9   >