Re: CVS commit: src/sys/dev/pci

2012-09-01 Thread Manuel Bouyer
s. Hum, gcc is wrong here, cmdlen and fields are only used if do_csum == true, and do_csum cannot be changed between setting it to false and testing it. Is it dependant on compiler flags ? -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: CVS commit: src/sys/dev/pci

2012-08-30 Thread Manuel Bouyer
should already be working correctly? Thanks, I will > verify. It should, yes. But now that programming docs are publically available, we may be able to do something if it doesn't work. -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: CVS commit: src/sys/dev/pci

2012-08-30 Thread Manuel Bouyer
82574. This commit fixes only the I350 because it's the only one I can test, but the new queue interface should probably be used for all WM_F_NEWQUEUE devices (which are: 82575, 82576, 82580 and I350). -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: CVS commit: src/sys/arch/xen/x86

2012-08-21 Thread Manuel Bouyer
you use u_long * for kcpuset_* interface ? -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: CVS commit: src/sys

2012-08-01 Thread Manuel Bouyer
On Tue, Jul 31, 2012 at 11:58:51AM -0500, Jonathan A. Kollasch wrote: > On Tue, Jul 31, 2012 at 03:50:39PM +0000, Manuel Bouyer wrote: > > Apply back changes that were reverted on Jul 24 and Jul 26 (general ata/wdc > > cleanup and SATA PMP support), now that I'm back to fix the

Re: CVS commit: src/sys

2012-08-01 Thread Manuel Bouyer
On Tue, Jul 31, 2012 at 11:32:02AM -0700, Hisashi T Fujinaka wrote: > On Tue, 31 Jul 2012, Jonathan A. Kollasch wrote: > > >On Tue, Jul 31, 2012 at 03:50:39PM +0000, Manuel Bouyer wrote: > >>Apply back changes that were reverted on Jul 24 and Jul 26 (general ata/wdc >

Re: CVS commit: src/sys

2012-07-04 Thread Manuel Bouyer
On Mon, Jul 02, 2012 at 11:13:51PM +0100, Mindaugas Rasiukevicius wrote: > "Manuel Bouyer" wrote: > > Module Name:src > > Committed By: bouyer > > Date: Mon Jul 2 18:15:48 UTC 2012 > > > > ... > > > > Log Mes

Re: CVS commit: src/sys/dev/scsipi

2012-04-20 Thread Manuel Bouyer
x27;m asking you to do here. Sorry, but I won't fix all ATA, SCSI and ethernet drivers. I'll go fix autoconfig instead. > > > > this isn't about SMPifing a whole driver, but adding a call to > > > taken/release the kernel lock around a few (often just one) > > > calls in a driver. it has never been a difficult change to > > > make. if you have drivers that needs it, i am happy to send > > > patches for testing. > > > > *ALL* non-MPSAFE drivers needs it. > > how can all drivers need scsipi specific code? *most* of the > scsipi drivers do not actually call into scsipi in the attach > routine, from what i recall looking a few months ago. most of them do config_found() in their attach routine to attach their scsibuses (but then we're back to autoconfig: scsipi not being MPSAFE, autoconfig should not call its attach routine without KERNEL_LOCK). > > what i'm asking you for is a list of actual problems you've seen > with the KASSERT() you changed so i can fix those, and revert > your change. please help me advance the state of netbsd smp. I think you have the list: all scsi drivers. -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: CVS commit: src/sys/dev/scsipi

2012-04-20 Thread Manuel Bouyer
On Fri, Apr 20, 2012 at 07:46:35AM +, David Holland wrote: > On Fri, Apr 20, 2012 at 09:37:00AM +0200, Manuel Bouyer wrote: > > > we've never had autoconfig run with the kernel lock AFAICT, so this > > > assumption has never been true. > > > > So

Re: CVS commit: src/sys/dev/scsipi

2012-04-20 Thread Manuel Bouyer
f them need to be patched. -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: CVS commit: src/sys/dev/scsipi

2012-04-20 Thread Manuel Bouyer
that are wrong and fix them. your change hides this. the contract has changed in a way that exposes all non-MPSAFE driver to a race condition. The problem shows up in scsipi, but it's not the only place where the problem exists. ata is not MP-safe, so the problem is also in IDE and SATA

Re: CVS commit: src/sys/dev/scsipi

2012-04-19 Thread Manuel Bouyer
7;s a problem with autoconf not dealing with non-MPSAFE drivers, not the driver themselve (they were working before the MP changes, they should continue to work as-is). If you want autoconf to not run under the KERNEL_LOCK when not needed, then is has to be extended so that MPSAFE drivers can regist

Re: CVS commit: src/sys/dev/scsipi

2012-04-19 Thread Manuel Bouyer
t as well - e.g. sys/dev/ata). Either attach() functions should always be called with KERNEL_LOCK(), or for checks as above we have to accept that when cold, locking is not fully up yet and lock checks should be bypassed. -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: CVS commit: src/sys/dev/scsipi

2012-04-19 Thread Manuel Bouyer
ld (e.g. after a detach/rescan of the pci bus), the driver's attach should be called with KERNEL_LOCK held, or bad things may happen when interrupts are enabled for this driver. What kind of senario do you have in mind ? -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: CVS commit: [netbsd-5-1] src

2012-03-17 Thread Manuel Bouyer
On Sat, Mar 17, 2012 at 07:17:04PM +, Manuel Bouyer wrote: > Module Name: src > Committed By: bouyer > Date: Sat Mar 17 19:17:04 UTC 2012 > > Modified Files: > src/doc [netbsd-5-1]: CHANGES-5.1.3 > src/usr.bin/ktruss [netbsd-5-1]: makeerrnos.sh >

Re: CVS commit: [netbsd-6] src/sys/uvm

2012-03-17 Thread Manuel Bouyer
On Sat, Mar 17, 2012 at 05:29:34PM +, Manuel Bouyer wrote: > Module Name: src > Committed By: bouyer > Date: Sat Mar 17 17:29:34 UTC 2012 > > Modified Files: > src/sys/uvm [netbsd-6]: uvm_km.c > > Log Message: > Pull up following revision(s) (reques

Re: CVS commit: src/sys/dev/usb

2012-03-16 Thread Manuel Bouyer
cur->qtd.qtd_buffer[i] = htole32(a); cur->qtd.qtd_buffer_hi[i] = 0; } I agree it would be better. If you mean something else I don't understand :) -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: CVS commit: src/sys/arch/i386/i386

2012-03-05 Thread Manuel Bouyer
On Mon, Mar 05, 2012 at 08:01:09AM +0530, Cherry G. Mathew wrote: > On 5 March 2012 02:14, Manuel Bouyer wrote: > > Module Name:    src > > Committed By:   bouyer > > Date:           Sun Mar  4 20:44:17 UTC 2012 > > > > Modified Files: > >        src/sy

Re: CVS commit: src/sys/arch

2012-02-25 Thread Manuel Bouyer
G_RW; #endif /* XEN */ to: const pd_entry_t pteflags = PG_k | PG_V | PG_RW; (PG_k is defined to PG_u on Xen/amd64 and 0 otherwise). -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: CVS commit: src/sys/arch

2012-02-24 Thread Manuel Bouyer
On Fri, Feb 24, 2012 at 06:14:11PM +0530, Cherry G. Mathew wrote: > On 24 February 2012 15:33, Manuel Bouyer wrote: > > On Fri, Feb 24, 2012 at 03:00:03PM +0530, Cherry G. Mathew wrote: > >> On 22 February 2012 18:31, Manuel Bouyer wrote: > >> > On Wed, Feb 22, 2012

Re: CVS commit: src/sys/arch

2012-02-24 Thread Manuel Bouyer
On Fri, Feb 24, 2012 at 03:00:03PM +0530, Cherry G. Mathew wrote: > On 22 February 2012 18:31, Manuel Bouyer wrote: > > On Wed, Feb 22, 2012 at 06:05:21PM +0530, Cherry G. Mathew wrote: > >> > >> I meant we could make it work, (it would already for amd64/xen since >

Re: CVS commit: src/sys/arch

2012-02-22 Thread Manuel Bouyer
me-critical; I guess a function pointer call is faster than a test. -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: CVS commit: src/sys/arch

2012-02-22 Thread Manuel Bouyer
On Wed, Feb 22, 2012 at 10:15:50AM +0530, Cherry G. Mathew wrote: > Hi Manuel, > > On 22 February 2012 00:40, Manuel Bouyer wrote: > > Module Name:    src > > Committed By:   bouyer > > Date:           Tue Feb 21 19:10:13 UTC 2012 > > > > Modified Files:

Re: CVS commit: src/sys/arch/xen/xen

2012-02-21 Thread Manuel Bouyer
't work. At least functions > from miscfs/genfs/genfs_io.c don't use minphys(). Yes; I did try it with xbd too, things are not so easy. -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: CVS commit: src/sys/uvm

2012-02-20 Thread Manuel Bouyer
On Mon, Feb 20, 2012 at 07:49:16PM +, Mindaugas Rasiukevicius wrote: > "Manuel Bouyer" wrote: > > Module Name:src > > Committed By: bouyer > > Date: Mon Feb 20 19:14:24 UTC 2012 > > > > Modified Files: > >

Re: CVS commit: src/usr.bin/quota

2012-01-31 Thread Manuel Bouyer
entifier name. This has (as far as I can tell) > prevented quotacheck and other old-style quota bits from working since > last March. just to make it clear: this bugs only shows up if you use userquota/groupquota in fstab without an explicit quota file name; that's probably why

Re: CVS commit: src/sys/arch

2012-01-07 Thread Manuel Bouyer
d (I'm not sure why it has been added in the first place) -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: CVS commit: src/sys/arch

2012-01-06 Thread Manuel Bouyer
On Fri, Jan 06, 2012 at 11:33:17AM -0800, Jeff Rizzo wrote: > On 1/6/12 10:26 AM, Manuel Bouyer wrote: > >On Fri, Jan 06, 2012 at 09:03:29PM +0530, Cherry G. Mathew wrote: > >>The diagnostic message that it triggers is very verbose for XEN > >>consoles, which ships wit

Re: CVS commit: src/sys/arch

2012-01-06 Thread Manuel Bouyer
On Fri, Jan 06, 2012 at 09:03:29PM +0530, Cherry G. Mathew wrote: > The diagnostic message that it triggers is very verbose for XEN > consoles, which ships with DIAGNOSTIC set by default ( not sure why > this is the case ). GENERIC has DIAGNOSTIC set by default as well. -- Manu

Re: amd64 direct map causing crashes at boot (Re: CVS commit: src/sys/arch)

2011-12-09 Thread Manuel Bouyer
On Fri, Dec 09, 2011 at 03:52:21PM +0100, Nicolas Joly wrote: > On Fri, Dec 09, 2011 at 03:30:38PM +0100, Manuel Bouyer wrote: > > > > I'd like to see what mem_clusters[] looks like, especially > > mem_clusters[mem_cluster_cnt - 1] > > Added the printfs at the en

Re: amd64 direct map causing crashes at boot (Re: CVS commit: src/sys/arch)

2011-12-09 Thread Manuel Bouyer
On Fri, Dec 09, 2011 at 03:22:45PM +0100, Nicolas Joly wrote: > On Fri, Dec 09, 2011 at 02:41:16PM +0100, Manuel Bouyer wrote: > > On Thu, Dec 08, 2011 at 11:24:35PM +0100, Nicolas Joly wrote: > > > On Thu, Dec 08, 2011 at 11:21:31PM +0100, Joerg Sonnenberger wrote: > > >

Re: amd64 direct map causing crashes at boot (Re: CVS commit: src/sys/arch)

2011-12-09 Thread Manuel Bouyer
mostly when sshd start (or fc-cache is updated). > > >Includes 1 "AMD Opteron(tm) Processor 6128A" CPU > > > > Can you try to disable the use of 1GB pages? > > Already tested for the 6128A, still no luck. Can you print the content of mem_clusters[] and me

Re: amd64 direct map causing crashes at boot (Re: CVS commit: src/sys/arch)

2011-12-08 Thread Manuel Bouyer
r 4800+" CPU. > > 2) A Supermicro H8DG6-F motherboard (only 1 socket populated) later on >boot mostly when sshd start (or fc-cache is updated). >Includes 1 "AMD Opteron(tm) Processor 6128A" CPU Do they announce 1GB pages support ? -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: CVS commit: src/sys/arch

2011-12-08 Thread Manuel Bouyer
ure does for me. Can we back it out temporarily, and what can I Please don't back it out but just don't define __HAVE_DIRECT_MAP in types.h. I'm looking at how Xen can make good use of it and I'd prefer to not see it go away now :) -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: CVS commit: src/sys/arch/xen/xen

2011-12-08 Thread Manuel Bouyer
t; And sizeof(struct pintrhand) != sizeof(intrhand). > > We need a ih_size field to track the right size. No, in event_remove_handler() is't really a intrhand which is freed, not pintrhand (the pintrhand is ih->ih_arg, not ih itself). At this time, pintrhand is never freed. It shou

Re: CVS commit: src/sys/dev

2011-12-01 Thread Manuel Bouyer
e this would need to be a real function call > (possibly an indirect one). I'm not sure bloating the kernel and infrastrucure with functions call, functions pointer and others to be able to compile out 4 lines of code is worth it. -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: CVS commit: src/sys/dev

2011-11-30 Thread Manuel Bouyer
On Wed, Nov 30, 2011 at 01:13:10PM -0500, Christos Zoulas wrote: > On Nov 30, 12:13pm, bou...@antioche.eu.org (Manuel Bouyer) wrote: > -- Subject: Re: CVS commit: src/sys/dev > > | This is not going to be used outside of fss.c so I'm not sure what this > would > | giv

Re: CVS commit: src/sys/dev

2011-11-30 Thread Manuel Bouyer
On Wed, Nov 30, 2011 at 04:26:09PM +, David Holland wrote: > On Wed, Nov 30, 2011 at 12:13:43PM +0100, Manuel Bouyer wrote: > > > Should the header portion move to compat/dev/? > > > > This is not going to be used outside of fss.c so I'm not sure

Re: CVS commit: src/sys/dev

2011-11-30 Thread Manuel Bouyer
On Wed, Nov 30, 2011 at 01:46:19AM +, Christos Zoulas wrote: > In article <2029205612.9148f17...@cvs.netbsd.org>, > Manuel Bouyer wrote: > >-=-=-=-=-=- > > > >Module Name: src > >Committed By:bouyer > >Date:Tue Nov

Re: CVS commit: src/lib/libperfuse

2011-10-23 Thread Manuel Bouyer
t can't just decide by itself how much memory to use for its cache. To make things worse, kern.maxvnodes can be changed after perfused has been started. -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: CVS commit: src/sys/dev/ata

2011-10-05 Thread Manuel Bouyer
te) logical sectors, as the traditional > MAXPHYS value has for at least the past decade. We should be able to go safely up to 256 sectors. Anything larger requires LBA48, which is not supported by some controllers. -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: CVS commit: src/share/man/man4

2011-08-29 Thread Manuel Bouyer
g xencons, and the ddb sequence is '+'. See the cn_set_magic() call in xencons.c -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: CVS commit: src/sys/arch/xen

2011-08-29 Thread Manuel Bouyer
On Mon, Aug 29, 2011 at 03:03:37PM +0200, Cherry G. Mathew wrote: > Hi Manuel, > > >>>>> "Manuel" == Manuel Bouyer writes: > > > [...] > > >> > >> Xen's TLB_FLUSH operation is synchronous, and doesn't requir

Re: CVS commit: src/share/man/man4

2011-08-29 Thread Manuel Bouyer
eak in > the domU (through xencons(4)). But when running inside qemu, you're using qemu's VGA display, not its serial port, right ? in this case I guess the dom0 is using wscons, not the xencons. xencons is (should) be used by dom0 only on serial console. -- Manuel Bouyer

Re: CVS commit: src/sys/arch/xen

2011-08-29 Thread Manuel Bouyer
On Mon, Aug 29, 2011 at 12:07:05PM +0200, Cherry G. Mathew wrote: > JM> On Mon, 22 Aug 2011 12:47:40 +0200, Manuel Bouyer wrote: > >>> This is slightly more complicated than it appears. Some of the > >>> "ops" in a per-cpu queue may have orderi

Re: CVS commit: src/share/man/man4

2011-08-29 Thread Manuel Bouyer
al console (or, to be more precise, xencons which is what is used by dom0 when the hypervisor is configured to use serial console), where break won't work because the hypervisor doesn't forward it to the dom0. -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: CVS commit: src/sys/dev/ic

2011-08-28 Thread Manuel Bouyer
. Ops, sorry. Looks like I commited the wrong version of the patch, before cleanups. The only cleanup needed so far was to remove the #error and a KASSERT() that I added while testing on the fuloong. I just commited the right version of this code. Sorry for this mess ... -- Manuel Bouyer

Re: CVS commit: src/sys/arch/xen

2011-08-22 Thread Manuel Bouyer
sue: with shadow page tables you can't use a CAS to assure atomic operation with the hardware TLB, as this is, precisely, a shadow PT and not the one used by hardware. -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: CVS commit: src/sys/arch/xen

2011-08-21 Thread Manuel Bouyer
o complete, like TLB flushes). I'd expect all > > Xen MMU hypercalls to be reentrant. > > An alternative would be to have per-CPU xpq_queue[] also. This is not > completely stupid, xpq_queue is meant as a way to put multiple MMU > operations in a queue asynchronous

Re: CVS commit: src/sys/arch/i386/conf

2011-08-09 Thread Manuel Bouyer
On Tue, Aug 09, 2011 at 11:23:57AM +0300, Jukka Ruohonen wrote: > On Tue, Aug 09, 2011 at 10:18:29AM +0200, Manuel Bouyer wrote: > > Sorry, but this is just plain stupid. I could as well make so my work > > won't work in a modular kernel, and we'll have incompatible fe

Re: CVS commit: src/sys/arch/i386/conf

2011-08-09 Thread Manuel Bouyer
On Tue, Aug 09, 2011 at 11:16:11AM +0300, Jukka Ruohonen wrote: > On Tue, Aug 09, 2011 at 10:14:08AM +0200, Manuel Bouyer wrote: > > On Tue, Aug 09, 2011 at 10:47:18AM +0300, Jukka Ruohonen wrote: > > > On Tue, Aug 09, 2011 at 09:44:09AM +0200, Alan Barrett wrote: > > >

Re: CVS commit: src/sys/arch/i386/conf

2011-08-09 Thread Manuel Bouyer
t; not consider in this message. > > Fortunately, people can vote with their own work; henceforth all drivers > I write will be available only as modules. You mean, your work cannot be inclued in non-modular kernels ? this is silly. -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: CVS commit: src/sys/arch

2011-07-03 Thread Manuel Bouyer
On Sun, Jul 03, 2011 at 08:00:30PM +0200, Manuel Bouyer wrote: > > Crash reports without backtrace - that is very often useless, and we do > > A panic message (especually from KASSERT which gives the exact place) > is more usefull than the tail of a backtrace. > Xen has trace

Re: CVS commit: src/sys/arch

2011-07-03 Thread Manuel Bouyer
On Sun, Jul 03, 2011 at 06:49:11PM +0100, Mindaugas Rasiukevicius wrote: > Manuel Bouyer wrote: > > On Sun, Jul 03, 2011 at 06:09:10PM +0100, Mindaugas Rasiukevicius wrote: > > > > I also don't think we did reach a consensus about this either. > > > > > &

Re: CVS commit: src/sys/arch

2011-07-03 Thread Manuel Bouyer
proposed. You can still coredump, either what will this do on a serial console ? Again this is not different from other panics we may have in the kernel. -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: CVS commit: src/sys/arch

2011-07-03 Thread Manuel Bouyer
pdate. Apart from updating > motd, I was thinking about some printf()ed warning in the kernel.. Was this ever evaluated ? I have DIAGNOSTIC in all my kernels, and I never noticed a difference in performances for real usages. -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: CVS commit: [cherry-xenmp] src/sys/arch/xen

2011-06-26 Thread Manuel Bouyer
On Sun, Jun 26, 2011 at 05:57:37PM +0300, Jukka Ruohonen wrote: > On Sun, Jun 26, 2011 at 04:39:55PM +0200, Manuel Bouyer wrote: > > Also, you seem to assume that all x86 CPUs on today's market are muticore; > > this is not true. > > No, I don't assume that. My reas

Re: CVS commit: [cherry-xenmp] src/sys/arch/xen

2011-06-26 Thread Manuel Bouyer
f #ifdef MULTIPROCESSOR in 2011 (for x86 MD, at least)? This is Xen, not x86. This may go away some day, but not yet - let the Xen MULTIPROCESSOR code stabilize first. Also, you seem to assume that all x86 CPUs on today's market are muticore; this is not true. -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: CVS commit: [netbsd-5] src/sys/kern

2011-06-19 Thread Manuel Bouyer
es it use the local clog as per other > > instances.. > > My bad, I did not attached the right patch to the ticket pullup. Iain's > patch is the right fix, and it is equivalent to the code I have been > running and testing for weeks. thanks. I've applied this patch

Re: CVS commit: src/tests/syscall

2011-05-21 Thread Manuel Bouyer
e they will vary from machine to machine. Sure. I ran ATF on a machine with a 1Mhz CPU clock (this is a simulator, the real hardware is expected to run faster :). Lots of tests timed out just because on such hardware they can't complete in less than 5mn. -- Manuel Bouyer NetBSD: 2

Re: CVS commit: src/sys/arch/xen/xen

2011-04-06 Thread Manuel Bouyer
uld be used. You could also use xvifxiy (e.g. xvif5i2, where i stands for 'index'). or any other letter ... -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: CVS commit: src/sys/sys

2011-03-10 Thread Manuel Bouyer
have to rebuild tools and > > my module dirs are out of date again. > > Sigh. param.h is not supposed to reflect features changes only ABI > incompatibilities. in fact there is an ABI incompatibility here (a function signature changed in vfsops), but I forgot to bump the kernel version ... -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: CVS commit: src/usr.bin/quota

2011-03-07 Thread Manuel Bouyer
On Mon, Mar 07, 2011 at 11:30:14AM +, Antti Kantee wrote: > On Sun, Mar 06, 2011 at 09:12:49PM +, Christos Zoulas wrote: > > In article <20110306205803.ga15...@antioche.eu.org>, > > Manuel Bouyer wrote: > > >On Sun, Mar 06, 2011 at 03:48:00PM -0500, Christ

Re: CVS commit: src/usr.bin/quota

2011-03-06 Thread Manuel Bouyer
ta.h quota.c > > Log Message: > - WARNS=4 > - KNF > - don't cast malloc > - don't use static buffers > - fix types > - remove extra \n's from errors > - fix prototypes this breaks the build. These utitilies are used bu other quota tools. Why did you #if 0 ti

Re: CVS commit: [netbsd-5] src/sys/arch/sparc/sparc

2011-02-16 Thread Manuel Bouyer
On Wed, Feb 16, 2011 at 09:33:25PM +, Manuel Bouyer wrote: > Module Name: src > Committed By: bouyer > Date: Wed Feb 16 21:33:25 UTC 2011 > > Modified Files: > src/sys/arch/sparc/sparc [netbsd-5]: cpu.c cpuvar.h pmap.c > timer_sun4m.c > >

Re: CVS commit: [bouyer-quota2] src/sys/ufs/ffs

2011-02-09 Thread Manuel Bouyer
On Tue, Feb 08, 2011 at 02:49:32PM -0800, Jeff Rizzo wrote: > On 2/8/11 1:29 PM, Manuel Bouyer wrote: > >Module Name: src > >Committed By:bouyer > >Date:Tue Feb 8 21:29:46 UTC 2011 > > > >Modified Files: > > src/sys/ufs/ffs

Re: CVS commit: src/common

2011-01-21 Thread Manuel Bouyer
On Thu, Jan 20, 2011 at 01:16:39PM +, David Laight wrote: > On Thu, Jan 20, 2011 at 11:17:59AM +0000, Manuel Bouyer wrote: > > Module Name:src > > Committed By: bouyer > > Date: Thu Jan 20 11:17:59 UTC 2011 > > > > Modified Files

Re: CVS commit: src/sys/uvm

2011-01-05 Thread Manuel Bouyer
ours is also used for PIPT systems (to make better use of caches), just in a sighly different way. I think the MI VM system should be made aware of the cache type and select is behavior (i.e. use colours only for PA allocation, or VA+PA allocations) based on this. -- Manuel Bouyer NetBSD: 26

Re: CVS commit: src/sys/uvm

2011-01-04 Thread Manuel Bouyer
On Tue, Jan 04, 2011 at 08:35:48AM -0800, Matt Thomas wrote: > > On Jan 4, 2011, at 8:33 AM, Manuel Bouyer wrote: > > > On Tue, Jan 04, 2011 at 08:03:33AM -0800, Matt Thomas wrote: > >>> I fixed this issue in arch/x86/x86/x86_machdep.c 1.37, I wonder if your > >

Re: CVS commit: src/sys/uvm

2011-01-04 Thread Manuel Bouyer
it, you expect to use it for something :) in which cases do you intend to turn it on ? A kernel config option, or for some ports ? -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: CVS commit: src/sys/uvm

2011-01-04 Thread Manuel Bouyer
if you allocate from the <4Gb free list, you can eat all DMA-capable RAM. I fixed this issue in arch/x86/x86/x86_machdep.c 1.37, I wonder if your change has reintroduced this problem ... -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: CVS commit: src/tests/fs/common

2011-01-03 Thread Manuel Bouyer
ainst the export list, as well as the R/O status for a write request (and other things such as the uid root is mapped to). So if you consider IP address are not spoofables in your environnement, IP-based access and write permissions are fine. -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: CVS commit: src

2010-10-06 Thread Manuel Bouyer
. Once the dump > is successful, this does not matter anymore. Doesn't it work with savecore -N /the_right_kernel ? -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: CVS commit: src/sys/arch

2010-07-24 Thread Manuel Bouyer
On Sat, Jul 24, 2010 at 02:03:14PM +0200, Jean-Yves Migeon wrote: > On 24.07.2010 12:30, Manuel Bouyer wrote: > >> How about making paddr_t always 64bit? That makes it much easier to deal > >> with in libkvm. > > > > The overhead would need to be evaluated first.

Re: CVS commit: src/sys/arch

2010-07-24 Thread Manuel Bouyer
t; How about making paddr_t always 64bit? That makes it much easier to deal > with in libkvm. The overhead would need to be evaluated first. Also, I'm not sure this would fix all the libkvm issues (the page table format is still different). -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

CVS commit: src/sys/dev/apm

2010-03-10 Thread Manuel Bouyer
Module Name:src Committed By: bouyer Date: Wed Mar 10 20:30:00 UTC 2010 Modified Files: src/sys/dev/apm: apm.c Log Message: Fix apm(4) suspend/resume: - apm_suspend() and apm_standby() will call splhhigh() before entering standby or suspend. After resume, the system go b

CVS commit: src/sys/dev/apm

2010-03-10 Thread Manuel Bouyer
Module Name:src Committed By: bouyer Date: Wed Mar 10 20:30:00 UTC 2010 Modified Files: src/sys/dev/apm: apm.c Log Message: Fix apm(4) suspend/resume: - apm_suspend() and apm_standby() will call splhhigh() before entering standby or suspend. After resume, the system go b

CVS commit: src/sys/dev/ic

2010-03-10 Thread Manuel Bouyer
23 Tue Feb 23 21:38:36 2010 +++ src/sys/dev/ic/ahcisata_core.c Wed Mar 10 19:23:57 2010 @@ -1,4 +1,4 @@ -/* $NetBSD: ahcisata_core.c,v 1.23 2010/02/23 21:38:36 bouyer Exp $ */ +/* $NetBSD: ahcisata_core.c,v 1.24 2010/03/10 19:23:57 bouyer Exp $ */ /* * Copyright (c) 2006 Manuel Bouyer. @@ -

CVS commit: src/sys/dev/ic

2010-03-10 Thread Manuel Bouyer
Module Name:src Committed By: bouyer Date: Wed Mar 10 19:23:57 UTC 2010 Modified Files: src/sys/dev/ic: ahcisata_core.c Log Message: ahcisata_core.c 1.23 cause long drive probe (31s, reported by Roy Marples), or other devices misbehavior probably due to interrupts issues (

CVS commit: src/sys/dev/ic

2010-02-23 Thread Manuel Bouyer
Module Name:src Committed By: bouyer Date: Tue Feb 23 21:38:36 UTC 2010 Modified Files: src/sys/dev/ic: ahcisata_core.c Log Message: Move ahci_channel_start() after BSY has cleared (what seems to matter here is not touching SError while BSY is asserted). Fix random behavio

CVS commit: src/sys/dev/i2o

2010-02-21 Thread Manuel Bouyer
Module Name:src Committed By: bouyer Date: Sun Feb 21 18:50:11 UTC 2010 Modified Files: src/sys/dev/i2o: iop.c Log Message: Fix confusion about PRE/POST in previous; and another place that has the same issue. Also add a BUS_DMASYNC_POSTWRITE to the POLL operation. Problem

Re: CVS commit: src/sys/dev/i2o

2010-02-21 Thread Manuel Bouyer
temp = le32toh(*sw); > if (temp == I2O_EXEC_foo); > break; > bus_dmamap_sync(..., PREREAD); > } I see. But this would require changing the macro; more work than what I can do right now. -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: CVS commit: src/sys/dev/i2o

2010-02-21 Thread Manuel Bouyer
gt; > (POLL() macro with bus_dmamap_sync() seems also wrong..) Hum, it looks correct to me. We are after the device wrote something to RAM, so it's a POSTREAD operation, isn't it ? Or do you mean it should be POSTREAD | POSTWRITE ? this would seems more correct to me but it probably d

CVS commit: src/sys/dev/i2o

2010-02-21 Thread Manuel Bouyer
Module Name:src Committed By: bouyer Date: Sun Feb 21 14:16:47 UTC 2010 Modified Files: src/sys/dev/i2o: iop.c Log Message: Fix bus_dmamap_sync(): it should be a BUS_DMASYNC_POSTWRITE after writing to DMA memory. Found by code inspection. To generate a diff of this commi

CVS commit: src/usr.sbin/repquota

2010-02-17 Thread Manuel Bouyer
Module Name:src Committed By: bouyer Date: Wed Feb 17 18:55:14 UTC 2010 Modified Files: src/usr.sbin/repquota: repquota.c Log Message: Make block fields one char wider; allows to sanely display quotas up to 99.9GB while still fitting 80 columns. Something else needs to be

CVS commit: [netbsd-5] src/doc

2010-02-16 Thread Manuel Bouyer
Module Name:src Committed By: bouyer Date: Tue Feb 16 21:27:25 UTC 2010 Modified Files: src/doc [netbsd-5]: CHANGES-5.1 Log Message: Tickets 1307 & 1308 To generate a diff of this commit: cvs rdiff -u -r1.1.2.197 -r1.1.2.198 src/doc/CHANGES-5.1 Please note that diffs ar

CVS commit: [netbsd-5-0] src/doc

2010-02-16 Thread Manuel Bouyer
Module Name:src Committed By: bouyer Date: Tue Feb 16 21:27:22 UTC 2010 Modified Files: src/doc [netbsd-5-0]: CHANGES-5.0.3 Log Message: Tickets 1307 & 1308 To generate a diff of this commit: cvs rdiff -u -r1.1.2.3 -r1.1.2.4 src/doc/CHANGES-5.0.3 Please note that diffs

CVS commit: [netbsd-5-0] src/tools/compat

2010-02-16 Thread Manuel Bouyer
Module Name:src Committed By: bouyer Date: Tue Feb 16 21:26:44 UTC 2010 Modified Files: src/tools/compat [netbsd-5-0]: getmode.c Log Message: Pull up following revision(s) (requested by snj in ticket #1308): tools/compat/getmode.c: revision 1.8 include unistd.h whe

CVS commit: [netbsd-5] src/tools/compat

2010-02-16 Thread Manuel Bouyer
Module Name:src Committed By: bouyer Date: Tue Feb 16 21:26:39 UTC 2010 Modified Files: src/tools/compat [netbsd-5]: getmode.c Log Message: Pull up following revision(s) (requested by snj in ticket #1308): tools/compat/getmode.c: revision 1.8 include unistd.h where

CVS commit: [netbsd-5-0] src/sys/arch/i386/i386

2010-02-16 Thread Manuel Bouyer
Module Name:src Committed By: bouyer Date: Tue Feb 16 21:24:22 UTC 2010 Modified Files: src/sys/arch/i386/i386 [netbsd-5-0]: ibcs2_machdep.c svr4_machdep.c Log Message: Pull up following revision(s) (requested by drochner in ticket #1307): sys/arch/i386/i386/svr4_m

CVS commit: [netbsd-5] src/sys/arch/i386/i386

2010-02-16 Thread Manuel Bouyer
Module Name:src Committed By: bouyer Date: Tue Feb 16 21:24:15 UTC 2010 Modified Files: src/sys/arch/i386/i386 [netbsd-5]: ibcs2_machdep.c svr4_machdep.c Log Message: Pull up following revision(s) (requested by drochner in ticket #1307): sys/arch/i386/i386/svr4_mac

CVS commit: [netbsd-5] src/doc

2010-02-14 Thread Manuel Bouyer
Module Name:src Committed By: bouyer Date: Sun Feb 14 14:05:54 UTC 2010 Modified Files: src/doc [netbsd-5]: CHANGES-5.1 Log Message: Tickets 1300, 1301, 1303, 1304 and 1305 To generate a diff of this commit: cvs rdiff -u -r1.1.2.195 -r1.1.2.196 src/doc/CHANGES-5.1 Pleas

CVS commit: [netbsd-5-0] src/doc

2010-02-14 Thread Manuel Bouyer
Module Name:src Committed By: bouyer Date: Sun Feb 14 14:05:07 UTC 2010 Modified Files: src/doc [netbsd-5-0]: CHANGES-5.0.3 Log Message: Ticket 1305 To generate a diff of this commit: cvs rdiff -u -r1.1.2.1 -r1.1.2.2 src/doc/CHANGES-5.0.3 Please note that diffs are not

CVS commit: [netbsd-5] src/distrib/pmax/instkernel

2010-02-14 Thread Manuel Bouyer
Module Name:src Committed By: bouyer Date: Sun Feb 14 14:04:53 UTC 2010 Modified Files: src/distrib/pmax/instkernel [netbsd-5]: Makefile Log Message: Apply patch, requested by snj in ticket 1305: distrib/pmax/instkernel/Makefile: patch Bump the size of the pmax ins

CVS commit: [netbsd-5-0] src/distrib/pmax/instkernel

2010-02-14 Thread Manuel Bouyer
Module Name:src Committed By: bouyer Date: Sun Feb 14 14:04:48 UTC 2010 Modified Files: src/distrib/pmax/instkernel [netbsd-5-0]: Makefile Log Message: Apply patch, requested by snj in ticket 1305: distrib/pmax/instkernel/Makefile: patch Bump the size of the pmax i

CVS commit: [netbsd-5] src/sys/arch/i386/stand/boot

2010-02-14 Thread Manuel Bouyer
Module Name:src Committed By: bouyer Date: Sun Feb 14 14:01:08 UTC 2010 Modified Files: src/sys/arch/i386/stand/boot [netbsd-5]: boot2.c Log Message: Pull up following revision(s) (requested by hubertf in ticket #1304): sys/arch/i386/stand/boot/boot2.c: revision 1.

CVS commit: [netbsd-5] src/sys/dev/usb

2010-02-14 Thread Manuel Bouyer
Module Name:src Committed By: bouyer Date: Sun Feb 14 13:58:32 UTC 2010 Modified Files: src/sys/dev/usb [netbsd-5]: ukbd.c Log Message: Pull up following revision(s) (requested by sborrill in ticket #1303): sys/dev/usb/ukbd.c: revision 1.104 sys/dev/usb/ukb

CVS commit: [netbsd-5] src/sys/arch/hp700/conf

2010-02-14 Thread Manuel Bouyer
Module Name:src Committed By: bouyer Date: Sun Feb 14 13:57:11 UTC 2010 Modified Files: src/sys/arch/hp700/conf [netbsd-5]: GENERIC Log Message: Pull up following revision(s) (requested by skrll in ticket #1301): sys/arch/hp700/conf/GENERIC: revision 1.92 Add USERC

CVS commit: [netbsd-5] src/sys/ufs/ufs

2010-02-14 Thread Manuel Bouyer
Module Name:src Committed By: bouyer Date: Sun Feb 14 13:55:29 UTC 2010 Modified Files: src/sys/ufs/ufs [netbsd-5]: ufs_lookup.c Log Message: Pull up following revision(s) (requested by dholland in ticket #1300): sys/ufs/ufs/ufs_lookup.c: revision 1.102 Avoid nasal

CVS commit: [netbsd-5] src/doc

2010-02-14 Thread Manuel Bouyer
Module Name:src Committed By: bouyer Date: Sun Feb 14 13:42:54 UTC 2010 Modified Files: src/doc [netbsd-5]: CHANGES-5.1 Log Message: Tickets 1289, 1290, 1292, 1292, 1293, 1297 To generate a diff of this commit: cvs rdiff -u -r1.1.2.194 -r1.1.2.195 src/doc/CHANGES-5.1 Pl

<    1   2   3   4   5   6   7   >