What's wrong with printf("%s", NULL)? It produces '(null)', and at
least it's visible something is missing there. I think gcc 9.3 is
overly eager for this.
Is it correct to just omit the parameter altogether and change output format?
Jaromir
Le dim. 6 sept. 2020 à 04:41, matthew green a écrit :
Le dim. 2 août 2020 à 15:57, Taylor R Campbell
a écrit :
> Why does it improve readability?
Certainly using cringe language features does not help readability.
> What else does -Wvla choke on in src/sys?
Some drm drivers, and uvm, particularly uvm_bio.c. I'd like to work
towards enabling -Wvla
Readability first and foremost in this case.
I was exploring if I can disable VLAs for the kernel altogether, this
can't be done for now. Nevertheless, this change looked like it would
be useful to make anyway.
Le dim. 2 août 2020 à 01:15, Taylor R Campbell
a écrit :
>
> > Module Name:src
>
One of the things which need to be done is calling the if_ioctl always
with the IFNET_LOCK() held. Right now it sometimes is, and other times
it is not, so it's not possible to rely on it and KASSERT().
As for bnx(4) I did just some basic fixes around making it work with
MSI(-X), since I don't rea
Perhaps we can use a similar technique for mips too? There also the
kernel actually always uses a compile-time fixed page size AFAICS.
Jaromir
Le sam. 27 juin 2020 à 04:51, Rin Okuyama a écrit :
>
> Module Name:src
> Committed By: rin
> Date: Sat Jun 27 02:51:23 UTC 2020
>
> Modi
The static variable was in #ifdef __NetBSD__ part, so I assumed it
doesn't influence the merge.
Christos already reverted the fallthrough warning fix.
Jaromir
Le jeu. 13 févr. 2020 à 09:18, matthew green a écrit :
>
> "Jaromir Dolecek" writes:
> > Module Name: src
> > Committed By: jdolecek
>
Good point, added asserts in genfs_io.c for this.
Le dim. 9 déc. 2018 à 23:56, matthew green a écrit :
>
> "Jaromir Dolecek" writes:
> > Module Name: src
> > Committed By: jdolecek
> > Date: Sun Dec 9 20:45:37 UTC 2018
> >
> > Modified Files:
> > src/sys/uvm: uvm_bio.c
> >
> > Log
Maybe I missed something earlier - does KASLR being enabled by default
mean that x86 now doesn't any more use the direct map to copy memory
pages?
Jaromir
Le ven. 7 déc. 2018 à 16:47, Maxime Villard a écrit :
>
> Module Name:src
> Committed By: maxv
> Date: Fri Dec 7 15:47:11 UTC
Shouldn't this:
memtop |= (uint16_t)mpbios_page[0x414] << 8;
be actually << 16 to keep the same semantics?
Jaromir
Le dim. 8 juil. 2018 à 01:05, Kamil Rytarowski a écrit :
>
> Module Name:src
> Committed By: kamil
> Date: Sat Jul 7 23:05:50 UTC 2018
>
> Modified Files:
>
2018-06-20 18:03 GMT+02:00 Maxime Villard :
> I haven't tested but looking at the code it seems to me that this part of
> your
> change breaks DAZ on native, and I don't see how it can help xsave on xen by
> the way
Thanks, I'll change the conditional to avoid any potential change of
behaviour for
The function is ever called only with x86_fpu_save >= FPU_SAVE_FXSAVE,
so there should be no change in functionality AFAICS.
2018-06-20 10:34 GMT+02:00 Maxime Villard :
> Le 19/06/2018 à 21:50, Jaromir Dolecek a écrit :
>>
>> Module Name:src
>> Committed By: jdolecek
>> Date: Tue J
2018-05-22 12:18 GMT+02:00 Martin Husemann :
> Here are timing results:
While 37% speedup is nice, I see there isn't nearly as huge difference
as for my machine. Could you please try with some file which fits
whole in the page cache?
> Unfortunatley with ubc_direct enabled, it panics quickly:
Th
The very basic test is to do some moral equivalent of "dd if=foo
of=/dev/null bs=64k" with some reasonably sized foo file, with default
setting twice (once to test reading off the disk, second off cache),
then set ubc_direct to 1 via DDB, remount the filesystem and re-run.
Also would be good to che
+1 to removal
2018-02-26 18:51 GMT+01:00 :
>
> Any chance we can remove this from libc before releasing 8.0?
> it has one user, and the implementation is very specific for a certain
> use-case.
>
> having a DIY one use case function in libc is actually harming the
> ability to upstream this, aside
Can we have acpi_intr_establish() accept the xname? It's very useful to
have the driver name registered for "intrctl list".
Jaromir
2017-12-10 17:51 GMT+01:00 Manuel Bouyer :
> Module Name:src
> Committed By: bouyer
> Date: Sun Dec 10 16:51:30 UTC 2017
>
> Modified Files:
>
I'd ask you to revert this nonsense.
Jaromir
2017-11-18 21:48 GMT+01:00 Maya Rashish :
> Module Name:src
> Committed By: maya
> Date: Sat Nov 18 20:48:50 UTC 2017
>
> Modified Files:
> src/games/fortune/datfiles: fortunes fortunes2 fortunes2-o.real
>
> Log Message:
> Remo
2017-06-17 20:00 GMT+02:00 Jonathan A. Kollasch :
>
> I really think we need to make ata_xfer_init() private to
> ata_queue_alloc(), and use ata_get_xfer() everywhere. That we can
> fabricate an xfer on the stack anywhere that will trample all over an
> active command slot is fundamentally wrong.
You rock! Thank you.
2017-05-31 2:19 GMT+02:00 Maya Rashish :
> Module Name:src
> Committed By: maya
> Date: Wed May 31 00:19:17 UTC 2017
>
> Modified Files:
> src/sys/arch/x86/x86: cpu.c
>
> Log Message:
> Do not pause many times between testing if the CPU can go.
>
> Thi
2016-11-11 11:52 GMT+01:00 J. Hannken-Illjes :
> Why do we need a TAILQ here, the number of deletions after the first
> element is nearly zero and the list is quite short.
The element would be somewhere towards the end of the list, but likely
not the very last one. Yes, the list is usually short (
2016-11-07 12:11 GMT+01:00 J. Hannken-Illjes :
> It gets used when a block of block pointers has been deallocated and
> brelsed, that is NOT written to disk. If we allow the deallocation of
> this block to fail and ufs_truncate_retry() runs ffs_truncate again
> it will read the block from disk and
2016-11-07 10:25 GMT+01:00 J. Hannken-Illjes :
> The first part should not be necessary. After the loop we should have
> "i == last" -- from a quick look "i < last" is impossible.
Yes, I know - it's just to make the diff vs 1.117 smaller and hence
easier to review. I want to commit this separatel
> On Fri, Nov 04, 2016 at 04:44:10PM +0100, J. Hannken-Illjes wrote:
>> - This change results in "panic: ffs_blkfree_common: freeing free block"
>> if I put a file system under stress (*1).
>>
>> - I suppose not zeroing the blocks to be freed before freeing them
>> makes the life of fsck harder
I see Robert added hack meanwhile, I'll look at proper fix tomorrow.
Jaromir
2016-10-16 0:23 GMT+02:00 Joerg Sonnenberger :
> On Sat, Oct 15, 2016 at 04:46:15PM +, Jaromir Dolecek wrote:
>> Module Name: src
>> Committed By: jdolecek
>> Date: Sat Oct 15 16:46:14 UTC 2016
>>
>> Modifie
23 matches
Mail list logo
