Re: CVS commit: src/sys/dev/pci

Hi maxv, there is a similar code fragment in ic/bwfm.c:bwfm_scan_node. I am not sure what I'm looking at. Could it be wrong too? Thanks. On Tue, Jan 16, 2018 at 07:05:25AM +, Maxime Villard wrote: > Module Name: src > Committed By: maxv > Date: Tue Jan 16 07:05:25 UTC 2018 > >

Re: CVS commit: src/sys/dev/pci

On 2017/11/30 12:53, SAITOH Masanobu wrote: Module Name:src Committed By: msaitoh Date: Thu Nov 30 03:53:24 UTC 2017 Modified Files: src/sys/dev/pci: if_wm.c Log Message: Don't allocate MSI-X interrupt on 82583. 82583 chip has a MSI-X capability in the PCI

Re: CVS commit: src/sys/dev/pci/ixgbe

On 2017/11/23 0:15, SAITOH Masanobu wrote: Module Name:src Committed By: msaitoh Date: Wed Nov 22 15:15:09 UTC 2017 Modified Files: src/sys/dev/pci/ixgbe: if_bypass.c ixgbe.c ixgbe.h Log Message: Fix a bug that bypass adapter's sysctls aren't set. Tested with

Re: CVS commit: src/sys/dev/pci/ixgbe

On 2017/06/27 19:33, SAITOH Masanobu wrote: Module Name:src Committed By: msaitoh Date: Tue Jun 27 10:33:09 UTC 2017 Modified Files: src/sys/dev/pci/ixgbe: ixgbe.c Log Message: Fix a bug of ixg(4)'s media setting. Before: ifconfig ixg0 media 100baseTX -> advertise

Re: CVS commit: src/sys/dev/pci

> Date: Thu, 2 Feb 2017 03:57:21 + > From: co...@sdf.org > > On Thu, Feb 02, 2017 at 03:41:22AM +, Jonathan A. Kollasch wrote: > > @@ -432,6 +433,10 @@ wpi_detach(device_t self, int flags __un > > pci_intr_disestablish(sc->sc_pct, sc->sc_ih); > > sc->sc_ih = NULL;

Re: CVS commit: src/sys/dev/pci

On Thu, Feb 02, 2017 at 03:41:22AM +, Jonathan A. Kollasch wrote: > @@ -432,6 +433,10 @@ wpi_detach(device_t self, int flags __un > pci_intr_disestablish(sc->sc_pct, sc->sc_ih); > sc->sc_ih = NULL; > } > + if (sc->sc_pihp != NULL) { > +

Re: CVS commit: src/sys/dev/pci

In article <58524a1b.5060...@netbsd.org>, Nick Hudson wrote: >On 12/14/16 22:21, Christos Zoulas wrote: >> Module Name: src >> Committed By:christos >> Date:Wed Dec 14 22:21:13 UTC 2016 >> >> Modified Files: >> src/sys/dev/pci: if_sk.c >> >> Log

Re: CVS commit: src/sys/dev/pci

On 2016/11/28 11:23, SAITOH Masanobu wrote: Module Name:src Committed By: msaitoh Date: Mon Nov 28 02:23:33 UTC 2016 Modified Files: src/sys/dev/pci: files.pci src/sys/dev/pci/ixgbe: ixgbe.c ixgbe.h Added Files: src/sys/dev/pci/ixgbe: ix_txrx.c Log

Re: CVS commit: src/sys/dev/pci

On Sun, Nov 27, 2016 at 12:15:56AM +0900, Kimihiro Nonaka wrote: > Hi, > > 2016-11-26 17:29 GMT+09:00 : > > > This strangely causes fallpoint for sandpoint because: > > sandpoint/include/pci_machdep.h:38:#define __HAVE_PCI_MSI_MSIX > > Does it really? > > fixed > >

Re: CVS commit: src/sys/dev/pci

Hi, 2016-11-26 17:29 GMT+09:00 : > This strangely causes fallpoint for sandpoint because: > sandpoint/include/pci_machdep.h:38:#define __HAVE_PCI_MSI_MSIX > Does it really? fixed http://mail-index.netbsd.org/source-changes/2016/11/26/msg079370.html regards, -- Kimihiro

Re: CVS commit: src/sys/dev/pci

This strangely causes fallpoint for sandpoint because: sandpoint/include/pci_machdep.h:38:#define __HAVE_PCI_MSI_MSIX Does it really? Failure at http://releng.netbsd.org/builds/HEAD/201611252110Z/sandpoint.build.failed if_re_pci.o: In function `re_pci_detach': if_re_pci.c:(.text+0x70):

Re: CVS commit: src/sys/dev/pci

On Wed, 16 Nov 2016 22:05:19 + "Michael Lorenz" wrote: > Module Name: src > Committed By: macallan > Date: Wed Nov 16 22:05:19 UTC 2016 > > Modified Files: > src/sys/dev/pci: voyager.c > > Log Message: > add more plumbing to pass a clockframe around so

Re: CVS commit: src/sys/dev/pci

On Nov 2, 9:02am, p...@whooppee.com (Paul Goyette) wrote: -- Subject: Re: CVS commit: src/sys/dev/pci | Even in the non-overflow case, if you write x-1 chars (not including the | trailing NUL) to a buffer of size x, the updated value of len will be 1 | (and dest would point to the last valid

Re: CVS commit: src/sys/dev/pci

On Tue, 1 Nov 2016, Christos Zoulas wrote: On Nov 2, 8:49am, p...@whooppee.com (Paul Goyette) wrote: -- Subject: Re: CVS commit: src/sys/dev/pci | > Why *len = 1 here? Shouldn't it be 0 since there is no more room left? | | No. :) | | The maximum number of characters actually writ

Re: CVS commit: src/sys/dev/pci

On Nov 2, 8:49am, p...@whooppee.com (Paul Goyette) wrote: -- Subject: Re: CVS commit: src/sys/dev/pci | > Why *len = 1 here? Shouldn't it be 0 since there is no more room left? | | No. :) | | The maximum number of characters actually written by vsnprintf() will | never exceed (len - 1).

Re: CVS commit: src/sys/dev/pci

On Wed, 2 Nov 2016, Christos Zoulas wrote: In article <20161102003956.35d12f...@cvs.netbsd.org>, Paul Goyette wrote: -=-=-=-=-=- + /* Handle overflow */ + if ((size_t)count >= *len) { + *dest += *len - 1; + *len = 1; Why

Re: CVS commit: src/sys/dev/pci

In article <20161102003956.35d12f...@cvs.netbsd.org>, Paul Goyette wrote: >-=-=-=-=-=- > >+ /* Handle overflow */ >+ if ((size_t)count >= *len) { >+ *dest += *len - 1; >+ *len = 1; Why *len = 1 here? Shouldn't it be 0 since there

Re: CVS commit: src/sys/dev/pci

On Oct 30, 6:24pm, p...@whooppee.com (Paul Goyette) wrote: -- Subject: Re: CVS commit: src/sys/dev/pci | One more revision. This one updates the length parameter as well as the | dest pointer, so the caller doesn't need to recalculate on each call. | | I've also changed it to return an int

Re: CVS commit: src/sys/dev/pci

On Fri, 28 Oct 2016, Paul Goyette wrote: Attached is a revised patch, which has a prototype/signature much more similar to snprintf(), more appropriate variable types, and improved comments/documentation. I'll plan on committing this sometime late next week... One more revision. This one

Re: CVS commit: src/sys/dev/pci

On Oct 28, 1:18pm, p...@whooppee.com (Paul Goyette) wrote: -- Subject: Re: CVS commit: src/sys/dev/pci | snappendprintf() seemed a rather unwieldly function name, so I called it | snappendf()! :-) I read this like snapper at first. | The attached diffs implement this function and use

Re: CVS commit: src/sys/dev/pci

... or write a function that appends and moves the pointer, like snappendprintf(char **dest, const char *end, fmt, ...) snappendprintf() seemed a rather unwieldly function name, so I called it snappendf()! The attached diffs implement this function and use in throughout pci_devinfo().

Re: CVS commit: src/sys/dev/pci

... I think that perhaps a variant that returns the number of characters appended would be more useful. like if (len >= max) dest = end; else dest += len; but, I would leave the whole thing alone instead :-) or write a function that appends and moves the pointer, like

Re: CVS commit: src/sys/dev/pci

On Wed, 26 Oct 2016, Paul Goyette wrote: HOWEVER, Looking at dev_untokenstring() it would appear that there is a potential problem there! We have cp = buf + strlcat(buf, words + *token, len - 2); cp[0] = ' '; cp[1] = '\0'; Since strlcat(3)

Re: CVS commit: src/sys/dev/pci

On Wed, 26 Oct 2016, Christos Zoulas wrote: In article , Paul Goyette wrote: On Wed, 26 Oct 2016, matthew green wrote: i think you're right that the 'cp' manipulation is the problem. snprintf() will return the

Re: CVS commit: src/sys/dev/pci

Date: Wed, 26 Oct 2016 06:10:39 +0800 (PHT) From: Paul Goyette There's only 9 snprintf() calls. I could simply provide a macro: #define ADD_TEXT(dest, end, format, ...) \ {\

Re: CVS commit: src/sys/dev/pci

In article , Paul Goyette wrote: >On Wed, 26 Oct 2016, matthew green wrote: > >> i think you're right that the 'cp' manipulation is the problem. >> snprintf() will return the "desired" size, so upon the first >> attempted

re: CVS commit: src/sys/dev/pci

On Wed, 26 Oct 2016, matthew green wrote: i think you're right that the 'cp' manipulation is the problem. snprintf() will return the "desired" size, so upon the first attempted overflow the 'cp' is moved beyond 'ep', and then the next snprintf() gets a negative aka extremely massive value for

re: CVS commit: src/sys/dev/pci

On Wed, 26 Oct 2016, matthew green wrote: "Paul Goyette" writes: Module Name:src Committed By: pgoyette Date: Tue Oct 25 05:43:40 UTC 2016 Modified Files: src/sys/dev/pci: pci_verbose.h Log Message: Increase max string length for PCI Product names. Affects only

re: CVS commit: src/sys/dev/pci

> We currently have a few product names that exceed the old limit, and > this is triggering an SSP check in pci_devinfo(). This commit doesn't > directly address the SSP issue, but pushes the can down the road... i think you're right that the 'cp' manipulation is the problem. snprintf() will

re: CVS commit: src/sys/dev/pci

"Paul Goyette" writes: > Module Name: src > Committed By: pgoyette > Date: Tue Oct 25 05:43:40 UTC 2016 > > Modified Files: > src/sys/dev/pci: pci_verbose.h > > Log Message: > Increase max string length for PCI Product names. Affects only kernels > with PCIVERBOSE (or

Re: CVS commit: src/sys/dev/pci

On Sun, Jun 19, 2016 at 06:58:17AM +, David A. Holland wrote: > Modified Files: > src/sys/dev/pci: arcmsr.c > > Log Message: > Broaden the #if NBIO > 0 block. Should fix broken emips build. Erm: "evbppc" -- David A. Holland dholl...@netbsd.org

Re: CVS commit: src/sys/dev/pci

2015-11-07 7:11 GMT+09:00 matthew green : > "NONAKA Kimihiro" writes: >> Module Name: src >> Committed By: nonaka >> Date: Fri Nov 6 14:22:17 UTC 2015 >> >> Modified Files: >> src/sys/dev/pci: if_iwm.c if_iwmvar.h if_rtwn.c if_rtwnreg.h rtsx_pci.c >> >> Log

re: CVS commit: src/sys/dev/pci

"NONAKA Kimihiro" writes: > Module Name: src > Committed By: nonaka > Date: Fri Nov 6 14:22:17 UTC 2015 > > Modified Files: > src/sys/dev/pci: if_iwm.c if_iwmvar.h if_rtwn.c if_rtwnreg.h rtsx_pci.c > > Log Message: > Always use pci_intr_alloc(9)/pci_intr_release(9). doesn't this

Re: CVS commit: src/sys/dev/pci

Date: Sat, 07 Nov 2015 09:11:23 +1100 from: matthew green "NONAKA Kimihiro" writes: > Modified Files: >src/sys/dev/pci: if_iwm.c if_iwmvar.h if_rtwn.c if_rtwnreg.h rtsx_pci.c > > Log Message: > Always use pci_intr_alloc(9)/pci_intr_release(9).

Re: CVS commit: src/sys/dev/pci

On 25/08/15 06:54, matthew green wrote: Antti Kantee writes: Module Name:src Committed By: pooka Date: Mon Aug 24 23:52:18 UTC 2015 Modified Files: src/sys/dev/pci: if_iwn.c Log Message: Remove #ifdef INET code. Por que? Because opt_inet.h was not included and #ifdef

re: CVS commit: src/sys/dev/pci

Antti Kantee writes: Module Name: src Committed By: pooka Date: Mon Aug 24 23:52:18 UTC 2015 Modified Files: src/sys/dev/pci: if_iwn.c Log Message: Remove #ifdef INET code. Por que? Because opt_inet.h was not included and #ifdef INET was just a fancy way of saying

Re: CVS commit: src/sys/dev/pci

In article 557e89ae.8070...@execsw.org, Masanobu SAITOH msai...@execsw.org wrote: I thought it's not required to wait API was fixed and committed. I think is better to wait or ask before committing when there is doubt. To support only MSI is easy, but MSI-X is not. This commit includes not

Re: CVS commit: src/sys/dev/pci

On 2015/06/14 5:42, Christos Zoulas wrote: In article 20150613154758.6971...@cvs.netbsd.org, SAITOH Masanobu source-changes-d@NetBSD.org wrote: -=-=-=-=-=- Module Name: src Committed By:msaitoh Date:Sat Jun 13 15:47:58 UTC 2015 Modified Files:

Re: CVS commit: src/sys/dev/pci

In article 20150613154758.6971...@cvs.netbsd.org, SAITOH Masanobu source-changes-d@NetBSD.org wrote: -=-=-=-=-=- Module Name: src Committed By: msaitoh Date: Sat Jun 13 15:47:58 UTC 2015 Modified Files: src/sys/dev/pci: if_wm.c if_wmreg.h Log Message: Add MSI/MSI-X support

Re: CVS commit: src/sys/dev/pci

On 2015/05/01 1:09, SAITOH Masanobu wrote: Module Name:src Committed By: msaitoh Date: Thu Apr 30 16:09:06 UTC 2015 Modified Files: src/sys/dev/pci: if_bge.c if_bgereg.h Log Message: Use another firmware command in bge_asf_driver_up(). This change fixes a bug that

Re: CVS commit: src/sys/dev/pci

Ooops, I accidently didn't cc the list: - Forwarded message from Martin Husemann mar...@duskware.de - Date: Tue, 7 Apr 2015 22:30:23 +0200 From: Martin Husemann mar...@duskware.de To: Masanobu SAITOH msai...@execsw.org Subject: Re: CVS commit: src/sys/dev/pci In-Reply-To: 5523b0f9.6000

Re: CVS commit: src/sys/dev/pci

Hi, Martin. On 2015/04/06 16:38, Martin Husemann wrote: Module Name:src Committed By: martin Date: Mon Apr 6 07:38:17 UTC 2015 Modified Files: src/sys/dev/pci: if_bge.c Log Message: Make sure to halt (not just stop) the bge_tick callout during detach. To generate a

Re: CVS commit: src/sys/dev/pci

In article 20150223130937.ddec...@cvs.netbsd.org, NONAKA Kimihiro source-changes-d@NetBSD.org wrote: -=-=-=-=-=- Module Name: src Committed By: nonaka Date: Mon Feb 23 13:09:37 UTC 2015 Modified Files: src/sys/dev/pci: if_iwm.c Log Message: CID 1271021: Overrunning array

Re: CVS commit: src/sys/dev/pci

I have not seen it. At the moment, I don't think the problem happen. 2015-02-23 22:21 GMT+09:00 Christos Zoulas chris...@astron.com: In article 20150223130937.ddec...@cvs.netbsd.org, NONAKA Kimihiro source-changes-d@NetBSD.org wrote: -=-=-=-=-=- Module Name: src Committed By: nonaka Date:

Re: CVS commit: src/sys/dev/pci

On Feb 23, 11:13pm, nona...@gmail.com (NONAKA Kimihiro) wrote: -- Subject: Re: CVS commit: src/sys/dev/pci | I have not seen it. | At the moment, I don't think the problem happen. Please revert the fix then, or check the coverity website for the explanation why it thinks that the index can be 15

Re: CVS commit: src/sys/dev/pci

2015-02-24 0:25 GMT+09:00 Christos Zoulas chris...@zoulas.com: Please revert the fix then, or check the coverity website for the explanation why it thinks that the index can be 15. It does not seem possible from my cursory examination and we don't sandbag the code against impossible errors.

Re: CVS commit: src/sys/dev/pci

In article 20150217101125.1591...@cvs.netbsd.org, SAITOH Masanobu source-changes-d@NetBSD.org wrote: -=-=-=-=-=- Module Name: src Committed By: msaitoh Date: Tue Feb 17 10:11:25 UTC 2015 Modified Files: src/sys/dev/pci: if_bge.c Log Message: Print bit setting of bge_asf_mode

Re: CVS commit: src/sys/dev/pci

On Sep 27, 3:44pm, m...@m00nbsd.net (Maxime Villard) wrote: -- Subject: Re: CVS commit: src/sys/dev/pci | This fix is wrong. | | - memset(p, sizeof(struct twa_param_9k *), 10); | + memset(p, 0, sizeof(*p)); | | p is a [10] array, your memset only initializes the first pointer

Re: CVS commit: src/sys/dev/pci

Module Name:src Committed By: christos Date: Sun Sep 21 17:11:07 UTC 2014 Modified Files: src/sys/dev/pci: twa.c Log Message: fix memset size inconsistency This fix is wrong. - memset(p, sizeof(struct twa_param_9k *), 10); + memset(p, 0, sizeof(*p)); p

re: CVS commit: src/sys/dev/pci/hdaudio

Nathanial Sloss writes: Module Name: src Committed By: nat Date: Sun Sep 21 10:41:23 UTC 2014 Modified Files: src/sys/dev/pci/hdaudio: hdafg.c Log Message: Enable sysbeep(4) to be heard on speakers on Toughbook mk1 and mk5 computers. Also on computers with SigmaTel

Re: CVS commit: src/sys/dev/pci

On Tue, Jul 01, 2014 at 04:43:17PM -0500, Jonathan A. Kollasch wrote: On Tue, Jul 01, 2014 at 12:07:39AM +0200, Joerg Sonnenberger wrote: On Mon, Jun 30, 2014 at 09:33:40PM +, Jonathan A. Kollasch wrote: Module Name: src Committed By: jakllsch Date: Mon Jun 30

Re: CVS commit: src/sys/dev/pci

joerg@ wrote: Log Message: Apply OpenBSD src/sys/dev/pci/if_wpireg.h 1.17. Can we get a better commit message in the future? Our commit guideline also says Give proper credit. http://www.netbsd.org/developers/commit-guidelines.html --- Izumi Tsutsui

Re: CVS commit: src/sys/dev/pci

On Tue, Jul 01, 2014 at 10:16:38PM +0900, Izumi Tsutsui wrote: joerg@ wrote: Log Message: Apply OpenBSD src/sys/dev/pci/if_wpireg.h 1.17. Can we get a better commit message in the future? Our commit guideline also says Give proper credit.

Re: CVS commit: src/sys/dev/pci

joerg@ wrote: On Tue, Jul 01, 2014 at 10:16:38PM +0900, Izumi Tsutsui wrote: joerg@ wrote: Log Message: Apply OpenBSD src/sys/dev/pci/if_wpireg.h 1.17. Can we get a better commit message in the future? Our commit guideline also says Give proper credit.

Re: CVS commit: src/sys/dev/pci

On Tue, Jul 01, 2014 at 12:07:39AM +0200, Joerg Sonnenberger wrote: On Mon, Jun 30, 2014 at 09:33:40PM +, Jonathan A. Kollasch wrote: Module Name:src Committed By: jakllsch Date: Mon Jun 30 21:33:40 UTC 2014 Modified Files: src/sys/dev/pci:

Re: CVS commit: src/sys/dev/pci

On Mon, Jun 30, 2014 at 09:33:40PM +, Jonathan A. Kollasch wrote: Module Name: src Committed By: jakllsch Date: Mon Jun 30 21:33:40 UTC 2014 Modified Files: src/sys/dev/pci: if_wpireg.h Log Message: Apply OpenBSD src/sys/dev/pci/if_wpireg.h 1.17. Can we get a better

Re: CVS commit: src/sys/dev/pci

On Fri, Feb 28, 2014 at 09:14:03AM +0200, Alan Barrett wrote: On Thu, 27 Feb 2014, Joerg Sonnenberger wrote: Modified Files: src/sys/dev/pci: if_ti.c Log Message: Remove impossible checks. If new bugs are introduced in the future, then these tests might no longer be impossible. So

Re: CVS commit: src/sys/dev/pci

On Thu, 27 Feb 2014, Joerg Sonnenberger wrote: Modified Files: src/sys/dev/pci: if_ti.c Log Message: Remove impossible checks. If new bugs are introduced in the future, then these tests might no longer be impossible. So I'd prefer to change them to KASSERT or KDASSERT rather than

Re: CVS commit: src/sys/dev/pci

Module Name: src Committed By: jakllsch Date: Thu Jan 16 18:41:10 UTC 2014 Modified Files: src/sys/dev/pci: genfb_pci.c Log Message: Fix PR kern/46376 with Nat Sloss's patch (with slight modification). Serial console now works on x86 with genfb enabled. Didn't you read

Re: CVS commit: src/sys/dev/pci

On Jan 9, 2014, at 9:28 AM, SAITOH Masanobu msai...@netbsd.org wrote: Module Name: src Committed By: msaitoh Date: Thu Jan 9 17:28:05 UTC 2014 Modified Files: src/sys/dev/pci: pcidevs Log Message: Remove 88SE9128(0x913a) entry. At least one of 88SE9128 chip's product

Re: CVS commit: src/sys/dev/pci

On Wed, Oct 16, 2013 at 03:32:30PM -0400, Christos Zoulas wrote: Module Name: src Committed By: christos Date: Wed Oct 16 19:32:30 UTC 2013 Modified Files: src/sys/dev/pci: cs4281.c Log Message: use __USE() What is __USE()? Might be worth a brief manual page... - Jukka.

Re: CVS commit: src/sys/dev/pci

On Thu, Oct 17, 2013 at 09:22:02AM +0300, Jukka Ruohonen wrote: Log Message: use __USE() What is __USE()? Might be worth a brief manual page... It needs very explicit wording in misc/style. Martin

Re: CVS commit: src/sys/dev/pci

On Thu, Oct 17, 2013 at 08:26:33AM +0200, Martin Husemann wrote: On Thu, Oct 17, 2013 at 09:22:02AM +0300, Jukka Ruohonen wrote: Log Message: use __USE() What is __USE()? Might be worth a brief manual page... Sure, although I was thinking a brief note (with caveats) appended to the

Re: CVS commit: src/sys/dev/pci

On Oct 17, 9:22am, jruoho...@iki.fi (Jukka Ruohonen) wrote: -- Subject: Re: CVS commit: src/sys/dev/pci | On Wed, Oct 16, 2013 at 03:32:30PM -0400, Christos Zoulas wrote: | Module Name:src | Committed By: christos | Date: Wed Oct 16 19:32:30 UTC 2013

Re: CVS commit: src/sys/dev/pci

On Mon, Jul 22, 2013 at 02:52:02PM +, Soren S. Jorvang wrote: Module Name: src Committed By: soren Date: Mon Jul 22 14:52:02 UTC 2013 Modified Files: src/sys/dev/pci: puc.c Log Message: Oops. Not the best of commit messages! 'Fix compilation' would be better.

Re: CVS commit: src/sys/dev/pci

On Tue, Jul 23, 2013 at 08:21:34AM +0100, David Laight wrote: Not the best of commit messages! 'Fix compilation' would be better. Alas, it stil doesn't: ../../../../dev/pci/puc.c: In function 'puc_attach': ../../../../dev/pci/puc.c:269:76: error: invalid operands to binary - (have

Re: CVS commit: src/sys/dev/pci

This patch at least makes it compile - but I have no idea if I properly kept the semantics correct, and can't test it. Martin Index: puc.c === RCS file: /cvsroot/src/sys/dev/pci/puc.c,v retrieving revision 1.35 diff -u -p -r1.35

Re: CVS commit: src/sys/dev/pci

On 23/07/2013, at 09.28, Martin Husemann mar...@duskware.de wrote: This patch at least makes it compile - but I have no idea if I properly kept the semantics correct, and can't test it. It would probably work, at least on platforms with simple bus_space implementations, but taking a subregion

Re: CVS commit: src/sys/dev/pci

On Tue, Jul 23, 2013 at 09:43:30AM +0200, Soren Jorvang wrote: It would probably work, at least on platforms with simple bus_space implementations, but taking a subregion that is outside the original region seems iffy, so I have just marked it as an x86 hack for now. No, it is strictly

Re: CVS commit: src/sys/dev/pci

On 23/07/2013, at 09.54, Martin Husemann mar...@duskware.de wrote: What are you doing here, and why can't you do a full new bus_space_map here? I guess resource handling would not matter a lot for the is_console case. (I haven't looked at the changes in details) puc.c currently first maps the

Re: CVS commit: src/sys/dev/pci

On Tue, Jul 23, 2013 at 10:09:28AM +0200, Soren Jorvang wrote: The pre-autoconf console code creates a bus_space handle (not a subregion of anything) for the console com, which conflicts with puc.c later trying to allocate the larger handle that the console is a subregion (but not a

Re: CVS commit: src/sys/dev/pci

On 23/07/2013, at 11.04, Martin Husemann mar...@duskware.de wrote: On Tue, Jul 23, 2013 at 10:09:28AM +0200, Soren Jorvang wrote: The pre-autoconf console code creates a bus_space handle (not a subregion of anything) for the console com, which conflicts with puc.c later trying to allocate the

Re: CVS commit: src/sys/dev/pci

On Mon, Jul 22, 2013 at 02:40:03PM +, Martin Husemann wrote: Module Name: src Committed By: martin Date: Mon Jul 22 14:40:03 UTC 2013 Modified Files: src/sys/dev/pci: puc.c Log Message: Unbreak the build - soren, please review! To generate a diff of this commit:

Re: CVS commit: src/sys/dev/pci

Hello. (2013/07/04 1:35), Erik Fair wrote: It would be very helpful to document in bge(4) just which chips support jumbo frames (and how big). I agree with you. and I knew bge.4 is very obsolete. :-( Heck, it would be even more helpful if that was a capability that ifconfig(8)

Re: CVS commit: src/sys/dev/pci

It would be very helpful to document in bge(4) just which chips support jumbo frames (and how big). Heck, it would be even more helpful if that was a capability that ifconfig(8) could report because drivers declare it. Erik f...@netbsd.org On Jul 2, 2013, at 22:49 , SAITOH Masanobu

Re: CVS commit: src/sys/dev/pci

On Sun, 30 Dec 2012 09:45:05 + Michael Lorenz macal...@netbsd.org wrote: Module Name: src Committed By: macallan Date: Sun Dec 30 09:45:05 UTC 2012 Modified Files: src/sys/dev/pci: radeonfb.c radeonfbreg.h Log Message: Add support for R3xx. Whi EFATFINGERS, fixed

Re: CVS commit: src/sys/dev/pci

Modified Files: src/sys/dev/pci: if_wm.c Log Message: Use PRIxPADDR to print a DMA address. This fix a problem that if_wm.c can't compile with WM_DEBUG on non-64bit platforms. sizeof(paddr_t) != sizeof(bus_addr_t) at least on sparc, so using PRIx64 with an explicit (uint64_t) cast is

Re: CVS commit: src/sys/dev/pci

Hi, tsutsui. (2012/10/09 21:20), Izumi Tsutsui wrote: Modified Files: src/sys/dev/pci: if_wm.c Log Message: Use PRIxPADDR to print a DMA address. This fix a problem that if_wm.c can't compile with WM_DEBUG on non-64bit platforms. sizeof(paddr_t) != sizeof(bus_addr_t) at least on

re: CVS commit: src/sys/dev/pci

On Sat, Sep 01, 2012 at 02:08:28AM +, Matt Thomas wrote: Module Name:src Committed By: matt Date: Sat Sep 1 02:08:28 UTC 2012 Modified Files: src/sys/dev/pci: if_wm.c Log Message: Shut up gcc about some uninitialized variables. Hum,

Re: CVS commit: src/sys/dev/pci

On Sat, Sep 01, 2012 at 02:08:28AM +, Matt Thomas wrote: Module Name: src Committed By: matt Date: Sat Sep 1 02:08:28 UTC 2012 Modified Files: src/sys/dev/pci: if_wm.c Log Message: Shut up gcc about some uninitialized variables. Hum, gcc is wrong here, cmdlen and

Re: CVS commit: src/sys/dev/pci

Hi. (2012/08/30 7:06), Paul Goyette wrote: On Wed, 29 Aug 2012, Paul Goyette wrote: On Wed, 29 Aug 2012, Manuel Bouyer wrote: Module Name:src Committed By:bouyer Date:Wed Aug 29 20:39:24 UTC 2012 Modified Files: src/sys/dev/pci: if_wm.c if_wmreg.h Log Message: Make

Re: CVS commit: src/sys/dev/pci

On Thu, 30 Aug 2012, Masanobu SAITOH wrote: BTW, reason I am asking is that I had previously (about a year or so ago) needed to disable the offload functions on the 82574 because it wasn't working. This commit seems to imply that it fixes only the I350 so I was wondering if some other change

Re: CVS commit: src/sys/dev/pci

On Thu, Aug 30, 2012 at 04:54:19AM -0700, Paul Goyette wrote: On Thu, 30 Aug 2012, Masanobu SAITOH wrote: BTW, reason I am asking is that I had previously (about a year or so ago) needed to disable the offload functions on the 82574 because it wasn't working. This commit seems to imply that

Re: CVS commit: src/sys/dev/pci

On Wed, 29 Aug 2012, Paul Goyette wrote: On Wed, 29 Aug 2012, Manuel Bouyer wrote: Module Name:src Committed By: bouyer Date: Wed Aug 29 20:39:24 UTC 2012 Modified Files: src/sys/dev/pci: if_wm.c if_wmreg.h Log Message: Make vlan and all ip/ip6 checksum offload work

Re: CVS commit: src/sys/dev/pci

Ooops - I will fix the log message shortly. On Tue, 14 Feb 2012, Paul Goyette wrote: Module Name:src Committed By: pgoyette Date: Tue Feb 14 15:08:07 UTC 2012 Modified Files: src/sys/dev/pci: amdpm_smbus.c amdpmvar.h ichsmb.c nfsmb.c piixpm.c Log Message:

Re: CVS commit: src/sys/dev/pci

Am 14.02.12 16:08, schrieb Paul Goyette: Module Name: src Committed By: pgoyette Date: Tue Feb 14 15:08:07 UTC 2012 Modified Files: src/sys/dev/pci: amdpm_smbus.c amdpmvar.h ichsmb.c nfsmb.c piixpm.c Log Message: /home/paul/COMMIT could you please be a bit more verbose?

Re: CVS commit: src/sys/dev/pci

Log message has been updated in cvs: Replace the xxx_acquire()/xxx_release() rwlocks with mutexes. There are only RW_WRITERs for these, and no RW_READERs, so no need to incur the extra overhead of allowing for both. As discussed on tech-kern. For piixpm and ichsmb, the acquire/release

Re: CVS commit: src/sys/dev/pci

On Wed, Jan 04, 2012 at 07:56:36AM +, Michael Lorenz wrote: Module Name: src Committed By: macallan Date: Wed Jan 4 07:56:35 UTC 2012 Modified Files: src/sys/dev/pci: r128fb.c Log Message: split putchar into separate methods for bitmap and alpha fonts, use

Re: CVS commit: src/sys/dev/pci

On Thu, Dec 29, 2011 at 08:14:40PM +, Michael Lorenz wrote: Module Name: src Committed By: macallan Date: Thu Dec 29 20:14:40 UTC 2011 Modified Files: src/sys/dev/pci: radeonfb.c Log Message: rework putchar(): - get rid of engine stalls when using the blitter to draw

re: CVS commit: src/sys/dev/pci

On Mon, 12 Dec 2011, matthew green wrote: On Mon, Dec 12, 2011 at 03:54:57PM +1100, matthew green wrote: On Mon, Dec 12, 2011 at 02:44:15AM +, Jonathan A. Kollasch wrote: Module Name: src Committed By: jakllsch Date: Mon Dec 12 02:44:15 UTC 2011

re: CVS commit: src/sys/dev/pci

On Mon, 12 Dec 2011, matthew green wrote: On Mon, Dec 12, 2011 at 03:54:57PM +1100, matthew green wrote: On Mon, Dec 12, 2011 at 02:44:15AM +, Jonathan A. Kollasch wrote: Module Name: src Committed By: jakllsch Date: Mon Dec 12 02:44:15 UTC 2011

Re: CVS commit: src/sys/dev/pci

On Mon, Dec 12, 2011 at 02:44:15AM +, Jonathan A. Kollasch wrote: Module Name: src Committed By: jakllsch Date: Mon Dec 12 02:44:15 UTC 2011 Modified Files: src/sys/dev/pci: if_sip.c Log Message: Using BUS_DMA_NOCACHE for bus_dmamem_map() causes issues on (at least)

Re: CVS commit: src/sys/dev/pci

On Mon, Dec 12, 2011 at 03:54:57PM +1100, matthew green wrote: On Mon, Dec 12, 2011 at 02:44:15AM +, Jonathan A. Kollasch wrote: Module Name: src Committed By: jakllsch Date: Mon Dec 12 02:44:15 UTC 2011 Modified Files: src/sys/dev/pci: if_sip.c

re: CVS commit: src/sys/dev/pci

On Mon, Dec 12, 2011 at 03:54:57PM +1100, matthew green wrote: On Mon, Dec 12, 2011 at 02:44:15AM +, Jonathan A. Kollasch wrote: Module Name:src Committed By: jakllsch Date: Mon Dec 12 02:44:15 UTC 2011 Modified Files: src/sys/dev/pci:

Re: CVS commit: src/sys/dev/pci

Marc Balmer mbal...@netbsd.org wrote Module Name: src Committed By: mbalmer Date: Sat Oct 8 10:21:16 UTC 2011 Modified Files: src/sys/dev/pci: if_iwn.c Log Message: Make this compile again: Use the device_xname() macro to get the devic name. It should use

Re: CVS commit: src/sys/dev/pci

Am 08.10.11 12:44, schrieb Takeshi Nakayama: Marc Balmer mbal...@netbsd.org wrote Module Name: src Committed By:mbalmer Date:Sat Oct 8 10:21:16 UTC 2011 Modified Files: src/sys/dev/pci: if_iwn.c Log Message: Make this compile again: Use the device_xname()

Re: CVS commit: src/sys/dev/pci

On Oct 8, 2011, at 12:42 AM, Roland Dowdeswell wrote: Module Name: src Committed By: elric Date: Fri Oct 7 22:42:19 UTC 2011 Modified Files: src/sys/dev/pci: if_iwn.c This breaks building kernels: sys/dev/pci/if_iwn.c: In function 'iwn5000_runtime_calib':

Re: CVS commit: src/sys/dev/pci

I'm sorry, I've committed the changes for the MII PHY part. Please cvs update and retry. Thanks. (2011/05/20 14:28), Takahiro Kambe wrote: Hi, compile GENERIC/if_wm.o /usr/src/sys/dev/pci/if_wm.c: In function 'wm_set_mdio_slow_mode_hv': /usr/src/sys/dev/pci/if_wm.c:7436: error:

Re: CVS commit: src/sys/dev/pci

Thanks for your quick fix. Best regards. -- Takahiro Kambe t...@back-street.net

Re: CVS commit: src/sys/dev/pci

Hi, compile GENERIC/if_wm.o /usr/src/sys/dev/pci/if_wm.c: In function 'wm_set_mdio_slow_mode_hv': /usr/src/sys/dev/pci/if_wm.c:7436: error: 'HV_KMRN_MODE_CTRL' undeclared (first use in this function) /usr/src/sys/dev/pci/if_wm.c:7436: error: (Each undeclared identifier is reported only

<    1   2   3   >