Re: CVS commit: src/external/gpl3/gcc/dist/libsanitizer/sanitizer_common

2020-09-05 Thread Kamil Rytarowski
On 05.09.2020 15:35, matthew green wrote: > Module Name: src > Committed By: mrg > Date: Sat Sep 5 13:35:55 UTC 2020 > > Modified Files: > src/external/gpl3/gcc/dist/libsanitizer/sanitizer_common: > sanitizer_linux.cc sanitizer_linux.h sanitizer_linux_libcdep.cc >

Re: CVS commit: src/sys/arch/alpha/include

2020-09-03 Thread Jason Thorpe
> On Sep 3, 2020, at 1:14 PM, matthew green wrote: > > "Jason R Thorpe" writes: >> Module Name: src >> Committed By:thorpej >> Date:Thu Sep 3 04:20:54 UTC 2020 >> >> Modified Files: >> src/sys/arch/alpha/include: cpu.h >> >> Log Message: >> Garabage-collect

re: CVS commit: src/sys/arch/alpha/include

2020-09-03 Thread matthew green
"Jason R Thorpe" writes: > Module Name: src > Committed By: thorpej > Date: Thu Sep 3 04:20:54 UTC 2020 > > Modified Files: > src/sys/arch/alpha/include: cpu.h > > Log Message: > Garabage-collect curpcb / cpu_info::ci_curpcb. does alpha have modules? this may be a ABI change

Re: CVS commit: src/usr.sbin/puffs/mount_9p

2020-08-30 Thread Christos Zoulas
> On Aug 30, 2020, at 7:01 PM, Valery Ushakov wrote: > > On Sun, Aug 30, 2020 at 17:12:45 -0400, Christos Zoulas wrote: > >> Module Name: src >> Committed By:christos >> Date:Sun Aug 30 21:12:45 UTC 2020 >> >> Modified Files: >> src/usr.sbin/puffs/mount_9p:

Re: CVS commit: src/usr.sbin/puffs/mount_9p

2020-08-30 Thread Valery Ushakov
On Sun, Aug 30, 2020 at 17:12:45 -0400, Christos Zoulas wrote: > Module Name: src > Committed By: christos > Date: Sun Aug 30 21:12:45 UTC 2020 > > Modified Files: > src/usr.sbin/puffs/mount_9p: Makefile > > Log Message: > include bsd.init.mk to avoid: > make: Bad conditional

Re: CVS commit: src/bin/kill

2020-08-30 Thread Robert Elz
Date:Sun, 30 Aug 2020 16:10:40 + From:"Robert Elz" Message-ID: <20200830161040.57630f...@cvs.netbsd.org> | Log Message: | Use the POSIX specified format [...] Ugh ... that should have mentioned that this applies to the output of "kill -l" kre

Re: CVS commit: src/sys/dev/mii (PR/kern 55538)

2020-08-27 Thread Frank Kardel
Hi Martin ! That is strange - I didn't expect that, especially as the previous code was wrong with respect to state tracking. Can you check whether the addresses do not have the DEtACHED flag? You could try the dtrace script from the PR - it shows a little bit what is going on. There was also

Re: CVS commit: src/sys/dev/mii (PR/kern 55538)

2020-08-27 Thread Martin Husemann
On Mon, Aug 24, 2020 at 12:46:04PM +, Frank Kardel wrote: > Module Name: src > Committed By: kardel > Date: Mon Aug 24 12:46:04 UTC 2020 > > Modified Files: > src/sys/dev/mii: mii_physubr.c > > Log Message: > Keep the change check invariant intact. The previous code could miss

Re: CVS commit: src/usr.bin/sockstat

2020-08-26 Thread Simon Burge
"Christos Zoulas" wrote: > Module Name: src > Committed By: christos > Date: Wed Aug 26 22:57:56 UTC 2020 > > Modified Files: > > src/usr.bin/sockstat: Makefile sockstat.c > > Log Message: > > undo previous, now sockstat works without privs Nice, thanks Christos! Cheers, Simon.

Re: CVS commit: src/share/man/man4

2020-08-24 Thread Valery Ushakov
On Tue, Aug 25, 2020 at 10:03:28 +0900, Ryo ONODERA wrote: > Valery Ushakov writes: > > > On Mon, Aug 24, 2020 at 19:27:36 +, Ryo ONODERA wrote: > > > >> Module Name: src > >> Committed By: ryoon > >> Date: Mon Aug 24 19:27:36 UTC 2020 > >> > >> Modified Files: > >>

Re: CVS commit: src/share/man/man4

2020-08-24 Thread Ryo ONODERA
Hi, Valery Ushakov writes: > On Mon, Aug 24, 2020 at 19:27:36 +, Ryo ONODERA wrote: > >> Module Name: src >> Committed By:ryoon >> Date:Mon Aug 24 19:27:36 UTC 2020 >> >> Modified Files: >> src/share/man/man4: viomb.4 >> >> Log Message: >> Add a missing comma

Re: CVS commit: src/share/man/man4

2020-08-24 Thread Valery Ushakov
On Mon, Aug 24, 2020 at 19:27:36 +, Ryo ONODERA wrote: > Module Name: src > Committed By: ryoon > Date: Mon Aug 24 19:27:36 UTC 2020 > > Modified Files: > src/share/man/man4: viomb.4 > > Log Message: > Add a missing comma > > And bump date. I don't think minor edits like

re: CVS commit: src/sys/uvm/pmap

2020-08-23 Thread matthew green
> Modified Files: > src/sys/uvm/pmap: pmap_segtab.c > > Log Message: > Remove the #if defined(__mips_n64) && PAGE_SIZE == 8192 and make the > check MI - all PTs are PAGE_SIZE aligned thanks! that is a much better way of doing it. .mrg.

Re: CVS commit: src

2020-08-19 Thread nia
On Mon, Aug 17, 2020 at 12:47:40PM +0100, David Brownlee wrote: > On Sun, 16 Aug 2020 at 08:13, Martin Husemann wrote: > > > > Hi Nia, > > > > I think you are mixing a few issues here into one discussion - which might > > make sense from a user perspective, but does not help us to get forward. >

Re: CVS commit: src

2020-08-17 Thread maya
Why don't you fix your system instead of breaking other people's?

Re: CVS commit: src

2020-08-17 Thread David Brownlee
On Sun, 16 Aug 2020 at 08:13, Martin Husemann wrote: > > Hi Nia, > > I think you are mixing a few issues here into one discussion - which might > make sense from a user perspective, but does not help us to get forward. I think that the other issues provide important context. NetBSD's underlying

Re: CVS commit: src/sys/arch

2020-08-16 Thread Rin Okuyama
On 2020/08/11 10:24, matthew green wrote: XXX Apply similar fixes to other m68k ports. yes...but also, a long-term project to consolidate all the almost-identical m68k code copied into each port would avoid this probably :-) Agreed. Also, I've found many dead codes in amiga/locore.s. I'd

Re: CVS commit: src/external/gpl3/gcc/dist/gcc/config/m68k

2020-08-16 Thread Rin Okuyama
Sorry for the late reply. On 2020/08/11 1:16, Valery Ushakov wrote: This sounds eerily similar to port-macppc/54827 - there's quite a bit of confusion early on on my part there, but scroll to the last couple of mails. http://gnats.netbsd.org/54827 It looks like some logic changed in MI gcc8

Re: CVS commit: src/share/man/man8

2020-08-16 Thread Martin Husemann
On Sat, Aug 15, 2020 at 04:12:40PM +0200, Leonardo Taccari wrote: > Can this use cdn.NetBSD.org and made a bit more general instead of > hardcoding version/port please? Maybe create a distinct "manually install pkgin" landing page with enough magic/ links to guide the user to the "best" repo on

Re: CVS commit: src

2020-08-16 Thread Martin Husemann
Hi Nia, I think you are mixing a few issues here into one discussion - which might make sense from a user perspective, but does not help us to get forward. >From my POV the interacting-but-need-to-be-solved-individually issues are: - The libc or kernel<->userland API. This is what the core

Re: CVS commit: src

2020-08-15 Thread nia
On Sat, Aug 15, 2020 at 06:49:11PM +, Taylor R Campbell wrote: > - The behaviour is incompatible only in the sense that NetBSD's idea > of `adequate entropy' is stronger than FreeBSD's or Linux's, so > blocking is _more likely_ on NetBSD than on FreeBSD or Linux. In practice, the blocking

re: CVS commit: src/share/man/man8

2020-08-15 Thread matthew green
> Yeah. I was hesistant to do it this way because hw.machine_arch didn't > occur to me (uname gives the wrong thing for package sets on arm, etc) "uname -p"? .mrg.

Re: CVS commit: src

2020-08-15 Thread Taylor R Campbell
> Date: Sat, 15 Aug 2020 10:23:02 + > From: nia > > Obviously, I disagree with core's decision, but let's try to be > productive about this. > > I'm happy to have getrandom in NetBSD, it's a good thing. But not with > this behaviour. > > 1) Adopting getrandom for compatibility does not

Re: CVS commit: src/share/man/man8

2020-08-15 Thread Valery Ushakov
On Sat, Aug 15, 2020 at 16:12:40 +0200, Leonardo Taccari wrote: > > +.Ic export > > PKG_PATH=https://ftp.netbsd.org/pub/pkgsrc/packages/NetBSD/9.0/amd64/All > > +.Ic pkg_add pkgin > > [...] > > Can this use cdn.NetBSD.org and made a bit more general instead of > hardcoding version/port please?

Re: CVS commit: src/share/man/man8

2020-08-15 Thread nia
On Sat, Aug 15, 2020 at 04:12:40PM +0200, Leonardo Taccari wrote: > Hello Nia, > > Nia Alarie writes: > > [...] > > Log Message: > > afterboot.8: Explain how to install pkgin on a fresh system > > [...] > > +.Pp > > +To install pkgin, if it was not done by the installer: > > +.Bd -literal -offset

Re: CVS commit: src/share/man/man8

2020-08-15 Thread Leonardo Taccari
Hello Nia, Nia Alarie writes: > [...] > Log Message: > afterboot.8: Explain how to install pkgin on a fresh system > [...] > +.Pp > +To install pkgin, if it was not done by the installer: > +.Bd -literal -offset indent > +.Ic export >

Re: CVS commit: src

2020-08-15 Thread nia
On Fri, Aug 14, 2020 at 12:53:17AM +, Taylor R Campbell wrote: > New system call getrandom() compatible with Linux and others. > > [..] > > As proposed on tech-userlevel, tech-crypto, tech-security, and > tech-kern, and subsequently adopted by core (minus the getentropy part > of the proposal,

Re: CVS commit: src/sys

2020-08-14 Thread Chuck Silvers
On Sat, Aug 15, 2020 at 01:20:48AM +0900, Ryo ONODERA wrote: > Hi, > > "Chuck Silvers" writes: > > > Module Name:src > > Committed By: chs > > Date: Fri Aug 14 09:06:15 UTC 2020 > > > > Modified Files: > > src/sys/miscfs/genfs: genfs_io.c > > src/sys/uvm:

Re: CVS commit: src/sys

2020-08-14 Thread Ryo ONODERA
Hi, "Chuck Silvers" writes: > Module Name: src > Committed By: chs > Date: Fri Aug 14 09:06:15 UTC 2020 > > Modified Files: > src/sys/miscfs/genfs: genfs_io.c > src/sys/uvm: uvm_extern.h uvm_object.c uvm_object.h uvm_page.c > uvm_page_status.c uvm_pager.c

Re: CVS commit: src/sys

2020-08-11 Thread Robert Swindells
matthew green wrote: >however, i'm looking at the changes and i'm not 100% convinced >it's safe to simply replace this file as-is. > > - struct v4l2_pix_format is laid out differently > - enum v4l2_buf_type <-> u_int32_t does not seem safe, in > eg struct v4l2_buffer. i *think* it may be,

re: CVS commit: src/sys

2020-08-10 Thread matthew green
matthew green writes: > > also, these updates to video(4) don't require a kernel bump > > so please revert that too. > > but this part could be done if you do it fast.. uvideo(4) as a module proves me wrong about this one too.. however, i'm looking at the changes and i'm not 100% convinced it's

Re: CVS commit: src/sys

2020-08-10 Thread Robert Swindells
matthew green wrote: >"Robert Swindells" writes: >> Module Name: src >> Committed By:rjs >> Date:Mon Aug 10 19:27:28 UTC 2020 >> >> Modified Files: >> src/sys/dev: video.c >> src/sys/dev/usb: uvideo.c >> src/sys/sys: videoio.h >> >> Log Message: >> Add

re: CVS commit: src/sys

2020-08-10 Thread matthew green
> > Import sys/videoio.h from OpenBSD, this is just the Linux headers > > concatenated together. > > this seems very problematic in that you've added GPLv2 code > into src/sys/sys. > > please revert. ah- i see it has dual-license, please ignore me. thanks to nia@ for the hint.. > also, these

re: CVS commit: src/sys

2020-08-10 Thread matthew green
"Robert Swindells" writes: > Module Name: src > Committed By: rjs > Date: Mon Aug 10 19:27:28 UTC 2020 > > Modified Files: > src/sys/dev: video.c > src/sys/dev/usb: uvideo.c > src/sys/sys: videoio.h > > Log Message: > Add some extra V4L ioctl() requests to latest V4L

re: CVS commit: src/external/gpl3/gcc/dist/gcc/config/m68k

2020-08-10 Thread matthew green
> May be we should also check other ports for similar gotcha proactively? good idea. no other gcc/config/*/*netbsd* files define the nasty STACK_BOUNDARY macro so hopefully we're good now. thanks! .mrg.

re: CVS commit: src/sys/arch

2020-08-10 Thread matthew green
thanks! > XXX > Apply similar fixes to other m68k ports. yes...but also, a long-term project to consolidate all the almost-identical m68k code copied into each port would avoid this probably :-)

Re: CVS commit: src/external/gpl3/gcc/dist/gcc/config/m68k

2020-08-10 Thread Valery Ushakov
On Mon, Aug 10, 2020 at 06:24:39 +, Rin Okuyama wrote: > Modified Files: > src/external/gpl3/gcc/dist/gcc/config/m68k: netbsd-elf.h > > Log Message: > PR port-m68k/6 > > Reset STACK_BOUNDARY to default, 16, to fix strange freeze for amiga, > when kernel is compiled by GCC8. This

Re: CVS commit: src/common/lib/libc/string

2020-08-08 Thread David Holland
(yes, change is from January, I'm hugely behind) On Mon, Jan 27, 2020 at 10:22:03PM +, Andrew Doran wrote: > Modified Files: > src/common/lib/libc/string: bcmp.c memcmp.c > > Log Message: > Drop the alignment check if __NO_STRICT_ALIGNMENT (x86, m68k, vax). Even on machines that

Re: CVS commit: src/sys/arch/amiga/amiga

2020-08-08 Thread Rin Okuyama
Hi, Sorry for the serious delay in my response. On 2020/07/22 13:37, matthew green wrote: thanks for getting more m68k working! Thanks! "Rin Okuyama" writes: Module Name:src Committed By: rin Date: Tue Jul 21 06:39:31 UTC 2020 Modified Files:

Re: CVS commit: src/sys/dev/mii

2020-08-03 Thread Valery Ushakov
On Tue, Aug 04, 2020 at 07:12:54 +0300, Valery Ushakov wrote: > On Tue, Aug 04, 2020 at 12:50:11 +0900, SAITOH Masanobu wrote: > > > On 2020/08/03 23:00, Valeriy E. Ushakov wrote: > > > Module Name: src > > > Committed By: uwe > > > Date: Mon Aug 3 14:00:41 UTC 2020 > > >

Re: CVS commit: src/sys/dev/mii

2020-08-03 Thread SAITOH Masanobu
On 2020/08/04 12:50, SAITOH Masanobu wrote: Hi. On 2020/08/03 23:00, Valeriy E. Ushakov wrote: Module Name:    src Committed By:    uwe Date:    Mon Aug  3 14:00:41 UTC 2020 Modified Files: src/sys/dev/mii: miidevs_data.h Log Message: mii_knowndevs[] is de facto const, define it as

Re: CVS commit: src/sys/external/bsd/acpica/dist

2020-08-03 Thread Herbert J. Skuhra
On Mon, Aug 03, 2020 at 02:31:11PM -0700, Tom Spindler (moof) wrote: > On Mon, Aug 03, 2020 at 10:59:04PM +0200, Herbert J. Skuhra wrote: > > This breaks the build (amd64) on FreeBSD and GNU/Linux: > > > > aslcompilerlex.l: In function 'AslCompilerlex': > > aslcompilerlex.l:589:22: error:

Re: CVS commit: src/sys/dev/mii

2020-08-03 Thread Valery Ushakov
On Tue, Aug 04, 2020 at 12:50:11 +0900, SAITOH Masanobu wrote: > On 2020/08/03 23:00, Valeriy E. Ushakov wrote: > > Module Name:src > > Committed By: uwe > > Date: Mon Aug 3 14:00:41 UTC 2020 > > > > Modified Files: > > src/sys/dev/mii: miidevs_data.h > > > >

Re: CVS commit: src/sys/dev/mii

2020-08-03 Thread SAITOH Masanobu
Hi. On 2020/08/03 23:00, Valeriy E. Ushakov wrote: Module Name:src Committed By: uwe Date: Mon Aug 3 14:00:41 UTC 2020 Modified Files: src/sys/dev/mii: miidevs_data.h Log Message: mii_knowndevs[] is de facto const, define it as such. To generate a diff of this

Re: CVS commit: src/sys/external/bsd/acpica/dist

2020-08-03 Thread Tom Spindler (moof)
On Mon, Aug 03, 2020 at 10:59:04PM +0200, Herbert J. Skuhra wrote: > This breaks the build (amd64) on FreeBSD and GNU/Linux: > > aslcompilerlex.l: In function 'AslCompilerlex': > aslcompilerlex.l:589:22: error: 'PARSEOP_REGIONSPACE_PRM' undeclared (first > use in this function); did you mean

Re: CVS commit: src/sys/external/bsd/acpica/dist

2020-08-03 Thread Herbert J. Skuhra
On Sun, 02 Aug 2020 22:25:55 +0200, "Christos Zoulas" wrote: > > Module Name: src > Committed By: christos > Date: Sun Aug 2 20:25:55 UTC 2020 > > Modified Files: > src/sys/external/bsd/acpica/dist/compiler: aslcompiler.l aslerror.c > aslload.c aslxref.c >

Re: CVS commit: src/sys/kern

2020-08-02 Thread Kamil Rytarowski
On 02.08.2020 17:50, Taylor R Campbell wrote: >> Date: Sun, 2 Aug 2020 17:35:06 +0200 >> From: Kamil Rytarowski >> >> On 02.08.2020 16:44, Taylor R Campbell wrote: Date: Sun, 2 Aug 2020 16:04:15 +0200 From: Kamil Rytarowski On 02.08.2020 15:57, Taylor R Campbell wrote: >

Re: CVS commit: src/sys/kern

2020-08-02 Thread Taylor R Campbell
> Date: Sun, 2 Aug 2020 17:35:06 +0200 > From: Kamil Rytarowski > > On 02.08.2020 16:44, Taylor R Campbell wrote: > >> Date: Sun, 2 Aug 2020 16:04:15 +0200 > >> From: Kamil Rytarowski > >> > >> On 02.08.2020 15:57, Taylor R Campbell wrote: > >>> But it sounds like the original motivation is

Re: CVS commit: src/sys/kern

2020-08-02 Thread Kamil Rytarowski
On 02.08.2020 16:44, Taylor R Campbell wrote: >> Date: Sun, 2 Aug 2020 16:04:15 +0200 >> From: Kamil Rytarowski >> >> On 02.08.2020 15:57, Taylor R Campbell wrote: >>> But it sounds like the original motivation is that it triggered >>> -Wvla...which frankly strikes me as a compiler bug since

Re: CVS commit: src/sys/kern

2020-08-02 Thread Jaromír Doleček
Le dim. 2 août 2020 à 15:57, Taylor R Campbell a écrit : > Why does it improve readability? Certainly using cringe language features does not help readability. > What else does -Wvla choke on in src/sys? Some drm drivers, and uvm, particularly uvm_bio.c. I'd like to work towards enabling -Wvla

Re: CVS commit: src/sys/kern

2020-08-02 Thread Taylor R Campbell
> Date: Sun, 2 Aug 2020 16:04:15 +0200 > From: Kamil Rytarowski > > On 02.08.2020 15:57, Taylor R Campbell wrote: > > But it sounds like the original motivation is that it triggered > > -Wvla...which frankly strikes me as a compiler bug since there's > > obviously no actual VLA created in

Re: CVS commit: src/sys/kern

2020-08-02 Thread Joerg Sonnenberger
On Sun, Aug 02, 2020 at 01:57:11PM +, Taylor R Campbell wrote: > But it sounds like the original motivation is that it triggered > -Wvla...which frankly strikes me as a compiler bug since there's > obviously no actual VLA created in sizeof; as far as I can tell > there's no semantic difference

Re: CVS commit: src/sys/kern

2020-08-02 Thread Kamil Rytarowski
On 02.08.2020 16:25, Paul Goyette wrote: > On Sun, 2 Aug 2020, Kamil Rytarowski wrote: > >> On 02.08.2020 15:57, Taylor R Campbell wrote: >>> But it sounds like the original motivation is that it triggered >>> -Wvla...which frankly strikes me as a compiler bug since there's >>> obviously no

Re: CVS commit: src/sys/kern

2020-08-02 Thread Paul Goyette
On Sun, 2 Aug 2020, Kamil Rytarowski wrote: On 02.08.2020 15:57, Taylor R Campbell wrote: But it sounds like the original motivation is that it triggered -Wvla...which frankly strikes me as a compiler bug since there's obviously no actual VLA created in sizeof; as far as I can tell there's no

Re: CVS commit: src/sys/kern

2020-08-02 Thread Kamil Rytarowski
On 02.08.2020 15:57, Taylor R Campbell wrote: > But it sounds like the original motivation is that it triggered > -Wvla...which frankly strikes me as a compiler bug since there's > obviously no actual VLA created in sizeof; as far as I can tell > there's no semantic difference between

Re: CVS commit: src/sys/kern

2020-08-02 Thread Taylor R Campbell
> Date: Sun, 2 Aug 2020 10:47:21 +0200 > From: Jarom�r Dole ek > > Readability first and foremost in this case. > > I was exploring if I can disable VLAs for the kernel altogether, this > can't be done for now. Nevertheless, this change looked like it would > be useful to make anyway. Why does

Re: CVS commit: src/usr.bin/make

2020-08-02 Thread Roland Illig
On 02.08.2020 13:06, Simon Burge wrote: > "Roland Illig" wrote: > >> Module Name: src >> Committed By:rillig >> Date:Sun Aug 2 09:43:22 UTC 2020 >> >> Modified Files: >> >> src/usr.bin/make: var.c >> >> Log Message: >> >> make(1): use shorter local variable names >>

Re: CVS commit: src/usr.bin/make

2020-08-02 Thread Simon Burge
"Roland Illig" wrote: > Module Name: src > Committed By: rillig > Date: Sun Aug 2 09:43:22 UTC 2020 > > Modified Files: > > src/usr.bin/make: var.c > > Log Message: > > make(1): use shorter local variable names > > The c in cp was redundant since the context makes it obvious that

Re: CVS commit: src/usr.bin/make

2020-08-02 Thread Jared McNeill
On Sun, 2 Aug 2020, Roland Illig wrote: Module Name:src Committed By: rillig Date: Sun Aug 2 09:43:22 UTC 2020 Modified Files: src/usr.bin/make: var.c Log Message: make(1): use shorter local variable names The c in cp was redundant since the context makes it obvious

Re: CVS commit: src/sys/kern

2020-08-02 Thread Jaromír Doleček
Readability first and foremost in this case. I was exploring if I can disable VLAs for the kernel altogether, this can't be done for now. Nevertheless, this change looked like it would be useful to make anyway. Le dim. 2 août 2020 à 01:15, Taylor R Campbell a écrit : > > > Module Name:src >

Re: CVS commit: src/share/misc

2020-08-02 Thread Warner Losh
On Sat, Aug 1, 2020, 6:26 PM Luke Mewburn wrote: > On 20-08-01 23:07, Taylor R Campbell wrote: > | Index: share/misc/style > | === > | RCS file: /cvsroot/src/share/misc/style,v > | retrieving revision 1.56 > | diff -p -p

Re: CVS commit: src/sys/arch/x86

2020-08-01 Thread Taylor R Campbell
> Module Name:src > Committed By: jdolecek > Date: Sat Aug 1 12:36:36 UTC 2020 > > Modified Files: > src/sys/arch/x86/pci: pci_intr_machdep.c > src/sys/arch/x86/x86: mainbus.c > > Log Message: > reorder includes to pull __HAVE_PCI_MSI_MSIX properly via > If

Re: CVS commit: src/share/misc

2020-08-01 Thread Luke Mewburn
On 20-08-01 23:07, Taylor R Campbell wrote: | Index: share/misc/style | === | RCS file: /cvsroot/src/share/misc/style,v | retrieving revision 1.56 | diff -p -p -u -r1.56 style | --- share/misc/style1 Aug 2020

Re: CVS commit: src/share/misc

2020-08-01 Thread Luke Mewburn
On 20-08-01 23:07, Taylor R Campbell wrote: | > Module Name:src | > Committed By: lukem | > Date: Sat Aug 1 02:45:36 UTC 2020 | > | > Modified Files: | > src/share/misc: style | > | > Log Message: | > style: prefer braces for single statement control

Re: CVS commit: src/sys/kern

2020-08-01 Thread Taylor R Campbell
> Module Name:src > Committed By: jdolecek > Date: Sat Aug 1 11:18:26 UTC 2020 > > Modified Files: > src/sys/kern: subr_autoconf.c > > Log Message: > avoid VLA for the sizeof() calculations Why?

Re: CVS commit: src/share/misc

2020-08-01 Thread Taylor R Campbell
> Module Name:src > Committed By: lukem > Date: Sat Aug 1 02:45:36 UTC 2020 > > Modified Files: > src/share/misc: style > > Log Message: > style: prefer braces for single statement control statements > > Prefer to use { braces } around single statements after > control

re: CVS commit: src/sys/dev

2020-07-28 Thread matthew green
"Jaromir Dolecek" writes: > Module Name: src > Committed By: jdolecek > Date: Tue Jul 28 09:36:05 UTC 2020 > > Modified Files: > src/sys/dev/ic: nvmevar.h > src/sys/dev/pci: nvme_pci.c > > Log Message: > add a quirk to disable MSI, and enable it for Intel SSD DC P4500 > >

Re: CVS commit: src/sys/crypto/aes

2020-07-28 Thread Roy Marples
On 27/07/2020 21:44, Taylor R Campbell wrote: Module Name:src Committed By: riastradh Date: Mon Jul 27 20:44:30 UTC 2020 Modified Files: src/sys/crypto/aes: aes_ccm.c aes_ccm.h Log Message: Gather auth[16] and ctr[16] into one authctr[32]. Should appease clang. clang

Re: CVS commit: src/usr.bin/make

2020-07-26 Thread Christos Zoulas
In article <20200726200457.f2522f...@cvs.netbsd.org>, Roland Illig wrote: >-=-=-=-=-=- > >Module Name: src >Committed By: rillig >Date: Sun Jul 26 20:04:57 UTC 2020 > >Modified Files: > src/usr.bin/make: Makefile > >Log Message: >make(1): explicitly add dependencies on headers >

re: CVS commit: src/usr.bin/make

2020-07-26 Thread matthew green
> In a follow-up commit, I adjusted the build scripts, and I'm doing a > full build right now. I'm pretty confident that everything works now > again, and if not, I'll fix it immediately. thanks! .mrg.

Re: CVS commit: src/usr.bin/make

2020-07-26 Thread Roland Illig
On 26.07.2020 10:29, matthew green wrote: > "Roland Illig" writes: >> Module Name: src >> Committed By:rillig >> Date:Sun Jul 26 07:15:26 UTC 2020 >> >> Modified Files: >> src/usr.bin/make: Makefile >> Added Files: >> src/usr.bin/make: lst.c >> Removed Files: >>

re: CVS commit: src/usr.bin/make

2020-07-26 Thread matthew green
"Roland Illig" writes: > Module Name: src > Committed By: rillig > Date: Sun Jul 26 07:15:26 UTC 2020 > > Modified Files: > src/usr.bin/make: Makefile > Added Files: > src/usr.bin/make: lst.c > Removed Files: > src/usr.bin/make/lst.lib: Makefile lstAppend.c lstAtEnd.c

Re: CVS commit: src/external/mit/xorg/server/xorg-server/hw/sun

2020-07-23 Thread Izumi Tsutsui
> Module Name: src > Committed By: mrg > Date: Thu Jul 23 09:59:36 UTC 2020 > > Modified Files: > src/external/mit/xorg/server/xorg-server/hw/sun: Makefile.Xsun > > Log Message: > fix build: > - add .../xorg subdir to the path > - add dbe and present extensions, both wanted via

re: CVS commit: src/sys/arch/amiga/amiga

2020-07-21 Thread matthew green
thanks for getting more m68k working! "Rin Okuyama" writes: > Module Name: src > Committed By: rin > Date: Tue Jul 21 06:39:31 UTC 2020 > > Modified Files: > src/sys/arch/amiga/amiga: locore.s > > Log Message: > Align tmpstk to 4-byte boundary in the same manner as mac68k. > >

Re: CVS commit: src/usr.bin/make

2020-07-19 Thread Izumi Tsutsui
kardel@ wrote: > nbmake currently fails to build the tree. > > config.status: creating buildmake.sh > compile arch.c > compile buf.c > compile compat.c > compile cond.c > compile dir.c > compile for.c > compile hash.c > compile job.c > compile

Re: CVS commit: src/usr.bin/make

2020-07-19 Thread Frank Kardel
nbmake currently fails to build the tree. config.status: creating buildmake.sh compile arch.c compile buf.c compile compat.c compile cond.c compile dir.c compile for.c compile hash.c compile job.c compile main.c compile make.c compile

Re: CVS commit: src/sys/uvm

2020-07-18 Thread Rin Okuyama
On 2020/07/18 17:30, Jukka Ruohonen wrote: On Sat, Jul 18, 2020 at 05:19:07PM +0900, Rin Okuyama wrote: For most (all?) ports, these specifiers are exposed only for _KERNEL and friends. So, inttypes(*3*) would not be the best place for them. Currently, I'm not sure where they should be.

Re: CVS commit: src/sys/uvm

2020-07-18 Thread Jukka Ruohonen
On Sat, Jul 18, 2020 at 05:19:07PM +0900, Rin Okuyama wrote: > For most (all?) ports, these specifiers are exposed only for > _KERNEL and friends. So, inttypes(*3*) would not be the best > place for them. Currently, I'm not sure where they should be. > /usr/share/misc/style? Perhaps a new

Re: CVS commit: src/sys/uvm

2020-07-18 Thread Rin Okuyama
On 2020/07/16 16:02, matthew green wrote: thanks! i'll try to remember we have PRIxPADDR because i considered looking for it and thought we didn't have it... My pleasure! On 2020/07/16 16:10, Jukka Ruohonen wrote: The whole { PRIxPADDR, PRIxPSIZE, ..., PRIxREGISTER } family should probably

Re: [sctp fix] Re: CVS commit: src/sys/kern

2020-07-18 Thread Maxime Villard
Le 28/04/2020 à 09:16, Luke Mewburn a écrit : On 20-04-26 18:15, Maxime Villard wrote: | - There was no demonstrated use-case justifying importing it. In addition, |major OSes like Windows and macOS do not implement SCTP. There just is no |demand for SCTP on the market; and on

Re: CVS commit: src/sys/dev/pci

2020-07-17 Thread Jaromír Doleček
One of the things which need to be done is calling the if_ioctl always with the IFNET_LOCK() held. Right now it sometimes is, and other times it is not, so it's not possible to rely on it and KASSERT(). As for bnx(4) I did just some basic fixes around making it work with MSI(-X), since I don't

Re: CVS commit: src/sys/dev/pci

2020-07-17 Thread Jason Thorpe
> On Jul 17, 2020, at 3:50 PM, matthew green wrote: > > any chance you can look at NET_MPSAFE here etc? :) I have a bunch of local changes for this in one of my trees, and I hope to get back to it after netbsd-10 branches. -- thorpej

re: CVS commit: src/sys/dev/pci

2020-07-17 Thread matthew green
"Jaromir Dolecek" writes: > Module Name: src > Committed By: jdolecek > Date: Fri Jul 17 09:48:21 UTC 2020 > > Modified Files: > src/sys/dev/pci: if_bnx.c > > Log Message: > re-enable MSI/MSI-X, the TX timeouts were caused by the IFF_OACTIVE handling, > which was fixed in previous

Re: CVS commit: src/sys/uvm

2020-07-16 Thread Jukka Ruohonen
On Thu, Jul 16, 2020 at 05:02:18PM +1000, matthew green wrote: > thanks! i'll try to remember we have PRIxPADDR because i > considered looking for it and thought we didn't have it... The whole { PRIxPADDR, PRIxPSIZE, ..., PRIxREGISTER } family should probably be documented in inttypes(3)? -

re: CVS commit: src/sys/uvm

2020-07-16 Thread matthew green
"Rin Okuyama" writes: > Module Name: src > Committed By: rin > Date: Wed Jul 15 15:08:26 UTC 2020 > > Modified Files: > src/sys/uvm: uvm_physseg.c > > Log Message: > Fix typo. Use PRIxPADDR rather than casting. thanks! i'll try to remember we have PRIxPADDR because i considered

re: CVS commit: src/share/mk

2020-07-13 Thread matthew green
Joerg Sonnenberger writes: > On Mon, Jul 13, 2020 at 07:22:51AM +, matthew green wrote: > > Module Name:src > > Committed By: mrg > > Date: Mon Jul 13 07:22:51 UTC 2020 > > > > Modified Files: > > src/share/mk: bsd.README > > > > Log Message: > > MKLLVMRT is

Re: CVS commit: src/share/mk

2020-07-13 Thread Joerg Sonnenberger
On Mon, Jul 13, 2020 at 07:22:51AM +, matthew green wrote: > Module Name: src > Committed By: mrg > Date: Mon Jul 13 07:22:51 UTC 2020 > > Modified Files: > src/share/mk: bsd.README > > Log Message: > MKLLVMRT is automatically enabled on x86 and arm64, not mesa18+. It is

Re: CVS commit: src/libexec/httpd

2020-07-13 Thread Jukka Ruohonen
On Mon, Jul 13, 2020 at 07:15:45PM +1000, matthew green wrote: > i'm not sure i agree about 500 -> abusive behaviour. that's > when there's some _internal_ error and could just as easily > be caused by a human or code error on the server side. > > i don't know blocklist well enough to suggestion

re: CVS commit: src/libexec/httpd

2020-07-13 Thread matthew green
thanks for this. please cc me directly for bozohttpd changes, i have a couple review comments :-) > Committed By: jruoho > Date: Sat Jul 11 08:10:52 UTC 2020 > > Modified Files: > src/libexec/httpd: Makefile auth-bozo.c bozohttpd.8 bozohttpd.c > bozohttpd.h > > Log

re: [mii locking] Re: CVS commit: src/sys

2020-07-13 Thread matthew green
> Since this change if_udav.c doesn't work. Simply plugging a USB-to-ethernet > device triggers a page fault on mutex_enter in udav_attach. > > Quickly looking at the code: > > 240 usbnet_lock_core(un); > 241 usbnet_busy(un); > 242 > 243 ///* reset the adapter */ > 244 //

Re: CVS commit: src/sys/dev/i2c

2020-07-12 Thread Kimmo Suominen
Hi Michael, Perhaps your commit missed some changes? The code no longer compiles. Cheers, + Kimmo /p/netbsd/cvs/src/sys/dev/i2c/dbcool.c: In function 'dbcool_attach': /p/netbsd/cvs/src/sys/dev/i2c/dbcool.c:778:4: error: 'struct dbcool_softc' has no member named 'sc_prop' sc->sc_prop =

Re: CVS commit: src/sys/dev/scsipi

2020-07-11 Thread Kimmo Suominen
On Sun, Jul 12, 2020 at 12:05:37AM +0700, Robert Elz wrote: > Just to make things clear here, the LUN you're talking about is not > the scsi unit number (which is what I think Martin was referring to) > but a sub-device number within a single scsi ID. Right? Correct. I should have written "SCSI

Re: CVS commit: src/sys/dev/scsipi

2020-07-11 Thread Robert Elz
Date:Sat, 11 Jul 2020 18:24:51 +0300 From:Kimmo Suominen Message-ID: <20200711152451.ga1...@homeworld.netbsd.org> | On Sat, Jul 11, 2020 at 05:00:02PM +0200, Martin Husemann wrote: | > I don't understand the change. When was this broken? This has always worked

Re: CVS commit: src/sys/dev/scsipi

2020-07-11 Thread Martin Husemann
On Sat, Jul 11, 2020 at 06:24:51PM +0300, Kimmo Suominen wrote: > I think all real SCSI hardware I've had has always just only had LUN 0, > and each disk has been on its own SCSI ID (target). Yes, I confused ID and LUN here - just ignore me. Martin

Re: CVS commit: src/sys/dev/scsipi

2020-07-11 Thread Kimmo Suominen
On Sat, Jul 11, 2020 at 05:00:02PM +0200, Martin Husemann wrote: > I don't understand the change. When was this broken? This has always worked > for me e.g. with the sd0 at LUN 3 and the controller at 6 or 7. I think all real SCSI hardware I've had has always just only had LUN 0, and each disk

Re: CVS commit: src/sys/dev/scsipi

2020-07-11 Thread Martin Husemann
On Sat, Jul 11, 2020 at 05:57:46PM +0300, Kimmo Suominen wrote: > On Sat, Jul 11, 2020 at 05:47:34PM +0300, Jukka Ruohonen wrote: > > I'd reckon a pullup to NetBSD 9 would be in order? > > Yes, I was just waiting to be able to link to mail-index. I had > already checked that the patch applies

Re: CVS commit: src/sys/dev/scsipi

2020-07-11 Thread Kimmo Suominen
On Sat, Jul 11, 2020 at 05:47:34PM +0300, Jukka Ruohonen wrote: > I'd reckon a pullup to NetBSD 9 would be in order? Yes, I was just waiting to be able to link to mail-index. I had already checked that the patch applies cleanly to both netbsd-9 and netbsd-8.

Re: CVS commit: src/sys/dev/scsipi

2020-07-11 Thread Jukka Ruohonen
On Sat, Jul 11, 2020 at 02:31:46PM +, Kimmo Suominen wrote: > Use case 2: A Linode boot profile with multiple disks results in > the first disk ("sda") on LUN 1, while the second disk ("sdb") is > on LUN 0, each on their own bus. As Linode is quite popular, and supposedly uses a rather

[mii locking] Re: CVS commit: src/sys

2020-07-09 Thread Maxime Villard
Module Name:src Committed By: thorpej Date: Sun Mar 15 23:04:51 UTC 2020 Modified Files: src/sys/arch/arm/amlogic: gxlphy.c src/sys/arch/x86/pci: if_vmx.c src/sys/dev/mii: acphy.c amhphy.c atphy.c bmtphy.c brgphy.c ciphy.c dmphy.c etphy.c

Re: CVS commit: src/sys/conf

2020-07-08 Thread Simon Burge
"Valeriy E. Ushakov" wrote: > Module Name: src > Committed By: uwe > Date: Wed Jul 8 19:39:22 UTC 2020 > > Modified Files: > > src/sys/conf: assym.mk > > Log Message: > > Drop -fstack-usage* from CFLAGS passed genassym. > We don't want it to create a "-.su" file. Thanks! Cheers,

<    8   9   10   11   12   13   14   15   16   17   >