Re: CVS commit: src/usr.sbin/powerd

2010-01-30 Thread David Holland
On Thu, Jan 28, 2010 at 09:19:42AM +0100, Martin Husemann wrote: > On Thu, Jan 28, 2010 at 04:43:25AM +, David Holland wrote: > > If some people do care, changing the perception might prompt someone > > to do something about it. Maybe. It's probably a good chunk of work > > and there's not

Re: CVS commit: src/usr.sbin/powerd

2010-01-28 Thread Jason Thorpe
On Jan 28, 2010, at 12:19 AM, Martin Husemann wrote: > - it is unclear how scripts could make use of the fact which subsystem > triggered the pmf event they are dealing with When I wrote that code, I did hot have a concrete example usage scenario for power-type-specific scripts, but since the

Re: CVS commit: src/usr.sbin/powerd

2010-01-28 Thread Martin Husemann
On Thu, Jan 28, 2010 at 04:43:25AM +, David Holland wrote: > If some people do care, changing the perception might prompt someone > to do something about it. Maybe. It's probably a good chunk of work > and there's not much bang for the buck. I tried, but it's not obvious [PR 37434, if anyone c

Re: CVS commit: src/usr.sbin/powerd

2010-01-27 Thread David Holland
On Tue, Jan 26, 2010 at 11:56:30PM +0100, Martin Husemann wrote: > > However, the "power_type" from POWER_IOC_GET_TYPE can currently only be > > "acpi" and "landisk" (...). No "apm" is being set anywhere in the tree via > > sysmon_power_settype(). > > I've been told APM is dead and won't be f

CVS commit: src/usr.sbin/powerd

2010-01-26 Thread Thomas Klausner
Module Name:src Committed By: wiz Date: Wed Jan 27 06:52:24 UTC 2010 Modified Files: src/usr.sbin/powerd: powerd.8 Log Message: Bump date for previous. To generate a diff of this commit: cvs rdiff -u -r1.21 -r1.22 src/usr.sbin/powerd/powerd.8 Please note that diffs are

Re: CVS commit: src/usr.sbin/powerd

2010-01-26 Thread Paul Goyette
On Tue, 26 Jan 2010, Jason Thorpe wrote: if (ioctl(fd, POWER_IOC_GET_TYPE, &power_type) == -1) { syslog(LOG_ERR, "POWER_IOC_GET_TYPE: %m"); exit(EX_OSERR); } (void)asprintf(&cp, "%s/%s", _PATH_POWERD_SCRIPTS, power_type.power_type);

Re: CVS commit: src/usr.sbin/powerd

2010-01-26 Thread Jukka Ruohonen
On Tue, Jan 26, 2010 at 02:38:45PM -0800, Jason Thorpe wrote: > This is incorrect. apm vs. acpi vs. whatever else.. the code still has > support for them. Please put this back. Just because apm-specific and > acpi-specific scripts do not yet exist doesn't mean that the code does not > support th

Re: CVS commit: src/usr.sbin/powerd

2010-01-26 Thread Paul Goyette
On Wed, 27 Jan 2010, Jukka Ruohonen wrote: I can put it back. But as has been pointed out, does it need to be there to confuse users when neither (a) the directories exist in the default install nor (b) does support for this exist in the code? Support does exist - you just have to look a bit d

Re: CVS commit: src/usr.sbin/powerd

2010-01-26 Thread Martin Husemann
On Wed, Jan 27, 2010 at 12:54:15AM +0200, Jukka Ruohonen wrote: > However, the "power_type" from POWER_IOC_GET_TYPE can currently only be > "acpi" and "landisk" (...). No "apm" is being set anywhere in the tree via > sysmon_power_settype(). I've been told APM is dead and won't be fixed (it does no

Re: CVS commit: src/usr.sbin/powerd

2010-01-26 Thread Jukka Ruohonen
On Tue, Jan 26, 2010 at 02:41:52PM -0800, Jason Thorpe wrote: > if (ioctl(fd, POWER_IOC_GET_TYPE, &power_type) == -1) { > syslog(LOG_ERR, "POWER_IOC_GET_TYPE: %m"); > exit(EX_OSERR); > } > > (void)asprintf(&cp, "%s/%s", _PATH_POWERD_SCRIPTS,

Re: CVS commit: src/usr.sbin/powerd

2010-01-26 Thread Jukka Ruohonen
On Tue, Jan 26, 2010 at 02:38:45PM -0800, Jason Thorpe wrote: > > On Jan 26, 2010, at 12:37 PM, Jukka Ruohonen wrote: > > > * Apparently there is only a single location for the scripts. Thus, remove > > the references to "/etc/powerd/scripts/apm" and > > "/etc/powerd/scripts/acpi". > > This i

Re: CVS commit: src/usr.sbin/powerd

2010-01-26 Thread Jason Thorpe
On Jan 26, 2010, at 2:26 PM, Paul Goyette wrote: > The powerd(8) man page currently says > > The first location is /etc/powerd/scripts/, where >is defined by the power management mechanism > supported by the system, e.g., ``apm'' or ``acpi''. If the > script is not fou

Re: CVS commit: src/usr.sbin/powerd

2010-01-26 Thread Jason Thorpe
On Jan 26, 2010, at 12:37 PM, Jukka Ruohonen wrote: > * Apparently there is only a single location for the scripts. Thus, remove > the references to "/etc/powerd/scripts/apm" and "/etc/powerd/scripts/acpi". This is incorrect. apm vs. acpi vs. whatever else.. the code still has support for th

Re: CVS commit: src/usr.sbin/powerd

2010-01-26 Thread Paul Goyette
The powerd(8) man page currently says The first location is /etc/powerd/scripts/, where is defined by the power management mechanism supported by the system, e.g., ``apm'' or ``acpi''. If the script is not found in the first location, powerd looks in /etc

Re: CVS commit: src/usr.sbin/powerd

2010-01-26 Thread Jonathan A. Kollasch
On Tue, Jan 26, 2010 at 08:37:13PM +, Jukka Ruohonen wrote: > * Apparently there is only a single location for the scripts. Thus, remove >the references to "/etc/powerd/scripts/apm" and "/etc/powerd/scripts/acpi". When did this change? I remember fixing this in the acpi case recently.

CVS commit: src/usr.sbin/powerd

2010-01-26 Thread Jukka Ruohonen
Module Name:src Committed By: jruoho Date: Tue Jan 26 20:37:13 UTC 2010 Modified Files: src/usr.sbin/powerd: powerd.8 Log Message: Some miscellaneous fixes: * Apparently there is only a single location for the scripts. Thus, remove the references to "/etc/powerd/scrip

CVS commit: src/usr.sbin/powerd

2010-01-26 Thread Jukka Ruohonen
Module Name:src Committed By: jruoho Date: Tue Jan 26 14:28:23 UTC 2010 Modified Files: src/usr.sbin/powerd: powerd.8 Log Message: Emphasize the script names and events. To generate a diff of this commit: cvs rdiff -u -r1.19 -r1.20 src/usr.sbin/powerd/powerd.8 Please no