Re: [Spacewalk-devel] Re: Merge branch 'master' of ssh://jlsherr...@git.fedorahosted.org/git/spacewalk

On Thu, Mar 12, 2009 at 11:00:06PM -0400, Brandon Perkins wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > > > Jesus M. Rodriguez wrote: > > 2009/3/12 Michael Mraka : > >> Jan Pazdziora wrote: > >> % On Thu, Mar 12, 2009 at 07:27:19AM +0100, Jan Pazdziora wrote: > >> % > On Wed, Mar

Re: [Spacewalk-devel] Re: Merge branch 'master' of ssh://jlsherr...@git.fedorahosted.org/git/spacewalk

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jesus M. Rodriguez wrote: > 2009/3/12 Michael Mraka : >> Jan Pazdziora wrote: >> % On Thu, Mar 12, 2009 at 07:27:19AM +0100, Jan Pazdziora wrote: >> % > On Wed, Mar 11, 2009 at 08:09:49PM -0700, Mike McCune wrote: >> % > > >>

[Spacewalk-devel] 489775 - fixing listERrata api due to bad query

why is this a BAD query? I think this was done on purpose to return the issue_date as date. jesus Sent to you by jmrodri via Google Reader: 489775 - fixing listERrata api due to bad query via Fedora Hosted Git Repositories - spacewalk.git/rss log by Justin Sherrill on 3/12/09 489775 - fixing li

[Spacewalk-devel] 489792- fixing incorrect api return types

Instead of + List list = (List) listErrata(sessionKey, channelLabel, "", ""); + // + for (Map item : list) { + item.put("date", item.get("issue_date")); + } + return list; why not change the query to return date as the column name instead of issue_date OR change it to return both issue_date and

[Spacewalk-devel] Updated the comments on the spacewalk setup spec to include my change

If you update the spec file, you might as well just build the package. tito tag tito build --release Also, don't put None - msg, simply put the commit message if there's no bugzilla. The commit messages are formatted so that they can be easily used as a changelog entry. jesus Sent to you by jm

[Spacewalk-devel] Fixed a iprange issue where the iprange delete URLs weren't being correctly ...

Why do we have to pass in the /rhn/ to the url here where we don't on the others? jesus Sent to you by jmrodri via Google Reader: Fixed a iprange issue where the iprange delete URLs weren't being correctly rendered via Fedora Hosted Git Repositories - spacewalk.git/rss log by Partha Aji on 3/12

Re: [Spacewalk-devel] Re: Merge branch 'master' of ssh://jlsherr...@git.fedorahosted.org/git/spacewalk

2009/3/12 Michael Mraka : > Jan Pazdziora wrote: > % On Thu, Mar 12, 2009 at 07:27:19AM +0100, Jan Pazdziora wrote: > % > On Wed, Mar 11, 2009 at 08:09:49PM -0700, Mike McCune wrote: > % > > >

Re: [Spacewalk-devel] Code Review Tool

On Thu, Mar 12, 2009 at 3:31 PM, Jesus M. Rodriguez wrote: > 2009/3/12 Michael Mraka : >> Pradeep Kilambi wrote: >> I like the idea either. IMHO "post" commit review would be enough (we do it >> now when reading commit logs) so commits could be taken automaticaly from git >> and then "wait" for r

Re: [Spacewalk-devel] Code Review Tool

2009/3/12 Michael Mraka : > Pradeep Kilambi wrote: > % Miroslav Suchý wrote: > % >Seeing as Jesus likes reviewing commit... I'm just wondering - do we > % >want to setup some Code Review tools? Will we use it? Or gitk/tig and > % >sending mails to spacewalk-devel is sufficient? > % >If I see here m

Re: [Spacewalk-devel] Code Review Tool

Pradeep Kilambi wrote: % Miroslav Suchý wrote: % >Seeing as Jesus likes reviewing commit... I'm just wondering - do we % >want to setup some Code Review tools? Will we use it? Or gitk/tig and % >sending mails to spacewalk-devel is sufficient? % >If I see here majority of positive response I will

Re: [Spacewalk-devel] Code Review Tool

Miroslav Suchý wrote: Seeing as Jesus likes reviewing commit... I'm just wondering - do we want to setup some Code Review tools? Will we use it? Or gitk/tig and sending mails to spacewalk-devel is sufficient? If I see here majority of positive response I will be happy to set up some tool. Hmm p

Re: [Spacewalk-devel] F10 nightly repo

On Thu, Mar 12, 2009 at 2:31 AM, Jan Pazdziora wrote: > On Thu, Mar 12, 2009 at 12:00:41AM -0400, Jesus Rodriguez wrote: >> I tried to install the F10 nightly repo tonight on a fresh (and updated) >> F10 box. I got the following dependency errors: >> >> http://fpaste.org/paste/5924 >> >> the el5 n

Re: [Spacewalk-devel] 481180 - update KickstartFormatter to not include --interpetter in profile f...

Thanks for the tip. Will update today. jmrodri wrote: If isInterpreter() returns a string you could've used StringUtils.isEmpty(kss.getInterpreter()) to avoid having to do the null and empty checks as isEmpty does both for you. jesus Sent to you by jmrodri via Google Reader:

Re: [Spacewalk-devel] Re: Merge branch 'master' of ssh://jlsherr...@git.fedorahosted.org/git/spacewalk

Jan Pazdziora wrote: % On Thu, Mar 12, 2009 at 07:27:19AM +0100, Jan Pazdziora wrote: % > On Wed, Mar 11, 2009 at 08:09:49PM -0700, Mike McCune wrote: % > > % > > % > > 'git pull --rebase' ne

Re: [Spacewalk-devel] Re: Merge branch 'master' of ssh://jlsherr...@git.fedorahosted.org/git/spacewalk

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Thu, 12 Mar 2009 13:21:58 +0100 Jan Pazdziora wrote: > On Thu, Mar 12, 2009 at 09:17:34AM -0300, Devan Goodwin wrote: > > > > Would like too, only reason not too I can think of is if you'd done > > some package tagging and intentionally done a pu

Re: [Spacewalk-devel] Re: Merge branch 'master' of ssh://jlsherr...@git.fedorahosted.org/git/spacewalk

On Thu, Mar 12, 2009 at 09:17:34AM -0300, Devan Goodwin wrote: > > Would like too, only reason not too I can think of is if you'd done > some package tagging and intentionally done a pull without --rebase so > as not to have to redo it. In that case you probably should --amend the commit to say w

Re: [Spacewalk-devel] Re: Merge branch 'master' of ssh://jlsherr...@git.fedorahosted.org/git/spacewalk

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Thu, 12 Mar 2009 07:38:10 +0100 Jan Pazdziora wrote: > On Thu, Mar 12, 2009 at 07:27:19AM +0100, Jan Pazdziora wrote: > > On Wed, Mar 11, 2009 at 08:09:49PM -0700, Mike McCune wrote: > > >

[Spacewalk-devel] Code Review Tool

Seeing as Jesus likes reviewing commit... I'm just wondering - do we want to setup some Code Review tools? Will we use it? Or gitk/tig and sending mails to spacewalk-devel is sufficient? If I see here majority of positive response I will be happy to set up some tool. Hmm probably some time after

Re: [Spacewalk-devel] Status of Spacewalk @ Fedora

Michael Stahnke wrote: Me again. rhnpush is emailing us every night about issues in Fedora. Will Fedora be shipping a rhnlib package? rhnpush has broken dependencies in the development tree: On i386: rhnpush-0.4.5-1.fc11.noarch requires rhnlib Please resolve this as soon as possible. A