On Thu, Mar 12, 2009 at 3:31 PM, Jesus M. Rodriguez <[email protected]> wrote: > 2009/3/12 Michael Mraka <[email protected]>: >> Pradeep Kilambi wrote:
>> I like the idea either. IMHO "post" commit review would be enough (we do it >> now when reading commit logs) so commits could be taken automaticaly from git >> and then "wait" for review by another developer. > > I would be game for having a tool. I'd also be happy if others would simply > look > at the commit logs as mike & I do. I look at them for a few reasons: > > 1) understand what's going on > 2) looking for glaring errors and duplicate code > > While a tool might help us get better, if everyone spent sometime > reviewing the commit logs. > I don't think the process will work if it is up to a developer to ask > for reviews, having done that > in the past it never really worked for me. That being said, if the code review tool pulls commits automatically, and I can have the ability to flag a commit for review, that would be ok. I do not want any commit to 'wait' for review before being accepted into the repository (I don't think that was being said but making sure) jesus _______________________________________________ Spacewalk-devel mailing list [email protected] https://www.redhat.com/mailman/listinfo/spacewalk-devel
