2009/3/12 Michael Mraka <[email protected]>: > Pradeep Kilambi wrote: > % Miroslav Suchý wrote: > % >Seeing as Jesus likes reviewing commit... I'm just wondering - do we > % >want to setup some Code Review tools? Will we use it? Or gitk/tig and > % >sending mails to spacewalk-devel is sufficient? > % >If I see here majority of positive response I will be happy to set up > % >some tool. Hmm probably some time after space05 when things will slows > % >down. > % > % > % I like the idea, sounds nice. But how do we plan on using it? Unless > % people volunteer to post their commits to the tool and request for a > % review, I think we'll be in the same position again where zeus or mike > % or someone else looking at the commits feeds and suggesting changes. > % I think if we have a tool like such, it comes down to the discipline of > % individual developer to ask for a review. Honestly I dont see that > % happening very frequently :) > > I like the idea either. IMHO "post" commit review would be enough (we do it > now when reading commit logs) so commits could be taken automaticaly from git > and then "wait" for review by another developer.
I would be game for having a tool. I'd also be happy if others would simply look at the commit logs as mike & I do. I look at them for a few reasons: 1) understand what's going on 2) looking for glaring errors and duplicate code While a tool might help us get better, if everyone spent sometime reviewing the commit logs. I don't think the process will work if it is up to a developer to ask for reviews, having done that in the past it never really worked for me. jesus _______________________________________________ Spacewalk-devel mailing list [email protected] https://www.redhat.com/mailman/listinfo/spacewalk-devel
