Re: [Spacewalk-devel] [PATCH] avoid link-jars task when executing make-eclipse-project

2013-05-17 Thread Grant Gainey
Hi there Silvio, - Original Message - Hi, I noticed that the make-eclipse-project Ant task in build.xml depends on link-jars, which as far as I understand should not be needed. This could result in errors when a developer wants to produce the Eclipse project files even if he/she

[Spacewalk-devel] Adventures in Koji, or, Why Isn't That Build Released Yet, ggainey?!?

2013-05-21 Thread Grant Gainey
Hey folks, Applied the ISS chg to spacewalk-nightly/1.9/1.8, along with a fix to get pylint to hush up about JanP's fix. Nightly and 1.9 build in koji fine. 1.8, however, I can't get kicked off, with the error below. I have some family commitments tonight that I can't move, so I'm not going

Re: [Spacewalk-devel] [PATCH] UserFactoryTest: avoid failure if there are no users

2013-08-28 Thread Grant Gainey
- Original Message - Hello, We are currently in the process of overhauling our test infrastructure downstream, and among other things we are trying to run upstream Java unit tests in order to spot regressions. We noticed that some of the tests, for example

Re: [Spacewalk-devel] [PATCH] UserFactoryTest: avoid failure if there are no users

2013-09-06 Thread Grant Gainey
Hey Silvio, - Original Message - On 08/28/2013 07:42 PM, Grant Gainey wrote: Fixing the tests to be more explicit and less reliant on typical setups is, at least in my opinion, always a good thing. I am glad to hear that, as at the moment that's exactly what I am doing! I

Re: [Spacewalk-devel] [PATCH] ChannelTest: do not assume a proxy channel family exists

2013-09-06 Thread Grant Gainey
Hi Silvio, - Original Message - Hi, Here is another simple patch to avoid having a proxy channel family set up in order to run ChannelTest. Accepted as commit 4fe6deb81b5328af52a7180676a91ccab1dffee1 Thanks for your contribution! Grant Regards, -- Silvio Moioli SUSE LINUX

Re: [Spacewalk-devel] [PATCH] AdvDataSourceTest: do not rely on test execution order

2013-09-06 Thread Grant Gainey
Hi Silvio, - Original Message - Hi, I noticed that AdvDataSourceTest relies on method ordering, and this can sometimes break tests. In fact we noticed that method call ordering is different in our OpenJDK 7 configuration between the commandline Ant launcher and the Eclipse launcher,

Re: [Spacewalk-devel] [PATCH] UpdateErrataCacheCommand: log an error when orgId is incorrect

2013-09-09 Thread Grant Gainey
- Original Message - So, what is the motivation of this change? (The only scenario I can imagine is, that the errata cache event will be queued and its organization gets deleted before the background errata cache action gets executed.) Exactly so. Because of the way the tests run,

Re: [Spacewalk-devel] [PATCH] UserManagerTest: don't rely on hardcoded default time zone

2013-09-09 Thread Grant Gainey
- Original Message - UserManagerTest relied on a default America/New_York time zone, I removed the hardcoded string replacing it with UserFactory.getDefaultTimeZone(). See attached patch. commit 4cba00f46447a5808e20ddc299c88a4335c08d6d Thanks for contributing! Grant Regards,

Re: [Spacewalk-devel] [PATCH] ConfigureSatelliteCommandTest: do not rely on HashMap key ordering

2013-09-09 Thread Grant Gainey
- Original Message - I noticed that ConfigureSatelliteCommandTest makes an assertion that depends on a HashMap key ordering, it was changed it to a SortedMap to guarantee repeatability. See attached patch. commit 59aafcf1a04208e67ea6a664052087fe266de32b Thanks for contributing!

Re: [Spacewalk-devel] [PATCH] MonitoringManagerTest: missing super.setUp() call added

2013-09-09 Thread Grant Gainey
- Original Message - See attached patch. commit a549568dd1a0d12aad605c5610e8cb8a5015c886 Thanks for contributing! Grant Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany ___

Re: [Spacewalk-devel] [PATCH] VirtualizationEntitlementsManagerTest fixes

2013-09-09 Thread Grant Gainey
- Original Message - On 09/09/2013 08:29 AM, Silvio Moioli wrote: I attached two patches: Patches updated to apply cleanly after Grant's commits. I apologize for the double post. No problem - added as commit - 21199a55fda8ecd893947dbad90b5cbff6328585 Thanks for your

Re: [Spacewalk-devel] pltcl question

2013-09-11 Thread Grant Gainey
- Original Message - On 09/11/2013 02:28 PM, Jan Pazdziora wrote: Which for typical web application request handling is what you want, isn't it? The whole request processing is one transaction and releasing it gives you nice cleanup. It is, except for a very few cases of

Re: [Spacewalk-devel] [PATCH] Frontend monitoring tests: ensure a Monitoring Scout exists

2013-09-13 Thread Grant Gainey
- Original Message - Hi, In some frontend tests it is assumed that at least one Monitoring Scout exists, and those tests will fail if there is none. The proposed attached patch creates a test Monitoring Scout before any operation that requires one, thus eliminating this

Re: [Spacewalk-devel] [PATCH] DownloadActionTest: do not assume file to be downloaded exists

2013-09-13 Thread Grant Gainey
- Original Message - See attached patch. commit 24bbc79a3bdf7c73e6a6d27760177a1d78264fef Thanks for the contribution! G Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany ___

Re: [Spacewalk-devel] [PATCH] OrgHandlerTest: don't depend on a channel family with free entitlement slots

2013-09-13 Thread Grant Gainey
- Original Message - OrgHandlerTest apparently required an official Red Hat channel family with free slots: /** * Lookup an official Red Hat channel family with free slots. * Fail the test if none can be found. [...] private ChannelFamily lookupRedHatChannelFamily() { [...] }

Re: [Spacewalk-devel] [PATCH] VirtualGuestsActionTest: do not rely on query string parameter ordering

2013-09-13 Thread Grant Gainey
- Original Message - Hi, The attached patch relaxes an assertion condition not to require a certain query string parameter order, which was in fact not respected in our test environment. commit e101391876ab21505ec080b4af29f5feb5caeb6b Thanks for contributing! G Regards, --

Re: [Spacewalk-devel] [PATCH] RequestContext.buildPageLink: force parameter ordering

2013-09-13 Thread Grant Gainey
- Original Message - Hi, I noticed that buildPageLink() uses a HashMap to keep track of query string parameters. While this is perfectly okay from a web application point of view, it makes testing a little more difficult and in particular, RequestContextTest could break because it

Re: [Spacewalk-devel] [PATCH] TestUtils: use the same temporary filename for the same file

2013-09-13 Thread Grant Gainey
- Original Message - Hi, The attached patch fixes a previous contribution of mine to transparently get resources either from the filesystem or from a jar file. When accessing a file from a jar that files gets decompressed in a temporary location which name was generated at random

Re: [Spacewalk-devel] [PATCH] AuthFilterTest: mocked request object updated

2013-09-13 Thread Grant Gainey
- Original Message - AuthFilterTest was failing in our setup, apparently because the mocked request object was missing some methods that were added after the test itself was written. I added those methods and now it passes. See attached patch. commit

Re: [Spacewalk-devel] [PATCH] junit tests: some logging cleanups

2013-09-13 Thread Grant Gainey
- Original Message - Hi, As previously discussed the new logging feature requires calling LoggingFactory.clearLogId() at the beginning of each transaction, and there were some places in test code where that was missing. I confirm that the latest patches from Grant actually

Re: [Spacewalk-devel] [PATCH] junit tests: do not rely on Cobbler

2013-09-13 Thread Grant Gainey
- Original Message - Hi, We propose some patches to avoid the junit testsuite to depend on Cobbler. With those, we are able to run all the tests using only a database instance seeded with the latest schema version. Details: commit bf05d8e0c6811a6bfed7f6c49091a56cabf8513d - patch

Re: [Spacewalk-devel] [PATCH] SystemHandlerTest: do not rely on hardcoded sequence ids

2013-09-13 Thread Grant Gainey
- Original Message - SystemHandlerTest was failing in our environment and, AFAIU, it expects that the underlying database will always return 1 as the id of a persisted test object. This is normally not the case, as the value is taken from a sequence and there is no code to ensure it

Re: [Spacewalk-devel] [PATCH] KickstartScriptActionTest: missing parameters added

2013-09-13 Thread Grant Gainey
- Original Message - Apparently some form parameters were missing and the test failed, at least in our environment. See attached patch. commit 12233d90d130eb739d80fbd53eb7c9dfc6493af7 Thanks for your contribution! G Regards, -- Silvio Moioli SUSE LINUX Products GmbH

Re: [Spacewalk-devel] [PATCH] MethodsSetupActionTest: do not assume that method command exists

2013-09-13 Thread Grant Gainey
- Original Message - See attached patch. commit 365c1834aa451aba3fb039f93034828dd2063c78 Thanks for your contribution! G Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany ___

Re: [Spacewalk-devel] [PATCH] OrgSoftwareSubscriptionsActionTest: always create test channel families

2013-09-13 Thread Grant Gainey
- Original Message - In OrgSoftwareSubscriptionsActionTest, a test channel family is correctly set up for a test method but not in another. I simply moved common initialization code in setUp(). See attached patch. commit 6796a8be523752b212173c0ce4f14106a8d63f97 Thanks for your

Re: [Spacewalk-devel] [PATCH] Add support for uploaded files in mocked requests, fix CryptoKeyCreateActionTest

2013-09-13 Thread Grant Gainey
- Original Message - Hi, In our environment we noticed that CryptoKeyCreateActionTest was failing. AFAIU, failure was due to the fact that the mocked request did not have the uploaded file in it, that is, it was not a multipart request. In order to fix that I added some code to

Re: [Spacewalk-devel] [PATCH] VirtualGuestsActionTest: do not rely on translation messages

2013-09-13 Thread Grant Gainey
- Original Message - VirtualGuestsActionTest had some localized messages hardcoded in English, I removed them to actually look up their value from LocalizationService. See attached patch. commit ff4f40accefe349c122301b9b44572cfa479bff2 Thanks for your contribution! G

Re: [Spacewalk-devel] [PATCH] SystemEntitlementsSetupActionTest: do not assume Org has virtualization entitlement

2013-09-13 Thread Grant Gainey
- Original Message - SystemEntitlementsSetupActionTest was failing in our environment, as the tested Org missed a virtualization entitlement. The proposed attached patch fixes the problem. commit c9b4477aadb9eff33befc91d079e47b1a8bbefa2 Thanks for your contribution! G

Re: [Spacewalk-devel] [patch] bugzilla 1009657 - fixes spacewalk-hostname-rename issue when postgres and oracle are installed

2013-09-20 Thread Grant Gainey
- Original Message - If a user has both postgres and oracle installed on their satellite system and they try to run a spaceawlk-hostname-rename, that will fail with /var/lib/pgsql/data is missing. Use service postgresql initdb to initialize the cluster first. even with db_backend =

Re: [Spacewalk-devel] Patch proposal: try-wrapping XMLRPC serialization code

2013-10-02 Thread Grant Gainey
- Original Message - On 10/01/2013 10:58 PM, Grant Gainey wrote: I decided there *had to* be a better way to do this - and I found one! Great! More Eyes would be great. Actually, Taskomatic classes were left out (probably overlooked). I added them in commit c29e22

Re: [Spacewalk-devel] Merging the bootstrap-css branch

2013-11-05 Thread Grant Gainey
Hey Duncan! We've had a fair amount of discussion here, and a number of folk playing with the current state of the branch. - Original Message - Hi astronauts We would like to start discussing a merge of the bootstrap-css branch. As you may know, the name is very technology

Re: [Spacewalk-devel] Merging the bootstrap-css branch

2013-11-06 Thread Grant Gainey
- Original Message - On 05/11/13 23:07, Grant Gainey wrote: Honestly, if we could get the checkstyle fixes and a first pass at The PXT Problem, I think we'd be good to go. We need more eyes, to flush out the edge-case problems. Thoughts? Grant Great! * We will do

[Spacewalk-devel] Spacewalk, 2.3, and Translations

2015-03-11 Thread Grant Gainey
-- Grant Gainey Principal Software Engineer, Red Hat Satellite ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel

Re: [Spacewalk-devel] Release Prep for Spacewalk 2.3!

2015-03-24 Thread Grant Gainey
Geschäftsführer: Dr. Martin Fischer, Rolf Henrich -- Grant Gainey Principal Software Engineer, Red Hat Satellite ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel

Re: [Spacewalk-devel] Release Prep for Spacewalk 2.3!

2015-03-24 Thread Grant Gainey
to versions 2.2 and 2.3 of Spacewalk, would also be interesting to include the Fedora 21 on /etc/rhn/spacewalk-common-channels.ini Updated the BZ - changes are already in place and will be part of 2.3 Thanks for pointing out the BZ! Grant -- Grant Gainey Principal Software Engineer, Red Hat Satellite

[Spacewalk-devel] A note on the new home of translations

2015-03-26 Thread Grant Gainey
. Thanks!) -- Grant Gainey Principal Software Engineer, Red Hat Satellite ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel

[Spacewalk-devel] SPACEWALK-2.3 branch has been created

2015-03-27 Thread Grant Gainey
straightened out. G -- Grant Gainey Principal Software Engineer, Red Hat Satellite ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel

[Spacewalk-devel] SPACEWALK-2.3: RHEL5 spacewalk-client repository works now

2015-04-21 Thread Grant Gainey
inconvenience, and Happy Spacewalking! Grant -- Grant Gainey Principal Software Engineer, Red Hat Satellite ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel

Re: [Spacewalk-devel] SPACEWALK-2.3: spacewalk-repo-2.3.3 incorrect

2015-04-28 Thread Grant Gainey
us know so quickly! Grant -- Grant Gainey Principal Software Engineer, Red Hat Satellite ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel -- Grant Gainey Principal Software

[Spacewalk-devel] Spacewalk 2.3 has been released

2015-04-14 Thread Grant Gainey
of course also discuss issues you might find when installing or using Spacewalk, but please do not be surprised if we ask you to file a bug at ​ https://bugzilla.redhat.com/enter_bug.cgi?product=Spacewalk with more details or full logs. Thank you for using Spacewalk. -- Grant Gainey

[Spacewalk-devel] SPACEWALK-2.3: Problem with RHEL5 client repo

2015-04-17 Thread Grant Gainey
. To address this, we are going to create a new (RHEL5-compatible) signing-key and re-sign the RHEL5-client-repo only. That new key will then be used going forward for all of SPACEWALK-2.4. Apologies for any inconvenience, and thanks to Peter Bieringer for catching it so quickly. Grant -- Grant Gainey

[Spacewalk-devel] Spacewalk/wiki is going to need a new home

2016-09-09 Thread Grant Gainey
one, and for tracking down as many external/documentation links as we can. Thoughts, anyone? Grant -- Grant Gainey Principal Software Engineer, Red Hat Satellite ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman

[Spacewalk-devel] Spacewalk wiki has a new home!

2017-01-13 Thread Grant Gainey
- it's the reason the Trac pages were locked down last year) At any rate - take the new wiki out for a drive, let us know what you think. Have a good weekend, Grant [1] you can find the migration tool here: https://github.com/ggainey/tracwiki2githubwiki -- Grant Gainey Principal Software

Re: [Spacewalk-devel] "Tracing a page" link broken on Wiki

2018-02-19 Thread Grant Gainey
; > -- > Eric Herget | Senior Software Engineer > Red Hat Satellite > > > ___ > Spacewalk-devel mailing list > Spacewalk-devel@redhat.com > https://www.redhat.com/mailman/listinfo/spacewalk-devel > -- Grant Gainey Principal Software Engineer, Red Hat Satellite ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel

Re: [Spacewalk-devel] spacewalk.qa.redhat.com & spacewalk.stage.redhat.com - expiring soon

2018-09-10 Thread Grant Gainey
6(84) bytes of data. 64 bytes from origin-www-stage-redhat-com.vserver.stage.ext.phx2.redhat.com (10.24.205.15): icmp_seq=1 ttl=249 time=46.3 ms Looks like spacewalk.stage is a vhost on www.stage.redhat.com that can be removed. G -- Grant Gainey Principal Software Engineer, Red Hat Satellite _

Re: [Spacewalk-devel] spacewalk.qa.redhat.com & spacewalk.stage.redhat.com - expiring soon

2018-09-11 Thread Grant Gainey
for HTTPS attempts to connect to it to get far enough to get the 302 and end up in the right place. So, we will continue to need that cert to be up-to-date. Thanks for checking! G > > On Mon, Sep 10, 2018 at 7:00 PM, Vikas Kumar wrote: > >> Thanks for follow up here. >> >>