Re: [PATCH 1/3] spi/pl022: Add high priority message pump support

2012-02-02 Thread Grant Likely
On Thu, Feb 02, 2012 at 01:59:34PM +0100, Linus Walleij wrote: > From: Chris Blair > > This switches the PL022 worker to a kthread in order to get > hold of a mechanism to control the message pump priority. On > low-latency systems elevating the message kthread to realtime > priority give a real

Re: [PATCH] spi-topcliff-pch: rename pch_spi_pcidev to pch_spi_pcidev_driver

2012-02-02 Thread Grant Likely
On Thu, Feb 02, 2012 at 02:20:30PM +0100, Danny Kukawka wrote: > Rename static struct pci_driver pch_spi_pcidev to > pch_spi_pcidev_driver to get rid of warnings from modpost checks. > > Signed-off-by: Danny Kukawka Merged, thanks. g. > --- > drivers/spi/spi-topcliff-pch.c |6 +++--- > 1 f

Re: [PATCH] spi/nuc900: Remove unnecessary memset of struct nuc900_spi

2012-02-01 Thread Grant Likely
On Wed, Feb 01, 2012 at 01:33:42PM +0100, Tobias Klauser wrote: > The memory allocated using kzalloc by spi_alloc_master so it doesn't > need to be set to 0 again. > > Signed-off-by: Tobias Klauser Merged, thanks. g. > --- > drivers/spi/spi-nuc900.c |2 -- > 1 files changed, 0 insertions(

Re: [PATCH] spi/spi-altera: Allow to explicitely override bus number via dts

2012-02-01 Thread Grant Likely
On Tue, Jan 31, 2012 at 8:54 AM, Tobias Klauser wrote: > From: Frederic Lambert > > Until now we let the code in spi.c assign us the bus number if the platform > device didn't specify its id. This patch adds the possibility to explicitely > specify the bus number via device tree. > > Signed-off-b

Re: [PATCH] spi/spi-altera: Allow to explicitely override bus number via dts

2012-02-01 Thread Grant Likely
On Wed, Feb 1, 2012 at 8:52 AM, Frederic LAMBERT wrote: > 2012/2/1 Mark Brown > >> >> Well, something that walks all block devices on Linux is very >> straightforward...  It sounds like you just want logic along the lines >> of "find a block device and offer the option of overriding by providing

Re: [PATCH 9/9 v3] spi: add Broadcom BCM63xx SPI controller driver

2012-01-31 Thread Grant Likely
On Tue, Jan 31, 2012 at 2:20 PM, Florian Fainelli wrote: > On Tuesday 31 January 2012 21:19:22 Grant Likely wrote: >> > +static const struct dev_pm_ops bcm63xx_spi_pm_ops = { >> > +   .suspend        = bcm63xx_spi_suspend, >> > +   .resum

Re: [PATCH 9/9 v3] spi: add Broadcom BCM63xx SPI controller driver

2012-01-31 Thread Grant Likely
.c | 486 > + > 3 files changed, 493 insertions(+), 0 deletions(-) > create mode 100644 drivers/spi/spi-bcm63xx.c > Looks okay. There are a couple of problems that needs to be fixed below, but otherwise: Acked-by: Grant Likely Merge this

Re: [PATCH 1/3] of_spi: add generic binding support to specify ncs gpio in the slave

2012-01-30 Thread Grant Likely
On Mon, Jan 30, 2012 at 04:27:49PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote: > This will allow to use gpio for chip select with no modification in the > driver binding > > When use the ncs-gpio, the gpio number will be passed via the controller_data > and the number of chip select will autom

Re: [PATCH v2 RESEND] SPI: add CSR SiRFprimaII SPI controller driver

2012-01-30 Thread Grant Likely
On Wed, Dec 14, 2011 at 04:23:27PM +0800, Barry Song wrote: > From: Zhiwu Song > > CSR SiRFprimaII has two SPIs (SPI0 and SPI1). Features: > * Master and slave modes > * 8-/12-/16-/32-bit data unit > * 256 bytes receive data FIFO and 256 bytes transmit data FIFO > * Multi-unit frame > * Configura

Re: [PATCH 2/3] spi/atmel: add DT support

2012-01-30 Thread Grant Likely
On Mon, Jan 30, 2012 at 04:27:50PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote: > the atmel_spi use only gpio for chip select > > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD > Cc: devicetree-disc...@lists.ozlabs.org > Cc: spi-devel-general@lists.sourceforge.net > --- > .../devicetree/bind

Re: [PATCH 0/3] spi/s3c64xx diagnostic and PM updates

2012-01-30 Thread Grant Likely
On Sat, Jan 21, 2012 at 03:13:41PM +, Mark Brown wrote: > On Sat, Jan 21, 2012 at 07:27:23AM -0700, Grant Likely wrote: > > > Pushed out to git://git.secretlab.ca/git/linux-2.6.git spi/merge. > > I'll ask Linus to pull in a couple of days after it has hit >

Re: [PATCH] spi/pl022: Add high priority message pump support

2012-01-27 Thread Grant Likely
On Thu, Jan 26, 2012 at 7:48 AM, Linus Walleij wrote: > On Wed, Jan 25, 2012 at 3:02 PM, Mark Brown wrote: >> On Tue, Jan 24, 2012 at 10:14:32PM +0100, Linus Walleij wrote: > >>> This switches the PL022 worker to a kthread in order to get >>> hold of a mechanism to control the message pump priori

Re: [PATCH] intel_mid_ssp_spi: Moorestown and Medfield SPI for SSP devices

2012-01-26 Thread Grant Likely
On Thu, Jan 26, 2012 at 10:57 AM, Alan Cox wrote: > From: Mathieu SOULARD > > This driver is a fusion of various internal drivers into a single > driver for the SPI slave/master on the Intel Moorestown and Medfield > SSP devices. > > Signed-off-by: Mathieu SOULARD > [Queueing and runtime pm adde

Re: [PATCH] spi: Add spi-s3c64xx driver dependency on ARCH_EXYNOS4

2012-01-25 Thread Grant Likely
On Wed, Jan 25, 2012 at 05:20:59PM +0100, Sylwester Nawrocki wrote: > The spi-s3c64xx driver is also used on Exynos4 so update the dependency > to enable build on those platforms. > > Cc: Jaswinder Singh > Signed-off-by: Sylwester Nawrocki > Signed-off-by: Kyungmin Park Applied, thanks. > ---

Re: [PATCH v2] spi: QUP based bus driver for Qualcomm MSM chipsets

2012-01-23 Thread Grant Likely
On Wed, Dec 07, 2011 at 11:37:58PM +0100, Wolfram Sang wrote: > On Mon, Nov 14, 2011 at 02:58:27PM -0700, Harini Jayaraman wrote: > > This bus driver supports the QUP SPI hardware controller in the Qualcomm > > MSM SOCs. The Qualcomm Universal Peripheral Engine (QUP) is a general > > purpose data p

Re: [PATCH 0/3] spi/s3c64xx diagnostic and PM updates

2012-01-21 Thread Grant Likely
gt; > Mark Brown (3): >      spi/s3c64xx: Log error interrupts >      spi/s3c64xx: Convert to dev_pm_ops >      spi/s3c64xx: Implement runtime PM support > >  drivers/spi/spi-s3c64xx.c |  115 >  1 files changed, 104 insertions(+),

Re: [PATCH] RFC: spi/sa1100: rewrite the SA1100 SPI driver

2012-01-19 Thread Grant Likely
On Thu, Jan 19, 2012 at 10:49 AM, Linus Walleij wrote: > On Wed, Jan 18, 2012 at 1:30 PM, Russell King - ARM Linux > wrote: >> On Wed, Jan 18, 2012 at 01:13:29PM +0100, Linus Walleij wrote: > >>> We usually merge drivers for microwire, TI, Motorola ... etc into >>> drivers/spi as well. It's a goo

Re: [PATCH 2/3] mfd: mc13xxx-core: Move spi specific code into separate module.

2012-01-19 Thread Grant Likely
On Thu, Jan 19, 2012 at 09:08:43AM +0100, Uwe Kleine-König wrote: > Hello, > > On Thu, Jan 19, 2012 at 12:01:33PM +1100, Marc Reilly wrote: > > All spi specific code is moved into a new module. The mc13xxx > > struct moves to the include file by necessity. > > > > A new config choice selects the

[git pull] spi bug fix for v3.3

2012-01-13 Thread Grant Likely
tory at: git://git.secretlab.ca/git/linux-2.6 spi-for-linus Olof Johansson (1): spi/tegra: depend instead of select TEGRA_SYSTEM_DMA drivers/spi/Kconfig |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) -- Grant Likely, B.Sc., P.Eng. Secret Lab T

Re: Why does MOSI appear to be sending data on a read?

2012-01-11 Thread Grant Likely
On Wed, Jan 11, 2012 at 05:21:24PM +, Wayne Tams wrote: > Hi, > > Just wondering if this is normal behaviour. When I do a SPI read to my > slave device I get the data I want all seems fine. > > When I look at the SPI bus on a logic analyser, after I write to MOSI > to tell the device I am goi

[GIT PULL] spi changes for v3.3

2012-01-04 Thread Grant Likely
-0800) are available in the git repository at: git://git.secretlab.ca/git/linux-2.6 spi/merge Grant Likely (1): Merge branch 'spi/next' (early part) into spi/merge Laurent Pinchart (1): spi: Fix device unregistration when unregistering the bus master Shubhrajyoti D (3):

[GIT PULL] gpio changes for 3.3 (plus some random spi and dt stuff)

2012-01-04 Thread Grant Likely
hread spi/pl022: add support for pm_runtime autosuspend Grant Likely (7): gpiolib: output basic details and consolidate gpio device drivers gpio/microblaze: Eliminate duplication of of_get_named_gpio_flags() gpio/powerpc: Eliminate duplication of of_get_named_gpio_flags()

Re: [PATCH] spi: Add SuperH HSPI prototype driver

2012-01-04 Thread Grant Likely
On Tue, Dec 27, 2011 at 12:35:18AM -0800, Kuninori Morimoto wrote: > This patch adds SuperH HSPI driver. > It is still prototype driver, but has enough function at this point. > > Signed-off-by: Kuninori Morimoto Some brief comments below... > --- > +static int hspi_pop(struct hspi_priv *hspi,

Re: [PATCH] spi/tegra: depend instead of select TEGRA_SYSTEM_DMA

2012-01-02 Thread Grant Likely
On Thu, Dec 22, 2011 at 03:57:57PM -0800, Olof Johansson wrote: > It's unlikely that anyone ever wants to turn off SYSTEM_DMA, but just in > case, it makes more sense to have the driver depend on it than select it. > > Signed-off-by: Olof Johansson Applied, thanks g. > --- > drivers/spi/Kconf

Re: [PATCH v2] spi: Fix device unregistration when unregistering the bus master

2011-12-16 Thread Grant Likely
On Fri, Dec 16, 2011 at 9:52 AM, Laurent Pinchart wrote: > Hi Grant, > > On Wednesday 14 December 2011 00:45:20 Grant Likely wrote: >> On Mon, Dec 12, 2011 at 01:15:06AM +0100, Laurent Pinchart wrote: >> > Device are added as children of the bus mas

Re: [PATCH v2] spi: Fix device unregistration when unregistering the bus master

2011-12-14 Thread Grant Likely
On Mon, Dec 12, 2011 at 01:15:06AM +0100, Laurent Pinchart wrote: > Device are added as children of the bus master's parent device, but > spi_unregister_master() looks for devices to unregister in the bus > master's children. This results in the child devices not being > unregistered. > > Fix this

Re: [GIT PULL] PL022 patches for 3.3

2011-12-13 Thread Grant Likely
PuaV2GvjKPmv/PTemGlQOYEKH06v3T > zPEwKlg6CkQfOIjSnV2tlJmChQQ5QKDccs+a7AuZbJfN/0ag4JXMg5UvwAQmkTVJ > w/SlLFuYGwpssGhnCoUESjtSbKq3tzu1/Lq3uaewyGwFZDSuLTHJl8T2Xscs5r7j > l9sAvfy7bhAJU4whAmLVcwmyDJjE2st/yjrXycTv3XiNEZ+H8IpiOkEgWiWufmMx > CnnbqbzImlvQC+lClSx6xV0xb3GObqF2gvuP/oXuWNIip1pLih62oOFX5ysWdtBU > fn98

Re: [PATCH 2/5] I2C: Add helper macro for i2c_driver boilerplate

2011-11-16 Thread Grant Likely
register/unregister > the I2C driver. By using this macro it is possible to eliminate a few lines of > boilerplate code per I2C driver. > > Signed-off-by: Lars-Peter Clausen Acked-by: Grant Likely > --- >  include/linux/i2c.h |   13 + >  1 files changed, 13 insertio

Re: [PATCH 5/5] staging:iio: Use module_spi_driver to register SPI driver

2011-11-16 Thread Grant Likely
On Wed, Nov 16, 2011 at 2:13 AM, Lars-Peter Clausen wrote: > Use the newly introduced module_spi_driver macro for registering SPI drivers. > This allows us to remove a few lines of boilerplate code. > > Signed-off-by: Lars-Peter Clausen Acked-by: Grant Likely g. > --- >  d

Re: [PATCH 3/5] SPI: Add helper macro for spi_driver boilerplate

2011-11-16 Thread Grant Likely
register/unregister > the SPI driver. By using this macro it is possible to eliminate a few lines of > boilerplate code per SPI driver. > > Signed-off-by: Lars-Peter Clausen Acked-by: Grant Likely > --- >  include/linux/spi/spi.h |   11 +++ >  1 files changed, 11 insertio

Re: [PATCH 1/5] drivercore: Generalize module_platform_driver

2011-11-16 Thread Grant Likely
d it > should be used to generate bus specific macros for registering drivers like > the module_platform_driver macro. > > Signed-off-by: Lars-Peter Clausen Acked-by: Grant Likely > --- >  include/linux/init.h            |   21 + >  include/linux/pla

Re: [PATCH 0/5] Generalize module_platform_driver

2011-11-16 Thread Grant Likely
On Wed, Nov 16, 2011 at 9:37 AM, Greg KH wrote: > On Wed, Nov 16, 2011 at 05:36:18PM +0100, Jean Delvare wrote: >> On Wed, 16 Nov 2011 08:02:06 -0800, Greg KH wrote: >> > On Wed, Nov 16, 2011 at 10:13:34AM +0100, Lars-Peter Clausen wrote: >> > > Grant

Re: [PATCH 1/2] spi-topcliff-pch: Support new device LAPIS Semiconductor ML7831 IOH

2011-10-29 Thread Grant Likely
On Fri, Oct 28, 2011 at 09:35:21AM +0900, Tomoya MORINAGA wrote: > ML7831 is companion chip for Intel Atom E6xx series. > > Signed-off-by: Tomoya MORINAGA Applied both for 3.3, thanks. g. > --- > drivers/spi/Kconfig|6 +++--- > drivers/spi/spi-topcliff-pch.c |5 - > 2

Re: [PATCH 1/3] OMAP: SPI: Use a workqueue per omap2_mcspi controller

2011-10-29 Thread Grant Likely
On Fri, Oct 28, 2011 at 05:14:17PM +0530, Shubhrajyoti D wrote: > Currently all the spi controllers share the work queue. > This patch allocates a work queue per controller. > > Signed-off-by: Steve Wilkins > Signed-off-by: Shubhrajyoti D Applied for v3.3, thanks. g. > --- > drivers/spi/spi-

Re: i.MX: GPIO based SPI chip selects question

2011-10-29 Thread Grant Likely
On Fri, Oct 28, 2011 at 02:06:16PM +0100, Wayne Tams wrote: > Hi, > > Can I use GPIO pins on my i.mx53 for SPI chip select, I have found little > on the web that can help me, I am hoping that it is straight-forward enough > for me to implement it? Perhaps there is a macro that I can use in the > s

Re: [PATCH 2/3] OMAP: SPI: call pm_runtime_disable in error path and remove

2011-10-29 Thread Grant Likely
On Fri, Oct 28, 2011 at 05:14:18PM +0530, Shubhrajyoti D wrote: > omap mcspi probe() doesnt call pm_runtime disable functions > in case of failure. remove() doesnt call pm_runtime disable. This could > lead to warnings as below on subsequent insmod. > > ~# insmod spi-omap2-mcspi.ko > [ 255.38367

Re: [PATCH 3/3] OMAP: SPI: Correct the error path

2011-10-29 Thread Grant Likely
On Fri, Oct 28, 2011 at 05:14:19PM +0530, Shubhrajyoti D wrote: > Currently McSPI driver doesnt follow correct failure fallback steps > attempting to correct the same. > Also > - label names changed to give meaningful names. > - Setting the driver data to NULL in remove > > Signed-off-by: Hebbar

[git pull] spi driver changes

2011-10-28 Thread Grant Likely
-2.6 (2011-10-28 16:44:18 -0700) are available in the git repository at: git://git.secretlab.ca/git/linux-2.6 spi/next Grant Likely (2): Merge commit 'v3.1' into spi/next drivercore: Add helper macro for platform_driver boilerplate H Hartley Sweeten (1): spi: spi-d

Re: [PATCH] OMAP: SPI: Fix the trying to free nonexistent resource error

2011-10-24 Thread Grant Likely
On Mon, Oct 24, 2011 at 03:54:24PM +0530, Shubhrajyoti D wrote: > Currently there is a request_mem_region(r->start, .. > followed by r->start += pdata->regs_offset; > > And then in remove > >r = platform_get_resource(pdev, IORESOURCE_MEM, 0); >release_mem_region(r->start, resource_size(r)

Re: [PATCH 43/49] spi: irq: Remove IRQF_DISABLED

2011-10-24 Thread Grant Likely
(see commit [b738a50a: > genirq: Warn when handler enables interrupts]). > > So now this flag is a NOOP and can be removed. > > Signed-off-by: Yong Zhang > Acked-by: Grant Likely Applied, thanks. g. > --- > drivers/spi/spi-bfin5xx.c |2 +- > drivers/spi/s

Re: [PATCH] spi/pl022: Enable clock in probe an use runtime_idle

2011-10-24 Thread Grant Likely
dle function > has been implemented. > > Change-Id: I6cb86f2cad30ecaab16f512daf4674b039b18213 > Signed-off-by: Ulf Hansson > Reviewed-on: http://gerrit.lud.stericsson.com/gerrit/34447 Acked-by: Grant Likely Since it depends on Russell's tree, I'm okay with it going in th

Re: Help with freescale p1010 based espi implementation.

2011-10-19 Thread Grant Likely
On Wed, Oct 19, 2011 at 12:46:22AM -0500, Robin Holt wrote: > I am a newbie to SPI and Broadcom Robo switch parts, so any correction > to my direction early on is _VERY_ welcome. > > > The Freescale P1010 communications SOC includes an ESPI controller > which works with the spi-fsl-espi.c driver.

Re: SPI Slave Mode

2011-10-18 Thread Grant Likely
On Tue, Oct 18, 2011 at 6:10 AM, Ned Forrester wrote: > On 10/18/2011 06:13 AM, Holdsworth, Joel wrote: >> Hi All, >> >> My team are working on an embedded system where we need our application >> processor to be an SPI slave. The documentation that I have read is very >> clear that this is current

Re: [PATCH 11/16] spi: pl022: Enable module alias autogeneration for AMBA drivers

2011-10-05 Thread Grant Likely
On Wed, Oct 5, 2011 at 10:05 AM, Dave Martin wrote: > Signed-off-by: Dave Martin Acked-by: Grant Likely > --- >  drivers/spi/spi-pl022.c |    2 ++ >  1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c > in

[GIT PULL] spi driver bug fixes

2011-10-04 Thread Grant Likely
spi-topcliff-pch: Add recovery processing in case FIFO overrun error occurs spi-topcliff-pch: Fix overrun issue drivers/spi/spi-topcliff-pch.c | 93 1 files changed, 66 insertions(+), 27 deletions(-) -- Grant Likely, B.Sc., P.Eng. Secret Lab Te

Re: [PATCH 1/5 v2] spi-topcliff-pch: add tx-memory clear after complete transmitting

2011-10-04 Thread Grant Likely
On Tue, Sep 06, 2011 at 05:16:34PM +0900, Tomoya MORINAGA wrote: > Currently, in case of reading date from SPI flash, > command is sent twice. > The cause is that tx-memory clear processing is missing . > This patch adds the tx-momory clear processing. > > Signed-off-by: Tomoya MORINAGA > --- > v

Re: [PATCH 1/5] spi-topcliff-pch: add tx-memory clear after complete transmitting

2011-10-04 Thread Grant Likely
On Tue, Oct 04, 2011 at 06:15:26PM +0900, Tomoya MORINAGA wrote: > Hi Grant, > > 1 month has passed. You look very busy, right ? > We've been long waiting for your accept. > Could you review these patch series ? > > Thanks in advance. Just looked at it now. I'm picking it up and I'll send the p

Re: [PATCH] spi: Fix WARN when removing spi-fsl-spi module

2011-09-23 Thread Grant Likely
On Fri, Sep 23, 2011 at 11:49:36AM -0400, Jeff Harris wrote: > If CPM mode is not used, the fsl_dummy_rx variable is never allocated. When > the cleanup attempts to free it, the reference count is zero and a WARN is > generated. The same CPM mode check used in the initialize is applied to the > f

Re: [PATCH] spi: detect wrong transfer->len values

2011-09-23 Thread Grant Likely
On Fri, Sep 23, 2011 at 01:59:18PM +0200, Michael Thalmeier wrote: > From: Helmut Raiger > > > Signed-off-by: Michael Thalmeier > --- > drivers/spi/spi.c | 12 +++- > 1 files changed, 11 insertions(+), 1 deletions(-) > > diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c > index 4d1

Re: [PATCH] spi: Fix builderror in spi-pl022.c

2011-09-20 Thread Grant Likely
On Tue, Sep 20, 2011 at 10:45:41PM +0200, Linus Walleij wrote: > On Mon, Sep 5, 2011 at 2:45 PM, Linus Walleij > wrote: > > On Sun, Aug 28, 2011 at 9:26 PM, Peter Huewe wrote: > > > >> This patch fixes a build error, introduced by commit (67fc8b9f, "PM: add > >> runtime PM support to core Primec

Re: [PATCH] spi: spi-dw: fix all sparse warnings

2011-09-20 Thread Grant Likely
arse warnings in spi-dw-mid.c due to > the return value of ioremap_nocache being stored in a u32 * not a > void __iomem *. > > With these changes the spi-dw* files all build with no sparse warnings. > > Signed-off-by: H Hartley Sweeten > Cc: Grant Likely Looks good to me. Fen

Re: [PATCH V2 1/6] spi/spi-pl022: Resolve formatting issues

2011-09-20 Thread Grant Likely
On Wed, Aug 10, 2011 at 02:20:54PM +0530, Viresh Kumar wrote: > There were few formatting related issues in code. This patch fixes them. > Fixes include: > - Remove extra blank lines > - align code to 80 cols > - combine several lines to one line > - Replace multiple spaces with tabs > - Remove spa

Re: [PATCH V2 0/6] spi/spi-pl022 fixes

2011-09-20 Thread Grant Likely
On Tue, Sep 20, 2011 at 04:46:44PM +0530, Viresh Kumar wrote: > On 9/1/2011 4:26 PM, Linus Walleij wrote: > > I agree. Acked-by: Linus Walleij for > > all except 6/6, it's probably just as possible to keep the channel handle > > taken in the driver if we modify the affected DMA driver instead. > >

Re: [PATCH V3 1/5] i2c: Add irq_gpio field to struct i2c_client, i2c_board_info.

2011-09-19 Thread Grant Likely
On Fri, Sep 02, 2011 at 08:56:20AM +0200, Jean Delvare wrote: > Stephen, > > Can you please fix your e-mail client / system / whatever so that your > patch series are no longer sent duplicated? > > On Thu, 1 Sep 2011 16:04:27 -0600, Stephen Warren wrote: > > Some devices use a single pin as both

Re: [PATCH v2] spi/imx: Fix spi-imx when the hardware SPI chipselects are used

2011-09-15 Thread Grant Likely
On Thu, Sep 15, 2011 at 03:28:57PM -0300, Fabio Estevam wrote: > commit 22a85e4cd51 (spi/imx: add device tree probe support) broke spi-imx > usage > when the SPI chipselect is the one internal to the controller. > > On a mx31pdk board the following error is seen: > > Registering mxc_nand as whol

Re: [PATCH v3] spi/imx: Fix spi-imx when the hardware SPI chipselects are used

2011-09-15 Thread Grant Likely
On Thu, Sep 15, 2011 at 05:21:15PM -0300, Fabio Estevam wrote: > commit 22a85e4cd51 (spi/imx: add device tree probe support) broke spi-imx > usage > when the SPI chipselect is the one internal to the controller. > > On a mx31pdk board the following error is seen: Applied, thanks. g. > > Regis

Re: [PATCH v2] spi/imx: Fix spi-imx when the hardware SPI chipselects are used

2011-09-15 Thread Grant Likely
On Thu, Sep 15, 2011 at 10:19:09PM +0200, Uwe Kleine-König wrote: > Hello again, > > On Thu, Sep 15, 2011 at 09:52:43PM +0200, Uwe Kleine-König wrote: > > diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c > > index 8ac6542..fa594d6 100644 > > --- a/drivers/spi/spi-imx.c > > +++ b/drivers/

Re: [PATCH 53/62] spi: irq: Remove IRQF_DISABLED

2011-09-07 Thread Grant Likely
On Wed, Sep 07, 2011 at 04:10:50PM +0800, Yong Zhang wrote: > This flag is a NOOP and can be removed now. > > Signed-off-by: Yong Zhang Acked-by: Grant Likely > --- > drivers/spi/spi-bfin5xx.c |2 +- > drivers/spi/spi-coldfire-qspi.c |2 +- > dri

[GIT PULL] an spi bug fix

2011-08-02 Thread Grant Likely
/pl022: remove function cannot exit drivers/spi/spi-pl022.c | 11 +++ 1 files changed, 3 insertions(+), 8 deletions(-) -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. -- BlackBerry® DevCon Americas

Re: [PATCH] spi/pl022: remove function cannot exit

2011-08-02 Thread Grant Likely
On Tue, Aug 02, 2011 at 11:29:24AM +0200, Linus Walleij wrote: > From: Linus Walleij > > The remove function in the PL022 driver cannot abort the remove > function any way, so restructure the code so as not to make that > assumption. Remove will now proceed no matter whether it can > stop the tra

[GIT PULL] SPI changes for v3.1

2011-07-22 Thread Grant Likely
ommit 02f8c6aee8df3cdc935e9bdd4f2d020306035dbe: Linux 3.0 (2011-07-21 19:17:23 -0700) are available in the git repository at: git://git.secretlab.ca/git/linux-2.6 spi/next Anatolij Gustschin (1): spi/bitbang: initialize bits_per_word as specified by spi message Grant Likely (5): spi: reorganize drivers

Re: [PATCH] FSL eSPI driver: fix byte-vs-character and receive buffer problems

2011-07-19 Thread Grant Likely
On Tue, Jul 19, 2011 at 02:21:22PM +0200, Thomas De Schampheleire wrote: > The Freescale eSPI driver has several problems related to transaction > counting and receive buffer offset. > - The len field in struct spi_transfer is counted in bytes, while the TRANLEN > field in the eSPI controller is

Re: [PATCH v3] pxa2xx_spi: fix memory corruption

2011-07-15 Thread Grant Likely
On Fri, Jul 15, 2011 at 09:24:21PM +0100, Russell King - ARM Linux wrote: > On Fri, Jul 15, 2011 at 01:50:03PM -0600, Grant Likely wrote: > > On Fri, Jul 15, 2011 at 09:12:42AM +0100, Russell King - ARM Linux wrote: > > > On Thu, Jul 14, 2011 at 08:53:31PM -0600,

Re: [PATCH v3] pxa2xx_spi: fix memory corruption

2011-07-15 Thread Grant Likely
On Fri, Jul 15, 2011 at 09:12:42AM +0100, Russell King - ARM Linux wrote: > On Thu, Jul 14, 2011 at 08:53:31PM -0600, Grant Likely wrote: > > > + u8 null_dma_buf_unaligned[16]; > > > > Don't dma buffers need to be cache-line aligned? How large is the > > ac

Re: [PATCH v2 3/7] spi/imx: do not use spi_imx2_3 to name SPI_IMX_VER_2_3 function and macro

2011-07-14 Thread Grant Likely
I_IMX_VER_2_3 case, it will be mx51. To distinguish it > from CSPI on mx51, mx51_ecspi might be a good choice. > > Signed-off-by: Shawn Guo > Cc: Uwe Kleine-König > Cc: Sascha Hauer > Cc: Grant Likely Applied, thanks. g

Re: [PATCH v2 5/7] spi/imx: use soc name in spi device type naming scheme

2011-07-14 Thread Grant Likely
y: Shawn Guo > Cc: Uwe Kleine-König > Cc: Sascha Hauer > Cc: Grant Likely Applied, thanks. g. > --- > arch/arm/mach-imx/clock-imx25.c |7 +- > arch/arm/mach-mx5/clock-mx51-mx53.c | 11 +- > arch/arm/plat-mxc/devices/

Re: [PATCH v2 7/7] spi/imx: add device tree probe support

2011-07-14 Thread Grant Likely
On Sun, Jul 10, 2011 at 01:16:41AM +0800, Shawn Guo wrote: > It adds device tree probe support for spi-imx driver. > > Signed-off-by: Shawn Guo > Cc: Grant Likely Applied, thanks. g. > --- > .../devicetree/bindings/spi/fsl-imx-cspi.txt | 22 +++ >

Re: [PATCH v2 2/7] spi/imx: use mx21 to name SPI_IMX_VER_0_0 function and macro

2011-07-14 Thread Grant Likely
ince i.mx21 comes out ealier than i.mx27. > > > > Signed-off-by: Shawn Guo > > Cc: Uwe Kleine-König > > Cc: Sascha Hauer > > Cc: Grant Likely > > --- > > drivers/spi/spi-imx.c | 67 > > + > >

Re: [PATCH v2 1/7] spi/imx: do not make copy of spi_imx_devtype_data

2011-07-14 Thread Grant Likely
Kleine-König > Cc: Sascha Hauer > Cc: Grant Likely Applied, thanks. g. > --- > drivers/spi/spi-imx.c | 24 > 1 files changed, 12 insertions(+), 12 deletions(-) > > diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c > index 69d6dba..1c

Re: [PATCH v3] pxa2xx_spi: fix memory corruption

2011-07-14 Thread Grant Likely
On Sun, Jul 10, 2011 at 06:18:19PM +0300, Vasily Khoruzhick wrote: > pxa2xx_spi_probe allocates struct driver_data and null_dma_buf > at same time via spi_alloc_master(), but then calculates > null_dma_buf pointer incorrectly, and it causes memory corruption > later if DMA usage is enabled. > > Si

Re: [PATCH 1/1] merging arch/arm/include/asm/mach/flash.h and include/linux/spi/flash.h into single header file include/linux/mtd/flash.h

2011-07-10 Thread Grant Likely
On Mon, Jan 31, 2011 at 12:29:11PM +0100, Alexis RODET wrote: > > Signed-off-by: Alexis RODET No commit description? You should always describe what you're doing and why. I think I'm okay with this. What build testing have you performed? g. > --- > arch/arm/include/asm/mach/flash.h | 35

Re: [PATCH] dw_spi: Add spi number into spi irq desc

2011-07-08 Thread Grant Likely
On Fri, Jul 08, 2011 at 02:24:31PM +0800, Liu, ShuoX wrote: > From b260c4e51487364552886b0327fe98d66e850168 Mon Sep 17 00:00:00 2001 > From: ShuoX Liu > Date: Thu, 7 Jul 2011 16:09:41 +0800 > Subject: [PATCH] dw_spi: Add spi number into spi irq desc > > Signed-off-by: ShuoX Liu Actually, the pr

Re: [PATCH] dw_spi: Add spi number into spi irq desc

2011-07-08 Thread Grant Likely
On Fri, Jul 08, 2011 at 02:24:31PM +0800, Liu, ShuoX wrote: > From b260c4e51487364552886b0327fe98d66e850168 Mon Sep 17 00:00:00 2001 > From: ShuoX Liu > Date: Thu, 7 Jul 2011 16:09:41 +0800 > Subject: [PATCH] dw_spi: Add spi number into spi irq desc > > Signed-off-by: ShuoX Liu Patch does not a

Re: [PATCH 0/6] Add device tree support for imx spi driver

2011-07-08 Thread Grant Likely
On Fri, Jul 08, 2011 at 04:27:28PM +0800, Shawn Guo wrote: > The patch set makes some cleanups on imx spi driver to get it ready > for adding device tree probe and then add the support. > > Those two dt helper function related patches are carried here to > resolve the dependency. They should be o

Re: [PATCH 5/6] dt: add empty of_property_read_u32[_array] for non-dt

2011-07-08 Thread Grant Likely
c: Rob Herring > Cc: Thomas Abraham > Cc: Grant Likely Applied, thanks, and added the string version. > --- > include/linux/of.h | 15 +++ > 1 files changed, 15 insertions(+), 0 deletions(-) > > diff --git a/include/linux/of.h b/include/linux/of.h > inde

Re: [PATCH 2/2] SPI: SAMSUNG: Bug fix for SPI with different FIFO level

2011-07-06 Thread Grant Likely
On Wed, Jul 06, 2011 at 04:17:05PM +0900, Kukjin Kim wrote: > Grant Likely wrote: > > > > On Wed, Jul 06, 2011 at 03:22:08PM +0900, Kukjin Kim wrote: > > > Kukjin Kim wrote: > > > > > > > > Grant Likely wrote: > > > > > >

Re: [PATCH 2/2] SPI: SAMSUNG: Bug fix for SPI with different FIFO level

2011-07-05 Thread Grant Likely
On Wed, Jul 06, 2011 at 03:22:08PM +0900, Kukjin Kim wrote: > Kukjin Kim wrote: > > > > Grant Likely wrote: > > > > > > On Mon, Jul 04, 2011 at 07:08:55PM +0900, Kukjin Kim wrote: > > > > Kukjin Kim wrote: > > > > > > > > >

Re: [PATCH] spi/tegra: Use engineering names in DT compatible property

2011-07-05 Thread Grant Likely
On Tue, Jul 05, 2011 at 02:18:02PM -0600, Stephen Warren wrote: > Engineering names are more stable than marketing names. Hence, use them > for Device Tree compatible properties instead. > > Signed-off-by: Stephen Warren > --- > Grant, this is against devicetree/arm, and also makes sense for > de

Re: [PATCH] spi/fsl_spi: fix CPM spi driver

2011-07-05 Thread Grant Likely
> > Now the driver uses of_iomap to get access to this area > > similar to i2c driver driver in the i2c-cpm.c which has a > > similar device tree node. This is tested on a MPC8247 with CPM2. > > > > Signed-off-by: Holger Brunck > > cc: Grant Likely > >

Re: [PATCH] spi/fsl_spi: fix CPM spi driver

2011-07-05 Thread Grant Likely
th CPM2. > > Signed-off-by: Holger Brunck > cc: Grant Likely > cc: spi-devel-general@lists.sourceforge.net Applied, thanks. g. > --- > This was the same problem reported and discussed on ppc-dev for CPM1: > http://lists.ozlabs.org/pipermail/linuxppc-dev/2010-Sept

Re: [PATCH 0/5] remove spi-s3c24xx-gpio driver

2011-07-04 Thread Grant Likely
On Wed, Jun 29, 2011 at 07:51:10PM +0200, Peter Korsgaard wrote: > >>>>> "Grant" == Grant Likely writes: > > >> Great, will you handle the series or should it go through the spi tree? > > Grant> With the big spi driver rename, it should probabl

Re: [PATCH 0/5] remove spi-s3c24xx-gpio driver

2011-07-04 Thread Grant Likely
On Tue, Jun 28, 2011 at 02:49:12PM +0200, Peter Korsgaard wrote: > The spi-s3c24xx-gpio driver is functionally equivalent to the spi-gpio > driver (but precedes it). The driver has seen very little development > since it got added back in 2006, and there's only 2 in-tree users of it. > > This pat

Re: [PATCH 2/2] SPI: SAMSUNG: Bug fix for SPI with different FIFO level

2011-07-04 Thread Grant Likely
On Mon, Jul 04, 2011 at 07:08:55PM +0900, Kukjin Kim wrote: > Kukjin Kim wrote: > > > > Grant Likely wrote: > > > > > > On Mon, Jul 4, 2011 at 12:55 AM, Grant Likely > > > wrote: > > > > On Fri, Jul 01, 2011 at 11:43:08AM +0530, Jassi Brar

Re: [PATCH 2/2] SPI: SAMSUNG: Bug fix for SPI with different FIFO level

2011-07-03 Thread Grant Likely
On Mon, Jul 4, 2011 at 12:55 AM, Grant Likely wrote: > On Fri, Jul 01, 2011 at 11:43:08AM +0530, Jassi Brar wrote: >> On Fri, Jul 1, 2011 at 11:29 AM, padma venkat wrote: >> > Hi Jassi, >> > >> > On Fri, Jul 1, 2011 at 11:22 AM, Jassi Brar >> >

Re: [PATCH 2/2] SPI: SAMSUNG: Bug fix for SPI with different FIFO level

2011-07-03 Thread Grant Likely
On Fri, Jul 01, 2011 at 11:43:08AM +0530, Jassi Brar wrote: > On Fri, Jul 1, 2011 at 11:29 AM, padma venkat wrote: > > Hi Jassi, > > > > On Fri, Jul 1, 2011 at 11:22 AM, Jassi Brar > > wrote: > >> On Fri, Jul 1, 2011 at 11:16 AM, padma venkat wrote: > >>> Hi Tony, > >>> > >>> On Thu, Jun 30, 20

Re: [PATCH 0/5] remove spi-s3c24xx-gpio driver

2011-06-29 Thread Grant Likely
On Wed, Jun 29, 2011 at 11:00 AM, Peter Korsgaard wrote: >> "Ben" == Ben Dooks writes: > >  >> The spi-s3c24xx-gpio driver is functionally equivalent to the spi-gpio >  >> driver (but precedes it). The driver has seen very little development >  >> since it got added back in 2006, and there's

Re: [PATCH 08/11] spi-dw: Ensure fifo lenght is set.

2011-06-22 Thread Grant Likely
ger. > Installation's a snap, and flexible recovery options mean your data is safe, > secure and there when you need it. Data protection magic? > Nope - It's vRanger. Get your free trial download today. > http://p.sf.net/sfu/quest-sfdev2dev > _______

Re: [PATCH 07/11] spi-dw: Set number of available chip selects correctly

2011-06-22 Thread Grant Likely
On Wed, Jun 22, 2011 at 8:00 PM, wrote: > From: Dirk Brandewie > > Only four chip selects are available directly off the pins of the > master. > > Signed-off-by: Dirk Brandewie > --- >  drivers/spi/spi-dw-mid.c |    4 +++- >  1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/dri

Re: [PATCH 06/11] spi-dw: Force error on out of range chip select.

2011-06-22 Thread Grant Likely
On Wed, Jun 22, 2011 at 8:00 PM, wrote: > From: Dirk Brandewie > > BUG_ON() if the selected chip select is out of range. > > Signed-off-by: Dirk Brandewie > --- >  drivers/spi/spi-dw.h |    3 +-- >  1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/drivers/spi/spi-dw.h b/drivers

Re: [PATCH 01/11] spi-dw: expose platform data stucture.

2011-06-22 Thread Grant Likely
ontrol)(u32 command); > +}; > +#endif > -- > 1.7.3.4 > > > -- > Simplify data backup and recovery for your virtual environment with vRanger. > Installation's a snap, and flexible recove

Re: [PATCH] spi: omap2-mcspi: fix omap2_mcspi_probe error handling

2011-06-22 Thread Grant Likely
gt; >        status = spi_register_master(master); >        if (status < 0) > -               goto err4; > +               goto err_free_dma_channels; > > -       return status; > +       return 0; > > -err4: > -       spi_master_put(master); &g

Re: [PATCH] spi/pxa2xx: Remove unavailable ssp_type from documentation

2011-06-18 Thread Grant Likely
gt; @@ -61,7 +57,6 @@ static struct resource pxa_spi_nssp_resources[] = { >  }; > >  static struct pxa2xx_spi_master pxa_nssp_master_info = { > -       .ssp_type = PXA25x_NSSP, /* Type of SSP */ >        .clock_enable = CKEN_NSSP, /* NSSP Peripheral clock */ >        .num_chipselect = 1, /*

[GIT PULL] spi fixes for v3.0-rc3

2011-06-17 Thread Grant Likely
drivers/spi/spi_bfin5xx.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. -- EditLive Enterprise is the world's most technically adv

Re: [PATCH 2/4] spi/bfin_spi: use structs for accessing hardware regs

2011-06-17 Thread Grant Likely
On Fri, Jun 17, 2011 at 04:16:56AM -0400, Mike Frysinger wrote: > Rather than hardcoding the register sizes/offsets in this file, use the > existing struct in the spi header for reading/writing the hardware. > > Signed-off-by: Mike Frysinger Applied, thanks. g. > --- > drivers/spi/spi_bfin5xx

Re: [PATCH 4/4] spi/bfin_spi: uninline fat queue funcs

2011-06-17 Thread Grant Likely
On Fri, Jun 17, 2011 at 04:16:58AM -0400, Mike Frysinger wrote: > There's no need for these queue funcs to be inlined, so drop the > markings. This shaves off a few hundred duplicated bytes. > > Signed-off-by: Mike Frysinger Applied, thanks. g. > --- > drivers/spi/spi_bfin5xx.c |8 --

Re: [PATCH 3/4] spi/bfin_spi: constify pin array

2011-06-17 Thread Grant Likely
On Fri, Jun 17, 2011 at 04:16:57AM -0400, Mike Frysinger wrote: > This array isn't written anywhere, so constify it. > > Signed-off-by: Mike Frysinger Applied, thanks. g. > --- > drivers/spi/spi_bfin5xx.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/

Re: [PATCH 1/4 v2] spi/bfin_spi: fix handling of default bits per word setting

2011-06-17 Thread Grant Likely
On Fri, Jun 17, 2011 at 04:35:37AM -0400, Mike Frysinger wrote: > The default bits per word setting should be 8 bits, but since most of our > devices have been explicitly setting this up, we didn't notice when the > default stopped working. > > At the moment, any default transfers without an expli

Re: [PATCH] spi-topcliff-pch: Support new device ML7223 IOH

2011-06-16 Thread Grant Likely
On Fri, Jun 17, 2011 at 09:34:25AM +0900, Tomoya MORINAGA wrote: > Support new device OKI SEMICONDUCTOR ML7223 IOH(Input/Output Hub). > The ML7223 IOH is for MP(Media Phone) use. > The ML7223 is companion chip for Intel Atom E6xx series. > The ML7223 is completely compatible for Intel EG20T PCH. >

Re: [PATCH 3/5] dw_spi: rework message processing

2011-06-16 Thread Grant Likely
On Thu, Jun 16, 2011 at 11:28 AM, Dirk Brandewie wrote: > On 06/16/2011 07:00 AM, Feng Tang wrote: >> >> Hi Dirk, >> >> IMHO, the patch is too big, it contains too many changes to the original >> drivers, and we can't see clearly what you've changed to each logical >> code part or section, If poss

Re: [PATCH 3/5] dw_spi: rework message processing

2011-06-16 Thread Grant Likely
On Thu, Jun 16, 2011 at 09:03:49AM -0700, Dirk Brandewie wrote: > On 06/16/2011 06:14 AM, Grant Likely wrote: > >On Wed, Jun 15, 2011 at 10:23:06AM -0700, dirk.brande...@gmail.com wrote: > >>From: Dirk Brandewie > >> > >>NOTE: patch created git format-patch

<    1   2   3   4   5   6   7   8   9   10   >