On Tue, Dec 19, 2017 at 11:26:00AM -0500, Frediano Ziglio wrote:
> >
> > The .pdb files contain the debug information for the drivers. They
> > increase significantly the size of the installer, so it's better not to
> > ship them.
>
> On the other side bug report will contain much less informatio
On Wed, Dec 20, 2017 at 03:47:25PM +0100, Victor Toso wrote:
> To be honest, I wrote this patch 3 times because of this. There
> are other places in the source code that we do enum-to-string
> conversion and I was thinking in making this better now too.
>
> But then I thought that I was complicati
On Wed, Dec 20, 2017 at 09:35:00AM +, Frediano Ziglio wrote:
> The list will persist while the SASL connection is not disposed
> (or another sasl_listmech called).
>
> From documentation:
> * results:
> * result-- NUL terminated result which persists until next
> * call t
upgrading from spice-gtk v0.31 to spice-gtk
v0.33"
I'd mention some of these in the commit log, but apart from this,
Acked-by: Christophe Fergeau
Christophe
signature.asc
Description: PGP signature
___
Spice-devel mailing list
Spice-dev
On Fri, Dec 22, 2017 at 10:02:37AM +, Frediano Ziglio wrote:
> Palette images are encoded using a slightly larger number of pixel than
> width.
Hmm, these extra pixels are just padding, aren't they? "Palette images
have padding at the end of each line, so their stride can't be inferred
from th
On Tue, Jan 02, 2018 at 06:50:27AM -0500, Frediano Ziglio wrote:
> > Acked-by: Snir Sheriber
> > ( Maybe can be merged with the first patch? )
>
> It touches the same lines but it a completely different issue and
> rationale.
To be fair, this patch does not really have a detailed issue/rationale
Ok, this is an alternative to the patch I sent a while ago, which keeps
the files on the ISO, but does not add them to the installer. I was
initially confused ;)
Acked-by: Christophe Fergeau
On Mon, Jan 01, 2018 at 10:15:19AM +0200, Yedidyah Bar David wrote:
> Usually they are not needed,
On Sun, Dec 31, 2017 at 05:46:24PM +0200, Snir Sheriber wrote:
> Use custom playbin sink instead of just appsink.
> In order to allow playbin to choose decoders that requires
> more complex pipelines (e.g. pipeline that requires color
> space conversion & uses gl memory).
What is gstreamer take on
There is no such function implemented anywhere in the codebase.
Signed-off-by: Christophe Fergeau
---
src/spice-gtk-session-priv.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/spice-gtk-session-priv.h b/src/spice-gtk-session-priv.h
index d7fe3133..0dbc9e96 100644
--- a/src/spice-gtk
A few classes are implementing GObject::constructor, which is more
cumbersome to use than ::constructed. Other classes use ::constructed
rather than ::constructor. This commit removes the last uses of
::constructor.
Signed-off-by: Christophe Fergeau
---
src/spice-gtk-session.c | 20
Hi,
A new release of the SPICE Guest Tools for Windows is available at
https://www.spice-space.org/download/windows/spice-guest-tools/spice-guest-tools-0.141/spice-guest-tools-0.141.exe
The SPICE Guest Tools for Windows is an all-in-one installer which will
install the virtio drivers, the QXL dri
On Fri, Dec 22, 2017 at 10:07:03AM +, Frediano Ziglio wrote:
> These functions do not set errno so is possible that errno is EAGAIN.
I would be a little bit more explicit: "errno is EAGAIN" -> "errno has a
stale value which happens to be EAGAIN"
Acked-by: Christo
On Fri, Dec 22, 2017 at 10:07:05AM +, Frediano Ziglio wrote:
> +int
> +main(int argc, char *argv[])
> +{
> +return 0;
> +}
> +#else
> +int
> +main(void)
> +{
> +return 0;
> +}
> +#endif
Have you considered disabling the test in Makefile.am when SASL is not
available?
Christophe
sign
In the shortlog, "Add code *to* mocking functions .."?
On Fri, Dec 22, 2017 at 10:07:06AM +, Frediano Ziglio wrote:
> Check some functions are called in a given sequence.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/tests/test-sasl.c | 19 +++
> 1 file changed, 19 inser
On Fri, Dec 22, 2017 at 10:07:08AM +, Frediano Ziglio wrote:
> @@ -395,16 +427,32 @@ idle_next_test(void *arg)
> {
> // end previous test
> if (test_num >= 0) {
> -g_assert(encode_called);
> +const TestData *data = &tests_data[test_num];
> +if (data->success)
On Fri, Dec 22, 2017 at 10:07:07AM +, Frediano Ziglio wrote:
> Create a thread that emulate a client and start SASL authentication
".. that emulates .."
>
> Signed-off-by: Frediano Ziglio
> ---
> server/tests/test-sasl.c | 236
> ++-
> 1 file ch
Ok,
Acked-by: Christophe Fergeau
On Fri, Dec 22, 2017 at 10:07:08AM +, Frediano Ziglio wrote:
> Try different connections with different tricky names.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/tests/test-sasl.c | 60
>
On Fri, Jan 05, 2018 at 04:47:55AM -0500, Frediano Ziglio wrote:
> >
> > On Fri, Dec 22, 2017 at 10:07:08AM +, Frediano Ziglio wrote:
> > > @@ -395,16 +427,32 @@ idle_next_test(void *arg)
> > > {
> > > // end previous test
> > > if (test_num >= 0) {
> > > -g_assert(encode_ca
On Fri, Dec 22, 2017 at 10:07:10AM +, Frediano Ziglio wrote:
> Asynchronous code jumping from a file to another is tedious to read
> also having code handling the same stuff in two files does not look
> a good design.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/red-stream.c | 118
> ++
On Fri, Dec 22, 2017 at 10:07:11AM +, Frediano Ziglio wrote:
> All SPICE protocol is little endian, there's no agreement on other
> endian and currently we support only little endian so make sure
> this will work even possibly running on a big endian machine.
>
> Signed-off-by: Frediano Ziglio
On Fri, Dec 22, 2017 at 10:07:13AM +, Frediano Ziglio wrote:
> Instead of having half state in RedSASL and half in RedSASLAuth
> move everything in RedSASLAuth. This also reduces memory usage
> when we are using SASL but we finish the authentication step.
>
> Signed-off-by: Frediano Ziglio
>
which is only needed for _start, and can be NULL afterwards.
Apart from this, looks good,
Acked-by: Christophe Fergeau
signature.asc
Description: PGP signature
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.or
On Fri, Jan 05, 2018 at 03:45:31PM +, Frediano Ziglio wrote:
> -static void reds_handle_auth_sasl_start(void *opaque)
> +static void reds_handle_sasl_result(void *opaque, RedSaslError status)
> {
> RedLinkInfo *link = (RedLinkInfo *)opaque;
> -RedSaslError status;
> -
> -status =
From: Ting-Wei Lan
sys/acl.h works on both FreeBSD and Linux, so we should use it instead
of acl/libacl.h, which only works on Linux.
FreeBSD puts ACL functions in libc, so we should check whether ACL
functions are available in libc before doing the check with -lacl.
https://bugs.freedesktop.or
From: Ting-Wei Lan
FreeBSD has OpenSSL installed in base, but .pc files are not available.
We can still successfully build spice-gtk by setting SSL_CFLAGS and
SSL_LIBS variables manually, but openssl will still be recorded to
Requires.private field of spice-client-glib-2.0.pc, causing problems fo
Hey,
Here are 2 build fixes for FreeBSD which were filed in bugzilla ([1] and
[2]). They look good to me, so I'll push them in a few days if nobody
objects in the mean time.
Christophe
[1] https://bugs.freedesktop.org/show_bug.cgi?id=104524
[2] https://bugs.freedesktop.org/show_bug.cgi?id=104525
On Mon, Jan 08, 2018 at 04:47:26AM -0500, Frediano Ziglio wrote:
> >
> > Use custom playbin sink instead of just appsink.
> > In order to allow playbin to choose decoders that requires
> > more complex pipelines (e.g. pipeline that requires color
> > space conversion & uses gl memory).
> > The new
On Mon, Jan 08, 2018 at 04:05:30PM +0800, 王杰东 wrote:
> When my virt-viewer spice clients are in net-A , and the hypervisor server
> with spice is in net-B , and a server is in both net-A and net-B
> How can i use virt-viewer to connect th vms on hypervisor server ?
>
> https://access.redhat.com/
est sending of clipboard data is then delayed until the
window is focused again. This behaviour matches the behaviour we get on
Wayland.
This mostly solves https://bugzilla.redhat.com/show_bug.cgi?id=1320263
Signed-off-by: Christophe Fergeau
---
Not overly happy with the added complexity, ma
For the series:
Acked-by: Christophe Fergeau
On Fri, Jan 05, 2018 at 12:12:00PM +, Frediano Ziglio wrote:
> Network fields should be encoded as little endian.
> This was discovered using an emulated MIPS machine.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/tests/
Hey,
On Tue, Jan 09, 2018 at 09:46:48AM -0500, Marc-André Lureau wrote:
> - Original Message -
> > This is used to prevent unfocused guests from sniffing the clipboard
> > content without the host or other guests noticing. This can be a
> > security issue if any VM can track the clipboard
On Tue, Jan 09, 2018 at 11:08:44AM -0500, Marc-André Lureau wrote:
> - Original Message -
> >
> > What makes spice different here is that it's used to access a VM, and a
> > VM is supposed to give you isolation. If some hostile code is running in
> > the VM, its impact on the host/client O
improved if needed.
For the series,
Acked-by: Christophe Fergeau
On Tue, Jan 09, 2018 at 07:44:55AM +, Frediano Ziglio wrote:
> SASL authentication code were a bit dodgy to see.
> The series have 2 parts:
> - a test for SASL code;
> - some code refactory.
>
> Test is not th
Hey,
On Fri, Dec 15, 2017 at 04:33:26AM -0500, Frediano Ziglio wrote:
> ping
So I finally took a quick look at this, patch 2/3 and 3/3 really deserve
a more detailed commit log/rationale/..., they cannot have just a
shortlog. Apart from that, they seemed ok, though we don't really have a
way to c
On Thu, Dec 07, 2017 at 08:47:38AM +, Frediano Ziglio wrote:
> Qemu does not trigger a new data read if we don't read all data in
> the buffer.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/stream-device.c| 9
> server/tests/test-stream-device.c | 43
>
On Thu, Dec 07, 2017 at 08:47:39AM +, Frediano Ziglio wrote:
> Due to the way Qemu handle the device we must consume all pending
> data inside the callback to read data from the device.
Any idea if QEMU can be fixed to do the right thing? We'll still need
some kind of workaround to deal with o
On Wed, Jan 10, 2018 at 11:39:32AM -0500, Frediano Ziglio wrote:
> >
> > Hey,
> >
> > On Fri, Dec 15, 2017 at 04:33:26AM -0500, Frediano Ziglio wrote:
> > > ping
> >
> > So I finally took a quick look at this, patch 2/3 and 3/3 really deserve
> > a more detailed commit log/rationale/..., they ca
On Tue, Jan 09, 2018 at 12:16:33PM -0500, Marc-André Lureau wrote:
> I think it's problematic for traditional applications as well.
> clipboard access is probably going to be limited by default and only
> accessed through so-called "portals", just like file access etc. This
> topic should be brough
On Wed, Jan 10, 2018 at 06:48:14PM -0500, Marc-André Lureau wrote:
> Hi
>
> - Original Message -
> > On Tue, Jan 09, 2018 at 12:16:33PM -0500, Marc-André Lureau wrote:
> > > I think it's problematic for traditional applications as well.
> > > clipboard access is probably going to be limite
On Thu, Jan 11, 2018 at 11:42:00AM -0500, Marc-André Lureau wrote:
>
> > (it seems that clipboard system for GTK 4 has been reworked quite a
> > bit - see https://git.gnome.org/browse/gtk+/log/?h=wip/otte/clipboard
> > - this is already merged into master)
>
> I have not much time to look at the
On Thu, Jan 11, 2018 at 12:35:36PM -0500, Marc-André Lureau wrote:
> > I agree with you that some help from the windowing/toolkit would be good
> > to have, but in this case, I doubt we are going to be able to do better
> > than managing this in spice-gtk.
>
> Yet it is already being solved at a l
On Fri, Jan 12, 2018 at 08:05:24AM -0500, Marc-André Lureau wrote:
>
> Is it really a security reason the clipboard behaviour is different on
> Wayland?
I don't know the reason for this behaviour, for me this is similar to
preventing applications from capturing the whole screen.
https://wiki.x.or
Hey,
Might have been worth splitting this a bit. Regardless of that, looks
goodh to me,
Acked-by: Christophe Fergeau
On Wed, Jan 10, 2018 at 08:51:16AM +, Frediano Ziglio wrote:
> Some additional header are needed to avoid undefined types.
> SOL_TCP and IPPROTO_TCP have the same va
On Tue, Jan 09, 2018 at 04:42:51PM -0500, Frediano Ziglio wrote:
> >
> > On Mon, Dec 11, 2017 at 10:27:58AM +, Frediano Ziglio wrote:
> > > Coverity complaint that this field should be protected by
> > > a mutex as other accesses are with the mutex locked.
> > > Use atomic operation. Not in an
Acked-by: Christophe Fergeau
On Tue, Jan 09, 2018 at 07:43:24PM +, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/tests/basic-event-loop.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/server/tests/basic-event-loop.c b/server/tests/
Acked-by: Christophe Fergeau
On Tue, Jan 09, 2018 at 07:43:25PM +, Frediano Ziglio wrote:
> The same function is used to reset writev field in SASL code.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/red-stream.c | 4 +---
> 1 file changed, 1 insertion(+), 3 dele
read_done_cb(opaque);
> +return;
> +}
This bit seems unrelated?
Apart from this,
Acked-by: Christophe Fergeau
Christophe
signature.asc
Description: PGP signature
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
On Tue, Jan 16, 2018 at 08:59:14AM -0500, Frediano Ziglio wrote:
> Yes, is handling a particular case (reading 0 bytes) directly instead of
> adding a pending operation. It can be useful if you have a sequence
> length+data
> where length can be 0. Currently cannot happen (size is always > 0), in
ould have argued that
test-display-base is more centered around testing display-related stuff,
while this one could focus on testing socket-related things. But since
it's not part of automated tests, ok for removing it.
Acked-by: Christophe Fergeau
signature.asc
Description:
hey,
On Wed, Jan 17, 2018 at 12:15:03PM +0300, Oleg Ginzburg wrote:
> Confirm - these changes work successfully, tested on: FreeBSD 11.1-RELEASE
> and FreeBSD 12-CURRENT (aka HEAD).
>
> Will these changes be included in the next release?
>
> There is another small issue of build libspice-server
At least on X.org, malicious code could run the equivalent of "watch
xsel -o --clipboard" in a VM, and would then be able to track all the
clipboard content, even when the spice-gtk widget is not focused.
At the moment, applications call spice_set_session_option(), and then
set SpiceGtkSession::au
On Thu, Jan 18, 2018 at 12:06:34PM +0100, Marc-André Lureau wrote:
> Hi
>
> On Thu, Jan 18, 2018 at 10:31 AM, Christophe Fergeau
> wrote:
> > At least on X.org, malicious code could run the equivalent of "watch
> > xsel -o --clipboard" in a VM, and w
On Wed, Jan 17, 2018 at 11:31:04AM +, Frediano Ziglio wrote:
> The field is only assigned but never used.
I would mention that this was used in the GDI canvas, but that this has
now been removed.
Apart from this, for the series,
Acked-by: Christophe Fergeau
>
> Signed-off-by:
On Wed, Jan 17, 2018 at 11:31:07AM +, Frediano Ziglio wrote:
> Not used anymore.
>
> Signed-off-by: Frediano Ziglio
> ---
> common/canvas_base.h | 3 ---
> common/sw_canvas.c | 3 ---
> 2 files changed, 6 deletions(-)
>
> diff --git a/common/canvas_base.h b/common/canvas_base.h
> index 2d
On Tue, Feb 13, 2018 at 02:40:38PM +0100, Christophe de Dinechin wrote:
>
>
> > On 13 Feb 2018, at 14:39, Frediano Ziglio wrote:
> >
> >>>
> >>> On 12 Feb 2018, at 17:58, Frediano Ziglio wrote:
> >>>
> >>> In SPICE, as in Glib, ERROR is more "strong" than CRITICAL
> >>> (I don't know where t
On Thu, Feb 08, 2018 at 12:25:24PM +0100, Christophe de Dinechin wrote:
> From: Christophe de Dinechin
>
> Signed-off-by: Christophe de Dinechin
> ---
> docs/spice_style.txt | 15 ---
> 1 file changed, 12 insertions(+), 3 deletions(-)
>
> diff --git a/docs/spice_style.txt b/docs/sp
Shouldn't this go with a Makefile rule? A few lines in the log what this
is about, what is the goal for having this file, ... would not hurt.
Christophe
On Thu, Feb 08, 2018 at 12:25:21PM +0100, Christophe de Dinechin wrote:
> From: Christophe de Dinechin
>
> Signed-off-by: Christophe de Dinech
On Thu, Feb 08, 2018 at 03:48:46AM -0500, Frediano Ziglio wrote:
> I think that the "Alternatively, use global `const` variables."
> is quite an ancient comment when spice-server was in C++
> (much before I join and I think even older than the git repository!)
There was a C++ *client* in spice.git
On Thu, Feb 08, 2018 at 03:50:37AM -0500, Frediano Ziglio wrote:
> >
> > From: Christophe de Dinechin
> >
> > Signed-off-by: Christophe de Dinechin
> > ---
> > docs/spice_style.txt | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/docs/spice_style.txt b/docs/spice
On Thu, Feb 08, 2018 at 03:58:46AM -0500, Frediano Ziglio wrote:
> > +
> > +[source,h]
> > +---
> > +#ifndef MY_MODULE_H
> > +#define MY_MODULE_H
> > +
> > +...
> > +
> > +#endif /* MY_MODULE_H */
> > +---
> > +
>
> Are we suggesting C style only comment or is clear the is not important?
> (I'm ju
On Mon, Feb 12, 2018 at 03:23:06AM -0500, Frediano Ziglio wrote:
> See
> https://lists.freedesktop.org/archives/spice-devel/2018-February/041724.html
>
> > From: Christophe de Dinechin
> >
> > Signed-off-by: Christophe de Dinechin
> > ---
> > docs/spice_style.txt | 11 ++-
> > 1 file
This one sounds more like an RFC to me, as from a quick look in server/,
this is not the style currently in use.
Christophe
On Thu, Feb 08, 2018 at 12:25:31PM +0100, Christophe de Dinechin wrote:
> From: Christophe de Dinechin
>
> As written, the headers style guide looks quite wrong. In partic
On Thu, Feb 08, 2018 at 12:25:30PM +0100, Christophe de Dinechin wrote:
> From: Christophe de Dinechin
>
> The objective of these guidelines is that:
> - We avoid introducing new warnings
> - We know how to fix old ones
> - We don't have to isolate whitespace changes when submitting patches,
>
On Mon, Jan 29, 2018 at 05:16:12PM -0500, Frediano Ziglio wrote:
> >
> >
> > > On 29 Jan 2018, at 12:00, Frediano Ziglio wrote:
> > >
> > > Signed-off-by: Frediano Ziglio
> > > ---
> > > Makefile.am | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/Makefi
On Thu, Feb 08, 2018 at 08:16:37AM +0100, Christophe de Dinechin wrote:
> Using std::string by default is *not* considered a good practice in
> C++. The reference for C++ good practices are probably best summarized
> by the C++ Core Guidelines:
> https://github.com/isocpp/CppCoreGuidelines/blob/mas
On Thu, Feb 08, 2018 at 12:25:29PM +0100, Christophe de Dinechin wrote:
> From: Christophe de Dinechin
>
> Signed-off-by: Christophe de Dinechin
> ---
> docs/spice_style.txt | 19 +++
> 1 file changed, 19 insertions(+)
>
> diff --git a/docs/spice_style.txt b/docs/spice_style.tx
This changes the suggested style to what is currently used in
spice-server codebase. This also removes a few sentences which
are not really related to how one should format their header guards.
Signed-off-by: Christophe Fergeau
---
docs/spice_style.txt | 6 ++
1 file changed, 2 insertions
On Wed, Feb 14, 2018 at 10:45:56AM -0500, Frediano Ziglio wrote:
> >
> > Shouldn't this go with a Makefile rule? A few lines in the log what this
> > is about, what is the goal for having this file, ... would not hurt.
> >
> > Christophe
> >
>
> I think this file is supposed to just help develo
On Wed, Feb 14, 2018 at 10:40:58AM -0500, Frediano Ziglio wrote:
> >
> > > On 14 Feb 2018, at 13:34, Lukáš Hrázký wrote:
> > >
> > > Introduce a unit test framework (Catch) to the codebase and a simple
> > > unit test for parsing the options of the mjpeg plugin.
> > >
> > > Signed-off-by: Lukáš
On Thu, Feb 08, 2018 at 11:09:35AM +0100, Victor Toso wrote:
> Hi,
>
> On Thu, Feb 08, 2018 at 05:01:05AM -0500, Frediano Ziglio wrote:
> > > > Depends on many cases. You don't want spurious changes to make harder to
> > > > look at the history for instance (that is a point for Nack).
> > > > The
On Wed, Feb 14, 2018 at 10:53:04PM +0100, Christophe de Dinechin wrote:
>
>
> > On 14 Feb 2018, at 14:37, Christophe Fergeau wrote:
> >
> > On Thu, Feb 08, 2018 at 12:25:30PM +0100, Christophe de Dinechin wrote:
> >> From: Christophe de Dinechin
> >>
On Wed, Feb 14, 2018 at 10:29:25PM +0100, Christophe de Dinechin wrote:
>
>
> > On 14 Feb 2018, at 17:34, Christophe Fergeau wrote:
> >
> > On Wed, Feb 14, 2018 at 10:45:56AM -0500, Frediano Ziglio wrote:
> >>>
> >>> Shouldn't this go w
On Wed, Feb 14, 2018 at 11:24:50PM +0100, Christophe de Dinechin wrote:
>
>
> > On 14 Feb 2018, at 14:35, Christophe Fergeau wrote:
> >
> > This one sounds more like an RFC to me
>
> Well, this is really a bug fix in the documentation more than a RFC.
>
>
On Wed, Feb 14, 2018 at 10:43:26PM +0100, Christophe de Dinechin wrote:
>
>
> > On 14 Feb 2018, at 17:29, Christophe Fergeau wrote:
> >
> > This changes the suggested style to what is currently used in
> > spice-server codebase. This also removes a few sent
On Thu, Feb 15, 2018 at 10:56:49AM +0100, Lukáš Hrázký wrote:
> On Wed, 2018-02-14 at 22:43 +0100, Christophe de Dinechin wrote:
> > > On 14 Feb 2018, at 17:29, Christophe Fergeau wrote:
> > >
> > > This changes the suggested style to what is currently used in
>
On Thu, Feb 15, 2018 at 11:55:44AM +0100, Christophe de Dinechin wrote:
> Now, Christophe’s arguments are that
>
> 1) we should not write guidelines that are inconsistent with existing code.
> 2) this is in the server codebase, so we should server rules
>
> Problem is with 2, really.
>
> We star
On Thu, Feb 15, 2018 at 01:14:43PM +0100, Christophe de Dinechin wrote:
>
>
> > On 15 Feb 2018, at 10:19, Christophe Fergeau wrote:
> >
> > On Wed, Feb 14, 2018 at 11:24:50PM +0100, Christophe de Dinechin wrote:
> >>
> >>
> >>&g
On Thu, Feb 15, 2018 at 03:25:23PM +0100, Christophe de Dinechin wrote:
>
>
> > On 15 Feb 2018, at 13:41, Christophe Fergeau wrote:
> >
> > On Thu, Feb 15, 2018 at 11:55:44AM +0100, Christophe de Dinechin wrote:
> >> Now, Christophe’s arguments are that
On Thu, Feb 15, 2018 at 03:25:08PM +0100, Christophe de Dinechin wrote:
> > And then I made concrete suggestions
> > as how I would move forward with this patch…
>
> Sorry, I saw your push back, but I did not see the concrete suggestion for
> moving forward… Would you please be kind enough to rep
On Thu, Feb 15, 2018 at 04:04:57PM +0100, Christophe de Dinechin wrote:
>
> This style guide only indicates what we aim to achieve. It does not
> necessarily reflect the current state of the code.
>
> What about adding:
>
> Consistency matters. It may be preferable to ignore a style
On Thu, Feb 15, 2018 at 05:06:19PM +0100, Christophe de Dinechin wrote:
> From: Christophe de Dinechin
>
> Signed-off-by: Christophe de Dinechin
> ---
> docs/spice_style.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/docs/spice_style.txt b/docs/spice_style.txt
> i
On Thu, Feb 15, 2018 at 05:06:14PM +0100, Christophe de Dinechin wrote:
> From: Christophe de Dinechin
>
> There are two use cases for this .clang-format:
>
> 1. Local reformatting of source code, e.g. using Emacs clang-format.el
> package.
>This is basically a wawy to accelerate routine re
On Thu, Feb 15, 2018 at 05:06:17PM +0100, Christophe de Dinechin wrote:
> From: Christophe de Dinechin
>
> Changes since v3:
> - Integrate comments about performance impact and solution
> - Integrate comments about impact of a failed assertion
> - Add prohibition against side effects
>
> Signed-
On Thu, Feb 15, 2018 at 05:06:21PM +0100, Christophe de Dinechin wrote:
> From: Christophe de Dinechin
>
> The objective of these guidelines is that:
> - We avoid introducing new warnings
> - We know how to fix old ones
>
> Changes since v3:
> - Put 'controversial' whitespace proposal in separat
The shortlog is not really good..
On Thu, Feb 15, 2018 at 05:06:23PM +0100, Christophe de Dinechin wrote:
> From: Christophe de Dinechin
>
> This attempts to find a wording that takes into account the existing
> practice, notably in the server.
>
> Signed-off-by: Christophe de Dinechin
> ---
>
On Thu, Feb 15, 2018 at 05:06:25PM +0100, Christophe de Dinechin wrote:
> From: Christophe de Dinechin
>
> Change since v3:
> - This particular aspect is controversial, so it was put in a separate patch.
This has been nack'ed by multiple people already, please don't resend it
unchanged.
Christo
On Fri, Feb 16, 2018 at 10:40:58AM +0100, Christophe de Dinechin wrote:
>
>
> > On 16 Feb 2018, at 10:12, Christophe Fergeau wrote:
> >
> > On Thu, Feb 15, 2018 at 05:06:17PM +0100, Christophe de Dinechin wrote:
> >> From: Christophe de Dinechin
> >>
On Thu, Feb 15, 2018 at 05:06:17PM +0100, Christophe de Dinechin wrote:
> From: Christophe de Dinechin
>
> Changes since v3:
> - Integrate comments about performance impact and solution
> - Integrate comments about impact of a failed assertion
> - Add prohibition against side effects
>
> Signed-
On Wed, Feb 14, 2018 at 06:52:11PM +0100, Christophe de Dinechin wrote:
> From: Christophe de Dinechin
>
> Signed-off-by: Christophe de Dinechin
> ---
> src/spice-streaming-agent.cpp | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/src/spice-streaming-agent.cpp
On Fri, Feb 16, 2018 at 04:23:06PM +0100, Christophe de Dinechin wrote:
> From: Christophe de Dinechin
>
> Without this, GCC complains about signed / unsigned comparisons:
>
> mjpeg-fallback.cpp:121:24: warning: comparison between signed and unsigned
> integer expressions [-Wsign-compare]
>
On Fri, Feb 16, 2018 at 10:30:18AM +, Daniel P. Berrangé wrote:
> On Fri, Feb 16, 2018 at 11:13:06AM +0100, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > spice:// has a weird scheme encoding, where it can accept both plain
> > and tls ports with URI query parameters.
On Thu, Feb 15, 2018 at 03:58:15PM +0100, Christophe de Dinechin wrote:
> Again, I really don’t want to have to post-process my patches manually
> to split-out whitespace corrections. I see that as “punishment for
> doing the right thing”.
This is also a matter of differing workflows, I mostly exc
On Wed, Feb 14, 2018 at 10:13:41PM +0100, Christophe de Dinechin wrote:
> >> I’d write “config.h”. No reason to ever look config.h in system headers.
> >
> > The reason for the <> is described in [1], 4th paragraph. I've
> > mentioned it during the previous discussion and didn't get any comment
>
On Thu, Feb 15, 2018 at 03:28:42PM +0100, Christophe de Dinechin wrote:
> While looking at some warnings, I came across this in sw_canvas.c:
>
> #include “canvas_base.c"
>
> So we include a .c in another one. Apparently, this was inherited from some
> Cairo canvas. Is that something we care to k
Hey,
On Thu, Feb 15, 2018 at 10:05:04AM +0100, Victor Toso wrote:
> From: Victor Toso
>
> Libva is an implementation for VA-API.
>
> This can be used to automatically send to the server the
> preferred video codecs as the client would prefer streams
> with video codecs that can be decoded with
On Thu, Feb 15, 2018 at 10:05:05AM +0100, Victor Toso wrote:
> From: Victor Toso
>
> By using the detection of which video codecs (and profiles!) the
> hardware supports with VA-API capable driver in previous commit.
>
> Signed-off-by: Victor Toso
> ---
> src/channel-display.c | 33 +++
On Tue, Feb 13, 2018 at 01:58:07PM +, Frediano Ziglio wrote:
> Changes since v2:
> - shrink buffer after the message is handled.
>
> Frediano Ziglio (2):
> stream-device: handle cursor from device
> stream-device: Implement mouse movement
>
> server/stream-device.c | 201
>
On Mon, Feb 19, 2018 at 03:06:40PM +0100, Christophe de Dinechin wrote:
>
>
> > On 19 Feb 2018, at 13:24, Christophe Fergeau wrote:
> >
> > On Fri, Feb 16, 2018 at 04:23:06PM +0100, Christophe de Dinechin wrote:
> >> From: Christophe de Dinechin
> >&g
On Thu, Jan 18, 2018 at 12:13:45PM +0100, Christophe Fergeau wrote:
> On Thu, Jan 18, 2018 at 12:06:34PM +0100, Marc-André Lureau wrote:
> > Hi
> >
> > On Thu, Jan 18, 2018 at 10:31 AM, Christophe Fergeau
> > wrote:
> > > At least on X.org, malicious cod
On Mon, Feb 19, 2018 at 09:19:18PM +0200, Uri Lublin wrote:
> If users prefer to not run autogen.sh that's ok.
> It provides defaults options for developers.
> For example, I do not expect users to run configure with
> --enable-maintainer-mode too.
NB: My understanding of
https://blogs.gnome.org/
401 - 500 of 6964 matches
Mail list logo
