[Spice-devel] [PATCH 1/2] spice client: fix dns lookup

2010-02-19 Thread Gerd Hoffmann
ignore lookup results which are not ipv4 Signed-off-by: Gerd Hoffmann kra...@redhat.com --- client/red_peer.cpp |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/client/red_peer.cpp b/client/red_peer.cpp index bdbf1ff..f252ef2 100644 --- a/client/red_peer.cpp +++ b/client

[Spice-devel] [PATCH 2/2] spice client: add ipv6 support.

2010-02-19 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- client/red_peer.cpp | 89 +++--- 1 files changed, 41 insertions(+), 48 deletions(-) diff --git a/client/red_peer.cpp b/client/red_peer.cpp index f252ef2..a6afcc2 100644 --- a/client/red_peer.cpp

[Spice-devel] spice for upstream qemu

2010-04-07 Thread Gerd Hoffmann
Hi, I'm busy fixing up the libspice-server API and preparing patches for upstream qemu. The bits start to become usable now, so I've prepared git trees for you to checkout. spice bits: http://cgit.freedesktop.org/~kraxel/spice/log/?h=api.v2 qemu bits:

[Spice-devel] [PATCH] make unstable qxl compatible with 0.4 qxl

2010-04-14 Thread Gerd Hoffmann
-by: Gerd Hoffmann kra...@redhat.com --- spice/qxl_dev.h |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/spice/qxl_dev.h b/spice/qxl_dev.h index 2873101..0dbe3a7 100644 --- a/spice/qxl_dev.h +++ b/spice/qxl_dev.h @@ -62,6 +62,7 @@ enum { QXL_IO_UPDATE_IRQ

[Spice-devel] [PATCH v2] make unstable qxl compatible with 0.4 qxl

2010-04-16 Thread Gerd Hoffmann
to structs which need care wrt. compatibility when updating. Added some QXLCompat* structs for the 0.4 struct versions. Added a flags field to QXLCommandEx so qxl can signal whenever commands are compat or not. Moved QXLRom-n_surfaces to make QXLRom-flags 64bit aligned. Signed-off-by: Gerd

Re: [Spice-devel] Spice in Fedora Rawhide?

2010-04-22 Thread Gerd Hoffmann
Hi, Getting upstream qemu to have the patches sounds important regardless, but I'm unclear on the first part of what you say here. Wouldn't any libraries needed for spice by definition be used by an application? That application would be qemu ... This work is led by Gerd Hoffmann and can

[Spice-devel] [PATCH] fix two warnings

2010-04-26 Thread Gerd Hoffmann
--- client/x11/platform.cpp |2 +- common/canvas_base.c|2 ++ 2 files changed, 3 insertions(+), 1 deletions(-) diff --git a/client/x11/platform.cpp b/client/x11/platform.cpp index 498e6e5..550de19 100644 --- a/client/x11/platform.cpp +++ b/client/x11/platform.cpp @@ -260,7 +260,7 @@

Re: [Spice-devel] New win32 driver for master

2010-04-27 Thread Gerd Hoffmann
On 04/26/10 16:38, Alexander Larsson wrote: I just commited the patches from gerd for backwards compatibility with 0.4, and this in addition to the recent format changes break compatibility with the win32 driver, so i built a new driver, availible at:

[Spice-devel] libspice and save/restore/migration

2010-05-03 Thread Gerd Hoffmann
Hi, I want change the way save/restore works for the qxl device. 0.4 works this way: savevm qxl: call worker-save() worker: call interface-set_save_data(data, size) qxl: save data block. loadvm qxl: load data block. qxl: call worker-load() worker: call

Re: [Spice-devel] C version of find_msb()

2010-05-03 Thread Gerd Hoffmann
Hi, This patch allows people to build the spice-client on any 32bit/64bit architecture, but it doesn't solve the endianess problems in the SPICE protocol itself. Has anyone looked into the network byte-ordering issues? spice protocol (on the wire) is defined to be little endian. Alexander

[Spice-devel] [PATCH 03/35] zap CoreInterface-next()

2010-05-12 Thread Gerd Hoffmann
Interfaces must be registered after spice_server_init(). The next callback is used to discover interfaces registered before spice_server_init(). Which is a empty list and thus pretty pointless. Remove it. --- server/reds.c |7 --- server/vd_interface.h |2 -- 2 files

[Spice-devel] [PATCH 02/35] channel security cleanup

2010-05-12 Thread Gerd Hoffmann
- drop spice_channel_name_t enum, use spice-protocol defines instead. - switch spice_server_set_channel_security() channel parameter from enum to string. - drop spice_server_set_default_channel_security(), use spice_server_set_channel_security with channel == NULL instead. --- server/reds.c

[Spice-devel] [PATCH 09/35] new watch api: switch listening sockets

2010-05-12 Thread Gerd Hoffmann
--- server/reds.c | 34 -- 1 files changed, 20 insertions(+), 14 deletions(-) diff --git a/server/reds.c b/server/reds.c index d7a8132..89f828d 100644 --- a/server/reds.c +++ b/server/reds.c @@ -245,6 +245,8 @@ typedef struct RedsStatValue { typedef struct

[Spice-devel] [PATCH 06/35] zap CoreInterface-{term_printf,log}

2010-05-12 Thread Gerd Hoffmann
Was used to print stuff to the qemu monitor. Fundamentally incompatible with QMP. Remove. --- server/reds.c | 48 +--- server/vd_interface.h |4 2 files changed, 5 insertions(+), 47 deletions(-) diff --git a/server/reds.c

[Spice-devel] [PATCH 07/35] fix visibility

2010-05-12 Thread Gerd Hoffmann
--- server/reds.c | 50 ++ server/reds.h |2 ++ 2 files changed, 28 insertions(+), 24 deletions(-) diff --git a/server/reds.c b/server/reds.c index 74da545..d7a8132 100644 --- a/server/reds.c +++ b/server/reds.c @@ -4305,14 +4305,14 @@ static

[Spice-devel] [PATCH 14/35] new watch api: switch migration

2010-05-12 Thread Gerd Hoffmann
--- server/reds.c | 59 + 1 files changed, 30 insertions(+), 29 deletions(-) diff --git a/server/reds.c b/server/reds.c index d995f78..095e644 100644 --- a/server/reds.c +++ b/server/reds.c @@ -3246,6 +3246,7 @@ typedef struct

[Spice-devel] [PATCH 13/35] new watch api: switch inputs

2010-05-12 Thread Gerd Hoffmann
--- server/reds.c | 50 +- 1 files changed, 25 insertions(+), 25 deletions(-) diff --git a/server/reds.c b/server/reds.c index 138d0f4..d995f78 100644 --- a/server/reds.c +++ b/server/reds.c @@ -2277,31 +2277,31 @@ static void

[Spice-devel] [PATCH 19/35] shlib major

2010-05-12 Thread Gerd Hoffmann
--- configure.ac |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure.ac b/configure.ac index 94cd65f..0958b6d 100644 --- a/configure.ac +++ b/configure.ac @@ -26,7 +26,7 @@ AC_PROG_LIBTOOL AM_PROG_CC_C_O AC_C_BIGENDIAN -SPICE_LT_VERSION=m4_format(%d:%d:%d,

[Spice-devel] [PATCH 21/35] s/CoreInterface/SpiceCoreInterface/

2010-05-12 Thread Gerd Hoffmann
--- server/red_channel.c |3 ++- server/red_channel.h |5 +++-- server/red_tunnel_worker.c |5 +++-- server/red_tunnel_worker.h |2 +- server/reds.c | 14 -- server/reds.h |2 +- server/spice.h |5 +

[Spice-devel] [PATCH 22/35] KeyboardInterface: redesign.

2010-05-12 Thread Gerd Hoffmann
This is the direction I wanna take with all interfaces: Clearly separate interface (aka version information and function pointers) and state information. SpiceKbdInterface defines the interface, SpiceKbdInstance maintains per-instance state information. Keyboard hasn't much beside a pointer to

[Spice-devel] [PATCH 18/35] minor timer interface cleanups.

2010-05-12 Thread Gerd Hoffmann
Make the timer interface largely look like the watch interface. Simliar naming convention for the functions (timer_*) and a opaque SpiceTimer type. --- server/red_tunnel_worker.c |5 ++--- server/reds.c | 40 server/vd_interface.h |

[Spice-devel] [PATCH 33/35] [debug] migration troubleshooting

2010-05-12 Thread Gerd Hoffmann
--- client/application.cpp |2 +- server/reds.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/client/application.cpp b/client/application.cpp index 4eb8ac8..74f5543 100644 --- a/client/application.cpp +++ b/client/application.cpp @@ -2110,7 +2110,7 @@ void

[Spice-devel] [PATCH 25/35] TabletInterface: redesign

2010-05-12 Thread Gerd Hoffmann
--- server/reds.c | 41 ++--- server/reds.h |4 server/vd_interface.h | 27 +-- 3 files changed, 47 insertions(+), 25 deletions(-) diff --git a/server/reds.c b/server/reds.c index 62a2cab..24b1507 100644 ---

[Spice-devel] [PATCH 20/35] VDInterface: redesign.

2010-05-12 Thread Gerd Hoffmann
VDInterface has been renamed to SpiceBaseInterface. Dropped base_version element, shlib versioning should be used instead. Dropped id element, it is passed to spice_server_add_interface() instead. Now SpiceBaseInterface has static information only, multiple interface instances can share it.

[Spice-devel] [PATCH 24/35] QXL: redesign.

2010-05-12 Thread Gerd Hoffmann
--- server/red_dispatcher.c | 36 ++-- server/red_dispatcher.h |2 +- server/red_worker.c | 38 +++--- server/red_worker.h |2 +- server/reds.c | 20 +++- server/reds.h |5

[Spice-devel] [PATCH 26/35] SoundInterfaces: redesign

2010-05-12 Thread Gerd Hoffmann
--- server/reds.c | 30 +- server/snd_worker.c | 160 server/snd_worker.h |8 +- server/vd_interface.h | 84 +- 4 files changed, 141 insertions(+), 141 deletions(-) diff --git a/server/reds.c

[Spice-devel] [PATCH 31/35] replace worker load/save with loadvm_commands, allow keeping surface content

2010-05-12 Thread Gerd Hoffmann
Add worker-loadvm_commands. qemu will uses this to send a series of commands needed to restore state after savevm/loadvm and migration. That will be one create-surface command per surface and one cursor-set command for the local pointer. The worker-save/load functions are not needed any more.

[Spice-devel] [PATCH 11/35] new watch api: switch main channel

2010-05-12 Thread Gerd Hoffmann
--- server/reds.c | 40 +--- 1 files changed, 21 insertions(+), 19 deletions(-) diff --git a/server/reds.c b/server/reds.c index 959e4dd..73d53f3 100644 --- a/server/reds.c +++ b/server/reds.c @@ -364,7 +364,6 @@ typedef struct PingItem { static uint8_t

[Spice-devel] [PATCH 35/35] zap MigrationInterface

2010-05-12 Thread Gerd Hoffmann
Remove remaining MigrationInterface bits. --- server/reds.c | 16 server/vd_interface.h | 11 --- 2 files changed, 0 insertions(+), 27 deletions(-) diff --git a/server/reds.c b/server/reds.c index 6275cf0..a09cb0d 100644 --- a/server/reds.c +++

[Spice-devel] [PATCH 05/35] zap qterm interfaces

2010-05-12 Thread Gerd Hoffmann
old way to handle monitor, obsolete. --- server/reds.c | 688 - server/vd_interface.h | 50 2 files changed, 0 insertions(+), 738 deletions(-) diff --git a/server/reds.c b/server/reds.c index dd8034c..a9767ad 100644 ---

[Spice-devel] [PATCH 32/35] zap migration code

2010-05-12 Thread Gerd Hoffmann
Drop all code which depends on accessing the migration file handle. --- server/reds.c | 642 + server/vd_interface.h |7 +- 2 files changed, 11 insertions(+), 638 deletions(-) diff --git a/server/reds.c b/server/reds.c index

Re: [Spice-devel] [PATCH 20/35] VDInterface: redesign.

2010-05-17 Thread Gerd Hoffmann
Hi, +if (interface-major_version != VD_INTERFACE_NET_WIRE_MAJOR || +interface-minor_version VD_INTERFACE_NET_WIRE_MINOR) { +red_printf(unsuported net wire interface); +return -1; +} +red_tunnel = red_tunnel_attach(core, net_wire);

Re: [Spice-devel] [PATCH 28/35] vdi port: redesign.

2010-05-17 Thread Gerd Hoffmann
Hi, -while (reds-agent_state.plug_ref != INVALID_VD_OBJECT_REF) { +sif = SPICE_CONTAINEROF(vdagent-base.sif, SpiceVDIPortInterface, base); +for (;;) { Changing a while to for(;;;) doesn't seem right. We can still hit: read_from_vdi_port()- dispatch_vdi_port_data()- default:

Re: [Spice-devel] [PATCH 28/35] vdi port: redesign.

2010-05-18 Thread Gerd Hoffmann
Hi, I'm not sure how that should be done. My main dislike of the current interface is that it forces either a copy from the driver to an intermediate, like the code I had checked in, or it forces spice-server to consume everything it gets. No, it isn't all or nothing. You can delay the

Re: [Spice-devel] [PATCH 28/35] vdi port: redesign.

2010-05-18 Thread Gerd Hoffmann
Yes, you need an additional interface for throttle/unthrottle then. Works too. I don't mind much which way we pick. Two notes: * I need to check with virtio-serial, but it seems to me that when we throttle we should be able to access the pointer provided by havedata. I don't think

[Spice-devel] [PATCH] add QXL_SURF_FLAG_KEEP_DATA

2010-05-18 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- spice/qxl_dev.h |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/spice/qxl_dev.h b/spice/qxl_dev.h index 80e5e08..6182953 100644 --- a/spice/qxl_dev.h +++ b/spice/qxl_dev.h @@ -155,7 +155,9 @@ typedef struct

[Spice-devel] [PATCH 00/39] libspice-server api patch series

2010-05-18 Thread Gerd Hoffmann
Hi, Next version. Also available here: http://cgit.freedesktop.org/~kraxel/spice/log/?h=api.v7 Changes: * misc tweaks according to review comments. * also convert tunnel interface to the new api. * drop vd_interface.h, move bits over to spice.h * create spice-experimental.h

[Spice-devel] [PATCH 04/39] zap CoreInterface-(un)register_change_notifiers()

2010-05-18 Thread Gerd Hoffmann
spice_server_add_interface() and spice_server_remove_interface() can be used instead. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- server/reds.c |4 server/vd_interface.h |4 2 files changed, 0 insertions(+), 8 deletions(-) diff --git a/server/reds.c b/server

[Spice-devel] [PATCH 02/39] channel security cleanup

2010-05-18 Thread Gerd Hoffmann
- drop spice_channel_name_t enum, use spice-protocol defines instead. - switch spice_server_set_channel_security() channel parameter from enum to string. - drop spice_server_set_default_channel_security(), use spice_server_set_channel_security with channel == NULL instead. Signed-off-by: Gerd

[Spice-devel] [PATCH 08/39] introduce new watch api

2010-05-18 Thread Gerd Hoffmann
(someone sayed QemuIONotifier?) this will break horribly. Beside that it is very bad style. Follwing patches will switch over users one by one to the new interface and finally zap the old one. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- server/vd_interface.h | 11 +++ 1 files

[Spice-devel] [PATCH 11/39] new watch api: switch main channel

2010-05-18 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- server/reds.c | 40 +--- 1 files changed, 21 insertions(+), 19 deletions(-) diff --git a/server/reds.c b/server/reds.c index 80f5fca..6a21d6e 100644 --- a/server/reds.c +++ b/server/reds.c @@ -364,7 +364,6

[Spice-devel] [PATCH 12/39] new watch api: switch ssl accept

2010-05-18 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- server/reds.c | 24 +++- 1 files changed, 19 insertions(+), 5 deletions(-) diff --git a/server/reds.c b/server/reds.c index 6a21d6e..e50ae63 100644 --- a/server/reds.c +++ b/server/reds.c @@ -491,7 +491,12 @@ static int

[Spice-devel] [PATCH 13/39] new watch api: switch inputs

2010-05-18 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- server/reds.c | 50 +- 1 files changed, 25 insertions(+), 25 deletions(-) diff --git a/server/reds.c b/server/reds.c index e50ae63..cd4fd57 100644 --- a/server/reds.c +++ b/server/reds.c

[Spice-devel] [PATCH 06/39] zap CoreInterface-{term_printf,log}

2010-05-18 Thread Gerd Hoffmann
Was used to print stuff to the qemu monitor. Fundamentally incompatible with QMP. Remove. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- server/reds.c | 48 +--- server/vd_interface.h |4 2 files changed, 5 insertions(+), 47

[Spice-devel] [PATCH 07/39] fix visibility

2010-05-18 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- server/reds.c | 50 ++ server/reds.h |2 ++ 2 files changed, 28 insertions(+), 24 deletions(-) diff --git a/server/reds.c b/server/reds.c index 88f6a72..50753c0 100644 --- a/server/reds.c

[Spice-devel] [PATCH 09/39] new watch api: switch listening sockets

2010-05-18 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- server/reds.c | 34 -- 1 files changed, 20 insertions(+), 14 deletions(-) diff --git a/server/reds.c b/server/reds.c index 50753c0..8ce07a0 100644 --- a/server/reds.c +++ b/server/reds.c @@ -245,6 +245,8

[Spice-devel] [PATCH 10/39] new watch api: switch liasync read

2010-05-18 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- server/reds.c | 24 +++- server/reds.h |1 + 2 files changed, 12 insertions(+), 13 deletions(-) diff --git a/server/reds.c b/server/reds.c index 8ce07a0..80f5fca 100644 --- a/server/reds.c +++ b/server/reds.c @@ -298,7

[Spice-devel] [PATCH 14/39] new watch api: switch migration

2010-05-18 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- server/reds.c | 59 + 1 files changed, 30 insertions(+), 29 deletions(-) diff --git a/server/reds.c b/server/reds.c index cd4fd57..6f5957f 100644 --- a/server/reds.c +++ b/server/reds.c

[Spice-devel] [PATCH 05/39] zap qterm interfaces

2010-05-18 Thread Gerd Hoffmann
old way to handle monitor, obsolete. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- server/reds.c | 688 - server/vd_interface.h | 50 2 files changed, 0 insertions(+), 738 deletions(-) diff --git a/server/reds.c b/server

[Spice-devel] [PATCH 15/39] new watch api: switch sound

2010-05-18 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- server/snd_worker.c | 32 +--- 1 files changed, 21 insertions(+), 11 deletions(-) diff --git a/server/snd_worker.c b/server/snd_worker.c index 66dc856..d5f5f37 100644 --- a/server/snd_worker.c +++ b/server

[Spice-devel] [PATCH 19/39] shlib major

2010-05-18 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- configure.ac |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure.ac b/configure.ac index 94cd65f..0958b6d 100644 --- a/configure.ac +++ b/configure.ac @@ -26,7 +26,7 @@ AC_PROG_LIBTOOL AM_PROG_CC_C_O

[Spice-devel] [PATCH 29/39] kill spice_server_set_mouse_absolute

2010-05-18 Thread Gerd Hoffmann
Not needed. Just register/unregister the tablet interface instead. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- server/reds.c |9 - server/spice.h |2 -- 2 files changed, 0 insertions(+), 11 deletions(-) diff --git a/server/reds.c b/server/reds.c index 01f610d..9b42cbf

[Spice-devel] [PATCH 17/39] new watch api: kill old api

2010-05-18 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- server/reds.c |2 -- server/vd_interface.h |5 - 2 files changed, 0 insertions(+), 7 deletions(-) diff --git a/server/reds.c b/server/reds.c index 6f5957f..ff90f5d 100644 --- a/server/reds.c +++ b/server/reds.c @@ -494,8

[Spice-devel] [PATCH 23/39] MouseInterface: redesign

2010-05-18 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- server/reds.c | 30 -- server/reds.h |4 server/vd_interface.h | 25 - 3 files changed, 40 insertions(+), 19 deletions(-) diff --git a/server/reds.c b/server

[Spice-devel] [PATCH 18/39] minor timer interface cleanups.

2010-05-18 Thread Gerd Hoffmann
Make the timer interface largely look like the watch interface. Simliar naming convention for the functions (timer_*) and a opaque SpiceTimer type. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- server/red_tunnel_worker.c |5 ++--- server/reds.c | 40

[Spice-devel] [PATCH 16/39] new watch api: switch channels

2010-05-18 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- server/red_channel.c | 41 - 1 files changed, 20 insertions(+), 21 deletions(-) diff --git a/server/red_channel.c b/server/red_channel.c index dbfbd42..3f46147 100644 --- a/server/red_channel.c +++ b

[Spice-devel] [PATCH 27/39] constify SpiceBaseInterface

2010-05-18 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- server/reds.c |4 ++-- server/vd_interface.h |2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/server/reds.c b/server/reds.c index a5e6c1b..71ce409 100644 --- a/server/reds.c +++ b/server/reds.c @@ -4039,7

[Spice-devel] [PATCH 37/39] vd_interface.h cleanups.

2010-05-18 Thread Gerd Hoffmann
Drop leftover bits which are not used any more. Rename DrawArea to QXLDrawArea. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- server/reds.c | 16 server/snd_worker.c |2 -- server/vd_interface.h | 39 +++ 3 files changed

[Spice-devel] [PATCH 34/39] migration: new api

2010-05-18 Thread Gerd Hoffmann
Add new API for migration, based on what RHEL-6 has. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- server/reds.c | 107 ++--- server/spice.h| 12 + server/vd_interface.h |7 --- 3 files changed, 87 insertions(+), 39

[Spice-devel] [PATCH 36/39] NetWireInterface: redesign

2010-05-18 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- server/red_tunnel_worker.h |2 +- server/reds.c | 14 -- server/reds.h |4 server/vd_interface.h | 29 + 4 files changed, 30 insertions(+), 19 deletions

[Spice-devel] [PATCH 22/39] KeyboardInterface: redesign.

2010-05-18 Thread Gerd Hoffmann
to SpiceKbdInterface, for other interfaces this very likely will be different. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- server/reds.c | 74 server/reds.h |4 ++ server/spice.h|2 +- server/vd_interface.h

[Spice-devel] [PATCH 39/39] add spice-experimental.h

2010-05-18 Thread Gerd Hoffmann
Supposed to be used for work-in-progress bits, where interfaces are not finalized yet. Moved over vdi port interface, tunnel interface and spice client migration functions. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- server/Makefile.am |2 + server/red_tunnel_worker.h

[Spice-devel] [PATCH 33/39] [debug] migration troubleshooting

2010-05-18 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- client/application.cpp |2 +- server/reds.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/client/application.cpp b/client/application.cpp index 4eb8ac8..74f5543 100644 --- a/client/application.cpp +++ b

[Spice-devel] [PATCH 28/39] vdi port: redesign.

2010-05-18 Thread Gerd Hoffmann
. That implies that we need support for multiple channels all the way through the stack ... Signed-off-by: Gerd Hoffmann kra...@redhat.com --- server/reds.c | 95 - server/vd_interface.h | 33 + 2 files changed, 71 insertions

[Spice-devel] [PATCH 30/39] surface: keep metadata (aka create command) in device memory.

2010-05-18 Thread Gerd Hoffmann
. This in turn makes it alot easier for qemu to handle savevm/loadvm. It just needs to do some minimal command parsing and maintain pointers to the create commands for the active surfaces. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- server/red_worker.c | 35

[Spice-devel] [PATCH 24/39] QXL: redesign.

2010-05-18 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- server/red_dispatcher.c | 36 ++-- server/red_dispatcher.h |2 +- server/red_worker.c | 38 +++--- server/red_worker.h |2 +- server/reds.c | 20

[Spice-devel] [PATCH 35/39] zap MigrationInterface

2010-05-18 Thread Gerd Hoffmann
Remove remaining MigrationInterface bits. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- server/reds.c | 16 server/vd_interface.h | 11 --- 2 files changed, 0 insertions(+), 27 deletions(-) diff --git a/server/reds.c b/server/reds.c index 3c832b5

[Spice-devel] [PATCH 26/39] SoundInterfaces: redesign

2010-05-18 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- server/reds.c | 30 +- server/snd_worker.c | 160 server/snd_worker.h |8 +- server/vd_interface.h | 84 +- 4 files changed, 141 insertions

Re: [Spice-devel] cannot boot from virtio / no -qxl option

2010-05-19 Thread Gerd Hoffmann
Hi, -when the disk is set to virtio, I can install F13, but boot fails (at bios stage). When I set it to IDE then, it starts OK Upstream qemu simply doesn't support that (yet). There have been seabios patches floating around which should fix this though, so this should improve soon.

Re: [Spice-devel] cannot boot from virtio / no -qxl option

2010-05-19 Thread Gerd Hoffmann
-when the disk is set to virtio, I can install F13, but boot fails (at bios stage). When I set it to IDE then, it starts OK Upstream qemu simply doesn't support that (yet). I'm quite surprised, I have others vms (running with normal qemu from virt-preview repo for F13), that boot without

Re: [Spice-devel] cannot boot from virtio / no -qxl option

2010-05-19 Thread Gerd Hoffmann
On 05/19/10 13:12, Frédéric Grelot wrote: Well, there is upstream qemu and there is qemu-kvm which carries additional patches (including extboot which handles booting from virtio). fedora ships qemu-kvm ... I can confirm that my other vms run with qemu-kvm. Does this difference also explains

Re: [Spice-devel] cannot boot from virtio / no -qxl option

2010-05-20 Thread Gerd Hoffmann
qxl driver is here: http://cgit.freedesktop.org/xorg/driver/xf86-video-qxl/ and corresponds to the one that get shipped with fedora 13? Yes. experimental bits are here: http://cgit.freedesktop.org/~sandmann/xf86-video-qxl/log/?h=surface0 and *should* work with qemu-unstable-spice from

Re: [Spice-devel] cannot boot from virtio / no -qxl option

2010-05-21 Thread Gerd Hoffmann
Hi, Well, it didn't seem to boot though... However, when I installed it, the disk was ide, I then installed the drivers (by adding a second drive in virtio mode), switched the main drive to virtio and restarted. I already did that a few time ago and it worked... I'm currently trying to

Re: [Spice-devel] cannot boot from virtio / no -qxl option

2010-05-25 Thread Gerd Hoffmann
On 05/24/10 01:59, Frédéric Grelot wrote: Hi List Gerd, Your driver (the rpm that appeared on the repository) doesn't want to work... I know, didn't found the time yet to investigate ... By the way, I made winxp and win7 work with spice without much trouble, but is it normal that there is

Re: [Spice-devel] virtio windows xp driver problems with spice

2010-06-16 Thread Gerd Hoffmann
Hi, Gerd, I can use virtio perfectly well with qemu-kvm, so it's quite possible there are bugs in spice. Is there any debug information I can provide that would make it easier to diagnose the fault? qemu-kvm uses a completely different way for virtio boot than upstream qemu (which

Re: [Spice-devel] Demarshaller work landed on master

2010-06-21 Thread Gerd Hoffmann
On 06/18/10 21:37, Alexander Larsson wrote: After a lot of work I finally got the marshaller/demarshaller work in a state where its interesting for others to look at and test. It works in my testing on both linux and win32, between both pre-marshaller versions (both ways) and between

Re: [Spice-devel] Demarshaller work landed on master

2010-06-21 Thread Gerd Hoffmann
Hi, This is one of the items pretty high on my priority list as it needs to be done for 0.4 compatibility for guest drivers ... The plan is to do this soon, its obviously the next step in making this really work. There is some initial work in bugzilla at:

[Spice-devel] [PATCH 3/6] qxl abi: parse QXLAlphaBlnd (+Compat)

2010-06-23 Thread Gerd Hoffmann
--- server/red_parse_qxl.c | 23 +-- 1 files changed, 21 insertions(+), 2 deletions(-) diff --git a/server/red_parse_qxl.c b/server/red_parse_qxl.c index aafd75a..cbdbf72 100644 --- a/server/red_parse_qxl.c +++ b/server/red_parse_qxl.c @@ -20,6 +20,23 @@ #include

[Spice-devel] [PATCH 0/6] initial qxl abi patches

2010-06-23 Thread Gerd Hoffmann
struct parser should call get_virt(). cheers, Gerd Gerd Hoffmann (6): qxl abi: parse QXLDrawable. qxl abi: parse QXLCompatDrawable. qxl abi: parse QXLAlphaBlnd (+Compat) qxl abi: parse QXLFill. qxl abi: parse QXLOpaque. qxl abi: add missing QXLCopyBits common/canvas_base.c |4

[Spice-devel] [PATCH 0/8] mingw32 build

2010-07-08 Thread Gerd Hoffmann
Hi, This is a series of patches to make spice client buildable with the mingw32 compiler. Compiles fine. Doesn't work yet, dunno why, maybe some magic compiler switch missing, any ideas are welcome ... Gerd Hoffmann (8): build: alsa is needed on linux only. build: only check for x11

[Spice-devel] [PATCH 6/8] mingw32 build: -fvisibility test needs refinement, disable for now

2010-07-08 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- configure.ac |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index 9b88c3d..8daee82 100644 --- a/configure.ac +++ b/configure.ac @@ -348,9 +348,9 @@ error Need GCC 4.0 for visibility int

[Spice-devel] [PATCH 3/8] build: use jpeg_boolean with more recent libjpeg versions.

2010-07-08 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- client/jpeg_decoder.cpp |6 +- client/mjpeg_decoder.cpp |6 +- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/client/jpeg_decoder.cpp b/client/jpeg_decoder.cpp index a7824a9..f5a0198 100644 --- a/client

[Spice-devel] [PATCH 7/8] mingw32 build: disable ms compiler pragmas for gcc

2010-07-08 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- client/common.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/client/common.h b/client/common.h index c0ce442..0a8e082 100644 --- a/client/common.h +++ b/client/common.h @@ -36,9 +36,11 @@ #include winsock2.h

[Spice-devel] [PATCH 5/8] mingw32 build: add client/windows/Makefile, tweak configure

2010-07-08 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- client/windows/Makefile.am | 195 configure.ac | 13 +++- 2 files changed, 206 insertions(+), 2 deletions(-) create mode 100644 client/windows/Makefile.am diff --git a/client

Re: [Spice-devel] [PATCH 3/3] Fix corrupted ram data (e.g., release_ring), and unsynchronized worker, after driver is disabled and re-enabled.

2010-07-12 Thread Gerd Hoffmann
On 07/12/10 11:15, Yonit Halperin wrote: On logoff in Win7 guest, and on switch user and login into Winxp guest, the driver is disabled and re-enabled (while the miniport in not reset). However, before the fix, all the draw objects, e.g., surfaces, were still alive in the worker and the release

Re: [Spice-devel] Build Win 32 client for kraxel.fedorapeople.org

2010-08-04 Thread Gerd Hoffmann
On 08/04/10 06:50, bwellsnc wrote: I am trying to build the win32 client under Visual Studio C++ express 2010. I am curious if anyone has built this for windows and if so, how can this be down by a non visual studio user. I am not interested in building the qxl drivers or anything else, I want

Re: [Spice-devel] Build Win 32 client for kraxel.fedorapeople.org

2010-08-05 Thread Gerd Hoffmann
On 08/05/10 04:16, bwellsnc wrote: I tried using mingw32-configure in the spice-0.5.2 directory and I get this error: checking for PROTOCOL... configure: error: Package requirements (spice-protocol) were not met: I have the spice-protocol package installed along with the

Re: [Spice-devel] [PATCH] spice: vdagent: add basic clipboard support

2010-08-18 Thread Gerd Hoffmann
On 08/18/10 14:15, Alexander Larsson wrote: On Mon, 2010-08-09 at 12:58 +0300, Arnon Gilboa wrote: From: Arnon Gilboaagil...@agilboa.usersys.redhat.com -currently supports text only (UTF8) -add VDAgent::dispatch_message() -in VDAgent::read_completion() handle multi-chunk msgs -fix chunk size

Re: [Spice-devel] [PATCH] vdservice: don't start when no qxl device present

2010-08-24 Thread Gerd Hoffmann
On 08/24/10 13:57, Alon Levy wrote: From 349e6a5bf8804b25c3af6e1f439122a7cc269cc2 Mon Sep 17 00:00:00 2001 From: Alon Levyal...@redhat.com Date: Tue, 24 Aug 2010 14:53:03 +0300 Subject: [PATCH] vdservice: don't start when no qxl device present Point being? The display configuration bits are

Re: [Spice-devel] [RFC 1/2] spice, server: introduce SpiceCharDevice

2010-08-25 Thread Gerd Hoffmann
Hi, -__visible__ void spice_server_vdi_port_wakeup(SpiceVDIPortInstance *sin) +__visible__ void spice_server_vdi_port_wakeup(SpiceCharDeviceInstance *sin) This should be renamed too. Also please make a separate patch which does the pure vdiport - chardevice renaming. +__visible__ int

[Spice-devel] [PATCH 4/5] zap dead typedefs

2010-08-26 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- server/red_worker.c |5 - 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index 17bbf6f..1975597 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -522,11 +522,6

[Spice-devel] [PATCH 3/5] zap dead qxl chunk code

2010-08-26 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- server/red_worker.c | 29 - 1 files changed, 0 insertions(+), 29 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index f525f17..17bbf6f 100644 --- a/server/red_worker.c +++ b/server/red_worker.c

Re: [Spice-devel] [PATCH 3/5] zap dead qxl chunk code

2010-08-27 Thread Gerd Hoffmann
On 08/27/10 08:41, Alexander Larsson wrote: On Fri, 2010-08-27 at 00:09 +0200, Gerd Hoffmann wrote: Signed-off-by: Gerd Hoffmannkra...@redhat.com --- server/red_worker.c | 29 - 1 files changed, 0 insertions(+), 29 deletions(-) Actually, you can get rid

Re: [Spice-devel] [PATCH 1/1] Add API to turn on backwards compatibility mode

2010-08-27 Thread Gerd Hoffmann
Hi, This API allows qemu to limit the set of features that spice uses to those compatible with an older version, in order to do an upgrade like this. Right now it doesn't really do much, since we don't keep compat with 0.4.0 atm (although that may be added later). As you are talking about

Re: [Spice-devel] [PATCH 3/5] zap dead qxl chunk code

2010-08-27 Thread Gerd Hoffmann
On 08/27/10 08:56, Alexander Larsson wrote: On Fri, 2010-08-27 at 08:49 +0200, Gerd Hoffmann wrote: On 08/27/10 08:41, Alexander Larsson wrote: On Fri, 2010-08-27 at 00:09 +0200, Gerd Hoffmann wrote: Signed-off-by: Gerd Hoffmannkra...@redhat.com --- server/red_worker.c | 29

Re: [Spice-devel] [PATCH 1/1] Add API to turn on backwards compatibility mode

2010-08-27 Thread Gerd Hoffmann
As you are talking about set of features already ... I think we should use a feature bitmask instead of a version number in the API. How would you use this in qemu though? Say you link to spice 0.10.0, which has a set of new features not in 0.8.0. Why would you want to make a spice instance

[Spice-devel] [PATCH] Add config functions.

2010-08-27 Thread Gerd Hoffmann
A bunch of configuration functions where never ported forward from rhel-6 to upstream. Add them so we can add qemu config options for these settings. --- server/reds.c | 27 +++ server/spice.h | 11 +++ 2 files changed, 38 insertions(+), 0 deletions(-) diff

Re: [Spice-devel] [PATCH 1/1] Add API to turn on backwards compatibility mode

2010-08-27 Thread Gerd Hoffmann
Hi, Having a more fine-grained command line feature selection just causes complexity and risk that sysadmins get things wrong. I don't see any gain in it. Point. I'll note that this switch is really only about migration compatibility. Any reason to add this now? We could delay it until

Re: [Spice-devel] [PATCH 1/1] Add API to turn on backwards compatibility mode

2010-08-30 Thread Gerd Hoffmann
On 08/27/10 19:42, Alexander Larsson wrote: On Fri, 2010-08-27 at 17:28 +0200, Gerd Hoffmann wrote: Hi, Having a more fine-grained command line feature selection just causes complexity and risk that sysadmins get things wrong. I don't see any gain in it. Point. I'll note that this switch

[Spice-devel] [PATCH] Bump versions.

2010-08-30 Thread Gerd Hoffmann
Update #define in server/spice.h in preparation for the 0.6.0 release. We also got some new functions, thus we have to increate the shared lib minor number for spice-server. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- configure.ac |2 +- server/spice.h |2 +- 2 files changed, 2

  1   2   3   4   5   6   7   8   >