Re: [Spice-devel] Getting patchwork to acknowledge acks?

[Uri Lublin]

On 08/04/2017 03:52 PM, Christophe de Dinechin wrote:



On 4 Aug 2017, at 14:49, Victor Toso  wrote:

On Fri, Aug 04, 2017 at 02:34:44PM +0200, Christophe de Dinechin wrote:

If I look at a patch I sent, then I have a button and also a “delegate to” pop 
up.
One of the choices is pw-git-hook. What does that mean?



pw is a command line tool, you could apply a series with something like
git pw apply-series 3837 (series-id)

Not sure about pw-git-hook.


Sounds like a git hook to update patchwork when
patches are pushed.

https://github.com/getpatchwork/patchwork/blob/master/tools/post-receive.hook

Uri.
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel

Re: [Spice-devel] Getting patchwork to acknowledge acks?

[Christophe de Dinechin]

> On 4 Aug 2017, at 14:49, Victor Toso  wrote:
> 
> On Fri, Aug 04, 2017 at 02:34:44PM +0200, Christophe de Dinechin wrote:
>> 
>>> On 4 Aug 2017, at 14:03, Frediano Ziglio  wrote:
>>> 
 
 Hi,
 
 On Fri, Aug 04, 2017 at 01:01:05PM +0200, Christophe de Dinechin wrote:
>> It does not check if given patch was pushed, no. :(
> 
> If so, that’s a lot less useful than PRs.
 
 All comes down to workflow in the end... Some people love it :)
 https://patchwork.linuxtv.org/
 
>>> 
>>> The missing synchronization with git was discussed already on
>>> our ML thread, both patchew and patchwork share this missing
>>> feature.
>> 
>> I love the phrasing “share this missing feature” ;-)
>> 
>>> 
>>> Not saying that patchwork have few interesting feature, indeed.
>>> Just don't have this. Mostly patchew add CI feature (as far as
>>> I saw). Just today I was wondering why this CI feature was
>>> not implemented on top of patchwork instead of having another
>>> tool.
>> 
>> I wonder if patchwork is not supposed to have at least some testing
>> capabilities. There is a “Test” menu on 
>> https://patchwork.freedesktop.org/project/Spice/series.
> 
> For..  Tested-by: Victor Toso 
> :)

Oh, I see. Manual CI it is then ;-) 

How does it know about the “pass/fail/info/warning”?

> 
>> Anyway, let me answer the question about the “Done” state.
>> Apparently, you can only change the state for a patch *you* submitted.
>> So the “state” button for the patch I referred to earlier does not show up,
>> presumably because only Pavel can change it.
> 
> I think anyone from Spice group in freedesktop can, manually, change it.

Ah, I may have made the mistake of creating another account on patchwork.
So I guess I’m supposed to reuse my freedesktop account?

> 
>> If I look at a patch I sent, then I have a button and also a “delegate to” 
>> pop up.
>> One of the choices is pw-git-hook. What does that mean?
>> 
>> Thanks
>> Christophe
> 
> pw is a command line tool, you could apply a series with something like
> git pw apply-series 3837 (series-id)
> 
> Not sure about pw-git-hook.

If you don’t know, who knows?…


Thanks
Christophe

> 

___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel

Re: [Spice-devel] Getting patchwork to acknowledge acks?

[Victor Toso]

On Fri, Aug 04, 2017 at 02:34:44PM +0200, Christophe de Dinechin wrote:
> 
> > On 4 Aug 2017, at 14:03, Frediano Ziglio  wrote:
> > 
> >> 
> >> Hi,
> >> 
> >> On Fri, Aug 04, 2017 at 01:01:05PM +0200, Christophe de Dinechin wrote:
>  It does not check if given patch was pushed, no. :(
> >>> 
> >>> If so, that’s a lot less useful than PRs.
> >> 
> >> All comes down to workflow in the end... Some people love it :)
> >> https://patchwork.linuxtv.org/
> >> 
> > 
> > The missing synchronization with git was discussed already on
> > our ML thread, both patchew and patchwork share this missing
> > feature.
> 
> I love the phrasing “share this missing feature” ;-)
> 
> > 
> > Not saying that patchwork have few interesting feature, indeed.
> > Just don't have this. Mostly patchew add CI feature (as far as
> > I saw). Just today I was wondering why this CI feature was
> > not implemented on top of patchwork instead of having another
> > tool.
> 
> I wonder if patchwork is not supposed to have at least some testing
> capabilities. There is a “Test” menu on 
> https://patchwork.freedesktop.org/project/Spice/series.

For..  Tested-by: Victor Toso 
:)

> Anyway, let me answer the question about the “Done” state.
> Apparently, you can only change the state for a patch *you* submitted.
> So the “state” button for the patch I referred to earlier does not show up,
> presumably because only Pavel can change it.

I think anyone from Spice group in freedesktop can, manually, change it.

> If I look at a patch I sent, then I have a button and also a “delegate to” 
> pop up.
> One of the choices is pw-git-hook. What does that mean?
>
> Thanks
> Christophe

pw is a command line tool, you could apply a series with something like
git pw apply-series 3837 (series-id)

Not sure about pw-git-hook.



signature.asc
Description: PGP signature
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel

Re: [Spice-devel] Getting patchwork to acknowledge acks?

[Christophe de Dinechin]

> On 4 Aug 2017, at 14:03, Frediano Ziglio  wrote:
> 
>> 
>> Hi,
>> 
>> On Fri, Aug 04, 2017 at 01:01:05PM +0200, Christophe de Dinechin wrote:
 It does not check if given patch was pushed, no. :(
>>> 
>>> If so, that’s a lot less useful than PRs.
>> 
>> All comes down to workflow in the end... Some people love it :)
>> https://patchwork.linuxtv.org/
>> 
> 
> The missing synchronization with git was discussed already on
> our ML thread, both patchew and patchwork share this missing
> feature.

I love the phrasing “share this missing feature” ;-)

> 
> Not saying that patchwork have few interesting feature, indeed.
> Just don't have this. Mostly patchew add CI feature (as far as
> I saw). Just today I was wondering why this CI feature was
> not implemented on top of patchwork instead of having another
> tool.

I wonder if patchwork is not supposed to have at least some testing
capabilities. There is a “Test” menu on 
https://patchwork.freedesktop.org/project/Spice/series.

Anyway, let me answer the question about the “Done” state.
Apparently, you can only change the state for a patch *you* submitted.
So the “state” button for the patch I referred to earlier does not show up,
presumably because only Pavel can change it.

If I look at a patch I sent, then I have a button and also a “delegate to” pop 
up.
One of the choices is pw-git-hook. What does that mean?


Thanks
Christophe
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel

Re: [Spice-devel] Getting patchwork to acknowledge acks?

[Frediano Ziglio]

> 
> Hi,
> 
> On Fri, Aug 04, 2017 at 01:01:05PM +0200, Christophe de Dinechin wrote:
> > > It does not check if given patch was pushed, no. :(
> >
> > If so, that’s a lot less useful than PRs.
> 
> All comes down to workflow in the end... Some people love it :)
> https://patchwork.linuxtv.org/
> 

The missing synchronization with git was discussed already on
our ML thread, both patchew and patchwork share this missing
feature.

Not saying that patchwork have few interesting feature, indeed.
Just don't have this. Mostly patchew add CI feature (as far as
I saw). Just today I was wondering why this CI feature was
not implemented on top of patchwork instead of having another
tool.

Frediano
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel

Re: [Spice-devel] Getting patchwork to acknowledge acks?

[Victor Toso]

Hi,

On Fri, Aug 04, 2017 at 01:01:05PM +0200, Christophe de Dinechin wrote:
> > It does not check if given patch was pushed, no. :(
>
> If so, that’s a lot less useful than PRs.

All comes down to workflow in the end... Some people love it :)
https://patchwork.linuxtv.org/



signature.asc
Description: PGP signature
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel

Re: [Spice-devel] Getting patchwork to acknowledge acks?

[Christophe de Dinechin]

> On 4 Aug 2017, at 12:48, Victor Toso  wrote:
> 
> Hi,
> 
> On Fri, Aug 04, 2017 at 12:42:39PM +0200, Christophe de Dinechin wrote:
>> During the discussion on PRs and stuff, several people pointed to
>> patchwork.
>> 
>> Does anyone know why this tool does not acknowledge acks? For example
>> https://patchwork.freedesktop.org/series/27298/ has a "Acked-by:
>> Christophe de Dinechin ” in the fifth comment,
>> and has been merged as 4cdd6e07d3f7ec07dccfa11c12099cb45ac60d3d. Yet
>> it’s still marked as “New” by patchwork.
> 
> It parses the acked-by and does +1 per-patch
> https://patchwork.freedesktop.org/project/Spice/patches/

It does not seem too smart about it though. I wrote “can’t ack right now”, and 
it apparently counted that as a second “ack” :-D

> 
> That`s the only automated feature that it does, afaik.
> 
>> There are a few series marked as “Done”:
>> https://patchwork.freedesktop.org/project/Spice/series/?ordering=-last_updated.
>> For example, this one https://patchwork.freedesktop.org/series/25980/
>> was marked as “Done”. It’s recent (June 19). Christophe, did you
>> explicitly mark it as “Done”, or is some fuzzy parser in patchwork
>> smart enough to parse your "I've now pushed this upstream” comment?
>> 
>> Christophe
> 
> It does not check if given patch was pushed, no. :(

If so, that’s a lot less useful than PRs.


Christophe
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel

Re: [Spice-devel] Getting patchwork to acknowledge acks?

[Victor Toso]

Hi,

On Fri, Aug 04, 2017 at 12:42:39PM +0200, Christophe de Dinechin wrote:
> During the discussion on PRs and stuff, several people pointed to
> patchwork.
>
> Does anyone know why this tool does not acknowledge acks? For example
> https://patchwork.freedesktop.org/series/27298/ has a "Acked-by:
> Christophe de Dinechin ” in the fifth comment,
> and has been merged as 4cdd6e07d3f7ec07dccfa11c12099cb45ac60d3d. Yet
> it’s still marked as “New” by patchwork.

It parses the acked-by and does +1 per-patch
https://patchwork.freedesktop.org/project/Spice/patches/

That`s the only automated feature that it does, afaik.

> There are a few series marked as “Done”:
> https://patchwork.freedesktop.org/project/Spice/series/?ordering=-last_updated.
> For example, this one https://patchwork.freedesktop.org/series/25980/
> was marked as “Done”. It’s recent (June 19). Christophe, did you
> explicitly mark it as “Done”, or is some fuzzy parser in patchwork
> smart enough to parse your "I've now pushed this upstream” comment?
>
> Christophe

It does not check if given patch was pushed, no. :(


signature.asc
Description: PGP signature
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel

[Spice-devel] Getting patchwork to acknowledge acks?

[Christophe de Dinechin]

During the discussion on PRs and stuff, several people pointed to patchwork.

Does anyone know why this tool does not acknowledge acks? For example 
https://patchwork.freedesktop.org/series/27298/ has a "Acked-by: Christophe de 
Dinechin ” in the fifth comment, and has been merged as 
4cdd6e07d3f7ec07dccfa11c12099cb45ac60d3d. Yet it’s still marked as “New” by 
patchwork.

There are a few series marked as “Done”: 
https://patchwork.freedesktop.org/project/Spice/series/?ordering=-last_updated. 
For example, this one https://patchwork.freedesktop.org/series/25980/ was 
marked as “Done”. It’s recent (June 19). Christophe, did you explicitly mark it 
as “Done”, or is some fuzzy parser in patchwork smart enough to parse your 
"I've now pushed this upstream” comment?


Christophe
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel