Re: [SlimDevices: SqueezeCenter] Spaces in Player names?
Thanks Paul Good grief - I wouldn't have the first idea how to code this little workaround. As you say, the consequences on different types of player might be different, and this restriction was obviously put there for a reason. I would guess that the 'setd' doesn't only handle player name changes, so it would be wise to restrict the change such that it only affects 'squeezelite' players, and only refers to name changes. I could see it taking me a week or more just to get to grips with the perl syntax and scratch the surface of the LMS structure. I think I'll just leave it, and live with the fact that squeezelite on the Joggler is behaving as programmed. On the other hand, whilst I can understand that it might be best to limit this type of communication while a player is playing, I wonder if it's really necessary for it to be explicitly 'stopped'. It seems like it might be just as safe to send this 'setd' while the player is paused, which is a much more common condition for a software player without a stop button. Paul Webster wrote: > > Michael probably best advisor on the though. Agreed. chill's Profile: http://forums.slimdevices.com/member.php?userid=10839 View this thread: http://forums.slimdevices.com/showthread.php?t=110157 ___ Squeezecenter mailing list Squeezecenter@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/squeezecenter
Re: [SlimDevices: SqueezeCenter] Spaces in Player names?
slim/player/squeezebox2.pm
Code:
# Only send a setd packet to the player if it is stopped and we are not
# still waiting for a response to a previous setd packet for this pref
if ( $client->controller() && $client->isStopped() && !($status &
SETD_WAITING) ) {
my $data = pack('C'.$currpref->{pack}, $currpref->{firmwareid}, $value);
$client->sendFrame('setd', \$data);
# We are now waiting for a response to this setd call
$client->pendingPrefChanges()->{$pref} = SETD_WAITING;
}
else {
# we can't update the pref's while playing, cache this change for later
$isInfo && $prefslog->info("Pending change for $pref");
# Mark this pref as pending, will be sent to the player later
$client->pendingPrefChanges()->{$pref} |= SETD_PENDING;
}
}
I think that an issue with changing it will be verifying the change
across the range of devices and situations ... so perhaps if removing
the check on being stopped then add other checks that limit which
hardware/software players that it will be sent to to include only those
that are readily testable.
Michael probably best advisor on the though.
Paul Webster
http://dabdig.blogspot.com
Author Radio France (FIP etc) plugin
Paul Webster's Profile: http://forums.slimdevices.com/member.php?userid=105
View this thread: http://forums.slimdevices.com/showthread.php?t=110157
___
Squeezecenter mailing list
Squeezecenter@lists.slimdevices.com
http://lists.slimdevices.com/mailman/listinfo/squeezecenter
Re: [SlimDevices: SqueezeCenter] Spaces in Player names?
After a quick test it looks as though you've solved the mystery Paul. Name changes get saved back to the specified file when the player is stopped. It's not enough to pause the player, or to (soft) power it off while playing or paused - it has to be explicitly stopped. Name changes also seem to get saved while the player is (soft) off, provided it was stopped first. I can't believe that I didn't spot this pattern in all my testing, but in my defence the browser interface doesn't have 'stop' function that I can see, and it's not obvious in the Jivelite interface - it takes a long press on the pause button to stop the player. I wonder if this 'stopped' condition really needs to be present. Paul - could you point me to the relevant bit of the source code and I might have a go at lifting that restriction to see what the consequences are. chill's Profile: http://forums.slimdevices.com/member.php?userid=10839 View this thread: http://forums.slimdevices.com/showthread.php?t=110157 ___ Squeezecenter mailing list Squeezecenter@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/squeezecenter
Re: [SlimDevices: SqueezeCenter] Spaces in Player names?
Paul Webster wrote: > > One thing I saw on the LMS side is that this is not sent while the > player is active - so try a name change while the player is stopped. > It looks like it queues up the info to be sent later in that case but I > did not work through that to see if it works. > Thanks Paul - that could be the key. With Jivelite running on the Joggler I can see the player name at the top of the screen, and this changes almost immediately when I change the name in LMS. But I do think that all my testing has been while squeezelite has been running*, so maybe the command isn't being sent to squeezelite itself. That might explain the 'occasional' success that I had. Will test that this evening. * I've been playing with making the Joggler autostart squeezelite at boot if it was running when the Joggler was shut down. I'm finally starting to get my head around lua settings files/menu operation/scripting/greping/awking.. chill's Profile: http://forums.slimdevices.com/member.php?userid=10839 View this thread: http://forums.slimdevices.com/showthread.php?t=110157 ___ Squeezecenter mailing list Squeezecenter@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/squeezecenter
Re: [SlimDevices: SqueezeCenter] Spaces in Player names?
I just had a quick look at bits of code. It is the setd slimproto command (as shown in your captured debug info). One thing I saw on the LMS side is that this is not sent while the player is active - so try a name change while the player is stopped. It looks like it queues up the info to be sent later in that case but I did not work through that to see if it works. Also - it is for firmware settings updating ... is there a chance that Squeezelite is not recognised as a device with firmware? (I did not check for that) Paul Webster http://dabdig.blogspot.com Author Radio France (FIP etc) plugin Paul Webster's Profile: http://forums.slimdevices.com/member.php?userid=105 View this thread: http://forums.slimdevices.com/showthread.php?t=110157 ___ Squeezecenter mailing list Squeezecenter@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/squeezecenter
Re: [SlimDevices: SqueezeCenter] Spaces in Player names?
I found the -d option in squeezelite, and captured some debug information. I can see where squeezelite is getting the name from the file, and where it then sets the name immediately afterwards: Code: root@openframe:~# /root/squeezelite/bin/squeezelite -v -d all=debug -o sysdefault:CARD=MID -N /root/squeezelite/bin/PlayerName -m 00:0e:8e:24:ce:36 [09:13:04.047426] stream_init:294 init stream . . . [09:13:09.275626] discover_server:795 got response from: 192.168.1.46:3483 [09:13:09.276186] *slimproto:858 retrieved name Joggler from /root/squeezelite/bin/PlayerName* [09:13:09.276556] slimproto:883 connecting to 192.168.1.46:3483 . . . [09:13:09.319463] process:514 setd [09:13:09.319661] *sendSETDName:238 set playername: Joggler* [09:13:09.319806] process:514 setd But when I then change the name in LMS there doesn't seem to be any sign of that coming back to squeezelite. chill's Profile: http://forums.slimdevices.com/member.php?userid=10839 View this thread: http://forums.slimdevices.com/showthread.php?t=110157 ___ Squeezecenter mailing list Squeezecenter@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/squeezecenter
Re: [SlimDevices: SqueezeCenter] Spaces in Player names?
ralphy wrote: > I've been using the -N option for ages, well really since Triode added > it back in Dec 2013 and I've never noticed that behaviour. > I usually populate the file with the playername when I first add the -N > option and I don't change player names very often. > Permissions could be the issue updating the -N file if squeezelite is > not running as root however squeezelite will log that with an 'unable to > store new name in file' warning. I'm struggling with this, and it's frustrating, given that it was working when I first tried it. @ralphy - that warning message, do I need to enable logging/debugging somehow in squeezelite? Just running it from from a terminal with ... Code: squeezelite -v -o sysdefault:CARD=MID -N /root/squeezelite/bin/JogglerPlayerName -m 00:0e:8e:24:ce:36 ... gives me no feedback at all. It's definitely taking the startup player name from the file, but name changes in LMS aren't getting back to the file, despite apparently being applied within the LMS interface. I'm running squeezelite as the root user (for now), but I've also tried changing the permissions of the named file to 777, as well as the folder it sits in. Any tips to investigate this would be appreciated. chill's Profile: http://forums.slimdevices.com/member.php?userid=10839 View this thread: http://forums.slimdevices.com/showthread.php?t=110157 ___ Squeezecenter mailing list Squeezecenter@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/squeezecenter
Re: [SlimDevices: SqueezeCenter] Spaces in Player names?
plus, as in this case, to get around bugs in some software/scripts that do handle spaces in player names very well. Paul Webster http://dabdig.blogspot.com Author Radio France (FIP etc) plugin Paul Webster's Profile: http://forums.slimdevices.com/member.php?userid=105 View this thread: http://forums.slimdevices.com/showthread.php?t=110157 ___ Squeezecenter mailing list Squeezecenter@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/squeezecenter
Re: [SlimDevices: SqueezeCenter] Spaces in Player names?
My understanding - if you launch the player with a -N filename where the named local file has a player name in it then that is the name that the player will give to LMS when it connects. If you then change the name of the player from LMS web interface (etc) then LMS will tell the player itÂ’s new name and the player should store it back into the named local file. Paul Webster http://dabdig.blogspot.com Author Radio France (FIP etc) plugin Paul Webster's Profile: http://forums.slimdevices.com/member.php?userid=105 View this thread: http://forums.slimdevices.com/showthread.php?t=110157 ___ Squeezecenter mailing list Squeezecenter@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/squeezecenter
Re: [SlimDevices: SqueezeCenter] Spaces in Player names?
chill wrote: > Are there any conditions that have to be met for this to work? I'm > pretty sure that when I first tried this after you posted that comment > it was working as expected - name changes would update the file could you get an old man up to the task? I am using squeezelite since the early days but i cant follow the -*the*- in "name changes would update -*the*- file." Do you mean the server.prefs in your lms DJanGo's Profile: http://forums.slimdevices.com/member.php?userid=1516 View this thread: http://forums.slimdevices.com/showthread.php?t=110157 ___ Squeezecenter mailing list Squeezecenter@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/squeezecenter
Re: [SlimDevices: SqueezeCenter] Spaces in Player names?
I've been using the -N option for ages, well really since Triode added it back in Dec 2013 and I've never noticed that behaviour. I usually populate the file with the playername when I first add the -N option and I don't change player names very often. Permissions could be the issue updating the -N file if squeezelite is not running as root however squeezelite will log that with an 'unable to store new name in file' warning. Ralphy *1*-Touch, *5*-Classics, *3*-Booms, *1*-UE Radio 'Squeezebox client builds' (https://sourceforge.net/projects/lmsclients/files/) 'donations' (https://www.paypal.com/cgi-bin/webscr?cmd=_donations=LL5P6365KQEXN=CA_name=Squeezebox%20client%20builds_code=USD=PP%2dDonationsBF%3abtn_donate_SM%2egif%3aNonHosted) always appreciated. ralphy's Profile: http://forums.slimdevices.com/member.php?userid=3484 View this thread: http://forums.slimdevices.com/showthread.php?t=110157 ___ Squeezecenter mailing list Squeezecenter@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/squeezecenter
Re: [SlimDevices: SqueezeCenter] Spaces in Player names?
Hmmm - this is odd. -Some- changes seem to get through, -eventually-. Haven't spotted a pattern yet - might be after a reboot, or restarting LMS. I'm pretty sure it was instant when I first tried it though. chill's Profile: http://forums.slimdevices.com/member.php?userid=10839 View this thread: http://forums.slimdevices.com/showthread.php?t=110157 ___ Squeezecenter mailing list Squeezecenter@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/squeezecenter
Re: [SlimDevices: SqueezeCenter] Spaces in Player names?
ralphy wrote: > > With -N you can set/change the name from LMS and squeezelite updates the > file with the new name. Are there any conditions that have to be met for this to work? I'm pretty sure that when I first tried this after you posted that comment it was working as expected - name changes would update the file. I tried files in various locations on the server, and didn't have to do anything special with file permissions/ownership etc. But I noticed today that any name changes entered via LMS are not updating the file. The only thing I can think of that might have changed is that I rebuilt Jivelite with the visualisations option (the only 'extra' build option that I specified). Could I have inadvertently missed out another build option? The '-N' option is still listed by --help, and evidently the filename is still being taken from that file, but changes are not being stored there. My squeezelite command is: Code: squeezelite -v -o sysdefault:CARD=MID -N /root/squeezelite/bin/PlayerName -m 00 0e 8e 24 ce 36 -z (I issued the command with colons in the MAC address - this text is copied from the output of 'ps aux') I'm running squeezelite as the root user. chill's Profile: http://forums.slimdevices.com/member.php?userid=10839 View this thread: http://forums.slimdevices.com/showthread.php?t=110157 ___ Squeezecenter mailing list Squeezecenter@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/squeezecenter
Re: [SlimDevices: SqueezeCenter] Spaces in Player names?
I do use my LMS players in home automation and I even added a space (and extra word) to make it easier. For example ... I had LMS player called "Kitchen" but changed it to "Kitchen Radio" to help distinguish it from lights in the kitchen. Paul Webster http://dabdig.blogspot.com Author Radio France (FIP etc) plugin Paul Webster's Profile: http://forums.slimdevices.com/member.php?userid=105 View this thread: http://forums.slimdevices.com/showthread.php?t=110157 ___ Squeezecenter mailing list Squeezecenter@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/squeezecenter
Re: [SlimDevices: SqueezeCenter] Spaces in Player names?
Paul Webster wrote: > Joke question ... can the filename have spaces in it? If you ever want to use a control device outside of lms - like a Homeautomation - you will remove that space ;-) So better not to use it in the first place DJanGo's Profile: http://forums.slimdevices.com/member.php?userid=1516 View this thread: http://forums.slimdevices.com/showthread.php?t=110157 ___ Squeezecenter mailing list Squeezecenter@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/squeezecenter
Re: [SlimDevices: SqueezeCenter] Spaces in Player names?
ralphy wrote: > > > With -N you can set/change the name from LMS and squeezelite updates the > file with the new name. This is a really neat feature - it means that squeezelite can be started up with an unchanging command string, but any name changes persist. I've been playing with it on the Joggler build I've been working on and it works perfectly. chill's Profile: http://forums.slimdevices.com/member.php?userid=10839 View this thread: http://forums.slimdevices.com/showthread.php?t=110157 ___ Squeezecenter mailing list Squeezecenter@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/squeezecenter
Re: [SlimDevices: SqueezeCenter] Spaces in Player names?
ralphy wrote: > The best way to define the player name for squeezelite is the -N command > line option. > > > Code: > > -N Store player name in filename to allow server defined name changes to be shared between servers (not supported with -n) > > > > > With -N you can set/change the name from LMS and squeezelite updates > the file with the new name. Joke question ... can the filename have spaces in it? Paul Webster http://dabdig.blogspot.com Author Radio France (FIP etc) plugin Paul Webster's Profile: http://forums.slimdevices.com/member.php?userid=105 View this thread: http://forums.slimdevices.com/showthread.php?t=110157 ___ Squeezecenter mailing list Squeezecenter@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/squeezecenter
Re: [SlimDevices: SqueezeCenter] Spaces in Player names?
The best way to define the player name for squeezelite is the -N command line option. Code: -N Store player name in filename to allow server defined name changes to be shared between servers (not supported with -n) Ralphy *1*-Touch, *5*-Classics, *3*-Booms, *1*-UE Radio 'Squeezebox client builds' (https://sourceforge.net/projects/lmsclients/files/) 'donations' (https://www.paypal.com/cgi-bin/webscr?cmd=_donations=LL5P6365KQEXN=CA_name=Squeezebox%20client%20builds_code=USD=PP%2dDonationsBF%3abtn_donate_SM%2egif%3aNonHosted) always appreciated. ralphy's Profile: http://forums.slimdevices.com/member.php?userid=3484 View this thread: http://forums.slimdevices.com/showthread.php?t=110157 ___ Squeezecenter mailing list Squeezecenter@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/squeezecenter
Re: [SlimDevices: SqueezeCenter] Spaces in Player names?
The player name is described as being human readable and the example in the docs contains a space - as indeed does the default name for some Squeezebox devices Code: player name ? The "player name ?" query returns the human-readable name for the specified player. If the name has not been specified by the user in the Player Settings, then a default name will be used, usually the IP address. Example: Request: "player name 0 ?" or "0 player name ?" Response: "player name 0 Living Room" Avoiding the use of spaces may well be convenient and perhaps even sidesteps some bugs but it is not essential. Paul Webster http://dabdig.blogspot.com Author Radio France (FIP etc) plugin Paul Webster's Profile: http://forums.slimdevices.com/member.php?userid=105 View this thread: http://forums.slimdevices.com/showthread.php?t=110157 ___ Squeezecenter mailing list Squeezecenter@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/squeezecenter
Re: [SlimDevices: SqueezeCenter] Spaces in Player names?
Manul wrote: > I'm not sure whether this is a server or client question: When I > configure my squeezelite player with a name containing a space, it > doesn't show up in LMS 7.9.2. Is this a general restriction with LMS, a > setup problem with squeezelite or just my incompetence? Since lms is a "internet" thing you should match the "internet" name requests. No Umlauts, no spaces, no dots, no underlines DJanGo's Profile: http://forums.slimdevices.com/member.php?userid=1516 View this thread: http://forums.slimdevices.com/showthread.php?t=110157 ___ Squeezecenter mailing list Squeezecenter@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/squeezecenter
Re: [SlimDevices: SqueezeCenter] Spaces in Player names?
I'm currently running squeezelite on 2 Raspberry Pis. One is running OSMC, but the other is currently running squeezelite exclusively on a regular Raspbian install. If that ever breaks I might give piCorePlayer a try, thanks for the suggestion. Manul's Profile: http://forums.slimdevices.com/member.php?userid=68932 View this thread: http://forums.slimdevices.com/showthread.php?t=110157 ___ Squeezecenter mailing list Squeezecenter@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/squeezecenter
Re: [SlimDevices: SqueezeCenter] Spaces in Player names?
Manul wrote: > > Edit: I'm not using pCP, I don't even know what that is. Should I? Yes. ;) Manul wrote: > I've worked around that by passing the -N option to squeezelite and > putting the name in a file. That works. And ^that is the solution to the 'spaces in names' problem with additional players configured in the 'tweaks' section of pCP. Marvellous, I didn't know that option existed, thank you. I now have 'Lounge DAC' instead of 'Lounge_DAC'. Much neater. chill's Profile: http://forums.slimdevices.com/member.php?userid=10839 View this thread: http://forums.slimdevices.com/showthread.php?t=110157 ___ Squeezecenter mailing list Squeezecenter@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/squeezecenter
Re: [SlimDevices: SqueezeCenter] Spaces in Player names?
Manul wrote: > > Edit: I'm not using pCP, I don't even know what that is. Should I? Pre-req is a Raspberry Pi. If you are running on a regular computer then this could save you on noise, power and space. Paul Webster http://dabdig.blogspot.com Author Radio France (FIP etc) plugin Paul Webster's Profile: http://forums.slimdevices.com/member.php?userid=105 View this thread: http://forums.slimdevices.com/showthread.php?t=110157 ___ Squeezecenter mailing list Squeezecenter@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/squeezecenter
Re: [SlimDevices: SqueezeCenter] Spaces in Player names?
Thanks to both of you! Turns out I didn't look closely enough: The problem wasn't that squeezelite didn't show up in LMS but that it didn't start at all. I'm running squeezelite from the Debian Buster package. This gets started by an auto-generated systemd unit that starts the included BSD startup script that in turn reads some defaults from a file. Somewhere along that way, any attempt of escaping the space or enclosing it in quotes I tried got lost and consequently squeezelite got called as "squeezelite -n two words" and choked on the second word. I've worked around that by passing the -N option to squeezelite and putting the name in a file. That works. Thanks again for putting me on the right track! Edit: I'm not using pCP, I don't even know what that is. Should I? Manul's Profile: http://forums.slimdevices.com/member.php?userid=68932 View this thread: http://forums.slimdevices.com/showthread.php?t=110157 ___ Squeezecenter mailing list Squeezecenter@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/squeezecenter
Re: [SlimDevices: SqueezeCenter] Spaces in Player names?
Manul wrote: > I'm not sure whether this is a server or client question: When I > configure my squeezelite player with a name containing a space, it > doesn't show up in LMS 7.9.2. Is this a general restriction with LMS, a > setup problem with squeezelite or just my incompetence? Where and how are you running Squeezelite? >From the command line, this works: Code: /usr/local/bin/squeezelite -n "Squeezelite player" But this doesn't: Code: /usr/local/bin/squeezelite -n Squeezelite player If you're using pCP, then the main Squeezelite instance can have a name with spaces in, because pCP encloses the name that you enter in double quotes. But if you're trying to run a second instance via the 'Tweaks' page, then the name does not get enclosed in quotes, and you can't manually include quotes, so you'll have to remove the spaces, e.g. Code: /usr/local/bin/squeezelite -n Squeezelite_player -o front:CARD=Set,DEV=0 chill's Profile: http://forums.slimdevices.com/member.php?userid=10839 View this thread: http://forums.slimdevices.com/showthread.php?t=110157 ___ Squeezecenter mailing list Squeezecenter@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/squeezecenter
Re: [SlimDevices: SqueezeCenter] Spaces in Player names?
I'm not sure whether this is a server or client question: When I configure my squeezelite player with a name containing a space, it doesn't show up in LMS 7.9.2. Is this a general restriction with LMS, a setup problem with squeezelite or just my incompetence? I'd say it's a setup problem with squeezelite. SB players by default would have been called "Squeezebox 2", "Squeezebox Boom" etc. -- Michael ___ Squeezecenter mailing list Squeezecenter@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/squeezecenter
[SlimDevices: SqueezeCenter] Spaces in Player names?
I'm not sure whether this is a server or client question: When I configure my squeezelite player with a name containing a space, it doesn't show up in LMS 7.9.2. Is this a general restriction with LMS, a setup problem with squeezelite or just my incompetence? Manul's Profile: http://forums.slimdevices.com/member.php?userid=68932 View this thread: http://forums.slimdevices.com/showthread.php?t=110157 ___ Squeezecenter mailing list Squeezecenter@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/squeezecenter
