Re: offline_mode

2008-04-04 Thread Adrian Chadd
I think its something that should be better fleshed out, yes. There's probably bigger fish to fry in the codebase though. Adrian On Sat, Apr 05, 2008, Amos Jeffries wrote: > Bug 1356 brings up some confusion over what the true meaning of > 'offline' is for this option. > > As Henrik pointed

client-side delay pools

2008-04-02 Thread Adrian Chadd
G'day, One of the items in my commercial work queue is client-side delay pools. The client wishes to restrict the throughput of certain items - hit or miss - back to the client. They're currently using Squid-2.6.18 and are probably going to upgrade to Squid-2.7 once its released. I have a tentati

Re: s2_delaywork ready for commit

2008-04-01 Thread Adrian Chadd
On Wed, Apr 02, 2008, Henrik Nordstrom wrote: > ons 2008-04-02 klockan 07:22 +0800 skrev Adrian Chadd: > > Try http://www.creative.net.au/diffs/s2_delaywork.diff . > > Looks better. > > No comments. Looks ready to merge. Ok. Its committed to Squid-2.HEAD. I might go thro

Re: s2_delaywork ready for commit

2008-04-01 Thread Adrian Chadd
Try http://www.creative.net.au/diffs/s2_delaywork.diff . Adrian On Wed, Apr 02, 2008, Henrik Nordstrom wrote: > > tis 2008-04-01 klockan 21:31 +0800 skrev Adrian Chadd: > > G'day, > > > > I believe this phase of the delay pools ACL and statistics work is ready &g

Re: TPROXY support in Squid 3

2008-04-01 Thread Adrian Chadd
On Mon, Mar 31, 2008, Alex Rousskov wrote: > What about Adrian plans (if I understood them correctly) to add > TPROXY-like support to FreeBSD but not for TPROXY4-like API? Is that a > good enough reason to continue supporting unsupported TPROXY versions? The FreeBSD API will be almost like the TP

tproxy-4 integration into squid-2

2008-04-01 Thread Adrian Chadd
G'day, I'm looking at Gonzalo's Squid-2 + TPROXY-4 patch in bugzilla (1581) and it doesn't seem all that difficult to integrate TPROXY-4 support. It won't make it in time for 2.7 (whenever that last outstanding bug is fixed) but I'd like to make it in for 2.8. There are a few core things to integ

s2_delaywork ready for commit

2008-04-01 Thread Adrian Chadd
G'day, I believe this phase of the delay pools ACL and statistics work is ready for commit to Squid-2. I've shuffled around the configuration file changes a bit and used PRIu64 for printf(). http://www.creative.net.au/diff/s2_delaywork.diff I'll commit it to Squid-2.HEAD this weekend if noone ha

Re: comm_connect_addr broke in squid3/trunk?

2008-04-01 Thread Adrian Chadd
On Tue, Apr 01, 2008, Amos Jeffries wrote: > >I've made a test patch to fix that: > > http://treenet.co.nz/projects/squid/patches/alex-20080401.patch > > > >Though I am not sure if the "#if defined(sin_len)" will work properly. Can > >you try it with and without those lines please before you roll

Re: Delay pools work: delayed pool assignment ACL; statistics

2008-03-31 Thread Adrian Chadd
On Mon, Mar 31, 2008, Henrik Nordstrom wrote: > m??n 2008-03-31 klockan 00:11 +0800 skrev Adrian Chadd: > > > I'll commit this work to 2.HEAD, 2.7 and 2.6 in a week or so. > > 2.HEAD ok. as always for anything reasonably sane in shape. > > 2.7 not sure. Would

Re: TPROXY support in Squid 3

2008-03-31 Thread Adrian Chadd
On Tue, Apr 01, 2008, Amos Jeffries wrote: > Between Balabit and TreeNet we have come up with a working TPROXY 4+ patch. > > It'll be sent to trunk soon. > > The merge It would be a whole lot cleaner and actually less change > overall if we could drop the TPROXY version 2 support from Squid-3. >

Re: Delay pools work: delayed pool assignment ACL; statistics

2008-03-30 Thread Adrian Chadd
On Mon, Mar 31, 2008, Amos Jeffries wrote: > > I need to figure out a clean way of printing unsigned 64 bit ints in a > > reasonably > > platform portable method. Does anyone have any ideas? > > Squid-3 uses: %"PRId64" Yeah, Squid-2 does too. Its for signed ints though, and that isn't what I'm

Delay pools work: delayed pool assignment ACL; statistics

2008-03-30 Thread Adrian Chadd
Hi, I've tidied up kikov's patch implementing delayed pool assignments for delay pools and I've included statistics for aggregate and network bucket bytes transferred. The statistics stuff works fine. It breaks on reconfigure ; but apparently delay pools breaks on reconfigure. I'll try to sort th

delay pools statistics

2008-03-30 Thread Adrian Chadd
G'day, One of my Squid contracts includes throwing some basic statistics gathering into the delay pools code, and I'd like to export these stats via SNMP. What do people think the SNMP OID hierarchy should look like for the delay pools configuration and runtime statistics? Thanks, Adrian --

Re: 3.1 steps forward

2008-03-27 Thread Adrian Chadd
On Tue, Mar 25, 2008, Amos Jeffries wrote: > >have you fixed the AddrInfo leak? :) > > > > Fixed. Are you still creating/destroying individual addrinfo structs when doing socket operations? Adrian -- - Xenion - http://www.xenion.com.au/ - VPS Hosting - Commercial Squid Support - - $25/pm en

Re: [MERGE] Replace a URN handling set of gotos' with a sub-function.

2008-03-25 Thread Adrian Chadd
Is there any way to get this stuff to post an actual diff rather than this bundle? Adrian On Tue, Mar 25, 2008, Amos Jeffries wrote: > Replace a URN handling set of gotos' with a sub-function. > # Bazaar merge directive format 2 (Bazaar 0.90) > # revision_id: [EMAIL PROTECTED] > # target_branc

Re: Valgrind results

2008-03-23 Thread Adrian Chadd
On Mon, Mar 24, 2008, Amos Jeffries wrote: > >Thats cool. There's just bigger fish to fry. :) > > Like why '--with-valgrind' doesn't enable the initialisation code > somebody already added to squid for those minor ones > > Trying leakfinder + valgrind now. Heh, valgrind makes it mostly eas

Re: Valgrind results

2008-03-23 Thread Adrian Chadd
On Mon, Mar 24, 2008, Amos Jeffries wrote: > Adrian Chadd wrote: > >You can ignore that. If you care that much about the epoll error then > >just bzero() the data being passed into epoll_ctl() before its called. > I care about every potential cause of trouble in squid. Particu

Re: Valgrind results

2008-03-23 Thread Adrian Chadd
You can ignore that. If you care that much about the epoll error then just bzero() the data being passed into epoll_ctl() before its called. adrian On Mon, Mar 24, 2008, Amos Jeffries wrote: > Just doing a quick check with valgrind I'm seeing a lot of errors in the > event system. > > "Syscal

Re: Features/LogDaemon

2008-03-18 Thread Adrian Chadd
On Tue, Mar 18, 2008, Alex Rousskov wrote: > On Tue, 2008-03-18 at 18:54 -0600, Adrian Chadd wrote: > > Uhm, I'll do it Amos. It won't take me that long. > > > > I'll wait for your source organisation to be completed before I bring over > > the >

Re: [Squid Web Proxy Wiki] Update of "Features/LogDaemon" by Amos Jeffries

2008-03-18 Thread Adrian Chadd
Uhm, I'll do it Amos. It won't take me that long. I'll wait for your source organisation to be completed before I bring over the changes. Adrian On Tue, Mar 18, 2008, [EMAIL PROTECTED] wrote: > Dear Wiki user, > > You have subscribed to a wiki page or wiki category on "Squid Web Proxy Wiki"

Re: tcp proxy hackery

2008-03-18 Thread Adrian Chadd
http://www.creative.net.au/diffs/test1-355.tar.gz I've fixed the last few bugs - I'm seeing some occasional connect() failures from the ab box to the proxy server but that may be the hacky apachebench code. I can handle ~ 12,000 proxied connections a second at 96 byte replies. Userland CPU use s

Re: tcp proxy hackery

2008-03-17 Thread Adrian Chadd
On Tue, Mar 18, 2008, Henrik Nordstrom wrote: > Does it? Most mallocs I know about has details about the allocated > region just before the pointer (and optional red zone). http://people.freebsd.org/~jasone/jemalloc/bsdcan2006/jemalloc.pdf Small allocations are segregated such that each ru

Re: tcp proxy hackery

2008-03-17 Thread Adrian Chadd
On Tue, Mar 18, 2008, Henrik Nordstrom wrote: > On Mon, 2008-03-17 at 13:37 +1100, Robert Collins wrote: > > it matter if process all the request on one CPU, or part on one part on > > another? Given NUMA it clearly does matter, but how many folk run > > squid/want to run squid on a NUMA machines?

Re: [squid-users] Caching files from Amazon S3

2008-03-16 Thread Adrian Chadd
On Mon, Mar 17, 2008, Robert Collins wrote: > > I've looked at the -3 stuff, and its missing about as much as the -2 > > stuff is missing. The memory store is only a small part of the overall > > problem handling sparse objects. > > > > (Unless there's some code I've missed that handles other ran

Re: tcp proxy hackery

2008-03-16 Thread Adrian Chadd
On Mon, Mar 17, 2008, Robert Collins wrote: > This reminds me, one of the things I was thinking heavily about a few > years ago was locality of reference in N-CPU situations. That is, making > sure we don't cause thrashing unnecessarily. For instance - given > chunking we can't really avoid seeing

Re: [squid-users] Caching files from Amazon S3

2008-03-16 Thread Adrian Chadd
On Mon, Mar 17, 2008, Robert Collins wrote: > On Sun, 2008-03-16 at 14:04 +0900, Adrian Chadd wrote: > > Annoyingly, why the hell is the request from the client a range request? > > Squid can't easily cache those unless it somehow fetches the entire object > > first. >

Re: tcp proxy hackery

2008-03-16 Thread Adrian Chadd
On Mon, Mar 17, 2008, Adrian Chadd wrote: > Benchmarking allocators is easy. Benchmarking allocators in real-world > situations > is less easy. The whole point of this work is to provide the minimum code > needed > to provide efficient(!) HTTP proxy services which can then be b

Re: tcp proxy hackery

2008-03-16 Thread Adrian Chadd
On Mon, Mar 17, 2008, Robert Collins wrote: > > It maxes out on my kit at the above speed; but at 32k replies it hits 3100 > > req/sec > > and close to a gigabit. I'll whack a recent linux distro+kernel on the test > > boxes > > in a few days and see how it compares. > > Sounds like its going w

Re: tcp proxy hackery

2008-03-16 Thread Adrian Chadd
On Wed, Mar 12, 2008, Adrian Chadd wrote: > I'm able to push this to about 5000 req/sec, 8000 concurrent client > connections > (so 16,000 concurrent TCP connections on the proxy) @ ~ 335mbit full-duplex > on my > test setup. I'm not maxing out anything yet as my

bzr commit stuff?

2008-03-13 Thread Adrian Chadd
Has anyone actually committed to the bzr tree? I haven't seen any commit messages. adrian

Re: tcp proxy hackery

2008-03-12 Thread Adrian Chadd
On Sat, Mar 08, 2008, Adrian Chadd wrote: > Nothing terribly fancy; very, very ugly and not very well laid out; but > cut #1 of a simple TCP proxy that I'm using for toying around with network > IO benchmarking: > > http://www.creative.net.au/diffs/test1-320.tar.gz > >

Squid-2.7 release notes updated

2008-03-12 Thread Adrian Chadd
I've updated the Squid-2.7 release notes. I'd like to release Squid-2.7.STABLE1 this weekend. Its possible my Bugzilla searches haven't turned up all of the relevant bugs to put in the release notes. Let me know if you have any objections. Thanks, Adrian -- - Xenion - http://www.xenion.com.a

Re: tcp proxy hackery

2008-03-10 Thread Adrian Chadd
On Sat, Mar 08, 2008, Adrian Chadd wrote: > Nothing terribly fancy; very, very ugly and not very well laid out; but > cut #1 of a simple TCP proxy that I'm using for toying around with network > IO benchmarking: > > http://www.creative.net.au/diffs/test1-320.tar.gz > >

tcp proxy hackery

2008-03-07 Thread Adrian Chadd
Nothing terribly fancy; very, very ugly and not very well laid out; but cut #1 of a simple TCP proxy that I'm using for toying around with network IO benchmarking: http://www.creative.net.au/diffs/test1-320.tar.gz Edit Makefile.defaults to point to where libevent is hiding, and then 'make'. The

Re: TProxy support

2008-03-05 Thread Adrian Chadd
On Wed, Mar 05, 2008, Laszlo Attila Toth wrote: > Hm. I don't know what would be the best way, because I am not familiar > with the squid code. What I know is: TProxy4 requires minimal code > change. My problem is: where to change and how to use ifdef-ed codes > (LINUX_TPROXY and the two new: L

Re: TProxy support

2008-03-05 Thread Adrian Chadd
On Wed, Mar 05, 2008, Laszlo Attila Toth wrote: > >There's a patch in the Squid bugzilla somewhere which implements tproxy > >support against Squid-2. I'd like to include this into Squid-2, but: > > I know this patch, mine is based on it. But that is for tproxy 4.0 not > 4.1... Ok. > >* So wha

Re: TProxy support

2008-03-05 Thread Adrian Chadd
On Wed, Mar 05, 2008, Laszlo Attila Toth wrote: > Hello, > > We only supports TProxy version 4.1 but in the squid "--enable-tproxy" > requires version 2 which is obsolete for a while. G'day, There's a patch in the Squid bugzilla somewhere which implements tproxy support against Squid-2. I'd lik

Google SOC 2008: Mentor Requests

2008-03-04 Thread Adrian Chadd
G'day, Participation in the Google SOC this year was discussed at the London meetup last week. We'd love to - there's lots of interesting stuff to kick to students! - but the problem we have is time. Noone participating in the discussion was able to commit enough time (10+ hours a week) to proper

Re: cleanup squid3/src dlink.cc,NONE,1.1.2.1 AuthConfig.h,1.3.26.1,1.3.26.2 AuthUser.cci,1.3,1.3.26.1 AuthUser.h,1.6.4.2,1.6.4.3 Makefile.am,1.138.2.7,1.138.2.8 client_side_reply.cc,1.125.2.2,1.125.2.

2008-03-03 Thread Adrian Chadd
Eventually you will want to either use these types outside of src/ or replace them with the BSD list macros. I'd suggest splitting it up into something under the top level dir, rather than under src/, to avoid having to shift it twice. Stick the bulk of the dlink routines in there, and stuff the

Re: async-calls squid3/src debug.cc,1.18.4.4,1.18.4.5 Debug.h,1.10.4.3,1.10.4.4 main.cc,1.89.4.7,1.89.4.8 structs.h,1.116.4.3,1.116.4.4 cf.data.pre,1.155.4.3,1.155.4.4

2008-02-29 Thread Adrian Chadd
On Mon, Feb 25, 2008, Alex Rousskov wrote: > On Sat, 2008-02-23 at 03:34 -0700, Adrian Chadd wrote: > > Can someone please explain the logic behind this? > > I think I understand, but I'd like to know what people are trying > > to achieve. > > The overall goal is r

Re: Time for squid 3.0 STABLE2 ?

2008-02-27 Thread Adrian Chadd
On Thu, Feb 28, 2008, Amos Jeffries wrote: > >> * Close more bugs? > > Booger: > > stub time| COSS block-size = 512 bytes > stub time| COSS largest file offset = -1 KB > stub time| COSS cache_dir size = 102400 KB > stub time| Fatal: COSS cache_dir size exceeds largest offset > .FAIL: tests/tes

Re: X-Vary-Options patch

2008-02-26 Thread Adrian Chadd
G'day, I'm happy to commit this to Squid-2.HEAD as-is. Can you throw it in a Bugzilla report and spit me the number? Thanks, Adrian On Fri, Feb 08, 2008, Tim Starling wrote: > There are two major sources of suboptimal hit rate on Wikipedia which > relate to the Vary header: > > * In Accept-

Squid-2.HEAD internal URL rewrite support committed

2008-02-26 Thread Adrian Chadd
I just committed Gonzalo's internal URL rewrite support to Squid-2.HEAD. Adrian -- - Xenion - http://www.xenion.com.au/ - VPS Hosting - Commercial Squid Support - - $25/pm entry-level VPSes w/ capped bandwidth charges available in WA -

Re: async-calls squid3/src debug.cc,1.18.4.4,1.18.4.5 Debug.h,1.10.4.3,1.10.4.4 main.cc,1.89.4.7,1.89.4.8 structs.h,1.116.4.3,1.116.4.4 cf.data.pre,1.155.4.3,1.155.4.4

2008-02-23 Thread Adrian Chadd
Can someone please explain the logic behind this? I think I understand, but I'd like to know what people are trying to achieve. Adrian On Sat, Feb 23, 2008, chtsanti wrote: > Update of cvs.devel.squid-cache.org:/cvsroot/squid/squid3/src > > Modified Files: > Tag: async-calls > deb

Re: HEAD squid3/errors/Armenian ERR_ESI,1.1,1.2 ERR_ICAP_FAILURE,1.1,1.2

2008-02-16 Thread Adrian Chadd
On Sat, Feb 16, 2008, Alex Rousskov wrote: > Another SourceForge HEAD commit? Such commits create problems for others > working with SourceForge CVS tree, right? Can we do something > simple/automatic to block these? Yes, there's a script run do to pre-commit checks (like our indent check) that s

Re: cvs commit: squid/src/fs/diskd store_io_diskd.c

2008-02-16 Thread Adrian Chadd
On Sat, Feb 16, 2008, Guido Serassio wrote: > > Bugzilla #761 : Handle recursive completion operations in diskd. > > I think that probably this should be also committed to SQUID_3_0. Yes, once I've looked at how to do it. The code's slightly different.. Adrian

Re: eCAP: expose Squid or link with eCAP lib?

2008-02-16 Thread Adrian Chadd
On Sat, Feb 16, 2008, Tsantilas Christos wrote: > OK, but this is not a requirement, squid3 is enough good without it. And > become better day by day. There is significant progress. > > > I started working on this in my Squid-2 branch; this upset some people. :) > > It is not that it will upset

Re: eCAP: expose Squid or link with eCAP lib?

2008-02-16 Thread Adrian Chadd
On Sat, Feb 16, 2008, Tsantilas Christos wrote: > > Wrapper calls most probably do have some penalties. With increasing > > delays on back-compat wrappers-on-wrappers as time (and changes) go by > > if they are not culled out. > > The wrapper calls normally have a minimal penalty. But depending

Re: eCAP: expose Squid or link with eCAP lib?

2008-02-14 Thread Adrian Chadd
On Fri, Feb 15, 2008, Amos Jeffries wrote: > I'd choose (3). Some of the basic types have clean headers already. > Is it possible to incrementally grow eCAP access to the internals of > squid? Starting with, ie just a buffer of page text, and work the API up? > I mean, we publish the available cl

Re: Squid Hardware

2008-02-14 Thread Adrian Chadd
On Thu, Feb 14, 2008, pokeman wrote: > well today my colleges are discuss about the caching their very long > conversation their is 2 participants I am behalf of squid ??? and others are > from BLUECOAT proxy sg hardware . well I am asking for squid developers > there is any solution on hardware b

Re: 3.1 steps forward

2008-02-14 Thread Adrian Chadd
On Fri, Feb 15, 2008, Amos Jeffries wrote: > Sorry if I was obtuse. I meant that you are the expert on this one. Are > you able to re-locate that mysterious branch and estimate when you will > have time to sync and push it to HEAD? squid3_logdaemon have you fixed the AddrInfo leak? :) Adri

Re: 3.1 steps forward

2008-02-14 Thread Adrian Chadd
On Thu, Feb 14, 2008, Amos Jeffries wrote: > > I'm just checking 3.1 progress maps now that the current big patches are in. > > Adrian: http://wiki.squid-cache.org/Features/LogDaemon > >Can we add a timeline on this now please? > If it requires a push THN will provide a little funding to get

Re: meetup occuring in London

2008-02-12 Thread Adrian Chadd
On Wed, Feb 13, 2008, Amos Jeffries wrote: > If it does prove to be a waste. I'd be happy with a simple recording to > listen to and hear whats discussed after te fact. Thats often easier to > grasp ideas than a written text done after the fact. So, who in the US or Europe wnats to trial out Yaho

Re: meetup occuring in London

2008-02-12 Thread Adrian Chadd
On Wed, Feb 13, 2008, Robert Collins wrote: > > Definitely, especially with the launch of yahoo live!; afaik, there's a > > private online ability with this, which should allow easy interaction > > with sound & video especially with the hookup of a projector at the > > meeting end. > > We've t

Re: meetup occuring in London

2008-02-12 Thread Adrian Chadd
(Only replying to squid-dev) On Wed, Feb 13, 2008, Robert Collins wrote: > Some of the squid developers are going to get together in London during > the weekend of the 1st and 2nd of March. We're still putting together > final details and so on. We'll be talking about much of the current > things

Re: HEAD squid3/src SquidString.h,1.15,1.16 String.cci,1.11,1.12

2008-02-10 Thread Adrian Chadd
On Mon, Feb 11, 2008, Amos Jeffries wrote: > > Oh &^%^%$!! > > Whats the Best way to undo this? > Commit a diff which reverts it? :) Adrian > Amos > > Amos Jeffries wrote: > >Update of cvs.devel.squid-cache.org:/cvsroot/squid/squid3/src > > > >Modified Files: > > SquidString.h String.

Re: two xasserts in squid3

2008-02-10 Thread Adrian Chadd
On Mon, Feb 11, 2008, Amos Jeffries wrote: > > It took me quite a while to get over the "goto is evil, never ever use it" > > koolaid. But then, in C++, you should be using exceptions, not weird > > flow control tricks. :) > > I've never fully subscribed to that generalisation. But the arguments

Re: two xasserts in squid3

2008-02-10 Thread Adrian Chadd
On Mon, Feb 11, 2008, Amos Jeffries wrote: > > I end up with -one- exit location in the function and I don't have to > > bum around using extra functions or massively nested conditional > > constructs to achieve it. In fact, I've used goto in a few places to > > tidy up the code.. > > If you need

Re: two xasserts in squid3

2008-02-10 Thread Adrian Chadd
On Mon, Feb 11, 2008, Amos Jeffries wrote: > FWIW the keyword 'typedef' is as evil in C++ as #define, and only 'goto' > is worse (and completely unnecessary since functional-C deprecated > pascal). Goto is fine. You just need to know how and when to use it. My use of goto in new Squid C code I w

Re: squid-3.HEAD IPAddress leak

2008-02-08 Thread Adrian Chadd
On Sat, Feb 09, 2008, Amos Jeffries wrote: > Correction: I did have online source that were somewhat confusing but > explained the behaviour a little. This seems to be saying what I > remember, http://www.kame.net/newsletter/19980604/ Today's rant: The C standard libraries after about 1995 wer

Re: squid-3.HEAD IPAddress leak

2008-02-07 Thread Adrian Chadd
On Fri, Feb 08, 2008, Amos Jeffries wrote: > sockaddr_storage (as Husni uses, and Adrian mentioned) was created to > provide a better way of using sockaddr* so the sockaddr_in and > sockaddr_in6 bits could be read-written easily. But the big/litte endian > problems between OS screwed up the socka

Re: squid-3.HEAD IPAddress leak

2008-02-07 Thread Adrian Chadd
And which version of debian on which platform is showing the busted behaviour? Adrian On Fri, Feb 08, 2008, Amos Jeffries wrote: > > > > On Thu, 2008-02-07 at 12:21 +0900, Adrian Chadd wrote: > >> > >> Well, I haven't removed the temporary malloc/free pair,

Re: squid-3.HEAD IPAddress leak

2008-02-07 Thread Adrian Chadd
On Fri, Feb 08, 2008, Amos Jeffries wrote: > Try it. You will be horrified. Why? Whats being trashed, AI, or AI->somemember? If AI is being trashed, then just create a temporary pointer copy of AI, use that in the socket call, and then throw it away. if its trashing the memory -at- the AI rather

Re: squid-3.HEAD IPAddress leak

2008-02-07 Thread Adrian Chadd
Have you tried running valgrind? Also, wait. What exactly are you using addr_info for? Can you explain it to me? There's a netural sock addr size type - its called sockaddr_storage. addr_info is for return results from hostname<->ip queries.. Adrian On Fri, Feb 08, 2008, Amos Jeffries wrote:

Re: squid-3.HEAD IPAddress leak

2008-02-07 Thread Adrian Chadd
;) Adrian On Fri, Feb 08, 2008, Amos Jeffries wrote: > > > > On Thu, 2008-02-07 at 12:21 +0900, Adrian Chadd wrote: > >> > >> Well, I haven't removed the temporary malloc/free pair, whatever its > >> called; > >> I've just removed Amos

Re: squid-3.HEAD IPAddress leak

2008-02-06 Thread Adrian Chadd
On Thu, Feb 07, 2008, Robert Collins wrote: > > On Thu, 2008-02-07 at 14:08 +0900, Adrian Chadd wrote: > > On Thu, Feb 07, 2008, Robert Collins wrote: > > > > > > Still, this is one of those "death of a thousand cuts" method of > > > > killing

Re: squid-3.HEAD IPAddress leak

2008-02-06 Thread Adrian Chadd
On Thu, Feb 07, 2008, Robert Collins wrote: > > Still, this is one of those "death of a thousand cuts" method of > > killing performance.. > > Right, I haven't seen the commit; care to mail the diff? Which? I just looked at the places where Amos is calling GetAddrInfo() and FreeAddrInfo(); more

Re: 20080207-squid3-nonzero-buffers.diff

2008-02-06 Thread Adrian Chadd
On Wed, Feb 06, 2008, Alex Rousskov wrote: > Ouch. I did not realize the two ended up in different classes. yeah, neither did I until I started toying with it. > doZeroOnPush has nothing to do with allocation and is not even used by > MemAllocator, but it has to be there and not in MemPool becau

Re: squid-3.HEAD IPAddress leak

2008-02-06 Thread Adrian Chadd
On Thu, Feb 07, 2008, Robert Collins wrote: > > > > I've removed that hack, and things work fine for me. Ubuntu 7.01 here, > > x86_64. > > There's a useful c++ thing called 'placement new' - its used when you > have classes that you want to use on the stack, but still have tight > abstraction bo

Re: squid-3.HEAD IPAddress leak

2008-02-06 Thread Adrian Chadd
On Thu, Feb 07, 2008, Amos Jeffries wrote: > > Amos, could you please poke the leak in IPAddress:GetAddrInfo a little? > > I'll give it another try. But don't hold your breath too long on that one. > > Did you see my note on it? > I tracked that leak backwards from two segfaults to the connect()

Re: squid-3.HEAD IPAddress leak

2008-02-06 Thread Adrian Chadd
On Thu, Feb 07, 2008, Amos Jeffries wrote: > > Amos, could you please poke the leak in IPAddress:GetAddrInfo a little? > > I'll give it another try. But don't hold your breath too long on that one. Why are you trying to allocate the structure on invocation of GetAddrInfo() ? Wouldn't it be bette

Re: squid-3.HEAD IPAddress leak

2008-02-06 Thread Adrian Chadd
On Thu, Feb 07, 2008, Amos Jeffries wrote: > > Amos, could you please poke the leak in IPAddress:GetAddrInfo a little? > > I'll give it another try. But don't hold your breath too long on that one. > > Did you see my note on it? > I tracked that leak backwards from two segfaults to the connect()

Re: 20080207-squid3-nonzero-buffers.diff

2008-02-06 Thread Adrian Chadd
Updated patch: http://www.creative.net.au/diffs/20080207-squid3-nonzero-buffers-2.diff doZeroOnPush can't be private as it then seems to be inaccessible from MemPool::push(). Adrian On Wed, Feb 06, 2008, Alex Rousskov wrote: > Adrian, > > A few comments regarding the nonzero patch you po

squid-3.HEAD IPAddress leak

2008-02-06 Thread Adrian Chadd
Amos, could you please poke the leak in IPAddress:GetAddrInfo a little? Thanks, Adrian ==19601== ==19601== ERROR SUMMARY: 9353 errors from 5 contexts (suppressed: 8 from 2) ==19601== malloc/free: in use at exit: 36,429,514 bytes in 14,790 blocks. ==19601== malloc/free: 114,225 allocs, 99,435

Re: integrating husni's ipv6 patch into squid-2

2008-02-05 Thread Adrian Chadd
On Tue, Feb 05, 2008, Guido Serassio wrote: > >Win2K has NO support so all the required generic libraries need to be > >emulated internally in squid. That had me and Guido spending several weeks > >of go-between locating and adapting code we could use in GPL squid. > > And the work on Squid-3 is

Re: integrating husni's ipv6 patch into squid-2

2008-02-04 Thread Adrian Chadd
On Tue, Feb 05, 2008, Adrian Chadd wrote: > Heck, I've just been handed a "please try to fix diskd, please!" > problem because a vendor is stuck on FreeBSD-4 for the next 12 months. Speaking of which, initial reports show that my bug #761 workaround seems to be working. Is

Re: integrating husni's ipv6 patch into squid-2

2008-02-04 Thread Adrian Chadd
On Tue, Feb 05, 2008, Amos Jeffries wrote: > You mean like all those setups we are trying to convert off 2.5? > Linux <2.6, MacOSX <10.2, Solaris <8, FreeBSD <6.0, NetBSD<2.0, > OpenBSD<3.0 are almost all in that category or have large know problems > with their v6 support. Yeah, and those platfo

Re: integrating husni's ipv6 patch into squid-2

2008-02-04 Thread Adrian Chadd
On Tue, Feb 05, 2008, Amos Jeffries wrote: > You begin to see why I threw out all the initial attempts at IPv6 C-styles. Heh. > Xuan and Rafael spent 4 months on trying squid-3 C-style and never got far > beyond the step-1 you are suggesting starting at. Well, if Step-1 is done and the code is

Re: integrating husni's ipv6 patch into squid-2

2008-02-04 Thread Adrian Chadd
On Mon, Feb 04, 2008, Guido Serassio wrote: > I don't like so much the addition of IPv6 to Squid-2 for two main reasons: > > - This could be a very dangerous thing for the Windows > compatibility, see the impact of the IPv6 merge into Squid-3, even > with the C++ help. Looking at it, XP and l

integrating husni's ipv6 patch into squid-2

2008-02-04 Thread Adrian Chadd
I've been looking at husni's IPv6 patch, and although the implementation is not as clean as amos' stuff, it seems to be relatively straightforward. The changes are roughly as follows: Stuff which can happen with minimal impact to the v4-ness of Squid-2: * in_addr and sockaddr_in -> struct sockad

Re: URIs for accelerators

2008-02-03 Thread Adrian Chadd
On Wed, Jan 23, 2008, Mark Nottingham wrote: > Short version: When an accelerator, Squid tends to omit the port > number from its idea of what the request-URI is. This screws up > logging, helpers, acls, etc. > > See: > http://www.squid-cache.org/bugs/show_bug.cgi?id=2192 Try: http://www.c

squid-2.7 ?

2008-02-03 Thread Adrian Chadd
G'day, Whats left to do before the Squid-2.7 release? Adrian -- - Xenion - http://www.xenion.com.au/ - VPS Hosting - Commercial Squid Support - - $25/pm entry-level VPSes w/ capped bandwidth charges available in WA -

Re: Forward architecture.

2008-02-03 Thread Adrian Chadd
On Sun, Feb 03, 2008, Amos Jeffries wrote: > Adrian Chadd wrote: > >Thats basically what Robert was proposing with his method changes > >in squid-3 a few years ago. > > > >Of course, what you really want to do is break out all of the magic > >url manipulation st

Re: ayjwork squid3/src HttpRequestMethod...

2008-02-02 Thread Adrian Chadd
On Sun, Feb 03, 2008, Amos Jeffries wrote: > > > >Please give an example or two, where the performance would noticeably > >suffer for standard methods. > > There were several switch(e->method) in what I think is the request > processing pathways. I was thinking making that switch into a series o

Re: Forward architecture.

2008-02-02 Thread Adrian Chadd
Thats basically what Robert was proposing with his method changes in squid-3 a few years ago. Of course, what you really want to do is break out all of the magic url manipulation stuff that happens for acceleration, because -that- stuff gets rewritten far before the forwarding manager gets its han

bugzilla #761: diskd

2008-02-02 Thread Adrian Chadd
I've put in a patch to possibly solve the diskd closing file assertion. http://www.squid-cache.org/bugs/show_bug.cgi?id=761 The patch can also be fetched here: http://www.creative.net.au/diffs/20080202-diskd-crashing.diff I haven't any idea whether it works, as I haven't yet triggered the bug l

Re: another proxy: ziproxy - inline image recompression

2008-01-30 Thread Adrian Chadd
.. aand Kinkie just went and created http://wiki.squid-cache.org/OtherHttpProxies . Adrian On Wed, Jan 30, 2008, Adrian Chadd wrote: > Its a post-fork()ing server, but it does inline content modification; > it recompresses images to take less client-side bandwidth. >

another proxy: ziproxy - inline image recompression

2008-01-30 Thread Adrian Chadd
Its a post-fork()ing server, but it does inline content modification; it recompresses images to take less client-side bandwidth. http://ziproxy.sourceforge.net/ Adrian -- - Xenion - http://www.xenion.com.au/ - VPS Hosting - Commercial Squid Support - - $25/pm entry-level VPSes w/ capped band

Re: forwarded_for documentation inaccurate

2008-01-30 Thread Adrian Chadd
On Wed, Jan 30, 2008, Amos Jeffries wrote: > >My filter files bugzilla and squid-dev emails together, so there is no > >difference as far as "getting noticed" is concerned. I am sure it is > >different for other developers though. > > Would be nice if I could get bugzilla emails too, but I work a

Re: Dynamic content policy update

2008-01-30 Thread Adrian Chadd
On Wed, Jan 30, 2008, Amos Jeffries wrote: > Adrian Chadd wrote: > >I'm for it. Henrik suggested just "." (ie, everything) rather than > >specifically doing cgi-bin and ? URLs; is there any particular reason > >to have different "." vs "(cgi-bin|\

Re: diskd and unlink

2008-01-29 Thread Adrian Chadd
On Wed, Jan 30, 2008, Robert Collins wrote: > > If noone objects I'll make this change to 2.HEAD, 2.7 and 2.6; I'll leave 3 > > to someone who knows more about the code post-code-shuffling. > > Doesn't that cause a performance hit on file systems where unlink() > blocks? Thats what unlinkd is fo

diskd and unlink

2008-01-29 Thread Adrian Chadd
Hi everyone, I'd like to make diskd use the unlink daemon instead of handling unlinks itself in an attempt to lessen the amount of work being sent to the queue, and thus (hopefully) mitigate the amount of times the disk callback is being recursively called. If noone objects I'll make this change

Re: WCCP2 patch

2008-01-28 Thread Adrian Chadd
Hm, I think its now worth creating a Wiki article covering WCCPv2 "issues" and which ones have been solved. This is definitely one of those things that should be documented. Adrian On Mon, Jan 28, 2008, Steven Wilton wrote: > We've had a couple of problems on our caches using WCCP2 + tproxy >

Re: Dynamic content policy update

2008-01-28 Thread Adrian Chadd
I'm for it. Henrik suggested just "." (ie, everything) rather than specifically doing cgi-bin and ? URLs; is there any particular reason to have different "." vs "(cgi-bin|\?)" refresh pattern lines? Thanks, Adrian On Tue, Jan 29, 2008, Amos Jeffries wrote: > Any objections to Squid2-HEAD and S

Re: URIs for accelerators

2008-01-26 Thread Adrian Chadd
Adrian On Fri, Jan 25, 2008, Adrian Chadd wrote: > On Wed, Jan 23, 2008, Mark Nottingham wrote: > > That's kind of what I was thinking, but was balking at the extra > > logic. If it's already hanging around, all the better. > > I just replied to the bug. This code

Re: HEAD squid3 configure.in,1.173,1.174

2008-01-24 Thread Adrian Chadd
Don't commit to HEAD on sourceforge- thats used to sync against. Create a branch for your work and dump your work in that branch. Adrian On Wed, Jan 23, 2008, Arthur Tumanyan wrote: > Update of cvs.devel.squid-cache.org:/cvsroot/squid/squid3 > > Modified Files: > configure.in > Log Mess

Re: URIs for accelerators

2008-01-24 Thread Adrian Chadd
On Wed, Jan 23, 2008, Mark Nottingham wrote: > That's kind of what I was thinking, but was balking at the extra > logic. If it's already hanging around, all the better. I just replied to the bug. This code may do the right thing: if (vport) snprintf(http->uri, url_sz

Re: s27_adri benchmarking

2008-01-23 Thread Adrian Chadd
On Wed, Jan 23, 2008, Alex Rousskov wrote: > Are these results based on fetching a 176-byte image from an Apache > server using a configurable number of best-effort robots (the x axis)? Yup. > Is that image cached by Squid? Its just an internal icon, loaded at runtime. This test is just design

Re: s27_adri benchmarking

2008-01-22 Thread Adrian Chadd
On Wed, Jan 23, 2008, Amos Jeffries wrote: > While you are doing this any chance of a look at: > 2.6s18 vs s7_adri vs 3.0s1 vs 3-HEAD ? No-Keepalive: 100 concurrent: 672 req/sec 200 concurrent: 671 req/sec 500 concurrent: 665 req/sec 1000 concurrent: 522 req/sec The keepalive requests aren't w

Re: s27_adri benchmarking

2008-01-22 Thread Adrian Chadd
On Wed, Jan 23, 2008, Adrian Chadd wrote: > On Wed, Jan 23, 2008, Amos Jeffries wrote: > > > While you are doing this any chance of a look at: > > 2.6s18 vs s7_adri vs 3.0s1 vs 3-HEAD ? > > Someone broke 3.HEAD ? > > Hm, copy/paste is busted (grr ubuntu deskto

<    1   2   3   4   5   6   7   8   9   10   >