[squid-dev] Idea: what if SBuf was a Packable?

Hi all, I spent some time wondering whether we could reduce code duplication by making SBuf implement the Packable interface, and replacing SBufStream with PackableStream. The interface changes seem rather minimal, SBuf already implements append(const char*, int) and vappendf; the main

[squid-dev] RFC: ACL clashes with Windows system entity

Hi all, I'm looking at improving windows portability, and we have a name clash with a Windows system header ( https://learn.microsoft.com/en-us/windows/win32/api/winnt/ns-winnt-acl) So.. how to deal with it? I can see two options: either we lift ACL into the Acl namespace, or we need to rename

Re: [squid-dev] mirrors with missing files

Hi all, I agree, it would be awesome to rely on a more more than delivery network for our website. At this time it is complicated. Oh website is large as a result of posting mailing list, archives and a lot of release files, patches, change sets. Before we can migrate to anything different, we

[squid-dev] RFC: make FOLLOW_X_FORWARDED_FOR unconditional

Hi all, what if we removed the configure option for FOLLOW_X_FORWARDED_FOR, and made it unconditionally part of Squid? It is on by default, and it is controlled by runtime configuration, removing the compile-time option would ensure we have better testing coverage. What do you think? --

[squid-dev] RFC: Transitioning ipcache and fqdncache to ClpMap

Hi all, I'd like to start working on transitioning ipcache and fqdncache to ClpMap . There is only one snag, that I would like to build consensus on before starting coding: the current configuration directives specify a cache size in number of entries, where ClpMap specifies a max size. I can

[squid-dev] CI: trunk is stable again

Hi all, trunk build tests can now be relied upon again for correctness checks. We can set them up again as required for merging PRs -- Francesco Chemolli Squid Software Foundation ___ squid-dev mailing list squid-dev@lists.squid-cache.org

[squid-dev] Opensuse tumblweed woes

Hi all, I'm disabling opensuse tumbleweed from all our test build jobs; in their current setup all builds are failing with an error in the linker for undefined references to just about everything (see

Re: [squid-dev] Latest Clang build errors

> > > BTW, since GCC v13 has other bugs and has not been officially "released" > yet, I suggest removing that compiler from the set of required tests > until it matures enough for us to support it efficiently. > That's what Fedora Rawhide ships as default compiler. We can only do that by stopping

Re: [squid-dev] Latest Clang build errors

Hi all, that is not just with clang: https://build.squid-cache.org/job/trunk-amd64-matrix/COMPILER=gcc,CPU=amd64,OS=fedora-rawhide,force_on_docker_arm64=docker-build-host-lowpri/434/console shows the error on gcc 13. I recall a conversation where Alex showed it to be a compiler issue, but I

Re: [squid-dev] RFC: policy change for header #includes

I like this idea; I would also complement it with the directive to use header instead of whenever possible - this could also be automatically enforced On Tue, Mar 7, 2023 at 5:38 AM Amos Jeffries wrote: > > Current Policy > < >

Re: [squid-dev] RFC: Switch to C++17

I support the switch On Sun, 4 Dec 2022 at 16:18, Alex Rousskov wrote: > Hello, > > I propose that we switch master/v6 from C++11 to C++17: Modern > environments support C++17 well. We are wasting significant amounts of > time on emulating such basic C++17 features as std::optional. We are

Re: [squid-dev] RFC: Semaphore CI to GitHub Actions migration

Hi Alex, this all sounds sensible to me and in general a good idea On Wed, Oct 19, 2022 at 3:25 PM Alex Rousskov < rouss...@measurement-factory.com> wrote: > Hello, > > I plan to gradually turn Semaphore CI testing off and make GitHub > Actions required. We should not babysit the same

Re: [squid-dev] Proposal: switch to always-build for some currently optional features

> > > I agree that modules that can always be built, should be. Such modules > should have no guarding #ifdefs. I think this is the set of modules that > your proposal is targeting, but please correct me if I am wrong. FWIW, > this design stems from an even more general/fundamental rule of thumb:

[squid-dev] Proposal: switch to always-build for some currently optional features

Hi all, there is a bunch of features that are currently gated at compile time: among others, I see: - adaptation (icap, ecap) - authentication - ident - delay pools - cache digests - htcp - cache digests - wccp - unlinkd I'd like to propose that we switch to always-build them. We would gain: -

Re: [squid-dev] IPv6 Proxy (RTC leak)

Hi Leandro, have you followed the instructions in https://wiki.squid-cache.org/SquidFaq/ConfiguringSquid#Can_Squid_anonymize_HTTP_requests.3F ? On Sun, Sep 11, 2022 at 10:33 PM Leandro de França wrote: > Hello, my name is Leandro de França! > I am using Squid to configure an IPv4 (incoming)

Re: [squid-dev] squid website certificate error

The squid website is not supposed to be over https, because it’s served by multiple mirrors not necessarily under the project’s control. We have some ideas on how to change this but need the developer time to do it. Help is welcome :) On Mon, 29 Aug 2022 at 15:25, Marcus Kool wrote: > Has

Re: [squid-dev] RFC submodule repositories

> > > ( So every change to Squid has to be justified as an optimization now. > Right... ) > My experience with submodules is not great; I often ended up with detached sub-branches that were a pain to deal with. Given that, I am trying to understand if it's worth it, that's all. As opposed to,

Re: [squid-dev] RFC submodule repositories

Hi, I second Alex' view point, I don't have a clear understanding about what is the benefit that you're trying to obtain. On Sun, Jul 31, 2022 at 4:09 PM Alex Rousskov < rouss...@measurement-factory.com> wrote: > On 7/31/22 00:29, Amos Jeffries wrote: > > When PR #937 merges we will have the

Re: [squid-dev] Errors while building 5.6 on Ubuntu 22.04

OpenSSL 3.0 support has landed in trunk yesterday. Hopefully there will be a point release with it any day now On Mon, Jul 18, 2022 at 9:52 AM wrote: > Hey Everybody, > > > > I have just started my build tests on Ubuntu 22.04 and I got some > errors, something with OpenSSL 3.0. > > I have seen

Re: [squid-dev] bugzilla issue

Hi Adam, thanks for letting me know. It's now fixed. On Fri, Jul 15, 2022 at 9:46 AM Adam Majer wrote: > When going to bugs.squid-cache.org, I get a message that MySQL DB is not > accessible. And since there is no notification address on that page, > forwarding here. > > - Adam > > > >

[squid-dev] Squid + docker multi-distro test builds script

Hi all, in order to facilitate multiplatform (at least on Linux) development velocity, let me share a script I use for this purpose. It is based on the same tech we run our CI farm on. the script is at https://github.com/kinkie/support-tools/blob/master/squid-build/do-build It's reasonably

Re: [squid-dev] RFC: Class section/member _order_

Hi, I generally agree on the proposal. Any difference in opinion I have is trivial and not worth discussing Regarding the ML filter, thanks for letting me know. I’ll have to figure out what keyword triggered the anti spam filter Francesco On Thu, 23 Jun 2022 at 15:37, Alex Rousskov <

Re: [squid-dev] PR backlog

On Wed, Jun 8, 2022 at 2:39 PM Alex Rousskov < rouss...@measurement-factory.com> wrote: > On 6/7/22 17:53, Francesco Chemolli wrote: > > This is exactly what I meant and what I see happening. > > I'd like us to concentrate on clearing as much as possible the PR >

Re: [squid-dev] PR backlog

has already picked up, that's great! > > On Mon, Jun 6, 2022 at 6:20 PM Alex Rousskov < > rouss...@measurement-factory.com> wrote: > >> On 6/6/22 03:34, Francesco Chemolli wrote: >> >> > we have quite a big backlog of open PRs >> > (https://github.com

Re: [squid-dev] PR backlog

, Jun 6, 2022 at 6:20 PM Alex Rousskov < rouss...@measurement-factory.com> wrote: > On 6/6/22 03:34, Francesco Chemolli wrote: > > > we have quite a big backlog of open PRs > > (https://github.com/squid-cache/squid/pulls?page=1=is%3Apr+is%3Aopen). > How >

[squid-dev] PR backlog

Hi all, we have quite a big backlog of open PRs ( https://github.com/squid-cache/squid/pulls?page=1=is%3Apr+is%3Aopen). How about doing a 15-days sprint and clearing it or at least trimming it significantly? -- Francesco ___ squid-dev mailing

[squid-dev] Can't build on Ubuntu Jammy

Hi all, I did a trial build run on Jammy ( https://build.squid-cache.org/job/anybranch-anyarch-matrix/COMPILER=gcc,OS=ubuntu-jammy,label=amd64-linux/5/console); it fails with ../../../../src/security/forward.h: In function 'void Security::DH_free_cpp(DH*)':

Re: [squid-dev] What os/cpu platforms do we want to target as a project?

On Sun, Dec 26, 2021 at 10:58 PM Alex Rousskov wrote: > > On 12/26/21 10:30 AM, Francesco Chemolli wrote: > > On Sun, Dec 5, 2021 at 10:05 PM Alex Rousskov wrote: > >> On 12/5/21 4:44 AM, Francesco Chemolli wrote: > >>> I would recommend that we support as m

Re: [squid-dev] What os/cpu platforms do we want to target as a project?

On Sun, Dec 5, 2021 at 10:05 PM Alex Rousskov wrote: > > On 12/5/21 4:44 AM, Francesco Chemolli wrote: > > > I would recommend that we support as main targets: > > - Linux on x64, arm64, arm32 and, if we can, MIPS > > - FreeBSD, OpenBSD on x64 > > >

[squid-dev] What os/cpu platforms do we want to target as a project?

Hi all, continuing the conversation from https://github.com/squid-cache/squid/pull/942#issuecomment-986055422 to a bigger forum The discussion started out of a number of PRs meant to remove explicit support for obsolete platforms such as OSF/1, NeXT or old versions of Solaris. I that thread I

Re: [squid-dev] Incoming breaking changes to OpenSSL API

:16 pm, Francesco Chemolli wrote: > > Hi all, > >Fedora Rawhide has upgraded openssl to version 3, and the results > > can be seen at > > https://build.squid-cache.org/job/anybranch-arm64-matrix/COMPILER=gcc,OS=fedora-rawhide,label=arm64/10/console > > > >

[squid-dev] Incoming breaking changes to OpenSSL API

Hi all, Fedora Rawhide has upgraded openssl to version 3, and the results can be seen at https://build.squid-cache.org/job/anybranch-arm64-matrix/COMPILER=gcc,OS=fedora-rawhide,label=arm64/10/console For example: In file included from ../../../../src/security/Session.h:15,

Re: [squid-dev] bizarre build behaviour from PoolingAllocator on OpenBSD/clang

On Mon, Aug 16, 2021 at 12:29 PM Stuart Henderson wrote: > On 2021-08-15, Alex Rousskov wrote: > > On 8/15/21 2:51 PM, Francesco Chemolli wrote: > >> Hi all, > >> I'm looking into OpenBSD compatibility for trunk, and there's a > >> strange behaviour at

[squid-dev] bizarre build behaviour from PoolingAllocator on OpenBSD/clang

Hi all, I'm looking into OpenBSD compatibility for trunk, and there's a strange behaviour at build time on OpenBSD (6.9) / clang (10.0.1) When building src/log/access.log.cc, build fails with these errors: -- begin quote --- static_assert((is_same::value), ^

Re: [squid-dev] Compilling squid

>> ./configure --enable-ssl-crtd --with-openssl ... > > I suggest that you fix basic build errors before trying to add more > dependencies for interception. I do not know exactly what libraries you > need for interception support on Ubuntu, and the answer may depend on > what kind of

Re: [squid-dev] Strategy about build farm nodes

On Mon, May 17, 2021 at 8:32 PM Alex Rousskov < rouss...@measurement-factory.com> wrote: > On 5/17/21 2:17 AM, Francesco Chemolli wrote: > > > Our Linux environments are docker containers on amd64, armv7l and arm64. > > On a roughly monthly cadence, I pull from our doc

Re: [squid-dev] Strategy about build farm nodes

> > > Adding new nodes with next distro release versions is a manual process > not related to keeping existing nodes up to date (which is automated?). > Mostly. Our Linux environments are docker containers on amd64, armv7l and arm64. On a roughly monthly cadence, I pull from our dockerfiles repo

Re: [squid-dev] Strategy about build farm nodes

On Wed, Apr 28, 2021 at 11:34 PM Alex Rousskov < rouss...@measurement-factory.com> wrote: > On 4/28/21 5:12 PM, Amos Jeffries wrote: > > I'm not sure why this is so controversial still. We have already been > > over these and have a policy from last time: > > Apparently, the recollections of what

[squid-dev] Strategy about build farm nodes

Hi all, I'm moving here the discussion from PR #806 about what strategy to have for CI tests, looking for an agreement. We have 3 classes of tests ni our CI farm (https://build.squid-cache.org/) - PR staging tests, triggered by commit hooks on GitHub (possibly with human approval) the job is

Re: [squid-dev] RFC: making TrieNode less memory-hungry

> > Do ESI users want to trade speed for memory savings? What memory savings > and speed reduction do you anticipate for a typical use case or two? > > In light of the fact that it's only used by ESI, I think it's not worthwhile investing in it. ___

Re: [squid-dev] cppunit -> googletest / gmock?

On Sat, May 30, 2020 at 7:38 PM Amos Jeffries wrote: > On 31/05/20 5:27 am, Francesco Chemolli wrote: > > Hi all, > >starting from a PR in a conversation with Alex about our current > > approach to unit testing being painful, I've checked what alternatives > > woul

[squid-dev] cppunit -> googletest / gmock?

Hi all, starting from a PR in a conversation with Alex about our current approach to unit testing being painful, I've checked what alternatives would we have and how practical would they be. An easy first option would be googletest/googlemock. On a lazy afternoon, I've tried seeing how

Re: [squid-dev] squid master build with alternate openssl fails

On Fri, May 8, 2020 at 3:58 PM Alex Rousskov < rouss...@measurement-factory.com> wrote: > On 5/8/20 10:12 AM, Christos Tsantilas wrote: > > > Squid master 699ade2d fails to build with an alternate OpenSsl, when the > > "--with-openssl=/path/to/openssl" is used. > > Francesco, builds with custom

[squid-dev] RFC: clang-format

Hi all, I have made an attempt at running clang-format on the squid sources, after applying a configuration which follows as closely as possible the project's coding guidelines. You can find the output of the exercise at https://github.com/kinkie/squid/tree/clang-format ; the configuration is

Re: [squid-dev] removing cache_diff?

doing that today. On Tue, Apr 7, 2020 at 2:47 PM Alex Rousskov < rouss...@measurement-factory.com> wrote: > On 4/6/20 5:00 PM, Francesco Chemolli wrote: > > > has anybody used the cache_diff program in the last 10 years? > > Not me. If you are going to remove it, I r

[squid-dev] removing cache_diff?

Hi all, has anybody used the cache_diff program in the last 10 years? I've used squid for 20 years now, and I never even noticed it. It's not even installed as part of the build process... -- Francesco ___ squid-dev mailing list

[squid-dev] RFC: use clang-format?

Hi all, astyle is a bit of PITA, maybe we can replace it with clang-format? It seems to me it has more power and flexibility, and its config could be stored in the source tree itself. What do you think? -- Francesco ___ squid-dev mailing list

Re: [squid-dev] RFC: cacheMatchAcl

2020 at 08:15, Amos Jeffries wrote: > On 4/04/20 7:49 pm, Francesco Chemolli wrote: > > I am not sure about what you recommend to do here. > > This cache is IMO over complicated and it breaks layering. > > I’m mostly done in a PR replacing the dlink with a std::list but

Re: [squid-dev] RFC: cacheMatchAcl

2020 at 07:41, Amos Jeffries wrote: > On 4/04/20 3:34 am, Alex Rousskov wrote: > > On 4/3/20 7:25 AM, Francesco Chemolli wrote: > > > >> I'm looking at places where to improve things a bit, and I stumbled > >> across cacheMatchAcl . It tries hard to be gener

[squid-dev] RFC: cacheMatchAcl

Hi all, I'm looking at places where to improve things a bit, and I stumbled across cacheMatchAcl . It tries hard to be generic, but it is only ever used in ACLProxyAuth::matchProxyAuth . Would it make sense to just have a specialised cache for proxyauth? -- Francesco

Re: [squid-dev] squid.conf future

I like the idea of markdown, if possible. It is simple and gets the job done. Would processing it be more cumbersome than the alternatives? On Wed, Feb 26, 2020 at 8:43 PM Alex Rousskov < rouss...@measurement-factory.com> wrote: > On 2/25/20 1:31 AM, Amos Jeffries wrote: > > > Any suggestions of

Re: [squid-dev] handling spaces in path to sources

if there are spaces in the build path. The feature branch is at https://github.com/kinkie/squid/tree/securify-test-builds This was tested on MacOS Catalina with - autoconf 2.69 - libtool 2.4.6 - gmake 3.81 - clang 11 On Tue, Feb 18, 2020 at 8:40 AM Francesco Chemolli wrote: > Hi all, > as a fo

[squid-dev] handling spaces in path to sources

Hi all, as a followup to discussion on PR 555, I was looking into safely handling source code paths with spaces. Turns out worrying is pointless: after doing the needed changes, doing a test build with builddir = "/Users/kinkie/src/test build with space" srcdir = "/Users/kinkie/src/squid dir

[squid-dev] [SPAM] Squid irc log bot

Hi all, is anyone using the free node irc log bot anymore? If not, I’m considering retiring it. Thanks, Kinkie ___ squid-dev mailing list squid-dev@lists.squid-cache.org http://lists.squid-cache.org/listinfo/squid-dev

[squid-dev] ARMv7 build nodes

Hi all, https://build.squid-cache.org/job/5-matrix-arm/ is our first ARMv7(32bit) build node - docker/linux/raspberry pi 3. Next up, hopefully, FreeBSD on aarch64 (banana pi). -- Francesco ___ squid-dev mailing list

Re: [squid-dev] PVS Studio

> On Jan 14, 2019, at 19:11, Alex Rousskov > wrote: > > On 1/14/19 3:20 PM, Francesco Chemolli wrote: >> Hi all, >> the team behind PVS studio (static code analysis tool) has decided >> to support FOSS projects for free (beer). >> >> https://

[squid-dev] PVS Studio

Hi all, the team behind PVS studio (static code analysis tool) has decided to support FOSS projects for free (beer). https://hownot2code.com/2019/01/14/free-pvs-studio-for-those-who-develops-open-source-projects/ Unless there are any concerns, I'll look into integrating our build pipelines

Re: [squid-dev] Anubis documentation

09:46 AM, Francesco Chemolli wrote: > > > recent discussions on github led me to understand that information > > on Anubis' interfaces is in peoples' heads and not on a bit of paper. > > Would it be possible to write a brief wiki page with some info about > >

[squid-dev] Anubis documentation

Hi all, recent discussions on github led me to understand that information on Anubis' interfaces is in peoples' heads and not on a bit of paper. Would it be possible to write a brief wiki page with some info about what is the FSM driving it and what are the tags it uses to store state? Thanks!

Re: [squid-dev] Squid-4.1 (stable)

Great! Looking forward to it On Tue, Jun 26, 2018 at 8:33 AM Amos Jeffries wrote: > > The latest Squid-4 beta has now passed 14 days with no new major bugs > being reported. That means I can start the final countdown for the > Squid-4.1 release. > > Unless something new comes up I intend to

Re: [squid-dev] Introduction

Please, Let’s all be respectful here. There is no need to call anyone names, especially under the unfounded assumption of ill intent. There are plenty of forums focused on policies and politics, and this isn’t one of them. On Mon, 19 Mar 2018 at 12:08, Serge wrote: >

Re: [squid-dev] Build failed in Jenkins: 4-matrix » clang,d-debian-wheezy #85

> On Sep 10, 2017, at 20:01, Amos Jeffries wrote: > > FWIW none of the compilers on Debian wheezy (and probably Jesse) can handle > Squid-4+ builds due to their incomplete C++11 implementation. Ok, removing them from the build list. Sorry for the noise, I’m reenabling

Re: [squid-dev] Git-related wiki updates

Hi Alex, thanks for taking the time! The updated documents are very helpful and seem quite accurate, I'll try them out and amend if I find any need. Did you have any challenges with wiki editing? Thanks! Francesco > On 2 Aug 2017, at 07:49, Alex Rousskov

[squid-dev] [PULL REQUEST] Pass-through with-openssl argument

Hi all, https://github.com/squid-cache/squid/pull/31 is about passing through the —with-openssl argument in maximum-test build when openssl is installed in a non-system location (as it happens on macOS home-brew). Please review :)

Re: [squid-dev] [PATCH] Log SSL Cryptography Parameters

On 10 Dec 2015, at 18:36, Christos Tsantilas wrote: > This patch adds the following formatting codes: LGTM. +1. Kinkie ___ squid-dev mailing list squid-dev@lists.squid-cache.org http://lists.squid-cache.org/listinfo/squid-dev

Re: [squid-dev] [RFC] Fix shared memory initialization, cleanup. Ensure its usability.

On 10 Dec 2015, at 19:23, Amos Jeffries wrote: > Okay. Good points, and some very good ones. > > > So it comes down to doing it your way and we will have to come up with > something to explain to confused admin why their proxies are now slow. Well, slow in starting up,

Re: [squid-dev] [PATCH] %ssl::

On 10 Dec 2015, at 18:04, Christos Tsantilas wrote: > This is a complement patch for "%ssl:: applied to trunk as r14343. LGTM. +1. Kinkie ___ squid-dev mailing list squid-dev@lists.squid-cache.org

Re: ctx_enter, ctx_exit, ctx_print

On 17 Feb 2014, at 00:48, Amos Jeffries squ...@treenet.co.nz wrote: On 17/02/2014 2:51 a.m., Kinkie wrote: Hi all, I'm working on debug together with Amos, working on reducing the size of the API, removing cruft and making it a bit speedier in the meantime. I'm looking into refactoring

Re: [PREVIEW] -M command line option

On 17 Feb 2014, at 08:03, Amos Jeffries squ...@treenet.co.nz wrote: On 15/02/2014 6:47 a.m., Francesco Chemolli wrote: On 14 Feb 2014, at 13:24, Amos Jeffries squ...@treenet.co.nz wrote: Just to kick this further along. I've put together the proposal in patch form. Anyone game to test

Re: [PREVIEW] -M command line option

On 14 Feb 2014, at 13:24, Amos Jeffries squ...@treenet.co.nz wrote: Just to kick this further along. I've put together the proposal in patch form. Anyone game to test the SMP support is working properly with -M foreground when this is applied? I'm also beginning to think we are needing

Re: [CTTE #727708] Default init system for Debian

On 14 Feb 2014, at 06:31, Alex Rousskov rouss...@measurement-factory.com wrote: On 02/13/2014 03:47 PM, Amos Jeffries wrote: Use of -N with no parameter produce an error. I do not think we have to break existing scripts (some of which may still be working OK!). We can issue a deprecation

heads-up: possible bug in trunk

Hi all, I've had squid lock a couple of times in trunk and stop responding to HTTP requests about ~10k requests today. It's not an endless loop, it's not busy-looping. Once I managed to get a backtrace, it seems to be either something in idns or in mempools, maybe it's related to

Re: [Squid Web Proxy Wiki] Update of KnowledgeBase/Benchmarks by FrancescoChemolli

On 30 Jan 2014, at 21:38, Amos Jeffries squ...@treenet.co.nz wrote: On 2014-01-31 04:24, w...@wiki.squid-cache.org wrote: snip + || RPS || 39715 || + || Bandwidth || 313 Mbit/sec sustained || + ... 600-bytes long document. Thats 1KB per transaction. + This number was taken in a

Re: [PATCH] Large Rock and Collapsed Forwarding

+1. IMHO, if nobody else wants to take a stab at a full audit I think you should just merge this and we fix the bugs as found. I'm with Amos on this. Merging will also give coverity a go at it, so +1 from me as well. Kinkie

Re: [PATCH] Make SBuf::find_first_of O(N) and implement find_first_not_of

On 17 Dec 2013, at 20:09, Alex Rousskov rouss...@measurement-factory.com wrote: On 12/17/2013 10:35 AM, Kinkie wrote: here's the updated patch. Looks good to me, thank you. There is only one bug (listed first below). The rest is minor polishing: +

Re: [RFC] Tokenizer API

[...] Given the number of cases where folks wrote the _wrong_ length already, I suggest the following plan: 1. Do not support the len argument. Use the add-single-character interface to add \0 when/if needed. 2. If we find ourselves adding \0 (and nothing else) too much, revisit this

Re: [RFC] Tokenizer API

On 09 Dec 2013, at 20:00, Alex Rousskov rouss...@measurement-factory.com wrote: Hello, The promised Tokenizer API proposal is attached. Compared to earlier proposals, this interface is simplified by focusing on finding tokens (requires knowledge of allowed and prohibited character

Re: [RFC] Tokenizer API

Hi, SBuf supplies a few find() variants which could help which are not constant time but rely on lower-level primitives and related optimizations. My suggestion is to have CharacterSet be a SBuf and rely on them, at least for now. In any case having them be a SBuf promotes better

Re: [PATCH] SBufList

And, if you insist that IsMember() wrapper is needed, it can be placed in the same header file as well. Make it generic like the SBufJoin() below. It's just convenience. I'd leave SBufList.h / .cc only as convenience helpers, relying on SBufAlgos.h for some grunt work. One note: I chose

Re: [PATCH] SBufList

On 02 Dec 2013, at 21:36, Alex Rousskov rouss...@measurement-factory.com wrote: On 12/02/2013 11:34 AM, Kinkie wrote: +SBuf operator() (SBuf accumulated, const SBuf item) { +if (first) { +first = false; +accumulated.append(item); +return

[MERGE] Branch prediction hints

with all possible static compiler error-checks enabled. === added file 'include/branch-hints.h' --- include/branch-hints.h 1970-01-01 00:00:00 + +++ include/branch-hints.h 2010-10-13 16:08:55 + @@ -0,0 +1,45 @@ +/* + * branch-hints.h (C) 2009 Francesco Chemolli kin...@squid

Re: refactoring the store

On Tue, 2004-12-28 at 12:36, Robert Collins wrote: I'm making some good headway on rearranging the store to match the rough API prepared in Stockholm. (Kinkie: where was that wiki you put up again? I'll put the design notes up there...). http://squidwiki.kinkie.it/; please feel free to CNAME