Re: [RFC] ignore ftp_epsv off for IPv6

On 29/01/2014 9:24 a.m., Alex Rousskov wrote: > On 01/25/2014 06:05 PM, Amos Jeffries wrote: >> On 25/01/2014 9:27 a.m., Alex Rousskov wrote: >> >>> I propose to limit squid.conf "ftp_epsv off" prohibition to IPv4 FTP >>> servers. > ... >>&g

Re: [RFC] Squid process model and service name impact

On 2014-01-29 07:21, Alex Rousskov wrote: On 01/27/2014 06:44 AM, Amos Jeffries wrote: On 27/01/2014 8:18 a.m., Henrik Nordström wrote: How do using a service name for these differ from having a squid.conf set the name (possibly using the same service name as a macro expansion)? squid.conf

Re: [RFC] Squid process model and service name impact

On 27/01/2014 8:18 a.m., Henrik Nordström wrote: > sön 2014-01-26 klockan 13:59 +1300 skrev Amos Jeffries: > >> So how do we safely allow users to configure where the IPC sockets are >> located on a per-worker basis while also allowing workers to communicate >>

RunnersRegistry dependencies

I am looking at making a few more items in the startup and shutdown sequences of Squid into Runners. I cannot quite see how to create dependencies such that Runner A does not occur until after Runner B has completed. Such as allocate cache heaps after initializing mempools, or opening listening so

Re: [RFC] ignore ftp_epsv off for IPv6

On 25/01/2014 9:27 a.m., Alex Rousskov wrote: > Hello, > > I propose to limit squid.conf "ftp_epsv off" prohibition to IPv4 FTP > servers. > > Setting ftp_epsv to "off" is often necessary to correctly handle > real-world cases where an IPv4 FTP server correctly responds to an EPSV > command b

Re: [RFC] Squid process model and service name impact

On 25/01/2014 8:50 p.m., Henrik Nordström wrote: > fre 2014-01-24 klockan 14:27 -0700 skrev Alex Rousskov: >> using the same Squid build (bug 3608). That bug report contains a >> suggestion to make the currently ./configure-set IPC paths explicitly >> configurable in squid.conf, but using service n

Re: [RFC] Squid process model

On 2/11/2013 2:11 a.m., Amos Jeffries wrote: > Hi all, > As some of you are no doubt aware that one of the design issues we are > facing with Squid these days is the process model. The current model has > a very init.d centric design and shoots itself in the foot when > encouter

Re: [PATCH] client-side redesign pt1 - Comm::TcpReceiver

On 22/01/2014 6:45 p.m., Alex Rousskov wrote: > On 01/07/2014 02:52 AM, Amos Jeffries wrote: >> Updated patch attaced for audit. >> >> This one includes all the currently known bits for server-side delay >> pools so no audit omissions this time around. >> >>

Re: [PATCH] client-side redesign pt1 - Comm::TcpReceiver

On 22/01/2014 10:32 p.m., Henrik Nordström wrote: > tis 2014-01-21 klockan 22:45 -0700 skrev Alex Rousskov: > >> All the TCP clients and servers you are willing to include (as future >> TcpReceiver kids) in the current project scope have at least one thing >> in common -- they all read and write p

Re: [PATCH] client-side redesign pt1 - Comm::TcpReceiver

On 23/01/2014 7:19 p.m., Eliezer Croitoru wrote: > On 07/01/14 11:52, Amos Jeffries wrote: >> Updated patch attaced for audit. > > I do not see any patch in the mailing list post, Are we talking about > "This one with the mk2 patch actually attached."? Yes. Amos

Re: [PATCH] client-side redesign pt1 - Comm::TcpReceiver

On 2014-01-22 18:45, Alex Rousskov wrote: On 01/07/2014 02:52 AM, Amos Jeffries wrote: Updated patch attaced for audit. This one includes all the currently known bits for server-side delay pools so no audit omissions this time around. On 4/01/2014 8:16 a.m., Alex Rousskov wrote: On 12/03

Re: [RFC] FTP gw source layout

On 2014-01-22 10:37, Alex Rousskov wrote: [ A specific revised proposal is at the end of this email, after the discussion. ] On 01/20/2014 03:30 PM, Amos Jeffries wrote: On 2014-01-21 07:45, Alex Rousskov wrote: I propose the following arrangement for the official submission: src/out

Re: debugs from an interesting CBDATA case study

On 14/01/2014 3:31 p.m., Alex Rousskov wrote: > On 01/07/2014 08:35 AM, Alex Rousskov wrote: > >> 2) [Add cbdata debugging to] find which object stores the invalid cbdata >> pointer. Then find how that invalid pointer gets to that object. > > I think it happens here: > > >>> #8 0x0834f190 in

Re: [PATCH] use nullptr more?

On 2014-01-21 12:47, Alex Rousskov wrote: On 01/20/2014 02:28 PM, Amos Jeffries wrote: On 2014-01-21 08:05, Alex Rousskov wrote: On 01/20/2014 08:15 AM, Kinkie wrote: the attached patch is an attempt (build-tested) to rely more on nullptr in place of NULL. It takes from the current

Re: [RFC] FTP gw source layout

On 2014-01-21 07:45, Alex Rousskov wrote: Hello, FTP gateway[1] code[2] work well, and we are polishing it for the official submission. The biggest change we need to make is to rearrange where the new code lives in Squid src directory. In this email, I am proposing how to structure that new

Re: [PATCH] use nullptr more?

On 2014-01-21 08:05, Alex Rousskov wrote: On 01/20/2014 08:15 AM, Kinkie wrote: the attached patch is an attempt (build-tested) to rely more on nullptr in place of NULL. It takes from the current implementation, it is just a bit more forceful in using nullptr if available. Hi Kinkie, Y

Re: Build failed in Jenkins: 3.HEAD-amd64-CentOs-icc #1235

I've taken a look at this link failure for ICC on CentOS: On 2014-01-15 10:47, n...@squid-cache.org wrote: See AclRegs.o: In function `_INTERNAL_20___src_AclRegs_cc_a4e5ab95::__gthread_active_p()': /usr/include/c++/4

Re: [PATCH] SMP SSL session cache implementation

On 11/01/2014 6:48 a.m., Tsantilas Christos wrote: > On 01/10/2014 01:04 AM, Amos Jeffries wrote: >> On 2014-01-10 04:50, Tsantilas Christos wrote: >>> On 01/09/2014 12:07 AM, Amos Jeffries wrote: >>>> On 2014-01-09 07:30, Tsantilas Christos wrote: >>>&g

Re: [PATCH] Coverity defect 1135443

On 9/01/2014 9:57 p.m., Kinkie wrote: > Hi, > Coverity detected a possible division by zero in > src/format/Format.cc line 500, on a Token->divisor. > The defect is a false positive as that value is correctly initialized, > but it could be a chance to document as a class invariant that that > val

Re: [PATCH] SMP SSL session cache implementation

On 2014-01-10 04:50, Tsantilas Christos wrote: On 01/09/2014 12:07 AM, Amos Jeffries wrote: On 2014-01-09 07:30, Tsantilas Christos wrote: This patch implement SSL session cache sharing across SMP workers using shared memory. The following new squid configuration options added: - The

Re: interesting tidbit in store_repl_heap.cc

On 2014-01-10 04:14, Kinkie wrote: It's been there forever, and a build with the most recent clang version is failing on it: store_repl_heap.cc:224 try_again: if (!heap_nodes(h->theHeap) > 0) Does anyone have any idea about what this code is supposed to do? A cursory look at the code would

Re: [PATCH] SMP SSL session cache implementation

On 2014-01-09 07:30, Tsantilas Christos wrote: This patch implement SSL session cache sharing across SMP workers using shared memory. The following new squid configuration options added: - The "sslproxy_session_cache_size" option which sets the cache size to use for ssl session. Example usage

Re: SUSE build of squid.

On 8/01/2014 2:13 p.m., Eliezer Croitoru wrote: > > As I understood the "-fPIC" flag will fit for allowing the code to be > more kind of "dynamic" in it's memory location and portable. > > I am looking for the right words for the flag "PIC". > PIC and PIE should be added automatically by libtoo

Re: helper program

On 2014-01-08 08:52, Amos Jeffries wrote: On 2014-01-08 07:19, Francesco Chemolli wrote: On 07 Jan 2014, at 18:24, cll_kfoury wrote: Hi all, I'm working with squid 2.7 with perl helper and every things work fine but try to work with squid 3.4.3 (beta version) and enable the helper

Re: helper program

On 2014-01-08 07:19, Francesco Chemolli wrote: On 07 Jan 2014, at 18:24, cll_kfoury wrote: Hi all, I'm working with squid 2.7 with perl helper and every things work fine but try to work with squid 3.4.3 (beta version) and enable the helper that already worked with 2.7, but it doesn't work, tr

Re: [PATCH] client-side redesign pt1 - Comm::TcpReceiver

This one with the mk2 patch actually attached. Amos === modified file 'src/comm/Makefile.am' --- src/comm/Makefile.am2012-03-29 09:22:41 + +++ src/comm/Makefile.am2013-10-16 12:14:31 + @@ -23,6 +23,8 @@ ModSelectWin32.cc \ TcpAcceptor.cc \ TcpAccepto

Re: [PATCH] client-side redesign pt1 - Comm::TcpReceiver

Updated patch attaced for audit. This one includes all the currently known bits for server-side delay pools so no audit omissions this time around. On 4/01/2014 8:16 a.m., Alex Rousskov wrote: > On 12/03/2013 10:05 PM, Amos Jeffries wrote: >> This patch abstracts the TCP socket operatio

debugs from an interesting CBDATA case study

For background: CBDATA uses an external lock counting and pointer management structure to perform auto_ptr/unique_ptr semantics on objects. If the objects "this" pointer does not match a magic binary pattern in the CBDATA object (cookie) for the class it will assert as shown below. For the code

Weird stuff today

Just noting this here for the record. If it happens to anyone else or again to me I will try to get enough details for a good bug report. The effect has since disappeared and the relevant Squid started working properly. ** The apparent action to fix was setting debug_options ALL,9 (!!). On upgrad

[RFC] MIME-Version / RFC 2045 compliance issues

I have been looking at the MIME header formatting and have come to the conclusion that Squid is not supposed to be sending the Mime-Version header any longer. It is roughly compliant with the syntax, but does not (and cannot for many delivered messages) meet with the formal requirements for emittin

Re: squid DNS internals confirmation.

On 2014-01-07 12:08, Eliezer Croitoru wrote: On 06/01/14 08:16, Amos Jeffries wrote: On 6/01/2014 5:16 p.m., Eliezer Croitoru wrote: Will the "/etc/hosts" file be loaded before these? /etc/resolv.conf contains the settings for DNS resolver component. /etc/hosts contains seed e

Re: [PATCH] Tokenizer

On 2014-01-07 10:23, Kinkie wrote: Hi, here's a merge proposal for Parser::Tokenizer, an implementation of the API suggested by Alex. The feature branch is available at lp:~squid/squid/sbuf-tokenizer in src/parser/Tokeniser.h * documentation call the second parameter of token() 'delimiters'

Re: squid DNS internals confirmation.

On 6/01/2014 5:16 p.m., Eliezer Croitoru wrote: > I am testing couple cases with squid which was slow on the WAN but fast > on the LAN. > The basic issue was that a simple "ping X" has *found* the host dns > record while squid did not for a long time(more then 30 secs). > > To make sure that I am

Re: [PATCH] More CharacterSet

On 2014-01-06 04:25, Kinkie wrote: Hi, the attached patch expands on the already-merged CharacterSet, adding: - operator+ - addRange - range-based constructor - a number of predefined sets, mostly taken from the HTTP specs - unit test It's a candidate for merging to trunk. in src/base/Char

Re: [PATCH] HTTP Parser upgrade

On 3/01/2014 8:08 a.m., Alex Rousskov wrote: > On 01/02/2014 06:45 AM, Amos Jeffries wrote: >>>> Http::Http1ParserPointer >>> >>> The proposed naming approach results in awkward names with too many >>> "HTTP"s in them. I suggest a different arra

Re: [PATCH] HTTP Parser upgrade

On 2/01/2014 10:08 a.m., Alex Rousskov wrote: > On 01/01/2014 05:15 AM, Amos Jeffries wrote: >> This patch renames the HttpParser class as Http1Parser (to differentiate >> from the future planned Http2Parser) and moves it into the Http namespace. > ... >> Also, the HttpRequ

Re: [PATCH] Large Rock and Collapsed Forwarding

On 1/01/2014 8:40 a.m., Alex Rousskov wrote: > Hello, > > The attached patch contains initial Large Rock and Collapsed > Forwarding support, also available as a Launchpad branch: > lp:~measurement-factory/squid/collapsed-fwd/ > > Large Rock: Support disk (and shared memory) caching of respons

Re: c++0x and RHEL5.X

On 30/12/2013 11:21 p.m., Kinkie wrote: > Hi all, >we have been talking about mandating c++11 some time in the next few > months. > Today I was trying to rely on a c++0x feature, and I realized that > RHEL5.X ships gcc 4.1.2, which doesn't support c++0x. RHEL6 ships g++ > 4.4.7, which supports

Re: What packages are needed in order to run squid in forward proxy, intercept proxy and TPROXY?

On 28/12/2013 10:21 a.m., Eliezer Croitoru wrote: > I do see at the configure the output: > configure: Using epoll for the IO loop. > checking if setresuid is actually implemented... yes > checking for constant CMSG_SPACE... yes > checking if strnstr is well implemented... no > checking if va_copy

Re: compile problem with 3.4.1

On 27/12/2013 11:35 a.m., Christian wrote: > Hi, > > unable to compile 3.4.1. > Hi Christian, please try the daily snapshot bundle. This should be fixed in there now. Amos

Re: SLES build error, what to do?

On 23/12/2013 12:08 p.m., Eliezer Croitoru wrote: > I am trying to build squid on SLES node to at least make sure that it > can run on it. > SLES offers (as much as I can tell) squid(2.7.STABLE5-2.12.16.1) and > squid3(3.1.12-8.12.1) packages. > > I am trying to make sure that squid 3.4(and maybe

Re: [PATCH] String API re-implementation using SBuf

On 20/11/2013 1:19 a.m., Amos Jeffries wrote: > [ And here is the new patch. ] > > > This patch implements Alex's suggestion for step 1 of String removal by ... > > * Replace String class internal buffer with an SBuf. > * Move converters to/from String and SBuf f

Re: [PATCH] reply_from_cache and reply_to_cache

Bumping this discussion. On 16/10/2013 4:36 a.m., Alex Rousskov wrote: > > Going forward, I think we need to decide: > > A) Whether altering the existing "cache" directive semantics is > desirable. If it is a good idea, we can remove or deprecate that option > and ignore its [end-of-life] existe

Re: [PATCH] Re: URL redirection with Squid 3.4

On 15/12/2013 5:11 p.m., Eliezer Croitoru wrote: > Hey, > > OK so now we know that there is a *bug* but I still do not think it > should affect any new revisions of squid which are out already. > > Since the "OK key=value" works as expected on all the basic helpers the > fix is to use new code bu

[PATCH] Re: URL redirection with Squid 3.4

On 14/12/2013 6:59 a.m., Marcus Kool wrote: > all, > > as discussed in a previous thread, the URL rewriter protocol of Squid > 3.4 is different than with previous versions of Squid. > Despite Amos' belief, I found out yesterday that there is no backward > compatibility since a typical redirection

Re: [Merge] lp:~squid/squid/sbuflist-merge into lp:squid

On 14/12/2013 11:17 p.m., Francesco Chemolli wrote: > Francesco Chemolli has proposed merging lp:~squid/squid/sbuflist-merge into > lp:squid. > > Requested reviews: > squid (squid) > > For more details, see: > https://code.launchpad.net/~squid/squid/sbuflist-merge/+merge/199024 > in src/SBuf

Re: [RFC] Tokenizer API

For the record this is now being developed as part of the parser upgrade branch: lp:~squid/squid/parser-ng Kinkie; I've just done an interim check... * the changes in CharacterSet introduced a infinite-loop bug in operator+=(). FYI: The uint8_t type value cannot represent the value 256, which i

Re: [PATCH] sslcrtvalidator_children concurrency option default value

On 2013-12-11 10:46, Tsantilas Christos wrote: Hi all, currently we have the following situation for sslcrtvalidator_children configuration option, which is may confusing people: 1) The testing sslcrtvalidator helper supports concurrency 2) The default concurrency if the sslcrtvalidator_childr

Re: [RFC] Tokenizer API

On 10/12/2013 9:38 p.m., Robert Collins wrote: > On 10 December 2013 19:13, Amos Jeffries wrote: > >> The problem with comparing input strings to a SBuf of characters is that >> parsing a input of length N againt charset of size M takes O(N*M) time. > > Huh? There are

Re: [RFC] Tokenizer API

On 10/12/2013 6:51 p.m., Francesco Chemolli wrote: >> Hi, >> SBuf supplies a few find() variants which could help which are not >> constant time but rely on lower-level primitives and related optimizations. >> My suggestion is to have CharacterSet be a SBuf and rely on them, at least >> for no

Re: [RFC] Tokenizer API

On 2013-12-10 08:00, Alex Rousskov wrote: Hello, The promised Tokenizer API proposal is attached. Compared to earlier proposals, this interface is simplified by focusing on finding tokens (requires knowledge of allowed and prohibited character sets), not parsing (requires knowledge of inpu

Re: [PATCH] SBufList

On 5/12/2013 6:34 a.m., Kinkie wrote: > Hi, > attaching v4, hand-unrolling SBufListJoin (as before, missing > Makefile.am changes), and marking wordlist as deprecated. > > On Tue, Dec 3, 2013 at 5:35 PM, Kinkie wrote: As this patch is a cherrypick of lp:~squid/squid/stringng, I'm not

[PATCH] client-side redesign pt1 - Comm::TcpReceiver

This patch abstracts the TCP socket operations out of existing client-side code into a class which can be re-used for any TCP socket code. It provides: * data members for referencing a TCP socket and read buffer. * methods for incremental parsing or processing of recieved data. * methods for ma

Re: [PATCH] Destroy ACLs in the reverse order of creation

On 29/11/2013 1:33 p.m., Alex Rousskov wrote: > Hello, > > The attached patch destroys ACLs in the reverse order of creation to > avoid destruction segfaults during reconfiguration. I could reproduce > segfaults in v3.3-based code. I saw access to the already destroyed ACL > memory in trunk; I

Re: [PATCH] annotation support for external ACL helpers

On 24/11/2013 12:02 a.m., Amos Jeffries wrote: > This completes the annotation support for common helper interfaces by > making custom key=value pairs sent by external ACL helpers in to > NotePair objects and attaching to the active request. > > The other side of this - sendin

Re: Introduction

On 27/11/2013 8:37 p.m., Goran Slavić wrote: >My name is Goran Slavic, > >I am currently writhing a masters theses on Faculty of Electrical > Engineering - University of Belgrade (Serbia). > Welcome aboard! Please take a few minutes to get acquainted with the proje

Re: [PATCH] Record SBuf and MemBlob sizes at destruct time

On 25/11/2013 6:15 a.m., Kinkie wrote: > Hi, > here's the updated patch (missing the Makefile.am bits, I'm > cherrypicking and it's just easier to do merge them by hand). > The merge will involve changesets 9679-9681, 9683,9687 of branch > lp:~squid/squid/stringng . > > Thanks > in src/tests/t

Re: [PATCH] SBufList

On 26/11/2013 11:40 a.m., Kinkie wrote: > Hi, > attached is v1 of SBufList. Its purpose is to be the eventual heir > to wordlist. For this reason I've implemented the bare minimum API to > cover wordlist's API, and kept code to a minimum by making it a > typedef of std::list. > > The patch is mi

Re: [PATCH] Record SBuf and MemBlob sizes at destruct time

On 24/11/2013 8:05 p.m., Kinkie wrote: > On Sun, Nov 24, 2013 at 12:16 AM, Amos Jeffries wrote: >> On 24/11/2013 9:29 a.m., Kinkie wrote: >>> Hi, >>> the attached patch records (and displays in cachemgr) the histogram >>> of the sizes of SBufs and MemBlobs

Re: [PATCH] Record SBuf and MemBlob sizes at destruct time

On 24/11/2013 9:29 a.m., Kinkie wrote: > Hi, > the attached patch records (and displays in cachemgr) the histogram > of the sizes of SBufs and MemBlobs. > > Builds and runs, but since SBuf is not yet used, no meaningful output > can be obtained. > The code lives as lp:~squid/squid/stringng (toge

[PATCH] StringArea removal

class StringArea was always intended to only be a temporary measure before SBuf was completed and merged. That has now happened. This replaces StringArea class with SBuf and drops the now unused code. Amos === modified file 'src/HttpHdrCc.cc' --- src/HttpHdrCc.cc2013-10-25 00:13:46 + +++

Re: [PATCH] String API re-implementation using SBuf

On 23/11/2013 5:49 a.m., Alex Rousskov wrote: > On 11/22/2013 08:25 AM, Amos Jeffries wrote: >>>>>> char const * >>>>>> String::termedBuf() const >>>>>> { >>>>>> -return buf_; >>>>>> +if (!defin

Re: [PATCH] String API re-implementation using SBuf

On 23/11/2013 5:35 a.m., Alex Rousskov wrote: > On 11/22/2013 08:25 AM, Amos Jeffries wrote: >> I've gone through the non-String code use of String::defined() and tried >> to find other ways of avoiding the defined()/NULL testing for ambiguous >> cases

[PATCH] annotation support for external ACL helpers

This completes the annotation support for common helper interfaces by making custom key=value pairs sent by external ACL helpers in to NotePair objects and attaching to the active request. The other side of this - sending values to the helper is deferred until the helper format can be converted to

Re: [PATCH] Add auth_param request_format, request_realm to proxy authentication schemes

On 23/11/2013 5:42 a.m., Tsantilas Christos wrote: > I am sending a new patch which I hope meets the requirements. > > It supports only one %key_extras authentication scheme parameter. This > is just append to the current request line format. Thank you. Looks much better. in src/auth/Config.cc

Re: [PATCH] String API re-implementation using SBuf

On 22/11/2013 8:20 a.m., Alex Rousskov wrote: > On 11/18/2013 05:13 AM, Amos Jeffries wrote: >> On 16/10/2013 7:12 a.m., Alex Rousskov wrote: >>> On 10/11/2013 11:03 PM, Amos Jeffries wrote: >>>> On 10/10/2013 10:12 p.m., Amos Jeffries wrote: >>>>>

Re: SBuf issue

On 22/11/2013 4:16 a.m., Alex Rousskov wrote: > On 11/21/2013 02:27 AM, Amos Jeffries wrote: >> While writing parser updates I have encountered the small problem that >> SBuf always *copies* data from non-Sbuf sources. There is absolutely no >> way provided to use a pre-alloca

SBuf issue

While writing parser updates I have encountered the small problem that SBuf always *copies* data from non-Sbuf sources. There is absolutely no way provided to use a pre-allocated I/O buffer as the backing store for Sbuf objects. This includes pointing SBuf at a already allocated global char*. It a

Re: [PATCH] reply_from_cache and reply_to_cache

On 16/10/2013 5:13 a.m., Alex Rousskov wrote: > On 10/14/2013 09:28 PM, Amos Jeffries wrote: >> >> I think store_miss and send_hit are the best out of those above. >> >> The naming of HIT directive is a bit tricky, but the above is no more or >> less ambiguous t

Re: [PATCH] Add auth_param request_format, request_realm to proxy authentication schemes

On 20/11/2013 12:49 p.m., Alex Rousskov wrote: > On 11/19/2013 04:01 PM, Amos Jeffries wrote: >> If you want to omit it from this patch and do it as a second one that >> would be okay. > > I do not like the idea of increasing the amount of work further by > splitting

Re: [PATCH] Add auth_param request_format, request_realm to proxy authentication schemes

On 2013-11-20 08:11, Alex Rousskov wrote: On 11/19/2013 02:54 AM, Tsantilas Christos wrote: My understanding is that we need: 1) Allow configuring the request format using one of the following: a) Use a request_format configuration parameter plus the %credentials formating code b) Use th

Re: [PATCH] HTTP/2.0 initial support

On 2013-11-19 08:42, Alex Rousskov wrote: On 11/15/2013 09:21 AM, Amos Jeffries wrote: On 24/08/2013 3:08 a.m., Alex Rousskov wrote: Perhaps you misunderstood my suggestion because it does not lead to any huge changes. In fact, it would probably simplify your patch. I suggest that the

Re: [PATCH] Add auth_param request_format, request_realm to proxy authentication schemes

On 2013-11-19 08:47, Alex Rousskov wrote: On 11/18/2013 10:57 AM, Tsantilas Christos wrote: On 11/15/2013 05:11 PM, Amos Jeffries wrote: in src/auth/ntlm/UserRequest.cc: * the YR and KK are lookups codes, not part of the credentials. They must be first on the helper query line and not

Re: [PATCH] String API re-implementation using SBuf

On 16/10/2013 7:12 a.m., Alex Rousskov wrote: > On 10/11/2013 11:03 PM, Amos Jeffries wrote: >> On 10/10/2013 10:12 p.m., Amos Jeffries wrote: >>> Replace String class internals with an SBuf. > FWIW, you made the review process more time consuming and less accurate

Re: [RFC] rename mime.conf

On 17/11/2013 3:30 p.m., Eliezer Croitoru wrote: > On 17/11/13 04:17, Amos Jeffries wrote: >>> Instead of jumping to change the file name can we*try* to "ping" these >>> >package distributors\maintainers and notify them that there is a >>> meaning >&g

Re: [PATCH] Add auth_param request_format, request_realm to proxy authentication schemes

On 17/11/2013 3:21 p.m., Alex Rousskov wrote: > On 11/15/2013 11:49 PM, Amos Jeffries wrote: >>>> Now about the name: "realm_format" is a bad choice IMO because some >>>> folks will think that it controls the format of the authentication realm >>>>

Re: [RFC] rename mime.conf

On 17/11/2013 9:13 a.m., Eliezer Croitoru wrote: > Just wanted to say this is the first time I have been seen a thread > about it. > If we will define it in the squid.conf as one of the main component it > will might look differently. > > On 11/16/2013 06:11 AM, Amos Jeffries w

Re: [PATCH] Add auth_param request_format, request_realm to proxy authentication schemes

On 16/11/2013 6:38 p.m., Alex Rousskov wrote: > On 11/15/2013 08:56 PM, Amos Jeffries wrote: >> On 16/11/2013 6:13 a.m., Alex Rousskov wrote: >>> On 11/15/2013 08:11 AM, Amos Jeffries wrote: >>>> On 30/10/2013 5:13 a.m., Tsantilas Christos wrote: >>>&g

[RFC] rename mime.conf

For quite some time I have been trying to get the package distributors to handle our mime.conf file as a Squid-specific config file, which gets FHS $(sysconf) installation instead of a Squid a data file, which gets FHS $(datadir) installation. But there are still some strong holdouts for a couple

Re: [PATCH] Add auth_param request_format, request_realm to proxy authentication schemes

On 16/11/2013 6:13 a.m., Alex Rousskov wrote: > On 11/15/2013 08:11 AM, Amos Jeffries wrote: >> On 30/10/2013 5:13 a.m., Tsantilas Christos wrote: >>> The attached patch add the "auth_param request_format" and "auth_param >>> request_realm&quo

Re: [PATCH] HTTP/2.0 initial support

New patch attached for review. On 24/08/2013 3:08 a.m., Alex Rousskov wrote: > On 08/22/2013 11:57 PM, Amos Jeffries wrote: >> On 23/08/2013 5:11 a.m., Alex Rousskov wrote: >>> Perhaps more importantly, the way you parse PRI requests may violate >>> draft-ietf-htt

Re: [PATCH] Add auth_param request_format, request_realm to proxy authentication schemes

On 30/10/2013 5:13 a.m., Tsantilas Christos wrote: > Hi all, > > The attached patch add the "auth_param request_format" and "auth_param > request_realm" to proxy authentication schemes. > > The request_format value used to define the format of the helper request > line. It is a "quoted string" wi

Re: [PATCH] Add auth_param request_format, request_realm to proxy authentication schemes

On 2013-11-14 22:36, Tsantilas Christos wrote: ping for this patch... If not objection I will commit this patch to trunk I'd like to have another read through it before that happens. Sorry. Will try to get that done later today. Amos

Re: url_rewrite_program in Squid 3.4

On 2013-11-13 01:02, Marcus Kool wrote: On 11/12/2013 09:41 AM, Amos Jeffries wrote: You can return OK without the url=, status= or rewrite-url= keys. url= is only required *if* the URL is being redirected. rewrite-url= is only required *if* the URL is being rewritten. Thanks for the

Re: url_rewrite_program in Squid 3.4

On 12/11/2013 11:06 p.m., Marcus Kool wrote: > >>> and must return >>> OK [status] url="newurl" >>> for a URL that needs to be redirected. >>> >>> One would expect that ERR is used for an error, not for something >>> that is the opposite of an error. >> >> The error is that the re-writer could

Re: url_rewrite_program in Squid 3.4

On 10/11/2013 3:20 a.m., Marcus Kool wrote: > Hi, > > I noticed that 3.4.0.2 uses a new protocol for the url_rewrite_program > that is incompatible with previous versions of Squid. > I am updating ufdbGuard, a URL redirector for Squid, for Squid 3.4 > to support the new protocol of Squid version 3

Re: [PATCH] Make Vary caching work better, take1

On 9/11/2013 8:30 a.m., Alex Rousskov wrote: > Hello, > > The attached patch contains three fixes related to Vary caching. > These fixes solve some but not all Vary-related problems. The fixes are > extracted from the unofficial bag5s branch on Launchpad but may apply to > trunk and/or v3.[34]

Re: [PATCH] adaptation_service ACL

On 7/11/2013 11:27 p.m., Tsantilas Christos wrote: > This patch adds the new ACL adaptation_service, to match the name of: > >- an adaptation service or group that had been applied to the master > transaction in the past >- an adaptation service or group that is being applied to the m

Re: Collapse forwarding range_offset_limit and 206 requests?

On 2013-11-11 03:08, Eliezer Croitoru wrote: I was wondering about something. Since I have seen that some code of collapse forwarding was written by Alex I was wondering about applying "range_offset_limit" In the docs it states(since 3.2): "usage: (size) [units] [[!]aclname]" which means I can u

Re: Wondering what is costs more? HTCP\ICP or frontend instance?

On 2013-11-08 08:59, Eliezer Croitoru wrote: Now these instances will probably will talk HTCP or ICP, HTCP preferred. Now I am wondering what will "cost" more? using one Frontend instance that will LoadBalance the traffic or plain HTCP? I expect that kernel level load balancing and HTCP bet

Re: [PATCH] Do not block on UDS sending errors

On 2013-11-08 06:19, Alex Rousskov wrote: Hello, The attached patch removes an ugly blocking sleep(3) call and resets UDS socket before retrying after a failed send attempt. Seems to work in my limited tests. This change addresses two XXXs in the UDS code, but does not fix the kid regi

Re: [RFC] Squid process model and -z

On 6/11/2013 11:00 a.m., Alex Rousskov wrote: On 11/01/2013 10:09 AM, Alex Rousskov wrote: I would also like to propose an alternative: Make "squid -z" a no-op (Squid would just exit immediately after detecting that option). Teach Squid to always prime cache_dirs at startup. This will remove al

Re: /bzr/squid3/trunk/ r13074: Cleanup transaction message size logging

On 1/11/2013 6:03 a.m., Alex Rousskov wrote: On 10/28/2013 08:24 PM, Amos Jeffries wrote: +/// counters for the response sent to client +MessageCounters adaptedReply; Please clarify by picking one: "response sent to client" or [received] "adapted reply".

[RFC] Squid process model

Hi all, As some of you are no doubt aware that one of the design issues we are facing with Squid these days is the process model. The current model has a very init.d centric design and shoots itself in the foot when encoutering third-party daemon management systems such as upstart, systemd,

Re: [PATCH] libecap v1.0 support

On 31/10/2013 1:16 p.m., Alex Rousskov wrote: Hello, The attached patch upgrades Squid to libecap v1.0, allowing asynchronous (e.g., threaded) eCAP adapters and eCAP version checks. After these changes, Squid can support eCAP adapters built with libecap v1.0, but stops supporting adapters

Re: [PATCH] This is a patch for support_ldap.cc in kerberos_ldap_group fro squid 3.4

On 29/10/2013 11:03 a.m., Markus Moeller wrote: Hi Amos, Apologies, I seem to have missed this. Could you please add it ? Thank you Markus Applied to squid-3. Thanks. Amos

Re: [PATCH] libecap v1.0 support

On 31/10/2013 6:04 p.m., Alex Rousskov wrote: On 10/30/2013 10:28 PM, Amos Jeffries wrote: On 31/10/2013 1:16 p.m., Alex Rousskov wrote: Hello, The attached patch upgrades Squid to libecap v1.0, allowing asynchronous (e.g., threaded) eCAP adapters and eCAP version checks. After these

Re: [PATCH] Hot idle

+1. Please commit ASAP. Amos

Re: [PATCH] libecap v1.0 support

On 31/10/2013 1:16 p.m., Alex Rousskov wrote: Hello, The attached patch upgrades Squid to libecap v1.0, allowing asynchronous (e.g., threaded) eCAP adapters and eCAP version checks. After these changes, Squid can support eCAP adapters built with libecap v1.0, but stops supporting adapters

Re: Squid toolchain requirements

On 24/10/2013 8:57 p.m., Eray Aslan wrote: On 23/10/13 14:16, Amos Jeffries wrote: Any help with the information is helpful. What I have so far is this set as of 3.2: My data points (not all config options are tested): squid-3.2.3 squid-3.3.9 automake 1.8.5 FAIL

<    1   2   3   4   5   6   7   8   9   10   >