Re: squid3_logdaemon work (round 1) complete, again!

2007-05-21 Thread Adrian Chadd
On Mon, May 21, 2007, Alex Rousskov wrote: You have not mentioned any bugs that this change fixes. From the discussion on this list, it looks like the change is far from trivial and is more complex than you originally thought. UDP logging, the primary factor for doing this changes (as far as

Re: squid3_logdaemon work (round 1) complete, again!

2007-05-19 Thread Guido Serassio
Hi Adrian, At 04.11 19/05/2007, Adrian Chadd wrote: On Fri, May 18, 2007, Adrian Chadd wrote: I've mostly copied over the older buffering thats in squid-2.6 and squid-3 logfile.c(c). Please review and provide feedback. I'm not going to try and improve the logfile writing in LogFileBlocking;

Re: squid3_logdaemon work (round 1) complete, again!

2007-05-19 Thread Adrian Chadd
On Sat, May 19, 2007, Guido Serassio wrote: Just run a build test on Windows, and is seems to build fine. Please verify if my change for the build error when using --enable-icmp is fine. Thanks for that! It looks fine. Adrian

Re: squid3_logdaemon work (round 1) complete, again!

2007-05-18 Thread Adrian Chadd
On Fri, May 18, 2007, Adrian Chadd wrote: I've mostly copied over the older buffering thats in squid-2.6 and squid-3 logfile.c(c). Please review and provide feedback. I'm not going to try and improve the logfile writing in LogFileBlocking; I just want it to mimic what the current codebase

Re: squid3_logdaemon work (round 1) complete, again!

2007-05-18 Thread Amos Jeffries
Adrian Chadd wrote: On Fri, May 18, 2007, Adrian Chadd wrote: I've mostly copied over the older buffering thats in squid-2.6 and squid-3 logfile.c(c). Please review and provide feedback. I'm not going to try and improve the logfile writing in LogFileBlocking; I just want it to mimic what the

Re: squid3_logdaemon work (round 1) complete

2007-05-17 Thread Henrik Nordstrom
tor 2007-05-17 klockan 08:19 +0800 skrev Adrian Chadd: Hm, which modern platforms are going to have trouble with stdio using FD 256 -and- C++ ? Solaris stdio is one. stdio is C not C++. No difference only because you compile C++ using stdio.. still C linked to a C++ program. C++ ostream

squid3_logdaemon work (round 1) complete

2007-05-16 Thread Adrian Chadd
I've completed the first round logfile code shifting. * use stdio for logfile writing; isn't going to be worse than how it was done before (still sync) * write LogFile class with basic interfaces * convert code to use LogFile methods * break out syslog and blocking into LogFileSyslog and

Re: squid3_logdaemon work (round 1) complete

2007-05-16 Thread Henrik Nordstrom
ons 2007-05-16 klockan 21:59 +0800 skrev Adrian Chadd: I've completed the first round logfile code shifting. * use stdio for logfile writing; isn't going to be worse than how it was done before (still sync) C stdio, or C++ OStream? stdio fails quite badly on some OS:es if using more than

Re: squid3_logdaemon work (round 1) complete

2007-05-16 Thread Guido Serassio
Hi Adrian, At 15.59 16/05/2007, Adrian Chadd wrote: I've completed the first round logfile code shifting. * use stdio for logfile writing; isn't going to be worse than how it was done before (still sync) * write LogFile class with basic interfaces * convert code to use LogFile methods *