URL: https://github.com/SSSD/sssd/pull/235
Title: #235: Allow using the "shortnames" feature without requiring any
configuration from the client side
jhrozek commented:
"""
* b78febe4c579f86f8007a27599605d1eb9f97a62
* 213048fd9a5e800deb74cb5b7f0eaf465945c640
*
URL: https://github.com/SSSD/sssd/pull/235
Title: #235: Allow using the "shortnames" feature without requiring any
configuration from the client side
fidencio commented:
"""
Added the "Accepted" label according to @pbrezina's ACK,
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/235
Title: #235: Allow using the "shortnames" feature without requiring any
configuration from the client side
pbrezina commented:
"""
Ack. Thank you for your patience.
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/235
Title: #235: Allow using the "shortnames" feature without requiring any
configuration from the client side
fidencio commented:
"""
On Tue, Apr 25, 2017 at 1:56 PM, Pavel Březina
wrote:
> Yes, I think we should log it so we
URL: https://github.com/SSSD/sssd/pull/235
Title: #235: Allow using the "shortnames" feature without requiring any
configuration from the client side
pbrezina commented:
"""
Yes, I think we should log it so we know what's used when we will debug issues
:-)
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/235
Title: #235: Allow using the "shortnames" feature without requiring any
configuration from the client side
fidencio commented:
"""
On Tue, Apr 25, 2017 at 12:37 PM, Pavel Březina
wrote:
> Thank you. Last trivial change, you
URL: https://github.com/SSSD/sssd/pull/235
Title: #235: Allow using the "shortnames" feature without requiring any
configuration from the client side
pbrezina commented:
"""
Thank you. Last trivial change, you have typo in commit message (domaiN):
`RESPONDER_COMMON: Improve
URL: https://github.com/SSSD/sssd/pull/235
Title: #235: Allow using the "shortnames" feature without requiring any
configuration from the client side
fidencio commented:
"""
Patch set updated according to @pbrezina's comments.
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/235
Title: #235: Allow using the "shortnames" feature without requiring any
configuration from the client side
pbrezina commented:
"""
Functional ack, but please, do the same change also for
`sss_resp_new_cr_domains_from_ipa_id_view`.
I would also
URL: https://github.com/SSSD/sssd/pull/235
Title: #235: Allow using the "shortnames" feature without requiring any
configuration from the client side
fidencio commented:
"""
@pbrezina: Yeah, not so easy to make the bad habits to go away :-)
Here's a diff of the changes made after your review:
URL: https://github.com/SSSD/sssd/pull/235
Title: #235: Allow using the "shortnames" feature without requiring any
configuration from the client side
pbrezina commented:
"""
Looking at the first patch, it is a bad habit to assign to an output variable
on failures. Whenever possible, we are
URL: https://github.com/SSSD/sssd/pull/235
Title: #235: Allow using the "shortnames" feature without requiring any
configuration from the client side
fidencio commented:
"""
CI results for the new patchset:
http://sssd-ci.duckdns.org/logs/job/67/95/summary.html
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/235
Title: #235: Allow using the "shortnames" feature without requiring any
configuration from the client side
fidencio commented:
"""
Okay, new patchset updated addressing @lslebodn's comments.
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/235
Title: #235: Allow using the "shortnames" feature without requiring any
configuration from the client side
fidencio commented:
"""
On Tue, Apr 18, 2017 at 2:12 PM, lslebodn wrote:
> On (18/04/17 03:47), fidencio wrote:
>
URL: https://github.com/SSSD/sssd/pull/235
Title: #235: Allow using the "shortnames" feature without requiring any
configuration from the client side
lslebodn commented:
"""
On (18/04/17 03:47), fidencio wrote:
>On Tue, Apr 18, 2017 at 11:33 AM, lslebodn wrote:
>
>>
URL: https://github.com/SSSD/sssd/pull/235
Title: #235: Allow using the "shortnames" feature without requiring any
configuration from the client side
fidencio commented:
"""
On Tue, Apr 18, 2017 at 11:33 AM, lslebodn wrote:
> Removing unit test is not acceptable
URL: https://github.com/SSSD/sssd/pull/235
Title: #235: Allow using the "shortnames" feature without requiring any
configuration from the client side
lslebodn commented:
"""
Removing unit test is not acceptable without writing new one.
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/235
Title: #235: Allow using the "shortnames" feature without requiring any
configuration from the client side
lslebodn commented:
"""
On (13/04/17 02:17), Jakub Hrozek wrote:
>retest this please
>
It is just wasting of time unless somebody will fix
URL: https://github.com/SSSD/sssd/pull/235
Title: #235: Allow using the "shortnames" feature without requiring any
configuration from the client side
fidencio commented:
"""
CI passed: http://sssd-ci.duckdns.org/logs/job/67/93/summary.html
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/235
Title: #235: Allow using the "shortnames" feature without requiring any
configuration from the client side
fidencio commented:
"""
retest this please
"""
See the full comment at
https://github.com/SSSD/sssd/pull/235#issuecomment-294443065
URL: https://github.com/SSSD/sssd/pull/235
Title: #235: Allow using the "shortnames" feature without requiring any
configuration from the client side
jhrozek commented:
"""
retest this please
"""
See the full comment at
https://github.com/SSSD/sssd/pull/235#issuecomment-293837126
URL: https://github.com/SSSD/sssd/pull/235
Title: #235: Allow using the "shortnames" feature without requiring any
configuration from the client side
fidencio commented:
"""
retest please
"""
See the full comment at
https://github.com/SSSD/sssd/pull/235#issuecomment-293834628
22 matches
Mail list logo