Re: [SSSD] [PATCH] SDAP: rename SDAP_CACHE_PURGE_TIMEOUT

2015-07-30 Thread Petr Cech
On 07/29/2015 08:51 PM, Jakub Hrozek wrote: On Wed, Jul 29, 2015 at 10:19:33AM +0200, Pavel Reichl wrote: Hello, please see trivial patch attached. While I was investigating case I found that to access value of 'ldap_purge_cache_timeout' option I need to use enum value

Re: [SSSD] [PATCH] mmap_cache: Override functions for initgr mmap cache

2015-07-30 Thread Lukas Slebodnik
On (29/07/15 17:05), Lukas Slebodnik wrote: On (17/07/15 14:07), Lukas Slebodnik wrote: From e6f0d72167fdd6921e173025a0e374996fc156d5 Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik lsleb...@redhat.com Date: Thu, 16 Jul 2015 16:54:00 +0200 Subject: [PATCH 1/2] mmap_cache: Rename variables ---

Re: [SSSD] [PATCH] mmap_cache: Override functions for initgr mmap cache

2015-07-30 Thread Michal Židek
On 07/30/2015 04:15 PM, Lukas Slebodnik wrote: On (29/07/15 17:05), Lukas Slebodnik wrote: Attached is a new patch set. I also contains fix for #2712 and not just for #2716. Otherwise there would be a crash. So it would be better push them together. Integration test were failing sporadically

Re: [SSSD] [PATCH] mmap_cache: Override functions for initgr mmap cache

2015-07-30 Thread Michal Židek
On 07/30/2015 05:06 PM, Michal Židek wrote: On 07/30/2015 04:15 PM, Lukas Slebodnik wrote: On (29/07/15 17:05), Lukas Slebodnik wrote: Attached is a new patch set. I also contains fix for #2712 and not just for #2716. Otherwise there would be a crash. So it would be better push them together.

[SSSD] [PATCH] Fetch one-way trust keytabs on sssd restart again

2015-07-30 Thread Jakub Hrozek
Hi, the attached patches implement fetching the keytab for one-way trusts on each sssd restart. This is in order for admin to be able to call service sssd restart and have fresh keytabs in case the trust was re-established in the meantime. Even though retrieving the keytabs is quite expensive

Re: [SSSD] [PATCHES] Add support for Smartcard authentication

2015-07-30 Thread Jakub Hrozek
On Thu, Jul 30, 2015 at 05:24:27PM +0200, Sumit Bose wrote: On Thu, Jul 30, 2015 at 11:10:33AM +0200, Jakub Hrozek wrote: On Wed, Jul 29, 2015 at 03:34:32PM +0200, Jakub Hrozek wrote: On Tue, Jul 28, 2015 at 10:43:13PM +0200, Sumit Bose wrote: Hi, I started the review,

Re: [SSSD] [PATCH] Fetch one-way trust keytabs on sssd restart again

2015-07-30 Thread Jakub Hrozek
On Thu, Jul 30, 2015 at 09:46:11PM +0200, Jakub Hrozek wrote: Hi, the attached patches implement fetching the keytab for one-way trusts on each sssd restart. This is in order for admin to be able to call service sssd restart and have fresh keytabs in case the trust was re-established in the

Re: [SSSD] [PATCH] IPA: Remove MPG groups if getgrgid was called before getpw()

2015-07-30 Thread Sumit Bose
On Wed, Jul 22, 2015 at 12:18:07PM +0200, Jakub Hrozek wrote: On Wed, Jul 22, 2015 at 10:01:31AM +0200, Sumit Bose wrote: On Tue, Jul 21, 2015 at 09:41:46PM +0200, Jakub Hrozek wrote: Hi, the attached patch fixes https://fedorahosted.org/sssd/ticket/2724 for me. I haven't yet heard

Re: [SSSD] [PATCH] IPA: Remove MPG groups if getgrgid was called before getpw()

2015-07-30 Thread Sumit Bose
On Thu, Jul 30, 2015 at 06:20:31PM +0200, Sumit Bose wrote: On Wed, Jul 22, 2015 at 12:18:07PM +0200, Jakub Hrozek wrote: On Wed, Jul 22, 2015 at 10:01:31AM +0200, Sumit Bose wrote: On Tue, Jul 21, 2015 at 09:41:46PM +0200, Jakub Hrozek wrote: Hi, the attached patch fixes

Re: [SSSD] [PATCH] CONFDB: Assume config file version 2 if missing

2015-07-30 Thread Lukas Slebodnik
On (27/07/15 16:12), Michal Židek wrote: On 07/27/2015 04:05 PM, Lukas Slebodnik wrote: On (27/07/15 15:58), Michal Židek wrote: On 07/24/2015 09:51 PM, Lukas Slebodnik wrote: On (07/07/15 19:45), Michal Židek wrote: Hi! See the attached patch. Ticket: https://fedorahosted.org/sssd/ticket/2688

[SSSD] [PATCH] sudo: use higher value wins when ordering rules

2015-07-30 Thread Pavel Březina
https://fedorahosted.org/sssd/ticket/2682 I think this option should stay undocumented since we want the users to use the correct sorting logic. From db18a64109d9e49fa8bcdad14f412c6e7159137d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?= pbrez...@redhat.com Date: Wed, 29 Jul

Re: [SSSD] [PATCHES] Add support for Smartcard authentication

2015-07-30 Thread Jakub Hrozek
On Wed, Jul 29, 2015 at 03:34:32PM +0200, Jakub Hrozek wrote: On Tue, Jul 28, 2015 at 10:43:13PM +0200, Sumit Bose wrote: Hi, I started the review, but because the patches are quite big, I will send my comments in batches. I hope that's fine. Thank you for the review.