[SSSD] Re: [PATCH] SDAP: Fix settig paging attribute in sdap_get_generic_ext_send

On Tue, Aug 30, 2016 at 5:26 PM, Lukas Slebodnik wrote: > ehlo, > > We should set pagging flag in state and not in local > variable which is not read anywhere in the function. > > Found by clang static analyzer. > > Do we need this patch also to stable branch? > > LS > >

[SSSD] Re: [PATCHES] Remove leftovers from diag_cmd and force_timeout

On 08/30/2016 06:35 PM, Fabiano Fidêncio wrote: Seems that when I sent the v2 of 7579cf99 and ac35fe74 I attached the wrong patches that ended up being pushed. Those patches were incomplete as there are still some leftovers. My bad, sorry :-\ See these 2 attached patches Best Regards, --

[SSSD] Re: [PATCH] SYSDB: Fix error handling in sysdb_get_user_members_recursively

On 08/30/2016 05:24 PM, Lukas Slebodnik wrote: ehlo, We should not ignore return values of functions. LS Hi Lukas, thanks for patch. LGTM, I am waiting for CI. Regards -- Petr^4 Čech ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

[SSSD] Re: [PATCH SET] SYSDB: Adding message to inform about cache

Bump. -- Petr^4 Čech ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org

[SSSD] Re: [PATCH] knownhostsproxy: use all of the getaddrinfo()

On (30/08/16 21:22), Jakub Hrozek wrote: >On Tue, Aug 30, 2016 at 06:51:43PM +0200, Lukas Slebodnik wrote: >> On (30/08/16 13:01), Pavel Březina wrote: >> >On 08/19/2016 02:03 PM, Jakub Hrozek wrote: >> >> Hi, >> >> >> >> I'm sending this patch on behalf of Nalin, who attached it to >> >>

[SSSD] [sssd PR#7] Fix initgroups with nested groups (+ack)

sumit-bose's pull request #7: "Fix initgroups with nested groups" label *ack* has been added See the full pull-request at https://github.com/SSSD/sssd/pull/7 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

[SSSD] [sssd PR#7] Fix initgroups with nested groups (comment)

jhrozek commented on a pull request """ OK, also looking at gdb confirms this is the right fix of course: (gdb) frame 0 #0 sdap_initgr_nested_get_membership_diff (mem_ctx=0x1176190, sysdb=0x1120040, opts=0x1134d90, dom=0x110b610, group=0x1184b80, all_groups=0x1184a80, groups_count=5,

[SSSD] [sssd PR#7] Fix initgroups with nested groups (comment)

jhrozek commented on a pull request """ On Tue, Aug 30, 2016 at 11:47:09AM -0700, lslebodn wrote: > Please provide a test-case (probably a hierarchy of groups) I was able to reproduce with: $ ipa group-show group20 Group name: group20 GID: 935600011 Member groups: group10, group11

[SSSD] Re: [PATCH] knownhostsproxy: use all of the getaddrinfo()

On Tue, Aug 30, 2016 at 06:51:43PM +0200, Lukas Slebodnik wrote: > On (30/08/16 13:01), Pavel Březina wrote: > >On 08/19/2016 02:03 PM, Jakub Hrozek wrote: > >> Hi, > >> > >> I'm sending this patch on behalf of Nalin, who attached it to > >> https://bugzilla.redhat.com/show_bug.cgi?id=1063278#c9

[SSSD] Re: [PATCH] sss_override: improve --debug description

On 08/05/2016 11:45 AM, Lukas Slebodnik wrote: On (15/03/16 12:40), Pavel Březina wrote: On 12/09/2015 01:16 PM, Jakub Hrozek wrote: On Wed, Dec 09, 2015 at 01:07:10PM +0100, Pavel Březina wrote: https://fedorahosted.org/sssd/ticket/2813 I wanted to split include/debug_levels.xml into more

[SSSD] [sssd PR#7] Fix initgroups with nested groups (comment)

lslebodn commented on a pull request """ Please provide a test-case (probably a hierarchy of groups) """ See the full comment at https://github.com/SSSD/sssd/pull/7#issuecomment-243540136 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

[SSSD] Re: [PATCH] knownhostsproxy: use all of the getaddrinfo()

On (30/08/16 13:01), Pavel Březina wrote: >On 08/19/2016 02:03 PM, Jakub Hrozek wrote: >> Hi, >> >> I'm sending this patch on behalf of Nalin, who attached it to >> https://bugzilla.redhat.com/show_bug.cgi?id=1063278#c9 > >Ack. > >Solves: >https://fedorahosted.org/sssd/ticket/1498 Denis wrote a

[SSSD] [PATCHES] Remove leftovers from diag_cmd and force_timeout

Seems that when I sent the v2 of 7579cf99 and ac35fe74 I attached the wrong patches that ended up being pushed. Those patches were incomplete as there are still some leftovers. My bad, sorry :-\ See these 2 attached patches Best Regards, -- Fabiano Fidêncio From

[SSSD] [sssd PR#7] Fix initgroups with nested groups (opened)

sumit-bose's pull request #7: "Fix initgroups with nested groups" was opened PR body: """ I think this is a leftover from the change to use fully-qualified names in sysdb. To verify this you can create a nested group in IPA. Without this patch the id command will only show the groups the user is

[SSSD] [PATCH] SDAP: Fix settig paging attribute in sdap_get_generic_ext_send

ehlo, We should set pagging flag in state and not in local variable which is not read anywhere in the function. Found by clang static analyzer. Do we need this patch also to stable branch? LS >From 6fb265fc7a41f037e3a380a4af7c60d513f48df4 Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik

[SSSD] [PATCH] SYSDB: Fix error handling in sysdb_get_user_members_recursively

ehlo, We should not ignore return values of functions. LS >From f60edd21fd40a2b3d5d7ca0ed0fb9918268f72fb Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik Date: Tue, 30 Aug 2016 15:37:43 +0200 Subject: [PATCH 1/2] SYSDB: Fix error handling in

[SSSD] Re: [PATCH SYSDB: Fix handling of version in sysdb_cache_connect_helper

On (30/08/16 16:59), Fabiano Fidêncio wrote: >Lukaš, > >On Tue, Aug 30, 2016 at 4:54 PM, Lukas Slebodnik wrote: >> ehlo, >> >> Clang static analyzer assume that ldb_search can found >> 0 entries in the tree "cn=sysdb". Thenvariable version >> could be used uninitialized. >>

[SSSD] [PATCH SYSDB: Fix handling of version in sysdb_cache_connect_helper

ehlo, Clang static analyzer assume that ldb_search can found 0 entries in the tree "cn=sysdb". Thenvariable version could be used uninitialized. We cannot get to such state in sssd but we already handle a case for more then one entry. LS >From 88da8ca30fbf50c320cd2bf4d79d84925cb0883c Mon Sep 17

[SSSD] [sssd PR#6] Applications should never define _USE_GNU themselves, but rely on _GNU_SOURCE (closed)

jhrozek's pull request #6: "Applications should never define _USE_GNU themselves, but rely on _GNU_SOURCE" was closed See the full pull-request at https://github.com/SSSD/sssd/pull/6 ... or pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd

[SSSD] [sssd PR#6] Applications should never define _USE_GNU themselves, but rely on _GNU_SOURCE (+pushed)

jhrozek's pull request #6: "Applications should never define _USE_GNU themselves, but rely on _GNU_SOURCE" label *pushed* has been added See the full pull-request at https://github.com/SSSD/sssd/pull/6 ___ sssd-devel mailing list

[SSSD] [sssd PR#6] Applications should never define _USE_GNU themselves, but rely on _GNU_SOURCE (-ack)

jhrozek's pull request #6: "Applications should never define _USE_GNU themselves, but rely on _GNU_SOURCE" label *ack* has been removed See the full pull-request at https://github.com/SSSD/sssd/pull/6 ___ sssd-devel mailing list

[SSSD] [sssd PR#6] Applications should never define _USE_GNU themselves, but rely on _GNU_SOURCE (comment)

jhrozek commented on a pull request """ * master: 1384d0ce6ea741aefb56b0006b6268d76e6cc2c2 """ See the full comment at https://github.com/SSSD/sssd/pull/6#issuecomment-243453157 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

[SSSD] [sssd PR#6] Applications should never define _USE_GNU themselves, but rely on _GNU_SOURCE (+ack)

jhrozek's pull request #6: "Applications should never define _USE_GNU themselves, but rely on _GNU_SOURCE" label *ack* has been added See the full pull-request at https://github.com/SSSD/sssd/pull/6 ___ sssd-devel mailing list

[SSSD] Re: [PATCH] sudo man page: say that we support IPA schema

On 08/30/2016 04:24 AM, Lukas Slebodnik wrote: On (30/08/16 10:14), Jakub Hrozek wrote: On Mon, Aug 29, 2016 at 11:28:44AM -0400, Justin Stephenson wrote: On 08/10/2016 04:33 PM, Dan Lavu wrote: I asked Lukas this but he wasn't positive, is the objectClasses different when adding

[SSSD] Re: [PATCH] Fix typo

On (30/08/16 13:41), Lukas Slebodnik wrote: >On (30/08/16 13:13), Pavel Březina wrote: >>On 08/05/2016 05:24 PM, Lukas Slebodnik wrote: >>> On (04/08/16 14:11), Pavel Březina wrote: >>> > Simple one liner attached. >>> >>> > From 6c3d8d6dba969960590d88bdd9a4ec2e9b4a1bb2 Mon Sep 17 00:00:00 2001

[SSSD] Re: [PATCH] PROXY: Adding proxy_max_children option

On 08/30/2016 01:21 PM, Pavel Březina wrote: On 08/30/2016 01:06 PM, Lukas Slebodnik wrote: On (30/08/16 13:03), Petr Cech wrote: On 08/30/2016 12:42 PM, Pavel Březina wrote: On 08/25/2016 01:43 PM, Petr Cech wrote: -/* FIXME: get max_children from configuration file */ -

[SSSD] [sssd PR#5] Miscellanous patches for the sssd-secrets responder (-ack)

jhrozek's pull request #5: "Miscellanous patches for the sssd-secrets responder" label *ack* has been removed See the full pull-request at https://github.com/SSSD/sssd/pull/5 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

[SSSD] [sssd PR#5] Miscellanous patches for the sssd-secrets responder (+pushed)

jhrozek's pull request #5: "Miscellanous patches for the sssd-secrets responder" label *pushed* has been added See the full pull-request at https://github.com/SSSD/sssd/pull/5 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

[SSSD] [sssd PR#5] Miscellanous patches for the sssd-secrets responder (closed)

jhrozek's pull request #5: "Miscellanous patches for the sssd-secrets responder" was closed See the full pull-request at https://github.com/SSSD/sssd/pull/5 ... or pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5/head:pr5 git checkout pr5

[SSSD] Re: [PATCH] PROXY: Adding proxy_max_children option

On (30/08/16 13:03), Petr Cech wrote: >On 08/30/2016 12:42 PM, Pavel Březina wrote: >> On 08/25/2016 01:43 PM, Petr Cech wrote: >> > -/* FIXME: get max_children from configuration file */ >> > -auth_ctx->max_children = 10; >> > +ret = confdb_get_int(be_ctx->cdb, be_ctx->conf_path, >> >

[SSSD] Re: [PATCH] PROXY: Adding proxy_max_children option

On 08/30/2016 12:42 PM, Pavel Březina wrote: On 08/25/2016 01:43 PM, Petr Cech wrote: -/* FIXME: get max_children from configuration file */ -auth_ctx->max_children = 10; +ret = confdb_get_int(be_ctx->cdb, be_ctx->conf_path, + CONFDB_PROXY_MAX_CHILDREN, 10, +

[SSSD] Re: [PATCH] knownhostsproxy: use all of the getaddrinfo()

On 08/19/2016 02:03 PM, Jakub Hrozek wrote: Hi, I'm sending this patch on behalf of Nalin, who attached it to https://bugzilla.redhat.com/show_bug.cgi?id=1063278#c9 Ack. Solves: https://fedorahosted.org/sssd/ticket/1498 ___ sssd-devel mailing list

[SSSD] [sssd PR#5] Miscellanous patches for the sssd-secrets responder (comment)

pbrezina commented on a pull request """ Ack. """ See the full comment at https://github.com/SSSD/sssd/pull/5#issuecomment-243402484 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

[SSSD] Re: [PATCH] PROXY: Adding proxy_max_children option

On 08/25/2016 01:43 PM, Petr Cech wrote: -/* FIXME: get max_children from configuration file */ -auth_ctx->max_children = 10; +ret = confdb_get_int(be_ctx->cdb, be_ctx->conf_path, + CONFDB_PROXY_MAX_CHILDREN, 10, + _children); +if

[SSSD] Re: [PATCH] sudo man page: say that we support IPA schema

On (30/08/16 10:14), Jakub Hrozek wrote: >On Mon, Aug 29, 2016 at 11:28:44AM -0400, Justin Stephenson wrote: >> On 08/10/2016 04:33 PM, Dan Lavu wrote: >> > I asked Lukas this but he wasn't positive, is the objectClasses different >> > when adding 'ldap_sudo_search_base' ? Or is it just location?

[SSSD] Re: [PATCH] sudo man page: say that we support IPA schema

On 08/30/2016 10:14 AM, Jakub Hrozek wrote: On Mon, Aug 29, 2016 at 11:28:44AM -0400, Justin Stephenson wrote: On 08/10/2016 04:33 PM, Dan Lavu wrote: I asked Lukas this but he wasn't positive, is the objectClasses different when adding 'ldap_sudo_search_base' ? Or is it just location?

[SSSD] Re: [PATCH] PROXY: Use right name in ldap filter

On Fri, Aug 26, 2016 at 03:10:39PM +0200, Lukas Slebodnik wrote: > ehlo, > > We used internal fq name in ldap filter > with id_provider proxy to files and auth provider > ldap > ACK thank you for catching this. ___ sssd-devel mailing list

[SSSD] Re: [PATCH] sudo man page: say that we support IPA schema

On Mon, Aug 29, 2016 at 11:28:44AM -0400, Justin Stephenson wrote: > On 08/10/2016 04:33 PM, Dan Lavu wrote: > > I asked Lukas this but he wasn't positive, is the objectClasses different > > when adding 'ldap_sudo_search_base' ? Or is it just location? > > > > Eitherway, I think this is going to

[SSSD] Re: [SSSD} [PATCH] Remove no longer used code

On (30/08/16 09:41), Petr Cech wrote: >On 08/30/2016 08:47 AM, Petr Cech wrote: >> >> >> On 08/30/2016 08:28 AM, Fabiano Fidêncio wrote: >> > On Tue, Aug 30, 2016 at 8:23 AM, Petr Cech wrote: >> > > On 08/15/2016 02:58 PM, Fabiano Fidêncio wrote: >> > > > >> > > > Those 3

[SSSD] Re: MONITOR: Add disable_netlink sssd.conf option

On Sat, Aug 27, 2016 at 12:54:53PM -0400, Justin Stephenson wrote: > Hello, > > The attached patches resolve https://fedorahosted.org/sssd/ticket/3142 > > However, I am having difficult with the man page addition to > 'src/man/sssd.conf.5.xml' for this new option. I have stared at the open and >

[SSSD] Re: [SSSD} [PATCH] Remove no longer used code

On 08/30/2016 08:28 AM, Fabiano Fidêncio wrote: On Tue, Aug 30, 2016 at 8:23 AM, Petr Cech wrote: On 08/15/2016 02:58 PM, Fabiano Fidêncio wrote: Those 3 patches are from Jakub and I've just done some minor adjustments and add myself as co-author of the first 2 patches.

[SSSD] Re: MONITOR: Add disable_netlink sssd.conf option

On 08/27/2016 06:54 PM, Justin Stephenson wrote: Hello, The attached patches resolve https://fedorahosted.org/sssd/ticket/3142 However, I am having difficult with the man page addition to 'src/man/sssd.conf.5.xml' for this new option. I have stared at the open and close xml tags(for far too

[SSSD] Re: [SSSD} [PATCH] Remove no longer used code

On Tue, Aug 30, 2016 at 8:23 AM, Petr Cech wrote: > On 08/15/2016 02:58 PM, Fabiano Fidêncio wrote: >> >> Those 3 patches are from Jakub and I've just done some minor >> adjustments and add myself as co-author of the first 2 patches. >> >> CI has passed:

[SSSD] Re: [SSSD} [PATCH] Remove no longer used code

On 08/15/2016 02:58 PM, Fabiano Fidêncio wrote: Those 3 patches are from Jakub and I've just done some minor adjustments and add myself as co-author of the first 2 patches. CI has passed: http://sssd-ci.duckdns.org/logs/job/51/55/summary.html Best Regards, -- Fabiano Fidêncio Hello, CI