[SSSD] [sssd PR#13][synchronized] MEMBEROF: Don't resolve members if they are removed

2016-09-19 Thread celestian
URL: https://github.com/SSSD/sssd/pull/13 Author: celestian Title: #13: MEMBEROF: Don't resolve members if they are removed Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/13/head:pr13 git checkout pr13 From

[SSSD] [sssd PR#25][-Accepted] TESTS: Add integration tests for the proxy provider of sssd-secrets

2016-09-19 Thread celestian
URL: https://github.com/SSSD/sssd/pull/25 Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#13][-Changes requested] MEMBEROF: Don't resolve members if they are removed

2016-09-19 Thread celestian
URL: https://github.com/SSSD/sssd/pull/13 Title: #13: MEMBEROF: Don't resolve members if they are removed Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#26][-Changes requested] KRB5: Fixing FQ name of user in krb5_setup()

2016-09-19 Thread celestian
URL: https://github.com/SSSD/sssd/pull/26 Title: #26: KRB5: Fixing FQ name of user in krb5_setup() Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#13][comment] MEMBEROF: Don't resolve members if they are removed

2016-09-19 Thread celestian
URL: https://github.com/SSSD/sssd/pull/13 Title: #13: MEMBEROF: Don't resolve members if they are removed celestian commented: """ Hello, I pushed new version with tests. Thanks @sumit-bose with help with the second patch. By the way is there better way how to write co-authors? Please tell

[SSSD] [sssd PR#13][synchronized] MEMBEROF: Don't resolve members if they are removed

2016-09-19 Thread celestian
URL: https://github.com/SSSD/sssd/pull/13 Author: celestian Title: #13: MEMBEROF: Don't resolve members if they are removed Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/13/head:pr13 git checkout pr13 From

[SSSD] [sssd PR#25][+Accepted] TESTS: Add integration tests for the proxy provider of sssd-secrets

2016-09-19 Thread celestian
URL: https://github.com/SSSD/sssd/pull/25 Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#25][comment] TESTS: Add integration tests for the proxy provider of sssd-secrets

2016-09-19 Thread celestian
URL: https://github.com/SSSD/sssd/pull/25 Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets celestian commented: """ ACK """ See the full comment at https://github.com/SSSD/sssd/pull/25#issuecomment-247988840 ___

[SSSD] [sssd PR#21][comment] IFP: expose user and group unique IDs through DBus

2016-09-19 Thread tequeter
URL: https://github.com/SSSD/sssd/pull/21 Title: #21: IFP: expose user and group unique IDs through DBus tequeter commented: """ Yes, I considered creating a ```group_attributes``` instead. However it would have taken more refactoring to avoid duplicating the ```user_attributes``` code than I

[SSSD] [sssd PR#25][comment] TESTS: Add integration tests for the proxy provider of sssd-secrets

2016-09-19 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/25 Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets lslebodn commented: """ On (19/09/16 04:39), Jakub Hrozek wrote: >On Mon, Sep 19, 2016 at 04:21:08AM -0700, celestian wrote: >> Well, >> >> LGTM. In my opinion we do not

[SSSD] [sssd PR#25][-Changes requested] TESTS: Add integration tests for the proxy provider of sssd-secrets

2016-09-19 Thread celestian
URL: https://github.com/SSSD/sssd/pull/25 Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#26][comment] KRB5: Fixing FQ name of user in krb5_setup()

2016-09-19 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/26 Title: #26: KRB5: Fixing FQ name of user in krb5_setup() lslebodn commented: """ On (19/09/16 04:39), celestian wrote: >Lukas, >sorry,I missed it. New version pushed. > >I have question, is there any way how to reply to your comment? This is new >one,

[SSSD] [sssd PR#25][synchronized] TESTS: Add integration tests for the proxy provider of sssd-secrets

2016-09-19 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/25 Author: jhrozek Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/25/head:pr25 git checkout pr25

[SSSD] [sssd PR#25][comment] TESTS: Add integration tests for the proxy provider of sssd-secrets

2016-09-19 Thread celestian
URL: https://github.com/SSSD/sssd/pull/25 Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets celestian commented: """ Jakub, IMHO we have description and the link to ticket. If it is not so strict then I am OK with it. """ See the full comment at

[SSSD] [sssd PR#26][comment] KRB5: Fixing FQ name of user in krb5_setup()

2016-09-19 Thread celestian
URL: https://github.com/SSSD/sssd/pull/26 Title: #26: KRB5: Fixing FQ name of user in krb5_setup() celestian commented: """ Lukas, sorry,I missed it. New version pushed. I have a question, is there any way how to reply to your comment? This is new one, it is not direct answer. """ See the

[SSSD] [sssd PR#26][comment] KRB5: Fixing FQ name of user in krb5_setup()

2016-09-19 Thread celestian
URL: https://github.com/SSSD/sssd/pull/26 Title: #26: KRB5: Fixing FQ name of user in krb5_setup() celestian commented: """ Lukas, sorry,I missed it. New version pushed. I have question, is there any way how to reply to your comment? This is new one, it is not direct answer. """ See the full

[SSSD] [sssd PR#25][comment] TESTS: Add integration tests for the proxy provider of sssd-secrets

2016-09-19 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/25 Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets jhrozek commented: """ On Mon, Sep 19, 2016 at 04:21:08AM -0700, celestian wrote: > Well, > > LGTM. In my opinion we do not have to run CI again for removing of comment. >

[SSSD] [sssd PR#26][synchronized] KRB5: Fixing FQ name of user in krb5_setup()

2016-09-19 Thread celestian
URL: https://github.com/SSSD/sssd/pull/26 Author: celestian Title: #26: KRB5: Fixing FQ name of user in krb5_setup() Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/26/head:pr26 git checkout pr26 From

[SSSD] [sssd PR#28][closed] PAM: call free only when memory is expected to be allocated

2016-09-19 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/28 Author: sumit-bose Title: #28: PAM: call free only when memory is expected to be allocated Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/28/head:pr28 git checkout pr28

[SSSD] [sssd PR#28][+Pushed] PAM: call free only when memory is expected to be allocated

2016-09-19 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/28 Title: #28: PAM: call free only when memory is expected to be allocated Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#25][comment] TESTS: Add integration tests for the proxy provider of sssd-secrets

2016-09-19 Thread celestian
URL: https://github.com/SSSD/sssd/pull/25 Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets celestian commented: """ Well, LGTM. In my opinion we do not have to run CI again for removing of comment. One last point. Jakub, please, could you fix the commit message?

[SSSD] [sssd PR#28][comment] PAM: call free only when memory is expected to be allocated

2016-09-19 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/28 Title: #28: PAM: call free only when memory is expected to be allocated lslebodn commented: """ master: * a8631161c47cbaefe7fd14b88202238bbdcc3dc8 LS """ See the full comment at https://github.com/SSSD/sssd/pull/28#issuecomment-247966703

[SSSD] [sssd PR#26][comment] KRB5: Fixing FQ name of user in krb5_setup()

2016-09-19 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/26 Title: #26: KRB5: Fixing FQ name of user in krb5_setup() lslebodn commented: """ On (19/09/16 04:07), celestian wrote: >I change the order of patches, thanks Lukas. > Thank you for changing the order but I cannot see requested changes in

[SSSD] [sssd PR#26][comment] KRB5: Fixing FQ name of user in krb5_setup()

2016-09-19 Thread celestian
URL: https://github.com/SSSD/sssd/pull/26 Title: #26: KRB5: Fixing FQ name of user in krb5_setup() celestian commented: """ I change the order of patches, thanks Lukas. """ See the full comment at https://github.com/SSSD/sssd/pull/26#issuecomment-247965473

[SSSD] [sssd PR#26][synchronized] KRB5: Fixing FQ name of user in krb5_setup()

2016-09-19 Thread celestian
URL: https://github.com/SSSD/sssd/pull/26 Author: celestian Title: #26: KRB5: Fixing FQ name of user in krb5_setup() Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/26/head:pr26 git checkout pr26 From

[SSSD] [sssd PR#26][comment] KRB5: Fixing FQ name of user in krb5_setup()

2016-09-19 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/26 Title: #26: KRB5: Fixing FQ name of user in krb5_setup() lslebodn commented: """ the following change looks werd to me `-dbus_free_string_array(arr_object_path);` `+dbus_free_string_array(discard_const(arr_object_path));` What about following

[SSSD] [sssd PR#26][comment] KRB5: Fixing FQ name of user in krb5_setup()

2016-09-19 Thread celestian
URL: https://github.com/SSSD/sssd/pull/26 Title: #26: KRB5: Fixing FQ name of user in krb5_setup() celestian commented: """ Hi, I push new version. All comments are addressed. Petr """ See the full comment at https://github.com/SSSD/sssd/pull/26#issuecomment-247961297

[SSSD] [sssd PR#26][synchronized] KRB5: Fixing FQ name of user in krb5_setup()

2016-09-19 Thread celestian
URL: https://github.com/SSSD/sssd/pull/26 Author: celestian Title: #26: KRB5: Fixing FQ name of user in krb5_setup() Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/26/head:pr26 git checkout pr26 From

[SSSD] [sssd PR#25][synchronized] TESTS: Add integration tests for the proxy provider of sssd-secrets

2016-09-19 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/25 Author: jhrozek Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/25/head:pr25 git checkout pr25

[SSSD] [sssd PR#25][comment] TESTS: Add integration tests for the proxy provider of sssd-secrets

2016-09-19 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/25 Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets jhrozek commented: """ On Mon, Sep 19, 2016 at 03:19:51AM -0700, lslebodn wrote: > On (16/09/16 06:56), Jakub Hrozek wrote: > >jhrozek commented on this pull request. > >>

[SSSD] [sssd PR#25][-Accepted] TESTS: Add integration tests for the proxy provider of sssd-secrets

2016-09-19 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/25 Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#25][comment] TESTS: Add integration tests for the proxy provider of sssd-secrets

2016-09-19 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/25 Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets lslebodn commented: """ On (16/09/16 06:56), Jakub Hrozek wrote: >jhrozek commented on this pull request. >> +# >+ >+import socket >+import requests >+ >+from

[SSSD] Re: [PATCHES] p11: add no_verification option

2016-09-19 Thread Jakub Hrozek
On Mon, Sep 19, 2016 at 12:06:23PM +0200, Jakub Hrozek wrote: > The backport was trivial, I'm just waiting for sssd-1-13 CI results. CI: http://sssd-ci.duckdns.org/logs/job/53/56/summary.html * sssd-1-13: * b76a0026a115a8a0362b1693404830fa3c68418b *

[SSSD] Re: [PATCHES] p11: add no_verification option

2016-09-19 Thread Jakub Hrozek
On Mon, Sep 19, 2016 at 11:48:54AM +0200, Sumit Bose wrote: > On Mon, Sep 19, 2016 at 10:14:57AM +0200, Jakub Hrozek wrote: > > On Thu, Jun 09, 2016 at 12:00:06PM +0200, Lukas Slebodnik wrote: > > > On (07/06/16 15:13), Jakub Hrozek wrote: > > > >On Tue, Jun 07, 2016 at 03:11:49PM +0200, Sumit

[SSSD] [sssd PR#28][comment] PAM: call free only when memory is expected to be allocated

2016-09-19 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/28 Title: #28: PAM: call free only when memory is expected to be allocated lslebodn commented: """ LGTM, Just waiting for the result of CI LS """ See the full comment at https://github.com/SSSD/sssd/pull/28#issuecomment-247952202

[SSSD] [sssd PR#21][comment] IFP: expose user and group unique IDs through DBus

2016-09-19 Thread tequeter
URL: https://github.com/SSSD/sssd/pull/21 Title: #21: IFP: expose user and group unique IDs through DBus tequeter commented: """ > > I considered using the gid provided by SSSD for that purpose (but it is not > > guaranteed to be consistent on all computers, from sssd-ldap(5)/ID MAPPING), > >

[SSSD] Re: [PATCHES] p11: add no_verification option

2016-09-19 Thread Sumit Bose
On Mon, Sep 19, 2016 at 10:14:57AM +0200, Jakub Hrozek wrote: > On Thu, Jun 09, 2016 at 12:00:06PM +0200, Lukas Slebodnik wrote: > > On (07/06/16 15:13), Jakub Hrozek wrote: > > >On Tue, Jun 07, 2016 at 03:11:49PM +0200, Sumit Bose wrote: > > >> On Tue, Jun 07, 2016 at 02:42:56PM +0200, Jakub

[SSSD] [sssd PR#28][opened] PAM: call free only when memory is expected to be allocated

2016-09-19 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/28 Author: sumit-bose Title: #28: PAM: call free only when memory is expected to be allocated Action: opened PR body: """ This fixes a potential double-free found by Coverity which was introduced by PR #17. """ To pull the PR as Git branch: git remote

[SSSD] [sssd PR#27][synchronized] Minor code changes

2016-09-19 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/27 Author: mzidek-rh Title: #27: Minor code changes Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/27/head:pr27 git checkout pr27 From ab432e4dd82a955c69b2b652082d6a9b62036f0e

[SSSD] Re: [PATCH] Failover to next server if authentication fails

2016-09-19 Thread Jakub Hrozek
On Mon, Sep 19, 2016 at 09:50:49AM +0200, Jakub Hrozek wrote: > On Wed, May 11, 2016 at 12:48:58PM +0200, Jakub Hrozek wrote: > > master: > > 8eb4a1f773b6c2246b0a6c6e3c3b8ef4d79c9ca6 > > 73dd89c3fb361dab43b4802510f4c64d282dbde1 > > I would like to backport these fixes to sssd-1-13..

[SSSD] Re: [PATCH] Fix offline resolution of autofs maps and netgroups

2016-09-19 Thread Lukas Slebodnik
On (19/09/16 10:06), Lukas Slebodnik wrote: >On (12/09/16 00:25), Jakub Hrozek wrote: >>From fd71b7ed7c588cc22402573b9877020234949e22 Mon Sep 17 00:00:00 2001 >>From: Jakub Hrozek >>Date: Fri, 9 Sep 2016 12:23:04 +0200 >>Subject: [PATCH 3/3] TESTS: Test offline netgroups

[SSSD] Re: [PATCH SET] AD_PROVIDER: ad_enabled_domains

2016-09-19 Thread Petr Cech
On 09/19/2016 10:16 AM, Jakub Hrozek wrote: On Mon, Sep 19, 2016 at 09:52:57AM +0200, Lukas Slebodnik wrote: On (19/09/16 09:46), Jakub Hrozek wrote: On Wed, Aug 17, 2016 at 04:13:02PM +0200, Jakub Hrozek wrote: On Wed, Aug 17, 2016 at 04:04:51PM +0200, Jakub Hrozek wrote: On Wed, Aug 17,

[SSSD] Re: [PATCH SET] AD_PROVIDER: ad_enabled_domains

2016-09-19 Thread Jakub Hrozek
On Mon, Sep 19, 2016 at 09:52:57AM +0200, Lukas Slebodnik wrote: > On (19/09/16 09:46), Jakub Hrozek wrote: > >On Wed, Aug 17, 2016 at 04:13:02PM +0200, Jakub Hrozek wrote: > >> On Wed, Aug 17, 2016 at 04:04:51PM +0200, Jakub Hrozek wrote: > >> > On Wed, Aug 17, 2016 at 12:23:37PM +0200, Petr Cech

[SSSD] Re: [PATCHES] p11: add no_verification option

2016-09-19 Thread Jakub Hrozek
On Thu, Jun 09, 2016 at 12:00:06PM +0200, Lukas Slebodnik wrote: > On (07/06/16 15:13), Jakub Hrozek wrote: > >On Tue, Jun 07, 2016 at 03:11:49PM +0200, Sumit Bose wrote: > >> On Tue, Jun 07, 2016 at 02:42:56PM +0200, Jakub Hrozek wrote: > >> > On Mon, May 30, 2016 at 04:32:20PM +0200, Sumit Bose

[SSSD] Re: [PATCH SET] AD_PROVIDER: ad_enabled_domains

2016-09-19 Thread Lukas Slebodnik
On (19/09/16 09:46), Jakub Hrozek wrote: >On Wed, Aug 17, 2016 at 04:13:02PM +0200, Jakub Hrozek wrote: >> On Wed, Aug 17, 2016 at 04:04:51PM +0200, Jakub Hrozek wrote: >> > On Wed, Aug 17, 2016 at 12:23:37PM +0200, Petr Cech wrote: >> > > Thanks Jakub, Lukas. >> > > >> > > CI tests almost

[SSSD] [sssd PR#25][+Accepted] TESTS: Add integration tests for the proxy provider of sssd-secrets

2016-09-19 Thread celestian
URL: https://github.com/SSSD/sssd/pull/25 Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#25][comment] TESTS: Add integration tests for the proxy provider of sssd-secrets

2016-09-19 Thread celestian
URL: https://github.com/SSSD/sssd/pull/25 Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets celestian commented: """ CI passed: http://sssd-ci.duckdns.org/logs/job/53/55/summary.html ACK """ See the full comment at