[SSSD] Re: [PATCH 1/6] RESPONDERS: Negcache in resp_ctx

2016-05-05 Thread Petr Cech
On 05/05/2016 12:08 PM, Petr Cech wrote: Hello, this patch set moves negative cache from particular context of given responder to common context resp_ctx. It is reaction on Fix taloc context for negative cache [1]. And it replaces it. It is applicable after [PATCH SET] Make the negcache

[SSSD] [PATCH] RESPONDERS: Negative caching of local users

2016-05-05 Thread Petr Cech
rom: Petr Cech <pc...@redhat.com> Date: Thu, 5 May 2016 11:16:14 -0400 Subject: [PATCH] RESPONDERS: Negative caching of local users This patch adds new option 'neg_cache_locals_timeout' into section of NSS responder. It allows negative caching of local groups and users. Default value is 0 wh

[SSSD] Re: [PATCH SET] Make the negcache timeout part of nc_ctx

2016-05-02 Thread Petr Cech
23 Mon Sep 17 00:00:00 2001 From: Petr Cech <pc...@redhat.com> Date: Fri, 22 Apr 2016 04:27:47 -0400 Subject: [PATCH 1/8] NEGCACHE: Adding timeout to struct sss_nc_ctx It adds timeout of negative cache to handling struct sss_nc_ctx. There is one change in API of negatice cache: * int sss_nca

[SSSD] Re: [PATCH] RESPONDERS: Negative caching of local users

2016-05-10 Thread Petr Cech
Thank you for review, Pavel. Regards -- Petr^4 Čech >From d3013d2c474f49159330e1916d931efb7d3cf532 Mon Sep 17 00:00:00 2001 From: Petr Cech <pc...@redhat.com> Date: Thu, 5 May 2016 11:16:14 -0400 Subject: [PATCH 1/2] RESPONDERS: Negative caching of local users This patch adds new option

[SSSD] [PATCH] NEGCACHE: Test fix

2016-04-19 Thread Petr Cech
Hello, there is little simple patch which fix the typo. Regards -- Petr^4 Čech >From 798e5a65b2dd8778cd9767a46fc04ca89b175d89 Mon Sep 17 00:00:00 2001 From: Petr Cech <pc...@redhat.com> Date: Tue, 19 Apr 2016 13:20:25 -0400 Subject: [PATCH] NEGCACHE: Test fix There were little t

[SSSD] Q: Rewriting negcache to save expiration time instead of saving time

2016-04-18 Thread Petr Cech
Hi, recently, negcache saves time of saving. If you check negcache, you need to provide appropriate timeout. I am working on [1] (NSS responder should negatively cache local users for a longer time) and I need to have two different timeouts. You can see new layer between negcache and

[SSSD] Re: Q: Rewriting negcache to save expiration time instead of saving time

2016-04-18 Thread Petr Cech
On 04/18/2016 12:50 PM, Petr Cech wrote: Hi, recently, negcache saves time of saving. If you check negcache, you need to provide appropriate timeout. I am working on [1] (NSS responder should negatively cache local users for a longer time) and I need to have two different timeouts. You can see

[SSSD] Re: [PATCH SET] TOOL: Invalidation of sudo rules at sss_cache

2016-04-18 Thread Petr Cech
On 04/15/2016 09:54 AM, Pavel Březina wrote: Hi, CI fails on debian: http://sssd-ci.duckdns.org/logs/job/41/53/debian_testing/ci.html Hi, CI tests passed locally. Moderate CI tests passed too: http://sssd-ci.duckdns.org/logs/job/41/87/summary.html And I have started rigorous CI tests

[SSSD] Re: [PATCH] NEGCACHE: Removing of condition for ttl = -1

2016-04-20 Thread Petr Cech
On 04/19/2016 01:55 PM, Petr Cech wrote: Hi, I found a strange condition in the function sss_ncache_check_str(). This condition causes the cache is NOT checked and the result of checking is automatically EEXIST. I dind't find call of sss_ncache_check_str() with ttl = -1, except in tests

[SSSD] Re: [PATCH] NEGCACHE: Test fix

2016-04-20 Thread Petr Cech
On 04/19/2016 07:24 PM, Petr Cech wrote: Hello, there is little simple patch which fix the typo. Hello, I wrote better commit message and I added to patch set with NEGCACHE: Removing of condition for ttl = -1 https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org

[SSSD] Re: [PATCH] intg: Use different uid range for add_remove tests

2016-04-20 Thread Petr Cech
On 04/18/2016 10:34 AM, Lukas Slebodnik wrote: ehlo, I use special local user for building srpms in mock and it caused failures for me with running integration tests. Attached patch is a workaround. The proper solution would be to wrap detection of active users in CWRAP enviroment. LS Hi

[SSSD] Re: [PATCH] intg: Use different uid range for add_remove tests

2016-04-20 Thread Petr Cech
On 04/20/2016 12:52 PM, Lukas Slebodnik wrote: On (20/04/16 12:36), Petr Cech wrote: >On 04/18/2016 10:34 AM, Lukas Slebodnik wrote: >>ehlo, >> >>I use special local user for building srpms in mock >>and it caused failures for me with running integration

[SSSD] Re: [PATCH SET] TOOL: Invalidation of sudo rules at sss_cache

2016-04-14 Thread Petr Cech
On 04/13/2016 12:09 PM, Petr Cech wrote: On 04/12/2016 04:24 PM, Petr Cech wrote: Hi, I investigated the time issue with Pavel -- it is probably known DST issue [1]. [1] https://fedorahosted.org/sssd/ticket/2316#comment:1 Patch uses work out with big time shift. Hi, attached patch set

[SSSD] [PATCH] AUTOFS: Removing of redudant debug message

2016-04-21 Thread Petr Cech
because it says that error is fatal. Regards -- Petr^4 Čech >From 545464d563f4aa382b7e177a4fe2ea966ab72c5b Mon Sep 17 00:00:00 2001 From: Petr Cech <pc...@redhat.com> Date: Thu, 21 Apr 2016 07:32:28 -0400 Subject: [PATCH] AUTOFS: Removing of redudant debug message Debug message has bee

[SSSD] Re: [PATCH] AUTOFS: Removing of redudant debug message

2016-04-21 Thread Petr Cech
On 04/21/2016 01:58 PM, Lukas Slebodnik wrote: On (21/04/16 13:44), Petr Cech wrote: >Hi, > >this patch is about removing redudant debug message from middle layer of >autofs responder. > >The point is that called function confdb_get_int() has very nice messaging. > >Ple

[SSSD] Re: [PATCH SET] TOOL: Invalidation of sudo rules at sss_cache

2016-04-19 Thread Petr Cech
On 04/18/2016 04:04 PM, Petr Cech wrote: On 04/15/2016 09:54 AM, Pavel Březina wrote: Hi, CI fails on debian: http://sssd-ci.duckdns.org/logs/job/41/53/debian_testing/ci.html Hi, CI tests passed locally. Moderate CI tests passed too: http://sssd-ci.duckdns.org/logs/job/41/87/summary.html

[SSSD] Re: [PATCH] NEGCACHE: Removing of condition for ttl = -1

2016-04-19 Thread Petr Cech
On 04/19/2016 02:07 PM, Lukas Slebodnik wrote: On (19/04/16 13:55), Petr Cech wrote: Hi, I found a strange condition in the function sss_ncache_check_str(). This condition causes the cache is NOT checked and the result of checking is automatically EEXIST. I dind't find call

[SSSD] [PATCH] NEGCACHE: Removing of condition for ttl = -1

2016-04-19 Thread Petr Cech
, no -1. Regards -- Petr^4 Čech >From 1fd913a19bbe260fa548c60f224d5072440e956d Mon Sep 17 00:00:00 2001 From: Petr Cech <pc...@redhat.com> Date: Tue, 19 Apr 2016 07:35:26 -0400 Subject: [PATCH] NEGCACHE: Removing of condition for ttl = -1 If ttl = -1 then function sss_ncache_check_str(

[SSSD] [PATCH] SYSDB: Removing of duplication of sysdb_ts_cache_attrs

2016-07-26 Thread Petr Cech
Hello list, there is a simple patch attached. Please, see the patch :-) Regards -- Petr^4 Čech >From 87143c65387c9aeea950b454c66ac771cd299790 Mon Sep 17 00:00:00 2001 From: Petr Cech <pc...@redhat.com> Date: Tue, 19 Jul 2016 14:28:35 +0200 Subject: [PATCH] SYSDB: Removing of du

[SSSD] [PATCH] TESTS: Fixing assignment discards 'const' qualifier

2016-07-26 Thread Petr Cech
Hello list, there is simple patch attached. Please, see subject for more info. Regards -- Petr^4 Čech >From da1f3c3835e47f46e9c1fba377c223b78aea9939 Mon Sep 17 00:00:00 2001 From: Petr Cech <pc...@redhat.com> Date: Tue, 26 Jul 2016 10:37:19 +0200 Subject: [PATCH] TESTS: Fixing a

[SSSD] Re: [PATCH] IPA: Removing of confusing debug message

2016-07-26 Thread Petr Cech
On 07/12/2016 12:01 PM, Pavel Březina wrote: On 07/12/2016 11:54 AM, Jakub Hrozek wrote: On Tue, Jul 12, 2016 at 11:52:05AM +0200, Pavel Březina wrote: On 07/12/2016 10:20 AM, Petr Cech wrote: Hello list, there is simple patch for [1]. I prepared two version: a) the first is for changing

[SSSD] Re: [PATCH] PROVIDER: Conversion empty string from D-Bus to NULL

2016-07-27 Thread Petr Cech
On 07/27/2016 10:57 AM, Pavel Březina wrote: On 07/27/2016 10:26 AM, Petr Cech wrote: Hi list, there is patch for [1] attached. [1] https://fedorahosted.org/sssd/ticket/3084 If you prefer two commits--one for reverting and second with the patch--don't hesitate to tell me it. :-) Regards

[SSSD] Re: [PATCH] LDAP: Removing of useless debug message

2016-07-12 Thread Petr Cech
On 07/11/2016 08:22 PM, Jakub Hrozek wrote: On Mon, Jul 11, 2016 at 09:49:15AM -0400, Stephen Gallagher wrote: On 07/11/2016 09:33 AM, Petr Cech wrote: Hi list, how Jakub mentioned on internal list this debug message should be removed. So I attached simple patch for it. I'd recommend

[SSSD] [PATCH] IPA: Removing of confusing debug message

2016-07-12 Thread Petr Cech
'trust direction not set'. So I vote for removing. Please do you have any other opinion? [1] https://fedorahosted.org/sssd/ticket/3090 Regards -- Petr^4 Čech >From c00336a3eee9472f7649ceea52bc0c0df3c0988b Mon Sep 17 00:00:00 2001 From: Petr Cech <pc...@redhat.com> Date: Tue, 12 Jul 2016

[SSSD] Re: [PATCH] SYSDB: Do not try to modify ts cache for unsupported DNs

2016-07-25 Thread Petr Cech
On 07/25/2016 08:41 AM, Lukas Slebodnik wrote: ehlo, There are some false positive debug messages when you try to invalidate automount entries. sh# sss_cache -A --debug=0x00f0 [sss_cache] [sysdb_set_cache_entry_attr] (0x0080): ldb_modify failed: [No such object](32)[ldb_wait: No such object

[SSSD] Re: [PATCH] LDAP: Removing of useless debug message

2016-07-22 Thread Petr Cech
bump -- Petr^4 Čech ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org

[SSSD] Re: [PATCH] SECRETS: Log message for failures with removing file

2016-07-22 Thread Petr Cech
On 07/22/2016 10:00 AM, Lukas Slebodnik wrote: ehlo, Nobody sent patch for this few weeks old coverity issue. So here you are :-) LS Hello Lukas, LGTM, I just wait for CI. Regards -- Petr^4 Čech ___ sssd-devel mailing list

[SSSD] Re: [PATCH] CI: Use /bin/sh as a CONFIG SHELL

2016-07-22 Thread Petr Cech
On 07/22/2016 07:48 AM, Petr Cech wrote: On 07/21/2016 06:34 PM, Lukas Slebodnik wrote: ehlo, ATM, test are failing on debian testing and fedora rawhide. The failures on debian_testing are caused by bug in /bin/bash http://sssd-ci.duckdns.org/logs-test/job/3/27/debian_testing/ci.html http

[SSSD] Re: [PATCH] CI: Use /bin/sh as a CONFIG SHELL

2016-07-21 Thread Petr Cech
On 07/21/2016 06:34 PM, Lukas Slebodnik wrote: ehlo, ATM, test are failing on debian testing and fedora rawhide. The failures on debian_testing are caused by bug in /bin/bash http://sssd-ci.duckdns.org/logs-test/job/3/27/debian_testing/ci.html

[SSSD] Re: [PATCH] PROVIDERS: Default values in debug

2016-07-29 Thread Petr Cech
bump -- Petr^4 Čech ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org

[SSSD] Re: [PATCH] PROVIDERS: Default values in debug

2016-07-29 Thread Petr Cech
On 07/29/2016 10:17 AM, Lukas Slebodnik wrote: On (29/07/16 10:05), Petr Cech wrote: On 07/29/2016 09:52 AM, Lukas Slebodnik wrote: On (29/07/16 09:41), Petr Cech wrote: On 07/29/2016 09:23 AM, Lukas Slebodnik wrote: What is a benefit of string "default ". Benefit is that we pr

[SSSD] Re: [PATCH] PROVIDERS: Default values in debug

2016-07-29 Thread Petr Cech
On 07/29/2016 09:23 AM, Lukas Slebodnik wrote: What is a benefit of string "default ". Benefit is that we provide more information. How does it improve reading debug messages with very high debug level? This patch doesn't improve reading in such way. Why should we care wheter it's

[SSSD] Re: [PATCH] PROVIDERS: Default values in debug

2016-07-29 Thread Petr Cech
On 07/29/2016 09:52 AM, Lukas Slebodnik wrote: On (29/07/16 09:41), Petr Cech wrote: On 07/29/2016 09:23 AM, Lukas Slebodnik wrote: What is a benefit of string "default ". Benefit is that we provide more information. How does it improve reading debug messages with very high d

[SSSD] [PATCH] LDAP: Improving debug message

2016-07-26 Thread Petr Cech
Hello list, in my opinion we might refer to user by their name and not by 'for loop' variable. This patch fixes this issue. I hit the issue during some debugging. Regards -- Petr^4 Čech >From 513a70ca5fb79973077725df84905921af30be8a Mon Sep 17 00:00:00 2001 From: Petr Cech <pc...@redh

[SSSD] Re: [PATCH SET] AD_PROVIDER: ad_enabled_domains

2016-07-25 Thread Petr Cech
On 07/21/2016 10:21 AM, Jakub Hrozek wrote: On Wed, Jul 20, 2016 at 12:24:11PM +0200, Jakub Hrozek wrote: > On Fri, Jul 15, 2016 at 03:24:15PM +0200, Petr Cech wrote: > > > > On 07/12/2016 10:31 AM, Pavel Březina wrote: > > > On 07/11/2016 05:12 PM, Petr Cech wrote:

[SSSD] Re: [PATCH] SYSDB: Do not try to modify ts cache for unsupported DNs

2016-07-25 Thread Petr Cech
On 07/25/2016 08:47 AM, Petr Cech wrote: On 07/25/2016 08:41 AM, Lukas Slebodnik wrote: ehlo, There are some false positive debug messages when you try to invalidate automount entries. sh# sss_cache -A --debug=0x00f0 [sss_cache] [sysdb_set_cache_entry_attr] (0x0080): ldb_modify failed

[SSSD] Re: [PATCH] Amend debug messages after failure of unlink

2016-07-25 Thread Petr Cech
On 07/25/2016 09:38 AM, Lukas Slebodnik wrote: ehlo, Some messages did not have errno or name of problematic file. There was also improper use of negative value. The function strerror was called with -1 instead of errno. LS Hi Lukas, LGTM, just wait for CI. Regards -- Petr^4 Čech

[SSSD] Re: [PATCH] Change debug level of config error msgs

2016-07-27 Thread Petr Cech
On 07/27/2016 02:32 PM, Michal Židek wrote: Hi, I believe that this patch makes pinpointing of config errors a little easier. Especially when using sssctl tool that currently refuses to start a command when there are syntax errors in sssd.conf, but by default it does not print problematic line

[SSSD] Re: [PATCH] Change debug level of config error msgs

2016-07-27 Thread Petr Cech
On 07/27/2016 03:05 PM, Petr Cech wrote: On 07/27/2016 02:32 PM, Michal Židek wrote: Hi, I believe that this patch makes pinpointing of config errors a little easier. Especially when using sssctl tool that currently refuses to start a command when there are syntax errors in sssd.conf

[SSSD] Re: [PATCH] IPA: Removing of confusing debug message

2016-08-02 Thread Petr Cech
bump -- Petr^4 Čech ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org

[SSSD] Re: [PATCH] ipa_netgroups: Lowercase key to htable

2016-08-02 Thread Petr Cech
On 08/02/2016 11:09 AM, Michal Židek wrote: Hi! When reviewing Petr's netgroup patch I found some issues with netgroups when using IPA provider. Attached patch fixes one of them. I filed ticket for the other issue here: https://fedorahosted.org/sssd/ticket/3117 Reviewing this is not priority

[SSSD] Re: [PATCH] ipa_netgroups: Lowercase key to htable

2016-08-02 Thread Petr Cech
On 08/02/2016 12:41 PM, Petr Cech wrote: On 08/02/2016 11:09 AM, Michal Židek wrote: Hi! When reviewing Petr's netgroup patch I found some issues with netgroups when using IPA provider. Attached patch fixes one of them. I filed ticket for the other issue here: https://fedorahosted.org/sssd

[SSSD] Re: [PATCH] LDAP: Improving debug message

2016-08-02 Thread Petr Cech
bump -- Petr^4 Čech ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org

[SSSD] Re: [PATCH] LDAP: Fixing of removing netgroup from cache

2016-08-03 Thread Petr Cech
On 08/03/2016 12:46 PM, Lukas Slebodnik wrote: On (03/08/16 12:34), Michal Židek wrote: Two nitpicks, see inline. On 07/22/2016 02:34 PM, Petr Cech wrote: +static errno_t add_to_missing_attrs (TALLOC_CTX * mem_ctx, + struct sysdb_attrs *attrs

[SSSD] Re: [PATCH 1/2] LDAP: Adding support for SIGTERM signal

2016-08-11 Thread Petr Cech
On 08/09/2016 02:49 PM, Jakub Hrozek wrote: On Tue, Aug 09, 2016 at 12:57:58PM +0200, Petr Cech wrote: On 08/09/2016 11:26 AM, Jakub Hrozek wrote: On Mon, Aug 08, 2016 at 09:46:55AM +0200, Petr Cech wrote: On 08/04/2016 05:01 PM, Petr Cech wrote: On 08/04/2016 04:35 PM, Petr Cech wrote: Hi

[SSSD] Re: [PATCH] NSS: Use correct name for invalidating memory cache

2016-08-09 Thread Petr Cech
On 08/09/2016 07:10 PM, Lukas Slebodnik wrote: On (09/08/16 10:21), Jakub Hrozek wrote: On Mon, Aug 08, 2016 at 06:37:10PM +0200, Lukas Slebodnik wrote: ehlo, yet another patch which fixes issues caused by sysdb refactoring. reproducer: a) add user with two groups b) call id user c) add

[SSSD] Re: [PATCH] dyndns-tests: Fix false positive failures

2016-08-10 Thread Petr Cech
On 08/10/2016 08:15 AM, Lukas Slebodnik wrote: On (10/08/16 08:11), Lukas Slebodnik wrote: On (10/08/16 08:09), Lukas Slebodnik wrote: ehlo, yesterdat, I build a sssd in copr for various distributions and the dyndns-tests failed for me few time. We had a similar failures also in CI

[SSSD] Re: [PATCH SET] AD_PROVIDER: ad_enabled_domains

2016-08-10 Thread Petr Cech
Sorry, I experienced some issue with mailing list. So I send it again. Forwarded Message Subject: Re: [SSSD] Re: [PATCH SET] AD_PROVIDER: ad_enabled_domains Date: Tue, 9 Aug 2016 17:29:38 +0200 From: Petr Cech <pc...@redhat.com> To: sssd-devel@lists.fedorahosted.org On

[SSSD] Re: [PATCH] NSS: Use correct name for invalidating memory cache

2016-08-10 Thread Petr Cech
On 08/10/2016 07:30 AM, Petr Cech wrote: On 08/09/2016 07:10 PM, Lukas Slebodnik wrote: On (09/08/16 10:21), Jakub Hrozek wrote: On Mon, Aug 08, 2016 at 06:37:10PM +0200, Lukas Slebodnik wrote: ehlo, yet another patch which fixes issues caused by sysdb refactoring. reproducer: a) add user

[SSSD] Re: [PATCH] dyndns-tests: Fix false positive failures

2016-08-10 Thread Petr Cech
On 08/10/2016 08:28 AM, Petr Cech wrote: On 08/10/2016 08:15 AM, Lukas Slebodnik wrote: On (10/08/16 08:11), Lukas Slebodnik wrote: On (10/08/16 08:09), Lukas Slebodnik wrote: ehlo, yesterdat, I build a sssd in copr for various distributions and the dyndns-tests failed for me few time. We

[SSSD] Re: [PATCH] PROVIDER: Conversion empty string from D-Bus to NULL

2016-08-03 Thread Petr Cech
bump -- Petr^4 Čech ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org

[SSSD] Re: [PATCH] LDAP: Improving debug message

2016-08-04 Thread Petr Cech
On 08/03/2016 09:54 AM, Fabiano Fidêncio wrote: Hey! I'd do it a bit differently. Hello Fabiano, I am glad for another point of view. diff --git a/src/providers/ldap/sdap_async_users.c b/src/providers/ldap/sdap_async_users.c index

[SSSD] Re: [PATCH SET] AD_PROVIDER: ad_enabled_domains

2016-08-03 Thread Petr Cech
bump -- Petr^4 Čech ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org

[SSSD] Re: [PATCH] UTILS: Fixing duplication of pid file declaration

2016-08-03 Thread Petr Cech
bump -- Petr^4 Čech ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org

[SSSD] [PATCH 1/2] LDAP: Adding support for SIGTERM signal

2016-08-04 Thread Petr Cech
974 Mon Sep 17 00:00:00 2001 From: Petr Cech <pc...@redhat.com> Date: Thu, 4 Aug 2016 16:25:28 +0200 Subject: [PATCH 1/2] LDAP: Adding support for SIGTERM signal We add support for handling SIGTERM signal. If ldap_child receives SIGTERM signal it removes temporary file. Resolv

[SSSD] Re: [PATCH 1/2] LDAP: Adding support for SIGTERM signal

2016-08-04 Thread Petr Cech
On 08/04/2016 04:35 PM, Petr Cech wrote: Hi list, there is the first version of patch for [1]. I need to investigate if we have the same issue in other *_childs. I tested it with sleep() added into ldap_child code. [1] https://fedorahosted.org/sssd/ticket/3106 I know, it is not perfect

[SSSD] Re: [PATCH] LDAP: Fixing of removing netgroup from cache

2016-08-12 Thread Petr Cech
On 08/11/2016 08:53 AM, Petr Cech wrote: On 08/03/2016 12:34 PM, Michal Židek wrote: Two nitpicks, see inline. On 07/22/2016 02:34 PM, Petr Cech wrote: +static errno_t add_to_missing_attrs (TALLOC_CTX * mem_ctx, + struct sysdb_attrs *attrs

[SSSD] Re: [PATCH] Better error message if sssctl is ran w/o activating the IFP responder

2016-08-14 Thread Petr Cech
On 08/12/2016 06:24 PM, Justin Stephenson wrote: Simple error message patch, resolves https://fedorahosted.org/sssd/ticket/3130 Kind regards, Justin Stephenson 0001-SSSCTL-More-helpful-error-message-when-InfoPipe-is-d.patch From 080f9639e120329d069d4f0ba5edcc776e0179c2 Mon Sep 17 00:00:00

[SSSD] Re: [PATCH] Better error message if sssctl is ran w/o activating the IFP responder

2016-08-15 Thread Petr Cech
On 08/15/2016 07:58 AM, Petr Cech wrote: On 08/12/2016 06:24 PM, Justin Stephenson wrote: Simple error message patch, resolves https://fedorahosted.org/sssd/ticket/3130 Kind regards, Justin Stephenson 0001-SSSCTL-More-helpful-error-message-when-InfoPipe-is-d.patch From

[SSSD] Re: [PATCH 1/2] LDAP: Adding support for SIGTERM signal

2016-08-15 Thread Petr Cech
On 08/12/2016 04:13 PM, Jakub Hrozek wrote: On Fri, Aug 12, 2016 at 03:41:26PM +0200, Petr Cech wrote: On 08/12/2016 03:07 PM, Jakub Hrozek wrote: Logs now look like: [root@albireo sssd]# grep 'child' sssd_ipa.cygnus.dev.log [child_handler_setup] (0x2000): Setting up signal handler up

[SSSD] Re: [PATCH 1/2] LDAP: Adding support for SIGTERM signal

2016-08-15 Thread Petr Cech
On 08/15/2016 09:59 AM, Jakub Hrozek wrote: On Mon, Aug 15, 2016 at 09:47:27AM +0200, Petr Cech wrote: On 08/12/2016 04:13 PM, Jakub Hrozek wrote: On Fri, Aug 12, 2016 at 03:41:26PM +0200, Petr Cech wrote: On 08/12/2016 03:07 PM, Jakub Hrozek wrote: Logs now look like: [root@albireo sssd

[SSSD] Re: [PATCH SET] AD_PROVIDER: ad_enabled_domains

2016-08-12 Thread Petr Cech
On 08/12/2016 11:27 AM, Jakub Hrozek wrote: On Wed, Aug 10, 2016 at 08:54:25AM +0200, Petr Cech wrote: Sorry, I experienced some issue with mailing list. So I send it again. Forwarded Message Subject: Re: [SSSD] Re: [PATCH SET] AD_PROVIDER: ad_enabled_domains Date: Tue, 9 Aug

[SSSD] Re: [PATCH 1/2] LDAP: Adding support for SIGTERM signal

2016-08-12 Thread Petr Cech
On 08/12/2016 11:06 AM, Jakub Hrozek wrote: On Thu, Aug 11, 2016 at 02:23:39PM +0200, Petr Cech wrote: On 08/09/2016 02:49 PM, Jakub Hrozek wrote: On Tue, Aug 09, 2016 at 12:57:58PM +0200, Petr Cech wrote: On 08/09/2016 11:26 AM, Jakub Hrozek wrote: On Mon, Aug 08, 2016 at 09:46:55AM +0200

[SSSD] Re: [PATCH SET] AD_PROVIDER: ad_enabled_domains

2016-08-12 Thread Petr Cech
On 08/12/2016 03:36 PM, Jakub Hrozek wrote: On Fri, Aug 12, 2016 at 02:51:21PM +0200, Petr Cech wrote: On 08/12/2016 11:27 AM, Jakub Hrozek wrote: On Wed, Aug 10, 2016 at 08:54:25AM +0200, Petr Cech wrote: Sorry, I experienced some issue with mailing list. So I send it again

[SSSD] Re: [PATCH 1/2] LDAP: Adding support for SIGTERM signal

2016-08-12 Thread Petr Cech
On 08/12/2016 03:07 PM, Jakub Hrozek wrote: Logs now look like: > > [root@albireo sssd]# grep 'child' sssd_ipa.cygnus.dev.log > [child_handler_setup] (0x2000): Setting up signal handler up for pid [18835] > [child_handler_setup] (0x2000): Signal handler set up for pid [18835] >

[SSSD] Re: [PATCH] LDAP: Fixing of removing netgroup from cache

2016-08-11 Thread Petr Cech
On 08/03/2016 12:34 PM, Michal Židek wrote: Two nitpicks, see inline. On 07/22/2016 02:34 PM, Petr Cech wrote: +static errno_t add_to_missing_attrs (TALLOC_CTX * mem_ctx, + struct sysdb_attrs *attrs, + const char *ext_key

[SSSD] Re: [PATCH] intg: Allow to test netgroups

2016-08-10 Thread Petr Cech
On 08/09/2016 07:09 PM, Lukas Slebodnik wrote: ehlo, attcheck patch is a python wrapper for netgroup lookups in sssd. LS Hello Lukas, thank you for this patch. You helped me. CI passed: http://sssd-ci.duckdns.org/logs/job/51/24/summary.html I found one nitpick, comment is in code bellow.

[SSSD] Re: Rethinking debug levels

2016-07-14 Thread Petr Cech
On 07/14/2016 11:35 AM, Michal Židek wrote: On 07/14/2016 10:12 AM, Pavel Březina wrote: We recently focus on providing lots of tracing messages in new code that helps us follow the code, however this makes the debug logs quite big and we usually focus only on a specific area or task while

[SSSD] Re: [PATCH SET] AD_PROVIDER: ad_enabled_domains

2016-07-21 Thread Petr Cech
On 07/21/2016 10:21 AM, Jakub Hrozek wrote: On Wed, Jul 20, 2016 at 12:24:11PM +0200, Jakub Hrozek wrote: On Fri, Jul 15, 2016 at 03:24:15PM +0200, Petr Cech wrote: On 07/12/2016 10:31 AM, Pavel Březina wrote: On 07/11/2016 05:12 PM, Petr Cech wrote: On 07/05/2016 08:44 AM, Jakub Hrozek

[SSSD] Re: [PATCH SET] AD_PROVIDER: ad_enabled_domains

2016-07-15 Thread Petr Cech
On 07/12/2016 10:31 AM, Pavel Březina wrote: On 07/11/2016 05:12 PM, Petr Cech wrote: On 07/05/2016 08:44 AM, Jakub Hrozek wrote: On Mon, Jun 27, 2016 at 03:37:25PM +0200, Petr Cech wrote: ... +static errno_t ad_get_enabled_domains(TALLOC_CTX *mem_ctx

[SSSD] Re: [PATCH SET] AD_PROVIDER: ad_enabled_domains

2016-07-15 Thread Petr Cech
On 07/12/2016 10:31 AM, Pavel Březina wrote: On 07/11/2016 05:12 PM, Petr Cech wrote: On 07/05/2016 08:44 AM, Jakub Hrozek wrote: On Mon, Jun 27, 2016 at 03:37:25PM +0200, Petr Cech wrote: ... +static errno_t ad_get_enabled_domains(TALLOC_CTX *mem_ctx

[SSSD] Re: [PATCH SET] AD_PROVIDER: ad_enabled_domains

2016-07-15 Thread Petr Cech
On 07/12/2016 10:31 AM, Pavel Březina wrote: On 07/11/2016 05:12 PM, Petr Cech wrote: On 07/05/2016 08:44 AM, Jakub Hrozek wrote: On Mon, Jun 27, 2016 at 03:37:25PM +0200, Petr Cech wrote: ... +static errno_t ad_get_enabled_domains(TALLOC_CTX *mem_ctx

[SSSD] PROVIDERS: Setting right {u,g}id if unpriveleged

2016-07-12 Thread Petr Cech
massively on valgrind tests. I hope it is not connected. [1] https://fedorahosted.org/sssd/ticket/3077 Regards -- Petr^4 Čech >From a99cb9e06fd0370b7e20af3b9dd489df40e37a34 Mon Sep 17 00:00:00 2001 From: Petr Cech <pc...@redhat.com> Date: Tue, 12 Jul 2016 16:14:04 +0200 Subject: [PATCH]

[SSSD] [PATCH] PROVIDERS: Default values in debug

2016-07-17 Thread Petr Cech
Hi list, I was debug code very deeply and I found nitpick. There is simple patch attached. Regards -- Petr^4 Čech >From 15d35c7e0e2171c49746d3a87f9aa2aba07a7bbc Mon Sep 17 00:00:00 2001 From: Petr Cech <pc...@redhat.com> Date: Sun, 17 Jul 2016 11:36:18 +0200 Subject: [PATCH]

[SSSD] Re: [PATCH SET] AD_PROVIDER: ad_enabled_domains

2016-06-27 Thread Petr Cech
On 06/22/2016 06:25 AM, Petr Cech wrote: On 06/14/2016 05:21 PM, Petr Cech wrote: Hello list, there is patch set attached resolving: https://fedorahosted.org/sssd/ticket/2828 You can also see: https://github.com/celestian/sssd/commits/subdomains_v2 This patch set is without tests yet. I

[SSSD] Re: [PATCH] SYSDB: Fixing DB update

2016-07-11 Thread Petr Cech
bump :-) -- Petr^4 Čech ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org

[SSSD] Re: [PATCH] SYSDB: Fixing DB update

2016-07-11 Thread Petr Cech
On 07/11/2016 11:59 AM, Lukas Slebodnik wrote: On (11/07/16 10:55), Sumit Bose wrote: On Mon, Jul 11, 2016 at 10:29:56AM +0200, Sumit Bose wrote: On Wed, Jun 22, 2016 at 03:30:28PM +0200, Petr Cech wrote: On 06/22/2016 11:14 AM, Lukas Slebodnik wrote: On (20/06/16 14:44), Petr Cech wrote

[SSSD] [PATCH] LDAP: Removing of useless debug message

2016-07-11 Thread Petr Cech
Hi list, how Jakub mentioned on internal list this debug message should be removed. So I attached simple patch for it. Regards -- Petr^4 Čech >From 185cb7095c5240d9eff8aa762331dc9f31061dfa Mon Sep 17 00:00:00 2001 From: Petr Cech <pc...@redhat.com> Date: Mon, 11 Jul 2016 15:27

[SSSD] Re: [PATCH SET] AD_PROVIDER: ad_enabled_domains

2016-07-11 Thread Petr Cech
On 07/05/2016 08:44 AM, Jakub Hrozek wrote: On Mon, Jun 27, 2016 at 03:37:25PM +0200, Petr Cech wrote: ... +static errno_t ad_get_enabled_domains(TALLOC_CTX *mem_ctx, + struct ad_id_ctx *ad_id_ctx, + const char

[SSSD] Re: [PATCH] LDAP: Fixing wrong pam error code for passwd

2016-08-05 Thread Petr Cech
bump -- Petr^4 Čech ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org

[SSSD] Re: [PATCH] LDAP: Fixing wrong pam error code for passwd

2016-08-05 Thread Petr Cech
On 08/05/2016 11:48 AM, Pavel Březina wrote: On 08/02/2016 10:19 AM, Petr Cech wrote: Hello list, the attached patch fixes: https://fedorahosted.org/sssd/ticket/3109 There was missing condition for offline state of sssd at ldap code for password changing. If sssd is offline it returns

[SSSD] Re: [PATCH] DP: Initialize D-Bus as soon as possible

2016-08-05 Thread Petr Cech
On 08/05/2016 11:41 AM, Pavel Březina wrote: https://fedorahosted.org/sssd/ticket/3111 Hi list, LGTM I am waiting or CI. Regards -- Petr^4 Čech ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

[SSSD] Re: [PATCH] DP: Initialize D-Bus as soon as possible

2016-08-05 Thread Petr Cech
On 08/05/2016 12:19 PM, Petr Cech wrote: On 08/05/2016 11:41 AM, Pavel Březina wrote: https://fedorahosted.org/sssd/ticket/3111 Hi list, LGTM I am waiting or CI. CI: http://sssd-ci.duckdns.org/logs/job/50/88/summary.html It failed on F24 on dyndns: http://sssd-ci.duckdns.org/logs/job/50

[SSSD] Re: [PATCH] tools: Add missing gettext macro

2016-08-05 Thread Petr Cech
On 08/05/2016 01:05 PM, Michal Židek wrote: Hi, see the attached simple patch. I sent it as part of the commands renaming patchset, but forgot to include it in the last iteration. Michal ACK -- Petr^4 Čech ___ sssd-devel mailing list

[SSSD] Re: [PATCH] sssctl: use internal API to remove files

2016-08-05 Thread Petr Cech
On 07/13/2016 01:47 PM, Pavel Březina wrote: 0001-utils-add-remove_subtree.patch From 0aa39a46b707212e6487b6b537238e31bf7da1b4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?= Date: Wed, 13 Jul 2016 12:17:58 +0200 Subject: [PATCH 1/2] utils: add

[SSSD] Re: [PATCH] UTILS: Fixing duplication of pid file declaration

2016-08-05 Thread Petr Cech
On 08/04/2016 11:06 AM, Jakub Hrozek wrote: On Thu, Aug 04, 2016 at 08:41:34AM +0200, Fabiano Fidêncio wrote: On Tue, Jul 26, 2016 at 4:01 PM, Petr Cech <pc...@redhat.com> wrote: Hello list, attached patch fixes duplication of pid file declaration. I hope that the util/util.h is the

[SSSD] Re: [PATCH] NSS: Do not check local users with disabled local_negative_timeout

2016-08-08 Thread Petr Cech
On 08/08/2016 04:20 PM, Petr Cech wrote: On 08/08/2016 04:09 PM, Lukas Slebodnik wrote: On (08/08/16 15:36), Petr Cech wrote: On 08/08/2016 03:14 PM, Petr Cech wrote: On 08/08/2016 02:40 PM, Lukas Slebodnik wrote: ehlo, The simple reproducer is to use getent passwd,group with non-existing

[SSSD] Re: [PATCH] sssctl: use internal API to remove files

2016-08-09 Thread Petr Cech
On 08/05/2016 01:48 PM, Petr Cech wrote: On 07/13/2016 01:47 PM, Pavel Březina wrote: 0001-utils-add-remove_subtree.patch From 0aa39a46b707212e6487b6b537238e31bf7da1b4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?= <pbrez...@redhat.com> Date: Wed, 13 Jul 2016 12:17:58

[SSSD] Re: [PATCH 1/2] LDAP: Adding support for SIGTERM signal

2016-08-09 Thread Petr Cech
On 08/09/2016 11:26 AM, Jakub Hrozek wrote: On Mon, Aug 08, 2016 at 09:46:55AM +0200, Petr Cech wrote: > On 08/04/2016 05:01 PM, Petr Cech wrote: > > On 08/04/2016 04:35 PM, Petr Cech wrote: > > > Hi list, > > > > > > there is the first version of patch

[SSSD] Re: [PATCH] NSS: Use correct name for invalidating memory cache

2016-08-09 Thread Petr Cech
On 08/09/2016 09:04 AM, Petr Cech wrote: On 08/08/2016 06:37 PM, Lukas Slebodnik wrote: ehlo, yet another patch which fixes issues caused by sysdb refactoring. reproducer: a) add user with two groups b) call id user c) add another group to user d) authenticate e) check tha id -G return 3

[SSSD] Re: [PATCH] NSS: Use correct name for invalidating memory cache

2016-08-09 Thread Petr Cech
On 08/08/2016 06:37 PM, Lukas Slebodnik wrote: ehlo, yet another patch which fixes issues caused by sysdb refactoring. reproducer: a) add user with two groups b) call id user c) add another group to user d) authenticate e) check tha id -G return 3 groups. I am looking forward to the

[SSSD] Re: [PATCH] sssctl: use internal API to remove files

2016-08-09 Thread Petr Cech
On 08/09/2016 02:10 PM, Pavel Březina wrote: On 08/09/2016 01:53 PM, Petr Cech wrote: On 08/05/2016 01:48 PM, Petr Cech wrote: On 07/13/2016 01:47 PM, Pavel Březina wrote: 0001-utils-add-remove_subtree.patch From 0aa39a46b707212e6487b6b537238e31bf7da1b4 Mon Sep 17 00:00:00 2001 From: =?UTF

[SSSD] Re: [PATCH] LDAP: Fix Dereference after NULL check

2016-08-08 Thread Petr Cech
On 08/08/2016 09:09 AM, Lukas Slebodnik wrote: ehlo, attached is a oneliner for bug introduced in dc30c60f166ad9adc63a47a1013508a71624ac87 I would push the patch with oneliner rule but there were objection in past for such behaviour. It was recommended to to use only in "critical" situation

[SSSD] Re: [PATCH] LDAP: Fix Dereference after NULL check

2016-08-08 Thread Petr Cech
On 08/08/2016 09:13 AM, Petr Cech wrote: On 08/08/2016 09:09 AM, Lukas Slebodnik wrote: ehlo, attached is a oneliner for bug introduced in dc30c60f166ad9adc63a47a1013508a71624ac87 I would push the patch with oneliner rule but there were objection in past for such behaviour. It was recommended

[SSSD] Re: [PATCH 1/2] LDAP: Adding support for SIGTERM signal

2016-08-08 Thread Petr Cech
On 08/04/2016 05:01 PM, Petr Cech wrote: On 08/04/2016 04:35 PM, Petr Cech wrote: Hi list, there is the first version of patch for [1]. I need to investigate if we have the same issue in other *_childs. I tested it with sleep() added into ldap_child code. [1] https://fedorahosted.org/sssd

[SSSD] Re: [PATCH] DP: Initialize D-Bus as soon as possible

2016-08-08 Thread Petr Cech
On 08/08/2016 10:26 AM, Pavel Březina wrote: On 08/05/2016 01:02 PM, Petr Cech wrote: On 08/05/2016 12:19 PM, Petr Cech wrote: On 08/05/2016 11:41 AM, Pavel Březina wrote: https://fedorahosted.org/sssd/ticket/3111 Hi list, LGTM I am waiting or CI. CI: http://sssd-ci.duckdns.org/logs

[SSSD] Re: [PATCH] NSS: Do not check local users with disabled local_negative_timeout

2016-08-08 Thread Petr Cech
On 08/08/2016 02:40 PM, Lukas Slebodnik wrote: ehlo, The simple reproducer is to use getent passwd,group with non-existing entry. Without the patch you will see that "/var/lib/sss/mc/passwd" is opened twice. Onece with mode "rw" opened by sssd_nss and the 2nd time with "r-" opened by

[SSSD] Re: [PATCH] PROVIDERS: Default values in debug

2016-08-08 Thread Petr Cech
On 08/05/2016 03:58 PM, Lukas Slebodnik wrote: On (29/07/16 10:46), Petr Cech wrote: On 07/29/2016 10:17 AM, Lukas Slebodnik wrote: On (29/07/16 10:05), Petr Cech wrote: On 07/29/2016 09:52 AM, Lukas Slebodnik wrote: On (29/07/16 09:41), Petr Cech wrote: On 07/29/2016 09:23 AM, Lukas

[SSSD] Re: [PATCH] NSS: Do not check local users with disabled local_negative_timeout

2016-08-08 Thread Petr Cech
On 08/08/2016 03:14 PM, Petr Cech wrote: On 08/08/2016 02:40 PM, Lukas Slebodnik wrote: ehlo, The simple reproducer is to use getent passwd,group with non-existing entry. Without the patch you will see that "/var/lib/sss/mc/passwd" is opened twice. Onece with mode "rw"

[SSSD] Re: [PATCH] NSS: Do not check local users with disabled local_negative_timeout

2016-08-08 Thread Petr Cech
On 08/08/2016 04:09 PM, Lukas Slebodnik wrote: On (08/08/16 15:36), Petr Cech wrote: On 08/08/2016 03:14 PM, Petr Cech wrote: On 08/08/2016 02:40 PM, Lukas Slebodnik wrote: ehlo, The simple reproducer is to use getent passwd,group with non-existing entry. Without the patch you will see

<    1   2   3   4   >