[SSSD] [PATCH] Fix monitor ping timeout

2009-08-11 Thread Stephen Gallagher
instead. This fix solves the problem where a busy backend (for example, one that is enumerating a large number of LDAP entries) would fail to respond to the ping in time. -- Stephen Gallagher RHCE 804006346421761 Looking to carve out IT costs? www.redhat.com/carveoutcosts/ From

Re: [SSSD] [PATCHES] services startup and identification

2009-08-11 Thread Stephen Gallagher
. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel Ack. - -- Stephen Gallagher RHCE 804006346421761 Looking to carve out IT costs? www.redhat.com/carveoutcosts

Re: [SSSD] [PATCH] Eliminate unnecessary explicit timeout for DP account requests

2009-08-12 Thread Stephen Gallagher
On 08/12/2009 08:51 AM, Stephen Gallagher wrote: D-BUS handles timeouts itself and reports DBUS_ERROR_NO_REPLY if a timeout fires, so we can rely on this instead of having an explicit timeout ourselves. Furthermore, the two timeouts present a potential race condition

Re: [SSSD] [PATCH] Eliminate unnecessary explicit timeout for DP account requests

2009-08-12 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/12/2009 09:09 AM, Simo Sorce wrote: On Wed, 2009-08-12 at 09:04 -0400, Stephen Gallagher wrote: On 08/12/2009 08:51 AM, Stephen Gallagher wrote: D-BUS handles timeouts itself and reports DBUS_ERROR_NO_REPLY if a timeout fires, so we can rely

Re: [SSSD] [PATCH] Tools ID range fixes

2009-08-13 Thread Stephen Gallagher
list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel Pushed to master. - -- Stephen Gallagher RHCE 804006346421761 Looking to carve out IT costs? www.redhat.com/carveoutcosts/ -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using

Re: [SSSD] RFC: Enumerations and sssd drivers

2009-08-13 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/13/2009 08:38 AM, Simo Sorce wrote: On Thu, 2009-08-13 at 08:54 -0400, Stephen Gallagher wrote: NOTE: this means that until the first background enumeration is complete, a getent passwd or a getent group call may return incomplete results. I

[SSSD] Bringing 0.5.0 to a close

2009-08-14 Thread Stephen Gallagher
will tag, sign and release 0.5.0. I urge all developers to please update their tickets to denote whether they feel they are needed for a stable release. 1: https://fedorahosted.org/sssd/report/1 - -- Stephen Gallagher RHCE 804006346421761 Looking to carve out IT costs? www.redhat.com/carveoutcosts

Re: [SSSD] [PATCH] Fix DP reconnection code [#101]

2009-08-17 Thread Stephen Gallagher
. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel Ack and pushed to master. Needed one-liner change before commit: Need to remove monitor_sbus.h from Makefile.am or build fails. - -- Stephen

Re: [SSSD] New Try to build SSSD on Karmic both as of 2009.08.04

2009-08-17 Thread Stephen Gallagher
be needed in 0.8. Karsten, please CC me on the ticket when you create it. - -- Stephen Gallagher RHCE 804006346421761 Looking to carve out IT costs? www.redhat.com/carveoutcosts/ -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Fedora - http

Re: [SSSD] [PATCH] ELAPI Adding concept of the targets

2009-08-17 Thread Stephen Gallagher
that the - -D macros you're passing to the compiler refer to $(srcdir). The AM_CPPFLAGS are correctly using $(srcdir) as-is. - -- Stephen Gallagher RHCE 804006346421761 Looking to carve out IT costs? www.redhat.com/carveoutcosts/ -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (GNU/Linux

[SSSD] [PATCH] Make the LOCAL provider always use MagicPrivateGroups

2009-08-20 Thread Stephen Gallagher
This patch will resolve https://fedorahosted.org/sssd/ticket/95 by making MPG=false an impossible configuration for the LOCAL provider. -- Stephen Gallagher RHCE 804006346421761 Looking to carve out IT costs? www.redhat.com/carveoutcosts/ From dd2446d2bc6fda3ba15a57f41efba76b4b1ff492 Mon Sep 17

Re: [SSSD] [PATCH] Make the LOCAL provider always use MagicPrivateGroups

2009-08-20 Thread Stephen Gallagher
On 08/20/2009 10:34 AM, Stephen Gallagher wrote: This patch will resolve https://fedorahosted.org/sssd/ticket/95 by making MPG=false an impossible configuration for the LOCAL provider

Re: [SSSD] [PATCHES] Fix RHEL5 builds

2009-08-20 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/20/2009 12:20 PM, Dmitri Pal wrote: Sumit Bose wrote: On Thu, Aug 20, 2009 at 11:15:30AM -0400, Stephen Gallagher wrote: On 08/20/2009 07:27 AM, Stephen Gallagher wrote: On 08/19/2009 07:40 PM, Dmitri Pal wrote: Dmitri Pal

Re: [SSSD] [PATCH] ELAPI Adding concept of the targets

2009-08-20 Thread Stephen Gallagher
___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel Ack and pushed to master. - -- Stephen Gallagher RHCE 804006346421761 Looking

[SSSD] [PATCH] Ensure that fds are only added once in the sbus

2009-08-26 Thread Stephen Gallagher
fancy in the toggle function. It is simpler to just remove or add watches as appropriate. -- Stephen Gallagher RHCE 804006346421761 Looking to carve out IT costs? www.redhat.com/carveoutcosts/ From fe7382fe3b3fcae9b5d05fd42744807a32b1c555 Mon Sep 17 00:00:00 2001 From: Stephen Gallagher sgall

Re: [SSSD] [PATCH] Turn enumeration parameter to boolean

2009-08-31 Thread Stephen Gallagher
there. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel - -- Stephen Gallagher RHCE 804006346421761

Re: [SSSD] [PATCH] Turn enumeration parameter to boolean

2009-08-31 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/31/2009 03:04 PM, Dmitri Pal wrote: Stephen Gallagher wrote: On 08/31/2009 02:56 PM, Dmitri Pal wrote: Simo Sorce wrote: Since we enumerate in background and use the member/memberof scheme you can't do group enumerations without also doing

[SSSD] [PATCH] Move RPM specfiles into contrib/

2009-09-01 Thread Stephen Gallagher
Also create a new spec file for RHEL5 -- Stephen Gallagher RHCE 804006346421761 Looking to carve out IT costs? www.redhat.com/carveoutcosts/ From e2ec4bf8dc7f394275b91271291d2ba31504fb74 Mon Sep 17 00:00:00 2001 From: Stephen Gallagher sgall...@redhat.com Date: Tue, 1 Sep 2009 16:02:46 -0400

Re: [SSSD] [PATCH] Move RPM specfiles into contrib/

2009-09-02 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/01/2009 04:46 PM, Stephen Gallagher wrote: On 09/01/2009 04:43 PM, Simo Sorce wrote: On Tue, 2009-09-01 at 16:15 -0400, Stephen Gallagher wrote: Also create a new spec file for RHEL5 Ack, although later it may be worth considering

Re: [SSSD] [PATCH] Move RPM specfiles into contrib/

2009-09-02 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/02/2009 10:04 AM, Simo Sorce wrote: On Wed, 2009-09-02 at 09:41 -0400, Stephen Gallagher wrote: New version. I have combined the two spec files into one and cleared up some glitches in the earlier patch. Looks good to me, ack Simo

Re: [SSSD] [PATCH] Fix proxy enumerations with newer tevent

2009-09-03 Thread Stephen Gallagher
sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel Pushed to master. - -- Stephen Gallagher RHCE 804006346421761 Looking to carve out IT costs? www.redhat.com/carveoutcosts/ -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG

Re: [SSSD] Fix crash in LDAP backend in initgroups() call

2009-09-03 Thread Stephen Gallagher
. It is obviously correct to check for it anyway, and, I think, also done in other code as well, thanks for catching it! ACK. Simo. Pushed to master. - -- Stephen Gallagher RHCE 804006346421761 Looking to carve out IT costs? www.redhat.com/carveoutcosts/ -BEGIN PGP SIGNATURE- Version

Re: [SSSD] [PATCH] ELAPI Laying foundation for the async processing

2009-09-04 Thread Stephen Gallagher
? - -- Stephen Gallagher RHCE 804006346421761 Looking to carve out IT costs? www.redhat.com/carveoutcosts/ -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iEYEARECAAYFAkqhOPgACgkQeiVVYja6o6MjzgCglS6gA2Rr3IgOat46GUSQX8Ke

Re: [SSSD] [PATCH] ELAPI Adding file provider and CSV format

2009-09-04 Thread Stephen Gallagher
as well. - -- Stephen Gallagher RHCE 804006346421761 Looking to carve out IT costs? www.redhat.com/carveoutcosts/ -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

Re: [SSSD] Coding standard question (was ELAPI Adding file... )

2009-09-04 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/04/2009 12:38 PM, Dmitri Pal wrote: Stephen Gallagher wrote: On 09/02/2009 08:27 PM, Dmitri Pal wrote: Hi, This patch is next significant chunk of code. See patch comments for the main description. It requires previous patch that has been

Re: [SSSD] [PATCH] ELAPI Adding file provider and CSV format

2009-09-08 Thread Stephen Gallagher
/listinfo/sssd-devel - -- Stephen Gallagher RHCE 804006346421761 Looking to carve out IT costs? www.redhat.com/carveoutcosts/ -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

Re: [SSSD] [PATCH] COLLECTION Copy collection flat with concatenated names

2009-09-08 Thread Stephen Gallagher
further on in the code (e.g. used for comparisons), you need to copy its current state. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel - -- Stephen Gallagher RHCE 804006346421761 Looking

Re: [SSSD] [PATCH] fix libdbus configure check

2009-09-08 Thread Stephen Gallagher
mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel Ack. - -- Stephen Gallagher RHCE 804006346421761 Looking to carve out IT costs? www.redhat.com/carveoutcosts/ -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG

Re: [SSSD] [PATCH] initialize sockaddr_in structure

2009-09-08 Thread Stephen Gallagher
___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel Ack. - -- Stephen Gallagher RHCE 804006346421761

Re: [SSSD] New Try to build SSSD on Karmic both as of 2009.08.04

2009-09-08 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/17/2009 10:30 AM, Stephen Gallagher wrote: On 08/13/2009 07:34 PM, Karsten Wade wrote: On Tue, Aug 11, 2009 at 06:09:24AM -0400, Simo Sorce wrote: Given we use git it doesn't seem a great match. If the Fedora facility do upgrade

Re: [SSSD] [PATCH] Split database file to one per domain

2009-09-08 Thread Stephen Gallagher
___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel - -- Stephen Gallagher RHCE 804006346421761 Looking to carve out IT costs? www.redhat.com/carveoutcosts/ -BEGIN PGP SIGNATURE

Re: [SSSD] [PATCH] COLLECTION Copy collection flat with concatenated names

2009-09-08 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/08/2009 08:41 AM, Dmitri Pal wrote: Thank you for review, comments inline. Stephen Gallagher wrote: On 09/07/2009 10:05 AM, Jakub Hrozek wrote: On 09/05/2009 02:32 AM, Dmitri Pal wrote: See patch comment. This patch most likely

Re: [SSSD] [PATCH] initialize sockaddr_in structure

2009-09-08 Thread Stephen Gallagher
___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel Pushed to master. - -- Stephen Gallagher RHCE

Re: [SSSD] [PATCH] fix libdbus configure check

2009-09-08 Thread Stephen Gallagher
mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel Pushed to master. - -- Stephen Gallagher RHCE 804006346421761 Looking to carve out IT costs? www.redhat.com/carveoutcosts/ -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (GNU/Linux) Comment

Re: [SSSD] Unpleasant warnings

2009-09-08 Thread Stephen Gallagher
in this function The value of count might have an unexpected value, but in this case fill_grent will return an error, too. I cannot see the other warnings, what compiler options and code revision are you using? bye, Sumit Ack - -- Stephen Gallagher RHCE 804006346421761 Looking to carve out

Re: [SSSD] Unpleasant warnings

2009-09-08 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/08/2009 03:01 PM, Stephen Gallagher wrote: On 09/08/2009 02:36 PM, Simo Sorce wrote: On Tue, 2009-09-08 at 12:21 +0200, Sumit Bose wrote: ../../server/responder/nss/nsssrv_cmd.c: In function fill_grent: ../../server/responder/nss

Re: [SSSD] [PATCH] ELAPI sinks and providers

2009-09-08 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/08/2009 06:47 AM, Stephen Gallagher wrote: On 09/07/2009 08:05 AM, Jakub Hrozek wrote: On 08/28/2009 11:40 AM, Jakub Hrozek wrote: No, none of this was critical, more like things I noticed reading the code. FWIW, while reviewing the ELAPI

Re: [SSSD] [PATCH] Correcting issues

2009-09-08 Thread Stephen Gallagher
, since this is just a set of fixes, not a new patch. - -- Stephen Gallagher RHCE 804006346421761 Looking to carve out IT costs? www.redhat.com/carveoutcosts/ -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

Re: [SSSD] [PATCH] Correcting issues

2009-09-08 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/08/2009 07:23 PM, Stephen Gallagher wrote: On 09/08/2009 06:45 PM, Dmitri Pal wrote: Hi, This patch corrects (hopefully last) set of issues found in the earlier patches during review. The ones that are not addressed yet are tracked via

Re: [SSSD] [PATCH] ELAPI Adding file provider and CSV format

2009-09-08 Thread Stephen Gallagher
of Correcting Issues squashed in. - -- Stephen Gallagher RHCE 804006346421761 Looking to carve out IT costs? www.redhat.com/carveoutcosts/ -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

Re: [SSSD] [PATCH] Add support for the EntryCacheNoWaitRefreshTimeout

2009-09-08 Thread Stephen Gallagher
the review inline below. On 08/17/2009 11:19 AM, Sumit Bose wrote: On Fri, Aug 14, 2009 at 03:46:54PM -0400, Stephen Gallagher wrote: This timeout specifies the lifetime of a cache entry before it is updated out-of-band. When this timeout is hit, the request will still complete from cache

Re: [SSSD] [PATCH] Add support for the EntryCacheNoWaitRefreshTimeout

2009-09-09 Thread Stephen Gallagher
On 09/09/2009 07:50 AM, Sumit Bose wrote: On Tue, Sep 08, 2009 at 08:32:55PM -0400, Stephen Gallagher wrote: I have refactored nsssrv_cmd.c and created a new patch for the EntryCacheNoWaitRefreshTimeout. I have created a new function, check_cache() which is a common entry point for getpwnam

Re: [SSSD] [PATCH] Add support for the EntryCacheNoWaitRefreshTimeout

2009-09-09 Thread Stephen Gallagher
On 09/09/2009 08:46 AM, Sumit Bose wrote: On Tue, Sep 08, 2009 at 08:32:55PM -0400, Stephen Gallagher wrote: I have refactored nsssrv_cmd.c and created a new patch for the EntryCacheNoWaitRefreshTimeout. I have created a new function, check_cache() which is a common entry point for getpwnam

Re: [SSSD] [PATCH] more fixes for older libpcre versions

2009-09-09 Thread Stephen Gallagher
hints about this. Ack. Pushed to master. - -- Stephen Gallagher RHCE 804006346421761 Looking to carve out IT costs? www.redhat.com/carveoutcosts/ -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

Re: [SSSD] [PATCH] Cleanups for library linking

2009-09-09 Thread Stephen Gallagher
which links against libldap. Absolutely, full ack! Simo. Pushed to master. - -- Stephen Gallagher RHCE 804006346421761 Looking to carve out IT costs? www.redhat.com/carveoutcosts/ -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Fedora - http

Re: [SSSD] [PATCH] COLLECTION Copy collection flat with concatenated names

2009-09-09 Thread Stephen Gallagher
... ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel Pushed to master. - -- Stephen Gallagher RHCE 804006346421761 Looking to carve out IT costs? www.redhat.com/carveoutcosts/ -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (GNU

Re: [SSSD] [PATCH] Add support for the EntryCacheNoWaitRefreshTimeout

2009-09-09 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/09/2009 09:27 AM, Sumit Bose wrote: On Wed, Sep 09, 2009 at 08:58:54AM -0400, Stephen Gallagher wrote: On 09/09/2009 08:46 AM, Sumit Bose wrote: On Tue, Sep 08, 2009 at 08:32:55PM -0400, Stephen Gallagher wrote: I have refactored

[SSSD] [PATCHES] Handle invalid domain configuration better

2009-09-09 Thread Stephen Gallagher
Patch 0001: Ensure that daemonization happens after reading in the configuration, so critical configuration errors repord FAILED during init script startup. Patch 0002: Ensure that the minId and maxId values are sensible (minId maxId, neither 0) -- Stephen Gallagher RHCE 804006346421761

[SSSD] [PATCH] Update manpage with new enumerate syntax

2009-09-09 Thread Stephen Gallagher
$SUBJECT -- Stephen Gallagher RHCE 804006346421761 Looking to carve out IT costs? www.redhat.com/carveoutcosts/ From 8b65da1c2d0d196978e96e11b48f1ecf640dd423 Mon Sep 17 00:00:00 2001 From: Stephen Gallagher sgall...@redhat.com Date: Wed, 9 Sep 2009 13:12:03 -0400 Subject: [PATCH 3/3] Update

Re: [SSSD] [PATCH] Update manpage with new enumerate syntax

2009-09-10 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/09/2009 02:16 PM, Simo Sorce wrote: On Wed, 2009-09-09 at 13:34 -0400, Stephen Gallagher wrote: $SUBJECT Ack. Simo. Pushed to master - -- Stephen Gallagher RHCE 804006346421761 Looking to carve out IT costs? www.redhat.com

Re: [SSSD] [PATCHES] Handle invalid domain configuration better

2009-09-10 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/09/2009 02:20 PM, Simo Sorce wrote: On Wed, 2009-09-09 at 13:33 -0400, Stephen Gallagher wrote: Patch 0001: Ensure that daemonization happens after reading in the configuration, so critical configuration errors repord FAILED during init

[SSSD] [PATCH] Read and validate configuration before daemonizing

2009-09-10 Thread Stephen Gallagher
the event_ctx argument to confdb_init, so I'm removing it to eliminate confusion. Patch 0002: Create the confdb and read in the configuration options before daemonizing so that failures can be reported immediately. -- Stephen Gallagher RHCE 804006346421761 Looking to carve out IT costs

[SSSD] [PATCH] Properly detect negative/invalid values for the minId and maxId

2009-09-10 Thread Stephen Gallagher
Now we'll first read the values in as a string and parse them to ensure that they represent positive numbers. -- Stephen Gallagher RHCE 804006346421761 Looking to carve out IT costs? www.redhat.com/carveoutcosts/ From 84a4386fa03406d32ca9dfcaa9bd4956f190fcb0 Mon Sep 17 00:00:00 2001 From

Re: [SSSD] [PATCH] Collection improvements to copy functions

2009-09-10 Thread Stephen Gallagher
. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel Ack - -- Stephen Gallagher RHCE 804006346421761 Looking to carve out IT costs? www.redhat.com/carveoutcosts/ -BEGIN PGP

Re: [SSSD] [PATCH] Properly detect negative/invalid values for the minId and maxId

2009-09-10 Thread Stephen Gallagher
New patch with code review concerns addressed. On 09/10/2009 04:37 PM, Simo Sorce wrote: On Thu, 2009-09-10 at 16:02 -0400, Stephen Gallagher wrote: New approach attached. Patch 0001: Create two convenience functions, strtouint32 and strtoint32. These behave identically to strtol or strtoll

Re: [SSSD] [PATCH] Small changes to the example config and manpage

2009-09-10 Thread Stephen Gallagher
@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel - -- Stephen Gallagher RHCE 804006346421761 Looking to carve out IT costs? www.redhat.com/carveoutcosts/ -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

Re: [SSSD] [PATCH] Let the PAM client send its PID

2009-09-11 Thread Stephen Gallagher
the protocol version if we're adding new mandatory arguments? - -- Stephen Gallagher RHCE 804006346421761 Looking to carve out IT costs? www.redhat.com/carveoutcosts/ -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

Re: [SSSD] [PATCH] Let the PAM client send its PID

2009-09-11 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/11/2009 10:29 AM, Sumit Bose wrote: On Fri, Sep 11, 2009 at 09:07:01AM -0400, Stephen Gallagher wrote: On 09/11/2009 06:13 AM, Sumit Bose wrote: Hi, with this patch the client sends its PID to sssd. This is at least needed by the krb5

[SSSD] [PATCH] Add unit tests for strtouint32 and strtoint32

2009-09-11 Thread Stephen Gallagher
Figured it would be a good idea to have some unit tests in place for the nonstandard strtoll functions I wrote. -- Stephen Gallagher RHCE 804006346421761 Looking to carve out IT costs? www.redhat.com/carveoutcosts/ From 686ddf64016fda7258a6cb4c3730061678ddff5e Mon Sep 17 00:00:00 2001 From

Re: [SSSD] [PATCHES] fix access to freed memory

2009-09-11 Thread Stephen Gallagher
. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel Patch 0001: Ack Patch 0002: Ack - -- Stephen Gallagher RHCE 804006346421761 Looking to carve out IT costs

[SSSD] [PATCH] Add 'make tests' target

2009-09-11 Thread Stephen Gallagher
Per Simo's request, here is a patch to enable the building (but not executing) of tests for the SSSD. To build and run them, 'make check' still works. -- Stephen Gallagher RHCE 804006346421761 Looking to carve out IT costs? www.redhat.com/carveoutcosts/ From

Re: [SSSD] [PATCH] fix broken getgrnam and getgrgid

2009-09-11 Thread Stephen Gallagher
. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel Ack - -- Stephen Gallagher RHCE 804006346421761 Looking to carve out IT costs? www.redhat.com/carveoutcosts/ -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (GNU

Re: [SSSD] [PATCH] Make offline status backend global

2009-09-14 Thread Stephen Gallagher
until you can convince me that the approach itself is right. - -- Stephen Gallagher RHCE 804006346421761 Looking to carve out IT costs? www.redhat.com/carveoutcosts/ -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

Re: [SSSD] [PATCH] Make basic options typed

2009-09-14 Thread Stephen Gallagher
. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel Nack. Generates a segfault running getent passwd u...@ldap - -- Stephen Gallagher

Re: [SSSD] [PATCH] Include m4 directories in tarball

2009-09-15 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/15/2009 09:45 AM, Simo Sorce wrote: On Tue, 2009-09-15 at 09:16 -0400, Stephen Gallagher wrote: Due to differences in autotools, building RPMS on RHEL5 requires the m4 directories to be included in the tarball. Is there any way to have

Re: [SSSD] [PATCH] Include m4 directories in tarball

2009-09-15 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/15/2009 09:37 AM, Sumit Bose wrote: On Tue, Sep 15, 2009 at 09:16:24AM -0400, Stephen Gallagher wrote: Due to differences in autotools, building RPMS on RHEL5 requires the m4 directories to be included in the tarball. ACK SLES10 needs

Re: [SSSD] [PATCH] Allow rerunning autoreconf from the tarball

2009-09-15 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/15/2009 09:45 AM, Simo Sorce wrote: On Tue, 2009-09-15 at 09:42 -0400, Stephen Gallagher wrote: We were missing two files from the tarball distribution that prevented autoreconf from running successfully: VERSION and replace/autoconf-2.60.m4

[SSSD] [PATCH] Add PRERELEASE_VERSION variable for use in sssd.spec.i

2009-09-15 Thread Stephen Gallagher
This will add a second, optional line to the VERSION file that will be used by the automated build scripts to create snapshot versions. -- Stephen Gallagher RHCE 804006346421761 Looking to carve out IT costs? www.redhat.com/carveoutcosts/ From f1bcde7fc13f8d3e21850dae15d2f05da747e56e Mon Sep 17

[SSSD] [PATCH] Add pl translation

2009-09-16 Thread Stephen Gallagher
I haven't gotten Transifex to send the patches to the sssd-devel list yet, so I'm forwarding this one on manually for the moment. I give it an Ack, and a thank-you to Piotr Drąg -- Stephen Gallagher RHCE 804006346421761 Looking to carve out IT costs? www.redhat.com/carveoutcosts/ From

Re: [SSSD] [PATCH] Add pl translation

2009-09-16 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/16/2009 11:40 AM, Stephen Gallagher wrote: I haven't gotten Transifex to send the patches to the sssd-devel list yet, so I'm forwarding this one on manually for the moment. I give it an Ack, and a thank-you to Piotr Drąg

Re: [SSSD] [PATCH] Add pl translation

2009-09-16 Thread Stephen Gallagher
On 09/16/2009 01:29 PM, Stephen Gallagher wrote: On 09/16/2009 11:40 AM, Stephen Gallagher wrote: I haven't gotten Transifex to send the patches to the sssd-devel list yet, so I'm forwarding this one on manually for the moment. I give it an Ack, and a thank-you to Piotr Drg

Re: [SSSD] [PATCH] Add pl translation

2009-09-16 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/16/2009 02:41 PM, Sumit Bose wrote: On Wed, Sep 16, 2009 at 02:29:09PM -0400, Stephen Gallagher wrote: On 09/16/2009 01:29 PM, Stephen Gallagher wrote: On 09/16/2009 11:40 AM, Stephen Gallagher wrote: I haven't gotten Transifex to send

[SSSD] [PATCH] Temporarily disable automatic config file reread

2009-09-24 Thread Stephen Gallagher
://fedorahosted.org/sssd/ticket/91 is fixed. -- Stephen Gallagher RHCE 804006346421761 Looking to carve out IT costs? www.redhat.com/carveoutcosts/ From 00d40204580b418fa71c1390650d8d43a1aaebcc Mon Sep 17 00:00:00 2001 From: Stephen Gallagher sgall...@redhat.com Date: Thu, 24 Sep 2009 08:59:03 -0400 Subject

Re: [SSSD] fixing ping probe when suspending computers

2009-09-24 Thread Stephen Gallagher
right away. Simo. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel Ack - -- Stephen Gallagher RHCE

Re: [SSSD] [PATCH] added support for older MIT kerberos versions

2009-09-24 Thread Stephen Gallagher
, Sumit ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel Ack. - -- Stephen Gallagher RHCE

Re: [SSSD] fixing ping probe when suspending computers

2009-09-24 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/24/2009 09:50 AM, Stephen Gallagher wrote: On 09/24/2009 09:48 AM, Simo Sorce wrote: When a laptop is suspended the clock may be jumping hours, with this patch now we explicitly count failure to pong back, so that at most we may loose one

Re: [SSSD] [PATCH] added support for older MIT kerberos versions

2009-09-24 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/24/2009 04:17 PM, Stephen Gallagher wrote: On 09/24/2009 02:32 PM, Sumit Bose wrote: Hi, this patch make the creation of the Kerberos locator plugin optional and adds support for older versions of MIT Kerberos (and older version

Re: [SSSD] [PATCHES] Convert the SSSD to config_file_version 2

2009-09-25 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Nack. See below On 09/25/2009 06:01 AM, Jakub Hrozek wrote: On 09/25/2009 10:48 AM, Sumit Bose wrote: Hi, here are my comments: On Thu, Sep 24, 2009 at 09:32:27PM -0400, Stephen Gallagher wrote: Patch 0001 (sgallagh): Convert the existing

Re: [SSSD] [PATCH] add new config options ldap_tls_cacert and ldap_tls_cacertdir

2009-09-25 Thread Stephen Gallagher
certificate store, but until that happens we probably need to be more explicit here. The only issue I have with the code is with the trailing comma in struct sdap_gen_opts default_basic_opts[] - -- Stephen Gallagher RHCE 804006346421761 Looking to carve out IT costs? www.redhat.com

Re: [SSSD] [PATCH] Send debug messages to logfile

2009-09-25 Thread Stephen Gallagher
mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel - -- Stephen Gallagher RHCE 804006346421761 Looking to carve out IT costs? www.redhat.com/carveoutcosts/ -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Fedora

Re: [SSSD] [PATCH] Send debug messages to logfile

2009-09-25 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/25/2009 09:48 AM, Jakub Hrozek wrote: On 09/25/2009 03:28 PM, Stephen Gallagher wrote: Nack /var/log/audit != /var/log/sssd Stupid copy'n'paste..sorry.. new patch attached Ack and pushed

Re: [SSSD] [PATCH] Convert the example config to v2 format, upgrade config on update only

2009-09-25 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/25/2009 11:31 AM, Jakub Hrozek wrote: On 09/25/2009 05:12 PM, Stephen Gallagher wrote: Nack The changes to sssd.spec.in are unnecessary. The upgrade_config.py already does an internal check and bails out if the version is already matched

Re: [SSSD] [PATCH] add defines for large file support to standard CFLAGS

2009-09-25 Thread Stephen Gallagher
___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel Ack - -- Stephen Gallagher RHCE 804006346421761 Looking to carve out IT costs? www.redhat.com/carveoutcosts/ -BEGIN PGP SIGNATURE

Re: [SSSD] [PATCH] leave space to run fd events on long operations

2009-09-25 Thread Stephen Gallagher
, rather than going through all timer events and then all fd events. I guess we'll work around it this way, but I'd like to see something smarter in the upstream project. Ack. - -- Stephen Gallagher RHCE 804006346421761 Looking to carve out IT costs? www.redhat.com/carveoutcosts/ -BEGIN PGP

Re: [SSSD] [PATCH] add defines for large file support to standard CFLAGS

2009-09-25 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/25/2009 12:23 PM, Stephen Gallagher wrote: On 09/25/2009 11:23 AM, Sumit Bose wrote: Hi, this patch fixes a compiler warning about the redefinition of SIZEOF_OFF_T on 32bit systems. It's not very elegant, but I don't know of a portable

Re: [SSSD] [PATCH] remove krb5_try_simple_upn option and make it a default fallback [was: [PATCH] extend sssd-krb5 man page]

2009-09-25 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/25/2009 12:13 PM, Stephen Gallagher wrote: On 09/25/2009 11:40 AM, Sumit Bose wrote: On Fri, Sep 25, 2009 at 09:40:49AM -0400, Stephen Gallagher wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/25/2009 09:09 AM, Sumit Bose wrote

Re: [SSSD] [PATCH] tighten up file permissions just to be safe

2009-09-28 Thread Stephen Gallagher
sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel Ack, although you may want to change sensible to sensitive in the commit comment before pushing. - -- Stephen Gallagher RHCE 804006346421761 Looking to carve out IT costs? www.redhat.com/carveoutcosts

[SSSD] [PATCH] Add config_from_fd() to ini_config

2009-09-28 Thread Stephen Gallagher
() functions still require the config file name for internal information. This does not imply that it is used to open the file. -- Stephen Gallagher RHCE 804006346421761 Looking to carve out IT costs? www.redhat.com/carveoutcosts/ From 48df8071fb8bb0848a3621020e0648394e18dd6e Mon Sep 17 00:00:00 2001 From

Re: [SSSD] [PATCH] Add config_from_fd() to ini_config

2009-09-28 Thread Stephen Gallagher
On 09/28/2009 09:55 AM, Simo Sorce wrote: On Mon, 2009-09-28 at 09:38 -0400, Stephen Gallagher wrote: The SSSD needs a config_from_fd() variant of the config_from_file() call so that we can preopen a config file and perform some verification on it before parsing it. The config_from_fd() call

Re: [SSSD] [PATCH] update sysdb tests to new config file version

2009-09-28 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/28/2009 11:52 AM, Sumit Bose wrote: On Mon, Sep 28, 2009 at 11:32:08AM -0400, Stephen Gallagher wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/28/2009 11:00 AM, Sumit Bose wrote: Hi, this patch should make sysdb tests happy

Re: [SSSD] [PATCH] add utility call check_and_open_readonly

2009-09-28 Thread Stephen Gallagher
is redundant. All of the necessary file-type checks can be performed with the fstat, with no risk of race condition. - -- Stephen Gallagher RHCE 804006346421761 Looking to carve out IT costs? www.redhat.com/carveoutcosts/ -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (GNU/Linux) Comment

Re: [SSSD] [PATCH] add utility call check_and_open_readonly

2009-09-28 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/28/2009 12:24 PM, Stephen Gallagher wrote: On 09/28/2009 11:49 AM, Sumit Bose wrote: Hi, with the patch the config file is only read if it is - a regular file - owner and group are 0 (root) - file permissions are 600 This patch

Re: [SSSD] [PATCH] Add config_from_fd() to ini_config

2009-09-28 Thread Stephen Gallagher
On 09/28/2009 01:46 PM, Dmitri Pal wrote: Stephen Gallagher wrote: On 09/28/2009 09:55 AM, Simo Sorce wrote: On Mon, 2009-09-28 at 09:38 -0400, Stephen Gallagher wrote: The SSSD needs a config_from_fd() variant of the config_from_file() call so that we can preopen a config file

[SSSD] [PATCH] Fix infinite loop with empty group enumeration

2009-09-29 Thread Stephen Gallagher
domain to verify that groups were still enumerated for further domains. -- Stephen Gallagher RHCE 804006346421761 Looking to carve out IT costs? www.redhat.com/carveoutcosts/ From 6b0bdf65566b5a37925b76e0db2b1967e5bf3547 Mon Sep 17 00:00:00 2001 From: Stephen Gallagher sgall...@redhat.com Date: Tue, 29

Re: [SSSD] [PATCH] Update polish translation for 0.6.0

2009-09-30 Thread Stephen Gallagher
Yes, it is. I didn't want to repeat my previous mistake and push this without a second pair of eyes. On Sep 30, 2009, at 11:14 AM, Simo Sorce sso...@redhat.com wrote: On Sun, 2009-09-27 at 10:11 -0400, Stephen Gallagher wrote: Sent on behalf of Piotr Drąg Is this waiting an ack ? Simo

Re: [SSSD] [PATCH] Update polish translation for 0.6.0

2009-10-01 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/30/2009 12:56 PM, Jakub Hrozek wrote: On 09/30/2009 05:15 PM, Stephen Gallagher wrote: Yes, it is. I didn't want to repeat my previous mistake and push this without a second pair of eyes. The patch looks fine, updates only .po files -- I

Re: [SSSD] [PATCH] use better timeouts and possibly fix #205

2009-10-01 Thread Stephen Gallagher
. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel Ack and pushed to master. - -- Stephen Gallagher RHCE 804006346421761 Looking to carve out IT costs? www.redhat.com

Re: [SSSD] [PATCH] add utility call check_and_open_readonly

2009-10-05 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/05/2009 03:15 AM, Sumit Bose wrote: On Fri, Oct 02, 2009 at 03:20:33PM -0400, Stephen Gallagher wrote: On 09/28/2009 03:05 PM, Sumit Bose wrote: On Mon, Sep 28, 2009 at 02:51:11PM -0400, Stephen Gallagher wrote: On 09/28/2009 01:52 PM

Re: [SSSD] [PATCH] Fix python sync operations and mem hierarchy

2009-10-05 Thread Stephen Gallagher
https://fedorahosted.org/mailman/listinfo/sssd-devel - -- Stephen Gallagher RHCE 804006346421761 Looking to carve out IT costs? www.redhat.com/carveoutcosts/ -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

Re: [SSSD] [PATCH] ELAPI Fixed the host name resolution

2009-10-05 Thread Stephen Gallagher
___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel Nack. The fix looks correct, but the unit test changes look like they're for a different patch. Please separate these out. - -- Stephen Gallagher RHCE

  1   2   3   4   5   6   7   8   9   10   >