jhrozek's pull request #6: "Applications should never define _USE_GNU
themselves, but rely on _GNU_SOURCE" label *ack* has been added
See the full pull-request at https://github.com/SSSD/sssd/pull/6
___
sssd-devel mailing list
sssd-devel@lists.fedorahos
fidencio's pull request #10: "UTIL: Remove support to libini older than 1.0.0"
was synchronize
See the full pull-request at https://github.com/SSSD/sssd/pull/10
... or pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/10/head:pr10
git checkout pr1
fidencio's pull request #10: "UTIL: Remove support to libini older than 1.0.0"
was edited
See the full pull-request at https://github.com/SSSD/sssd/pull/10
... or pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/10/head:pr10
git checkout pr10
___
fidencio's pull request #11: "SECRETS: Don't remove a container when it has
children" was synchronize
See the full pull-request at https://github.com/SSSD/sssd/pull/11
... or pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/11/head:pr11
git check
fidencio's pull request #11: "SECRETS: Don't remove a container when it has
children" was synchronize
See the full pull-request at https://github.com/SSSD/sssd/pull/11
... or pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/11/head:pr11
git check
fidencio's pull request #11: "SECRETS: Don't remove a container when it has
children" was edited
See the full pull-request at https://github.com/SSSD/sssd/pull/11
... or pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/11/head:pr11
git checkout p
fidencio's pull request #11: "SECRETS: Don't remove a container when it has
children" was edited
See the full pull-request at https://github.com/SSSD/sssd/pull/11
... or pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/11/head:pr11
git checkout p
fidencio's pull request #11: "SECRETS: Don't remove a container when it has
children" was synchronize
See the full pull-request at https://github.com/SSSD/sssd/pull/11
... or pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/11/head:pr11
git check
fidencio commented on a pull request
"""
Sorry for the noise in this PR, but I'm just testing whether my surname will
break Martin's script again or not.
Fabiano Fidêncio
"""
See the full comment at
https://github.com/
fidencio commented on a pull request
"""
Sorry for the noise in this PR, but I'm just testing whether my surname will
break Martin's script again or not.
Fabiano Fidêncio
"""
See the full comment at
https://github.com/
fidencio commented on a pull request
"""
I basically agree with Martin here.
IMO the code could be a bit simplified a little bit more, something like:
`if (mod_ctx->membel == NULL &&
(mod_ctx->ghel == NULL || mod_ctx->ghel->num_values == 0))`
Fabiano Fi
fidencio commented on a pull request
"""
I basically agree with Martin here.
IMO the code could be simplified a little bit more, something like:
`if (mod_ctx->membel == NULL &&
(mod_ctx->ghel == NULL || mod_ctx->ghel->num_values == 0))`
Fabiano Fidêncio
fidencio commented on a pull request
"""
Patch works as expected but I wasn't able to run CI tests on it* due to some
connection issue to the CI machine.
*: Well, I ran it locally and it passed.
Please, if possible, run the CI as feel free to push as soon as it passes
jhrozek's pull request #14: "Attempting to create a qualified name from a NULL
pointer broke sss_groupadd" label *ack* has been added
See the full pull-request at https://github.com/SSSD/sssd/pull/14
___
sssd-devel mailing list
sssd-devel@lists.fedoraho
fidencio commented on a pull request
"""
The distributions that would break with this patch are:
- RHEL/CentOS 5 and older
- Debian Wheezy (from 2013) and older
- Ubuntu 12.04 LTS and older
I was not able to find what's the version of the package on SLES
""&qu
fidencio commented on a pull request
"""
A few minors in the commit messages that should be fixed before pushing.
Patch0001: TOOLS: Fix a typo in groupadd()
Remove the four spaces before the link of the trac ticket.
Patch0002: TOOLS: sss_groupshow did not work
Patch0003: TEST
fidencio's pull request #11: "SECRETS: Don't remove a container when it has
children" was synchronize
See the full pull-request at https://github.com/SSSD/sssd/pull/11
... or pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/11/head:pr11
git check
fidencio commented on a pull request
"""
Patch looks good to me and the reporter already said it fixed the problem for
him.
Is it possible to easily have tests for this part of the code? If yes, tests
would be welcome.
I'd say it's an ACK for me as long as it passes
fidencio's pull request #11: "SECRETS: Don't remove a container when it has
children" was synchronize
See the full pull-request at https://github.com/SSSD/sssd/pull/11
... or pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/11/head:pr11
git check
fidencio's pull request #11: "SECRETS: Don't remove a container when it has
children" label *Changes requested* has been removed
See the full pull-request at https://github.com/SSSD/sssd/pull/11
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.
URL: https://github.com/SSSD/sssd/pull/32
Author: fidencio
Title: #32: Requesting a pull to SSSD:master from fidencio:wip/#3138
Action: opened
PR body:
"""
This patch series is intended to solve #3138 by adding a new service
that updates the confdb. As part of the series this
URL: https://github.com/SSSD/sssd/pull/32
Author: fidencio
Title: #32: Requesting a pull to SSSD:master from fidencio:wip/#3138
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/32/head:pr32
git checkout pr32
From
URL: https://github.com/SSSD/sssd/pull/32
Title: #32: Requesting a pull to SSSD:master from fidencio:wip/#3138
fidencio commented:
"""
Okay, with the updated version of the patches both issues that I had are fixed.
Here is the link for the CI (that has passed):
http://sssd-ci.d
URL: https://github.com/SSSD/sssd/pull/32
Author: fidencio
Title: #32: Requesting a pull to SSSD:master from fidencio:wip/#3138
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/32/head:pr32
git checkout pr32
From
URL: https://github.com/SSSD/sssd/pull/33
Author: fidencio
Title: #33: SECRETS: Some small misc fixes + fixing #3136
Action: opened
PR body:
"""
This series was made on top of Jakub's patches adding Secrets'
documentation, that is applied on top of my own patches a
URL: https://github.com/SSSD/sssd/pull/33
Author: fidencio
Title: #33: SECRETS: Some small misc fixes + fixing #3136
Action: edited
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/33/head:pr33
git checkout pr33
URL: https://github.com/SSSD/sssd/pull/33
Title: #33: SECRETS: Some small misc fixes + fixing #3168
fidencio commented:
"""
@jhrozek, about the configAPI question, I really missed the others secrets
specific options. I'll re-work and re-submit the patches.
""&qu
URL: https://github.com/SSSD/sssd/pull/32
Title: #32: Requesting a pull to SSSD:master from fidencio:wip/#3138
fidencio commented:
"""
@jhrozek
Answer for 1)
I do believe it may work, but I would have to adapt `sssd --genconf` logic, in
order to avoid race-conditions. Shall
URL: https://github.com/SSSD/sssd/pull/33
Author: fidencio
Title: #33: SECRETS: Some small misc fixes + fixing #3168
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/33/head:pr33
git checkout pr33
From
URL: https://github.com/SSSD/sssd/pull/33
Title: #33: SECRETS: Some small misc fixes + fixing #3168
Label: -Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedora
URL: https://github.com/SSSD/sssd/pull/33
Title: #33: SECRETS: Some small misc fixes + fixing #3168
fidencio commented:
"""
So, I've pushed a new version of the patches and I tried to address all
comments made, but the one adding a debug message i
URL: https://github.com/SSSD/sssd/pull/24
Title: #24: MAN: Add a manpage for the sssd-secrets responder
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahoste
URL: https://github.com/SSSD/sssd/pull/24
Title: #24: MAN: Add a manpage for the sssd-secrets responder
fidencio commented:
"""
I'm using libcurl 7.47 on F24 and I have no problem using a full URL as
described in the examples.
So, I'm giving an ACK to the patch. In
URL: https://github.com/SSSD/sssd/pull/24
Title: #24: MAN: Add a manpage for the sssd-secrets responder
fidencio commented:
"""
I'm using curl 7.47 on F24 and I have no problem using a full URL as described
in the examples.
So, I'm giving an ACK to the patch. In
URL: https://github.com/SSSD/sssd/pull/33
Title: #33: SECRETS: Some small misc fixes + fixing #3168
fidencio commented:
"""
And CI has passed: http://sssd-ci.duckdns.org/logs/job/54/46/summary.html
Although, github complains that all checks have failed for some reason.
&q
URL: https://github.com/SSSD/sssd/pull/33
Author: fidencio
Title: #33: SECRETS: Some small misc fixes + fixing #3168
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/33/head:pr33
git checkout pr33
From
URL: https://github.com/SSSD/sssd/pull/33
Title: #33: SECRETS: Some small misc fixes + fixing #3168
fidencio commented:
"""
Done!
"""
See the full comment at
https://github.com/SSSD/sssd/pull/33#issuecomment-250682778
_
URL: https://github.com/SSSD/sssd/pull/33
Author: fidencio
Title: #33: SECRETS: Some small misc fixes + fixing #3168
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/33/head:pr33
git checkout pr33
From
URL: https://github.com/SSSD/sssd/pull/33
Title: #33: SECRETS: Some small misc fixes + fixing #3168
fidencio commented:
"""
Okay, with this last patch series config-check works like a charm for [secrets]
and [secrets/users/$uid].
Also the name of the newly introduced property
URL: https://github.com/SSSD/sssd/pull/33
Author: fidencio
Title: #33: SECRETS: Some small misc fixes + fixing #3168
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/33/head:pr33
git checkout pr33
From
URL: https://github.com/SSSD/sssd/pull/33
Title: #33: SECRETS: Some small misc fixes + fixing #3168
fidencio commented:
"""
And here is the diff between the last series and the new one that's arriving in
a few ...
src/config/SSSDConfig/__init__.py.in | 1 +
src/conf
URL: https://github.com/SSSD/sssd/pull/36
Author: fidencio
Title: #36: Partial fix for #3169
Action: opened
PR body:
"""
Ticket #3169 is about having a quota for sssd secrets.
This quota depends basically on the number of stored secrets and the size
of (the payload of the) eac
URL: https://github.com/SSSD/sssd/pull/37
Title: #37: Add DEBUG messages to the sssd-secrets responder
Label: +Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fed
URL: https://github.com/SSSD/sssd/pull/38
Title: #38: IPA: Initialize has_changes boolean control value
fidencio commented:
"""
Hmm. Nice catch.
Didn't run any test but the code looks okay. Did you run CI on this? Feel free
to push when it passes.
""&qu
URL: https://github.com/SSSD/sssd/pull/38
Title: #38: IPA: Initialize has_changes boolean control value
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahoste
URL: https://github.com/SSSD/sssd/pull/38
Title: #38: IPA: Initialize has_changes boolean control value
fidencio commented:
"""
@jhrozek: I've checked sssd-1-13 already. There refresh_has_changes is always
initialized as false before calling ipa_subdomains_refresh():
htt
URL: https://github.com/SSSD/sssd/pull/37
Title: #37: Add DEBUG messages to the sssd-secrets responder
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted
URL: https://github.com/SSSD/sssd/pull/37
Title: #37: Add DEBUG messages to the sssd-secrets responder
fidencio commented:
"""
Yes, all comments were addressed. Feel free to push the whole series (when CI
passes).
"""
See the full comment at
https://github.com/
URL: https://github.com/SSSD/sssd/pull/38
Title: #38: IPA: Initialize has_changes boolean control value
fidencio commented:
"""
Super. Please, just remember to add the reference to the bug before pushing the
patch.
"""
See the full comment at
https://github.com/
URL: https://github.com/SSSD/sssd/pull/38
Title: #38: IPA: Initialize has_changes boolean control value
fidencio commented:
"""
Your text editor puts 4 spaces before the link for the bug. Please, avoid it.
Also, to be consistent with the commit template, move this whole part
&
URL: https://github.com/SSSD/sssd/pull/38
Title: #38: IPA: Initialize has_changes boolean control value
fidencio commented:
"""
Okay, go for it!
"""
See the full comment at
https://github.com/SSSD/sssd/pull/38#issuecomment-251490003
URL: https://github.com/SSSD/sssd/pull/36
Author: fidencio
Title: #36: Partial fix for #3169
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/36/head:pr36
git checkout pr36
From b4ee0be14b805b33cca81319c97d15ef856ac5e4
URL: https://github.com/SSSD/sssd/pull/36
Title: #36: Partial fix for #3169
fidencio commented:
"""
Done!
"""
See the full comment at
https://github.com/SSSD/sssd/pull/36#issuecomment-251497769
___
sssd-de
URL: https://github.com/SSSD/sssd/pull/36
Title: #36: Partial fix for #3169
fidencio commented:
"""
Done!
Btw, CI is running ...
"""
See the full comment at
https://github.com/SSSD/sssd/pull/36#issuecomment-251497769
_
URL: https://github.com/SSSD/sssd/pull/36
Title: #36: Partial fix for #3169
Label: -Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/36
Author: fidencio
Title: #36: Partial fix for #3169
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/36/head:pr36
git checkout pr36
From 3595d4c8f2ae2439c35ffe9401e3ca5f5ff19fd3
URL: https://github.com/SSSD/sssd/pull/36
Title: #36: Partial fix for #3169
fidencio commented:
"""
CI: http://sssd-ci.duckdns.org/logs/job/54/65/summary.html
It has failed on RHEL7, but the failure isn't related to the patch.
"""
See the full comment at
h
URL: https://github.com/SSSD/sssd/pull/39
Title: #39: RESPONDER: Enable sudoRule in case insen. domains
fidencio commented:
"""
On Thu, Oct 6, 2016 at 7:56 AM, celestian wrote:
> It's time for little explanation.
>
> SSSD (version 1.13) is able to find proper
URL: https://github.com/SSSD/sssd/pull/40
Author: fidencio
Title: #40: TESTS: Remove a leftover debug message
Action: opened
PR body:
"""
The debug message was introduced when I was testing 65a38b8c9, but ended
up not removed before submitting the patch.
Signed-off-by: F
URL: https://github.com/SSSD/sssd/pull/45
Title: #45: tests: Add unit tests for UPNs in SSS_NSS_GETSIDBYNAME and
SSS_NSS_GETORIGBYNAME
fidencio commented:
"""
@jhrozek: code-wise the bew patches look good. However, I really would like to
have a review from @sumit-bose here
URL: https://github.com/SSSD/sssd/pull/43
Title: #43: RESPONDER: Enable sudoRule in case insen. domains (1.14)
Label: +Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@
URL: https://github.com/SSSD/sssd/pull/48
Title: #48: sssctl: Flags for commadn initialization
Label: +Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahoste
URL: https://github.com/SSSD/sssd/pull/44
Title: #44: libwbclient-sssd: update interface to version 0.13
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahost
URL: https://github.com/SSSD/sssd/pull/44
Title: #44: libwbclient-sssd: update interface to version 0.13
fidencio commented:
"""
Okay, please, fire our CI and feel free to push the patches after CI passes.
"""
See the full comment at
https://github.com/SSSD/sssd/
URL: https://github.com/SSSD/sssd/pull/48
Title: #48: sssctl: Flags for commadn initialization
Label: -Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahoste
URL: https://github.com/SSSD/sssd/pull/44
Title: #44: libwbclient-sssd: update interface to version 0.13
fidencio commented:
"""
@jhrozek: Okay, okay. I'm running CI on #47 and we can get back to this one
after having that series pushed.
"""
See the full
URL: https://github.com/SSSD/sssd/pull/48
Title: #48: sssctl: Flags for commadn initialization
Label: +Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahoste
URL: https://github.com/SSSD/sssd/pull/13
Title: #13: MEMBEROF: Don't resolve members if they are removed
fidencio commented:
"""
On Fri, Oct 14, 2016 at 9:46 AM, celestian wrote:
> So, I looked this patch set again. Both, ldap and memberof patch, can fix
> t
URL: https://github.com/SSSD/sssd/pull/50
Author: fidencio
Title: #50: [RFC] Use GNULIB's compiler warning code
Action: opened
PR body:
"""
This patch series was sent to the sssd-devel and some discussions
already happened there[0]. I've decided to open the PR b
URL: https://github.com/SSSD/sssd/pull/53
Author: fidencio
Title: #53: Fixes in the config API related to secrets responder
Action: opened
PR body:
"""
Those fixes were suggested by Lukaš in the following thread:
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.f
URL: https://github.com/SSSD/sssd/pull/55
Author: fidencio
Title: #55: TESTS: Fix check for py bindings in dlopen tests
Action: opened
PR body:
"""
The current code checks only for "HAVE_PYTHON_BINDINGS", which is not
even a valid check. Let's do the proper
URL: https://github.com/SSSD/sssd/pull/53
Author: fidencio
Title: #53: Fixes in the config API related to secrets responder
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/53/head:pr53
git checkout pr53
From
URL: https://github.com/SSSD/sssd/pull/53
Title: #53: Fixes in the config API related to secrets responder
fidencio commented:
"""
And CI has passed: http://sssd-ci.duckdns.org/logs/job/55/24/summary.html
"""
See the full comment at
https://github.com/SSSD/sssd/
URL: https://github.com/SSSD/sssd/pull/52
Title: #52: CI: Remove dlopen-test from valgrind blacklist
fidencio commented:
"""
Please, refer to e1a58f3d in the commit message.
This is a genuine question (even in case it's a dumb one), but do we really
need to call dlclose()
URL: https://github.com/SSSD/sssd/pull/52
Title: #52: CI: Remove dlopen-test from valgrind blacklist
fidencio commented:
"""
On Mon, Oct 17, 2016 at 10:52 PM, lslebodn wrote:
> On (17/10/16 12:34), fidencio wrote:
> >Please, refer to e1a58f3d in the commit message.
>
URL: https://github.com/SSSD/sssd/pull/52
Title: #52: CI: Remove dlopen-test from valgrind blacklist
fidencio commented:
"""
On Mon, Oct 17, 2016 at 11:37 PM, lslebodn wrote:
> On (17/10/16 14:26), fidencio wrote:
> >On Mon, Oct 17, 2016 at 10:52 PM, lslebodn
> w
URL: https://github.com/SSSD/sssd/pull/52
Title: #52: CI: Remove dlopen-test from valgrind blacklist
fidencio commented:
"""
On Mon, Oct 17, 2016 at 11:51 PM, lslebodn wrote:
> On (17/10/16 14:43), fidencio wrote:
> >On Mon, Oct 17, 2016 at 11:37 PM, lslebodn
> w
URL: https://github.com/SSSD/sssd/pull/52
Title: #52: CI: Remove dlopen-test from valgrind blacklist
fidencio commented:
"""
On Wed, Oct 19, 2016 at 7:43 AM, lslebodn wrote:
> On (17/10/16 14:55), fidencio wrote:
> >On Mon, Oct 17, 2016 at 11:51 PM, lslebodn
URL: https://github.com/SSSD/sssd/pull/53
Title: #53: Fixes in the config API related to secrets responder
Label: -Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists
URL: https://github.com/SSSD/sssd/pull/53
Title: #53: Fixes in the config API related to secrets responder
fidencio commented:
"""
@jhrozek I'm removing "Changes requested" label as the last patchset (from 2
days ago) already contains the changes requested by Lu
URL: https://github.com/SSSD/sssd/pull/50
Title: #50: [RFC] Use GNULIB's compiler warning code
Label: +Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahoste
URL: https://github.com/SSSD/sssd/pull/61
Title: #61: BUILD: Fix build without samba
fidencio commented:
"""
Please, fix the typos in the commit message before pushing.
shoudl bw -> should be
"""
See the full comment at
https://github.com/SSSD/ss
URL: https://github.com/SSSD/sssd/pull/63
Title: #63: BUILD: Fix installation without samba
fidencio commented:
"""
Patch makes sense.
I'll run our CI on this and ACK as soon as CI passes.
Thanks for you contribution.
"""
See the full comment at
h
URL: https://github.com/SSSD/sssd/pull/53
Author: fidencio
Title: #53: Fixes in the config API related to secrets responder
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/53/head:pr53
git checkout pr53
From
URL: https://github.com/SSSD/sssd/pull/53
Title: #53: Fixes in the config API related to secrets responder
fidencio commented:
"""
@jhrozek:
For the first patch the tests are correct. @lslebodn also complained that
[secrets/users/] could be a valid case in the way the code is i
URL: https://github.com/SSSD/sssd/pull/75
Author: fidencio
Title: #75: Add configuirable max payload size limit of a secret
Action: opened
PR body:
"""
This series may conflict with PR53[0]. So either one or another will
need to be rebased after the first one gets merg
URL: https://github.com/SSSD/sssd/pull/75
Author: fidencio
Title: #75: Add configuirable max payload size limit of a secret
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/75/head:pr75
git checkout pr75
From
URL: https://github.com/SSSD/sssd/pull/75
Author: fidencio
Title: #75: Add configuirable max payload size limit of a secret
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/75/head:pr75
git checkout pr75
From
URL: https://github.com/SSSD/sssd/pull/75
Title: #75: Add configuirable max payload size limit of a secret
fidencio commented:
"""
Thanks for catching this, @lslebodn.
I've ran the CI locally and it has passed. I was wondering what was my mistake
and `git stash pop
URL: https://github.com/SSSD/sssd/pull/50
Author: fidencio
Title: #50: [RFC] Use GNULIB's compiler warning code
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/50/head:pr50
git checkout pr50
URL: https://github.com/SSSD/sssd/pull/50
Title: #50: [RFC] Use GNULIB's compiler warning code
Label: -Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahoste
URL: https://github.com/SSSD/sssd/pull/50
Title: #50: [RFC] Use GNULIB's compiler warning code
fidencio commented:
"""
I've updated this series and I'm still waiting for CI to finish.
A lot of warnings were just caught when building on RHEL6 machine (which passe
URL: https://github.com/SSSD/sssd/pull/50
Title: #50: [RFC] Use GNULIB's compiler warning code
fidencio commented:
"""
http://sssd-ci.duckdns.org/logs/job/56/78/summary.html
"""
See the full comment at
https://github.com/SSSD/
URL: https://github.com/SSSD/sssd/pull/50
Title: #50: [RFC] Use GNULIB's compiler warning code
fidencio commented:
"""
@lslebodn, a way easier solution would be to disable -Werror when running CI on
RHEL6 than fixing those issues only caught there. Is there a simple way t
URL: https://github.com/SSSD/sssd/pull/50
Title: #50: [RFC] Use GNULIB's compiler warning code
fidencio commented:
"""
Disabling Werror on RHEL6 will be just a matter of passing "--enable-werror=no"
to configure. It should be **really** simple as long as we a
URL: https://github.com/SSSD/sssd/pull/50
Title: #50: [RFC] Use GNULIB's compiler warning code
fidencio commented:
"""
Lukáš,
I'm afraid you didn't understand how the usage of the GNULIB's compiler
warnings is supposed to be.
There are basical
URL: https://github.com/SSSD/sssd/pull/50
Author: fidencio
Title: #50: [RFC] Use GNULIB's compiler warning code
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/50/head:pr50
git checkout pr50
URL: https://github.com/SSSD/sssd/pull/50
Title: #50: [RFC] Use GNULIB's compiler warning code
fidencio commented:
"""
@lslebodn:
After some proper checking, seems that all "-Wunitialized" reports are false
positives, so I've removed the patches from this se
URL: https://github.com/SSSD/sssd/pull/50
Title: #50: [RFC] Use GNULIB's compiler warning code
fidencio commented:
"""
So, here are some stats about the configure time that you complained before:
So, I've ran the contrib/ci/run script on our F25 machine on Jenki
URL: https://github.com/SSSD/sssd/pull/50
Title: #50: [RFC] Use GNULIB's compiler warning code
fidencio commented:
"""
So, here are some stats about the configure time that you complained before:
So, I've ran the contrib/ci/run script on our F25 machine on Jenki
1 - 100 of 2359 matches
Mail list logo
