[SSSD] [sssd PR#476][comment] IPA: Handle empty nisDomainName

2018-03-07 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/476 Title: #476: IPA: Handle empty nisDomainName lslebodn commented: """ @sumit-bose, thank you very much for increasing test coverage. Initially I though that it could be included in sssd git using our internal python-multihost `s

[SSSD] [sssd PR#476][comment] IPA: Handle empty nisDomainName

2018-03-07 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/476 Title: #476: IPA: Handle empty nisDomainName lslebodn commented: """ @sumit-bose, thank you very much for increasing test coverage. Initially I though that it could be included in sssd git using our internal python-multihost `s

[SSSD] [sssd PR#476][+Accepted] IPA: Handle empty nisDomainName

2018-03-07 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/476 Title: #476: IPA: Handle empty nisDomainName Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#527][comment] PEP8 Fixes and enable PEP8 check in CI

2018-03-02 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/527 Title: #527: PEP8 Fixes and enable PEP8 check in CI lslebodn commented: """ I would like to also ask whether it make a sense fix pep8 issues in the file src/tests/python-test.py. The file/test will be removed as part of PR #4

[SSSD] [sssd PR#527][comment] PEP8 Fixes and enable PEP8 check in CI

2018-03-02 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/527 Title: #527: PEP8 Fixes and enable PEP8 check in CI lslebodn commented: """ @mzidek-rh, Could you help me to find a way how to enable catching warning in commit "TESTS: Fix E501 pep8 issues on utils.py"? ``` sh-4.4$ gi

[SSSD] [sssd PR#526][comment] SSS_PYTHON: Use PyUnicode_FromString() with py3 code

2018-03-01 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/526 Title: #526: SSS_PYTHON: Use PyUnicode_FromString() with py3 code lslebodn commented: """ On (01/03/18 16:27), fidencio wrote: >fidencio commented on this pull request. >> docobj = PyString_FromString(doc

[SSSD] [sssd PR#488][closed] Two fixes for certificates in idoverrides

2018-02-27 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/488 Author: sumit-bose Title: #488: Two fixes for certificates in idoverrides Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/488/head:pr488 git checkout pr488

[SSSD] [sssd PR#488][comment] Two fixes for certificates in idoverrides

2018-02-27 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/488 Title: #488: Two fixes for certificates in idoverrides lslebodn commented: """ >Yes, but one of the ssh patches was a dependency for 4300385 so I thought it's >safer to just cleanly apply patches and have one less bug in sssd-1-

[SSSD] [sssd PR#488][+Pushed] Two fixes for certificates in idoverrides

2018-02-27 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/488 Title: #488: Two fixes for certificates in idoverrides Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#523][comment] IPA: Drop unused ifdef HAVE_SELINUX_LOGIN_DIR

2018-02-27 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/523 Title: #523: IPA: Drop unused ifdef HAVE_SELINUX_LOGIN_DIR lslebodn commented: """ master: * 47362caf4c30c3ff5a143f4f4a7fd5599db03b48 * 2f8d0cc83b986b1d302d431f7a3b7c90682faf99 """ See the full comment at https:/

[SSSD] [sssd PR#523][closed] IPA: Drop unused ifdef HAVE_SELINUX_LOGIN_DIR

2018-02-27 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/523 Author: lslebodn Title: #523: IPA: Drop unused ifdef HAVE_SELINUX_LOGIN_DIR Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/523/head:pr523 git checkout pr523

[SSSD] [sssd PR#523][+Pushed] IPA: Drop unused ifdef HAVE_SELINUX_LOGIN_DIR

2018-02-27 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/523 Title: #523: IPA: Drop unused ifdef HAVE_SELINUX_LOGIN_DIR Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#488][comment] Two fixes for certificates in idoverrides

2018-02-27 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/488 Title: #488: Two fixes for certificates in idoverrides lslebodn commented: """ @sumit-bose, I think it should be enough to backport "ipa: remove SYSDB_USER_CERT from sub-domain users". At least just this patch was in #494.

[SSSD] [sssd PR#524][opened] CI: Add dbus into debian dependencies

2018-02-26 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/524 Author: lslebodn Title: #524: CI: Add dbus into debian dependencies Action: opened PR body: """ There is just weak dependency (recommends) between dbus libraries and dbus daemon. It is installed by default but we should not rely in in

[SSSD] [sssd PR#523][synchronized] IPA: Drop unused ifdef HAVE_SELINUX_LOGIN_DIR

2018-02-26 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/523 Author: lslebodn Title: #523: IPA: Drop unused ifdef HAVE_SELINUX_LOGIN_DIR Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/523/head:pr523 git checkout pr523 From

[SSSD] [sssd PR#523][comment] IPA: Drop unused ifdef HAVE_SELINUX_LOGIN_DIR

2018-02-26 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/523 Title: #523: IPA: Drop unused ifdef HAVE_SELINUX_LOGIN_DIR lslebodn commented: """ On (26/02/18 11:30), Pavel Březina wrote: >When touching `sssm_ipa_selinux_init` can you also fix this typo: Sure. Nice catch. """

[SSSD] [sssd PR#523][opened] IPA: Drop unused ifdef HAVE_SELINUX_LOGIN_DIR

2018-02-26 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/523 Author: lslebodn Title: #523: IPA: Drop unused ifdef HAVE_SELINUX_LOGIN_DIR Action: opened PR body: """ Macros ALL_SERVICES and selogin_path were conditionally defined in case of existing selinux login directory at configure time

[SSSD] [sssd PR#391][comment] Use dbus-daemon in cwrap enviroment for test

2018-02-23 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/391 Title: #391: Use dbus-daemon in cwrap enviroment for test lslebodn commented: """ master: * 0df79781d78973e5462dbef1e89d8fd6001da05c * e64696e1fab85c42aaeda65ddf49ee1b7e3f07e1 * 52ae4eeba9c97c0254a2025ec

[SSSD] [sssd PR#391][+Pushed] Use dbus-daemon in cwrap enviroment for test

2018-02-23 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/391 Title: #391: Use dbus-daemon in cwrap enviroment for test Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#391][closed] Use dbus-daemon in cwrap enviroment for test

2018-02-23 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/391 Author: lslebodn Title: #391: Use dbus-daemon in cwrap enviroment for test Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/391/head:pr391 git checkout pr391

[SSSD] [sssd PR#391][comment] Use dbus-daemon in cwrap enviroment for test

2018-02-23 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/391 Title: #391: Use dbus-daemon in cwrap enviroment for test lslebodn commented: """ >I'm sorry I didn't see there was already ack by pbrezina and then the patches >only had a trivial change. No need to apologize. We are all busy

[SSSD] [sssd PR#514][+Pushed] Backport several UPN related patches to sssd-1-13

2018-02-23 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/514 Title: #514: Backport several UPN related patches to sssd-1-13 Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#514][comment] Backport several UPN related patches to sssd-1-13

2018-02-23 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/514 Title: #514: Backport several UPN related patches to sssd-1-13 lslebodn commented: """ sssd-1-13: * 99afca8926fb211774de457e750dea27da8ac3a9 * 42dbd7ee691ffef8b136fc310128aadfd91fd70c * f6afb6f9418735bcfd125eb2bb2ffeeb5cc07d99 "&quo

[SSSD] [sssd PR#514][closed] Backport several UPN related patches to sssd-1-13

2018-02-23 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/514 Author: jhrozek Title: #514: Backport several UPN related patches to sssd-1-13 Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/514/head:pr514 git checkout pr514

[SSSD] [sssd PR#514][comment] Backport several UPN related patches to sssd-1-13

2018-02-23 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/514 Title: #514: Backport several UPN related patches to sssd-1-13 lslebodn commented: """ Thank you very much for additional info in commit messages. ACK """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#513][+Pushed] SPEC: Reduce changes between upstream and downstream

2018-02-22 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/513 Title: #513: SPEC: Reduce changes between upstream and downstream Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#513][comment] SPEC: Reduce changes between upstream and downstream

2018-02-22 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/513 Title: #513: SPEC: Reduce changes between upstream and downstream lslebodn commented: """ master: * 65afba536e4535b1381ae5468edb16b3c9b89578 """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#513][closed] SPEC: Reduce changes between upstream and downstream

2018-02-22 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/513 Author: lslebodn Title: #513: SPEC: Reduce changes between upstream and downstream Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/513/head:pr513 git checkout pr513

[SSSD] [sssd PR#509][closed] SPEC: Fix systemd executions/requirements

2018-02-22 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/509 Author: lslebodn Title: #509: SPEC: Fix systemd executions/requirements Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/509/head:pr509 git checkout pr509

[SSSD] [sssd PR#509][comment] SPEC: Fix systemd executions/requirements

2018-02-22 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/509 Title: #509: SPEC: Fix systemd executions/requirements lslebodn commented: """ master: * 274ee2952fcb521222fe1eb86331c6dab505dc3a """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#509][+Pushed] SPEC: Fix systemd executions/requirements

2018-02-22 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/509 Title: #509: SPEC: Fix systemd executions/requirements Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#428][+Pushed] CI: Ignore source file generated by systemtap in coverage

2018-02-22 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/428 Title: #428: CI: Ignore source file generated by systemtap in coverage Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#442][+Pushed] LDAP: Improve error treatment from sdap_cli_connect() in ldap_auth

2018-02-22 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/442 Title: #442: LDAP: Improve error treatment from sdap_cli_connect() in ldap_auth Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#496][+Pushed] sysdb: sanitize search filter input - backport sssd-1-13

2018-02-22 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/496 Title: #496: sysdb: sanitize search filter input - backport sssd-1-13 Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#496][closed] sysdb: sanitize search filter input - backport sssd-1-13

2018-02-22 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/496 Author: sumit-bose Title: #496: sysdb: sanitize search filter input - backport sssd-1-13 Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/496/head:pr496 git checkout pr496

[SSSD] [sssd PR#496][comment] sysdb: sanitize search filter input - backport sssd-1-13

2018-02-22 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/496 Title: #496: sysdb: sanitize search filter input - backport sssd-1-13 lslebodn commented: """ master: * 3cf0aa1904fe791eed414bfb532c91a79ea2df9c * 0c0b9a3323dfc7988a58d4b67e9c94d0567ee82c * 76b79f5a816152d5aa07618b7

[SSSD] [sssd PR#516][+Pushed] DESKPROFILE: Document it doesn't work when run as unprivileged user

2018-02-22 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/516 Title: #516: DESKPROFILE: Document it doesn't work when run as unprivileged user Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#516][closed] DESKPROFILE: Document it doesn't work when run as unprivileged user

2018-02-22 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/516 Author: fidencio Title: #516: DESKPROFILE: Document it doesn't work when run as unprivileged user Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/516/head:pr516 git checkout pr516

[SSSD] [sssd PR#516][comment] DESKPROFILE: Document it doesn't work when run as unprivileged user

2018-02-22 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/516 Title: #516: DESKPROFILE: Document it doesn't work when run as unprivileged user lslebodn commented: """ master: * 5150fbdc429ee9ed52e80e5f133ddb48c5b79914 """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#521][+Pushed] Avoid double semicolon warnings on older compilers

2018-02-22 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/521 Title: #521: Avoid double semicolon warnings on older compilers Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#521][comment] Avoid double semicolon warnings on older compilers

2018-02-22 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/521 Title: #521: Avoid double semicolon warnings on older compilers lslebodn commented: """ comment would not work; because it would bot be expanded by macro. ACK++ """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#521][closed] Avoid double semicolon warnings on older compilers

2018-02-22 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/521 Author: cryptomilk Title: #521: Avoid double semicolon warnings on older compilers Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/521/head:pr521 git checkout pr521

[SSSD] [sssd PR#521][comment] Avoid double semicolon warnings on older compilers

2018-02-22 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/521 Title: #521: Avoid double semicolon warnings on older compilers lslebodn commented: """ master: * 1ef36a878ac0f55c97e4d1c5597ac9cc1a52613a """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#496][comment] sysdb: sanitize search filter input - backport sssd-1-13

2018-02-22 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/496 Title: #496: sysdb: sanitize search filter input - backport sssd-1-13 lslebodn commented: """ LGTM :-) I'll wait with pushing till after successful run in centos ci """ See the full comment at https://github.com/S

[SSSD] [sssd PR#521][comment] Avoid double semicolon warnings on older compilers

2018-02-22 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/521 Title: #521: Avoid double semicolon warnings on older compilers lslebodn commented: """ Andreas created PR also on pagure and added comment there https://pagure.io/SSSD/sssd/pull-request/3645 A

[SSSD] [sssd PR#496][comment] sysdb: sanitize search filter input - backport sssd-1-13

2018-02-22 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/496 Title: #496: sysdb: sanitize search filter input - backport sssd-1-13 lslebodn commented: """ > Do you think that for completeness and easier reference it would be ok if I > push your patches to this PR and the 1.14 ones to PR#49

[SSSD] [sssd PR#497][+Pushed] sysdb: sanitize search filter input - backport sssd-1-14

2018-02-21 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/497 Title: #497: sysdb: sanitize search filter input - backport sssd-1-14 Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#516][-Accepted] DESKPROFILE: Document it doesn't work when run as unprivileged user

2018-02-21 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/516 Title: #516: DESKPROFILE: Document it doesn't work when run as unprivileged user Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#516][comment] DESKPROFILE: Document it doesn't work when run as unprivileged user

2018-02-21 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/516 Title: #516: DESKPROFILE: Document it doesn't work when run as unprivileged user lslebodn commented: """ Justin, thank you for review """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#516][comment] DESKPROFILE: Document it doesn't work when run as unprivileged user

2018-02-21 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/516 Title: #516: DESKPROFILE: Document it doesn't work when run as unprivileged user lslebodn commented: """ I tried to figure out why centos CI is failing and I noticed that xml element `note` is not allowed in DTD ``` /usr/bin/xml

[SSSD] [sssd PR#496][-Changes requested] sysdb: sanitize search filter input - backport sssd-1-13

2018-02-21 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/496 Title: #496: sysdb: sanitize search filter input - backport sssd-1-13 Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#516][+Changes requested] DESKPROFILE: Document it doesn't work when run as unprivileged user

2018-02-21 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/516 Title: #516: DESKPROFILE: Document it doesn't work when run as unprivileged user Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#496][comment] sysdb: sanitize search filter input - backport sssd-1-13

2018-02-21 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/496 Title: #496: sysdb: sanitize search filter input - backport sssd-1-13 lslebodn commented: """ And here are patches for 1.13 https://github.com/lslebodn/sssd/tree/cve_backport_1.13 @sumit-bose could you check them? """

[SSSD] [sssd PR#497][closed] sysdb: sanitize search filter input - backport sssd-1-14

2018-02-21 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/497 Author: sumit-bose Title: #497: sysdb: sanitize search filter input - backport sssd-1-14 Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/497/head:pr497 git checkout pr497

[SSSD] [sssd PR#497][comment] sysdb: sanitize search filter input - backport sssd-1-14

2018-02-21 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/497 Title: #497: sysdb: sanitize search filter input - backport sssd-1-14 lslebodn commented: """ sssd-1-14: * e45e50e4523e36f310d7ff0b052500c024c434bf * e358dd7b4992da4c4aa7b7f769bd597222715127 * 353853d479225ba7a625658e5

[SSSD] [sssd PR#497][comment] sysdb: sanitize search filter input - backport sssd-1-14

2018-02-21 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/497 Title: #497: sysdb: sanitize search filter input - backport sssd-1-14 lslebodn commented: """ >@lslebodn, thank you for backporting. The selected patches are looking good. Thank you for checking. I'll push patches + create backport f

[SSSD] [sssd PR#514][comment] Backport several UPN related patches to sssd-1-13

2018-02-21 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/514 Title: #514: Backport several UPN related patches to sssd-1-13 lslebodn commented: """ As part of backporting patches for sanitizing sysdb filters, we found out that we might consider backporting also afadeb1a530ff010a2f9a7552562576

[SSSD] [sssd PR#497][comment] sysdb: sanitize search filter input - backport sssd-1-14

2018-02-21 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/497 Title: #497: sysdb: sanitize search filter input - backport sssd-1-14 lslebodn commented: """ I know we started discussion as part of #496 but I firstly backported patches + sysdb unit tests to 1.14 branch. https://github.com/lsl

[SSSD] [sssd PR#516][comment] DESKPROFILE: Document it doesn't work when run as unprivileged user

2018-02-21 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/516 Title: #516: DESKPROFILE: Document it doesn't work when run as unprivileged user lslebodn commented: """ LGTM from content point of view. @justin-stephenson could you check this PR as well? """ See the full comment at

[SSSD] [sssd PR#488][comment] Two fixes for certificates in idoverrides

2018-02-21 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/488 Title: #488: Two fixes for certificates in idoverrides lslebodn commented: """ This PR is also required for stable branch (1.13) #494. Please do not forget to push it also to older branches after pushing to master """

[SSSD] [sssd PR#494][+Pushed] Backport support for certificates in idoverrides to sssd-1.13

2018-02-21 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/494 Title: #494: Backport support for certificates in idoverrides to sssd-1.13 Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#494][closed] Backport support for certificates in idoverrides to sssd-1.13

2018-02-21 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/494 Author: sumit-bose Title: #494: Backport support for certificates in idoverrides to sssd-1.13 Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/494/head:pr494 git checkout pr494

[SSSD] [sssd PR#494][comment] Backport support for certificates in idoverrides to sssd-1.13

2018-02-21 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/494 Title: #494: Backport support for certificates in idoverrides to sssd-1.13 lslebodn commented: """ sssd-1-13: * 9d1397219374531e7f2a3188ea6aa9f86ca35f9e * 81f9af96065eb94ed0a9e6ef2b759761406b4b81 * f13505ce5632822e093982ca3

[SSSD] [sssd PR#494][comment] Backport support for certificates in idoverrides to sssd-1.13

2018-02-21 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/494 Title: #494: Backport support for certificates in idoverrides to sssd-1.13 lslebodn commented: """ > I added '(cherry picked from ...)' to the commit messages with a hint if > fixes where needed or not. thank you and ACK >

[SSSD] [sssd PR#520][+Pushed] DESKPROFILE: Fix 'Improper use of negative value'

2018-02-20 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/520 Title: #520: DESKPROFILE: Fix 'Improper use of negative value' Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#520][closed] DESKPROFILE: Fix 'Improper use of negative value'

2018-02-20 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/520 Author: sumit-bose Title: #520: DESKPROFILE: Fix 'Improper use of negative value' Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/520/head:pr520 git checkout pr520

[SSSD] [sssd PR#520][comment] DESKPROFILE: Fix 'Improper use of negative value'

2018-02-20 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/520 Title: #520: DESKPROFILE: Fix 'Improper use of negative value' lslebodn commented: """ master: * 0633e97cfd6a696c19e19219e3de1cda7c7ee7b4 """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#517][comment] Fix two memory leaks in the AD provider

2018-02-17 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/517 Title: #517: Fix two memory leaks in the AD provider lslebodn commented: """ retest this please """ See the full comment at https://github.com/SSSD/sssd/pull/517#issuecomment-366440086

[SSSD] [sssd PR#515][comment] sssctl: Showing help even when sssd not configured

2018-02-17 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/515 Title: #515: sssctl: Showing help even when sssd not configured lslebodn commented: """ retest this please """ See the full comment at https://github.com/SSSD/sssd/pull/515#issuecomment-366440039 __

[SSSD] [sssd PR#516][+Changes requested] DESKPROFILE: Document it doesn't work when run as unprivileged user

2018-02-16 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/516 Title: #516: DESKPROFILE: Document it doesn't work when run as unprivileged user Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#435][comment] krb5: call krb5_auth_cache_creds() if a pssword is available

2018-02-16 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/435 Title: #435: krb5: call krb5_auth_cache_creds() if a pssword is available lslebodn commented: """ master: * a87658e5382a6ad119058d22b118a29eaae7a365 sssd-1-14: * 3546e6c0be2f85c9e1828237000a376a188e

[SSSD] [sssd PR#435][closed] krb5: call krb5_auth_cache_creds() if a pssword is available

2018-02-16 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/435 Author: sumit-bose Title: #435: krb5: call krb5_auth_cache_creds() if a pssword is available Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/435/head:pr435 git checkout pr435

[SSSD] [sssd PR#435][+Pushed] krb5: call krb5_auth_cache_creds() if a pssword is available

2018-02-16 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/435 Title: #435: krb5: call krb5_auth_cache_creds() if a pssword is available Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#435][+Accepted] krb5: call krb5_auth_cache_creds() if a pssword is available

2018-02-16 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/435 Title: #435: krb5: call krb5_auth_cache_creds() if a pssword is available Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#435][comment] krb5: call krb5_auth_cache_creds() if a pssword is available

2018-02-16 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/435 Title: #435: krb5: call krb5_auth_cache_creds() if a pssword is available lslebodn commented: """ Sanity test with krb5/ad/ipa passed ACK """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#518][+Pushed] PYSSS_MURMUR: Fix [-Wsign-compare] found by gcc

2018-02-16 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/518 Title: #518: PYSSS_MURMUR: Fix [-Wsign-compare] found by gcc Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#518][closed] PYSSS_MURMUR: Fix [-Wsign-compare] found by gcc

2018-02-16 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/518 Author: fidencio Title: #518: PYSSS_MURMUR: Fix [-Wsign-compare] found by gcc Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/518/head:pr518 git checkout pr518

[SSSD] [sssd PR#518][comment] PYSSS_MURMUR: Fix [-Wsign-compare] found by gcc

2018-02-16 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/518 Title: #518: PYSSS_MURMUR: Fix [-Wsign-compare] found by gcc lslebodn commented: """ master: * 1c42c3962577ea4b2d9ed6a8a07179d33756b3b4 """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#518][+Accepted] PYSSS_MURMUR: Fix [-Wsign-compare] found by gcc

2018-02-16 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/518 Title: #518: PYSSS_MURMUR: Fix [-Wsign-compare] found by gcc Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#518][comment] PYSSS_MURMUR: Fix [-Wsign-compare] found by gcc

2018-02-16 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/518 Title: #518: PYSSS_MURMUR: Fix [-Wsign-compare] found by gcc lslebodn commented: """ ACK """ See the full comment at https://github.com/SSSD/sssd/pull/518#issuecomment-366244091 _

[SSSD] [sssd PR#503][closed] Regression test for false possitive "corrupted" memory cache

2018-02-15 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/503 Author: lslebodn Title: #503: Regression test for false possitive "corrupted" memory cache Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/503/head:pr503 git chec

[SSSD] [sssd PR#503][+Pushed] Regression test for false possitive "corrupted" memory cache

2018-02-15 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/503 Title: #503: Regression test for false possitive "corrupted" memory cache Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#503][comment] Regression test for false possitive "corrupted" memory cache

2018-02-15 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/503 Title: #503: Regression test for false possitive "corrupted" memory cache lslebodn commented: """ master: * 6dc1de9781ab211a43d24cbaed7969d98abc1cc1 * fd17e0925dbcafedb878ddf828a37743c115c9dd * 8f83feea4586a8f

[SSSD] [sssd PR#503][comment] Regression test for false possitive "corrupted" memory cache

2018-02-15 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/503 Title: #503: Regression test for false possitive "corrupted" memory cache lslebodn commented: """ Thank you for review. """ See the full comment at https://github.com/S

[SSSD] [sssd PR#435][comment] krb5: call krb5_auth_cache_creds() if a pssword is available

2018-02-15 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/435 Title: #435: krb5: call krb5_auth_cache_creds() if a pssword is available lslebodn commented: """ Thank you for update. I'll run some krb5 tests for sanity checking. So far LGTM """ See the full comment at https:/

[SSSD] [sssd PR#435][-Changes requested] krb5: call krb5_auth_cache_creds() if a pssword is available

2018-02-15 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/435 Title: #435: krb5: call krb5_auth_cache_creds() if a pssword is available Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#515][-Changes requested] sssctl: Showing help even when sssd not configured

2018-02-15 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/515 Title: #515: sssctl: Showing help even when sssd not configured Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#515][comment] sssctl: Showing help even when sssd not configured

2018-02-15 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/515 Title: #515: sssctl: Showing help even when sssd not configured lslebodn commented: """ ok to test """ See the full comment at https://github.com/SSSD/sssd/pull/515#issuecomment-365909737

[SSSD] [sssd PR#391][comment] Use dbus-daemon in cwrap enviroment for test

2018-02-15 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/391 Title: #391: Use dbus-daemon in cwrap enviroment for test lslebodn commented: """ retest this please """ See the full comment at https://github.com/SSSD/sssd/pull/391#issuecomment-365858862

[SSSD] [sssd PR#494][+Changes requested] Backport support for certificates in idoverrides to sssd-1.13

2018-02-15 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/494 Title: #494: Backport support for certificates in idoverrides to sssd-1.13 Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#494][comment] Backport support for certificates in idoverrides to sssd-1.13

2018-02-15 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/494 Title: #494: Backport support for certificates in idoverrides to sssd-1.13 lslebodn commented: """ I assume you at least partially used cherry-pick + fixing conflicts due to sysdb changes. It would be good to mention hash of original t

[SSSD] [sssd PR#515][+Changes requested] sssctl: Showing help even when sssd not configured

2018-02-15 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/515 Title: #515: sssctl: Showing help even when sssd not configured Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#514][+Changes requested] Backport several UPN related patches to sssd-1-13

2018-02-15 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/514 Title: #514: Backport several UPN related patches to sssd-1-13 Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#514][comment] Backport several UPN related patches to sssd-1-13

2018-02-15 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/514 Title: #514: Backport several UPN related patches to sssd-1-13 lslebodn commented: """ The commits "Fix iterating to next domain for initgroup lookups" and "Make get_object_from_cache() aware of UPN searches" do

[SSSD] [sssd PR#435][+Changes requested] krb5: call krb5_auth_cache_creds() if a pssword is available

2018-02-15 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/435 Title: #435: krb5: call krb5_auth_cache_creds() if a pssword is available Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#435][comment] krb5: call krb5_auth_cache_creds() if a pssword is available

2018-02-15 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/435 Title: #435: krb5: call krb5_auth_cache_creds() if a pssword is available lslebodn commented: """ @sumit-bose, I would like to apologize for long pending review. I added inline comment. """ See the full comment at htt

[SSSD] [sssd PR#498][-Pushed] DESKPROFILE: Do not require CAP_DAC_OVERRIDE

2018-02-14 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/498 Title: #498: DESKPROFILE: Do not require CAP_DAC_OVERRIDE Label: -Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#498][comment] DESKPROFILE: Do not require CAP_DAC_OVERRIDE

2018-02-14 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/498 Title: #498: DESKPROFILE: Do not require CAP_DAC_OVERRIDE lslebodn commented: """ Unfortunately, it was pushed without careful review. That would not work when running sssd in non-privileged mode because `seteuid` will fail. And i

[SSSD] [sssd PR#498][-Accepted] DESKPROFILE: Do not require CAP_DAC_OVERRIDE

2018-02-14 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/498 Title: #498: DESKPROFILE: Do not require CAP_DAC_OVERRIDE Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#498][reopened] DESKPROFILE: Do not require CAP_DAC_OVERRIDE

2018-02-14 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/498 Author: fidencio Title: #498: DESKPROFILE: Do not require CAP_DAC_OVERRIDE Action: reopened To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/498/head:pr498 git checkout pr498

  1   2   3   4   5   6   7   8   9   10   >