[SSSD] [sssd PR#476][comment] IPA: Handle empty nisDomainName
URL: https://github.com/SSSD/sssd/pull/476 Title: #476: IPA: Handle empty nisDomainName lslebodn commented: """ @sumit-bose, thank you very much for increasing test coverage. Initially I though that it could be included in sssd git using our internal python-multihost `src/tests/python/`. But it is not related where is the test but that such test exist. Test is ready so please push this PR. > https://pagure.io/fork/sbose/SSSD/sssd/c/859ab248be719eef5d84dbbed27f146f2aa162e8?branch=netgroup_tests That can be reviewed as a separate PR because that one is IPA specific. I know it is a little bit unrelated but I have few tips to your netgroup test. It can be simplified a little bit + such version would not work with python3 (because 'str' object has no attribute 'decode') please create separate pr and I'll add comments there. """ See the full comment at https://github.com/SSSD/sssd/pull/476#issuecomment-371296550 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#476][comment] IPA: Handle empty nisDomainName
URL: https://github.com/SSSD/sssd/pull/476 Title: #476: IPA: Handle empty nisDomainName lslebodn commented: """ @sumit-bose, thank you very much for increasing test coverage. Initially I though that it could be included in sssd git using our internal python-multihost `src/tests/python/`. But it is not related where is the test but that such test exist. Test is ready so please push this PR. > https://pagure.io/fork/sbose/SSSD/sssd/c/859ab248be719eef5d84dbbed27f146f2aa162e8?branch=netgroup_tests Thank can be safely created as a separate PR because that one is IPA specific. I know it is a little bit unrelated but I have few tips to your netgroup test. It can be simplified a little bit + such version would not work with python3 (because 'str' object has no attribute 'decode') please create separate pr and i'll add comments there. """ See the full comment at https://github.com/SSSD/sssd/pull/476#issuecomment-371296550 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#476][+Accepted] IPA: Handle empty nisDomainName
URL: https://github.com/SSSD/sssd/pull/476 Title: #476: IPA: Handle empty nisDomainName Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#527][comment] PEP8 Fixes and enable PEP8 check in CI
URL: https://github.com/SSSD/sssd/pull/527 Title: #527: PEP8 Fixes and enable PEP8 check in CI lslebodn commented: """ I would like to also ask whether it make a sense fix pep8 issues in the file src/tests/python-test.py. The file/test will be removed as part of PR #430. Fortunately, there is already a way how skip checking of pep8 errors in ci script. BTW I tried really hard but I was not able to have "green" results from the test. (I manually create sssd.conf for local provider, install required dependencies python2-sss, python3-sss, sssd-tools, nscd, ldb-tools) @mzidek-rh, or could you five me a tips how did you ensure that it still works? """ See the full comment at https://github.com/SSSD/sssd/pull/527#issuecomment-370041624 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#527][comment] PEP8 Fixes and enable PEP8 check in CI
URL: https://github.com/SSSD/sssd/pull/527 Title: #527: PEP8 Fixes and enable PEP8 check in CI lslebodn commented: """ @mzidek-rh, Could you help me to find a way how to enable catching warning in commit "TESTS: Fix E501 pep8 issues on utils.py"? ``` sh-4.4$ git rev-parse --verify HEAD 47362caf4c30c3ff5a143f4f4a7fd5599db03b48 sh-4.4$ pep8 --version 1.6.2 sh-4.4$ pep8 src/tests/python/sssd/testlib/common/utils.py sh-4.4$ pep8 --max-line-length=79 src/tests/python/sssd/testlib/common/utils.py sh-4.4$ pep8 --max-line-length=79 --select=E501 src/tests/python/sssd/testlib/common/utils.py sh-4.4$ pep8 --ignore=E121,E123,E126,E226,E24,E704,W503,E722 src/tests/python/sssd/testlib/common/utils.py ``` It is also not reproducible with older and newer version (also tested with 1.5.7, 1.7.1 and 2.3.1) Maybe it is reproducible with older version of pep8. But it would be good to see that working on recent systems. BTW patch is correct and it is obvious after checking the file with editor. """ See the full comment at https://github.com/SSSD/sssd/pull/527#issuecomment-370039380 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#526][comment] SSS_PYTHON: Use PyUnicode_FromString() with py3 code
URL: https://github.com/SSSD/sssd/pull/526 Title: #526: SSS_PYTHON: Use PyUnicode_FromString() with py3 code lslebodn commented: """ On (01/03/18 16:27), fidencio wrote: >fidencio commented on this pull request. >> docobj = PyString_FromString(doc); >+#endif > >@lslebodn, this is a valid issue but not related to this patch. >Please, would you mind opening a ticket for it? If you don't have the time, >let me know and I will open the ticket and assign it to myself. > I am so sorry if I overlook something but title of this pull request is: **SSS_PYTHON: Use PyUnicode_FromString() with py3 code** And this code should be used only with python2.6 and never with python2.7 or python3. Because python2.7+ already have `PyErr_NewExceptionWithDoc` and we needn't use alternative implementation. In another words, we are adding almost dead code for python3. Or would you be so kind and could you explain what did I miss? LS """ See the full comment at https://github.com/SSSD/sssd/pull/526#issuecomment-369655636 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#488][closed] Two fixes for certificates in idoverrides
URL: https://github.com/SSSD/sssd/pull/488 Author: sumit-bose Title: #488: Two fixes for certificates in idoverrides Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/488/head:pr488 git checkout pr488 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#488][comment] Two fixes for certificates in idoverrides
URL: https://github.com/SSSD/sssd/pull/488 Title: #488: Two fixes for certificates in idoverrides lslebodn commented: """ >Yes, but one of the ssh patches was a dependency for 4300385 so I thought it's >safer to just cleanly apply patches and have one less bug in sssd-1-13 at the >same time. Of course, feel free to backport just 4300385 on its own if you >prefer to have a more minimal changeset in sssd-1-13. make sense sssd-1-14: * 24165ebec6fc3c76f93750022671c153f94b0d4e * b5c3597d0a13256d381b60ba24838d64edfb68df * 6c564d20a021016cf8d08fea2c57f40590a71178 sssd-1-13: * 5d2e7c3154ab4b7e2123b3418debf2e5359a0917 * a02baf4dac81278a597b0f5df66a3df3e3d5a2ca * 448cbbfa0284ecd88a9a8f900aa406fcd9d6fb1d """ See the full comment at https://github.com/SSSD/sssd/pull/488#issuecomment-368866758 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#488][+Pushed] Two fixes for certificates in idoverrides
URL: https://github.com/SSSD/sssd/pull/488 Title: #488: Two fixes for certificates in idoverrides Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#523][comment] IPA: Drop unused ifdef HAVE_SELINUX_LOGIN_DIR
URL: https://github.com/SSSD/sssd/pull/523 Title: #523: IPA: Drop unused ifdef HAVE_SELINUX_LOGIN_DIR lslebodn commented: """ master: * 47362caf4c30c3ff5a143f4f4a7fd5599db03b48 * 2f8d0cc83b986b1d302d431f7a3b7c90682faf99 """ See the full comment at https://github.com/SSSD/sssd/pull/523#issuecomment-368850934 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#523][closed] IPA: Drop unused ifdef HAVE_SELINUX_LOGIN_DIR
URL: https://github.com/SSSD/sssd/pull/523 Author: lslebodn Title: #523: IPA: Drop unused ifdef HAVE_SELINUX_LOGIN_DIR Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/523/head:pr523 git checkout pr523 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#523][+Pushed] IPA: Drop unused ifdef HAVE_SELINUX_LOGIN_DIR
URL: https://github.com/SSSD/sssd/pull/523 Title: #523: IPA: Drop unused ifdef HAVE_SELINUX_LOGIN_DIR Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#488][comment] Two fixes for certificates in idoverrides
URL: https://github.com/SSSD/sssd/pull/488 Title: #488: Two fixes for certificates in idoverrides lslebodn commented: """ @sumit-bose, I think it should be enough to backport "ipa: remove SYSDB_USER_CERT from sub-domain users". At least just this patch was in #494. Is that correct? """ See the full comment at https://github.com/SSSD/sssd/pull/488#issuecomment-368788279 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#524][opened] CI: Add dbus into debian dependencies
URL: https://github.com/SSSD/sssd/pull/524 Author: lslebodn Title: #524: CI: Add dbus into debian dependencies Action: opened PR body: """ There is just weak dependency (recommends) between dbus libraries and dbus daemon. It is installed by default but we should not rely in integration tests on weak dependency if we directly need binary dbus-daemon. sh# apt-cache depends libdbus-1-dev libdbus-1-3 libdbus-1-dev Depends: libdbus-1-3 Depends: pkg-config pkgconf libdbus-1-3 Depends: libc6 Depends: libsystemd0 Breaks: dbus Recommends: dbus """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/524/head:pr524 git checkout pr524 From 2a1e96433f4043d78b465507d877deac634bb131 Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik <lsleb...@redhat.com> Date: Mon, 26 Feb 2018 13:28:19 +0100 Subject: [PATCH] CI: Add dbus into debian dependencies There is just weak dependency (recommends) between dbus libraries and dbus daemon. It is installed by default but we should not rely in integration tests on weak dependency if we directly need binary dbus-daemon. sh# apt-cache depends libdbus-1-dev libdbus-1-3 libdbus-1-dev Depends: libdbus-1-3 Depends: pkg-config pkgconf libdbus-1-3 Depends: libc6 Depends: libsystemd0 Breaks: dbus Recommends: dbus --- contrib/ci/deps.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/ci/deps.sh b/contrib/ci/deps.sh index 89e6aae0e..2488ec91c 100644 --- a/contrib/ci/deps.sh +++ b/contrib/ci/deps.sh @@ -129,6 +129,7 @@ if [[ "$DISTRO_BRANCH" == -debian-* ]]; then krb5-admin-server krb5-user uuid-dev +dbus python-dbus ) DEPS_INTGCHECK_SATISFIED=true ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#523][synchronized] IPA: Drop unused ifdef HAVE_SELINUX_LOGIN_DIR
URL: https://github.com/SSSD/sssd/pull/523
Author: lslebodn
Title: #523: IPA: Drop unused ifdef HAVE_SELINUX_LOGIN_DIR
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/523/head:pr523
git checkout pr523
From 7a1fb530c6b47abb5ebfdb79f53bcf662956066b Mon Sep 17 00:00:00 2001
From: Lukas Slebodnik <lsleb...@redhat.com>
Date: Fri, 23 Feb 2018 19:54:19 +0100
Subject: [PATCH 1/2] IPA: Drop unused ifdef HAVE_SELINUX_LOGIN_DIR
Macros ALL_SERVICES and selogin_path were conditionally defined
in case of existing selinux login directory at configure time
(defined macro AVE_SELINUX_LOGIN_DIR)
However, these macros were unused for quite a long 2.5 year
and last usage was removed in commit 9c47c8c59b5c9078f342f82367cd0ad7857acef8
"IPA: Use set_seuser instead of writing selinux login file"
---
configure.ac| 1 -
src/external/selinux.m4 | 9 -
src/providers/ipa/ipa_init.c| 2 +-
src/providers/ipa/ipa_selinux.h | 7 ---
4 files changed, 1 insertion(+), 18 deletions(-)
diff --git a/configure.ac b/configure.ac
index fafb73500..69deb811e 100644
--- a/configure.ac
+++ b/configure.ac
@@ -377,7 +377,6 @@ AM_PYTHON2_MODULE([ldap])
if test x$HAVE_SELINUX != x; then
AM_CHECK_SELINUX
-AM_CHECK_SELINUX_LOGIN_DIR
fi
if test x$HAVE_SEMANAGE != x -a x$HAVE_SELINUX != x; then
diff --git a/src/external/selinux.m4 b/src/external/selinux.m4
index 1f41b3128..d1b961a49 100644
--- a/src/external/selinux.m4
+++ b/src/external/selinux.m4
@@ -23,12 +23,3 @@ AC_DEFUN([AM_CHECK_SEMANAGE],
[AC_MSG_ERROR([libsemanage is missing])])
AC_SUBST(SEMANAGE_LIBS)
])
-
-dnl Check if the SELinux login directory exists
-AC_DEFUN([AM_CHECK_SELINUX_LOGIN_DIR],
-[
- AC_CHECK_FILE(/etc/selinux/targeted/logins/,
-[AC_DEFINE([HAVE_SELINUX_LOGIN_DIR], [1],
- [The directory to store SELinux user login is available])],
-[AC_MSG_WARN([SELinux login directory is not available])])
-])
diff --git a/src/providers/ipa/ipa_init.c b/src/providers/ipa/ipa_init.c
index 3edab59bb..cdf58b322 100644
--- a/src/providers/ipa/ipa_init.c
+++ b/src/providers/ipa/ipa_init.c
@@ -853,7 +853,7 @@ errno_t sssm_ipa_selinux_init(TALLOC_CTX *mem_ctx,
void *module_data,
struct dp_method *dp_methods)
{
-#if defined HAVE_SELINUX && defined HAVE_SELINUX_LOGIN_DIR
+#if defined HAVE_SELINUX
struct ipa_selinux_ctx *selinux_ctx;
struct ipa_init_ctx *init_ctx;
struct ipa_options *opts;
diff --git a/src/providers/ipa/ipa_selinux.h b/src/providers/ipa/ipa_selinux.h
index 65ca037ee..dea87759e 100644
--- a/src/providers/ipa/ipa_selinux.h
+++ b/src/providers/ipa/ipa_selinux.h
@@ -27,13 +27,6 @@
#include "providers/ldap/ldap_common.h"
-#ifdef HAVE_SELINUX_LOGIN_DIR
-
-#define ALL_SERVICES "*"
-#define selogin_path(mem_ctx, username) \
-talloc_asprintf(mem_ctx, "%s/logins/%s", selinux_policy_root(), username)
-#endif /* HAVE_SELINUX_LOGIN_DIR */
-
struct ipa_selinux_ctx {
struct ipa_id_ctx *id_ctx;
time_t last_update;
From 23c34fcdb5ac10737492d83d0877337012cc3beb Mon Sep 17 00:00:00 2001
From: Lukas Slebodnik <lsleb...@redhat.com>
Date: Mon, 26 Feb 2018 13:04:01 +0100
Subject: [PATCH 2/2] IPA: Fix typo in debug message in sssm_ipa_selinux_init
It was probably a copy mistake.
---
src/providers/ipa/ipa_init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/providers/ipa/ipa_init.c b/src/providers/ipa/ipa_init.c
index cdf58b322..cd2227896 100644
--- a/src/providers/ipa/ipa_init.c
+++ b/src/providers/ipa/ipa_init.c
@@ -879,7 +879,7 @@ errno_t sssm_ipa_selinux_init(TALLOC_CTX *mem_ctx,
return EOK;
#else
DEBUG(SSSDBG_MINOR_FAILURE, "SELinux init handler called but SSSD is "
-"built without SSH support, ignoring\n");
+"built without SELinux support, ignoring\n");
return EOK;
#endif
}
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#523][comment] IPA: Drop unused ifdef HAVE_SELINUX_LOGIN_DIR
URL: https://github.com/SSSD/sssd/pull/523 Title: #523: IPA: Drop unused ifdef HAVE_SELINUX_LOGIN_DIR lslebodn commented: """ On (26/02/18 11:30), Pavel Březina wrote: >When touching `sssm_ipa_selinux_init` can you also fix this typo: Sure. Nice catch. """ See the full comment at https://github.com/SSSD/sssd/pull/523#issuecomment-368478726 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#523][opened] IPA: Drop unused ifdef HAVE_SELINUX_LOGIN_DIR
URL: https://github.com/SSSD/sssd/pull/523
Author: lslebodn
Title: #523: IPA: Drop unused ifdef HAVE_SELINUX_LOGIN_DIR
Action: opened
PR body:
"""
Macros ALL_SERVICES and selogin_path were conditionally defined
in case of existing selinux login directory at configure time
(defined macro AVE_SELINUX_LOGIN_DIR)
However, these macros were unused for quite a long 2.5 year
and last usage was removed in commit 9c47c8c59b5c9078f342f82367cd0ad7857acef8
"IPA: Use set_seuser instead of writing selinux login file"
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/523/head:pr523
git checkout pr523
From 7a1fb530c6b47abb5ebfdb79f53bcf662956066b Mon Sep 17 00:00:00 2001
From: Lukas Slebodnik <lsleb...@redhat.com>
Date: Fri, 23 Feb 2018 19:54:19 +0100
Subject: [PATCH] IPA: Drop unused ifdef HAVE_SELINUX_LOGIN_DIR
Macros ALL_SERVICES and selogin_path were conditionally defined
in case of existing selinux login directory at configure time
(defined macro AVE_SELINUX_LOGIN_DIR)
However, these macros were unused for quite a long 2.5 year
and last usage was removed in commit 9c47c8c59b5c9078f342f82367cd0ad7857acef8
"IPA: Use set_seuser instead of writing selinux login file"
---
configure.ac| 1 -
src/external/selinux.m4 | 9 -
src/providers/ipa/ipa_init.c| 2 +-
src/providers/ipa/ipa_selinux.h | 7 ---
4 files changed, 1 insertion(+), 18 deletions(-)
diff --git a/configure.ac b/configure.ac
index fafb73500..69deb811e 100644
--- a/configure.ac
+++ b/configure.ac
@@ -377,7 +377,6 @@ AM_PYTHON2_MODULE([ldap])
if test x$HAVE_SELINUX != x; then
AM_CHECK_SELINUX
-AM_CHECK_SELINUX_LOGIN_DIR
fi
if test x$HAVE_SEMANAGE != x -a x$HAVE_SELINUX != x; then
diff --git a/src/external/selinux.m4 b/src/external/selinux.m4
index 1f41b3128..d1b961a49 100644
--- a/src/external/selinux.m4
+++ b/src/external/selinux.m4
@@ -23,12 +23,3 @@ AC_DEFUN([AM_CHECK_SEMANAGE],
[AC_MSG_ERROR([libsemanage is missing])])
AC_SUBST(SEMANAGE_LIBS)
])
-
-dnl Check if the SELinux login directory exists
-AC_DEFUN([AM_CHECK_SELINUX_LOGIN_DIR],
-[
- AC_CHECK_FILE(/etc/selinux/targeted/logins/,
-[AC_DEFINE([HAVE_SELINUX_LOGIN_DIR], [1],
- [The directory to store SELinux user login is available])],
-[AC_MSG_WARN([SELinux login directory is not available])])
-])
diff --git a/src/providers/ipa/ipa_init.c b/src/providers/ipa/ipa_init.c
index 3edab59bb..cdf58b322 100644
--- a/src/providers/ipa/ipa_init.c
+++ b/src/providers/ipa/ipa_init.c
@@ -853,7 +853,7 @@ errno_t sssm_ipa_selinux_init(TALLOC_CTX *mem_ctx,
void *module_data,
struct dp_method *dp_methods)
{
-#if defined HAVE_SELINUX && defined HAVE_SELINUX_LOGIN_DIR
+#if defined HAVE_SELINUX
struct ipa_selinux_ctx *selinux_ctx;
struct ipa_init_ctx *init_ctx;
struct ipa_options *opts;
diff --git a/src/providers/ipa/ipa_selinux.h b/src/providers/ipa/ipa_selinux.h
index 65ca037ee..dea87759e 100644
--- a/src/providers/ipa/ipa_selinux.h
+++ b/src/providers/ipa/ipa_selinux.h
@@ -27,13 +27,6 @@
#include "providers/ldap/ldap_common.h"
-#ifdef HAVE_SELINUX_LOGIN_DIR
-
-#define ALL_SERVICES "*"
-#define selogin_path(mem_ctx, username) \
-talloc_asprintf(mem_ctx, "%s/logins/%s", selinux_policy_root(), username)
-#endif /* HAVE_SELINUX_LOGIN_DIR */
-
struct ipa_selinux_ctx {
struct ipa_id_ctx *id_ctx;
time_t last_update;
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#391][comment] Use dbus-daemon in cwrap enviroment for test
URL: https://github.com/SSSD/sssd/pull/391 Title: #391: Use dbus-daemon in cwrap enviroment for test lslebodn commented: """ master: * 0df79781d78973e5462dbef1e89d8fd6001da05c * e64696e1fab85c42aaeda65ddf49ee1b7e3f07e1 * 52ae4eeba9c97c0254a2025ec3b5ffe90588b775 * 841bcb5e1f66bb9c41e1884a2ab1dae654def13e * 3b0356f3bd82e78dffd38ebdc206b555d00dde2f """ See the full comment at https://github.com/SSSD/sssd/pull/391#issuecomment-368085218 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#391][+Pushed] Use dbus-daemon in cwrap enviroment for test
URL: https://github.com/SSSD/sssd/pull/391 Title: #391: Use dbus-daemon in cwrap enviroment for test Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#391][closed] Use dbus-daemon in cwrap enviroment for test
URL: https://github.com/SSSD/sssd/pull/391 Author: lslebodn Title: #391: Use dbus-daemon in cwrap enviroment for test Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/391/head:pr391 git checkout pr391 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#391][comment] Use dbus-daemon in cwrap enviroment for test
URL: https://github.com/SSSD/sssd/pull/391 Title: #391: Use dbus-daemon in cwrap enviroment for test lslebodn commented: """ >I'm sorry I didn't see there was already ack by pbrezina and then the patches >only had a trivial change. No need to apologize. We are all busy and sometimes happen there is a PR pending review for some time. I am quite patience. And the most important is that we finally increased code coverage in upstream and extended possibilities in cwrap integration tests. >Nonetheless, the patches look good and I've only started CI to see if all >distros pass before pushing. Thank you. """ See the full comment at https://github.com/SSSD/sssd/pull/391#issuecomment-367961830 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#514][+Pushed] Backport several UPN related patches to sssd-1-13
URL: https://github.com/SSSD/sssd/pull/514 Title: #514: Backport several UPN related patches to sssd-1-13 Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#514][comment] Backport several UPN related patches to sssd-1-13
URL: https://github.com/SSSD/sssd/pull/514 Title: #514: Backport several UPN related patches to sssd-1-13 lslebodn commented: """ sssd-1-13: * 99afca8926fb211774de457e750dea27da8ac3a9 * 42dbd7ee691ffef8b136fc310128aadfd91fd70c * f6afb6f9418735bcfd125eb2bb2ffeeb5cc07d99 """ See the full comment at https://github.com/SSSD/sssd/pull/514#issuecomment-367949323 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#514][closed] Backport several UPN related patches to sssd-1-13
URL: https://github.com/SSSD/sssd/pull/514 Author: jhrozek Title: #514: Backport several UPN related patches to sssd-1-13 Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/514/head:pr514 git checkout pr514 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#514][comment] Backport several UPN related patches to sssd-1-13
URL: https://github.com/SSSD/sssd/pull/514 Title: #514: Backport several UPN related patches to sssd-1-13 lslebodn commented: """ Thank you very much for additional info in commit messages. ACK """ See the full comment at https://github.com/SSSD/sssd/pull/514#issuecomment-367948868 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#513][+Pushed] SPEC: Reduce changes between upstream and downstream
URL: https://github.com/SSSD/sssd/pull/513 Title: #513: SPEC: Reduce changes between upstream and downstream Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#513][comment] SPEC: Reduce changes between upstream and downstream
URL: https://github.com/SSSD/sssd/pull/513 Title: #513: SPEC: Reduce changes between upstream and downstream lslebodn commented: """ master: * 65afba536e4535b1381ae5468edb16b3c9b89578 """ See the full comment at https://github.com/SSSD/sssd/pull/513#issuecomment-367799871 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#513][closed] SPEC: Reduce changes between upstream and downstream
URL: https://github.com/SSSD/sssd/pull/513 Author: lslebodn Title: #513: SPEC: Reduce changes between upstream and downstream Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/513/head:pr513 git checkout pr513 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#509][closed] SPEC: Fix systemd executions/requirements
URL: https://github.com/SSSD/sssd/pull/509 Author: lslebodn Title: #509: SPEC: Fix systemd executions/requirements Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/509/head:pr509 git checkout pr509 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#509][comment] SPEC: Fix systemd executions/requirements
URL: https://github.com/SSSD/sssd/pull/509 Title: #509: SPEC: Fix systemd executions/requirements lslebodn commented: """ master: * 274ee2952fcb521222fe1eb86331c6dab505dc3a """ See the full comment at https://github.com/SSSD/sssd/pull/509#issuecomment-367754826 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#509][+Pushed] SPEC: Fix systemd executions/requirements
URL: https://github.com/SSSD/sssd/pull/509 Title: #509: SPEC: Fix systemd executions/requirements Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#428][+Pushed] CI: Ignore source file generated by systemtap in coverage
URL: https://github.com/SSSD/sssd/pull/428 Title: #428: CI: Ignore source file generated by systemtap in coverage Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#442][+Pushed] LDAP: Improve error treatment from sdap_cli_connect() in ldap_auth
URL: https://github.com/SSSD/sssd/pull/442 Title: #442: LDAP: Improve error treatment from sdap_cli_connect() in ldap_auth Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#496][+Pushed] sysdb: sanitize search filter input - backport sssd-1-13
URL: https://github.com/SSSD/sssd/pull/496 Title: #496: sysdb: sanitize search filter input - backport sssd-1-13 Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#496][closed] sysdb: sanitize search filter input - backport sssd-1-13
URL: https://github.com/SSSD/sssd/pull/496 Author: sumit-bose Title: #496: sysdb: sanitize search filter input - backport sssd-1-13 Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/496/head:pr496 git checkout pr496 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#496][comment] sysdb: sanitize search filter input - backport sssd-1-13
URL: https://github.com/SSSD/sssd/pull/496 Title: #496: sysdb: sanitize search filter input - backport sssd-1-13 lslebodn commented: """ master: * 3cf0aa1904fe791eed414bfb532c91a79ea2df9c * 0c0b9a3323dfc7988a58d4b67e9c94d0567ee82c * 76b79f5a816152d5aa07618b7825fb4926d15f1e * 0a539e693254275248ff5756e2e35a9a8f991bb0 * 50841c025e20e7619ca342739e9beaa9dfb85f1c * 853ab167b05b61e3e174b575fbe2fc81abe24f02 """ See the full comment at https://github.com/SSSD/sssd/pull/496#issuecomment-367682774 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#516][+Pushed] DESKPROFILE: Document it doesn't work when run as unprivileged user
URL: https://github.com/SSSD/sssd/pull/516 Title: #516: DESKPROFILE: Document it doesn't work when run as unprivileged user Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#516][closed] DESKPROFILE: Document it doesn't work when run as unprivileged user
URL: https://github.com/SSSD/sssd/pull/516 Author: fidencio Title: #516: DESKPROFILE: Document it doesn't work when run as unprivileged user Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/516/head:pr516 git checkout pr516 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#516][comment] DESKPROFILE: Document it doesn't work when run as unprivileged user
URL: https://github.com/SSSD/sssd/pull/516 Title: #516: DESKPROFILE: Document it doesn't work when run as unprivileged user lslebodn commented: """ master: * 5150fbdc429ee9ed52e80e5f133ddb48c5b79914 """ See the full comment at https://github.com/SSSD/sssd/pull/516#issuecomment-367678121 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#521][+Pushed] Avoid double semicolon warnings on older compilers
URL: https://github.com/SSSD/sssd/pull/521 Title: #521: Avoid double semicolon warnings on older compilers Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#521][comment] Avoid double semicolon warnings on older compilers
URL: https://github.com/SSSD/sssd/pull/521 Title: #521: Avoid double semicolon warnings on older compilers lslebodn commented: """ comment would not work; because it would bot be expanded by macro. ACK++ """ See the full comment at https://github.com/SSSD/sssd/pull/521#issuecomment-367676908 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#521][closed] Avoid double semicolon warnings on older compilers
URL: https://github.com/SSSD/sssd/pull/521 Author: cryptomilk Title: #521: Avoid double semicolon warnings on older compilers Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/521/head:pr521 git checkout pr521 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#521][comment] Avoid double semicolon warnings on older compilers
URL: https://github.com/SSSD/sssd/pull/521 Title: #521: Avoid double semicolon warnings on older compilers lslebodn commented: """ master: * 1ef36a878ac0f55c97e4d1c5597ac9cc1a52613a """ See the full comment at https://github.com/SSSD/sssd/pull/521#issuecomment-367676950 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#496][comment] sysdb: sanitize search filter input - backport sssd-1-13
URL: https://github.com/SSSD/sssd/pull/496 Title: #496: sysdb: sanitize search filter input - backport sssd-1-13 lslebodn commented: """ LGTM :-) I'll wait with pushing till after successful run in centos ci """ See the full comment at https://github.com/SSSD/sssd/pull/496#issuecomment-367662551 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#521][comment] Avoid double semicolon warnings on older compilers
URL: https://github.com/SSSD/sssd/pull/521 Title: #521: Avoid double semicolon warnings on older compilers lslebodn commented: """ Andreas created PR also on pagure and added comment there https://pagure.io/SSSD/sssd/pull-request/3645 Adding also here ``` - sss_cv_attribute_fallthrough_val= + sss_cv_attribute_fallthrough_val="((void)0)" maybe we could expand that to comment which is recognized by linters, static analyzers. e.g. "/ fallthrough /" I didn't test that because I already have gcc8 on my machine :- ``` """ See the full comment at https://github.com/SSSD/sssd/pull/521#issuecomment-367662168 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#496][comment] sysdb: sanitize search filter input - backport sssd-1-13
URL: https://github.com/SSSD/sssd/pull/496 Title: #496: sysdb: sanitize search filter input - backport sssd-1-13 lslebodn commented: """ > Do you think that for completeness and easier reference it would be ok if I > push your patches to this PR and the 1.14 ones to PR#497? Feel free to push them here. 1.14 are already in upstream https://github.com/SSSD/sssd/pull/497#issuecomment-367430480 """ See the full comment at https://github.com/SSSD/sssd/pull/496#issuecomment-367661163 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#497][+Pushed] sysdb: sanitize search filter input - backport sssd-1-14
URL: https://github.com/SSSD/sssd/pull/497 Title: #497: sysdb: sanitize search filter input - backport sssd-1-14 Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#516][-Accepted] DESKPROFILE: Document it doesn't work when run as unprivileged user
URL: https://github.com/SSSD/sssd/pull/516 Title: #516: DESKPROFILE: Document it doesn't work when run as unprivileged user Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#516][comment] DESKPROFILE: Document it doesn't work when run as unprivileged user
URL: https://github.com/SSSD/sssd/pull/516 Title: #516: DESKPROFILE: Document it doesn't work when run as unprivileged user lslebodn commented: """ Justin, thank you for review """ See the full comment at https://github.com/SSSD/sssd/pull/516#issuecomment-367457190 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#516][comment] DESKPROFILE: Document it doesn't work when run as unprivileged user
URL: https://github.com/SSSD/sssd/pull/516 Title: #516: DESKPROFILE: Document it doesn't work when run as unprivileged user lslebodn commented: """ I tried to figure out why centos CI is failing and I noticed that xml element `note` is not allowed in DTD ``` /usr/bin/xmllint --catalogs --postvalid --nonet --noent --xinclude --noout ../../../sssd/src/man/sssd.conf.5.xml ../../../sssd/src/man/sssd.conf.5.xml:2464: element note: validity error : Element note content does not follow the DTD, expecting (title? , (calloutlist | glosslist | bibliolist | itemizedlist | orderedlist | segmentedlist | simplelist | variablelist | literallayout | programlisting | programlistingco | screen | screenco | screenshot | synopsis | cmdsynopsis | funcsynopsis | classsynopsis | fieldsynopsis | constructorsynopsis | destructorsynopsis | methodsynopsis | formalpara | para | simpara | address | blockquote | graphic | graphicco | mediaobject | mediaobjectco | informalequation | informalexample | informalfigure | informaltable | equation | example | figure | table | procedure | sidebar | anchor | bridgehead | remark | indexterm | beginpage)+), got (CDATA) Document ../../../sssd/src/man/sssd.conf.5.xml does not validate make[2]: *** [Makefile:938: sssd.conf.5] Error 3 ``` I can see that on other places in sssd.conf.5.xml we use either ``` NOTE: Sudo rules are ``` or NOTE without emphasis ``` NOTE: The filter_groups option doesn't affect ``` I'm sorry that I did not notice that earlier. """ See the full comment at https://github.com/SSSD/sssd/pull/516#issuecomment-367459699 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#496][-Changes requested] sysdb: sanitize search filter input - backport sssd-1-13
URL: https://github.com/SSSD/sssd/pull/496 Title: #496: sysdb: sanitize search filter input - backport sssd-1-13 Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#516][+Changes requested] DESKPROFILE: Document it doesn't work when run as unprivileged user
URL: https://github.com/SSSD/sssd/pull/516 Title: #516: DESKPROFILE: Document it doesn't work when run as unprivileged user Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#496][comment] sysdb: sanitize search filter input - backport sssd-1-13
URL: https://github.com/SSSD/sssd/pull/496 Title: #496: sysdb: sanitize search filter input - backport sssd-1-13 lslebodn commented: """ And here are patches for 1.13 https://github.com/lslebodn/sssd/tree/cve_backport_1.13 @sumit-bose could you check them? """ See the full comment at https://github.com/SSSD/sssd/pull/496#issuecomment-367446142 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#497][closed] sysdb: sanitize search filter input - backport sssd-1-14
URL: https://github.com/SSSD/sssd/pull/497 Author: sumit-bose Title: #497: sysdb: sanitize search filter input - backport sssd-1-14 Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/497/head:pr497 git checkout pr497 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#497][comment] sysdb: sanitize search filter input - backport sssd-1-14
URL: https://github.com/SSSD/sssd/pull/497 Title: #497: sysdb: sanitize search filter input - backport sssd-1-14 lslebodn commented: """ sssd-1-14: * e45e50e4523e36f310d7ff0b052500c024c434bf * e358dd7b4992da4c4aa7b7f769bd597222715127 * 353853d479225ba7a625658e58a3af989de909a5 * 4814454b846cbe9682e0bbcfcf9e0fe98b5181f3 * 64ef6ab9a432d6fdd231d5f96887ecabeb2fc39e * f84055ee1c4ad60219e5d9b2ea5cc4dd6e1112eb """ See the full comment at https://github.com/SSSD/sssd/pull/497#issuecomment-367430480 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#497][comment] sysdb: sanitize search filter input - backport sssd-1-14
URL: https://github.com/SSSD/sssd/pull/497 Title: #497: sysdb: sanitize search filter input - backport sssd-1-14 lslebodn commented: """ >@lslebodn, thank you for backporting. The selected patches are looking good. Thank you for checking. I'll push patches + create backport for 1.13 > Can you add a comment to the related UPN PRs about afadeb1? done """ See the full comment at https://github.com/SSSD/sssd/pull/497#issuecomment-367377809 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#514][comment] Backport several UPN related patches to sssd-1-13
URL: https://github.com/SSSD/sssd/pull/514 Title: #514: Backport several UPN related patches to sssd-1-13 lslebodn commented: """ As part of backporting patches for sanitizing sysdb filters, we found out that we might consider backporting also afadeb1a530ff010a2f9a7552562576b843c874b. You might need to wait for CVE backport to avoid conflicts """ See the full comment at https://github.com/SSSD/sssd/pull/514#issuecomment-367377399 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#497][comment] sysdb: sanitize search filter input - backport sssd-1-14
URL: https://github.com/SSSD/sssd/pull/497 Title: #497: sysdb: sanitize search filter input - backport sssd-1-14 lslebodn commented: """ I know we started discussion as part of #496 but I firstly backported patches + sysdb unit tests to 1.14 branch. https://github.com/lslebodn/sssd/tree/cve_backport_1.14 Related sysdb functions are almost the same as in master branch. I did not include afadeb1a530ff010a2f9a7552562576b843c874b into 1.14 because it is not related to CVE fix. But we were backporting UPN fixes to 1.13 so we might backport that commit in different PR And there is also missing ba926c98b7ae605077a09ba7135e05257de62a0f because it was related to multiple results for searches by certificate which is only in 1.15 as a feature. @sumit-bose Could you check PR before I'll backport patches to 1.13? """ See the full comment at https://github.com/SSSD/sssd/pull/497#issuecomment-367340136 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#516][comment] DESKPROFILE: Document it doesn't work when run as unprivileged user
URL: https://github.com/SSSD/sssd/pull/516 Title: #516: DESKPROFILE: Document it doesn't work when run as unprivileged user lslebodn commented: """ LGTM from content point of view. @justin-stephenson could you check this PR as well? """ See the full comment at https://github.com/SSSD/sssd/pull/516#issuecomment-367288934 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#488][comment] Two fixes for certificates in idoverrides
URL: https://github.com/SSSD/sssd/pull/488 Title: #488: Two fixes for certificates in idoverrides lslebodn commented: """ This PR is also required for stable branch (1.13) #494. Please do not forget to push it also to older branches after pushing to master """ See the full comment at https://github.com/SSSD/sssd/pull/488#issuecomment-367286098 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#494][+Pushed] Backport support for certificates in idoverrides to sssd-1.13
URL: https://github.com/SSSD/sssd/pull/494 Title: #494: Backport support for certificates in idoverrides to sssd-1.13 Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#494][closed] Backport support for certificates in idoverrides to sssd-1.13
URL: https://github.com/SSSD/sssd/pull/494 Author: sumit-bose Title: #494: Backport support for certificates in idoverrides to sssd-1.13 Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/494/head:pr494 git checkout pr494 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#494][comment] Backport support for certificates in idoverrides to sssd-1.13
URL: https://github.com/SSSD/sssd/pull/494 Title: #494: Backport support for certificates in idoverrides to sssd-1.13 lslebodn commented: """ sssd-1-13: * 9d1397219374531e7f2a3188ea6aa9f86ca35f9e * 81f9af96065eb94ed0a9e6ef2b759761406b4b81 * f13505ce5632822e093982ca3bbf94f327d59a34 * ae124b2a2f93942d87c615703cde10b2fa39c258 * 2b527257a6d80648671a309e003a88b1cf482eae * 35f9936d892fe0bda51ebc1db3c1a47e7d1a495f * 377786542b19ad4227f7447a0995ac5be8bf4a54 * b7f2686bde219ae2ddd9398901a4b3e9cdde2ab1 * 28fbcec499b12d3032590182adf8b09a60f518f1 * e2d9254cf24be128f8593b5629a6ed3ad95bc4e6 * 95b7cee1fb67b4f2da4c5a8345ccfbb0a2de8755 * aec447a206a34909a0becd6098d12b268270a4c3 """ See the full comment at https://github.com/SSSD/sssd/pull/494#issuecomment-367285119 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#494][comment] Backport support for certificates in idoverrides to sssd-1.13
URL: https://github.com/SSSD/sssd/pull/494 Title: #494: Backport support for certificates in idoverrides to sssd-1.13 lslebodn commented: """ > I added '(cherry picked from ...)' to the commit messages with a hint if > fixes where needed or not. thank you and ACK >Only the last patch does not have this because it isn't in master yet but >under review in #488. It would be good to good to have #488 in master. I'll add comment to that PR that patch is also required for 1.13 branch """ See the full comment at https://github.com/SSSD/sssd/pull/494#issuecomment-367281949 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#520][+Pushed] DESKPROFILE: Fix 'Improper use of negative value'
URL: https://github.com/SSSD/sssd/pull/520 Title: #520: DESKPROFILE: Fix 'Improper use of negative value' Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#520][closed] DESKPROFILE: Fix 'Improper use of negative value'
URL: https://github.com/SSSD/sssd/pull/520 Author: sumit-bose Title: #520: DESKPROFILE: Fix 'Improper use of negative value' Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/520/head:pr520 git checkout pr520 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#520][comment] DESKPROFILE: Fix 'Improper use of negative value'
URL: https://github.com/SSSD/sssd/pull/520 Title: #520: DESKPROFILE: Fix 'Improper use of negative value' lslebodn commented: """ master: * 0633e97cfd6a696c19e19219e3de1cda7c7ee7b4 """ See the full comment at https://github.com/SSSD/sssd/pull/520#issuecomment-366987695 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#517][comment] Fix two memory leaks in the AD provider
URL: https://github.com/SSSD/sssd/pull/517 Title: #517: Fix two memory leaks in the AD provider lslebodn commented: """ retest this please """ See the full comment at https://github.com/SSSD/sssd/pull/517#issuecomment-366440086 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#515][comment] sssctl: Showing help even when sssd not configured
URL: https://github.com/SSSD/sssd/pull/515 Title: #515: sssctl: Showing help even when sssd not configured lslebodn commented: """ retest this please """ See the full comment at https://github.com/SSSD/sssd/pull/515#issuecomment-366440039 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#516][+Changes requested] DESKPROFILE: Document it doesn't work when run as unprivileged user
URL: https://github.com/SSSD/sssd/pull/516 Title: #516: DESKPROFILE: Document it doesn't work when run as unprivileged user Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#435][comment] krb5: call krb5_auth_cache_creds() if a pssword is available
URL: https://github.com/SSSD/sssd/pull/435 Title: #435: krb5: call krb5_auth_cache_creds() if a pssword is available lslebodn commented: """ master: * a87658e5382a6ad119058d22b118a29eaae7a365 sssd-1-14: * 3546e6c0be2f85c9e1828237000a376a188e43ac sssd-1-13: * 6b900667cd1541809dbaaf9603f7e7785e6f78f9 """ See the full comment at https://github.com/SSSD/sssd/pull/435#issuecomment-366344661 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#435][closed] krb5: call krb5_auth_cache_creds() if a pssword is available
URL: https://github.com/SSSD/sssd/pull/435 Author: sumit-bose Title: #435: krb5: call krb5_auth_cache_creds() if a pssword is available Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/435/head:pr435 git checkout pr435 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#435][+Pushed] krb5: call krb5_auth_cache_creds() if a pssword is available
URL: https://github.com/SSSD/sssd/pull/435 Title: #435: krb5: call krb5_auth_cache_creds() if a pssword is available Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#435][+Accepted] krb5: call krb5_auth_cache_creds() if a pssword is available
URL: https://github.com/SSSD/sssd/pull/435 Title: #435: krb5: call krb5_auth_cache_creds() if a pssword is available Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#435][comment] krb5: call krb5_auth_cache_creds() if a pssword is available
URL: https://github.com/SSSD/sssd/pull/435 Title: #435: krb5: call krb5_auth_cache_creds() if a pssword is available lslebodn commented: """ Sanity test with krb5/ad/ipa passed ACK """ See the full comment at https://github.com/SSSD/sssd/pull/435#issuecomment-366290486 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#518][+Pushed] PYSSS_MURMUR: Fix [-Wsign-compare] found by gcc
URL: https://github.com/SSSD/sssd/pull/518 Title: #518: PYSSS_MURMUR: Fix [-Wsign-compare] found by gcc Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#518][closed] PYSSS_MURMUR: Fix [-Wsign-compare] found by gcc
URL: https://github.com/SSSD/sssd/pull/518 Author: fidencio Title: #518: PYSSS_MURMUR: Fix [-Wsign-compare] found by gcc Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/518/head:pr518 git checkout pr518 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#518][comment] PYSSS_MURMUR: Fix [-Wsign-compare] found by gcc
URL: https://github.com/SSSD/sssd/pull/518 Title: #518: PYSSS_MURMUR: Fix [-Wsign-compare] found by gcc lslebodn commented: """ master: * 1c42c3962577ea4b2d9ed6a8a07179d33756b3b4 """ See the full comment at https://github.com/SSSD/sssd/pull/518#issuecomment-366244837 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#518][+Accepted] PYSSS_MURMUR: Fix [-Wsign-compare] found by gcc
URL: https://github.com/SSSD/sssd/pull/518 Title: #518: PYSSS_MURMUR: Fix [-Wsign-compare] found by gcc Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#518][comment] PYSSS_MURMUR: Fix [-Wsign-compare] found by gcc
URL: https://github.com/SSSD/sssd/pull/518 Title: #518: PYSSS_MURMUR: Fix [-Wsign-compare] found by gcc lslebodn commented: """ ACK """ See the full comment at https://github.com/SSSD/sssd/pull/518#issuecomment-366244091 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#503][closed] Regression test for false possitive "corrupted" memory cache
URL: https://github.com/SSSD/sssd/pull/503 Author: lslebodn Title: #503: Regression test for false possitive "corrupted" memory cache Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/503/head:pr503 git checkout pr503 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#503][+Pushed] Regression test for false possitive "corrupted" memory cache
URL: https://github.com/SSSD/sssd/pull/503 Title: #503: Regression test for false possitive "corrupted" memory cache Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#503][comment] Regression test for false possitive "corrupted" memory cache
URL: https://github.com/SSSD/sssd/pull/503 Title: #503: Regression test for false possitive "corrupted" memory cache lslebodn commented: """ master: * 6dc1de9781ab211a43d24cbaed7969d98abc1cc1 * fd17e0925dbcafedb878ddf828a37743c115c9dd * 8f83feea4586a8fcf4365e0d22e0a16740424cc2 * 41454a64c714e984423fd6e94ea89d183a73cc67 """ See the full comment at https://github.com/SSSD/sssd/pull/503#issuecomment-365956707 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#503][comment] Regression test for false possitive "corrupted" memory cache
URL: https://github.com/SSSD/sssd/pull/503 Title: #503: Regression test for false possitive "corrupted" memory cache lslebodn commented: """ Thank you for review. """ See the full comment at https://github.com/SSSD/sssd/pull/503#issuecomment-365956635 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#435][comment] krb5: call krb5_auth_cache_creds() if a pssword is available
URL: https://github.com/SSSD/sssd/pull/435 Title: #435: krb5: call krb5_auth_cache_creds() if a pssword is available lslebodn commented: """ Thank you for update. I'll run some krb5 tests for sanity checking. So far LGTM """ See the full comment at https://github.com/SSSD/sssd/pull/435#issuecomment-365919656 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#435][-Changes requested] krb5: call krb5_auth_cache_creds() if a pssword is available
URL: https://github.com/SSSD/sssd/pull/435 Title: #435: krb5: call krb5_auth_cache_creds() if a pssword is available Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#515][-Changes requested] sssctl: Showing help even when sssd not configured
URL: https://github.com/SSSD/sssd/pull/515 Title: #515: sssctl: Showing help even when sssd not configured Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#515][comment] sssctl: Showing help even when sssd not configured
URL: https://github.com/SSSD/sssd/pull/515 Title: #515: sssctl: Showing help even when sssd not configured lslebodn commented: """ ok to test """ See the full comment at https://github.com/SSSD/sssd/pull/515#issuecomment-365909737 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#391][comment] Use dbus-daemon in cwrap enviroment for test
URL: https://github.com/SSSD/sssd/pull/391 Title: #391: Use dbus-daemon in cwrap enviroment for test lslebodn commented: """ retest this please """ See the full comment at https://github.com/SSSD/sssd/pull/391#issuecomment-365858862 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#494][+Changes requested] Backport support for certificates in idoverrides to sssd-1.13
URL: https://github.com/SSSD/sssd/pull/494 Title: #494: Backport support for certificates in idoverrides to sssd-1.13 Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#494][comment] Backport support for certificates in idoverrides to sssd-1.13
URL: https://github.com/SSSD/sssd/pull/494 Title: #494: Backport support for certificates in idoverrides to sssd-1.13 lslebodn commented: """ I assume you at least partially used cherry-pick + fixing conflicts due to sysdb changes. It would be good to mention hash of original ticket in commit message (git cherry-pick -x) Or in other case, it would be good to mention in commit message that was written from scratch and maybe that it is "similar" to some hash in master. """ See the full comment at https://github.com/SSSD/sssd/pull/494#issuecomment-365858187 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#515][+Changes requested] sssctl: Showing help even when sssd not configured
URL: https://github.com/SSSD/sssd/pull/515 Title: #515: sssctl: Showing help even when sssd not configured Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#514][+Changes requested] Backport several UPN related patches to sssd-1-13
URL: https://github.com/SSSD/sssd/pull/514 Title: #514: Backport several UPN related patches to sssd-1-13 Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#514][comment] Backport several UPN related patches to sssd-1-13
URL: https://github.com/SSSD/sssd/pull/514 Title: #514: Backport several UPN related patches to sssd-1-13 lslebodn commented: """ The commits "Fix iterating to next domain for initgroup lookups" and "Make get_object_from_cache() aware of UPN searches" does not have any info about commits in other/newer branches. Were they written from scratch? or you just forgot to mention that in commit message. If it is just a subset of change from bigger patch in master then it would still be good to mention that in commit message. (or at least ticket partially fix that in master) """ See the full comment at https://github.com/SSSD/sssd/pull/514#issuecomment-365856535 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#435][+Changes requested] krb5: call krb5_auth_cache_creds() if a pssword is available
URL: https://github.com/SSSD/sssd/pull/435 Title: #435: krb5: call krb5_auth_cache_creds() if a pssword is available Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#435][comment] krb5: call krb5_auth_cache_creds() if a pssword is available
URL: https://github.com/SSSD/sssd/pull/435 Title: #435: krb5: call krb5_auth_cache_creds() if a pssword is available lslebodn commented: """ @sumit-bose, I would like to apologize for long pending review. I added inline comment. """ See the full comment at https://github.com/SSSD/sssd/pull/435#issuecomment-365854911 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#498][-Pushed] DESKPROFILE: Do not require CAP_DAC_OVERRIDE
URL: https://github.com/SSSD/sssd/pull/498 Title: #498: DESKPROFILE: Do not require CAP_DAC_OVERRIDE Label: -Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#498][comment] DESKPROFILE: Do not require CAP_DAC_OVERRIDE
URL: https://github.com/SSSD/sssd/pull/498 Title: #498: DESKPROFILE: Do not require CAP_DAC_OVERRIDE lslebodn commented: """ Unfortunately, it was pushed without careful review. That would not work when running sssd in non-privileged mode because `seteuid` will fail. And it was mentioned in upstream ticket https://pagure.io/SSSD/sssd/issue/3621 Quick POC ``` sh# su --shell=/bin/bash - sssd sh$ python Python 2.7.14 (default, Jan 31 2018, 14:27:00) [GCC 8.0.1 20180127 (Red Hat 8.0.1-0.6)] on linux2 Type "help", "copyright", "credits" or "license" for more information. >>> import os >>> os.getuid() 974 >>> os.geteuid() 974 >>> os.seteuid(1000) Traceback (most recent call last): File "", line 1, in OSError: [Errno 1] Operation not permitted ``` BTW I ran few basic tests in non-privileged mode and works like a charm with following IPA tests: selinux-usemap, sudo, hbac, user, group, netgroup, password changes, ssh keys, automount. I didn't test ad-trust tests because there is a known issue in non-privileged mode. """ See the full comment at https://github.com/SSSD/sssd/pull/498#issuecomment-365839135 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#498][-Accepted] DESKPROFILE: Do not require CAP_DAC_OVERRIDE
URL: https://github.com/SSSD/sssd/pull/498 Title: #498: DESKPROFILE: Do not require CAP_DAC_OVERRIDE Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#498][reopened] DESKPROFILE: Do not require CAP_DAC_OVERRIDE
URL: https://github.com/SSSD/sssd/pull/498 Author: fidencio Title: #498: DESKPROFILE: Do not require CAP_DAC_OVERRIDE Action: reopened To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/498/head:pr498 git checkout pr498 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
