URL: https://github.com/SSSD/sssd/pull/5863
Title: #5863: Responder and Child process tevent chain id improvements
alexey-tikhonov commented:
"""
Pushed PR: https://github.com/SSSD/sssd/pull/5863
* `master`
* 1110bd59e62dc9a9886612f59eb6358fa53fb0cc - Analyzer: Fail if chain ID
support is
URL: https://github.com/SSSD/sssd/pull/5863
Title: #5863: Responder and Child process tevent chain id improvements
alexey-tikhonov commented:
"""
The same test failed again.
Looks a little bit similar to fails we saw in #5766 (that were fixed by
29f8a795f67db651e95842cddf153975f97d9b3f)
"""
URL: https://github.com/SSSD/sssd/pull/5863
Title: #5863: Responder and Child process tevent chain id improvements
alexey-tikhonov commented:
"""
> > https://s3.eu-central-1.amazonaws.com/sssd-ci/PR-5863/20/fedora33/ci-make-intgcheck.log
>
> Not sure how this was caused by my PR
I also don't
URL: https://github.com/SSSD/sssd/pull/5863
Title: #5863: Responder and Child process tevent chain id improvements
justin-stephenson commented:
"""
> https://s3.eu-central-1.amazonaws.com/sssd-ci/PR-5863/20/fedora33/ci-make-intgcheck.log
Not sure how this was caused by my PR, I'm triggering a
URL: https://github.com/SSSD/sssd/pull/5863
Title: #5863: Responder and Child process tevent chain id improvements
alexey-tikhonov commented:
"""
https://s3.eu-central-1.amazonaws.com/sssd-ci/PR-5863/20/fedora33/ci-make-intgcheck.log
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/5863
Title: #5863: Responder and Child process tevent chain id improvements
justin-stephenson commented:
"""
* Added one final commit (I hope)
https://github.com/SSSD/sssd/pull/5863/commits/8ab51e9dbd3ec7a469f0e38046f2354297e7b7ba
"""
See the full
URL: https://github.com/SSSD/sssd/pull/5863
Title: #5863: Responder and Child process tevent chain id improvements
sumit-bose commented:
"""
Hi,
I agree with @alexey-tikhonov, it is better to just fail hard if chain ID
support is missing.
bye,
Sumit
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/5863
Title: #5863: Responder and Child process tevent chain id improvements
alexey-tikhonov commented:
"""
From my point of view, it's ok to change "will be limited" to "unsupported" and
just quit at this point.
There is really very little we can do
URL: https://github.com/SSSD/sssd/pull/5863
Title: #5863: Responder and Child process tevent chain id improvements
alexey-tikhonov commented:
"""
From my point of view, it's ok to change "will be limited" to "unsupported" and
just quit at this point.
There is really very little we can do
URL: https://github.com/SSSD/sssd/pull/5863
Title: #5863: Responder and Child process tevent chain id improvements
stanislavlevin commented:
"""
@justin-stephenson, I saw the message, thank you.
Since there is no strict requirement on that version of libtevent I assumed the
tool should work in
URL: https://github.com/SSSD/sssd/pull/5863
Title: #5863: Responder and Child process tevent chain id improvements
justin-stephenson commented:
"""
> ```
> [root@master1 /]# sssctl analyze request list -v
> NOTE: Tevent chain ID support missing, request analysis will be limited.
> It is
URL: https://github.com/SSSD/sssd/pull/5863
Title: #5863: Responder and Child process tevent chain id improvements
stanislavlevin commented:
"""
> ```
> [root@master1 /]# sssctl analyze request list -v
> NOTE: Tevent chain ID support missing, request analysis will be limited.
> It is
URL: https://github.com/SSSD/sssd/pull/5863
Title: #5863: Responder and Child process tevent chain id improvements
stanislavlevin commented:
"""
Are there corresponding tests? Can't find them.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/5863#issuecomment-996523962
URL: https://github.com/SSSD/sssd/pull/5863
Title: #5863: Responder and Child process tevent chain id improvements
stanislavlevin commented:
"""
cherry-pick is OK.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/5863#issuecomment-996521088
URL: https://github.com/SSSD/sssd/pull/5863
Title: #5863: Responder and Child process tevent chain id improvements
stanislavlevin commented:
"""
```
[root@master1 /]# sssctl analyze request list -v
NOTE: Tevent chain ID support missing, request analysis will be limited.
It is recommended to use
URL: https://github.com/SSSD/sssd/pull/5863
Title: #5863: Responder and Child process tevent chain id improvements
alexey-tikhonov commented:
"""
@stanislavlevin, are you fine with a cherry-pick and a fix on top?
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/5863
Title: #5863: Responder and Child process tevent chain id improvements
justin-stephenson commented:
"""
Latest push adds the following into this PR, to incorporate changes from PR
5845 and avoid the need to rebase
* Commit from @stanislavlevin in
URL: https://github.com/SSSD/sssd/pull/5863
Title: #5863: Responder and Child process tevent chain id improvements
justin-stephenson commented:
"""
> @justin-stephenson, please rebase.
Done, thank you.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/5863#issuecomment-995837651
URL: https://github.com/SSSD/sssd/pull/5863
Title: #5863: Responder and Child process tevent chain id improvements
alexey-tikhonov commented:
"""
@justin-stephenson, please rebase.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/5863#issuecomment-995785995
URL: https://github.com/SSSD/sssd/pull/5863
Title: #5863: Responder and Child process tevent chain id improvements
sumit-bose commented:
"""
Hi,
thanks for the patch, it is working well in my (quite basic) tests for PAM and
NSS.
I'm afraid I can't remember what we planned for the other
URL: https://github.com/SSSD/sssd/pull/5863
Title: #5863: Responder and Child process tevent chain id improvements
alexey-tikhonov commented:
"""
@sumit-bose, do you agree with the latest changes?
"""
See the full comment at
https://github.com/SSSD/sssd/pull/5863#issuecomment-994741262
URL: https://github.com/SSSD/sssd/pull/5863
Title: #5863: Responder and Child process tevent chain id improvements
justin-stephenson commented:
"""
These changes remove the analyzer `--cachereq'`option and add a new `--child`
option, https://sssd.io/troubleshooting/analyzer.html will need to
URL: https://github.com/SSSD/sssd/pull/5863
Title: #5863: Responder and Child process tevent chain id improvements
justin-stephenson commented:
"""
> > This introduced an issue where `[ldb]` messages are tagged with CID/RID,
> > which makes the log analyzer output quite unfriendly/ugly.
>
>
URL: https://github.com/SSSD/sssd/pull/5863
Title: #5863: Responder and Child process tevent chain id improvements
alexey-tikhonov commented:
"""
> This introduced an issue where `[ldb]` messages are tagged with CID/RID,
> which makes the log analyzer output quite unfriendly/ugly.
But this
URL: https://github.com/SSSD/sssd/pull/5863
Title: #5863: Responder and Child process tevent chain id improvements
alexey-tikhonov commented:
"""
> This introduced an issue where `[ldb]` messages are tagged with CID/RID,
> which makes the log analyzer output quite unfriendly/ugly.
But this
URL: https://github.com/SSSD/sssd/pull/5863
Title: #5863: Responder and Child process tevent chain id improvements
justin-stephenson commented:
"""
Latest push addresses final items requested by Pavel:
* splits a commit for [adding
URL: https://github.com/SSSD/sssd/pull/5863
Title: #5863: Responder and Child process tevent chain id improvements
pbrezina commented:
"""
https://github.com/SSSD/sssd/pull/5863#discussion_r768040888 + split adding
chain id format to its own commit and it is ack from me.
"""
See the full
URL: https://github.com/SSSD/sssd/pull/5863
Title: #5863: Responder and Child process tevent chain id improvements
alexey-tikhonov commented:
"""
Deferred until we have a conclusion what upstream release this targets.
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/5863
Title: #5863: Responder and Child process tevent chain id improvements
sumit-bose commented:
"""
Hi,
thanks, remaining CI issues are not related, ACK.
bye,
Sumit
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/5863
Title: #5863: Responder and Child process tevent chain id improvements
justin-stephenson commented:
"""
>
Thanks, sorry I should have caught this. Fixed now.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/5863#issuecomment-975635466
URL: https://github.com/SSSD/sssd/pull/5863
Title: #5863: Responder and Child process tevent chain id improvements
sumit-bose commented:
"""
Hi,
I'm sorry I didn't pull the latest version when running the tests. Since the
chain_id option is now added unconditionally `test_set_extra_args`
URL: https://github.com/SSSD/sssd/pull/5863
Title: #5863: Responder and Child process tevent chain id improvements
sumit-bose commented:
"""
Hi,
I'm fine with the patches and test are working locally for me. I restarted the
CI task to hopefully get some CI results as well.
bye,
Sumit
"""
URL: https://github.com/SSSD/sssd/pull/5863
Title: #5863: Responder and Child process tevent chain id improvements
alexey-tikhonov commented:
"""
Thank you for updates, @justin-stephenson. In general (besides one open minor
conversation) looks good to me.
@sumit-bose, could please also take a
URL: https://github.com/SSSD/sssd/pull/5863
Title: #5863: Responder and Child process tevent chain id improvements
alexey-tikhonov commented:
"""
Isn't it required to execute `sss_chain_id_setup()` in all child processes?
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/5863
Title: #5863: Responder and Child process tevent chain id improvements
alexey-tikhonov commented:
"""
Isn't it required to execute `sss_chain_id_setup()` in all child processes?
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/5863
Title: #5863: Responder and Child process tevent chain id improvements
justin-stephenson commented:
"""
Now that the chain ID is logged in responder log files, should the analyzer
tool always grep responder log files for `CID#` in `request show`
URL: https://github.com/SSSD/sssd/pull/5863
Title: #5863: Responder and Child process tevent chain id improvements
justin-stephenson commented:
"""
> Isn't it required to set `debug_from_responder` in `p11_child`?
Yes, fixed.
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/5863
Title: #5863: Responder and Child process tevent chain id improvements
justin-stephenson commented:
"""
>
> Hi,
>
> I tend to the latter. The idea of the tool is to help to find issues. Adding
> the child logs by default might make this harder
URL: https://github.com/SSSD/sssd/pull/5863
Title: #5863: Responder and Child process tevent chain id improvements
alexey-tikhonov commented:
"""
Isn't it required to set `debug_from_responder` in `p11_child`?
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/5863
Title: #5863: Responder and Child process tevent chain id improvements
sumit-bose commented:
"""
> Now that the RID # is passed to the child log files, `sssctl analyze request
> show #` will check these child logs and print those RID # matches also.
URL: https://github.com/SSSD/sssd/pull/5863
Title: #5863: Responder and Child process tevent chain id improvements
justin-stephenson commented:
"""
Now that the RID # is passed to the child log files, `sssctl analyze request
show #` will check these child logs and print those RID # matches
URL: https://github.com/SSSD/sssd/pull/5863
Title: #5863: Responder and Child process tevent chain id improvements
alexey-tikhonov commented:
"""
RHBZs:
- https://bugzilla.redhat.com/show_bug.cgi?id=2013259
- https://bugzilla.redhat.com/show_bug.cgi?id=2013260
-
42 matches
Mail list logo
