On (20/12/16 15:02), Victor Tapia wrote:
>Hi Lukas,
>
>Just wanted to confirm your patch works for me.
>
Thank you very much for confirmation and contribution.
It took me some times to process many mails after christmas holiday.
And sorry for long delays in review process.
master:
Hi Lukas,
Just wanted to confirm your patch works for me.
Kind regards,
Victor
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Hi, I was out last week, sorry for the delay!
The patch looks good to me, I'll try to test it too as soon as I find some time.
Thanks,
Victor
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
On (03/10/16 17:44), Victor Tapia wrote:
>Hi,
>
>I just removed the upstart part and left just the systemd notification
>with the fix for the latest master branch. I also fixed the evaluation
>of the return code of sd_notify from the original patch, so this should
>be the "good" one :).
>
>Thanks,
Hi Lukas,
please let me know if you need anything else for this patch.
Regards,
Victor
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
On (24/10/16 16:13), Victor Tapia wrote:
>Hi Lukas,
>
>could you review this patch and let me if it's ok as it is?
>
Sure,
I will need to test patch one more time
because when I was testing the patch in past
I could see some failures but they coudl be cause by bugs in 1.14 branch.
LS
Hi Lukas,
could you review this patch and let me if it's ok as it is?
Thanks,
Victor
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
El 03/10/16 a las 21:34, Jakub Hrozek escribió:
> On Mon, Oct 03, 2016 at 05:44:19PM +0200, Victor Tapia wrote:
>> Hi,
>>
>> I just removed the upstart part and left just the systemd notification
>> with the fix for the latest master branch. I also fixed the evaluation
>> of the return code of
On Mon, Oct 03, 2016 at 05:44:19PM +0200, Victor Tapia wrote:
> Hi,
>
> I just removed the upstart part and left just the systemd notification
> with the fix for the latest master branch. I also fixed the evaluation
> of the return code of sd_notify from the original patch, so this should
> be
Hi,
I just removed the upstart part and left just the systemd notification
with the fix for the latest master branch. I also fixed the evaluation
of the return code of sd_notify from the original patch, so this should
be the "good" one :).
Thanks,
Victor
El 22/09/16 a las 12:31, Jakub Hrozek
On Thu, Sep 22, 2016 at 10:07:21AM -, Victor Tapia wrote:
> Hi,
>
> I just saw that the ticket 3080 (https://fedorahosted.org/sssd/ticket/3080)
> has been closed with a different patch. Is this one landing too?
Sorry, that's my fault, I put a wrong URL into patches for #3140. I
reopened
Hi,
I just saw that the ticket 3080 (https://fedorahosted.org/sssd/ticket/3080) has
been closed with a different patch. Is this one landing too?
Thanks,
Victor
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an
El 08/09/16 a las 13:13, Lukas Slebodnik escribió:
> On (08/09/16 12:29), Victor Tapia wrote:
>> El 01/09/16 a las 14:50, Lukas Slebodnik escribió:
>>> On (26/08/16 13:16), Victor Tapia wrote:
Hi,
Sorry for the late response, I've been out for nearly two weeks. I'm
attaching a
On (08/09/16 12:29), Victor Tapia wrote:
>El 01/09/16 a las 14:50, Lukas Slebodnik escribió:
>> On (26/08/16 13:16), Victor Tapia wrote:
>>> Hi,
>>>
>>> Sorry for the late response, I've been out for nearly two weeks. I'm
>>> attaching a new version of the patch to review.
>>>
Does
El 01/09/16 a las 14:50, Lukas Slebodnik escribió:
> On (26/08/16 13:16), Victor Tapia wrote:
>> Hi,
>>
>> Sorry for the late response, I've been out for nearly two weeks. I'm
>> attaching a new version of the patch to review.
>>
>>> Does upstart/init script need to be updated as well?
>>> We have
On (26/08/16 13:16), Victor Tapia wrote:
>Hi,
>
>Sorry for the late response, I've been out for nearly two weeks. I'm
>attaching a new version of the patch to review.
>
>> Does upstart/init script need to be updated as well?
>> We have some generic in src/sysv/sssd.in
>
>Upstart does need to keep
On (26/08/16 13:16), Victor Tapia wrote:
>Hi,
>
>Sorry for the late response, I've been out for nearly two weeks. I'm
>attaching a new version of the patch to review.
>
>> Does upstart/init script need to be updated as well?
>> We have some generic in src/sysv/sssd.in
>
>Upstart does need to keep
Hi,
Sorry for the late response, I've been out for nearly two weeks. I'm
attaching a new version of the patch to review.
> Does upstart/init script need to be updated as well?
> We have some generic in src/sysv/sssd.in
Upstart does need to keep track of the pidfile creation. I can't see a
On (12/08/16 16:08), Victor Tapia wrote:
>
>>>
>>> I haven't tried using "Type=notify", but I don't think it would make a
>>> difference if we can't hold the notification signal until the responders
>>> are running.
>>>
>> You would need to call sd_*notify function after initialisation of
>>
>> I haven't tried using "Type=notify", but I don't think it would make a
>> difference if we can't hold the notification signal until the responders
>> are running.
>>
> You would need to call sd_*notify function after initialisation of responders
> man 3 sd_notify
>
On (12/08/16 14:34), Victor Tapia wrote:
>Hi Lukas,
>
>> I tried to look into systemd documentation and I could not see
>> anything in documentation which would say that it is a reliable
>> way to use a pid file. (It might change in future if it is not documented)
>>
>> man systemd.service says
Hi Lukas,
> I tried to look into systemd documentation and I could not see
> anything in documentation which would say that it is a reliable
> way to use a pid file. (It might change in future if it is not documented)
>
> man systemd.service says
>If set to forking, it is expected
On (12/08/16 11:48), Victor Tapia wrote:
>Hi list,
>
>The attached patch covers ticket #3080
>(https://fedorahosted.org/sssd/ticket/3080). It's based on the following
>commit:
>https://git.fedorahosted.org/cgit/sssd.git/commit/?id=d19c4785215305e6eb5f2fa2fc503a2ba50d3f10
>
>
>Currently, systemd
23 matches
Mail list logo
